@cesium/engine 2.0.0 → 2.2.0

package/Source/DataSources/KmlDataSource.js

@@ -3539,29 +3539,29 @@ function load(dataSource, entityCollection, data, options) {
 // https://github.com/microsoft/TypeScript/issues/20077 and/or
 // https://github.com/jsdoc/jsdoc/issues/1199 actually get resolved
 /**
- * @typedef {Object} KmlDataSource.LoadOptions
+ * @typedef {object} KmlDataSource.LoadOptions
  *
  * Initialization options for the `load` method.
  *
- * @property {String} [sourceUri] Overrides the url to use for resolving relative links and other KML network features.
- * @property {Boolean} [clampToGround=false] true if we want the geometry features (Polygons, LineStrings and LinearRings) clamped to the ground.
+ * @property {string} [sourceUri] Overrides the url to use for resolving relative links and other KML network features.
+ * @property {boolean} [clampToGround=false] true if we want the geometry features (Polygons, LineStrings and LinearRings) clamped to the ground.
  * @property {Ellipsoid} [ellipsoid=Ellipsoid.WGS84] The global ellipsoid used for geographical calculations.
- * @property {Element|String} [screenOverlayContainer] A container for ScreenOverlay images.
+ * @property {Element|string} [screenOverlayContainer] A container for ScreenOverlay images.
  */
 
 /**
- * @typedef {Object} KmlDataSource.ConstructorOptions
+ * @typedef {object} KmlDataSource.ConstructorOptions
  *
  * Options for constructing a new KmlDataSource, or calling the static `load` method.
  *
  * @property {Camera} [camera] The camera that is used for viewRefreshModes and sending camera properties to network links.
  * @property {HTMLCanvasElement} [canvas] The canvas that is used for sending viewer properties to network links.
- * @property {Credit|String} [credit] A credit for the data source, which is displayed on the canvas.
+ * @property {Credit|string} [credit] A credit for the data source, which is displayed on the canvas.
  *
- * @property {String} [sourceUri] Overrides the url to use for resolving relative links and other KML network features.
- * @property {Boolean} [clampToGround=false] true if we want the geometry features (Polygons, LineStrings and LinearRings) clamped to the ground.
+ * @property {string} [sourceUri] Overrides the url to use for resolving relative links and other KML network features.
+ * @property {boolean} [clampToGround=false] true if we want the geometry features (Polygons, LineStrings and LinearRings) clamped to the ground.
  * @property {Ellipsoid} [ellipsoid=Ellipsoid.WGS84] The global ellipsoid used for geographical calculations.
- * @property {Element|String} [screenOverlayContainer] A container for ScreenOverlay images.
+ * @property {Element|string} [screenOverlayContainer] A container for ScreenOverlay images.
 
 */
 
@@ -3667,10 +3667,10 @@ function KmlDataSource(options) {
 /**
  * Creates a Promise to a new instance loaded with the provided KML data.
  *
- * @param {Resource|String|Document|Blob} data A url, parsed KML document, or Blob containing binary KMZ data or a parsed KML document.
+ * @param {Resource|string|Document|Blob} data A url, parsed KML document, or Blob containing binary KMZ data or a parsed KML document.
  * @param {KmlDataSource.ConstructorOptions} [options] An object specifying configuration options
  *
- * @returns {Promise.<KmlDataSource>} A promise that will resolve to a new KmlDataSource instance once the KML is loaded.
+ * @returns {Promise<KmlDataSource>} A promise that will resolve to a new KmlDataSource instance once the KML is loaded.
  */
 KmlDataSource.load = function (data, options) {
   options = defaultValue(options, defaultValue.EMPTY_OBJECT);
@@ -3683,7 +3683,7 @@ Object.defineProperties(KmlDataSource.prototype, {
    * Gets or sets a human-readable name for this instance.
    * This will be automatically be set to the KML document name on load.
    * @memberof KmlDataSource.prototype
-   * @type {String}
+   * @type {string}
    */
   name: {
     get: function () {
@@ -3721,7 +3721,7 @@ Object.defineProperties(KmlDataSource.prototype, {
   /**
    * Gets a value indicating if the data source is currently loading data.
    * @memberof KmlDataSource.prototype
-   * @type {Boolean}
+   * @type {boolean}
    */
   isLoading: {
     get: function () {
@@ -3781,7 +3781,7 @@ Object.defineProperties(KmlDataSource.prototype, {
   /**
    * Gets whether or not this data source should be displayed.
    * @memberof KmlDataSource.prototype
-   * @type {Boolean}
+   * @type {boolean}
    */
   show: {
     get: function () {
@@ -3836,10 +3836,10 @@ Object.defineProperties(KmlDataSource.prototype, {
 /**
  * Asynchronously loads the provided KML data, replacing any existing data.
  *
- * @param {Resource|String|Document|Blob} data A url, parsed KML document, or Blob containing binary KMZ data or a parsed KML document.
+ * @param {Resource|string|Document|Blob} data A url, parsed KML document, or Blob containing binary KMZ data or a parsed KML document.
  * @param {KmlDataSource.LoadOptions} [options] An object specifying configuration options
  *
- * @returns {Promise.<KmlDataSource>} A promise that will resolve to this instances once the KML is loaded.
+ * @returns {Promise<KmlDataSource>} A promise that will resolve to this instances once the KML is loaded.
  */
 KmlDataSource.prototype.load = function (data, options) {
   //>>includeStart('debug', pragmas.debug);
@@ -4113,7 +4113,7 @@ const entitiesToIgnore = new AssociativeArray();
  * Updates any NetworkLink that require updating.
  *
  * @param {JulianDate} time The simulation time.
- * @returns {Boolean} True if this data source is ready to be displayed at the provided time, false otherwise.
+ * @returns {boolean} True if this data source is ready to be displayed at the provided time, false otherwise.
  */
 KmlDataSource.prototype.update = function (time) {
   const networkLinks = this._networkLinks;
@@ -4253,10 +4253,10 @@ KmlDataSource.prototype.update = function (time) {
 function KmlFeatureData() {
   /**
    * @typedef KmlFeatureData.Author
-   * @type {Object}
-   * @property {String} name Gets the name.
-   * @property {String} uri Gets the URI.
-   * @property {Number} age Gets the email.
+   * @type {object}
+   * @property {string} name Gets the name.
+   * @property {string} uri Gets the URI.
+   * @property {number} age Gets the email.
    */
 
   /**
@@ -4271,13 +4271,13 @@ function KmlFeatureData() {
 
   /**
    * @typedef KmlFeatureData.Link
-   * @type {Object}
-   * @property {String} href Gets the href.
-   * @property {String} hreflang Gets the language of the linked resource.
-   * @property {String} rel Gets the link relation.
-   * @property {String} type Gets the link type.
-   * @property {String} title Gets the link title.
-   * @property {String} length Gets the link length.
+   * @type {object}
+   * @property {string} href Gets the href.
+   * @property {string} hreflang Gets the language of the linked resource.
+   * @property {string} rel Gets the link relation.
+   * @property {string} type Gets the link type.
+   * @property {string} title Gets the link title.
+   * @property {string} length Gets the link length.
    */
 
   /**
@@ -4295,24 +4295,24 @@ function KmlFeatureData() {
 
   /**
    * Gets the unstructured address field.
-   * @type {String}
+   * @type {string}
    */
   this.address = undefined;
   /**
    * Gets the phone number.
-   * @type {String}
+   * @type {string}
    */
   this.phoneNumber = undefined;
   /**
    * Gets the snippet.
-   * @type {String}
+   * @type {string}
    */
   this.snippet = undefined;
   /**
    * Gets the extended data, parsed into a JSON object.
    * Currently only the <code>Data</code> property is supported.
    * <code>SchemaData</code> and custom data are ignored.
-   * @type {String}
+   * @type {string}
    */
   this.extendedData = undefined;
 }

package/Source/DataSources/KmlTour.js

@@ -8,8 +8,8 @@ import Event from "../Core/Event.js";
  * @alias KmlTour
  * @constructor
  *
- * @param {String} name name parsed from KML
- * @param {String} id id parsed from KML
+ * @param {string} name name parsed from KML
+ * @param {string} id id parsed from KML
  * @param {Array} playlist array with KmlTourFlyTos and KmlTourWaits
  *
  * @see KmlTourFlyTo
@@ -20,22 +20,22 @@ import Event from "../Core/Event.js";
 function KmlTour(name, id) {
   /**
    * Id of kml gx:Tour entry
-   * @type String
+   * @type {string}
    */
   this.id = id;
   /**
    * Tour name
-   * @type String
+   * @type {string}
    */
   this.name = name;
   /**
    * Index of current entry from playlist
-   * @type Number
+   * @type {number}
    */
   this.playlistIndex = 0;
   /**
    * Array of playlist entries
-   * @type Array
+   * @type {Array}
    */
   this.playlist = [];
   /**
@@ -86,7 +86,7 @@ KmlTour.prototype.addPlaylistEntry = function (entry) {
  * Play this tour.
  *
  * @param {Viewer|CesiumWidget} widget The widget.
- * @param {Object} [cameraOptions] these options will be merged with {@link Camera#flyTo}
+ * @param {object} [cameraOptions] these options will be merged with {@link Camera#flyTo}
  * options for FlyTo playlist entries.
  */
 KmlTour.prototype.play = function (widget, cameraOptions) {

package/Source/DataSources/KmlTourFlyTo.js

@@ -9,8 +9,8 @@ import EasingFunction from "../Core/EasingFunction.js";
  * @alias KmlTourFlyTo
  * @constructor
  *
- * @param {Number} duration entry duration
- * @param {String} flyToMode KML fly to mode: bounce, smooth, etc
+ * @param {number} duration entry duration
+ * @param {string} flyToMode KML fly to mode: bounce, smooth, etc
  * @param {KmlCamera|KmlLookAt} view KmlCamera or KmlLookAt
  *
  * @see KmlTour
@@ -32,7 +32,7 @@ function KmlTourFlyTo(duration, flyToMode, view) {
  *
  * @param {KmlTourFlyTo.DoneCallback} done function which will be called when playback ends
  * @param {Camera} camera Cesium camera
- * @param {Object} [cameraOptions] which will be merged with camera flyTo options. See {@link Camera#flyTo}
+ * @param {object} [cameraOptions] which will be merged with camera flyTo options. See {@link Camera#flyTo}
  */
 KmlTourFlyTo.prototype.play = function (done, camera, cameraOptions) {
   this.activeCamera = camera;
@@ -70,8 +70,8 @@ KmlTourFlyTo.prototype.stop = function () {
  * Returns options for {@link Camera#flyTo} or {@link Camera#flyToBoundingSphere}
  * depends on this.view type.
  *
- * @param {Object} cameraOptions options to merge with generated. See {@link Camera#flyTo}
- * @returns {Object} {@link Camera#flyTo} or {@link Camera#flyToBoundingSphere} options
+ * @param {object} cameraOptions options to merge with generated. See {@link Camera#flyTo}
+ * @returns {object} {@link Camera#flyTo} or {@link Camera#flyToBoundingSphere} options
  */
 KmlTourFlyTo.prototype.getCameraOptions = function (cameraOptions) {
   let options = {
@@ -103,7 +103,7 @@ KmlTourFlyTo.prototype.getCameraOptions = function (cameraOptions) {
  * A function that will be executed when the flight completes.
  * @callback KmlTourFlyTo.DoneCallback
  *
- * @param {Boolean} terminated true if {@link KmlTourFlyTo#stop} was
+ * @param {boolean} terminated true if {@link KmlTourFlyTo#stop} was
  * called before entry done playback.
  */
 export default KmlTourFlyTo;

package/Source/DataSources/KmlTourWait.js

@@ -5,7 +5,7 @@ import defined from "../Core/defined.js";
  * @alias KmlTourWait
  * @constructor
  *
- * @param {Number} duration entry duration
+ * @param {number} duration entry duration
  *
  * @see KmlTour
  * @see KmlTourFlyTo
@@ -46,7 +46,7 @@ KmlTourWait.prototype.stop = function () {
  * A function which will be called when playback ends.
  *
  * @callback KmlTourWait.DoneCallback
- * @param {Boolean} terminated true if {@link KmlTourWait#stop} was
+ * @param {boolean} terminated true if {@link KmlTourWait#stop} was
  * called before entry done playback.
  */
 export default KmlTourWait;

package/Source/DataSources/LabelGraphics.js

@@ -5,7 +5,7 @@ import Event from "../Core/Event.js";
 import createPropertyDescriptor from "./createPropertyDescriptor.js";
 
 /**
- * @typedef {Object} LabelGraphics.ConstructorOptions
+ * @typedef {object} LabelGraphics.ConstructorOptions
  *
  * Initialization options for the LabelGraphics constructor
  *

package/Source/DataSources/LabelVisualizer.js

@@ -84,7 +84,7 @@ function LabelVisualizer(entityCluster, entityCollection) {
  * Entity counterpart at the given time.
  *
  * @param {JulianDate} time The time to update to.
- * @returns {Boolean} This function always returns true.
+ * @returns {boolean} This function always returns true.
  */
 LabelVisualizer.prototype.update = function (time) {
   //>>includeStart('debug', pragmas.debug);
@@ -293,7 +293,7 @@ LabelVisualizer.prototype.getBoundingSphere = function (entity, result) {
 /**
  * Returns true if this object was destroyed; otherwise, false.
  *
- * @returns {Boolean} True if this object was destroyed; otherwise, false.
+ * @returns {boolean} True if this object was destroyed; otherwise, false.
  */
 LabelVisualizer.prototype.isDestroyed = function () {
   return false;

package/Source/DataSources/MaterialProperty.js

@@ -29,7 +29,7 @@ Object.defineProperties(MaterialProperty.prototype, {
    * constant if getValue always returns the same result for the current definition.
    * @memberof MaterialProperty.prototype
    *
-   * @type {Boolean}
+   * @type {boolean}
    * @readonly
    */
   isConstant: {
@@ -54,7 +54,7 @@ Object.defineProperties(MaterialProperty.prototype, {
  * @function
  *
  * @param {JulianDate} time The time for which to retrieve the type.
- * @returns {String} The type of material.
+ * @returns {string} The type of material.
  */
 MaterialProperty.prototype.getType = DeveloperError.throwInstantiationError;
 
@@ -63,8 +63,8 @@ MaterialProperty.prototype.getType = DeveloperError.throwInstantiationError;
  * @function
  *
  * @param {JulianDate} time The time for which to retrieve the value.
- * @param {Object} [result] The object to store the value into, if omitted, a new instance is created and returned.
- * @returns {Object} The modified result parameter or a new instance if the result parameter was not supplied.
+ * @param {object} [result] The object to store the value into, if omitted, a new instance is created and returned.
+ * @returns {object} The modified result parameter or a new instance if the result parameter was not supplied.
  */
 MaterialProperty.prototype.getValue = DeveloperError.throwInstantiationError;
 
@@ -74,7 +74,7 @@ MaterialProperty.prototype.getValue = DeveloperError.throwInstantiationError;
  * @function
  *
  * @param {Property} [other] The other property.
- * @returns {Boolean} <code>true</code> if left and right are equal, <code>false</code> otherwise.
+ * @returns {boolean} <code>true</code> if left and right are equal, <code>false</code> otherwise.
  */
 MaterialProperty.prototype.equals = DeveloperError.throwInstantiationError;
 

package/Source/DataSources/ModelGraphics.js

@@ -19,7 +19,7 @@ function createArticulationStagePropertyBag(value) {
 }
 
 /**
- * @typedef {Object} ModelGraphics.ConstructorOptions
+ * @typedef {object} ModelGraphics.ConstructorOptions
  *
  * Initialization options for the ModelGraphics constructor
  *
@@ -41,8 +41,8 @@ function createArticulationStagePropertyBag(value) {
  * @property {Property | Cartesian2} [imageBasedLightingFactor=new Cartesian2(1.0, 1.0)] A property specifying the contribution from diffuse and specular image-based lighting.
  * @property {Property | Color} [lightColor] A property specifying the light color when shading the model. When <code>undefined</code> the scene's light color is used instead.
  * @property {Property | DistanceDisplayCondition} [distanceDisplayCondition] A Property specifying at what distance from the camera that this model will be displayed.
- * @property {PropertyBag | Object.<string, TranslationRotationScale>} [nodeTransformations] An object, where keys are names of nodes, and values are {@link TranslationRotationScale} Properties describing the transformation to apply to that node. The transformation is applied after the node's existing transformation as specified in the glTF, and does not replace the node's existing transformation.
- * @property {PropertyBag | Object.<string, number>} [articulations] An object, where keys are composed of an articulation name, a single space, and a stage name, and the values are numeric properties.
+ * @property {PropertyBag | Object<string, TranslationRotationScale>} [nodeTransformations] An object, where keys are names of nodes, and values are {@link TranslationRotationScale} Properties describing the transformation to apply to that node. The transformation is applied after the node's existing transformation as specified in the glTF, and does not replace the node's existing transformation.
+ * @property {PropertyBag | Object<string, number>} [articulations] An object, where keys are composed of an articulation name, a single space, and a stage name, and the values are numeric properties.
  * @property {Property | ClippingPlaneCollection} [clippingPlanes] A property specifying the {@link ClippingPlaneCollection} used to selectively disable rendering the model.
  * @property {Property | CustomShader} [customShader] A property specifying the {@link CustomShader} to apply to this model.
  */

package/Source/DataSources/ModelVisualizer.js

@@ -36,6 +36,9 @@ const modelMatrixScratch = new Matrix4();
 const nodeMatrixScratch = new Matrix4();
 
 const scratchColor = new Color();
+const scratchArray = new Array(4);
+const scratchCartesian = new Cartesian3();
+
 /**
  * A {@link Visualizer} which maps {@link Entity#model} to a {@link Model}.
  * @alias ModelVisualizer
@@ -63,12 +66,58 @@ function ModelVisualizer(scene, entityCollection) {
   this._onCollectionChanged(entityCollection, entityCollection.values, [], []);
 }
 
+async function createModelPrimitive(
+  visualizer,
+  entity,
+  resource,
+  incrementallyLoadTextures
+) {
+  const primitives = visualizer._primitives;
+  const modelHash = visualizer._modelHash;
+
+  try {
+    const model = await Model.fromGltfAsync({
+      url: resource,
+      incrementallyLoadTextures: incrementallyLoadTextures,
+      scene: visualizer._scene,
+    });
+
+    if (visualizer.isDestroyed() || !defined(modelHash[entity.id])) {
+      return;
+    }
+
+    model.id = entity;
+    primitives.add(model);
+    modelHash[entity.id].modelPrimitive = model;
+    model.errorEvent.addEventListener((error) => {
+      if (!defined(modelHash[entity.id])) {
+        return;
+      }
+
+      console.log(error);
+
+      // Texture failures when incrementallyLoadTextures
+      // will not affect the ability to compute the bounding sphere
+      if (error.name !== "TextureError" && model.incrementallyLoadTextures) {
+        modelHash[entity.id].loadFailed = true;
+      }
+    });
+  } catch (error) {
+    if (visualizer.isDestroyed() || !defined(modelHash[entity.id])) {
+      return;
+    }
+
+    console.log(error);
+    modelHash[entity.id].loadFailed = true;
+  }
+}
+
 /**
  * Updates models created this visualizer to match their
  * Entity counterpart at the given time.
  *
  * @param {JulianDate} time The time to update to.
- * @returns {Boolean} This function always returns true.
+ * @returns {boolean} This function always returns true.
  */
 ModelVisualizer.prototype.update = function (time) {
   //>>includeStart('debug', pragmas.debug);
@@ -102,45 +151,44 @@ ModelVisualizer.prototype.update = function (time) {
     }
 
     if (!show) {
-      if (defined(modelData)) {
+      if (defined(modelData) && modelData.modelPrimitive) {
         modelData.modelPrimitive.show = false;
       }
       continue;
     }
 
-    let model = defined(modelData) ? modelData.modelPrimitive : undefined;
-    if (!defined(model) || resource.url !== modelData.url) {
-      if (defined(model)) {
-        primitives.removeAndDestroy(model);
+    if (!defined(modelData) || resource.url !== modelData.url) {
+      if (defined(modelData?.modelPrimitive)) {
+        primitives.removeAndDestroy(modelData.modelPrimitive);
         delete modelHash[entity.id];
       }
 
-      model = Model.fromGltf({
-        url: resource,
-        incrementallyLoadTextures: Property.getValueOrDefault(
-          modelGraphics._incrementallyLoadTextures,
-          time,
-          defaultIncrementallyLoadTextures
-        ),
-        scene: this._scene,
-      });
-      model.id = entity;
-      primitives.add(model);
-
       modelData = {
-        modelPrimitive: model,
+        modelPrimitive: undefined,
         url: resource.url,
         animationsRunning: false,
         nodeTransformationsScratch: {},
         articulationsScratch: {},
-        loadFail: false,
+        loadFailed: false,
+        modelUpdated: false,
         awaitingSampleTerrain: false,
         clampedBoundingSphere: undefined,
         sampleTerrainFailed: false,
       };
       modelHash[entity.id] = modelData;
 
-      checkModelLoad(model, entity, modelHash);
+      const incrementallyLoadTextures = Property.getValueOrDefault(
+        modelGraphics._incrementallyLoadTextures,
+        time,
+        defaultIncrementallyLoadTextures
+      );
+
+      createModelPrimitive(this, entity, resource, incrementallyLoadTextures);
+    }
+
+    const model = modelData.modelPrimitive;
+    if (!defined(model)) {
+      continue;
     }
 
     model.show = true;
@@ -214,15 +262,27 @@ ModelVisualizer.prototype.update = function (time) {
       time,
       defaultImageBasedLightingFactor
     );
-    model.lightColor = Property.getValueOrUndefined(
+    let lightColor = Property.getValueOrUndefined(
       modelGraphics._lightColor,
       time
     );
+
+    // Convert from Color to Cartesian3
+    if (defined(lightColor)) {
+      Color.pack(lightColor, scratchArray, 0);
+      lightColor = Cartesian3.unpack(scratchArray, 0, scratchCartesian);
+    }
+
+    model.lightColor = lightColor;
     model.customShader = Property.getValueOrUndefined(
       modelGraphics._customShader,
       time
     );
 
+    // It's possible for getBoundingSphere to run before
+    // model becomes ready and these properties are updated
+    modelHash[entity.id].modelUpdated = true;
+
     if (model.ready) {
       const runAnimations = Property.getValueOrDefault(
         modelGraphics._runAnimations,
@@ -315,7 +375,7 @@ ModelVisualizer.prototype.update = function (time) {
 /**
  * Returns true if this object was destroyed; otherwise, false.
  *
- * @returns {Boolean} True if this object was destroyed; otherwise, false.
+ * @returns {boolean} True if this object was destroyed; otherwise, false.
  */
 ModelVisualizer.prototype.isDestroyed = function () {
   return false;
@@ -365,18 +425,23 @@ ModelVisualizer.prototype.getBoundingSphere = function (entity, result) {
   //>>includeEnd('debug');
 
   const modelData = this._modelHash[entity.id];
-  if (!defined(modelData) || modelData.loadFail) {
+  if (!defined(modelData)) {
+    return BoundingSphereState.FAILED;
+  }
+
+  if (modelData.loadFailed) {
     return BoundingSphereState.FAILED;
   }
 
   const model = modelData.modelPrimitive;
   if (!defined(model) || !model.show) {
-    return BoundingSphereState.FAILED;
+    return BoundingSphereState.PENDING;
   }
 
-  if (!model.ready) {
+  if (!model.ready || !modelData.modelUpdated) {
     return BoundingSphereState.PENDING;
   }
+
   const scene = this._scene;
   const globe = scene.globe;
   const ellipsoid = globe.ellipsoid;
@@ -386,7 +451,8 @@ ModelVisualizer.prototype.getBoundingSphere = function (entity, result) {
   if (hasHeightReference) {
     // We cannot query the availability of the terrain provider till its ready, so the
     // bounding sphere state will remain pending till the terrain provider is ready.
-    if (!terrainProvider.ready) {
+    // ready is deprecated. This is here for backwards compatibility
+    if (!terrainProvider._ready) {
       return BoundingSphereState.PENDING;
     }
 
@@ -441,6 +507,10 @@ ModelVisualizer.prototype.getBoundingSphere = function (entity, result) {
           scratchCartographic,
         ])
           .then((result) => {
+            if (this.isDestroyed()) {
+              return;
+            }
+
             this._modelHash[entity.id].awaitingSampleTerrain = false;
 
             const updatedCartographic = result[0];
@@ -463,6 +533,10 @@ ModelVisualizer.prototype.getBoundingSphere = function (entity, result) {
             );
           })
           .catch((e) => {
+            if (this.isDestroyed()) {
+              return;
+            }
+
             this._modelHash[entity.id].sampleTerrainFailed = true;
             this._modelHash[entity.id].awaitingSampleTerrain = false;
           });
@@ -539,10 +613,4 @@ function clearNodeTransformationsArticulationsScratch(entity, modelHash) {
   }
 }
 
-function checkModelLoad(model, entity, modelHash) {
-  model.readyPromise.catch(function (error) {
-    console.error(error);
-    modelHash[entity.id].loadFail = true;
-  });
-}
 export default ModelVisualizer;

package/Source/DataSources/NodeTransformationProperty.js

@@ -12,7 +12,7 @@ const defaultNodeTransformation = new TranslationRotationScale();
  * @alias NodeTransformationProperty
  * @constructor
  *
- * @param {Object} [options] Object with the following properties:
+ * @param {object} [options] Object with the following properties:
  * @param {Property|Cartesian3} [options.translation=Cartesian3.ZERO] A {@link Cartesian3} Property specifying the (x, y, z) translation to apply to the node.
  * @param {Property|Quaternion} [options.rotation=Quaternion.IDENTITY] A {@link Quaternion} Property specifying the (x, y, z, w) rotation to apply to the node.
  * @param {Property|Cartesian3} [options.scale=new Cartesian3(1.0, 1.0, 1.0)] A {@link Cartesian3} Property specifying the (x, y, z) scaling to apply to the node.
@@ -39,7 +39,7 @@ Object.defineProperties(NodeTransformationProperty.prototype, {
    * constant if getValue always returns the same result for the current definition.
    * @memberof NodeTransformationProperty.prototype
    *
-   * @type {Boolean}
+   * @type {boolean}
    * @readonly
    */
   isConstant: {
@@ -130,7 +130,7 @@ NodeTransformationProperty.prototype.getValue = function (time, result) {
  * <code>true</code> if they are equal, <code>false</code> otherwise.
  *
  * @param {Property} [other] The other property.
- * @returns {Boolean} <code>true</code> if left and right are equal, <code>false</code> otherwise.
+ * @returns {boolean} <code>true</code> if left and right are equal, <code>false</code> otherwise.
  */
 NodeTransformationProperty.prototype.equals = function (other) {
   return (

package/Source/DataSources/PathGraphics.js

@@ -6,7 +6,7 @@ import createMaterialPropertyDescriptor from "./createMaterialPropertyDescriptor
 import createPropertyDescriptor from "./createPropertyDescriptor.js";
 
 /**
- * @typedef {Object} PathGraphics.ConstructorOptions
+ * @typedef {object} PathGraphics.ConstructorOptions
  *
  * Initialization options for the PathGraphics constructor
  *

package/Source/DataSources/PathVisualizer.js

@@ -612,7 +612,7 @@ function PathVisualizer(scene, entityCollection) {
  * Entity counterpart at the given time.
  *
  * @param {JulianDate} time The time to update to.
- * @returns {Boolean} This function always returns true.
+ * @returns {boolean} This function always returns true.
  */
 PathVisualizer.prototype.update = function (time) {
   //>>includeStart('debug', pragmas.debug);
@@ -682,7 +682,7 @@ PathVisualizer.prototype.update = function (time) {
 /**
  * Returns true if this object was destroyed; otherwise, false.
  *
- * @returns {Boolean} True if this object was destroyed; otherwise, false.
+ * @returns {boolean} True if this object was destroyed; otherwise, false.
  */
 PathVisualizer.prototype.isDestroyed = function () {
   return false;

package/Source/DataSources/PlaneGraphics.js

@@ -6,7 +6,7 @@ import createMaterialPropertyDescriptor from "./createMaterialPropertyDescriptor
 import createPropertyDescriptor from "./createPropertyDescriptor.js";
 
 /**
- * @typedef {Object} PlaneGraphics.ConstructorOptions
+ * @typedef {object} PlaneGraphics.ConstructorOptions
  *
  * Initialization options for the PlaneGraphics constructor
  *