@cesium/engine 2.0.0 → 2.2.0

package/Source/Scene/Model/Model3DTileContent.js

@@ -2,6 +2,7 @@ import Color from "../../Core/Color.js";
 import combine from "../../Core/combine.js";
 import defined from "../../Core/defined.js";
 import destroyObject from "../../Core/destroyObject.js";
+import deprecationWarning from "../../Core/deprecationWarning.js";
 import DeveloperError from "../../Core/DeveloperError.js";
 import Pass from "../../Renderer/Pass.js";
 import ModelAnimationLoop from "../ModelAnimationLoop.js";
@@ -14,6 +15,8 @@ import Model from "./Model.js";
  * <p>
  * Implements the {@link Cesium3DTileContent} interface.
  * </p>
+ * This object is normally not instantiated directly, use {@link Model3DTileContent.fromGltf}, {@link Model3DTileContent.fromB3dm}, {@link Model3DTileContent.fromI3dm}, {@link Model3DTileContent.fromPnts}, or {@link Model3DTileContent.fromGeoJson}.
+ *
  * @alias Model3DTileContent
  * @constructor
  * @private
@@ -24,9 +27,12 @@ function Model3DTileContent(tileset, tile, resource) {
   this._resource = resource;
 
   this._model = undefined;
-  this._readyPromise = undefined;
   this._metadata = undefined;
   this._group = undefined;
+  this._ready = false;
+
+  this._resolveContent = undefined;
+  this._readyPromise = undefined;
 }
 
 Object.defineProperties(Model3DTileContent.prototype, {
@@ -83,8 +89,37 @@ Object.defineProperties(Model3DTileContent.prototype, {
     },
   },
 
+  /**
+   * Returns true when the tile's content is ready to render; otherwise false
+   *
+   * @memberof Model3DTileContent.prototype
+   *
+   * @type {boolean}
+   * @readonly
+   * @private
+   */
+  ready: {
+    get: function () {
+      return this._ready;
+    },
+  },
+
+  /**
+   * Gets the promise that will be resolved when the tile's content is ready to render.
+   *
+   * @memberof Model3DTileContent.prototype
+   *
+   * @type {Promise<Model3DTileContent>}
+   * @readonly
+   * @deprecated
+   * @private
+   */
   readyPromise: {
     get: function () {
+      deprecationWarning(
+        "Model3DTileContent.readyPromise",
+        "Model3DTileContent.readyPromise was deprecated in CesiumJS 1.104. It will be removed in 1.107. Wait for Model3DTileContent.ready to return true instead."
+      );
       return this._readyPromise;
     },
   },
@@ -244,6 +279,16 @@ Model3DTileContent.prototype.update = function (tileset, frameState) {
   }
 
   model.update(frameState);
+
+  if (!this._ready && model.ready) {
+    // Animation can only be added once the model is ready
+    model.activeAnimations.addAll({
+      loop: ModelAnimationLoop.REPEAT,
+    });
+
+    this._ready = true;
+    this._resolveContent = this._resolveContent && this._resolveContent(this);
+  }
 };
 
 Model3DTileContent.prototype.isDestroyed = function () {
@@ -255,7 +300,7 @@ Model3DTileContent.prototype.destroy = function () {
   return destroyObject(this);
 };
 
-Model3DTileContent.fromGltf = function (tileset, tile, resource, gltf) {
+Model3DTileContent.fromGltf = async function (tileset, tile, resource, gltf) {
   const content = new Model3DTileContent(tileset, tile, resource);
 
   const additionalOptions = {
@@ -276,20 +321,18 @@ Model3DTileContent.fromGltf = function (tileset, tile, resource, gltf) {
 
   modelOptions.classificationType = classificationType;
 
-  const model = Model.fromGltf(modelOptions);
+  const model = await Model.fromGltfAsync(modelOptions);
   content._model = model;
-  // Include the animation setup in the ready promise to avoid an uncaught exception
-  content._readyPromise = model.readyPromise.then(function (model) {
-    model.activeAnimations.addAll({
-      loop: ModelAnimationLoop.REPEAT,
-    });
-    return model;
+
+  // This is for backwards compatibility. It can be removed once readyPromise is removed.
+  content._readyPromise = new Promise((resolve) => {
+    content._resolveContent = resolve;
   });
 
   return content;
 };
 
-Model3DTileContent.fromB3dm = function (
+Model3DTileContent.fromB3dm = async function (
   tileset,
   tile,
   resource,
@@ -317,20 +360,18 @@ Model3DTileContent.fromB3dm = function (
 
   modelOptions.classificationType = classificationType;
 
-  const model = Model.fromB3dm(modelOptions);
+  const model = await Model.fromB3dm(modelOptions);
   content._model = model;
-  // Include the animation setup in the ready promise to avoid an uncaught exception
-  content._readyPromise = model.readyPromise.then(function (model) {
-    model.activeAnimations.addAll({
-      loop: ModelAnimationLoop.REPEAT,
-    });
-    return model;
+
+  // This is for backwards compatibility. It can be removed once readyPromise is removed.
+  content._readyPromise = new Promise((resolve) => {
+    content._resolveContent = resolve;
   });
 
   return content;
 };
 
-Model3DTileContent.fromI3dm = function (
+Model3DTileContent.fromI3dm = async function (
   tileset,
   tile,
   resource,
@@ -352,20 +393,18 @@ Model3DTileContent.fromI3dm = function (
     additionalOptions
   );
 
-  const model = Model.fromI3dm(modelOptions);
+  const model = await Model.fromI3dm(modelOptions);
   content._model = model;
-  // Include the animation setup in the ready promise to avoid an uncaught exception
-  content._readyPromise = model.readyPromise.then(function (model) {
-    model.activeAnimations.addAll({
-      loop: ModelAnimationLoop.REPEAT,
-    });
-    return model;
+
+  // This is for backwards compatibility. It can be removed once readyPromise is removed.
+  content._readyPromise = new Promise((resolve) => {
+    content._resolveContent = resolve;
   });
 
   return content;
 };
 
-Model3DTileContent.fromPnts = function (
+Model3DTileContent.fromPnts = async function (
   tileset,
   tile,
   resource,
@@ -386,14 +425,23 @@ Model3DTileContent.fromPnts = function (
     content,
     additionalOptions
   );
-  const model = Model.fromPnts(modelOptions);
+  const model = await Model.fromPnts(modelOptions);
   content._model = model;
-  content._readyPromise = model.readyPromise;
+
+  // This is for backwards compatibility. It can be removed once readyPromise is removed.
+  content._readyPromise = new Promise((resolve) => {
+    content._resolveContent = resolve;
+  });
 
   return content;
 };
 
-Model3DTileContent.fromGeoJson = function (tileset, tile, resource, geoJson) {
+Model3DTileContent.fromGeoJson = async function (
+  tileset,
+  tile,
+  resource,
+  geoJson
+) {
   const content = new Model3DTileContent(tileset, tile, resource);
 
   const additionalOptions = {
@@ -407,9 +455,13 @@ Model3DTileContent.fromGeoJson = function (tileset, tile, resource, geoJson) {
     content,
     additionalOptions
   );
-  const model = Model.fromGeoJson(modelOptions);
+  const model = await Model.fromGeoJson(modelOptions);
   content._model = model;
-  content._readyPromise = model.readyPromise;
+
+  // This is for backwards compatibility. It can be removed once readyPromise is removed.
+  content._readyPromise = new Promise((resolve) => {
+    content._resolveContent = resolve;
+  });
 
   return content;
 };

package/Source/Scene/Model/ModelAlphaOptions.js

@@ -17,7 +17,7 @@ function ModelAlphaOptions() {
   /**
    * Determines the alpha threshold below which fragments are discarded
    *
-   * @type {Number}
+   * @type {number}
    * @private
    */
   this.alphaCutoff = undefined;

package/Source/Scene/Model/ModelAnimation.js

@@ -37,7 +37,7 @@ function ModelAnimation(model, animation, options) {
    * This is slightly more efficient that not removing it, but if, for example,
    * time is reversed, the animation is not played again.
    *
-   * @type {Boolean}
+   * @type {boolean}
    * @default false
    */
   this.removeOnStop = defaultValue(options.removeOnStop, false);
@@ -149,7 +149,7 @@ Object.defineProperties(ModelAnimation.prototype, {
    *
    * @memberof ModelAnimation.prototype
    *
-   * @type {String}
+   * @type {string}
    * @readonly
    */
   name: {
@@ -196,7 +196,7 @@ Object.defineProperties(ModelAnimation.prototype, {
    *
    * @memberof ModelAnimation.prototype
    *
-   * @type {Number}
+   * @type {number}
    * @readonly
    *
    * @private
@@ -213,7 +213,7 @@ Object.defineProperties(ModelAnimation.prototype, {
    *
    * @memberof ModelAnimation.prototype
    *
-   * @type {Number}
+   * @type {number}
    * @readonly
    *
    * @private
@@ -246,7 +246,7 @@ Object.defineProperties(ModelAnimation.prototype, {
    *
    * @memberof ModelAnimation.prototype
    *
-   * @type {Number}
+   * @type {number}
    * @readonly
    *
    * @default undefined
@@ -284,7 +284,7 @@ Object.defineProperties(ModelAnimation.prototype, {
    *
    * @memberof ModelAnimation.prototype
    *
-   * @type {Number}
+   * @type {number}
    * @readonly
    *
    * @default 1.0
@@ -300,7 +300,7 @@ Object.defineProperties(ModelAnimation.prototype, {
    *
    * @memberof ModelAnimation.prototype
    *
-   * @type {Boolean}
+   * @type {boolean}
    * @readonly
    *
    * @default false
@@ -387,7 +387,7 @@ function initialize(runtimeAnimation) {
 /**
  * Evaluate all animation channels to advance this animation.
  *
- * @param {Number} time The local animation time.
+ * @param {number} time The local animation time.
  *
  * @private
  */
@@ -403,9 +403,9 @@ ModelAnimation.prototype.animate = function (time) {
  * A function used to compute the local animation time for a ModelAnimation.
  * @callback ModelAnimation.AnimationTimeCallback
  *
- * @param {Number} duration The animation's original duration in seconds.
- * @param {Number} seconds The seconds since the animation started, in scene time.
- * @returns {Number} Returns the local animation time.
+ * @param {number} duration The animation's original duration in seconds.
+ * @param {number} seconds The seconds since the animation started, in scene time.
+ * @returns {number} Returns the local animation time.
  *
  * @example
  * // Use real time for model animation (assuming animateWhilePaused was set to true)

package/Source/Scene/Model/ModelAnimationChannel.js

@@ -18,7 +18,7 @@ const AnimatedPropertyType = ModelComponents.AnimatedPropertyType;
  * channel is responsible for interpolating between the keyframe values of an animated
  * property, then applying the change to the target node.
  *
- * @param {Object} options An object containing the following options:
+ * @param {object} options An object containing the following options:
  * @param {ModelComponents.AnimationChannel} options.channel The corresponding animation channel components from the 3D model.
  * @param {ModelAnimation} options.runtimeAnimation The runtime animation containing this channel.
  * @param {ModelRuntimeNode} options.runtimeNode The runtime node that this channel will animate.
@@ -254,7 +254,7 @@ function initialize(runtimeChannel) {
 /**
  * Animates the target node property based on its spline.
  *
- * @param {Number} time The local animation time.
+ * @param {number} time The local animation time.
  *
  * @private
  */

package/Source/Scene/Model/ModelAnimationCollection.js

@@ -56,7 +56,7 @@ function ModelAnimationCollection(model) {
    * to the model's animations. By default, this is based on scene time, so models using
    * the default will not animate regardless of this setting.
    *
-   * @type {Boolean}
+   * @type {boolean}
    * @default false
    */
   this.animateWhilePaused = false;
@@ -72,7 +72,7 @@ Object.defineProperties(ModelAnimationCollection.prototype, {
    *
    * @memberof ModelAnimationCollection.prototype
    *
-   * @type {Number}
+   * @type {number}
    * @readonly
    */
   length: {
@@ -110,20 +110,20 @@ function addAnimation(collection, animation, options) {
  * This raises the {@link ModelAnimationCollection#animationAdded} event so, for example, a UI can stay in sync.
  * </p>
  *
- * @param {Object} options Object with the following properties:
- * @param {String} [options.name] The glTF animation name that identifies the animation. Must be defined if <code>options.index</code> is <code>undefined</code>.
- * @param {Number} [options.index] The glTF animation index that identifies the animation. Must be defined if <code>options.name</code> is <code>undefined</code>.
+ * @param {object} options Object with the following properties:
+ * @param {string} [options.name] The glTF animation name that identifies the animation. Must be defined if <code>options.index</code> is <code>undefined</code>.
+ * @param {number} [options.index] The glTF animation index that identifies the animation. Must be defined if <code>options.name</code> is <code>undefined</code>.
  * @param {JulianDate} [options.startTime] The scene time to start playing the animation.  When this is <code>undefined</code>, the animation starts at the next frame.
- * @param {Number} [options.delay=0.0] The delay, in seconds, from <code>startTime</code> to start playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
+ * @param {number} [options.delay=0.0] The delay, in seconds, from <code>startTime</code> to start playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
  * @param {JulianDate} [options.stopTime] The scene time to stop playing the animation.  When this is <code>undefined</code>, the animation is played for its full duration.
- * @param {Boolean} [options.removeOnStop=false] When <code>true</code>, the animation is removed after it stops playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
- * @param {Number} [options.multiplier=1.0] Values greater than <code>1.0</code> increase the speed that the animation is played relative to the scene clock speed; values less than <code>1.0</code> decrease the speed.
- * @param {Boolean} [options.reverse=false] When <code>true</code>, the animation is played in reverse.
+ * @param {boolean} [options.removeOnStop=false] When <code>true</code>, the animation is removed after it stops playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
+ * @param {number} [options.multiplier=1.0] Values greater than <code>1.0</code> increase the speed that the animation is played relative to the scene clock speed; values less than <code>1.0</code> decrease the speed.
+ * @param {boolean} [options.reverse=false] When <code>true</code>, the animation is played in reverse.
  * @param {ModelAnimationLoop} [options.loop=ModelAnimationLoop.NONE] Determines if and how the animation is looped.
  * @param {ModelAnimation.AnimationTimeCallback} [options.animationTime=undefined] If defined, computes the local animation time for this animation.
  * @returns {ModelAnimation} The animation that was added to the collection.
  *
- * @exception {DeveloperError} Animations are not loaded.  Wait for the {@link Model#readyPromise} to resolve.
+ * @exception {DeveloperError} Animations are not loaded.  Wait for the {@link Model#ready} to return trues.
  * @exception {DeveloperError} options.name must be a valid animation name.
  * @exception {DeveloperError} options.index must be a valid animation index.
  * @exception {DeveloperError} Either options.name or options.index must be defined.
@@ -174,7 +174,7 @@ ModelAnimationCollection.prototype.add = function (options) {
   //>>includeStart('debug', pragmas.debug);
   if (!model.ready) {
     throw new DeveloperError(
-      "Animations are not loaded.  Wait for Model.readyPromise to resolve."
+      "Animations are not loaded.  Wait for Model.ready to be true."
     );
   }
   //>>includeEnd('debug');
@@ -230,13 +230,13 @@ ModelAnimationCollection.prototype.add = function (options) {
  * This raises the {@link ModelAnimationCollection#animationAdded} event for each model so, for example, a UI can stay in sync.
  * </p>
  *
- * @param {Object} [options] Object with the following properties:
+ * @param {object} [options] Object with the following properties:
  * @param {JulianDate} [options.startTime] The scene time to start playing the animations. When this is <code>undefined</code>, the animations starts at the next frame.
- * @param {Number} [options.delay=0.0] The delay, in seconds, from <code>startTime</code> to start playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
+ * @param {number} [options.delay=0.0] The delay, in seconds, from <code>startTime</code> to start playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
  * @param {JulianDate} [options.stopTime] The scene time to stop playing the animations. When this is <code>undefined</code>, the animations are played for its full duration.
- * @param {Boolean} [options.removeOnStop=false] When <code>true</code>, the animations are removed after they stop playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
- * @param {Number} [options.multiplier=1.0] Values greater than <code>1.0</code> increase the speed that the animations play relative to the scene clock speed; values less than <code>1.0</code> decrease the speed.
- * @param {Boolean} [options.reverse=false] When <code>true</code>, the animations are played in reverse.
+ * @param {boolean} [options.removeOnStop=false] When <code>true</code>, the animations are removed after they stop playing. This will only affect the animation if <code>options.loop</code> is ModelAnimationLoop.NONE.
+ * @param {number} [options.multiplier=1.0] Values greater than <code>1.0</code> increase the speed that the animations play relative to the scene clock speed; values less than <code>1.0</code> decrease the speed.
+ * @param {boolean} [options.reverse=false] When <code>true</code>, the animations are played in reverse.
  * @param {ModelAnimationLoop} [options.loop=ModelAnimationLoop.NONE] Determines if and how the animations are looped.
  * @param {ModelAnimation.AnimationTimeCallback} [options.animationTime=undefined] If defined, computes the local animation time for all of the animations.
  * @returns {ModelAnimation[]} An array of {@link ModelAnimation} objects, one for each animation added to the collection.  If there are no glTF animations, the array is empty.
@@ -258,7 +258,7 @@ ModelAnimationCollection.prototype.addAll = function (options) {
   //>>includeStart('debug', pragmas.debug);
   if (!model.ready) {
     throw new DeveloperError(
-      "Animations are not loaded.  Wait for Model.readyPromise to resolve."
+      "Animations are not loaded.  Wait for Model.ready to be true."
     );
   }
 
@@ -289,7 +289,7 @@ ModelAnimationCollection.prototype.addAll = function (options) {
  * </p>
  *
  * @param {ModelAnimation} runtimeAnimation The runtime animation to remove.
- * @returns {Boolean} <code>true</code> if the animation was removed; <code>false</code> if the animation was not found in the collection.
+ * @returns {boolean} <code>true</code> if the animation was removed; <code>false</code> if the animation was not found in the collection.
  *
  * @example
  * const a = model.activeAnimations.add({
@@ -336,7 +336,7 @@ ModelAnimationCollection.prototype.removeAll = function () {
  * Determines whether this collection contains a given animation.
  *
  * @param {ModelAnimation} runtimeAnimation The runtime animation to check for.
- * @returns {Boolean} <code>true</code> if this collection contains the animation, <code>false</code> otherwise.
+ * @returns {boolean} <code>true</code> if this collection contains the animation, <code>false</code> otherwise.
  */
 ModelAnimationCollection.prototype.contains = function (runtimeAnimation) {
   if (defined(runtimeAnimation)) {
@@ -352,7 +352,7 @@ ModelAnimationCollection.prototype.contains = function (runtimeAnimation) {
  * it to the left, changing their indices.  This function is commonly used to iterate over
  * all the animations in the collection.
  *
- * @param {Number} index The zero-based index of the animation.
+ * @param {number} index The zero-based index of the animation.
  * @returns {ModelAnimation} The runtime animation at the specified index.
  *
  * @example
@@ -396,7 +396,7 @@ function createAnimationRemovedFunction(
  * that have stopped.
  *
  * @param {FrameState} frameState The current frame state.
- * @returns {Boolean} <code>true</code> if an animation played during this update, <code>false</code> otherwise.
+ * @returns {boolean} <code>true</code> if an animation played during this update, <code>false</code> otherwise.
  *
  * @private
  */

package/Source/Scene/Model/ModelArticulation.js

@@ -9,7 +9,7 @@ import ModelArticulationStage from "./ModelArticulationStage.js";
  * {@link ModelSceneGraph}. This is defined in a model by the
  * <code>AGI_articulations</code> extension.
  *
- * @param {Object} options An object containing the following options:
+ * @param {object} options An object containing the following options:
  * @param {ModelComponents.Articulation} options.articulation The articulation components from the 3D model.
  * @param {ModelSceneGraph} options.sceneGraph The scene graph this articulation belongs to.
  *
@@ -80,7 +80,7 @@ Object.defineProperties(ModelArticulation.prototype, {
    * The name of this articulation.
    *
    * @memberof ModelArticulation.prototype
-   * @type {String}
+   * @type {string}
    * @readonly
    *
    * @private
@@ -150,8 +150,8 @@ function initialize(runtimeArticulation) {
 /**
  * Sets the current value of an articulation stage.
  *
- * @param {String} stageName The name of the articulation stage.
- * @param {Number} value The numeric value of this stage of the articulation.
+ * @param {string} stageName The name of the articulation stage.
+ * @param {number} value The numeric value of this stage of the articulation.
  *
  * @private
  */

package/Source/Scene/Model/ModelArticulationStage.js

@@ -12,7 +12,7 @@ const articulationEpsilon = CesiumMath.EPSILON16;
  * An in-memory representation of an articulation stage belonging to a
  * {@link ModelArticulation}.
  *
- * @param {Object} options An object containing the following options:
+ * @param {object} options An object containing the following options:
  * @param {ModelComponents.ArticulationStage} options.stage The articulation stage components from the 3D model.
  * @param {ModelArticulation} options.runtimeArticulation The runtime articulation that this stage belongs to.
  *
@@ -76,7 +76,7 @@ Object.defineProperties(ModelArticulationStage.prototype, {
    * The name of this articulation stage.
    *
    * @memberof ModelArticulationStage.prototype
-   * @type {String}
+   * @type {string}
    * @readonly
    *
    * @private
@@ -107,7 +107,7 @@ Object.defineProperties(ModelArticulationStage.prototype, {
    * The minimum value of this articulation stage.
    *
    * @memberof ModelArticulationStage.prototype
-   * @type {Number}
+   * @type {number}
    * @readonly
    *
    * @private
@@ -122,7 +122,7 @@ Object.defineProperties(ModelArticulationStage.prototype, {
    * The maximum value of this articulation stage.
    *
    * @memberof ModelArticulationStage.prototype
-   * @type {Number}
+   * @type {number}
    * @readonly
    *
    * @private
@@ -137,7 +137,7 @@ Object.defineProperties(ModelArticulationStage.prototype, {
    * The current value of this articulation stage.
    *
    * @memberof ModelArticulationStage.prototype
-   * @type {Number}
+   * @type {number}
    *
    * @private
    */

package/Source/Scene/Model/ModelDrawCommand.js

@@ -24,7 +24,7 @@ import StyleCommandsNeeded from "./StyleCommandsNeeded.js";
  * This manages the derived commands and pushes only the necessary commands depending
  * on the given frame state.
  *
- * @param {Object} options An object containing the following options:
+ * @param {object} options An object containing the following options:
  * @param {DrawCommand} options.command The draw command from which to derive other commands from.
  * @param {PrimitiveRenderResources} options.primitiveRenderResources The render resources of the primitive associated with the command.
  *
@@ -346,7 +346,7 @@ Object.defineProperties(ModelDrawCommand.prototype, {
    * translucent.
    *
    * @memberof ModelDrawCommand.prototype
-   * @type {Boolean}
+   * @type {boolean}
    *
    * @private
    */
@@ -390,7 +390,7 @@ Object.defineProperties(ModelDrawCommand.prototype, {
    * Whether to draw the bounding sphere associated with this draw command.
    *
    * @memberof ModelDrawCommand.prototype
-   * @type {Boolean}
+   * @type {boolean}
    *
    * @private
    */
@@ -437,9 +437,8 @@ function updateShadows(drawCommand) {
   const receiveShadows = ShadowMode.receiveShadows(shadows);
 
   const derivedCommands = drawCommand._derivedCommands;
-  const length = derivedCommands.length;
 
-  for (let i = 0; i < length; ++i) {
+  for (let i = 0; i < derivedCommands.length; ++i) {
     const derivedCommand = derivedCommands[i];
     if (derivedCommand.updateShadows) {
       const command = derivedCommand.command;
@@ -451,11 +450,9 @@ function updateShadows(drawCommand) {
 
 function updateBackFaceCulling(drawCommand) {
   const backFaceCulling = drawCommand.backFaceCulling;
-
   const derivedCommands = drawCommand._derivedCommands;
-  const length = derivedCommands.length;
 
-  for (let i = 0; i < length; ++i) {
+  for (let i = 0; i < derivedCommands.length; ++i) {
     const derivedCommand = derivedCommands[i];
     if (derivedCommand.updateBackFaceCulling) {
       const command = derivedCommand.command;
@@ -468,11 +465,9 @@ function updateBackFaceCulling(drawCommand) {
 
 function updateCullFace(drawCommand) {
   const cullFace = drawCommand.cullFace;
-
   const derivedCommands = drawCommand._derivedCommands;
-  const length = derivedCommands.length;
 
-  for (let i = 0; i < length; ++i) {
+  for (let i = 0; i < derivedCommands.length; ++i) {
     const derivedCommand = derivedCommands[i];
     if (derivedCommand.updateCullFace) {
       const command = derivedCommand.command;
@@ -485,11 +480,9 @@ function updateCullFace(drawCommand) {
 
 function updateDebugShowBoundingVolume(drawCommand) {
   const debugShowBoundingVolume = drawCommand.debugShowBoundingVolume;
-
   const derivedCommands = drawCommand._derivedCommands;
-  const length = derivedCommands.length;
 
-  for (let i = 0; i < length; ++i) {
+  for (let i = 0; i < derivedCommands.length; ++i) {
     const derivedCommand = derivedCommands[i];
     if (derivedCommand.updateDebugShowBoundingVolume) {
       const command = derivedCommand.command;
@@ -537,15 +530,10 @@ ModelDrawCommand.prototype.pushCommands = function (frameState, result) {
   }
 
   if (this._needsSkipLevelOfDetailCommands) {
-    const content = this._model.content;
-    const tileset = content.tileset;
-    const tile = content.tile;
-
-    const hasMixedContent = tileset._hasMixedContent;
-    const finalResolution = tile._finalResolution;
+    const { tileset, tile } = this._model.content;
 
-    if (hasMixedContent) {
-      if (!finalResolution) {
+    if (tileset.hasMixedContent) {
+      if (!tile._finalResolution) {
         pushCommand(
           tileset._backfaceCommands,
           this._skipLodBackfaceCommand,
@@ -846,13 +834,14 @@ function deriveSkipLodStencilCommand(command) {
   const stencilCommand = DrawCommand.shallowClone(command);
   const renderState = clone(command.renderState, true);
   // The stencil reference is updated dynamically; see updateSkipLodStencilCommand().
-  renderState.stencilTest.enabled = true;
-  renderState.stencilTest.mask = StencilConstants.SKIP_LOD_MASK;
-  renderState.stencilTest.reference = StencilConstants.CESIUM_3D_TILE_MASK;
-  renderState.stencilTest.frontFunction = StencilFunction.GREATER_OR_EQUAL;
-  renderState.stencilTest.frontOperation.zPass = StencilOperation.REPLACE;
-  renderState.stencilTest.backFunction = StencilFunction.GREATER_OR_EQUAL;
-  renderState.stencilTest.backOperation.zPass = StencilOperation.REPLACE;
+  const { stencilTest } = renderState;
+  stencilTest.enabled = true;
+  stencilTest.mask = StencilConstants.SKIP_LOD_MASK;
+  stencilTest.reference = StencilConstants.CESIUM_3D_TILE_MASK;
+  stencilTest.frontFunction = StencilFunction.GREATER_OR_EQUAL;
+  stencilTest.frontOperation.zPass = StencilOperation.REPLACE;
+  stencilTest.backFunction = StencilFunction.GREATER_OR_EQUAL;
+  stencilTest.backOperation.zPass = StencilOperation.REPLACE;
   renderState.stencilMask =
     StencilConstants.CESIUM_3D_TILE_MASK | StencilConstants.SKIP_LOD_MASK;