rubocop 0.8.0 → 0.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (377) hide show
  1. checksums.yaml +4 -4
  2. data/.travis.yml +0 -4
  3. data/.yardopts +2 -0
  4. data/CHANGELOG.md +95 -1
  5. data/README.md +101 -11
  6. data/config/default.yml +14 -2
  7. data/config/enabled.yml +96 -14
  8. data/lib/rubocop/cli.rb +178 -94
  9. data/lib/rubocop/config.rb +56 -11
  10. data/lib/rubocop/config_store.rb +2 -0
  11. data/lib/rubocop/cop/cop.rb +54 -11
  12. data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
  13. data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
  14. data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
  15. data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
  16. data/lib/rubocop/cop/lint/eval.rb +22 -0
  17. data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
  18. data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
  19. data/lib/rubocop/cop/lint/loop.rb +29 -0
  20. data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
  21. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
  22. data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
  23. data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
  24. data/lib/rubocop/cop/lint/void.rb +58 -0
  25. data/lib/rubocop/cop/offence.rb +112 -12
  26. data/lib/rubocop/cop/rails/validation.rb +34 -0
  27. data/lib/rubocop/cop/style/access_control.rb +58 -0
  28. data/lib/rubocop/cop/style/alias.rb +28 -0
  29. data/lib/rubocop/cop/style/align_parameters.rb +39 -0
  30. data/lib/rubocop/cop/style/and_or.rb +45 -0
  31. data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
  32. data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
  33. data/lib/rubocop/cop/style/attr.rb +20 -0
  34. data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
  35. data/lib/rubocop/cop/style/avoid_for.rb +18 -0
  36. data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
  37. data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
  38. data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
  39. data/lib/rubocop/cop/style/begin_block.rb +18 -0
  40. data/lib/rubocop/cop/style/block_comments.rb +20 -0
  41. data/lib/rubocop/cop/style/block_nesting.rb +47 -0
  42. data/lib/rubocop/cop/style/blocks.rb +27 -0
  43. data/lib/rubocop/cop/style/case_equality.rb +22 -0
  44. data/lib/rubocop/cop/style/case_indentation.rb +28 -0
  45. data/lib/rubocop/cop/style/character_literal.rb +37 -0
  46. data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
  47. data/lib/rubocop/cop/style/class_methods.rb +22 -0
  48. data/lib/rubocop/cop/style/collection_methods.rb +37 -0
  49. data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
  50. data/lib/rubocop/cop/style/constant_name.rb +31 -0
  51. data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
  52. data/lib/rubocop/cop/style/documentation.rb +58 -0
  53. data/lib/rubocop/cop/style/dot_position.rb +25 -0
  54. data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
  55. data/lib/rubocop/cop/style/empty_lines.rb +40 -0
  56. data/lib/rubocop/cop/style/empty_literal.rb +53 -0
  57. data/lib/rubocop/cop/style/encoding.rb +29 -0
  58. data/lib/rubocop/cop/style/end_block.rb +18 -0
  59. data/lib/rubocop/cop/style/end_of_line.rb +23 -0
  60. data/lib/rubocop/cop/style/favor_join.rb +29 -0
  61. data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
  62. data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
  63. data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
  64. data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
  65. data/lib/rubocop/cop/style/if_then_else.rb +80 -0
  66. data/lib/rubocop/cop/style/lambda.rb +47 -0
  67. data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
  68. data/lib/rubocop/cop/style/line_continuation.rb +26 -0
  69. data/lib/rubocop/cop/style/line_length.rb +30 -0
  70. data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
  71. data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
  72. data/lib/rubocop/cop/style/method_length.rb +57 -0
  73. data/lib/rubocop/cop/style/not.rb +24 -0
  74. data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
  75. data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
  76. data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
  77. data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
  78. data/lib/rubocop/cop/style/proc.rb +30 -0
  79. data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
  80. data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
  81. data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
  82. data/lib/rubocop/cop/style/semicolon.rb +51 -0
  83. data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
  84. data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
  85. data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
  86. data/lib/rubocop/cop/style/string_literals.rb +36 -0
  87. data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
  88. data/lib/rubocop/cop/style/symbol_array.rb +31 -0
  89. data/lib/rubocop/cop/style/symbol_name.rb +27 -0
  90. data/lib/rubocop/cop/style/tab.rb +25 -0
  91. data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
  92. data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
  93. data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
  94. data/lib/rubocop/cop/style/unless_else.rb +26 -0
  95. data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
  96. data/lib/rubocop/cop/style/when_then.rb +25 -0
  97. data/lib/rubocop/cop/style/while_until_do.rb +45 -0
  98. data/lib/rubocop/cop/style/word_array.rb +44 -0
  99. data/lib/rubocop/cop/util.rb +1 -0
  100. data/lib/rubocop/cop/variable_inspector.rb +280 -0
  101. data/lib/rubocop/formatter/base_formatter.rb +119 -0
  102. data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
  103. data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
  104. data/lib/rubocop/formatter/formatter_set.rb +77 -0
  105. data/lib/rubocop/formatter/json_formatter.rb +76 -0
  106. data/lib/rubocop/formatter/progress_formatter.rb +63 -0
  107. data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
  108. data/lib/rubocop/version.rb +15 -1
  109. data/lib/rubocop.rb +97 -71
  110. data/rubocop.gemspec +1 -2
  111. data/spec/.rubocop.yml +5 -0
  112. data/spec/project_spec.rb +4 -7
  113. data/spec/rubocop/cli_spec.rb +402 -143
  114. data/spec/rubocop/config_spec.rb +61 -0
  115. data/spec/rubocop/config_store_spec.rb +2 -2
  116. data/spec/rubocop/cops/cop_spec.rb +14 -7
  117. data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
  118. data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
  119. data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
  120. data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
  121. data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
  122. data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
  123. data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
  124. data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
  125. data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
  126. data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
  127. data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
  128. data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
  129. data/spec/rubocop/cops/lint/void_spec.rb +63 -0
  130. data/spec/rubocop/cops/offence_spec.rb +107 -10
  131. data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
  132. data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
  133. data/spec/rubocop/cops/style/alias_spec.rb +47 -0
  134. data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
  135. data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
  136. data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
  137. data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
  138. data/spec/rubocop/cops/style/attr_spec.rb +20 -0
  139. data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
  140. data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
  141. data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
  142. data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
  143. data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
  144. data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
  145. data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
  146. data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
  147. data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
  148. data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
  149. data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
  150. data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
  151. data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
  152. data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
  153. data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
  154. data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
  155. data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
  156. data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
  157. data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
  158. data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
  159. data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
  160. data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
  161. data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
  162. data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
  163. data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
  164. data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
  165. data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
  166. data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
  167. data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
  168. data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
  169. data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
  170. data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
  171. data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
  172. data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
  173. data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
  174. data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
  175. data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
  176. data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
  177. data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
  178. data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
  179. data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
  180. data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
  181. data/spec/rubocop/cops/style/not_spec.rb +28 -0
  182. data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
  183. data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
  184. data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
  185. data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
  186. data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
  187. data/spec/rubocop/cops/style/proc_spec.rb +28 -0
  188. data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
  189. data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
  190. data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
  191. data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
  192. data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
  193. data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
  194. data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
  195. data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
  196. data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
  197. data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
  198. data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
  199. data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
  200. data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
  201. data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
  202. data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
  203. data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
  204. data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
  205. data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
  206. data/spec/rubocop/cops/style/tab_spec.rb +23 -0
  207. data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
  208. data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
  209. data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
  210. data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
  211. data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
  212. data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
  213. data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
  214. data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
  215. data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
  216. data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
  217. data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
  218. data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
  219. data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
  220. data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
  221. data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
  222. data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
  223. data/spec/spec_helper.rb +24 -9
  224. data/spec/support/mri_syntax_checker.rb +69 -0
  225. data/spec/support/shared_examples.rb +33 -0
  226. metadata +317 -239
  227. data/lib/rubocop/cop/access_control.rb +0 -41
  228. data/lib/rubocop/cop/alias.rb +0 -17
  229. data/lib/rubocop/cop/align_parameters.rb +0 -37
  230. data/lib/rubocop/cop/and_or.rb +0 -26
  231. data/lib/rubocop/cop/ascii_comments.rb +0 -13
  232. data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
  233. data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
  234. data/lib/rubocop/cop/avoid_for.rb +0 -17
  235. data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
  236. data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
  237. data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
  238. data/lib/rubocop/cop/block_comments.rb +0 -15
  239. data/lib/rubocop/cop/blocks.rb +0 -23
  240. data/lib/rubocop/cop/case_indentation.rb +0 -22
  241. data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
  242. data/lib/rubocop/cop/class_methods.rb +0 -15
  243. data/lib/rubocop/cop/collection_methods.rb +0 -29
  244. data/lib/rubocop/cop/colon_method_call.rb +0 -20
  245. data/lib/rubocop/cop/constant_name.rb +0 -24
  246. data/lib/rubocop/cop/def_parentheses.rb +0 -62
  247. data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
  248. data/lib/rubocop/cop/empty_lines.rb +0 -34
  249. data/lib/rubocop/cop/empty_literal.rb +0 -47
  250. data/lib/rubocop/cop/encoding.rb +0 -19
  251. data/lib/rubocop/cop/end_of_line.rb +0 -15
  252. data/lib/rubocop/cop/ensure_return.rb +0 -19
  253. data/lib/rubocop/cop/eval.rb +0 -19
  254. data/lib/rubocop/cop/favor_join.rb +0 -22
  255. data/lib/rubocop/cop/favor_modifier.rb +0 -72
  256. data/lib/rubocop/cop/favor_percent_r.rb +0 -19
  257. data/lib/rubocop/cop/favor_sprintf.rb +0 -21
  258. data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
  259. data/lib/rubocop/cop/handle_exceptions.rb +0 -17
  260. data/lib/rubocop/cop/hash_syntax.rb +0 -41
  261. data/lib/rubocop/cop/if_then_else.rb +0 -65
  262. data/lib/rubocop/cop/leading_comment_space.rb +0 -17
  263. data/lib/rubocop/cop/line_continuation.rb +0 -15
  264. data/lib/rubocop/cop/line_length.rb +0 -23
  265. data/lib/rubocop/cop/loop.rb +0 -33
  266. data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
  267. data/lib/rubocop/cop/method_length.rb +0 -52
  268. data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
  269. data/lib/rubocop/cop/not.rb +0 -21
  270. data/lib/rubocop/cop/numeric_literals.rb +0 -21
  271. data/lib/rubocop/cop/parameter_lists.rb +0 -23
  272. data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
  273. data/lib/rubocop/cop/percent_r.rb +0 -19
  274. data/lib/rubocop/cop/reduce_arguments.rb +0 -29
  275. data/lib/rubocop/cop/rescue_exception.rb +0 -26
  276. data/lib/rubocop/cop/rescue_modifier.rb +0 -17
  277. data/lib/rubocop/cop/semicolon.rb +0 -31
  278. data/lib/rubocop/cop/single_line_methods.rb +0 -44
  279. data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
  280. data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
  281. data/lib/rubocop/cop/string_literals.rb +0 -22
  282. data/lib/rubocop/cop/surrounding_space.rb +0 -283
  283. data/lib/rubocop/cop/symbol_array.rb +0 -31
  284. data/lib/rubocop/cop/symbol_name.rb +0 -23
  285. data/lib/rubocop/cop/syntax.rb +0 -49
  286. data/lib/rubocop/cop/tab.rb +0 -15
  287. data/lib/rubocop/cop/ternary_operator.rb +0 -43
  288. data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
  289. data/lib/rubocop/cop/trivial_accessors.rb +0 -26
  290. data/lib/rubocop/cop/unless_else.rb +0 -23
  291. data/lib/rubocop/cop/variable_interpolation.rb +0 -29
  292. data/lib/rubocop/cop/when_then.rb +0 -17
  293. data/lib/rubocop/cop/word_array.rb +0 -37
  294. data/lib/rubocop/report/emacs_style.rb +0 -17
  295. data/lib/rubocop/report/plain_text.rb +0 -18
  296. data/lib/rubocop/report/report.rb +0 -44
  297. data/spec/rubocop/cops/access_control_spec.rb +0 -129
  298. data/spec/rubocop/cops/alias_spec.rb +0 -39
  299. data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
  300. data/spec/rubocop/cops/and_or_spec.rb +0 -37
  301. data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
  302. data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
  303. data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
  304. data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
  305. data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
  306. data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
  307. data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
  308. data/spec/rubocop/cops/block_comments_spec.rb +0 -25
  309. data/spec/rubocop/cops/blocks_spec.rb +0 -33
  310. data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
  311. data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
  312. data/spec/rubocop/cops/class_methods_spec.rb +0 -49
  313. data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
  314. data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
  315. data/spec/rubocop/cops/constant_name_spec.rb +0 -42
  316. data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
  317. data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
  318. data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
  319. data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
  320. data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
  321. data/spec/rubocop/cops/encoding_spec.rb +0 -47
  322. data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
  323. data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
  324. data/spec/rubocop/cops/eval_spec.rb +0 -39
  325. data/spec/rubocop/cops/favor_join_spec.rb +0 -35
  326. data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
  327. data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
  328. data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
  329. data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
  330. data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
  331. data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
  332. data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
  333. data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
  334. data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
  335. data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
  336. data/spec/rubocop/cops/line_length_spec.rb +0 -23
  337. data/spec/rubocop/cops/loop_spec.rb +0 -31
  338. data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
  339. data/spec/rubocop/cops/method_length_spec.rb +0 -147
  340. data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
  341. data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
  342. data/spec/rubocop/cops/not_spec.rb +0 -31
  343. data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
  344. data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
  345. data/spec/rubocop/cops/op_method_spec.rb +0 -78
  346. data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
  347. data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
  348. data/spec/rubocop/cops/percent_r_spec.rb +0 -29
  349. data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
  350. data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
  351. data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
  352. data/spec/rubocop/cops/semicolon_spec.rb +0 -88
  353. data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
  354. data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
  355. data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
  356. data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
  357. data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
  358. data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
  359. data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
  360. data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
  361. data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
  362. data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
  363. data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
  364. data/spec/rubocop/cops/string_literals_spec.rb +0 -47
  365. data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
  366. data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
  367. data/spec/rubocop/cops/syntax_spec.rb +0 -41
  368. data/spec/rubocop/cops/tab_spec.rb +0 -21
  369. data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
  370. data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
  371. data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
  372. data/spec/rubocop/cops/unless_else_spec.rb +0 -29
  373. data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
  374. data/spec/rubocop/cops/when_then_spec.rb +0 -38
  375. data/spec/rubocop/cops/word_array_spec.rb +0 -47
  376. data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
  377. data/spec/rubocop/reports/report_spec.rb +0 -29
@@ -0,0 +1,118 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # Common functionality for modifier cops.
7
+ module FavorModifier
8
+ # TODO extremely ugly solution that needs lots of polish
9
+ def check(sexp, comments)
10
+ case sexp.loc.keyword.source
11
+ when 'if' then cond, body, _else = *sexp
12
+ when 'unless' then cond, _else, body = *sexp
13
+ else cond, body = *sexp
14
+ end
15
+
16
+ if length(sexp) > 3
17
+ false
18
+ else
19
+ body_length = body_length(body)
20
+
21
+ if body_length == 0
22
+ false
23
+ else
24
+ indentation = sexp.loc.keyword.column
25
+ kw_length = sexp.loc.keyword.size
26
+ cond_length = cond.loc.expression.size
27
+ space = 1
28
+ total = indentation + body_length + space + kw_length + space +
29
+ cond_length
30
+ total <= LineLength.max && !body_has_comment?(body, comments)
31
+ end
32
+ end
33
+ end
34
+
35
+ def length(sexp)
36
+ sexp.loc.expression.source.lines.to_a.size
37
+ end
38
+
39
+ def body_length(body)
40
+ if body && body.loc.expression
41
+ body.loc.expression.size
42
+ else
43
+ 0
44
+ end
45
+ end
46
+
47
+ def body_has_comment?(body, comments)
48
+ comment_lines = comments.map(&:location).map(&:line)
49
+ body_line = body.loc.expression.line
50
+ comment_lines.include?(body_line)
51
+ end
52
+ end
53
+
54
+ # Checks for if and unless statements that would fit on one line
55
+ # if written as a modifier if/unless.
56
+ class IfUnlessModifier < Cop
57
+ include FavorModifier
58
+
59
+ def error_message
60
+ 'Favor modifier if/unless usage when you have a single-line body. ' +
61
+ 'Another good alternative is the usage of control flow &&/||.'
62
+ end
63
+
64
+ def inspect(source_buffer, source, tokens, ast, comments)
65
+ return unless ast
66
+ on_node(:if, ast) do |node|
67
+ # discard ternary ops, if/else and modifier if/unless nodes
68
+ return if ternary_op?(node)
69
+ return if modifier_if?(node)
70
+ return if elsif?(node)
71
+ return if if_else?(node)
72
+
73
+ if check(node, comments)
74
+ add_offence(:convention, node.loc.expression, error_message)
75
+ end
76
+ end
77
+ end
78
+
79
+ def ternary_op?(node)
80
+ node.loc.respond_to?(:question)
81
+ end
82
+
83
+ def modifier_if?(node)
84
+ node.loc.end.nil?
85
+ end
86
+
87
+ def elsif?(node)
88
+ node.loc.keyword.is?('elsif')
89
+ end
90
+
91
+ def if_else?(node)
92
+ node.loc.respond_to?(:else) && node.loc.else
93
+ end
94
+ end
95
+
96
+ # Checks for while and until statements that would fit on one line
97
+ # if written as a modifier while/until.
98
+ class WhileUntilModifier < Cop
99
+ include FavorModifier
100
+
101
+ MSG =
102
+ 'Favor modifier while/until usage when you have a single-line body.'
103
+
104
+ def inspect(source_buffer, source, tokens, ast, comments)
105
+ return unless ast
106
+ on_node([:while, :until], ast) do |node|
107
+ # discard modifier while/until
108
+ next unless node.loc.end
109
+
110
+ if check(node, comments)
111
+ add_offence(:convention, node.loc.expression, MSG)
112
+ end
113
+ end
114
+ end
115
+ end
116
+ end
117
+ end
118
+ end
@@ -0,0 +1,28 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses of String#%.
7
+ #
8
+ # It cannot be implemented in a reliable manner for all cases, so
9
+ # only two scenarios are considered - if the first argument is a string
10
+ # literal and if the second argument is an array literal.
11
+ class FavorSprintf < Cop
12
+ MSG = 'Favor sprintf over String#%.'
13
+
14
+ def on_send(node)
15
+ receiver_node, method_name, *arg_nodes = *node
16
+
17
+ if method_name == :% &&
18
+ ([:str, :dstr].include?(receiver_node.type) ||
19
+ arg_nodes[0].type == :array)
20
+ add_offence(:convention, node.loc.selector, MSG)
21
+ end
22
+
23
+ super
24
+ end
25
+ end
26
+ end
27
+ end
28
+ end
@@ -0,0 +1,54 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # Some common code shared between the two cops.
7
+ module FavorOtherKeywordOverNegation
8
+ def check(node)
9
+ condition, _body, _rest = *node
10
+
11
+ # Look at last expression of contents if there's a parenthesis
12
+ # around condition.
13
+ condition = condition.children.last while condition.type == :begin
14
+
15
+ if condition.type == :send
16
+ _object, method = *condition
17
+ if method == :! && !(node.loc.respond_to?(:else) && node.loc.else)
18
+ add_offence(:convention, node.loc.expression, error_message)
19
+ end
20
+ end
21
+ end
22
+ end
23
+
24
+ # Checks for uses of if with a negated condition. Only ifs
25
+ # without else are considered.
26
+ class FavorUnlessOverNegatedIf < Cop
27
+ include FavorOtherKeywordOverNegation
28
+
29
+ def on_if(node)
30
+ check(node)
31
+ super
32
+ end
33
+
34
+ def error_message
35
+ 'Favor unless (or control flow or) over if for negative conditions.'
36
+ end
37
+ end
38
+
39
+ # Checks for uses of while with a negated condition.
40
+ class FavorUntilOverNegatedWhile < Cop
41
+ include FavorOtherKeywordOverNegation
42
+
43
+ def on_while(node)
44
+ check(node)
45
+ super
46
+ end
47
+
48
+ def error_message
49
+ 'Favor until over while for negative conditions.'
50
+ end
51
+ end
52
+ end
53
+ end
54
+ end
@@ -0,0 +1,47 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses of the Ruby 1.8 hash literal syntax,
7
+ # when the 1.9 syntax is applicable as well.
8
+ #
9
+ # A separate offence is registered for each problematic pair.
10
+ class HashSyntax < Cop
11
+ MSG = 'Ruby 1.8 hash syntax detected'
12
+
13
+ def on_hash(node)
14
+ pairs = *node
15
+
16
+ sym_indices = pairs.all? { |p| word_symbol_pair?(p) }
17
+
18
+ if sym_indices
19
+ pairs.each do |pair|
20
+ if pair.loc.operator && pair.loc.operator.is?('=>')
21
+ add_offence(:convention,
22
+ pair.loc.expression.begin.join(pair.loc.operator),
23
+ MSG)
24
+ end
25
+ end
26
+ end
27
+
28
+ super
29
+ end
30
+
31
+ private
32
+
33
+ def word_symbol_pair?(pair)
34
+ key, _value = *pair
35
+
36
+ if key.type == :sym
37
+ sym_name = key.to_a[0]
38
+
39
+ sym_name =~ /\A\w+\z/
40
+ else
41
+ false
42
+ end
43
+ end
44
+ end
45
+ end
46
+ end
47
+ end
@@ -0,0 +1,80 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # Common functionality for cops checking if and unless statements.
7
+ module IfThenElse
8
+ def on_if(node)
9
+ check(node)
10
+ super
11
+ end
12
+
13
+ def on_unless(node)
14
+ check(node)
15
+ super
16
+ end
17
+
18
+ def check(node)
19
+ # We won't check modifier or ternary conditionals.
20
+ if node.loc.expression.source =~ /\A(if|unless)\b/
21
+ if offending_line(node)
22
+ add_offence(:convention, node.loc.expression, error_message)
23
+ end
24
+ end
25
+ end
26
+ end
27
+
28
+ # Checks for uses of semicolon in if statements.
29
+ class IfWithSemicolon < Cop
30
+ include IfThenElse
31
+
32
+ def offending_line(node)
33
+ node.loc.begin.line if node.loc.begin && node.loc.begin.is?(';')
34
+ end
35
+
36
+ def error_message
37
+ 'Never use if x; Use the ternary operator instead.'
38
+ end
39
+ end
40
+
41
+ # Checks for uses of then multi-line if statements.
42
+ class MultilineIfThen < Cop
43
+ include IfThenElse
44
+
45
+ def offending_line(node)
46
+ condition, body = *node
47
+ next_thing = if body && body.loc.expression
48
+ body.loc.expression.begin
49
+ else
50
+ node.loc.end # No body, use "end".
51
+ end
52
+ right_after_cond =
53
+ Parser::Source::Range.new(next_thing.source_buffer,
54
+ condition.loc.expression.end.end_pos,
55
+ next_thing.begin_pos)
56
+ if right_after_cond.source =~ /\A\s*then\s*(#.*)?\s*\n/
57
+ node.loc.expression.begin.line
58
+ end
59
+ end
60
+
61
+ def error_message
62
+ 'Never use then for multi-line if/unless.'
63
+ end
64
+ end
65
+
66
+ # Checks for uses of if/then/else/end on a single line.
67
+ class OneLineConditional < Cop
68
+ include IfThenElse
69
+
70
+ def offending_line(node)
71
+ node.loc.expression.line unless node.loc.expression.source =~ /\n/
72
+ end
73
+
74
+ def error_message
75
+ 'Favor the ternary operator (?:) over if/then/else/end constructs.'
76
+ end
77
+ end
78
+ end
79
+ end
80
+ end
@@ -0,0 +1,47 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses of the pre 1.9 lambda syntax for one-line
7
+ # anonymous functions and uses of the 1.9 lambda syntax for multi-line
8
+ # anonymous functions.
9
+ class Lambda < Cop
10
+ SINGLE_MSG = 'Use the new lambda literal syntax ->(params) {...}.'
11
+ MULTI_MSG = 'Use the lambda method for multi-line lambdas.'
12
+
13
+ TARGET = s(:send, nil, :lambda)
14
+
15
+ def on_block(node)
16
+ # We're looking for
17
+ # (block
18
+ # (send nil :lambda)
19
+ # ...)
20
+ block_method, = *node
21
+
22
+ if block_method == TARGET
23
+ selector = block_method.loc.selector.source
24
+ lambda_length = lambda_length(node)
25
+
26
+ if selector != '->' && lambda_length == 0
27
+ add_offence(:convention, block_method.loc.expression, SINGLE_MSG)
28
+ elsif selector == '->' && lambda_length > 0
29
+ add_offence(:convention, block_method.loc.expression, MULTI_MSG)
30
+ end
31
+ end
32
+
33
+ super
34
+ end
35
+
36
+ private
37
+
38
+ def lambda_length(block_node)
39
+ start_line = block_node.loc.begin.line
40
+ end_line = block_node.loc.end.line
41
+
42
+ end_line - start_line
43
+ end
44
+ end
45
+ end
46
+ end
47
+ end
@@ -0,0 +1,25 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks whether comments have a leading space
7
+ # after the # denoting the start of the comment. The
8
+ # leading space is not required for some RDoc special syntax,
9
+ # like #++, #--, #:nodoc, etc.
10
+ class LeadingCommentSpace < Cop
11
+ MSG = 'Missing space after #.'
12
+
13
+ def inspect(source_buffer, source, tokens, ast, comments)
14
+ comments.each do |comment|
15
+ if comment.text =~ /^#+[^#\s:+-]/
16
+ unless comment.text.start_with?('#!') && comment.loc.line == 1
17
+ add_offence(:convention, comment.loc, MSG)
18
+ end
19
+ end
20
+ end
21
+ end
22
+ end
23
+ end
24
+ end
25
+ end
@@ -0,0 +1,26 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses of the line continuation character.
7
+ #
8
+ # This check has to be refined or retired, since it doesn't make a lot
9
+ # of sense without inspection of its context.
10
+ class LineContinuation < Cop
11
+ MSG = 'Avoid the use of the line continuation character(\).'
12
+
13
+ def inspect(source_buffer, source, tokens, ast, comments)
14
+ source.each_with_index do |line, index|
15
+ if line =~ /.*\\\z/
16
+ add_offence(:convention,
17
+ source_range(source_buffer, source[0...index],
18
+ line.length - 1, 1),
19
+ MSG)
20
+ end
21
+ end
22
+ end
23
+ end
24
+ end
25
+ end
26
+ end
@@ -0,0 +1,30 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks the length of lines in the source code.
7
+ # The maximum length is configurable.
8
+ class LineLength < Cop
9
+ MSG = 'Line is too long. [%d/%d]'
10
+
11
+ def inspect(source_buffer, source, tokens, ast, comments)
12
+ source.each_with_index do |line, index|
13
+ max = LineLength.max
14
+ if line.length > max
15
+ message = sprintf(MSG, line.length, max)
16
+ add_offence(:convention,
17
+ source_range(source_buffer, source[0...index], max,
18
+ line.length - max),
19
+ message)
20
+ end
21
+ end
22
+ end
23
+
24
+ def self.max
25
+ LineLength.config['Max']
26
+ end
27
+ end
28
+ end
29
+ end
30
+ end
@@ -0,0 +1,61 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop makes sure that all methods and variables use
7
+ # snake_case for their names. Some special arrangements have to be
8
+ # made for operator methods.
9
+ class MethodAndVariableSnakeCase < Cop
10
+ MSG = 'Use snake_case for methods and variables.'
11
+ SNAKE_CASE = /^@?[\da-z_]+[!?=]?$/
12
+
13
+ # http://phrogz.net/programmingruby/language.html#table_18.4
14
+ OPERATOR_METHODS = %w(
15
+ | ^ & <=> == === =~ > >= < <= << >>
16
+ + - * / % ** ~ +@ -@ [] []= ` ! != !~
17
+ ).map(&:to_sym)
18
+
19
+ def inspect(source_buffer, source, tokens, node, comments)
20
+ return unless node
21
+ on_node([:def, :defs, :lvasgn, :ivasgn, :send], node) do |n|
22
+ name = case n.type
23
+ when :def
24
+ name_of_instance_method(n)
25
+ when :defs
26
+ name_of_singleton_method(n)
27
+ when :lvasgn, :ivasgn
28
+ name_of_variable(n)
29
+ when :send
30
+ name_of_setter(n)
31
+ end
32
+
33
+ next unless name
34
+ next if name =~ SNAKE_CASE || OPERATOR_METHODS.include?(name)
35
+
36
+ add_offence(:convention, n.location.expression, MSG)
37
+ end
38
+ end
39
+
40
+ def name_of_instance_method(def_node)
41
+ def_node.children.first
42
+ end
43
+
44
+ def name_of_singleton_method(defs_node)
45
+ defs_node.children[1]
46
+ end
47
+
48
+ def name_of_variable(vasgn_node)
49
+ vasgn_node.children.first
50
+ end
51
+
52
+ def name_of_setter(send_node)
53
+ receiver, method_name = *send_node
54
+ return nil unless receiver && receiver.type == :self
55
+ return nil unless method_name.to_s.end_with?('=')
56
+ method_name
57
+ end
58
+ end
59
+ end
60
+ end
61
+ end
@@ -0,0 +1,22 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for unwanted parentheses in parameterless method calls.
7
+ class MethodCallParentheses < Cop
8
+ MSG = 'Do not use parentheses for method calls with no arguments.'
9
+
10
+ def on_send(node)
11
+ _receiver, _method_name, *args = *node
12
+
13
+ if args.empty? && node.loc.begin
14
+ add_offence(:convention, node.loc.begin, MSG)
15
+ end
16
+
17
+ super
18
+ end
19
+ end
20
+ end
21
+ end
22
+ end
@@ -0,0 +1,57 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks if the length a method exceeds some maximum value.
7
+ # Comment lines can optionally be ignored.
8
+ # The maximum allowed length is configurable.
9
+ class MethodLength < Cop
10
+ MSG = 'Method has too many lines. [%d/%d]'
11
+
12
+ def on_def(node)
13
+ check(node)
14
+
15
+ super
16
+ end
17
+
18
+ def on_defs(node)
19
+ check(node)
20
+
21
+ super
22
+ end
23
+
24
+ def max_length
25
+ MethodLength.config['Max']
26
+ end
27
+
28
+ def count_comments?
29
+ MethodLength.config['CountComments']
30
+ end
31
+
32
+ private
33
+
34
+ def check(node)
35
+ method_length = calculate_length(node.loc.expression.source)
36
+
37
+ if method_length > max_length
38
+ message = sprintf(MSG, method_length, max_length)
39
+ add_offence(:convention, node.loc.keyword, message)
40
+ end
41
+ end
42
+
43
+ def calculate_length(source)
44
+ lines = source.lines.to_a[1...-1]
45
+
46
+ return 0 unless lines
47
+
48
+ lines.map!(&:strip).reject!(&:empty?)
49
+
50
+ lines.reject! { |line| line =~ /^\s*#/ } unless count_comments?
51
+
52
+ lines.size
53
+ end
54
+ end
55
+ end
56
+ end
57
+ end
@@ -0,0 +1,24 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses if the keyword *not* instead of !.
7
+ class Not < Cop
8
+ MSG = 'Use ! instead of not.'
9
+
10
+ def on_send(node)
11
+ _receiver, method_name, *args = *node
12
+
13
+ # not does not take any arguments
14
+ if args.empty? && method_name == :! &&
15
+ node.loc.selector.is?('not')
16
+ add_offence(:convention, node.loc.selector, MSG)
17
+ end
18
+
19
+ super
20
+ end
21
+ end
22
+ end
23
+ end
24
+ end
@@ -0,0 +1,25 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for big numeric literals without _ between groups
7
+ # of digits in them.
8
+ class NumericLiterals < Cop
9
+ MSG = 'Add underscores to large numeric literals to ' +
10
+ 'improve their readability.'
11
+
12
+ def on_int(node)
13
+ value, = *node
14
+
15
+ if value > 10000 &&
16
+ node.loc.expression.source.split('.').grep(/\d{6}/).any?
17
+ add_offence(:convention, node.loc.expression, MSG)
18
+ end
19
+ end
20
+
21
+ alias_method :on_float, :on_int
22
+ end
23
+ end
24
+ end
25
+ end
@@ -2,8 +2,10 @@
2
2
 
3
3
  module Rubocop
4
4
  module Cop
5
+ # This cop makes sure that certain operator methods have their sole
6
+ # parameter named *other*.
5
7
  class OpMethod < Cop
6
- MSG = 'When defining the %s operator, name its argument other.'
8
+ MSG = 'When defining the %s operator, name its argument *other*.'
7
9
 
8
10
  BLACKLISTED = [:+@, :-@, :[], :[]=, :<<]
9
11
 
@@ -14,8 +16,7 @@ module Rubocop
14
16
 
15
17
  if name !~ /\A\w/ && !BLACKLISTED.include?(name) &&
16
18
  args.children.size == 1 && args != TARGET_ARGS
17
- add_offence(:convention,
18
- node.loc.line,
19
+ add_offence(:convention, args.children[0].loc.expression,
19
20
  sprintf(MSG, name))
20
21
  end
21
22