rubocop 0.8.0 → 0.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (377) hide show
  1. checksums.yaml +4 -4
  2. data/.travis.yml +0 -4
  3. data/.yardopts +2 -0
  4. data/CHANGELOG.md +95 -1
  5. data/README.md +101 -11
  6. data/config/default.yml +14 -2
  7. data/config/enabled.yml +96 -14
  8. data/lib/rubocop/cli.rb +178 -94
  9. data/lib/rubocop/config.rb +56 -11
  10. data/lib/rubocop/config_store.rb +2 -0
  11. data/lib/rubocop/cop/cop.rb +54 -11
  12. data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
  13. data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
  14. data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
  15. data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
  16. data/lib/rubocop/cop/lint/eval.rb +22 -0
  17. data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
  18. data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
  19. data/lib/rubocop/cop/lint/loop.rb +29 -0
  20. data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
  21. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
  22. data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
  23. data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
  24. data/lib/rubocop/cop/lint/void.rb +58 -0
  25. data/lib/rubocop/cop/offence.rb +112 -12
  26. data/lib/rubocop/cop/rails/validation.rb +34 -0
  27. data/lib/rubocop/cop/style/access_control.rb +58 -0
  28. data/lib/rubocop/cop/style/alias.rb +28 -0
  29. data/lib/rubocop/cop/style/align_parameters.rb +39 -0
  30. data/lib/rubocop/cop/style/and_or.rb +45 -0
  31. data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
  32. data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
  33. data/lib/rubocop/cop/style/attr.rb +20 -0
  34. data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
  35. data/lib/rubocop/cop/style/avoid_for.rb +18 -0
  36. data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
  37. data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
  38. data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
  39. data/lib/rubocop/cop/style/begin_block.rb +18 -0
  40. data/lib/rubocop/cop/style/block_comments.rb +20 -0
  41. data/lib/rubocop/cop/style/block_nesting.rb +47 -0
  42. data/lib/rubocop/cop/style/blocks.rb +27 -0
  43. data/lib/rubocop/cop/style/case_equality.rb +22 -0
  44. data/lib/rubocop/cop/style/case_indentation.rb +28 -0
  45. data/lib/rubocop/cop/style/character_literal.rb +37 -0
  46. data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
  47. data/lib/rubocop/cop/style/class_methods.rb +22 -0
  48. data/lib/rubocop/cop/style/collection_methods.rb +37 -0
  49. data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
  50. data/lib/rubocop/cop/style/constant_name.rb +31 -0
  51. data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
  52. data/lib/rubocop/cop/style/documentation.rb +58 -0
  53. data/lib/rubocop/cop/style/dot_position.rb +25 -0
  54. data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
  55. data/lib/rubocop/cop/style/empty_lines.rb +40 -0
  56. data/lib/rubocop/cop/style/empty_literal.rb +53 -0
  57. data/lib/rubocop/cop/style/encoding.rb +29 -0
  58. data/lib/rubocop/cop/style/end_block.rb +18 -0
  59. data/lib/rubocop/cop/style/end_of_line.rb +23 -0
  60. data/lib/rubocop/cop/style/favor_join.rb +29 -0
  61. data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
  62. data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
  63. data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
  64. data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
  65. data/lib/rubocop/cop/style/if_then_else.rb +80 -0
  66. data/lib/rubocop/cop/style/lambda.rb +47 -0
  67. data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
  68. data/lib/rubocop/cop/style/line_continuation.rb +26 -0
  69. data/lib/rubocop/cop/style/line_length.rb +30 -0
  70. data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
  71. data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
  72. data/lib/rubocop/cop/style/method_length.rb +57 -0
  73. data/lib/rubocop/cop/style/not.rb +24 -0
  74. data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
  75. data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
  76. data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
  77. data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
  78. data/lib/rubocop/cop/style/proc.rb +30 -0
  79. data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
  80. data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
  81. data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
  82. data/lib/rubocop/cop/style/semicolon.rb +51 -0
  83. data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
  84. data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
  85. data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
  86. data/lib/rubocop/cop/style/string_literals.rb +36 -0
  87. data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
  88. data/lib/rubocop/cop/style/symbol_array.rb +31 -0
  89. data/lib/rubocop/cop/style/symbol_name.rb +27 -0
  90. data/lib/rubocop/cop/style/tab.rb +25 -0
  91. data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
  92. data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
  93. data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
  94. data/lib/rubocop/cop/style/unless_else.rb +26 -0
  95. data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
  96. data/lib/rubocop/cop/style/when_then.rb +25 -0
  97. data/lib/rubocop/cop/style/while_until_do.rb +45 -0
  98. data/lib/rubocop/cop/style/word_array.rb +44 -0
  99. data/lib/rubocop/cop/util.rb +1 -0
  100. data/lib/rubocop/cop/variable_inspector.rb +280 -0
  101. data/lib/rubocop/formatter/base_formatter.rb +119 -0
  102. data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
  103. data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
  104. data/lib/rubocop/formatter/formatter_set.rb +77 -0
  105. data/lib/rubocop/formatter/json_formatter.rb +76 -0
  106. data/lib/rubocop/formatter/progress_formatter.rb +63 -0
  107. data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
  108. data/lib/rubocop/version.rb +15 -1
  109. data/lib/rubocop.rb +97 -71
  110. data/rubocop.gemspec +1 -2
  111. data/spec/.rubocop.yml +5 -0
  112. data/spec/project_spec.rb +4 -7
  113. data/spec/rubocop/cli_spec.rb +402 -143
  114. data/spec/rubocop/config_spec.rb +61 -0
  115. data/spec/rubocop/config_store_spec.rb +2 -2
  116. data/spec/rubocop/cops/cop_spec.rb +14 -7
  117. data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
  118. data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
  119. data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
  120. data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
  121. data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
  122. data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
  123. data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
  124. data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
  125. data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
  126. data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
  127. data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
  128. data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
  129. data/spec/rubocop/cops/lint/void_spec.rb +63 -0
  130. data/spec/rubocop/cops/offence_spec.rb +107 -10
  131. data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
  132. data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
  133. data/spec/rubocop/cops/style/alias_spec.rb +47 -0
  134. data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
  135. data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
  136. data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
  137. data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
  138. data/spec/rubocop/cops/style/attr_spec.rb +20 -0
  139. data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
  140. data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
  141. data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
  142. data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
  143. data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
  144. data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
  145. data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
  146. data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
  147. data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
  148. data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
  149. data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
  150. data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
  151. data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
  152. data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
  153. data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
  154. data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
  155. data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
  156. data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
  157. data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
  158. data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
  159. data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
  160. data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
  161. data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
  162. data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
  163. data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
  164. data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
  165. data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
  166. data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
  167. data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
  168. data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
  169. data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
  170. data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
  171. data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
  172. data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
  173. data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
  174. data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
  175. data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
  176. data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
  177. data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
  178. data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
  179. data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
  180. data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
  181. data/spec/rubocop/cops/style/not_spec.rb +28 -0
  182. data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
  183. data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
  184. data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
  185. data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
  186. data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
  187. data/spec/rubocop/cops/style/proc_spec.rb +28 -0
  188. data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
  189. data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
  190. data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
  191. data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
  192. data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
  193. data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
  194. data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
  195. data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
  196. data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
  197. data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
  198. data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
  199. data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
  200. data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
  201. data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
  202. data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
  203. data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
  204. data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
  205. data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
  206. data/spec/rubocop/cops/style/tab_spec.rb +23 -0
  207. data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
  208. data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
  209. data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
  210. data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
  211. data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
  212. data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
  213. data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
  214. data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
  215. data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
  216. data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
  217. data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
  218. data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
  219. data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
  220. data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
  221. data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
  222. data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
  223. data/spec/spec_helper.rb +24 -9
  224. data/spec/support/mri_syntax_checker.rb +69 -0
  225. data/spec/support/shared_examples.rb +33 -0
  226. metadata +317 -239
  227. data/lib/rubocop/cop/access_control.rb +0 -41
  228. data/lib/rubocop/cop/alias.rb +0 -17
  229. data/lib/rubocop/cop/align_parameters.rb +0 -37
  230. data/lib/rubocop/cop/and_or.rb +0 -26
  231. data/lib/rubocop/cop/ascii_comments.rb +0 -13
  232. data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
  233. data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
  234. data/lib/rubocop/cop/avoid_for.rb +0 -17
  235. data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
  236. data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
  237. data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
  238. data/lib/rubocop/cop/block_comments.rb +0 -15
  239. data/lib/rubocop/cop/blocks.rb +0 -23
  240. data/lib/rubocop/cop/case_indentation.rb +0 -22
  241. data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
  242. data/lib/rubocop/cop/class_methods.rb +0 -15
  243. data/lib/rubocop/cop/collection_methods.rb +0 -29
  244. data/lib/rubocop/cop/colon_method_call.rb +0 -20
  245. data/lib/rubocop/cop/constant_name.rb +0 -24
  246. data/lib/rubocop/cop/def_parentheses.rb +0 -62
  247. data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
  248. data/lib/rubocop/cop/empty_lines.rb +0 -34
  249. data/lib/rubocop/cop/empty_literal.rb +0 -47
  250. data/lib/rubocop/cop/encoding.rb +0 -19
  251. data/lib/rubocop/cop/end_of_line.rb +0 -15
  252. data/lib/rubocop/cop/ensure_return.rb +0 -19
  253. data/lib/rubocop/cop/eval.rb +0 -19
  254. data/lib/rubocop/cop/favor_join.rb +0 -22
  255. data/lib/rubocop/cop/favor_modifier.rb +0 -72
  256. data/lib/rubocop/cop/favor_percent_r.rb +0 -19
  257. data/lib/rubocop/cop/favor_sprintf.rb +0 -21
  258. data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
  259. data/lib/rubocop/cop/handle_exceptions.rb +0 -17
  260. data/lib/rubocop/cop/hash_syntax.rb +0 -41
  261. data/lib/rubocop/cop/if_then_else.rb +0 -65
  262. data/lib/rubocop/cop/leading_comment_space.rb +0 -17
  263. data/lib/rubocop/cop/line_continuation.rb +0 -15
  264. data/lib/rubocop/cop/line_length.rb +0 -23
  265. data/lib/rubocop/cop/loop.rb +0 -33
  266. data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
  267. data/lib/rubocop/cop/method_length.rb +0 -52
  268. data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
  269. data/lib/rubocop/cop/not.rb +0 -21
  270. data/lib/rubocop/cop/numeric_literals.rb +0 -21
  271. data/lib/rubocop/cop/parameter_lists.rb +0 -23
  272. data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
  273. data/lib/rubocop/cop/percent_r.rb +0 -19
  274. data/lib/rubocop/cop/reduce_arguments.rb +0 -29
  275. data/lib/rubocop/cop/rescue_exception.rb +0 -26
  276. data/lib/rubocop/cop/rescue_modifier.rb +0 -17
  277. data/lib/rubocop/cop/semicolon.rb +0 -31
  278. data/lib/rubocop/cop/single_line_methods.rb +0 -44
  279. data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
  280. data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
  281. data/lib/rubocop/cop/string_literals.rb +0 -22
  282. data/lib/rubocop/cop/surrounding_space.rb +0 -283
  283. data/lib/rubocop/cop/symbol_array.rb +0 -31
  284. data/lib/rubocop/cop/symbol_name.rb +0 -23
  285. data/lib/rubocop/cop/syntax.rb +0 -49
  286. data/lib/rubocop/cop/tab.rb +0 -15
  287. data/lib/rubocop/cop/ternary_operator.rb +0 -43
  288. data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
  289. data/lib/rubocop/cop/trivial_accessors.rb +0 -26
  290. data/lib/rubocop/cop/unless_else.rb +0 -23
  291. data/lib/rubocop/cop/variable_interpolation.rb +0 -29
  292. data/lib/rubocop/cop/when_then.rb +0 -17
  293. data/lib/rubocop/cop/word_array.rb +0 -37
  294. data/lib/rubocop/report/emacs_style.rb +0 -17
  295. data/lib/rubocop/report/plain_text.rb +0 -18
  296. data/lib/rubocop/report/report.rb +0 -44
  297. data/spec/rubocop/cops/access_control_spec.rb +0 -129
  298. data/spec/rubocop/cops/alias_spec.rb +0 -39
  299. data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
  300. data/spec/rubocop/cops/and_or_spec.rb +0 -37
  301. data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
  302. data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
  303. data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
  304. data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
  305. data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
  306. data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
  307. data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
  308. data/spec/rubocop/cops/block_comments_spec.rb +0 -25
  309. data/spec/rubocop/cops/blocks_spec.rb +0 -33
  310. data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
  311. data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
  312. data/spec/rubocop/cops/class_methods_spec.rb +0 -49
  313. data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
  314. data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
  315. data/spec/rubocop/cops/constant_name_spec.rb +0 -42
  316. data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
  317. data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
  318. data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
  319. data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
  320. data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
  321. data/spec/rubocop/cops/encoding_spec.rb +0 -47
  322. data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
  323. data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
  324. data/spec/rubocop/cops/eval_spec.rb +0 -39
  325. data/spec/rubocop/cops/favor_join_spec.rb +0 -35
  326. data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
  327. data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
  328. data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
  329. data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
  330. data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
  331. data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
  332. data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
  333. data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
  334. data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
  335. data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
  336. data/spec/rubocop/cops/line_length_spec.rb +0 -23
  337. data/spec/rubocop/cops/loop_spec.rb +0 -31
  338. data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
  339. data/spec/rubocop/cops/method_length_spec.rb +0 -147
  340. data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
  341. data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
  342. data/spec/rubocop/cops/not_spec.rb +0 -31
  343. data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
  344. data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
  345. data/spec/rubocop/cops/op_method_spec.rb +0 -78
  346. data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
  347. data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
  348. data/spec/rubocop/cops/percent_r_spec.rb +0 -29
  349. data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
  350. data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
  351. data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
  352. data/spec/rubocop/cops/semicolon_spec.rb +0 -88
  353. data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
  354. data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
  355. data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
  356. data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
  357. data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
  358. data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
  359. data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
  360. data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
  361. data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
  362. data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
  363. data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
  364. data/spec/rubocop/cops/string_literals_spec.rb +0 -47
  365. data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
  366. data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
  367. data/spec/rubocop/cops/syntax_spec.rb +0 -41
  368. data/spec/rubocop/cops/tab_spec.rb +0 -21
  369. data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
  370. data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
  371. data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
  372. data/spec/rubocop/cops/unless_else_spec.rb +0 -29
  373. data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
  374. data/spec/rubocop/cops/when_then_spec.rb +0 -38
  375. data/spec/rubocop/cops/word_array_spec.rb +0 -47
  376. data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
  377. data/spec/rubocop/reports/report_spec.rb +0 -29
@@ -1,197 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AlignParameters do
8
- let(:align) { AlignParameters.new }
9
-
10
- it 'registers an offence for parameters with single indent' do
11
- inspect_source(align, ['function(a,',
12
- ' if b then c else d end)'])
13
- expect(align.offences.size).to eq(1)
14
- end
15
-
16
- it 'registers an offence for parameters with double indent' do
17
- inspect_source(align, ['function(a,',
18
- ' if b then c else d end)'])
19
- expect(align.offences.size).to eq(1)
20
- end
21
-
22
- it 'accepts multiline []= method call' do
23
- inspect_source(align, ['Test.config["something"] =',
24
- ' true'])
25
- expect(align.offences).to be_empty
26
- end
27
-
28
- it 'accepts correctly aligned parameters' do
29
- inspect_source(align, ['function(a,',
30
- ' 0, 1,',
31
- ' (x + y),',
32
- ' if b then c else d end)'])
33
- expect(align.offences).to be_empty
34
- end
35
-
36
- it 'accepts calls that only span one line' do
37
- inspect_source(align, ['find(path, s, @special[sexp[0]])'])
38
- expect(align.offences).to be_empty
39
- end
40
-
41
- it "doesn't get confused by a symbol argument" do
42
- inspect_source(align,
43
- ['add_offence(:convention, index,',
44
- ' MSG % kind)'])
45
- expect(align.offences).to be_empty
46
- end
47
-
48
- it "doesn't get confused by splat operator" do
49
- inspect_source(align,
50
- ['func1(*a,',
51
- ' *b,',
52
- ' c)',
53
- 'func2(a,',
54
- ' *b,',
55
- ' c)',
56
- 'func3(*a)',
57
- ])
58
- expect(align.offences.map(&:to_s)).to eq(
59
- ['C: 5: Align the parameters of a method call if they span ' +
60
- 'more than one line.'])
61
- end
62
-
63
- it "doesn't get confused by extra comma at the end" do
64
- inspect_source(align,
65
- ['func1(a,',
66
- ' b,)'])
67
- expect(align.offences.map(&:to_s)).to eq(
68
- ['C: 2: Align the parameters of a method call if they span ' +
69
- 'more than one line.'])
70
- end
71
-
72
- it 'can handle a correctly aligned string literal as first argument' do
73
- inspect_source(align,
74
- ['add_offence(:convention, x,',
75
- ' a)'])
76
- expect(align.offences).to be_empty
77
- end
78
-
79
- it 'can handle a string literal as other argument' do
80
- inspect_source(align,
81
- ['add_offence(:convention,',
82
- ' "", a)'])
83
- expect(align.offences).to be_empty
84
- end
85
-
86
- it "doesn't get confused by a line break inside a parameter" do
87
- inspect_source(align,
88
- ['read(path, { headers: true,',
89
- ' converters: :numeric })'])
90
- expect(align.offences).to be_empty
91
- end
92
-
93
- it "doesn't get confused by symbols with embedded expressions" do
94
- inspect_source(align,
95
- ['send(:"#{name}_comments_path")'])
96
- expect(align.offences).to be_empty
97
- end
98
-
99
- it "doesn't get confused by regexen with embedded expressions" do
100
- inspect_source(align,
101
- ['a(/#{name}/)'])
102
- expect(align.offences).to be_empty
103
- end
104
-
105
- it 'accepts braceless hashes' do
106
- inspect_source(align,
107
- ['run(collection, :entry_name => label,',
108
- ' :paginator => paginator)'])
109
- expect(align.offences).to be_empty
110
- end
111
-
112
- it 'accepts the first parameter being on a new row' do
113
- inspect_source(align,
114
- [' match(',
115
- ' a,',
116
- ' b',
117
- ' )'])
118
- expect(align.offences).to be_empty
119
- end
120
-
121
- it 'can handle heredoc strings' do
122
- src = ['class_eval(<<-EOS, __FILE__, __LINE__ + 1)',
123
- ' def run_#{name}_callbacks(*args)',
124
- ' a = 1',
125
- ' return value',
126
- ' end',
127
- ' EOS']
128
- inspect_source(align, src)
129
- expect(align.offences).to be_empty
130
- end
131
-
132
- it 'can handle a method call within a method call' do
133
- inspect_source(align,
134
- ['a(a1,',
135
- ' b(b1,',
136
- ' b2),',
137
- ' a2)'])
138
- expect(align.offences).to be_empty
139
- end
140
-
141
- it 'can handle a call embedded in a string' do
142
- inspect_source(align,
143
- ['model("#{index(name)}", child)'])
144
- expect(align.offences).to be_empty
145
- end
146
-
147
- it 'can handle do-end' do
148
- inspect_source(align,
149
- [' run(lambda do |e|',
150
- " w = e['warden']",
151
- ' end)'])
152
- expect(align.offences).to be_empty
153
- end
154
-
155
- it 'can handle a call with a block inside another call' do
156
- src = ['new(table_name,',
157
- ' exec_query("info(\'#{row[\'name\']}\')").map { |col|',
158
- " col['name']",
159
- ' })']
160
- inspect_source(align, src)
161
- expect(align.offences).to be_empty
162
- end
163
-
164
- it 'can handle a ternary condition with a block reference' do
165
- src = ['cond ? a : func(&b)']
166
- inspect_source(align, src)
167
- expect(align.offences).to be_empty
168
- end
169
-
170
- it 'can handle parentheses used with no parameters' do
171
- src = ['func()']
172
- inspect_source(align, src)
173
- expect(align.offences).to be_empty
174
- end
175
-
176
- it 'can handle a multiline hash as second parameter' do
177
- src = ['tag(:input, {',
178
- ' :value => value',
179
- '})']
180
- inspect_source(align, src)
181
- expect(align.offences).to be_empty
182
- end
183
-
184
- it 'can handle method calls without parentheses' do
185
- src = ['a(b c, d)']
186
- inspect_source(align, src)
187
- expect(align.offences).to be_empty
188
- end
189
-
190
- it 'can handle other method calls without parentheses' do
191
- src = ['chars(Unicode.apply_mapping @wrapped_string, :uppercase)']
192
- inspect_source(align, src)
193
- expect(align.offences).to be_empty
194
- end
195
- end
196
- end
197
- end
@@ -1,37 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AndOr do
8
- let(:amp) { AndOr.new }
9
-
10
- it 'registers an offence for OR' do
11
- inspect_source(amp,
12
- ['test if a or b'])
13
- expect(amp.offences.size).to eq(1)
14
- expect(amp.messages).to eq(['Use || instead of or.'])
15
- end
16
-
17
- it 'registers an offence for AND' do
18
- inspect_source(amp,
19
- ['test if a and b'])
20
- expect(amp.offences.size).to eq(1)
21
- expect(amp.messages).to eq(['Use && instead of and.'])
22
- end
23
-
24
- it 'accepts ||' do
25
- inspect_source(amp,
26
- ['test if a || b'])
27
- expect(amp.offences).to be_empty
28
- end
29
-
30
- it 'accepts &&' do
31
- inspect_source(amp,
32
- ['test if a && b'])
33
- expect(amp.offences).to be_empty
34
- end
35
- end
36
- end
37
- end
@@ -1,26 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AsciiComments do
8
- let(:ascii) { AsciiComments.new }
9
-
10
- it 'registers an offence for a comment with non-ascii chars' do
11
- inspect_source(ascii,
12
- ['# encoding: utf-8',
13
- '# 这是什么?'])
14
- expect(ascii.offences.size).to eq(1)
15
- expect(ascii.offences.map(&:message))
16
- .to eq([AsciiComments::MSG])
17
- end
18
-
19
- it 'accepts comments with only ascii chars' do
20
- inspect_source(ascii,
21
- ['# AZaz1@$%~,;*_`|'])
22
- expect(ascii.offences).to be_empty
23
- end
24
- end
25
- end
26
- end
@@ -1,26 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AsciiIdentifiers do
8
- let(:ascii) { AsciiIdentifiers.new }
9
-
10
- it 'registers an offence for a variable name with non-ascii chars' do
11
- inspect_source(ascii,
12
- ['# encoding: utf-8',
13
- 'älg = 1'])
14
- expect(ascii.offences.size).to eq(1)
15
- expect(ascii.offences.map(&:message))
16
- .to eq([AsciiIdentifiers::MSG])
17
- end
18
-
19
- it 'accepts identifiers with only ascii chars' do
20
- inspect_source(ascii,
21
- ['x.empty?'])
22
- expect(ascii.offences).to be_empty
23
- end
24
- end
25
- end
26
- end
@@ -1,25 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AvoidClassVars do
8
- let(:acv) { AvoidClassVars.new }
9
-
10
- it 'registers an offence for class variable declaration' do
11
- inspect_source(acv,
12
- ['class TestClass; @@test = 10; end'])
13
- expect(acv.offences.size).to eq(1)
14
- expect(acv.offences.map(&:message))
15
- .to eq(['Replace class var @@test with a class instance var.'])
16
- end
17
-
18
- it 'does not register an offence for class variable usage' do
19
- inspect_source(acv,
20
- ['@@test.test(20)'])
21
- expect(acv.offences).to be_empty
22
- end
23
- end
24
- end
25
- end
@@ -1,35 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AvoidFor do
8
- let(:af) { AvoidFor.new }
9
-
10
- it 'registers an offence for for' do
11
- inspect_source(af,
12
- ['def func',
13
- ' for n in [1, 2, 3] do',
14
- ' puts n',
15
- ' end',
16
- 'end'])
17
- expect(af.offences.size).to eq(1)
18
- expect(af.offences.map(&:message))
19
- .to eq([AvoidFor::MSG])
20
- end
21
-
22
- it 'does not register an offence for :for' do
23
- inspect_source(af,
24
- ['[:for, :ala, :bala]'])
25
- expect(af.offences).to be_empty
26
- end
27
-
28
- it 'does not register an offence for def for' do
29
- inspect_source(af,
30
- ['def for; end'])
31
- expect(af.offences).to be_empty
32
- end
33
- end
34
- end
35
- end
@@ -1,32 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AvoidGlobalVars do
8
- let(:ap) { AvoidGlobalVars.new }
9
-
10
- it 'registers an offence for $custom' do
11
- inspect_source(ap, ['puts $custom'])
12
- expect(ap.offences.size).to eq(1)
13
- end
14
-
15
- it 'does not register an offence for $"' do
16
- inspect_source(ap, ['puts $"'])
17
-
18
- expect(ap.offences).to be_empty
19
- end
20
-
21
- it 'does not register an offence for $ORS' do
22
- inspect_source(ap, ['puts $0'])
23
- expect(ap.offences).to be_empty
24
- end
25
-
26
- it 'does not register an offence for backrefs like $1' do
27
- inspect_source(ap, ['puts $1'])
28
- expect(ap.offences).to be_empty
29
- end
30
- end
31
- end
32
- end
@@ -1,18 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AvoidPerlBackrefs do
8
- let(:ap) { AvoidPerlBackrefs.new }
9
-
10
- it 'registers an offence for $1' do
11
- inspect_source(ap, ['puts $1'])
12
- expect(ap.offences.size).to eq(1)
13
- expect(ap.offences.map(&:message))
14
- .to eq(['Prefer the use of MatchData over $1.'])
15
- end
16
- end
17
- end
18
- end
@@ -1,44 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe AvoidPerlisms do
8
- let(:ap) { AvoidPerlisms.new }
9
-
10
- it 'registers an offence for $:' do
11
- inspect_source(ap, ['puts $:'])
12
- expect(ap.offences.size).to eq(1)
13
- expect(ap.offences.map(&:message))
14
- .to eq(['Prefer $LOAD_PATH over $:.'])
15
- end
16
-
17
- it 'registers an offence for $"' do
18
- inspect_source(ap, ['puts $"'])
19
- expect(ap.offences.size).to eq(1)
20
- expect(ap.offences.map(&:message))
21
- .to eq(['Prefer $LOADED_FEATURES over $".'])
22
- end
23
-
24
- it 'registers an offence for $0' do
25
- inspect_source(ap, ['puts $0'])
26
- expect(ap.offences.size).to eq(1)
27
- expect(ap.offences.map(&:message))
28
- .to eq(['Prefer $PROGRAM_NAME over $0.'])
29
- end
30
-
31
- it 'registers an offence for $$' do
32
- inspect_source(ap, ['puts $$'])
33
- expect(ap.offences.size).to eq(1)
34
- expect(ap.offences.map(&:message))
35
- .to eq(['Prefer $PID or $PROCESS_ID from English library over $$.'])
36
- end
37
-
38
- it 'does not register an offence for backrefs like $1' do
39
- inspect_source(ap, ['puts $1'])
40
- expect(ap.offences).to be_empty
41
- end
42
- end
43
- end
44
- end
@@ -1,25 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe BlockComments do
8
- let(:block) { BlockComments.new }
9
-
10
- it 'registers an offence for block comments' do
11
- inspect_source(block,
12
- ['=begin',
13
- 'comment',
14
- '=end'])
15
- expect(block.offences.size).to eq(1)
16
- end
17
-
18
- it 'accepts regular comments' do
19
- inspect_source(block,
20
- ['# comment'])
21
- expect(block.offences).to be_empty
22
- end
23
- end
24
- end
25
- end
@@ -1,33 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe Blocks do
8
- let(:blocks) { Blocks.new }
9
-
10
- it 'registers an offence for a multiline block with braces' do
11
- inspect_source(blocks, ['each { |x|',
12
- '}'])
13
- expect(blocks.messages).to eq([Blocks::MULTI_LINE_MSG])
14
- end
15
-
16
- it 'accepts a multiline block with do-end' do
17
- inspect_source(blocks, ['each do |x|',
18
- 'end'])
19
- expect(blocks.offences.map(&:message)).to be_empty
20
- end
21
-
22
- it 'registers an offence for a single line block with do-end' do
23
- inspect_source(blocks, ['each do |x| end'])
24
- expect(blocks.messages).to eq([Blocks::SINGLE_LINE_MSG])
25
- end
26
-
27
- it 'accepts a single line block with braces' do
28
- inspect_source(blocks, ['each { |x| }'])
29
- expect(blocks.offences.map(&:message)).to be_empty
30
- end
31
- end
32
- end
33
- end
@@ -1,86 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe CaseIndentation do
8
- let(:ind) { CaseIndentation.new }
9
-
10
- it "registers an offence for a when clause that's deeper than case" do
11
- source = ['case a',
12
- ' when 0 then return',
13
- ' case b',
14
- ' when 1 then return',
15
- ' end',
16
- 'end']
17
- inspect_source(ind, source)
18
- expect(ind.offences.map(&:message)).to eq(
19
- ['Indent when as deep as case.'] * 2)
20
- end
21
-
22
- it "accepts a when clause that's equally indented with case" do
23
- source = ['y = case a',
24
- ' when 0 then break',
25
- ' when 0 then return',
26
- ' z = case b',
27
- ' when 1 then return',
28
- ' when 1 then break',
29
- ' end',
30
- ' end',
31
- 'case c',
32
- 'when 2 then encoding',
33
- 'end',
34
- '']
35
- inspect_source(ind, source)
36
- expect(ind.offences).to be_empty
37
- end
38
-
39
- it "doesn't get confused by strings with case in them" do
40
- source = ['a = "case"',
41
- 'case x',
42
- 'when 0',
43
- 'end',
44
- '']
45
- inspect_source(ind, source)
46
- expect(ind.offences.map(&:message)).to be_empty
47
- end
48
-
49
- it "doesn't get confused by symbols named case or when" do
50
- source = ['KEYWORDS = { :case => true, :when => true }',
51
- 'case type',
52
- 'when 0',
53
- ' ParameterNode',
54
- 'when 1',
55
- ' MethodCallNode',
56
- 'end',
57
- '']
58
- inspect_source(ind, source)
59
- expect(ind.offences.map(&:message)).to be_empty
60
- end
61
-
62
- it 'accepts correctly indented whens in complex combinations' do
63
- source = ['each {',
64
- ' case state',
65
- ' when 0',
66
- ' case name',
67
- ' when :a',
68
- ' end',
69
- ' when 1',
70
- ' loop {',
71
- ' case name',
72
- ' when :b',
73
- ' end',
74
- ' }',
75
- ' end',
76
- '}',
77
- 'case s',
78
- 'when Array',
79
- 'end',
80
- '']
81
- inspect_source(ind, source)
82
- expect(ind.offences.map(&:message)).to be_empty
83
- end
84
- end
85
- end
86
- end
@@ -1,44 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe ClassAndModuleCamelCase do
8
- let(:camel_case) { ClassAndModuleCamelCase.new }
9
-
10
- it 'registers an offence for underscore in class and module name' do
11
- inspect_source(camel_case,
12
- ['class My_Class',
13
- 'end',
14
- '',
15
- 'module My_Module',
16
- 'end',
17
- ])
18
- expect(camel_case.offences.size).to eq(2)
19
- end
20
-
21
- it 'is not fooled by qualified names' do
22
- inspect_source(camel_case,
23
- ['class Top::My_Class',
24
- 'end',
25
- '',
26
- 'module My_Module::Ala',
27
- 'end',
28
- ])
29
- expect(camel_case.offences.size).to eq(2)
30
- end
31
-
32
- it 'accepts CamelCase names' do
33
- inspect_source(camel_case,
34
- ['class MyClass',
35
- 'end',
36
- '',
37
- 'module Mine',
38
- 'end',
39
- ])
40
- expect(camel_case.offences).to be_empty
41
- end
42
- end
43
- end
44
- end
@@ -1,49 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe ClassMethods do
8
- let(:cm) { ClassMethods.new }
9
-
10
- it 'registers an offence for methods using a class name' do
11
- inspect_source(cm,
12
- ['class Test',
13
- ' def Test.some_method',
14
- ' do_something',
15
- ' end',
16
- 'end'])
17
- expect(cm.offences.size).to eq(1)
18
- end
19
-
20
- it 'registers an offence for methods using a module name' do
21
- inspect_source(cm,
22
- ['module Test',
23
- ' def Test.some_method',
24
- ' do_something',
25
- ' end',
26
- 'end'])
27
- expect(cm.offences.size).to eq(1)
28
- end
29
-
30
- it 'does not register an offence for methods using self' do
31
- inspect_source(cm,
32
- ['module Test',
33
- ' def self.some_method',
34
- ' do_something',
35
- ' end',
36
- 'end'])
37
- expect(cm.offences).to be_empty
38
- end
39
-
40
- it 'does not register an offence outside class/module bodies' do
41
- inspect_source(cm,
42
- ['def self.some_method',
43
- ' do_something',
44
- 'end'])
45
- expect(cm.offences).to be_empty
46
- end
47
- end
48
- end
49
- end