rubocop 0.8.0 → 0.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (377) hide show
  1. checksums.yaml +4 -4
  2. data/.travis.yml +0 -4
  3. data/.yardopts +2 -0
  4. data/CHANGELOG.md +95 -1
  5. data/README.md +101 -11
  6. data/config/default.yml +14 -2
  7. data/config/enabled.yml +96 -14
  8. data/lib/rubocop/cli.rb +178 -94
  9. data/lib/rubocop/config.rb +56 -11
  10. data/lib/rubocop/config_store.rb +2 -0
  11. data/lib/rubocop/cop/cop.rb +54 -11
  12. data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
  13. data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
  14. data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
  15. data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
  16. data/lib/rubocop/cop/lint/eval.rb +22 -0
  17. data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
  18. data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
  19. data/lib/rubocop/cop/lint/loop.rb +29 -0
  20. data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
  21. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
  22. data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
  23. data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
  24. data/lib/rubocop/cop/lint/void.rb +58 -0
  25. data/lib/rubocop/cop/offence.rb +112 -12
  26. data/lib/rubocop/cop/rails/validation.rb +34 -0
  27. data/lib/rubocop/cop/style/access_control.rb +58 -0
  28. data/lib/rubocop/cop/style/alias.rb +28 -0
  29. data/lib/rubocop/cop/style/align_parameters.rb +39 -0
  30. data/lib/rubocop/cop/style/and_or.rb +45 -0
  31. data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
  32. data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
  33. data/lib/rubocop/cop/style/attr.rb +20 -0
  34. data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
  35. data/lib/rubocop/cop/style/avoid_for.rb +18 -0
  36. data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
  37. data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
  38. data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
  39. data/lib/rubocop/cop/style/begin_block.rb +18 -0
  40. data/lib/rubocop/cop/style/block_comments.rb +20 -0
  41. data/lib/rubocop/cop/style/block_nesting.rb +47 -0
  42. data/lib/rubocop/cop/style/blocks.rb +27 -0
  43. data/lib/rubocop/cop/style/case_equality.rb +22 -0
  44. data/lib/rubocop/cop/style/case_indentation.rb +28 -0
  45. data/lib/rubocop/cop/style/character_literal.rb +37 -0
  46. data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
  47. data/lib/rubocop/cop/style/class_methods.rb +22 -0
  48. data/lib/rubocop/cop/style/collection_methods.rb +37 -0
  49. data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
  50. data/lib/rubocop/cop/style/constant_name.rb +31 -0
  51. data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
  52. data/lib/rubocop/cop/style/documentation.rb +58 -0
  53. data/lib/rubocop/cop/style/dot_position.rb +25 -0
  54. data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
  55. data/lib/rubocop/cop/style/empty_lines.rb +40 -0
  56. data/lib/rubocop/cop/style/empty_literal.rb +53 -0
  57. data/lib/rubocop/cop/style/encoding.rb +29 -0
  58. data/lib/rubocop/cop/style/end_block.rb +18 -0
  59. data/lib/rubocop/cop/style/end_of_line.rb +23 -0
  60. data/lib/rubocop/cop/style/favor_join.rb +29 -0
  61. data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
  62. data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
  63. data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
  64. data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
  65. data/lib/rubocop/cop/style/if_then_else.rb +80 -0
  66. data/lib/rubocop/cop/style/lambda.rb +47 -0
  67. data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
  68. data/lib/rubocop/cop/style/line_continuation.rb +26 -0
  69. data/lib/rubocop/cop/style/line_length.rb +30 -0
  70. data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
  71. data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
  72. data/lib/rubocop/cop/style/method_length.rb +57 -0
  73. data/lib/rubocop/cop/style/not.rb +24 -0
  74. data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
  75. data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
  76. data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
  77. data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
  78. data/lib/rubocop/cop/style/proc.rb +30 -0
  79. data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
  80. data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
  81. data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
  82. data/lib/rubocop/cop/style/semicolon.rb +51 -0
  83. data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
  84. data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
  85. data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
  86. data/lib/rubocop/cop/style/string_literals.rb +36 -0
  87. data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
  88. data/lib/rubocop/cop/style/symbol_array.rb +31 -0
  89. data/lib/rubocop/cop/style/symbol_name.rb +27 -0
  90. data/lib/rubocop/cop/style/tab.rb +25 -0
  91. data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
  92. data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
  93. data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
  94. data/lib/rubocop/cop/style/unless_else.rb +26 -0
  95. data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
  96. data/lib/rubocop/cop/style/when_then.rb +25 -0
  97. data/lib/rubocop/cop/style/while_until_do.rb +45 -0
  98. data/lib/rubocop/cop/style/word_array.rb +44 -0
  99. data/lib/rubocop/cop/util.rb +1 -0
  100. data/lib/rubocop/cop/variable_inspector.rb +280 -0
  101. data/lib/rubocop/formatter/base_formatter.rb +119 -0
  102. data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
  103. data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
  104. data/lib/rubocop/formatter/formatter_set.rb +77 -0
  105. data/lib/rubocop/formatter/json_formatter.rb +76 -0
  106. data/lib/rubocop/formatter/progress_formatter.rb +63 -0
  107. data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
  108. data/lib/rubocop/version.rb +15 -1
  109. data/lib/rubocop.rb +97 -71
  110. data/rubocop.gemspec +1 -2
  111. data/spec/.rubocop.yml +5 -0
  112. data/spec/project_spec.rb +4 -7
  113. data/spec/rubocop/cli_spec.rb +402 -143
  114. data/spec/rubocop/config_spec.rb +61 -0
  115. data/spec/rubocop/config_store_spec.rb +2 -2
  116. data/spec/rubocop/cops/cop_spec.rb +14 -7
  117. data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
  118. data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
  119. data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
  120. data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
  121. data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
  122. data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
  123. data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
  124. data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
  125. data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
  126. data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
  127. data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
  128. data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
  129. data/spec/rubocop/cops/lint/void_spec.rb +63 -0
  130. data/spec/rubocop/cops/offence_spec.rb +107 -10
  131. data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
  132. data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
  133. data/spec/rubocop/cops/style/alias_spec.rb +47 -0
  134. data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
  135. data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
  136. data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
  137. data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
  138. data/spec/rubocop/cops/style/attr_spec.rb +20 -0
  139. data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
  140. data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
  141. data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
  142. data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
  143. data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
  144. data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
  145. data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
  146. data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
  147. data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
  148. data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
  149. data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
  150. data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
  151. data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
  152. data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
  153. data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
  154. data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
  155. data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
  156. data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
  157. data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
  158. data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
  159. data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
  160. data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
  161. data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
  162. data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
  163. data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
  164. data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
  165. data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
  166. data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
  167. data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
  168. data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
  169. data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
  170. data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
  171. data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
  172. data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
  173. data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
  174. data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
  175. data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
  176. data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
  177. data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
  178. data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
  179. data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
  180. data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
  181. data/spec/rubocop/cops/style/not_spec.rb +28 -0
  182. data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
  183. data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
  184. data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
  185. data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
  186. data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
  187. data/spec/rubocop/cops/style/proc_spec.rb +28 -0
  188. data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
  189. data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
  190. data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
  191. data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
  192. data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
  193. data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
  194. data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
  195. data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
  196. data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
  197. data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
  198. data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
  199. data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
  200. data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
  201. data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
  202. data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
  203. data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
  204. data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
  205. data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
  206. data/spec/rubocop/cops/style/tab_spec.rb +23 -0
  207. data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
  208. data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
  209. data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
  210. data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
  211. data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
  212. data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
  213. data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
  214. data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
  215. data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
  216. data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
  217. data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
  218. data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
  219. data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
  220. data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
  221. data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
  222. data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
  223. data/spec/spec_helper.rb +24 -9
  224. data/spec/support/mri_syntax_checker.rb +69 -0
  225. data/spec/support/shared_examples.rb +33 -0
  226. metadata +317 -239
  227. data/lib/rubocop/cop/access_control.rb +0 -41
  228. data/lib/rubocop/cop/alias.rb +0 -17
  229. data/lib/rubocop/cop/align_parameters.rb +0 -37
  230. data/lib/rubocop/cop/and_or.rb +0 -26
  231. data/lib/rubocop/cop/ascii_comments.rb +0 -13
  232. data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
  233. data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
  234. data/lib/rubocop/cop/avoid_for.rb +0 -17
  235. data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
  236. data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
  237. data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
  238. data/lib/rubocop/cop/block_comments.rb +0 -15
  239. data/lib/rubocop/cop/blocks.rb +0 -23
  240. data/lib/rubocop/cop/case_indentation.rb +0 -22
  241. data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
  242. data/lib/rubocop/cop/class_methods.rb +0 -15
  243. data/lib/rubocop/cop/collection_methods.rb +0 -29
  244. data/lib/rubocop/cop/colon_method_call.rb +0 -20
  245. data/lib/rubocop/cop/constant_name.rb +0 -24
  246. data/lib/rubocop/cop/def_parentheses.rb +0 -62
  247. data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
  248. data/lib/rubocop/cop/empty_lines.rb +0 -34
  249. data/lib/rubocop/cop/empty_literal.rb +0 -47
  250. data/lib/rubocop/cop/encoding.rb +0 -19
  251. data/lib/rubocop/cop/end_of_line.rb +0 -15
  252. data/lib/rubocop/cop/ensure_return.rb +0 -19
  253. data/lib/rubocop/cop/eval.rb +0 -19
  254. data/lib/rubocop/cop/favor_join.rb +0 -22
  255. data/lib/rubocop/cop/favor_modifier.rb +0 -72
  256. data/lib/rubocop/cop/favor_percent_r.rb +0 -19
  257. data/lib/rubocop/cop/favor_sprintf.rb +0 -21
  258. data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
  259. data/lib/rubocop/cop/handle_exceptions.rb +0 -17
  260. data/lib/rubocop/cop/hash_syntax.rb +0 -41
  261. data/lib/rubocop/cop/if_then_else.rb +0 -65
  262. data/lib/rubocop/cop/leading_comment_space.rb +0 -17
  263. data/lib/rubocop/cop/line_continuation.rb +0 -15
  264. data/lib/rubocop/cop/line_length.rb +0 -23
  265. data/lib/rubocop/cop/loop.rb +0 -33
  266. data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
  267. data/lib/rubocop/cop/method_length.rb +0 -52
  268. data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
  269. data/lib/rubocop/cop/not.rb +0 -21
  270. data/lib/rubocop/cop/numeric_literals.rb +0 -21
  271. data/lib/rubocop/cop/parameter_lists.rb +0 -23
  272. data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
  273. data/lib/rubocop/cop/percent_r.rb +0 -19
  274. data/lib/rubocop/cop/reduce_arguments.rb +0 -29
  275. data/lib/rubocop/cop/rescue_exception.rb +0 -26
  276. data/lib/rubocop/cop/rescue_modifier.rb +0 -17
  277. data/lib/rubocop/cop/semicolon.rb +0 -31
  278. data/lib/rubocop/cop/single_line_methods.rb +0 -44
  279. data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
  280. data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
  281. data/lib/rubocop/cop/string_literals.rb +0 -22
  282. data/lib/rubocop/cop/surrounding_space.rb +0 -283
  283. data/lib/rubocop/cop/symbol_array.rb +0 -31
  284. data/lib/rubocop/cop/symbol_name.rb +0 -23
  285. data/lib/rubocop/cop/syntax.rb +0 -49
  286. data/lib/rubocop/cop/tab.rb +0 -15
  287. data/lib/rubocop/cop/ternary_operator.rb +0 -43
  288. data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
  289. data/lib/rubocop/cop/trivial_accessors.rb +0 -26
  290. data/lib/rubocop/cop/unless_else.rb +0 -23
  291. data/lib/rubocop/cop/variable_interpolation.rb +0 -29
  292. data/lib/rubocop/cop/when_then.rb +0 -17
  293. data/lib/rubocop/cop/word_array.rb +0 -37
  294. data/lib/rubocop/report/emacs_style.rb +0 -17
  295. data/lib/rubocop/report/plain_text.rb +0 -18
  296. data/lib/rubocop/report/report.rb +0 -44
  297. data/spec/rubocop/cops/access_control_spec.rb +0 -129
  298. data/spec/rubocop/cops/alias_spec.rb +0 -39
  299. data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
  300. data/spec/rubocop/cops/and_or_spec.rb +0 -37
  301. data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
  302. data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
  303. data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
  304. data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
  305. data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
  306. data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
  307. data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
  308. data/spec/rubocop/cops/block_comments_spec.rb +0 -25
  309. data/spec/rubocop/cops/blocks_spec.rb +0 -33
  310. data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
  311. data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
  312. data/spec/rubocop/cops/class_methods_spec.rb +0 -49
  313. data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
  314. data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
  315. data/spec/rubocop/cops/constant_name_spec.rb +0 -42
  316. data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
  317. data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
  318. data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
  319. data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
  320. data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
  321. data/spec/rubocop/cops/encoding_spec.rb +0 -47
  322. data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
  323. data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
  324. data/spec/rubocop/cops/eval_spec.rb +0 -39
  325. data/spec/rubocop/cops/favor_join_spec.rb +0 -35
  326. data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
  327. data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
  328. data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
  329. data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
  330. data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
  331. data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
  332. data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
  333. data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
  334. data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
  335. data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
  336. data/spec/rubocop/cops/line_length_spec.rb +0 -23
  337. data/spec/rubocop/cops/loop_spec.rb +0 -31
  338. data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
  339. data/spec/rubocop/cops/method_length_spec.rb +0 -147
  340. data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
  341. data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
  342. data/spec/rubocop/cops/not_spec.rb +0 -31
  343. data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
  344. data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
  345. data/spec/rubocop/cops/op_method_spec.rb +0 -78
  346. data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
  347. data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
  348. data/spec/rubocop/cops/percent_r_spec.rb +0 -29
  349. data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
  350. data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
  351. data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
  352. data/spec/rubocop/cops/semicolon_spec.rb +0 -88
  353. data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
  354. data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
  355. data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
  356. data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
  357. data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
  358. data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
  359. data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
  360. data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
  361. data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
  362. data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
  363. data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
  364. data/spec/rubocop/cops/string_literals_spec.rb +0 -47
  365. data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
  366. data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
  367. data/spec/rubocop/cops/syntax_spec.rb +0 -41
  368. data/spec/rubocop/cops/tab_spec.rb +0 -21
  369. data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
  370. data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
  371. data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
  372. data/spec/rubocop/cops/unless_else_spec.rb +0 -29
  373. data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
  374. data/spec/rubocop/cops/when_then_spec.rb +0 -38
  375. data/spec/rubocop/cops/word_array_spec.rb +0 -47
  376. data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
  377. data/spec/rubocop/reports/report_spec.rb +0 -29
@@ -2,34 +2,134 @@
2
2
 
3
3
  module Rubocop
4
4
  module Cop
5
+ # An Offence represents a style violation detected by RuboCop.
5
6
  class Offence
6
- attr_accessor :severity, :line_number, :message
7
+ include Comparable
7
8
 
9
+ # @api private
8
10
  SEVERITIES = [:refactor, :convention, :warning, :error, :fatal]
9
11
 
10
- def initialize(severity, line_number, message)
11
- @severity = severity
12
- @line_number = line_number
13
- @message = message
12
+ # @api public
13
+ #
14
+ # @!attribute [r] severity
15
+ #
16
+ # @return [Symbol]
17
+ # severity.
18
+ # any of `:refactor`, `:convention`, `:warning`, `:error` or `:fatal`.
19
+ attr_reader :severity
20
+
21
+ # @api public
22
+ #
23
+ # @!attribute [r] location
24
+ #
25
+ # @return [Parser::Source::Range]
26
+ # the location where the violation is detected.
27
+ #
28
+ # @see http://rubydoc.info/github/whitequark/parser/Parser/Source/Range
29
+ # Parser::Source::Range
30
+ attr_reader :location
31
+
32
+ # @api public
33
+ #
34
+ # @!attribute [r] message
35
+ #
36
+ # @return [String]
37
+ # human-readable message
38
+ #
39
+ # @example
40
+ # 'Line is too long. [90/79]'
41
+ attr_reader :message
42
+
43
+ # @api public
44
+ #
45
+ # @!attribute [r] cop_name
46
+ #
47
+ # @return [String]
48
+ # a cop class name without namespace.
49
+ # i.e. type of the violation.
50
+ #
51
+ # @example
52
+ # 'LineLength'
53
+ attr_reader :cop_name
54
+
55
+ # @api private
56
+ attr_reader :line
57
+
58
+ # @api private
59
+ attr_reader :column
60
+
61
+ # @api private
62
+ def initialize(severity, location, message, cop_name)
63
+ unless SEVERITIES.include?(severity)
64
+ fail ArgumentError, "Unknown severity: #{severity}"
65
+ end
66
+ @severity = severity.freeze
67
+ @location = location.freeze
68
+ @line = location.line.freeze
69
+ @column = location.column.freeze
70
+ @message = message.freeze
71
+ @cop_name = cop_name.freeze
72
+ freeze
14
73
  end
15
74
 
75
+ # @api private
16
76
  def to_s
17
- # we must be wary of messages containing % in them
18
- sprintf("#{encode_severity}:%3d: #{message.gsub(/%/, '%%')}",
19
- line_number)
77
+ sprintf("#{encode_severity}:%3d:%3d: %s",
78
+ line, real_column, message)
20
79
  end
21
80
 
81
+ # @api private
22
82
  def encode_severity
23
83
  @severity.to_s[0].upcase
24
84
  end
25
85
 
86
+ # @api private
87
+ def clang_severity
88
+ case @severity
89
+ when :fatal then 'F'.color(:red)
90
+ when :error then 'E'.color(:red)
91
+ when :warning then 'W'.color(:magenta)
92
+ when :convention then 'C'.color(:yellow)
93
+ end
94
+ end
95
+
96
+ # @api private
97
+ def severity_level
98
+ SEVERITIES.index(severity) + 1
99
+ end
100
+
101
+ # @api private
102
+ #
103
+ # Internally we use column number that start at 0, but when
104
+ # outputting column numbers, we want them to start at 1. One
105
+ # reason is that editors, such as Emacs, expect this.
106
+ def real_column
107
+ column + 1
108
+ end
109
+
110
+ # @api public
111
+ #
112
+ # @return [Boolean]
113
+ # returns `true` if two offences contain same attributes
26
114
  def ==(other)
27
- severity == other.severity && line_number == other.line_number &&
28
- message == other.message
115
+ severity == other.severity && line == other.line &&
116
+ column == other.column && message == other.message &&
117
+ cop_name == other.cop_name
29
118
  end
30
119
 
31
- def explode
32
- [severity, line_number, message]
120
+ # @api public
121
+ #
122
+ # Returns `-1`, `0` or `+1`
123
+ # if this offence is less than, equal to, or greater than `other`.
124
+ #
125
+ # @return [Integer]
126
+ # comparison result
127
+ def <=>(other)
128
+ [:line, :column, :cop_name, :message].each do |attribute|
129
+ result = send(attribute) <=> other.send(attribute)
130
+ return result unless result == 0
131
+ end
132
+ 0
33
133
  end
34
134
  end
35
135
  end
@@ -0,0 +1,34 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Rails
6
+ # This cop checks for the use of old-style attribute validation macros.
7
+ class Validation < Cop
8
+ MSG = 'Use the new "sexy" validations (validates ...).'
9
+
10
+ BLACKLIST = [:validates_acceptance_of,
11
+ :validates_confirmation_of,
12
+ :validates_exclusion_of,
13
+ :validates_format_of,
14
+ :validates_inclusion_of,
15
+ :validates_length_of,
16
+ :validates_numericality_of,
17
+ :validates_presence_of,
18
+ :validates_size_of]
19
+
20
+ def self.rails?
21
+ true
22
+ end
23
+
24
+ def on_send(node)
25
+ receiver, method_name, *_args = *node
26
+
27
+ if receiver.nil? && BLACKLIST.include?(method_name)
28
+ add_offence(:convention, node.loc.selector, MSG)
29
+ end
30
+ end
31
+ end
32
+ end
33
+ end
34
+ end
@@ -0,0 +1,58 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # A couple of checks related to the use method visibility modifiers.
7
+ # Modifiers should be indented as deeps are method definitions and
8
+ # surrounded by blank lines.
9
+ class AccessControl < Cop
10
+ INDENT_MSG = 'Indent %s as deep as method definitions.'
11
+ BLANK_MSG = 'Keep a blank line before and after %s.'
12
+
13
+ PRIVATE_NODE = s(:send, nil, :private)
14
+ PROTECTED_NODE = s(:send, nil, :protected)
15
+ PUBLIC_NODE = s(:send, nil, :public)
16
+
17
+ def inspect(source_buffer, source, tokens, ast, comments)
18
+ return unless ast
19
+ on_node([:class, :module, :sclass], ast) do |class_node|
20
+ class_start_col = class_node.loc.expression.column
21
+
22
+ # we'll have to walk all class children nodes
23
+ # except other class/module nodes
24
+ class_node.children.compact.each do |node|
25
+ on_node(:send, node, [:class, :module, :sclass]) do |send_node|
26
+ if modifier_node?(send_node)
27
+ send_start_col = send_node.loc.expression.column
28
+ selector = send_node.loc.selector.source
29
+
30
+ if send_start_col - 2 != class_start_col
31
+ add_offence(:convention,
32
+ send_node.loc.expression,
33
+ format(INDENT_MSG, selector))
34
+ end
35
+
36
+ send_line = send_node.loc.line
37
+
38
+ unless source[send_line].chomp.empty? &&
39
+ source[send_line - 2].chomp.empty?
40
+ add_offence(:convention,
41
+ send_node.loc.expression,
42
+ format(BLANK_MSG, selector))
43
+ end
44
+ end
45
+ end
46
+ end
47
+ end
48
+ end
49
+
50
+ private
51
+
52
+ def modifier_node?(node)
53
+ [PRIVATE_NODE, PROTECTED_NODE, PUBLIC_NODE].include?(node)
54
+ end
55
+ end
56
+ end
57
+ end
58
+ end
@@ -0,0 +1,28 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # The purpose of the this cop is advise the use of
7
+ # alias_method over the alias keyword whenever possible.
8
+ class Alias < Cop
9
+ MSG = 'Use alias_method instead of alias.'
10
+
11
+ # TODO make this check context aware - alias_method is not
12
+ # available outside of classes/modules.
13
+ def on_alias(node)
14
+ # alias_method can't be used with global variables
15
+ new, old = *node
16
+
17
+ return if new.type == :gvar && old.type == :gvar
18
+
19
+ add_offence(:convention,
20
+ node.loc.keyword,
21
+ MSG)
22
+
23
+ super
24
+ end
25
+ end
26
+ end
27
+ end
28
+ end
@@ -0,0 +1,39 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # Here we check if the parameters on a multi-line method call are
7
+ # aligned.
8
+ class AlignParameters < Cop
9
+ MSG = 'Align the parameters of a method call if they span ' +
10
+ 'more than one line.'
11
+
12
+ def on_send(node)
13
+ _receiver, method, *args = *node
14
+
15
+ if method != :[]= && args.size > 1
16
+ first_arg_col = args.first.loc.expression.column
17
+ prev_arg_line = args.first.loc.expression.line
18
+ prev_arg_col = first_arg_col
19
+
20
+ args.each do |arg|
21
+ cur_arg_line = arg.loc.expression.line
22
+ cur_arg_col = arg.loc.expression.column
23
+
24
+ if cur_arg_line != prev_arg_line &&
25
+ cur_arg_col != first_arg_col
26
+ add_offence(:convention, arg.loc.expression, MSG)
27
+ end
28
+
29
+ prev_arg_col = cur_arg_col
30
+ prev_arg_line = cur_arg_line
31
+ end
32
+ end
33
+
34
+ super
35
+ end
36
+ end
37
+ end
38
+ end
39
+ end
@@ -0,0 +1,45 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses of *and* and *or*.
7
+ class AndOr < Cop
8
+ MSG = 'Use %s instead of %s.'
9
+
10
+ OPS = { 'and' => '&&', 'or' => '||' }
11
+
12
+ def on_and(node)
13
+ process_logical_op(node)
14
+
15
+ super
16
+ end
17
+
18
+ def on_or(node)
19
+ process_logical_op(node)
20
+
21
+ super
22
+ end
23
+
24
+ private
25
+
26
+ def process_logical_op(node)
27
+ op = node.loc.operator.source
28
+ op_type = node.type.to_s
29
+
30
+ if op == op_type
31
+ add_offence(:convention,
32
+ node.loc.operator,
33
+ sprintf(MSG, OPS[op], op))
34
+ do_autocorrect(node)
35
+ end
36
+ end
37
+
38
+ def autocorrect_action(node)
39
+ replacement = (node.type == :and ? '&&' : '||')
40
+ replace(node.loc.operator, replacement)
41
+ end
42
+ end
43
+ end
44
+ end
45
+ end
@@ -0,0 +1,21 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for non-ascii (non-English) characters
7
+ # in comments.
8
+ class AsciiComments < Cop
9
+ MSG = 'Use only ascii symbols in comments.'
10
+
11
+ def inspect(source_buffer, source, tokens, ast, comments)
12
+ comments.each do |comment|
13
+ if comment.text =~ /[^\x00-\x7f]/
14
+ add_offence(:convention, comment.loc, MSG)
15
+ end
16
+ end
17
+ end
18
+ end
19
+ end
20
+ end
21
+ end
@@ -0,0 +1,22 @@
1
+ # encoding: utf-8
2
+
3
+ # rubocop:disable SymbolName
4
+
5
+ module Rubocop
6
+ module Cop
7
+ module Style
8
+ # This cop checks for non-ascii characters in indentifier names.
9
+ class AsciiIdentifiers < Cop
10
+ MSG = 'Use only ascii symbols in identifiers.'
11
+
12
+ def inspect(source_buffer, source, tokens, ast, comments)
13
+ tokens.each do |t|
14
+ if t.type == :tIDENTIFIER && t.text =~ /[^\x00-\x7f]/
15
+ add_offence(:convention, t.pos, MSG)
16
+ end
17
+ end
18
+ end
19
+ end
20
+ end
21
+ end
22
+ end
@@ -0,0 +1,20 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses of Module#attr.
7
+ class Attr < Cop
8
+ MSG = 'Do not use `attr`. Use `attr_reader` instead.'
9
+
10
+ def on_send(node)
11
+ if command?(:attr, node)
12
+ add_offence(:convention, node.loc.selector, MSG)
13
+ end
14
+
15
+ super
16
+ end
17
+ end
18
+ end
19
+ end
20
+ end
@@ -0,0 +1,20 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for uses of class variables. Offences
7
+ # are signaled only on assignment to class variables to
8
+ # reduced the number of offences that would be reported.
9
+ class AvoidClassVars < Cop
10
+ MSG = 'Replace class var %s with a class instance var.'
11
+
12
+ def on_cvasgn(node)
13
+ class_var, = *node
14
+ add_offence(:convention, node.loc.name, sprintf(MSG, class_var))
15
+ super
16
+ end
17
+ end
18
+ end
19
+ end
20
+ end
@@ -0,0 +1,18 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop looks for uses of the *for* keyword.
7
+ class AvoidFor < Cop
8
+ MSG = 'Prefer *each* over *for*.'
9
+
10
+ def on_for(node)
11
+ add_offence(:convention, node.loc.keyword, MSG)
12
+
13
+ super
14
+ end
15
+ end
16
+ end
17
+ end
18
+ end
@@ -0,0 +1,65 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cops looks for uses of global variables.
7
+ # It does not report offences for built-in global variables.
8
+ class AvoidGlobalVars < Cop
9
+ MSG = 'Do not introduce global variables.'
10
+
11
+ # predefined global variables their English aliases
12
+ # http://www.zenspider.com/Languages/Ruby/QuickRef.html
13
+ BUILT_IN_VARS = %w(
14
+ $: $LOAD_PATH
15
+ $" $LOADED_FEATURES
16
+ $0 $PROGRAM_NAME
17
+ $! $ERROR_INFO
18
+ $@ $ERROR_POSITION
19
+ $; $FS $FIELD_SEPARATOR
20
+ $, $OFS $OUTPUT_FIELD_SEPARATOR
21
+ $/ $RS $INPUT_RECORD_SEPARATOR
22
+ $\\ $ORS $OUTPUT_RECORD_SEPARATOR
23
+ $. $NR $INPUT_LINE_NUMBER
24
+ $_ $LAST_READ_LINE
25
+ $> $DEFAULT_OUTPUT
26
+ $< $DEFAULT_INPUT
27
+ $$ $PID $PROCESS_ID
28
+ $? $CHILD_STATUS
29
+ $~ $LAST_MATCH_INFO
30
+ $= $IGNORECASE
31
+ $* $ARGV
32
+ $& $MATCH
33
+ $` $PREMATCH
34
+ $' $POSTMATCH
35
+ $+ $LAST_PAREN_MATCH
36
+ $stdin $stdout $stderr
37
+ $DEBUG $FILENAME $VERBOSE
38
+ $-0 $-a $-d $-F $-i $-I $-l $-p $-v $-w
39
+ )
40
+
41
+ def on_gvar(node)
42
+ check(node)
43
+
44
+ super
45
+ end
46
+
47
+ def on_gvasgn(node)
48
+ check(node)
49
+
50
+ super
51
+ end
52
+
53
+ def check(node)
54
+ global_var, = *node
55
+
56
+ unless BUILT_IN_VARS.include?(global_var.to_s)
57
+ add_offence(:convention,
58
+ node.loc.name,
59
+ MSG)
60
+ end
61
+ end
62
+ end
63
+ end
64
+ end
65
+ end
@@ -0,0 +1,21 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop looks for uses of Perl-style regexp match
7
+ # backreferences like $1, $2, etc.
8
+ class AvoidPerlBackrefs < Cop
9
+ def on_nth_ref(node)
10
+ backref, = *node
11
+
12
+ add_offence(:convention,
13
+ node.loc.expression,
14
+ "Prefer the use of MatchData over $#{backref}.")
15
+
16
+ super
17
+ end
18
+ end
19
+ end
20
+ end
21
+ end
@@ -0,0 +1,50 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop looks for uses of Perl-style global variables.
7
+ class AvoidPerlisms < Cop
8
+ PREFERRED_VARS = {
9
+ '$:' => '$LOAD_PATH',
10
+ '$"' => '$LOADED_FEATURES',
11
+ '$0' => '$PROGRAM_NAME',
12
+ '$!' => '$ERROR_INFO from English library',
13
+ '$@' => '$ERROR_POSITION from English library',
14
+ '$;' => '$FS or $FIELD_SEPARATOR from English library',
15
+ '$,' => '$OFS or $OUTPUT_FIELD_SEPARATOR from English library',
16
+ '$/' => '$RS or $INPUT_RECORD_SEPARATOR from English library',
17
+ '$\\' => '$ORS or $OUTPUT_RECORD_SEPARATOR from English library',
18
+ '$.' => '$NR or $INPUT_LINE_NUMBER from English library',
19
+ '$_' => '$LAST_READ_LINE from English library',
20
+ '$>' => '$DEFAULT_OUTPUT from English library',
21
+ '$<' => '$DEFAULT_INPUT from English library',
22
+ '$$' => '$PID or $PROCESS_ID from English library',
23
+ '$?' => '$CHILD_STATUS from English library',
24
+ '$~' => '$LAST_MATCH_INFO from English library',
25
+ '$=' => '$IGNORECASE from English library',
26
+ '$*' => '$ARGV from English library or ARGV constant',
27
+ '$&' => '$MATCH from English library',
28
+ '$`' => '$PREMATCH from English library',
29
+ '$\'' => '$POSTMATCH from English library',
30
+ '$+' => '$LAST_PAREN_MATCH from English library'
31
+ }
32
+
33
+ def on_gvar(node)
34
+ global_var, = *node
35
+ global_var = global_var.to_s
36
+
37
+ if PREFERRED_VARS[global_var]
38
+ add_offence(
39
+ :convention,
40
+ node.loc.expression,
41
+ "Prefer #{PREFERRED_VARS[global_var]} over #{global_var}."
42
+ )
43
+ end
44
+
45
+ super
46
+ end
47
+ end
48
+ end
49
+ end
50
+ end
@@ -0,0 +1,18 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for BEGIN blocks.
7
+ class BeginBlock < Cop
8
+ MSG = 'Avoid the use of BEGIN blocks.'
9
+
10
+ def on_preexe(node)
11
+ add_offence(:convention, node.loc.keyword, MSG)
12
+
13
+ super
14
+ end
15
+ end
16
+ end
17
+ end
18
+ end
@@ -0,0 +1,20 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop looks for uses of block comments (=begin...=end).
7
+ class BlockComments < Cop
8
+ MSG = 'Do not use block comments.'
9
+
10
+ def inspect(source_buffer, source, tokens, ast, comments)
11
+ comments.each do |comment|
12
+ if comment.text.start_with?('=begin')
13
+ add_offence(:convention, comment.loc, MSG)
14
+ end
15
+ end
16
+ end
17
+ end
18
+ end
19
+ end
20
+ end
@@ -0,0 +1,47 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Cop
5
+ module Style
6
+ # This cop checks for excessive nesting of conditional and looping
7
+ # constructs. Despite the cop's name, blocks are not considered as a
8
+ # extra level of nesting.
9
+ #
10
+ # The maximum level of nesting allowed is configurable.
11
+ class BlockNesting < Cop
12
+ NESTING_BLOCKS = [:case, :if, :while, :while_post, :until, :until_post,
13
+ :for, :resbody]
14
+
15
+ def inspect(source_buffer, source, tokens, ast, comments)
16
+ return unless ast
17
+ max = BlockNesting.config['Max']
18
+ check_nesting_level(ast, max, 0)
19
+ end
20
+
21
+ private
22
+
23
+ def check_nesting_level(node, max, current_level)
24
+ if NESTING_BLOCKS.include?(node.type)
25
+ unless node.loc.respond_to?(:keyword) &&
26
+ node.loc.keyword.is?('elsif')
27
+ current_level += 1
28
+ end
29
+ if current_level == max + 1
30
+ add_offence(:convention, node.location.expression, message(max))
31
+ return
32
+ end
33
+ end
34
+ node.children.each do |child|
35
+ if child.is_a?(Parser::AST::Node)
36
+ check_nesting_level(child, max, current_level)
37
+ end
38
+ end
39
+ end
40
+
41
+ def message(max)
42
+ "Avoid more than #{max} levels of block nesting."
43
+ end
44
+ end
45
+ end
46
+ end
47
+ end