rubocop 0.8.0 → 0.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (377) hide show
  1. checksums.yaml +4 -4
  2. data/.travis.yml +0 -4
  3. data/.yardopts +2 -0
  4. data/CHANGELOG.md +95 -1
  5. data/README.md +101 -11
  6. data/config/default.yml +14 -2
  7. data/config/enabled.yml +96 -14
  8. data/lib/rubocop/cli.rb +178 -94
  9. data/lib/rubocop/config.rb +56 -11
  10. data/lib/rubocop/config_store.rb +2 -0
  11. data/lib/rubocop/cop/cop.rb +54 -11
  12. data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
  13. data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
  14. data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
  15. data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
  16. data/lib/rubocop/cop/lint/eval.rb +22 -0
  17. data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
  18. data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
  19. data/lib/rubocop/cop/lint/loop.rb +29 -0
  20. data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
  21. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
  22. data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
  23. data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
  24. data/lib/rubocop/cop/lint/void.rb +58 -0
  25. data/lib/rubocop/cop/offence.rb +112 -12
  26. data/lib/rubocop/cop/rails/validation.rb +34 -0
  27. data/lib/rubocop/cop/style/access_control.rb +58 -0
  28. data/lib/rubocop/cop/style/alias.rb +28 -0
  29. data/lib/rubocop/cop/style/align_parameters.rb +39 -0
  30. data/lib/rubocop/cop/style/and_or.rb +45 -0
  31. data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
  32. data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
  33. data/lib/rubocop/cop/style/attr.rb +20 -0
  34. data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
  35. data/lib/rubocop/cop/style/avoid_for.rb +18 -0
  36. data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
  37. data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
  38. data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
  39. data/lib/rubocop/cop/style/begin_block.rb +18 -0
  40. data/lib/rubocop/cop/style/block_comments.rb +20 -0
  41. data/lib/rubocop/cop/style/block_nesting.rb +47 -0
  42. data/lib/rubocop/cop/style/blocks.rb +27 -0
  43. data/lib/rubocop/cop/style/case_equality.rb +22 -0
  44. data/lib/rubocop/cop/style/case_indentation.rb +28 -0
  45. data/lib/rubocop/cop/style/character_literal.rb +37 -0
  46. data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
  47. data/lib/rubocop/cop/style/class_methods.rb +22 -0
  48. data/lib/rubocop/cop/style/collection_methods.rb +37 -0
  49. data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
  50. data/lib/rubocop/cop/style/constant_name.rb +31 -0
  51. data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
  52. data/lib/rubocop/cop/style/documentation.rb +58 -0
  53. data/lib/rubocop/cop/style/dot_position.rb +25 -0
  54. data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
  55. data/lib/rubocop/cop/style/empty_lines.rb +40 -0
  56. data/lib/rubocop/cop/style/empty_literal.rb +53 -0
  57. data/lib/rubocop/cop/style/encoding.rb +29 -0
  58. data/lib/rubocop/cop/style/end_block.rb +18 -0
  59. data/lib/rubocop/cop/style/end_of_line.rb +23 -0
  60. data/lib/rubocop/cop/style/favor_join.rb +29 -0
  61. data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
  62. data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
  63. data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
  64. data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
  65. data/lib/rubocop/cop/style/if_then_else.rb +80 -0
  66. data/lib/rubocop/cop/style/lambda.rb +47 -0
  67. data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
  68. data/lib/rubocop/cop/style/line_continuation.rb +26 -0
  69. data/lib/rubocop/cop/style/line_length.rb +30 -0
  70. data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
  71. data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
  72. data/lib/rubocop/cop/style/method_length.rb +57 -0
  73. data/lib/rubocop/cop/style/not.rb +24 -0
  74. data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
  75. data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
  76. data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
  77. data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
  78. data/lib/rubocop/cop/style/proc.rb +30 -0
  79. data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
  80. data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
  81. data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
  82. data/lib/rubocop/cop/style/semicolon.rb +51 -0
  83. data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
  84. data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
  85. data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
  86. data/lib/rubocop/cop/style/string_literals.rb +36 -0
  87. data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
  88. data/lib/rubocop/cop/style/symbol_array.rb +31 -0
  89. data/lib/rubocop/cop/style/symbol_name.rb +27 -0
  90. data/lib/rubocop/cop/style/tab.rb +25 -0
  91. data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
  92. data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
  93. data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
  94. data/lib/rubocop/cop/style/unless_else.rb +26 -0
  95. data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
  96. data/lib/rubocop/cop/style/when_then.rb +25 -0
  97. data/lib/rubocop/cop/style/while_until_do.rb +45 -0
  98. data/lib/rubocop/cop/style/word_array.rb +44 -0
  99. data/lib/rubocop/cop/util.rb +1 -0
  100. data/lib/rubocop/cop/variable_inspector.rb +280 -0
  101. data/lib/rubocop/formatter/base_formatter.rb +119 -0
  102. data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
  103. data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
  104. data/lib/rubocop/formatter/formatter_set.rb +77 -0
  105. data/lib/rubocop/formatter/json_formatter.rb +76 -0
  106. data/lib/rubocop/formatter/progress_formatter.rb +63 -0
  107. data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
  108. data/lib/rubocop/version.rb +15 -1
  109. data/lib/rubocop.rb +97 -71
  110. data/rubocop.gemspec +1 -2
  111. data/spec/.rubocop.yml +5 -0
  112. data/spec/project_spec.rb +4 -7
  113. data/spec/rubocop/cli_spec.rb +402 -143
  114. data/spec/rubocop/config_spec.rb +61 -0
  115. data/spec/rubocop/config_store_spec.rb +2 -2
  116. data/spec/rubocop/cops/cop_spec.rb +14 -7
  117. data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
  118. data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
  119. data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
  120. data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
  121. data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
  122. data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
  123. data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
  124. data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
  125. data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
  126. data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
  127. data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
  128. data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
  129. data/spec/rubocop/cops/lint/void_spec.rb +63 -0
  130. data/spec/rubocop/cops/offence_spec.rb +107 -10
  131. data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
  132. data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
  133. data/spec/rubocop/cops/style/alias_spec.rb +47 -0
  134. data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
  135. data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
  136. data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
  137. data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
  138. data/spec/rubocop/cops/style/attr_spec.rb +20 -0
  139. data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
  140. data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
  141. data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
  142. data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
  143. data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
  144. data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
  145. data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
  146. data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
  147. data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
  148. data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
  149. data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
  150. data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
  151. data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
  152. data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
  153. data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
  154. data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
  155. data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
  156. data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
  157. data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
  158. data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
  159. data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
  160. data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
  161. data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
  162. data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
  163. data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
  164. data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
  165. data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
  166. data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
  167. data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
  168. data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
  169. data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
  170. data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
  171. data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
  172. data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
  173. data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
  174. data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
  175. data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
  176. data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
  177. data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
  178. data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
  179. data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
  180. data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
  181. data/spec/rubocop/cops/style/not_spec.rb +28 -0
  182. data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
  183. data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
  184. data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
  185. data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
  186. data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
  187. data/spec/rubocop/cops/style/proc_spec.rb +28 -0
  188. data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
  189. data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
  190. data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
  191. data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
  192. data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
  193. data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
  194. data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
  195. data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
  196. data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
  197. data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
  198. data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
  199. data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
  200. data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
  201. data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
  202. data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
  203. data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
  204. data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
  205. data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
  206. data/spec/rubocop/cops/style/tab_spec.rb +23 -0
  207. data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
  208. data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
  209. data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
  210. data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
  211. data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
  212. data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
  213. data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
  214. data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
  215. data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
  216. data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
  217. data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
  218. data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
  219. data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
  220. data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
  221. data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
  222. data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
  223. data/spec/spec_helper.rb +24 -9
  224. data/spec/support/mri_syntax_checker.rb +69 -0
  225. data/spec/support/shared_examples.rb +33 -0
  226. metadata +317 -239
  227. data/lib/rubocop/cop/access_control.rb +0 -41
  228. data/lib/rubocop/cop/alias.rb +0 -17
  229. data/lib/rubocop/cop/align_parameters.rb +0 -37
  230. data/lib/rubocop/cop/and_or.rb +0 -26
  231. data/lib/rubocop/cop/ascii_comments.rb +0 -13
  232. data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
  233. data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
  234. data/lib/rubocop/cop/avoid_for.rb +0 -17
  235. data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
  236. data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
  237. data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
  238. data/lib/rubocop/cop/block_comments.rb +0 -15
  239. data/lib/rubocop/cop/blocks.rb +0 -23
  240. data/lib/rubocop/cop/case_indentation.rb +0 -22
  241. data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
  242. data/lib/rubocop/cop/class_methods.rb +0 -15
  243. data/lib/rubocop/cop/collection_methods.rb +0 -29
  244. data/lib/rubocop/cop/colon_method_call.rb +0 -20
  245. data/lib/rubocop/cop/constant_name.rb +0 -24
  246. data/lib/rubocop/cop/def_parentheses.rb +0 -62
  247. data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
  248. data/lib/rubocop/cop/empty_lines.rb +0 -34
  249. data/lib/rubocop/cop/empty_literal.rb +0 -47
  250. data/lib/rubocop/cop/encoding.rb +0 -19
  251. data/lib/rubocop/cop/end_of_line.rb +0 -15
  252. data/lib/rubocop/cop/ensure_return.rb +0 -19
  253. data/lib/rubocop/cop/eval.rb +0 -19
  254. data/lib/rubocop/cop/favor_join.rb +0 -22
  255. data/lib/rubocop/cop/favor_modifier.rb +0 -72
  256. data/lib/rubocop/cop/favor_percent_r.rb +0 -19
  257. data/lib/rubocop/cop/favor_sprintf.rb +0 -21
  258. data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
  259. data/lib/rubocop/cop/handle_exceptions.rb +0 -17
  260. data/lib/rubocop/cop/hash_syntax.rb +0 -41
  261. data/lib/rubocop/cop/if_then_else.rb +0 -65
  262. data/lib/rubocop/cop/leading_comment_space.rb +0 -17
  263. data/lib/rubocop/cop/line_continuation.rb +0 -15
  264. data/lib/rubocop/cop/line_length.rb +0 -23
  265. data/lib/rubocop/cop/loop.rb +0 -33
  266. data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
  267. data/lib/rubocop/cop/method_length.rb +0 -52
  268. data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
  269. data/lib/rubocop/cop/not.rb +0 -21
  270. data/lib/rubocop/cop/numeric_literals.rb +0 -21
  271. data/lib/rubocop/cop/parameter_lists.rb +0 -23
  272. data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
  273. data/lib/rubocop/cop/percent_r.rb +0 -19
  274. data/lib/rubocop/cop/reduce_arguments.rb +0 -29
  275. data/lib/rubocop/cop/rescue_exception.rb +0 -26
  276. data/lib/rubocop/cop/rescue_modifier.rb +0 -17
  277. data/lib/rubocop/cop/semicolon.rb +0 -31
  278. data/lib/rubocop/cop/single_line_methods.rb +0 -44
  279. data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
  280. data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
  281. data/lib/rubocop/cop/string_literals.rb +0 -22
  282. data/lib/rubocop/cop/surrounding_space.rb +0 -283
  283. data/lib/rubocop/cop/symbol_array.rb +0 -31
  284. data/lib/rubocop/cop/symbol_name.rb +0 -23
  285. data/lib/rubocop/cop/syntax.rb +0 -49
  286. data/lib/rubocop/cop/tab.rb +0 -15
  287. data/lib/rubocop/cop/ternary_operator.rb +0 -43
  288. data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
  289. data/lib/rubocop/cop/trivial_accessors.rb +0 -26
  290. data/lib/rubocop/cop/unless_else.rb +0 -23
  291. data/lib/rubocop/cop/variable_interpolation.rb +0 -29
  292. data/lib/rubocop/cop/when_then.rb +0 -17
  293. data/lib/rubocop/cop/word_array.rb +0 -37
  294. data/lib/rubocop/report/emacs_style.rb +0 -17
  295. data/lib/rubocop/report/plain_text.rb +0 -18
  296. data/lib/rubocop/report/report.rb +0 -44
  297. data/spec/rubocop/cops/access_control_spec.rb +0 -129
  298. data/spec/rubocop/cops/alias_spec.rb +0 -39
  299. data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
  300. data/spec/rubocop/cops/and_or_spec.rb +0 -37
  301. data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
  302. data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
  303. data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
  304. data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
  305. data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
  306. data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
  307. data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
  308. data/spec/rubocop/cops/block_comments_spec.rb +0 -25
  309. data/spec/rubocop/cops/blocks_spec.rb +0 -33
  310. data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
  311. data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
  312. data/spec/rubocop/cops/class_methods_spec.rb +0 -49
  313. data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
  314. data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
  315. data/spec/rubocop/cops/constant_name_spec.rb +0 -42
  316. data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
  317. data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
  318. data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
  319. data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
  320. data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
  321. data/spec/rubocop/cops/encoding_spec.rb +0 -47
  322. data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
  323. data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
  324. data/spec/rubocop/cops/eval_spec.rb +0 -39
  325. data/spec/rubocop/cops/favor_join_spec.rb +0 -35
  326. data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
  327. data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
  328. data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
  329. data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
  330. data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
  331. data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
  332. data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
  333. data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
  334. data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
  335. data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
  336. data/spec/rubocop/cops/line_length_spec.rb +0 -23
  337. data/spec/rubocop/cops/loop_spec.rb +0 -31
  338. data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
  339. data/spec/rubocop/cops/method_length_spec.rb +0 -147
  340. data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
  341. data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
  342. data/spec/rubocop/cops/not_spec.rb +0 -31
  343. data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
  344. data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
  345. data/spec/rubocop/cops/op_method_spec.rb +0 -78
  346. data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
  347. data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
  348. data/spec/rubocop/cops/percent_r_spec.rb +0 -29
  349. data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
  350. data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
  351. data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
  352. data/spec/rubocop/cops/semicolon_spec.rb +0 -88
  353. data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
  354. data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
  355. data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
  356. data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
  357. data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
  358. data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
  359. data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
  360. data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
  361. data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
  362. data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
  363. data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
  364. data/spec/rubocop/cops/string_literals_spec.rb +0 -47
  365. data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
  366. data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
  367. data/spec/rubocop/cops/syntax_spec.rb +0 -41
  368. data/spec/rubocop/cops/tab_spec.rb +0 -21
  369. data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
  370. data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
  371. data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
  372. data/spec/rubocop/cops/unless_else_spec.rb +0 -29
  373. data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
  374. data/spec/rubocop/cops/when_then_spec.rb +0 -38
  375. data/spec/rubocop/cops/word_array_spec.rb +0 -47
  376. data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
  377. data/spec/rubocop/reports/report_spec.rb +0 -29
@@ -0,0 +1,62 @@
1
+ # encoding: utf-8
2
+
3
+ module Rubocop
4
+ module Formatter
5
+ # A basic formatter that displays only files with offences.
6
+ # Offences are displayed at compact form - just the
7
+ # location of the problem and the associated message.
8
+ class SimpleTextFormatter < BaseFormatter
9
+ attr_accessor :reports_summary
10
+ alias_method :reports_summary?, :reports_summary
11
+
12
+ def started(target_files)
13
+ @total_offence_count = 0
14
+ end
15
+
16
+ def file_finished(file, offences)
17
+ return if offences.empty?
18
+ @total_offence_count += offences.count
19
+ report_file(file, offences)
20
+ end
21
+
22
+ def finished(inspected_files)
23
+ if reports_summary?
24
+ report_summary(inspected_files.count, @total_offence_count)
25
+ end
26
+ end
27
+
28
+ def report_file(file, offences)
29
+ output.puts "== #{smart_path(file)} ==".color(:yellow)
30
+ output.puts offences.join("\n")
31
+ end
32
+
33
+ def report_summary(file_count, offence_count)
34
+ summary = ''
35
+
36
+ plural = file_count == 0 || file_count > 1 ? 's' : ''
37
+ summary << "#{file_count} file#{plural} inspected, "
38
+
39
+ offences_string = case offence_count
40
+ when 0 then 'no offences'
41
+ when 1 then '1 offence'
42
+ else "#{offence_count} offences"
43
+ end
44
+ summary << "#{offences_string} detected"
45
+ .color(offence_count.zero? ? :green : :red)
46
+
47
+ output.puts
48
+ output.puts summary
49
+ end
50
+
51
+ protected
52
+
53
+ def smart_path(path)
54
+ if path.start_with?(Dir.pwd)
55
+ Pathname.new(path).relative_path_from(Pathname.getwd).to_s
56
+ else
57
+ path
58
+ end
59
+ end
60
+ end
61
+ end
62
+ end
@@ -1,7 +1,21 @@
1
1
  # encoding: utf-8
2
2
 
3
3
  module Rubocop
4
+ # This module holds the RuboCop version information.
4
5
  module Version
5
- STRING = '0.8.0'
6
+ STRING = '0.9.0'
7
+
8
+ MSG = '%s (using Parser %s, running on %s %s %s)'
9
+
10
+ module_function
11
+
12
+ def version(debug = false)
13
+ if debug
14
+ sprintf(MSG, STRING, Parser::VERSION,
15
+ RUBY_ENGINE, RUBY_VERSION, RUBY_PLATFORM)
16
+ else
17
+ STRING
18
+ end
19
+ end
6
20
  end
7
21
  end
data/lib/rubocop.rb CHANGED
@@ -6,80 +6,106 @@ require 'parser/current'
6
6
  require 'ast/sexp'
7
7
 
8
8
  require 'rubocop/cop/util'
9
+ require 'rubocop/cop/variable_inspector'
9
10
  require 'rubocop/cop/offence'
10
11
  require 'rubocop/cop/cop'
11
- require 'rubocop/cop/encoding'
12
- require 'rubocop/cop/line_length'
13
- require 'rubocop/cop/line_continuation'
14
- require 'rubocop/cop/syntax'
15
- require 'rubocop/cop/tab'
16
- require 'rubocop/cop/trailing_whitespace'
17
- require 'rubocop/cop/case_indentation'
18
- require 'rubocop/cop/empty_line_between_defs'
19
- require 'rubocop/cop/empty_lines'
20
- require 'rubocop/cop/surrounding_space'
21
- require 'rubocop/cop/space_after_comma_etc'
22
- require 'rubocop/cop/space_after_control_keyword'
23
- require 'rubocop/cop/hash_syntax'
24
- require 'rubocop/cop/end_of_line'
25
- require 'rubocop/cop/numeric_literals'
26
- require 'rubocop/cop/align_parameters'
27
- require 'rubocop/cop/def_parentheses'
28
- require 'rubocop/cop/if_then_else'
29
- require 'rubocop/cop/blocks'
30
- require 'rubocop/cop/parameter_lists'
31
- require 'rubocop/cop/string_literals'
32
- require 'rubocop/cop/ternary_operator'
33
- require 'rubocop/cop/unless_else'
34
- require 'rubocop/cop/and_or'
35
- require 'rubocop/cop/when_then'
36
- require 'rubocop/cop/favor_modifier'
37
- require 'rubocop/cop/favor_unless_over_negated_if'
38
- require 'rubocop/cop/new_lambda_literal'
39
- require 'rubocop/cop/parentheses_around_condition'
40
- require 'rubocop/cop/method_and_variable_snake_case'
41
- require 'rubocop/cop/class_and_module_camel_case'
42
- require 'rubocop/cop/collection_methods'
43
- require 'rubocop/cop/avoid_for'
44
- require 'rubocop/cop/avoid_perlisms'
45
- require 'rubocop/cop/avoid_perl_backrefs'
46
- require 'rubocop/cop/avoid_global_vars'
47
- require 'rubocop/cop/avoid_class_vars'
48
- require 'rubocop/cop/symbol_name'
49
- require 'rubocop/cop/constant_name'
50
- require 'rubocop/cop/variable_interpolation'
51
- require 'rubocop/cop/semicolon'
52
- require 'rubocop/cop/favor_sprintf'
53
- require 'rubocop/cop/favor_join'
54
- require 'rubocop/cop/alias'
55
- require 'rubocop/cop/rescue_modifier'
56
- require 'rubocop/cop/ensure_return'
57
- require 'rubocop/cop/handle_exceptions'
58
- require 'rubocop/cop/rescue_exception'
59
- require 'rubocop/cop/ascii_identifiers'
60
- require 'rubocop/cop/ascii_comments'
61
- require 'rubocop/cop/block_comments'
62
- require 'rubocop/cop/empty_literal'
63
- require 'rubocop/cop/method_length'
64
- require 'rubocop/cop/op_method'
65
- require 'rubocop/cop/reduce_arguments'
66
- require 'rubocop/cop/percent_r'
67
- require 'rubocop/cop/favor_percent_r'
68
- require 'rubocop/cop/class_methods'
69
- require 'rubocop/cop/single_line_methods'
70
- require 'rubocop/cop/word_array'
71
- require 'rubocop/cop/symbol_array'
72
- require 'rubocop/cop/trivial_accessors'
73
- require 'rubocop/cop/leading_comment_space'
74
- require 'rubocop/cop/colon_method_call'
75
- require 'rubocop/cop/not'
76
- require 'rubocop/cop/eval'
77
- require 'rubocop/cop/access_control'
78
- require 'rubocop/cop/loop'
79
12
 
80
- require 'rubocop/report/report'
81
- require 'rubocop/report/plain_text'
82
- require 'rubocop/report/emacs_style'
13
+ require 'rubocop/cop/lint/assignment_in_condition'
14
+ require 'rubocop/cop/lint/end_alignment'
15
+ require 'rubocop/cop/lint/end_in_method'
16
+ require 'rubocop/cop/lint/ensure_return'
17
+ require 'rubocop/cop/lint/eval'
18
+ require 'rubocop/cop/lint/handle_exceptions'
19
+ require 'rubocop/cop/lint/literal_in_condition'
20
+ require 'rubocop/cop/lint/loop'
21
+ require 'rubocop/cop/lint/rescue_exception'
22
+ require 'rubocop/cop/lint/shadowing_outer_local_variable'
23
+ require 'rubocop/cop/lint/unreachable_code'
24
+ require 'rubocop/cop/lint/unused_local_variable'
25
+ require 'rubocop/cop/lint/void'
26
+
27
+ require 'rubocop/cop/style/access_control'
28
+ require 'rubocop/cop/style/alias'
29
+ require 'rubocop/cop/style/align_parameters'
30
+ require 'rubocop/cop/style/and_or'
31
+ require 'rubocop/cop/style/ascii_comments'
32
+ require 'rubocop/cop/style/ascii_identifiers'
33
+ require 'rubocop/cop/style/attr'
34
+ require 'rubocop/cop/style/avoid_class_vars'
35
+ require 'rubocop/cop/style/avoid_for'
36
+ require 'rubocop/cop/style/avoid_global_vars'
37
+ require 'rubocop/cop/style/avoid_perl_backrefs'
38
+ require 'rubocop/cop/style/avoid_perlisms'
39
+ require 'rubocop/cop/style/begin_block'
40
+ require 'rubocop/cop/style/block_comments'
41
+ require 'rubocop/cop/style/block_nesting'
42
+ require 'rubocop/cop/style/blocks'
43
+ require 'rubocop/cop/style/character_literal'
44
+ require 'rubocop/cop/style/case_equality'
45
+ require 'rubocop/cop/style/case_indentation'
46
+ require 'rubocop/cop/style/class_and_module_camel_case'
47
+ require 'rubocop/cop/style/class_methods'
48
+ require 'rubocop/cop/style/collection_methods'
49
+ require 'rubocop/cop/style/colon_method_call'
50
+ require 'rubocop/cop/style/constant_name'
51
+ require 'rubocop/cop/style/def_parentheses'
52
+ require 'rubocop/cop/style/documentation'
53
+ require 'rubocop/cop/style/dot_position'
54
+ require 'rubocop/cop/style/empty_line_between_defs'
55
+ require 'rubocop/cop/style/empty_lines'
56
+ require 'rubocop/cop/style/empty_literal'
57
+ require 'rubocop/cop/style/encoding'
58
+ require 'rubocop/cop/style/end_block'
59
+ require 'rubocop/cop/style/end_of_line'
60
+ require 'rubocop/cop/style/favor_join'
61
+ require 'rubocop/cop/style/favor_modifier'
62
+ require 'rubocop/cop/style/favor_sprintf'
63
+ require 'rubocop/cop/style/favor_unless_over_negated_if'
64
+ require 'rubocop/cop/style/hash_syntax'
65
+ require 'rubocop/cop/style/if_then_else'
66
+ require 'rubocop/cop/style/lambda'
67
+ require 'rubocop/cop/style/leading_comment_space'
68
+ require 'rubocop/cop/style/line_continuation'
69
+ require 'rubocop/cop/style/line_length'
70
+ require 'rubocop/cop/style/method_and_variable_snake_case'
71
+ require 'rubocop/cop/style/method_call_parentheses'
72
+ require 'rubocop/cop/style/method_length'
73
+ require 'rubocop/cop/style/not'
74
+ require 'rubocop/cop/style/numeric_literals'
75
+ require 'rubocop/cop/style/op_method'
76
+ require 'rubocop/cop/style/parameter_lists'
77
+ require 'rubocop/cop/style/parentheses_around_condition'
78
+ require 'rubocop/cop/style/proc'
79
+ require 'rubocop/cop/style/reduce_arguments'
80
+ require 'rubocop/cop/style/regexp_literal'
81
+ require 'rubocop/cop/style/rescue_modifier'
82
+ require 'rubocop/cop/style/semicolon'
83
+ require 'rubocop/cop/style/single_line_methods'
84
+ require 'rubocop/cop/style/space_after_comma_etc'
85
+ require 'rubocop/cop/style/space_after_control_keyword'
86
+ require 'rubocop/cop/style/string_literals'
87
+ require 'rubocop/cop/style/surrounding_space'
88
+ require 'rubocop/cop/style/symbol_array'
89
+ require 'rubocop/cop/style/symbol_name'
90
+ require 'rubocop/cop/style/tab'
91
+ require 'rubocop/cop/style/ternary_operator'
92
+ require 'rubocop/cop/style/trailing_whitespace'
93
+ require 'rubocop/cop/style/trivial_accessors'
94
+ require 'rubocop/cop/style/unless_else'
95
+ require 'rubocop/cop/style/variable_interpolation'
96
+ require 'rubocop/cop/style/when_then'
97
+ require 'rubocop/cop/style/while_until_do'
98
+ require 'rubocop/cop/style/word_array'
99
+
100
+ require 'rubocop/cop/rails/validation'
101
+
102
+ require 'rubocop/formatter/base_formatter'
103
+ require 'rubocop/formatter/simple_text_formatter'
104
+ require 'rubocop/formatter/emacs_style_formatter'
105
+ require 'rubocop/formatter/clang_style_formatter'
106
+ require 'rubocop/formatter/progress_formatter'
107
+ require 'rubocop/formatter/json_formatter'
108
+ require 'rubocop/formatter/formatter_set'
83
109
 
84
110
  require 'rubocop/config'
85
111
  require 'rubocop/config_store'
data/rubocop.gemspec CHANGED
@@ -10,7 +10,6 @@ Gem::Specification.new do |s|
10
10
  s.platform = Gem::Platform::RUBY
11
11
  s.required_ruby_version = '>= 1.9.2'
12
12
  s.authors = ['Bozhidar Batsov']
13
- s.date = '2013-04-17'
14
13
  s.description = <<-EOF
15
14
  Automatic Ruby code style checking tool.
16
15
  Aims to enforce the community-driven Ruby Style Guide.
@@ -28,7 +27,7 @@ Gem::Specification.new do |s|
28
27
  s.summary = 'Automatic Ruby code style checking tool.'
29
28
 
30
29
  s.add_runtime_dependency('rainbow', '>= 1.1.4')
31
- s.add_runtime_dependency('parser', '~> 2.0.0.beta2')
30
+ s.add_runtime_dependency('parser', '2.0.0.beta9')
32
31
  s.add_development_dependency('rake', '~> 10.0')
33
32
  s.add_development_dependency('rspec', '~> 2.13')
34
33
  s.add_development_dependency('yard', '~> 0.8')
data/spec/.rubocop.yml ADDED
@@ -0,0 +1,5 @@
1
+ inherit_from: ../.rubocop.yml
2
+
3
+ # The documentation check doesn't make sense for test code
4
+ Documentation:
5
+ Enabled: false
data/spec/project_spec.rb CHANGED
@@ -3,25 +3,22 @@
3
3
  require 'spec_helper'
4
4
 
5
5
  describe 'RuboCop Project' do
6
- describe '.rubocop.yml' do
6
+ describe 'default configuration file' do
7
7
  it 'has configuration for all cops' do
8
8
  cop_names = Rubocop::Cop::Cop.all.map(&:cop_name)
9
- expect(Rubocop::Config.load_file('.rubocop.yml').keys.sort)
9
+ expect(Rubocop::Config.load_file('config/default.yml').keys.sort)
10
10
  .to eq((['AllCops'] + cop_names).sort)
11
11
  end
12
12
  end
13
13
 
14
- describe 'source codes', broken: true do
14
+ describe 'source codes' do
15
15
  before { $stdout = StringIO.new }
16
16
  after { $stdout = STDOUT }
17
17
 
18
18
  it 'has no violations' do
19
19
  # Need to pass an empty array explicitly
20
20
  # so that the CLI does not refer arguments of `rspec`
21
- Rubocop::CLI.new.run([])
22
- expect($stdout.string).to match(
23
- /files inspected, no offences detected\n/
24
- )
21
+ expect(Rubocop::CLI.new.run([])).to eq(0)
25
22
  end
26
23
  end
27
24
  end