rubocop 0.8.0 → 0.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.travis.yml +0 -4
- data/.yardopts +2 -0
- data/CHANGELOG.md +95 -1
- data/README.md +101 -11
- data/config/default.yml +14 -2
- data/config/enabled.yml +96 -14
- data/lib/rubocop/cli.rb +178 -94
- data/lib/rubocop/config.rb +56 -11
- data/lib/rubocop/config_store.rb +2 -0
- data/lib/rubocop/cop/cop.rb +54 -11
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
- data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
- data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
- data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
- data/lib/rubocop/cop/lint/eval.rb +22 -0
- data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
- data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
- data/lib/rubocop/cop/lint/loop.rb +29 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
- data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
- data/lib/rubocop/cop/lint/void.rb +58 -0
- data/lib/rubocop/cop/offence.rb +112 -12
- data/lib/rubocop/cop/rails/validation.rb +34 -0
- data/lib/rubocop/cop/style/access_control.rb +58 -0
- data/lib/rubocop/cop/style/alias.rb +28 -0
- data/lib/rubocop/cop/style/align_parameters.rb +39 -0
- data/lib/rubocop/cop/style/and_or.rb +45 -0
- data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
- data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
- data/lib/rubocop/cop/style/attr.rb +20 -0
- data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
- data/lib/rubocop/cop/style/avoid_for.rb +18 -0
- data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
- data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
- data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
- data/lib/rubocop/cop/style/begin_block.rb +18 -0
- data/lib/rubocop/cop/style/block_comments.rb +20 -0
- data/lib/rubocop/cop/style/block_nesting.rb +47 -0
- data/lib/rubocop/cop/style/blocks.rb +27 -0
- data/lib/rubocop/cop/style/case_equality.rb +22 -0
- data/lib/rubocop/cop/style/case_indentation.rb +28 -0
- data/lib/rubocop/cop/style/character_literal.rb +37 -0
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
- data/lib/rubocop/cop/style/class_methods.rb +22 -0
- data/lib/rubocop/cop/style/collection_methods.rb +37 -0
- data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
- data/lib/rubocop/cop/style/constant_name.rb +31 -0
- data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
- data/lib/rubocop/cop/style/documentation.rb +58 -0
- data/lib/rubocop/cop/style/dot_position.rb +25 -0
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
- data/lib/rubocop/cop/style/empty_lines.rb +40 -0
- data/lib/rubocop/cop/style/empty_literal.rb +53 -0
- data/lib/rubocop/cop/style/encoding.rb +29 -0
- data/lib/rubocop/cop/style/end_block.rb +18 -0
- data/lib/rubocop/cop/style/end_of_line.rb +23 -0
- data/lib/rubocop/cop/style/favor_join.rb +29 -0
- data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
- data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
- data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
- data/lib/rubocop/cop/style/if_then_else.rb +80 -0
- data/lib/rubocop/cop/style/lambda.rb +47 -0
- data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
- data/lib/rubocop/cop/style/line_continuation.rb +26 -0
- data/lib/rubocop/cop/style/line_length.rb +30 -0
- data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
- data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
- data/lib/rubocop/cop/style/method_length.rb +57 -0
- data/lib/rubocop/cop/style/not.rb +24 -0
- data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
- data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
- data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
- data/lib/rubocop/cop/style/proc.rb +30 -0
- data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
- data/lib/rubocop/cop/style/semicolon.rb +51 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
- data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
- data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
- data/lib/rubocop/cop/style/string_literals.rb +36 -0
- data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
- data/lib/rubocop/cop/style/symbol_array.rb +31 -0
- data/lib/rubocop/cop/style/symbol_name.rb +27 -0
- data/lib/rubocop/cop/style/tab.rb +25 -0
- data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
- data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
- data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
- data/lib/rubocop/cop/style/unless_else.rb +26 -0
- data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
- data/lib/rubocop/cop/style/when_then.rb +25 -0
- data/lib/rubocop/cop/style/while_until_do.rb +45 -0
- data/lib/rubocop/cop/style/word_array.rb +44 -0
- data/lib/rubocop/cop/util.rb +1 -0
- data/lib/rubocop/cop/variable_inspector.rb +280 -0
- data/lib/rubocop/formatter/base_formatter.rb +119 -0
- data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
- data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
- data/lib/rubocop/formatter/formatter_set.rb +77 -0
- data/lib/rubocop/formatter/json_formatter.rb +76 -0
- data/lib/rubocop/formatter/progress_formatter.rb +63 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
- data/lib/rubocop/version.rb +15 -1
- data/lib/rubocop.rb +97 -71
- data/rubocop.gemspec +1 -2
- data/spec/.rubocop.yml +5 -0
- data/spec/project_spec.rb +4 -7
- data/spec/rubocop/cli_spec.rb +402 -143
- data/spec/rubocop/config_spec.rb +61 -0
- data/spec/rubocop/config_store_spec.rb +2 -2
- data/spec/rubocop/cops/cop_spec.rb +14 -7
- data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
- data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
- data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
- data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
- data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
- data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
- data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
- data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
- data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
- data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
- data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
- data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
- data/spec/rubocop/cops/lint/void_spec.rb +63 -0
- data/spec/rubocop/cops/offence_spec.rb +107 -10
- data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
- data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
- data/spec/rubocop/cops/style/alias_spec.rb +47 -0
- data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
- data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
- data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
- data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
- data/spec/rubocop/cops/style/attr_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
- data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
- data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
- data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
- data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
- data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
- data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
- data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
- data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
- data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
- data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
- data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
- data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
- data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
- data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
- data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
- data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
- data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
- data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
- data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
- data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
- data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
- data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
- data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
- data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
- data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
- data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
- data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
- data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
- data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
- data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
- data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
- data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
- data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
- data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
- data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
- data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
- data/spec/rubocop/cops/style/not_spec.rb +28 -0
- data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
- data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
- data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
- data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
- data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
- data/spec/rubocop/cops/style/proc_spec.rb +28 -0
- data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
- data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
- data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
- data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
- data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
- data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
- data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
- data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
- data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
- data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
- data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
- data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
- data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
- data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
- data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
- data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
- data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
- data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
- data/spec/rubocop/cops/style/tab_spec.rb +23 -0
- data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
- data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
- data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
- data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
- data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
- data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
- data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
- data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
- data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
- data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
- data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
- data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
- data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
- data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
- data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
- data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
- data/spec/spec_helper.rb +24 -9
- data/spec/support/mri_syntax_checker.rb +69 -0
- data/spec/support/shared_examples.rb +33 -0
- metadata +317 -239
- data/lib/rubocop/cop/access_control.rb +0 -41
- data/lib/rubocop/cop/alias.rb +0 -17
- data/lib/rubocop/cop/align_parameters.rb +0 -37
- data/lib/rubocop/cop/and_or.rb +0 -26
- data/lib/rubocop/cop/ascii_comments.rb +0 -13
- data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
- data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
- data/lib/rubocop/cop/avoid_for.rb +0 -17
- data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
- data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
- data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
- data/lib/rubocop/cop/block_comments.rb +0 -15
- data/lib/rubocop/cop/blocks.rb +0 -23
- data/lib/rubocop/cop/case_indentation.rb +0 -22
- data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
- data/lib/rubocop/cop/class_methods.rb +0 -15
- data/lib/rubocop/cop/collection_methods.rb +0 -29
- data/lib/rubocop/cop/colon_method_call.rb +0 -20
- data/lib/rubocop/cop/constant_name.rb +0 -24
- data/lib/rubocop/cop/def_parentheses.rb +0 -62
- data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
- data/lib/rubocop/cop/empty_lines.rb +0 -34
- data/lib/rubocop/cop/empty_literal.rb +0 -47
- data/lib/rubocop/cop/encoding.rb +0 -19
- data/lib/rubocop/cop/end_of_line.rb +0 -15
- data/lib/rubocop/cop/ensure_return.rb +0 -19
- data/lib/rubocop/cop/eval.rb +0 -19
- data/lib/rubocop/cop/favor_join.rb +0 -22
- data/lib/rubocop/cop/favor_modifier.rb +0 -72
- data/lib/rubocop/cop/favor_percent_r.rb +0 -19
- data/lib/rubocop/cop/favor_sprintf.rb +0 -21
- data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
- data/lib/rubocop/cop/handle_exceptions.rb +0 -17
- data/lib/rubocop/cop/hash_syntax.rb +0 -41
- data/lib/rubocop/cop/if_then_else.rb +0 -65
- data/lib/rubocop/cop/leading_comment_space.rb +0 -17
- data/lib/rubocop/cop/line_continuation.rb +0 -15
- data/lib/rubocop/cop/line_length.rb +0 -23
- data/lib/rubocop/cop/loop.rb +0 -33
- data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
- data/lib/rubocop/cop/method_length.rb +0 -52
- data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
- data/lib/rubocop/cop/not.rb +0 -21
- data/lib/rubocop/cop/numeric_literals.rb +0 -21
- data/lib/rubocop/cop/parameter_lists.rb +0 -23
- data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
- data/lib/rubocop/cop/percent_r.rb +0 -19
- data/lib/rubocop/cop/reduce_arguments.rb +0 -29
- data/lib/rubocop/cop/rescue_exception.rb +0 -26
- data/lib/rubocop/cop/rescue_modifier.rb +0 -17
- data/lib/rubocop/cop/semicolon.rb +0 -31
- data/lib/rubocop/cop/single_line_methods.rb +0 -44
- data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
- data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
- data/lib/rubocop/cop/string_literals.rb +0 -22
- data/lib/rubocop/cop/surrounding_space.rb +0 -283
- data/lib/rubocop/cop/symbol_array.rb +0 -31
- data/lib/rubocop/cop/symbol_name.rb +0 -23
- data/lib/rubocop/cop/syntax.rb +0 -49
- data/lib/rubocop/cop/tab.rb +0 -15
- data/lib/rubocop/cop/ternary_operator.rb +0 -43
- data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
- data/lib/rubocop/cop/trivial_accessors.rb +0 -26
- data/lib/rubocop/cop/unless_else.rb +0 -23
- data/lib/rubocop/cop/variable_interpolation.rb +0 -29
- data/lib/rubocop/cop/when_then.rb +0 -17
- data/lib/rubocop/cop/word_array.rb +0 -37
- data/lib/rubocop/report/emacs_style.rb +0 -17
- data/lib/rubocop/report/plain_text.rb +0 -18
- data/lib/rubocop/report/report.rb +0 -44
- data/spec/rubocop/cops/access_control_spec.rb +0 -129
- data/spec/rubocop/cops/alias_spec.rb +0 -39
- data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
- data/spec/rubocop/cops/and_or_spec.rb +0 -37
- data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
- data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
- data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
- data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
- data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
- data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
- data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
- data/spec/rubocop/cops/block_comments_spec.rb +0 -25
- data/spec/rubocop/cops/blocks_spec.rb +0 -33
- data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
- data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
- data/spec/rubocop/cops/class_methods_spec.rb +0 -49
- data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
- data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
- data/spec/rubocop/cops/constant_name_spec.rb +0 -42
- data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
- data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
- data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
- data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
- data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
- data/spec/rubocop/cops/encoding_spec.rb +0 -47
- data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
- data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
- data/spec/rubocop/cops/eval_spec.rb +0 -39
- data/spec/rubocop/cops/favor_join_spec.rb +0 -35
- data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
- data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
- data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
- data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
- data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
- data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
- data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
- data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
- data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
- data/spec/rubocop/cops/line_length_spec.rb +0 -23
- data/spec/rubocop/cops/loop_spec.rb +0 -31
- data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
- data/spec/rubocop/cops/method_length_spec.rb +0 -147
- data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
- data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
- data/spec/rubocop/cops/not_spec.rb +0 -31
- data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
- data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
- data/spec/rubocop/cops/op_method_spec.rb +0 -78
- data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
- data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
- data/spec/rubocop/cops/percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
- data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
- data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
- data/spec/rubocop/cops/semicolon_spec.rb +0 -88
- data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
- data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
- data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
- data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
- data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
- data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
- data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
- data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
- data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
- data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
- data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
- data/spec/rubocop/cops/string_literals_spec.rb +0 -47
- data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
- data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
- data/spec/rubocop/cops/syntax_spec.rb +0 -41
- data/spec/rubocop/cops/tab_spec.rb +0 -21
- data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
- data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
- data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
- data/spec/rubocop/cops/unless_else_spec.rb +0 -29
- data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
- data/spec/rubocop/cops/when_then_spec.rb +0 -38
- data/spec/rubocop/cops/word_array_spec.rb +0 -47
- data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
- data/spec/rubocop/reports/report_spec.rb +0 -29
|
@@ -1,114 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe FavorModifier, broken: true do
|
|
8
|
-
let(:if_until) { IfUnlessModifier.new }
|
|
9
|
-
let(:while_until) { WhileUntilModifier.new }
|
|
10
|
-
before { LineLength.config = { 'Max' => 79 } }
|
|
11
|
-
|
|
12
|
-
it 'registers an offence for multiline if that fits on one line' do
|
|
13
|
-
# This if statement fits exactly on one line if written as a modifier.
|
|
14
|
-
inspect_source(if_until,
|
|
15
|
-
['if a_condition_that_is_just_short_enough',
|
|
16
|
-
' some_long_metod_name(followed_by_args)',
|
|
17
|
-
'end'])
|
|
18
|
-
expect(if_until.offences.map(&:message)).to eq(
|
|
19
|
-
['Favor modifier if/unless usage when you have a single-line body.' +
|
|
20
|
-
' Another good alternative is the usage of control flow and/or.'])
|
|
21
|
-
end
|
|
22
|
-
|
|
23
|
-
it "accepts multiline if that doesn't fit on one line" do
|
|
24
|
-
check_too_long(if_until, 'if')
|
|
25
|
-
end
|
|
26
|
-
|
|
27
|
-
it 'accepts multiline if whose body is more than one line' do
|
|
28
|
-
check_short_multiline(if_until, 'if')
|
|
29
|
-
end
|
|
30
|
-
|
|
31
|
-
it 'registers an offence for multiline unless that fits on one line' do
|
|
32
|
-
inspect_source(if_until, ['unless a',
|
|
33
|
-
' b',
|
|
34
|
-
'end'])
|
|
35
|
-
expect(if_until.offences.map(&:message)).to eq(
|
|
36
|
-
['Favor modifier if/unless usage when you have a single-line body.' +
|
|
37
|
-
' Another good alternative is the usage of control flow and/or.'])
|
|
38
|
-
end
|
|
39
|
-
|
|
40
|
-
it 'accepts code with EOL comment since user might want to keep it' do
|
|
41
|
-
pending
|
|
42
|
-
inspect_source(if_until, ['unless a',
|
|
43
|
-
' b # A comment',
|
|
44
|
-
'end'])
|
|
45
|
-
expect(if_until.offences.map(&:message)).to be_empty
|
|
46
|
-
end
|
|
47
|
-
|
|
48
|
-
it 'accepts if-else-end' do
|
|
49
|
-
inspect_source(if_until,
|
|
50
|
-
['if args.last.is_a? Hash then args.pop else ' +
|
|
51
|
-
'Hash.new end'])
|
|
52
|
-
expect(if_until.offences.map(&:message)).to be_empty
|
|
53
|
-
end
|
|
54
|
-
|
|
55
|
-
it "accepts multiline unless that doesn't fit on one line" do
|
|
56
|
-
check_too_long(while_until, 'unless')
|
|
57
|
-
end
|
|
58
|
-
|
|
59
|
-
it 'accepts multiline unless whose body is more than one line' do
|
|
60
|
-
check_short_multiline(while_until, 'unless')
|
|
61
|
-
end
|
|
62
|
-
|
|
63
|
-
it 'registers an offence for multiline while that fits on one line' do
|
|
64
|
-
check_really_short(while_until, 'while')
|
|
65
|
-
end
|
|
66
|
-
|
|
67
|
-
it "accepts multiline while that doesn't fit on one line" do
|
|
68
|
-
check_too_long(while_until, 'while')
|
|
69
|
-
end
|
|
70
|
-
|
|
71
|
-
it 'accepts multiline while whose body is more than one line' do
|
|
72
|
-
check_short_multiline(while_until, 'while')
|
|
73
|
-
end
|
|
74
|
-
|
|
75
|
-
it 'registers an offence for multiline until that fits on one line' do
|
|
76
|
-
check_really_short(while_until, 'until')
|
|
77
|
-
end
|
|
78
|
-
|
|
79
|
-
it "accepts multiline until that doesn't fit on one line" do
|
|
80
|
-
check_too_long(while_until, 'until')
|
|
81
|
-
end
|
|
82
|
-
|
|
83
|
-
it 'accepts multiline until whose body is more than one line' do
|
|
84
|
-
check_short_multiline(while_until, 'until')
|
|
85
|
-
end
|
|
86
|
-
|
|
87
|
-
def check_really_short(cop, keyword)
|
|
88
|
-
inspect_source(cop, ["#{keyword} a",
|
|
89
|
-
' b',
|
|
90
|
-
'end'])
|
|
91
|
-
expect(cop.offences.map(&:message)).to eq(
|
|
92
|
-
['Favor modifier while/until usage when you have a single-line ' +
|
|
93
|
-
'body.'])
|
|
94
|
-
end
|
|
95
|
-
|
|
96
|
-
def check_too_long(cop, keyword)
|
|
97
|
-
inspect_source(cop,
|
|
98
|
-
[" #{keyword} a_lengthy_condition_that_goes_on_and_on",
|
|
99
|
-
' some_long_metod_name(followed_by_args)',
|
|
100
|
-
' end'])
|
|
101
|
-
expect(cop.offences.map(&:message)).to be_empty
|
|
102
|
-
end
|
|
103
|
-
|
|
104
|
-
def check_short_multiline(cop, keyword)
|
|
105
|
-
inspect_source(cop,
|
|
106
|
-
["#{keyword} ENV['COVERAGE']",
|
|
107
|
-
" require 'simplecov'",
|
|
108
|
-
' SimpleCov.start',
|
|
109
|
-
'end'])
|
|
110
|
-
expect(cop.offences.map(&:message)).to be_empty
|
|
111
|
-
end
|
|
112
|
-
end
|
|
113
|
-
end
|
|
114
|
-
end
|
|
@@ -1,29 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe FavorPercentR do
|
|
8
|
-
let(:fpr) { FavorPercentR.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for // with two slashes in regexp' do
|
|
11
|
-
inspect_source(fpr, ['x =~ /home\/\//',
|
|
12
|
-
'y =~ /etc\/top\//'])
|
|
13
|
-
expect(fpr.offences.map(&:message))
|
|
14
|
-
.to eq([FavorPercentR::MSG] * 2)
|
|
15
|
-
end
|
|
16
|
-
|
|
17
|
-
it 'accepts // with only one slash in regexp' do
|
|
18
|
-
inspect_source(fpr, ['x =~ /\/home/',
|
|
19
|
-
'y =~ /\//'])
|
|
20
|
-
expect(fpr.offences.map(&:message)).to be_empty
|
|
21
|
-
end
|
|
22
|
-
|
|
23
|
-
it 'accepts %r delimiters for regexp with two or more slashes' do
|
|
24
|
-
inspect_source(fpr, ['x =~ %r(/home/)'])
|
|
25
|
-
expect(fpr.offences.map(&:message)).to be_empty
|
|
26
|
-
end
|
|
27
|
-
end
|
|
28
|
-
end
|
|
29
|
-
end
|
|
@@ -1,51 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe FavorSprintf do
|
|
8
|
-
let(:fs) { FavorSprintf.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for a string followed by something' do
|
|
11
|
-
inspect_source(fs,
|
|
12
|
-
['puts "%d" % 10'])
|
|
13
|
-
expect(fs.offences.size).to eq(1)
|
|
14
|
-
expect(fs.offences.map(&:message))
|
|
15
|
-
.to eq([FavorSprintf::MSG])
|
|
16
|
-
end
|
|
17
|
-
|
|
18
|
-
it 'registers an offence for something followed by an array' do
|
|
19
|
-
inspect_source(fs,
|
|
20
|
-
['puts x % [10, 11]'])
|
|
21
|
-
expect(fs.offences.size).to eq(1)
|
|
22
|
-
expect(fs.offences.map(&:message))
|
|
23
|
-
.to eq([FavorSprintf::MSG])
|
|
24
|
-
end
|
|
25
|
-
|
|
26
|
-
it 'does not register an offence for numbers' do
|
|
27
|
-
inspect_source(fs,
|
|
28
|
-
['puts 10 % 4'])
|
|
29
|
-
expect(fs.offences).to be_empty
|
|
30
|
-
end
|
|
31
|
-
|
|
32
|
-
it 'does not register an offence for ambiguous cases' do
|
|
33
|
-
inspect_source(fs,
|
|
34
|
-
['puts x % 4'])
|
|
35
|
-
expect(fs.offences).to be_empty
|
|
36
|
-
|
|
37
|
-
inspect_source(fs,
|
|
38
|
-
['puts x % Y'])
|
|
39
|
-
expect(fs.offences).to be_empty
|
|
40
|
-
end
|
|
41
|
-
|
|
42
|
-
it 'works if the first operand contains embedded expressions' do
|
|
43
|
-
inspect_source(fs,
|
|
44
|
-
['puts "#{x * 5} %d #{@test}" % 10'])
|
|
45
|
-
expect(fs.offences.size).to eq(1)
|
|
46
|
-
expect(fs.offences.map(&:message))
|
|
47
|
-
.to eq([FavorSprintf::MSG])
|
|
48
|
-
end
|
|
49
|
-
end
|
|
50
|
-
end
|
|
51
|
-
end
|
|
@@ -1,62 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe FavorUnlessOverNegatedIf do
|
|
8
|
-
let(:fav_unless) { FavorUnlessOverNegatedIf.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for if with exclamation point condition' do
|
|
11
|
-
inspect_source(fav_unless,
|
|
12
|
-
['if !a_condition',
|
|
13
|
-
' some_method',
|
|
14
|
-
'end',
|
|
15
|
-
'some_method if !a_condition',
|
|
16
|
-
])
|
|
17
|
-
expect(fav_unless.offences.map(&:message)).to eq(
|
|
18
|
-
['Favor unless (or control flow or) over if for negative ' +
|
|
19
|
-
'conditions.'] * 2)
|
|
20
|
-
end
|
|
21
|
-
|
|
22
|
-
it 'registers an offence for if with "not" condition' do
|
|
23
|
-
inspect_source(fav_unless,
|
|
24
|
-
['if not a_condition',
|
|
25
|
-
' some_method',
|
|
26
|
-
'end',
|
|
27
|
-
'some_method if not a_condition'])
|
|
28
|
-
expect(fav_unless.offences.map(&:message)).to eq(
|
|
29
|
-
['Favor unless (or control flow or) over if for negative ' +
|
|
30
|
-
'conditions.'] * 2)
|
|
31
|
-
expect(fav_unless.offences.map(&:line_number)).to eq([1, 4])
|
|
32
|
-
end
|
|
33
|
-
|
|
34
|
-
it 'accepts an if/else with negative condition' do
|
|
35
|
-
inspect_source(fav_unless,
|
|
36
|
-
['if !a_condition',
|
|
37
|
-
' some_method',
|
|
38
|
-
'else',
|
|
39
|
-
' something_else',
|
|
40
|
-
'end',
|
|
41
|
-
'if not a_condition',
|
|
42
|
-
' some_method',
|
|
43
|
-
'elsif other_condition',
|
|
44
|
-
' something_else',
|
|
45
|
-
'end'])
|
|
46
|
-
expect(fav_unless.offences.map(&:message)).to be_empty
|
|
47
|
-
end
|
|
48
|
-
|
|
49
|
-
it 'accepts an if where only part of the contition is negated' do
|
|
50
|
-
inspect_source(fav_unless,
|
|
51
|
-
['if !a_condition && another_condition',
|
|
52
|
-
' some_method',
|
|
53
|
-
'end',
|
|
54
|
-
'if not a_condition or another_condition',
|
|
55
|
-
' some_method',
|
|
56
|
-
'end',
|
|
57
|
-
'some_method if not a_condition or another_condition'])
|
|
58
|
-
expect(fav_unless.offences.map(&:message)).to be_empty
|
|
59
|
-
end
|
|
60
|
-
end
|
|
61
|
-
end
|
|
62
|
-
end
|
|
@@ -1,45 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe FavorUntilOverNegatedWhile do
|
|
8
|
-
let(:fav_until) { FavorUntilOverNegatedWhile.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for while with exclamation point condition' do
|
|
11
|
-
inspect_source(fav_until,
|
|
12
|
-
['while !a_condition',
|
|
13
|
-
' some_method',
|
|
14
|
-
'end',
|
|
15
|
-
'some_method while !a_condition',
|
|
16
|
-
])
|
|
17
|
-
expect(fav_until.offences.map(&:message)).to eq(
|
|
18
|
-
['Favor until over while for negative conditions.'] * 2)
|
|
19
|
-
end
|
|
20
|
-
|
|
21
|
-
it 'registers an offence for while with "not" condition' do
|
|
22
|
-
inspect_source(fav_until,
|
|
23
|
-
['while (not a_condition)',
|
|
24
|
-
' some_method',
|
|
25
|
-
'end',
|
|
26
|
-
'some_method while not a_condition'])
|
|
27
|
-
expect(fav_until.offences.map(&:message)).to eq(
|
|
28
|
-
['Favor until over while for negative conditions.'] * 2)
|
|
29
|
-
expect(fav_until.offences.map(&:line_number)).to eq([1, 4])
|
|
30
|
-
end
|
|
31
|
-
|
|
32
|
-
it 'accepts an while where only part of the contition is negated' do
|
|
33
|
-
inspect_source(fav_until,
|
|
34
|
-
['while !a_condition && another_condition',
|
|
35
|
-
' some_method',
|
|
36
|
-
'end',
|
|
37
|
-
'while not a_condition or another_condition',
|
|
38
|
-
' some_method',
|
|
39
|
-
'end',
|
|
40
|
-
'some_method while not a_condition or other_cond'])
|
|
41
|
-
expect(fav_until.offences.map(&:message)).to be_empty
|
|
42
|
-
end
|
|
43
|
-
end
|
|
44
|
-
end
|
|
45
|
-
end
|
|
@@ -1,34 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe HandleExceptions do
|
|
8
|
-
let(:he) { HandleExceptions.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for empty rescue block' do
|
|
11
|
-
inspect_source(he,
|
|
12
|
-
['begin',
|
|
13
|
-
' something',
|
|
14
|
-
'rescue',
|
|
15
|
-
' #do nothing',
|
|
16
|
-
'end'])
|
|
17
|
-
expect(he.offences.size).to eq(1)
|
|
18
|
-
expect(he.offences.map(&:message))
|
|
19
|
-
.to eq([HandleExceptions::MSG])
|
|
20
|
-
end
|
|
21
|
-
|
|
22
|
-
it 'does not register an offence for rescue with body' do
|
|
23
|
-
inspect_source(he,
|
|
24
|
-
['begin',
|
|
25
|
-
' something',
|
|
26
|
-
' return',
|
|
27
|
-
'rescue',
|
|
28
|
-
' file.close',
|
|
29
|
-
'end'])
|
|
30
|
-
expect(he.offences).to be_empty
|
|
31
|
-
end
|
|
32
|
-
end
|
|
33
|
-
end
|
|
34
|
-
end
|
|
@@ -1,49 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe HashSyntax do
|
|
8
|
-
let(:hash_syntax) { HashSyntax.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for hash rocket syntax when new is possible' do
|
|
11
|
-
inspect_source(hash_syntax, ['x = { :a => 0 }'])
|
|
12
|
-
expect(hash_syntax.offences.map(&:message)).to eq(
|
|
13
|
-
['Ruby 1.8 hash syntax detected'])
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
it 'registers an offence for mixed syntax when new is possible' do
|
|
17
|
-
inspect_source(hash_syntax, ['x = { :a => 0, b: 1 }'])
|
|
18
|
-
expect(hash_syntax.offences.map(&:message)).to eq(
|
|
19
|
-
['Ruby 1.8 hash syntax detected'])
|
|
20
|
-
end
|
|
21
|
-
|
|
22
|
-
it 'registers an offence for hash rockets in method calls' do
|
|
23
|
-
inspect_source(hash_syntax, ['func(3, :a => 0)'])
|
|
24
|
-
expect(hash_syntax.offences.map(&:message)).to eq(
|
|
25
|
-
['Ruby 1.8 hash syntax detected'])
|
|
26
|
-
end
|
|
27
|
-
|
|
28
|
-
it 'accepts hash rockets when keys have different types' do
|
|
29
|
-
inspect_source(hash_syntax, ['x = { :a => 0, "b" => 1 }'])
|
|
30
|
-
expect(hash_syntax.offences.map(&:message)).to be_empty
|
|
31
|
-
end
|
|
32
|
-
|
|
33
|
-
it 'accepts hash rockets when keys special symbols in them' do
|
|
34
|
-
inspect_source(hash_syntax, ['x = { :"t o" => 0, :"\xab" => 1 }'])
|
|
35
|
-
expect(hash_syntax.offences.map(&:message)).to be_empty
|
|
36
|
-
end
|
|
37
|
-
|
|
38
|
-
it 'accepts new syntax in a hash literal' do
|
|
39
|
-
inspect_source(hash_syntax, ['x = { a: 0, b: 1 }'])
|
|
40
|
-
expect(hash_syntax.offences.map(&:message)).to be_empty
|
|
41
|
-
end
|
|
42
|
-
|
|
43
|
-
it 'accepts new syntax in method calls' do
|
|
44
|
-
inspect_source(hash_syntax, ['func(3, a: 0)'])
|
|
45
|
-
expect(hash_syntax.offences.map(&:message)).to be_empty
|
|
46
|
-
end
|
|
47
|
-
end
|
|
48
|
-
end
|
|
49
|
-
end
|
|
@@ -1,23 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe IfWithSemicolon do
|
|
8
|
-
let(:iws) { IfWithSemicolon.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for one line if/;/end' do
|
|
11
|
-
inspect_source(iws, ['if cond; run else dont end'])
|
|
12
|
-
expect(iws.offences.map(&:message)).to eq(
|
|
13
|
-
['Never use if x; Use the ternary operator instead.'])
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
it 'can handle modifier conditionals' do
|
|
17
|
-
inspect_source(iws, ['class Hash',
|
|
18
|
-
'end if RUBY_VERSION < "1.8.7"'])
|
|
19
|
-
expect(iws.offences.map(&:message)).to be_empty
|
|
20
|
-
end
|
|
21
|
-
end
|
|
22
|
-
end
|
|
23
|
-
end
|
|
@@ -1,54 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe LeadingCommentSpace do
|
|
8
|
-
let(:lcs) { LeadingCommentSpace.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for comment without leading space' do
|
|
11
|
-
inspect_source(lcs,
|
|
12
|
-
['#missing space'])
|
|
13
|
-
expect(lcs.offences.size).to eq(1)
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
it 'does not register an offence for # followed by no text' do
|
|
17
|
-
inspect_source(lcs,
|
|
18
|
-
['#'])
|
|
19
|
-
expect(lcs.offences).to be_empty
|
|
20
|
-
end
|
|
21
|
-
|
|
22
|
-
it 'does not register an offence for more than one space' do
|
|
23
|
-
inspect_source(lcs,
|
|
24
|
-
['# heavily indented'])
|
|
25
|
-
expect(lcs.offences).to be_empty
|
|
26
|
-
end
|
|
27
|
-
|
|
28
|
-
it 'does not register an offence for more than one #' do
|
|
29
|
-
inspect_source(lcs,
|
|
30
|
-
['###### heavily indented'])
|
|
31
|
-
expect(lcs.offences).to be_empty
|
|
32
|
-
end
|
|
33
|
-
|
|
34
|
-
it 'does not register an offence for only #s' do
|
|
35
|
-
inspect_source(lcs,
|
|
36
|
-
['######'])
|
|
37
|
-
expect(lcs.offences).to be_empty
|
|
38
|
-
end
|
|
39
|
-
|
|
40
|
-
it 'does not register an offence for #! on first line' do
|
|
41
|
-
inspect_source(lcs,
|
|
42
|
-
['#!/usr/bin/ruby',
|
|
43
|
-
'test'])
|
|
44
|
-
expect(lcs.offences).to be_empty
|
|
45
|
-
end
|
|
46
|
-
|
|
47
|
-
it 'registers an offence for #! after the first line' do
|
|
48
|
-
inspect_source(lcs,
|
|
49
|
-
['test', '#!/usr/bin/ruby'])
|
|
50
|
-
expect(lcs.offences.size).to eq(1)
|
|
51
|
-
end
|
|
52
|
-
end
|
|
53
|
-
end
|
|
54
|
-
end
|
|
@@ -1,24 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe LineContinuation do
|
|
8
|
-
let(:lc) { LineContinuation.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for line continuation char' do
|
|
11
|
-
inspect_source(lc,
|
|
12
|
-
['test = 5 \\', '+ 5'])
|
|
13
|
-
expect(lc.offences.size).to eq(1)
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
it 'does not register an offence for cont char in a string' do
|
|
17
|
-
inspect_source(lc,
|
|
18
|
-
['result = "test string\\\n"',
|
|
19
|
-
'more'])
|
|
20
|
-
expect(lc.offences).to be_empty
|
|
21
|
-
end
|
|
22
|
-
end
|
|
23
|
-
end
|
|
24
|
-
end
|
|
@@ -1,23 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe LineLength do
|
|
8
|
-
let(:ll) { LineLength.new }
|
|
9
|
-
before { LineLength.config = { 'Max' => 79 } }
|
|
10
|
-
|
|
11
|
-
it "registers an offence for a line that's 80 characters wide" do
|
|
12
|
-
ll.inspect(['#' * 80], nil, nil, nil)
|
|
13
|
-
expect(ll.offences.size).to eq(1)
|
|
14
|
-
expect(ll.offences.first.message).to eq('Line is too long. [80/79]')
|
|
15
|
-
end
|
|
16
|
-
|
|
17
|
-
it "accepts a line that's 79 characters wide" do
|
|
18
|
-
ll.inspect(['#' * 79], nil, nil, nil)
|
|
19
|
-
expect(ll.offences).to be_empty
|
|
20
|
-
end
|
|
21
|
-
end
|
|
22
|
-
end
|
|
23
|
-
end
|
|
@@ -1,31 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe Loop do
|
|
8
|
-
let(:loop) { Loop.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for begin/end/while' do
|
|
11
|
-
inspect_source(loop, ['begin something; top; end while test'])
|
|
12
|
-
expect(loop.offences.size).to eq(1)
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
it 'registers an offence for begin/end/until' do
|
|
16
|
-
inspect_source(loop, ['begin something; top; end until test'])
|
|
17
|
-
expect(loop.offences.size).to eq(1)
|
|
18
|
-
end
|
|
19
|
-
|
|
20
|
-
it 'accepts normal while' do
|
|
21
|
-
inspect_source(loop, ['while test; one; two; end'])
|
|
22
|
-
expect(loop.offences).to be_empty
|
|
23
|
-
end
|
|
24
|
-
|
|
25
|
-
it 'accepts normal until' do
|
|
26
|
-
inspect_source(loop, ['until test; one; two; end'])
|
|
27
|
-
expect(loop.offences).to be_empty
|
|
28
|
-
end
|
|
29
|
-
end
|
|
30
|
-
end
|
|
31
|
-
end
|
|
@@ -1,93 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe MethodAndVariableSnakeCase do
|
|
8
|
-
let(:snake_case) { MethodAndVariableSnakeCase.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for camel case in instance method name' do
|
|
11
|
-
inspect_source(snake_case,
|
|
12
|
-
['def myMethod',
|
|
13
|
-
' # ...',
|
|
14
|
-
'end',
|
|
15
|
-
])
|
|
16
|
-
expect(snake_case.offences.map(&:message)).to eq(
|
|
17
|
-
['Use snake_case for methods and variables.'])
|
|
18
|
-
end
|
|
19
|
-
|
|
20
|
-
it 'registers an offence for camel case in singleton method name' do
|
|
21
|
-
inspect_source(snake_case,
|
|
22
|
-
['def self.myMethod',
|
|
23
|
-
' # ...',
|
|
24
|
-
'end',
|
|
25
|
-
])
|
|
26
|
-
expect(snake_case.offences.map(&:message)).to eq(
|
|
27
|
-
['Use snake_case for methods and variables.'])
|
|
28
|
-
end
|
|
29
|
-
|
|
30
|
-
it 'registers an offence for camel case in local variable name' do
|
|
31
|
-
inspect_source(snake_case, ['myLocal = 1'])
|
|
32
|
-
expect(snake_case.offences.map(&:message)).to eq(
|
|
33
|
-
['Use snake_case for methods and variables.'])
|
|
34
|
-
end
|
|
35
|
-
|
|
36
|
-
it 'registers an offence for camel case in instance variable name' do
|
|
37
|
-
inspect_source(snake_case, ['@myAttribute = 3'])
|
|
38
|
-
expect(snake_case.offences.map(&:message)).to eq(
|
|
39
|
-
['Use snake_case for methods and variables.'])
|
|
40
|
-
end
|
|
41
|
-
|
|
42
|
-
it 'registers an offence for camel case in setter name' do
|
|
43
|
-
inspect_source(snake_case, ['self.mySetter = 2'])
|
|
44
|
-
expect(snake_case.offences.map(&:message)).to eq(
|
|
45
|
-
['Use snake_case for methods and variables.'])
|
|
46
|
-
end
|
|
47
|
-
|
|
48
|
-
it 'registers an offence for capitalized camel case' do
|
|
49
|
-
inspect_source(snake_case,
|
|
50
|
-
['def MyMethod',
|
|
51
|
-
'end',
|
|
52
|
-
])
|
|
53
|
-
expect(snake_case.offences.map(&:message)).to eq(
|
|
54
|
-
['Use snake_case for methods and variables.'])
|
|
55
|
-
end
|
|
56
|
-
|
|
57
|
-
it 'accepts snake case in names' do
|
|
58
|
-
inspect_source(snake_case,
|
|
59
|
-
['def my_method',
|
|
60
|
-
' my_local_html = 1',
|
|
61
|
-
' self.my_setter = 2',
|
|
62
|
-
' @my_attribute = 3',
|
|
63
|
-
'end',
|
|
64
|
-
])
|
|
65
|
-
expect(snake_case.offences.map(&:message)).to be_empty
|
|
66
|
-
end
|
|
67
|
-
|
|
68
|
-
it 'registers an offence for mixed snake case and camel case' do
|
|
69
|
-
inspect_source(snake_case,
|
|
70
|
-
['def visit_Arel_Nodes_SelectStatement',
|
|
71
|
-
'end'])
|
|
72
|
-
expect(snake_case.offences.map(&:message)).to eq(
|
|
73
|
-
['Use snake_case for methods and variables.'])
|
|
74
|
-
end
|
|
75
|
-
|
|
76
|
-
it 'accepts screaming snake case globals' do
|
|
77
|
-
inspect_source(snake_case, ['$MY_GLOBAL = 0'])
|
|
78
|
-
expect(snake_case.offences.map(&:message)).to be_empty
|
|
79
|
-
end
|
|
80
|
-
|
|
81
|
-
it 'accepts screaming snake case constants' do
|
|
82
|
-
inspect_source(snake_case, ['MY_CONSTANT = 0'])
|
|
83
|
-
expect(snake_case.offences.map(&:message)).to be_empty
|
|
84
|
-
end
|
|
85
|
-
|
|
86
|
-
it 'accepts assigning to camel case constant' do
|
|
87
|
-
inspect_source(snake_case,
|
|
88
|
-
['Paren = Struct.new :left, :right, :kind'])
|
|
89
|
-
expect(snake_case.offences.map(&:message)).to be_empty
|
|
90
|
-
end
|
|
91
|
-
end
|
|
92
|
-
end
|
|
93
|
-
end
|