rubocop 0.8.0 → 0.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.travis.yml +0 -4
- data/.yardopts +2 -0
- data/CHANGELOG.md +95 -1
- data/README.md +101 -11
- data/config/default.yml +14 -2
- data/config/enabled.yml +96 -14
- data/lib/rubocop/cli.rb +178 -94
- data/lib/rubocop/config.rb +56 -11
- data/lib/rubocop/config_store.rb +2 -0
- data/lib/rubocop/cop/cop.rb +54 -11
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
- data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
- data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
- data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
- data/lib/rubocop/cop/lint/eval.rb +22 -0
- data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
- data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
- data/lib/rubocop/cop/lint/loop.rb +29 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
- data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
- data/lib/rubocop/cop/lint/void.rb +58 -0
- data/lib/rubocop/cop/offence.rb +112 -12
- data/lib/rubocop/cop/rails/validation.rb +34 -0
- data/lib/rubocop/cop/style/access_control.rb +58 -0
- data/lib/rubocop/cop/style/alias.rb +28 -0
- data/lib/rubocop/cop/style/align_parameters.rb +39 -0
- data/lib/rubocop/cop/style/and_or.rb +45 -0
- data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
- data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
- data/lib/rubocop/cop/style/attr.rb +20 -0
- data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
- data/lib/rubocop/cop/style/avoid_for.rb +18 -0
- data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
- data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
- data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
- data/lib/rubocop/cop/style/begin_block.rb +18 -0
- data/lib/rubocop/cop/style/block_comments.rb +20 -0
- data/lib/rubocop/cop/style/block_nesting.rb +47 -0
- data/lib/rubocop/cop/style/blocks.rb +27 -0
- data/lib/rubocop/cop/style/case_equality.rb +22 -0
- data/lib/rubocop/cop/style/case_indentation.rb +28 -0
- data/lib/rubocop/cop/style/character_literal.rb +37 -0
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
- data/lib/rubocop/cop/style/class_methods.rb +22 -0
- data/lib/rubocop/cop/style/collection_methods.rb +37 -0
- data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
- data/lib/rubocop/cop/style/constant_name.rb +31 -0
- data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
- data/lib/rubocop/cop/style/documentation.rb +58 -0
- data/lib/rubocop/cop/style/dot_position.rb +25 -0
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
- data/lib/rubocop/cop/style/empty_lines.rb +40 -0
- data/lib/rubocop/cop/style/empty_literal.rb +53 -0
- data/lib/rubocop/cop/style/encoding.rb +29 -0
- data/lib/rubocop/cop/style/end_block.rb +18 -0
- data/lib/rubocop/cop/style/end_of_line.rb +23 -0
- data/lib/rubocop/cop/style/favor_join.rb +29 -0
- data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
- data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
- data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
- data/lib/rubocop/cop/style/if_then_else.rb +80 -0
- data/lib/rubocop/cop/style/lambda.rb +47 -0
- data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
- data/lib/rubocop/cop/style/line_continuation.rb +26 -0
- data/lib/rubocop/cop/style/line_length.rb +30 -0
- data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
- data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
- data/lib/rubocop/cop/style/method_length.rb +57 -0
- data/lib/rubocop/cop/style/not.rb +24 -0
- data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
- data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
- data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
- data/lib/rubocop/cop/style/proc.rb +30 -0
- data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
- data/lib/rubocop/cop/style/semicolon.rb +51 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
- data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
- data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
- data/lib/rubocop/cop/style/string_literals.rb +36 -0
- data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
- data/lib/rubocop/cop/style/symbol_array.rb +31 -0
- data/lib/rubocop/cop/style/symbol_name.rb +27 -0
- data/lib/rubocop/cop/style/tab.rb +25 -0
- data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
- data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
- data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
- data/lib/rubocop/cop/style/unless_else.rb +26 -0
- data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
- data/lib/rubocop/cop/style/when_then.rb +25 -0
- data/lib/rubocop/cop/style/while_until_do.rb +45 -0
- data/lib/rubocop/cop/style/word_array.rb +44 -0
- data/lib/rubocop/cop/util.rb +1 -0
- data/lib/rubocop/cop/variable_inspector.rb +280 -0
- data/lib/rubocop/formatter/base_formatter.rb +119 -0
- data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
- data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
- data/lib/rubocop/formatter/formatter_set.rb +77 -0
- data/lib/rubocop/formatter/json_formatter.rb +76 -0
- data/lib/rubocop/formatter/progress_formatter.rb +63 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
- data/lib/rubocop/version.rb +15 -1
- data/lib/rubocop.rb +97 -71
- data/rubocop.gemspec +1 -2
- data/spec/.rubocop.yml +5 -0
- data/spec/project_spec.rb +4 -7
- data/spec/rubocop/cli_spec.rb +402 -143
- data/spec/rubocop/config_spec.rb +61 -0
- data/spec/rubocop/config_store_spec.rb +2 -2
- data/spec/rubocop/cops/cop_spec.rb +14 -7
- data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
- data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
- data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
- data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
- data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
- data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
- data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
- data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
- data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
- data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
- data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
- data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
- data/spec/rubocop/cops/lint/void_spec.rb +63 -0
- data/spec/rubocop/cops/offence_spec.rb +107 -10
- data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
- data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
- data/spec/rubocop/cops/style/alias_spec.rb +47 -0
- data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
- data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
- data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
- data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
- data/spec/rubocop/cops/style/attr_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
- data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
- data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
- data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
- data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
- data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
- data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
- data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
- data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
- data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
- data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
- data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
- data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
- data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
- data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
- data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
- data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
- data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
- data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
- data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
- data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
- data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
- data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
- data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
- data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
- data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
- data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
- data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
- data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
- data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
- data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
- data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
- data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
- data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
- data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
- data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
- data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
- data/spec/rubocop/cops/style/not_spec.rb +28 -0
- data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
- data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
- data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
- data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
- data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
- data/spec/rubocop/cops/style/proc_spec.rb +28 -0
- data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
- data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
- data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
- data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
- data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
- data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
- data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
- data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
- data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
- data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
- data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
- data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
- data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
- data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
- data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
- data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
- data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
- data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
- data/spec/rubocop/cops/style/tab_spec.rb +23 -0
- data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
- data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
- data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
- data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
- data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
- data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
- data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
- data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
- data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
- data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
- data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
- data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
- data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
- data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
- data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
- data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
- data/spec/spec_helper.rb +24 -9
- data/spec/support/mri_syntax_checker.rb +69 -0
- data/spec/support/shared_examples.rb +33 -0
- metadata +317 -239
- data/lib/rubocop/cop/access_control.rb +0 -41
- data/lib/rubocop/cop/alias.rb +0 -17
- data/lib/rubocop/cop/align_parameters.rb +0 -37
- data/lib/rubocop/cop/and_or.rb +0 -26
- data/lib/rubocop/cop/ascii_comments.rb +0 -13
- data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
- data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
- data/lib/rubocop/cop/avoid_for.rb +0 -17
- data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
- data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
- data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
- data/lib/rubocop/cop/block_comments.rb +0 -15
- data/lib/rubocop/cop/blocks.rb +0 -23
- data/lib/rubocop/cop/case_indentation.rb +0 -22
- data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
- data/lib/rubocop/cop/class_methods.rb +0 -15
- data/lib/rubocop/cop/collection_methods.rb +0 -29
- data/lib/rubocop/cop/colon_method_call.rb +0 -20
- data/lib/rubocop/cop/constant_name.rb +0 -24
- data/lib/rubocop/cop/def_parentheses.rb +0 -62
- data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
- data/lib/rubocop/cop/empty_lines.rb +0 -34
- data/lib/rubocop/cop/empty_literal.rb +0 -47
- data/lib/rubocop/cop/encoding.rb +0 -19
- data/lib/rubocop/cop/end_of_line.rb +0 -15
- data/lib/rubocop/cop/ensure_return.rb +0 -19
- data/lib/rubocop/cop/eval.rb +0 -19
- data/lib/rubocop/cop/favor_join.rb +0 -22
- data/lib/rubocop/cop/favor_modifier.rb +0 -72
- data/lib/rubocop/cop/favor_percent_r.rb +0 -19
- data/lib/rubocop/cop/favor_sprintf.rb +0 -21
- data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
- data/lib/rubocop/cop/handle_exceptions.rb +0 -17
- data/lib/rubocop/cop/hash_syntax.rb +0 -41
- data/lib/rubocop/cop/if_then_else.rb +0 -65
- data/lib/rubocop/cop/leading_comment_space.rb +0 -17
- data/lib/rubocop/cop/line_continuation.rb +0 -15
- data/lib/rubocop/cop/line_length.rb +0 -23
- data/lib/rubocop/cop/loop.rb +0 -33
- data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
- data/lib/rubocop/cop/method_length.rb +0 -52
- data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
- data/lib/rubocop/cop/not.rb +0 -21
- data/lib/rubocop/cop/numeric_literals.rb +0 -21
- data/lib/rubocop/cop/parameter_lists.rb +0 -23
- data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
- data/lib/rubocop/cop/percent_r.rb +0 -19
- data/lib/rubocop/cop/reduce_arguments.rb +0 -29
- data/lib/rubocop/cop/rescue_exception.rb +0 -26
- data/lib/rubocop/cop/rescue_modifier.rb +0 -17
- data/lib/rubocop/cop/semicolon.rb +0 -31
- data/lib/rubocop/cop/single_line_methods.rb +0 -44
- data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
- data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
- data/lib/rubocop/cop/string_literals.rb +0 -22
- data/lib/rubocop/cop/surrounding_space.rb +0 -283
- data/lib/rubocop/cop/symbol_array.rb +0 -31
- data/lib/rubocop/cop/symbol_name.rb +0 -23
- data/lib/rubocop/cop/syntax.rb +0 -49
- data/lib/rubocop/cop/tab.rb +0 -15
- data/lib/rubocop/cop/ternary_operator.rb +0 -43
- data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
- data/lib/rubocop/cop/trivial_accessors.rb +0 -26
- data/lib/rubocop/cop/unless_else.rb +0 -23
- data/lib/rubocop/cop/variable_interpolation.rb +0 -29
- data/lib/rubocop/cop/when_then.rb +0 -17
- data/lib/rubocop/cop/word_array.rb +0 -37
- data/lib/rubocop/report/emacs_style.rb +0 -17
- data/lib/rubocop/report/plain_text.rb +0 -18
- data/lib/rubocop/report/report.rb +0 -44
- data/spec/rubocop/cops/access_control_spec.rb +0 -129
- data/spec/rubocop/cops/alias_spec.rb +0 -39
- data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
- data/spec/rubocop/cops/and_or_spec.rb +0 -37
- data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
- data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
- data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
- data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
- data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
- data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
- data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
- data/spec/rubocop/cops/block_comments_spec.rb +0 -25
- data/spec/rubocop/cops/blocks_spec.rb +0 -33
- data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
- data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
- data/spec/rubocop/cops/class_methods_spec.rb +0 -49
- data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
- data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
- data/spec/rubocop/cops/constant_name_spec.rb +0 -42
- data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
- data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
- data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
- data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
- data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
- data/spec/rubocop/cops/encoding_spec.rb +0 -47
- data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
- data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
- data/spec/rubocop/cops/eval_spec.rb +0 -39
- data/spec/rubocop/cops/favor_join_spec.rb +0 -35
- data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
- data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
- data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
- data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
- data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
- data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
- data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
- data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
- data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
- data/spec/rubocop/cops/line_length_spec.rb +0 -23
- data/spec/rubocop/cops/loop_spec.rb +0 -31
- data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
- data/spec/rubocop/cops/method_length_spec.rb +0 -147
- data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
- data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
- data/spec/rubocop/cops/not_spec.rb +0 -31
- data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
- data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
- data/spec/rubocop/cops/op_method_spec.rb +0 -78
- data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
- data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
- data/spec/rubocop/cops/percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
- data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
- data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
- data/spec/rubocop/cops/semicolon_spec.rb +0 -88
- data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
- data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
- data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
- data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
- data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
- data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
- data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
- data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
- data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
- data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
- data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
- data/spec/rubocop/cops/string_literals_spec.rb +0 -47
- data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
- data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
- data/spec/rubocop/cops/syntax_spec.rb +0 -41
- data/spec/rubocop/cops/tab_spec.rb +0 -21
- data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
- data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
- data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
- data/spec/rubocop/cops/unless_else_spec.rb +0 -29
- data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
- data/spec/rubocop/cops/when_then_spec.rb +0 -38
- data/spec/rubocop/cops/word_array_spec.rb +0 -47
- data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
- data/spec/rubocop/reports/report_spec.rb +0 -29
data/lib/rubocop/cop/encoding.rb
DELETED
|
@@ -1,19 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class Encoding < Cop
|
|
6
|
-
MSG = 'Missing utf-8 encoding comment.'
|
|
7
|
-
|
|
8
|
-
def inspect(source, tokens, ast, comments)
|
|
9
|
-
unless RUBY_VERSION >= '2.0.0'
|
|
10
|
-
expected_line = 0
|
|
11
|
-
expected_line += 1 if source[expected_line] =~ /^#!/
|
|
12
|
-
unless source[expected_line] =~ /#.*coding: (UTF|utf)-8/
|
|
13
|
-
add_offence(:convention, 1, MSG)
|
|
14
|
-
end
|
|
15
|
-
end
|
|
16
|
-
end
|
|
17
|
-
end
|
|
18
|
-
end
|
|
19
|
-
end
|
|
@@ -1,15 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class EndOfLine < Cop
|
|
6
|
-
MSG = 'Carriage return character detected.'
|
|
7
|
-
|
|
8
|
-
def inspect(source, tokens, ast, comments)
|
|
9
|
-
source.each_with_index do |line, index|
|
|
10
|
-
add_offence(:convention, index + 1, MSG) if line =~ /\r$/
|
|
11
|
-
end
|
|
12
|
-
end
|
|
13
|
-
end
|
|
14
|
-
end
|
|
15
|
-
end
|
|
@@ -1,19 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class EnsureReturn < Cop
|
|
6
|
-
MSG = 'Never return from an ensure block.'
|
|
7
|
-
|
|
8
|
-
def on_ensure(node)
|
|
9
|
-
_body, ensure_body = *node
|
|
10
|
-
|
|
11
|
-
on_node(:return, ensure_body) do |e|
|
|
12
|
-
add_offence(:warning, e.loc.line, MSG)
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
super
|
|
16
|
-
end
|
|
17
|
-
end
|
|
18
|
-
end
|
|
19
|
-
end
|
data/lib/rubocop/cop/eval.rb
DELETED
|
@@ -1,19 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class Eval < Cop
|
|
6
|
-
MSG = 'The use of eval is a serious security risk.'
|
|
7
|
-
|
|
8
|
-
def on_send(node)
|
|
9
|
-
receiver, method_name, = *node
|
|
10
|
-
|
|
11
|
-
if receiver.nil? && method_name == :eval
|
|
12
|
-
add_offence(:security, node.loc.line, MSG)
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
super
|
|
16
|
-
end
|
|
17
|
-
end
|
|
18
|
-
end
|
|
19
|
-
end
|
|
@@ -1,22 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class FavorJoin < Cop
|
|
6
|
-
MSG = 'Favor Array#join over Array#*.'
|
|
7
|
-
|
|
8
|
-
def on_send(node)
|
|
9
|
-
receiver_node, method_name, *arg_nodes = *node
|
|
10
|
-
|
|
11
|
-
if receiver_node && receiver_node.type == :array &&
|
|
12
|
-
method_name == :* && arg_nodes[0].type == :str
|
|
13
|
-
add_offence(:convention,
|
|
14
|
-
node.loc.expression.line,
|
|
15
|
-
MSG)
|
|
16
|
-
end
|
|
17
|
-
|
|
18
|
-
super
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
end
|
|
22
|
-
end
|
|
@@ -1,72 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
module FavorModifier
|
|
6
|
-
# TODO extremely ugly solution that needs lots of polish
|
|
7
|
-
def check(sexp)
|
|
8
|
-
# discard if/then/else
|
|
9
|
-
return false if sexp.loc.respond_to?(:else) && sexp.loc.else
|
|
10
|
-
|
|
11
|
-
if %w(if while).include?(sexp.loc.keyword.source)
|
|
12
|
-
cond, body = *sexp
|
|
13
|
-
else
|
|
14
|
-
cond, _else, body = *sexp
|
|
15
|
-
end
|
|
16
|
-
|
|
17
|
-
if length(sexp) > 3
|
|
18
|
-
false
|
|
19
|
-
else
|
|
20
|
-
cond_length = sexp.loc.keyword.size + cond.loc.expression.size + 1
|
|
21
|
-
body_length = body_length(body)
|
|
22
|
-
|
|
23
|
-
(cond_length + body_length) <= LineLength.max
|
|
24
|
-
end
|
|
25
|
-
end
|
|
26
|
-
|
|
27
|
-
def length(sexp)
|
|
28
|
-
sexp.loc.expression.source.split("\n").size
|
|
29
|
-
end
|
|
30
|
-
|
|
31
|
-
def body_length(body)
|
|
32
|
-
if body
|
|
33
|
-
body.loc.expression.column + body.loc.expression.size
|
|
34
|
-
else
|
|
35
|
-
0
|
|
36
|
-
end
|
|
37
|
-
end
|
|
38
|
-
end
|
|
39
|
-
|
|
40
|
-
class IfUnlessModifier < Cop
|
|
41
|
-
include FavorModifier
|
|
42
|
-
|
|
43
|
-
def error_message
|
|
44
|
-
'Favor modifier if/unless usage when you have a single-line body. ' +
|
|
45
|
-
'Another good alternative is the usage of control flow &&/||.'
|
|
46
|
-
end
|
|
47
|
-
|
|
48
|
-
def on_if(node)
|
|
49
|
-
# discard ternary ops and modifier if/unless nodes
|
|
50
|
-
return unless node.loc.respond_to?(:keyword) &&
|
|
51
|
-
node.loc.respond_to?(:else)
|
|
52
|
-
|
|
53
|
-
add_offence(:convention, node.loc.line, error_message) if check(node)
|
|
54
|
-
|
|
55
|
-
super
|
|
56
|
-
end
|
|
57
|
-
end
|
|
58
|
-
|
|
59
|
-
class WhileUntilModifier < Cop
|
|
60
|
-
include FavorModifier
|
|
61
|
-
|
|
62
|
-
MSG =
|
|
63
|
-
'Favor modifier while/until usage when you have a single-line body.'
|
|
64
|
-
|
|
65
|
-
def inspect(source, tokens, ast, comments)
|
|
66
|
-
on_node([:while, :until], ast) do |node|
|
|
67
|
-
add_offence(:convention, node.loc.line, MSG) if check(node)
|
|
68
|
-
end
|
|
69
|
-
end
|
|
70
|
-
end
|
|
71
|
-
end
|
|
72
|
-
end
|
|
@@ -1,19 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class FavorPercentR < Cop
|
|
6
|
-
MSG = 'Use %r for regular expressions matching more ' +
|
|
7
|
-
"than one '/' character."
|
|
8
|
-
|
|
9
|
-
def on_regexp(node)
|
|
10
|
-
if node.loc.begin.source == '/' &&
|
|
11
|
-
node.loc.expression.source[1...-1].scan(/\//).size > 1
|
|
12
|
-
add_offence(:convention, node.loc.line, MSG)
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
super
|
|
16
|
-
end
|
|
17
|
-
end
|
|
18
|
-
end
|
|
19
|
-
end
|
|
@@ -1,21 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class FavorSprintf < Cop
|
|
6
|
-
MSG = 'Favor sprintf over String#%.'
|
|
7
|
-
|
|
8
|
-
def on_send(node)
|
|
9
|
-
receiver_node, method_name, *arg_nodes = *node
|
|
10
|
-
|
|
11
|
-
if method_name == :% &&
|
|
12
|
-
([:str, :dstr].include?(receiver_node.type) ||
|
|
13
|
-
arg_nodes[0].type == :array)
|
|
14
|
-
add_offence(:convention, node.loc.expression.line, MSG)
|
|
15
|
-
end
|
|
16
|
-
|
|
17
|
-
super
|
|
18
|
-
end
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
end
|
|
@@ -1,49 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
module FavorOtherKeywordOverNegation
|
|
6
|
-
def check(node)
|
|
7
|
-
condition, _body, _rest = *node
|
|
8
|
-
|
|
9
|
-
# Look at last expression of contents if there's a parenthesis
|
|
10
|
-
# around condition.
|
|
11
|
-
*_, condition = *condition while condition.type == :begin
|
|
12
|
-
|
|
13
|
-
if condition.type == :send
|
|
14
|
-
_object, method = *condition
|
|
15
|
-
if method == :! && !(node.loc.respond_to?(:else) && node.loc.else)
|
|
16
|
-
add_offence(:convention, node.loc.expression.line,
|
|
17
|
-
error_message)
|
|
18
|
-
end
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
end
|
|
22
|
-
|
|
23
|
-
class FavorUnlessOverNegatedIf < Cop
|
|
24
|
-
include FavorOtherKeywordOverNegation
|
|
25
|
-
|
|
26
|
-
def on_if(node)
|
|
27
|
-
check(node)
|
|
28
|
-
super
|
|
29
|
-
end
|
|
30
|
-
|
|
31
|
-
def error_message
|
|
32
|
-
'Favor unless (or control flow or) over if for negative conditions.'
|
|
33
|
-
end
|
|
34
|
-
end
|
|
35
|
-
|
|
36
|
-
class FavorUntilOverNegatedWhile < Cop
|
|
37
|
-
include FavorOtherKeywordOverNegation
|
|
38
|
-
|
|
39
|
-
def on_while(node)
|
|
40
|
-
check(node)
|
|
41
|
-
super
|
|
42
|
-
end
|
|
43
|
-
|
|
44
|
-
def error_message
|
|
45
|
-
'Favor until over while for negative conditions.'
|
|
46
|
-
end
|
|
47
|
-
end
|
|
48
|
-
end
|
|
49
|
-
end
|
|
@@ -1,17 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class HandleExceptions < Cop
|
|
6
|
-
MSG = 'Do not suppress exceptions.'
|
|
7
|
-
|
|
8
|
-
def on_resbody(node)
|
|
9
|
-
_exc_list_node, _exc_var_node, body_node = *node
|
|
10
|
-
|
|
11
|
-
add_offence(:warning, node.loc.line, MSG) if body_node.type == :nil
|
|
12
|
-
|
|
13
|
-
super
|
|
14
|
-
end
|
|
15
|
-
end
|
|
16
|
-
end
|
|
17
|
-
end
|
|
@@ -1,41 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class HashSyntax < Cop
|
|
6
|
-
MSG = 'Ruby 1.8 hash syntax detected'
|
|
7
|
-
|
|
8
|
-
def on_hash(node)
|
|
9
|
-
pairs = *node
|
|
10
|
-
|
|
11
|
-
sym_indices = pairs.all? { |p| word_symbol_pair?(p) }
|
|
12
|
-
|
|
13
|
-
if sym_indices
|
|
14
|
-
pairs.each do |pair|
|
|
15
|
-
if pair.loc.operator && pair.loc.operator.source == '=>'
|
|
16
|
-
add_offence(:convention,
|
|
17
|
-
pair.loc.line,
|
|
18
|
-
MSG)
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
end
|
|
22
|
-
|
|
23
|
-
super
|
|
24
|
-
end
|
|
25
|
-
|
|
26
|
-
private
|
|
27
|
-
|
|
28
|
-
def word_symbol_pair?(pair)
|
|
29
|
-
key, _value = *pair
|
|
30
|
-
|
|
31
|
-
if key.type == :sym
|
|
32
|
-
sym_name = key.to_a[0]
|
|
33
|
-
|
|
34
|
-
sym_name =~ /\A\w+\z/
|
|
35
|
-
else
|
|
36
|
-
false
|
|
37
|
-
end
|
|
38
|
-
end
|
|
39
|
-
end
|
|
40
|
-
end
|
|
41
|
-
end
|
|
@@ -1,65 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
module IfThenElse
|
|
6
|
-
def on_if(node)
|
|
7
|
-
check(node)
|
|
8
|
-
super
|
|
9
|
-
end
|
|
10
|
-
|
|
11
|
-
def on_unless(node)
|
|
12
|
-
check(node)
|
|
13
|
-
super
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
def check(node)
|
|
17
|
-
# We won't check modifier or ternary conditionals.
|
|
18
|
-
if node.loc.expression.source =~ /\A(if|unless)\b/
|
|
19
|
-
line = offending_line(node)
|
|
20
|
-
add_offence(:convention, line, error_message) if line
|
|
21
|
-
end
|
|
22
|
-
end
|
|
23
|
-
end
|
|
24
|
-
|
|
25
|
-
class IfWithSemicolon < Cop
|
|
26
|
-
include IfThenElse
|
|
27
|
-
|
|
28
|
-
def offending_line(node)
|
|
29
|
-
if node.loc.begin && node.loc.begin.source == ';'
|
|
30
|
-
node.loc.begin.line
|
|
31
|
-
end
|
|
32
|
-
end
|
|
33
|
-
|
|
34
|
-
def error_message
|
|
35
|
-
'Never use if x; Use the ternary operator instead.'
|
|
36
|
-
end
|
|
37
|
-
end
|
|
38
|
-
|
|
39
|
-
class MultilineIfThen < Cop
|
|
40
|
-
include IfThenElse
|
|
41
|
-
|
|
42
|
-
def offending_line(node)
|
|
43
|
-
if node.loc.expression.source =~ /\bthen\s*(#.*)?\s*$/
|
|
44
|
-
node.loc.begin.line
|
|
45
|
-
end
|
|
46
|
-
end
|
|
47
|
-
|
|
48
|
-
def error_message
|
|
49
|
-
'Never use then for multi-line if/unless.'
|
|
50
|
-
end
|
|
51
|
-
end
|
|
52
|
-
|
|
53
|
-
class OneLineConditional < Cop
|
|
54
|
-
include IfThenElse
|
|
55
|
-
|
|
56
|
-
def offending_line(node)
|
|
57
|
-
node.loc.expression.line unless node.loc.expression.source =~ /\n/
|
|
58
|
-
end
|
|
59
|
-
|
|
60
|
-
def error_message
|
|
61
|
-
'Favor the ternary operator (?:) over if/then/else/end constructs.'
|
|
62
|
-
end
|
|
63
|
-
end
|
|
64
|
-
end
|
|
65
|
-
end
|
|
@@ -1,17 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class LeadingCommentSpace < Cop
|
|
6
|
-
MSG = 'Missing space after #.'
|
|
7
|
-
|
|
8
|
-
def on_comment(c)
|
|
9
|
-
if c.text =~ /^#+[^#\s]/
|
|
10
|
-
unless c.text.start_with?('#!') && c.loc.line == 1
|
|
11
|
-
add_offence(:convention, c.loc.line, MSG)
|
|
12
|
-
end
|
|
13
|
-
end
|
|
14
|
-
end
|
|
15
|
-
end
|
|
16
|
-
end
|
|
17
|
-
end
|
|
@@ -1,15 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class LineContinuation < Cop
|
|
6
|
-
MSG = 'Avoid the use of the line continuation character(\).'
|
|
7
|
-
|
|
8
|
-
def inspect(source, tokens, ast, comments)
|
|
9
|
-
source.each_with_index do |line, index|
|
|
10
|
-
add_offence(:convention, index, MSG) if line =~ /.*\\\z/
|
|
11
|
-
end
|
|
12
|
-
end
|
|
13
|
-
end
|
|
14
|
-
end
|
|
15
|
-
end
|
|
@@ -1,23 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class LineLength < Cop
|
|
6
|
-
MSG = 'Line is too long. [%d/%d]'
|
|
7
|
-
|
|
8
|
-
def inspect(source, tokens, ast, comments)
|
|
9
|
-
source.each_with_index do |line, index|
|
|
10
|
-
max = LineLength.max
|
|
11
|
-
if line.length > max
|
|
12
|
-
message = sprintf(MSG, line.length, max)
|
|
13
|
-
add_offence(:convention, index + 1, message)
|
|
14
|
-
end
|
|
15
|
-
end
|
|
16
|
-
end
|
|
17
|
-
|
|
18
|
-
def self.max
|
|
19
|
-
LineLength.config['Max']
|
|
20
|
-
end
|
|
21
|
-
end
|
|
22
|
-
end
|
|
23
|
-
end
|
data/lib/rubocop/cop/loop.rb
DELETED
|
@@ -1,33 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class Loop < Cop
|
|
6
|
-
MSG = 'Use Kernel#loop with break rather than begin/end/until(or while).'
|
|
7
|
-
|
|
8
|
-
def on_while(node)
|
|
9
|
-
check(node)
|
|
10
|
-
|
|
11
|
-
super
|
|
12
|
-
end
|
|
13
|
-
|
|
14
|
-
def on_until(node)
|
|
15
|
-
check(node)
|
|
16
|
-
|
|
17
|
-
super
|
|
18
|
-
end
|
|
19
|
-
|
|
20
|
-
private
|
|
21
|
-
|
|
22
|
-
def check(node)
|
|
23
|
-
_cond, body = *node
|
|
24
|
-
type = node.type.to_s
|
|
25
|
-
|
|
26
|
-
if body.type == :begin &&
|
|
27
|
-
!node.loc.expression.source.start_with?(type)
|
|
28
|
-
add_offence(:warning, node.loc.keyword.line, MSG)
|
|
29
|
-
end
|
|
30
|
-
end
|
|
31
|
-
end
|
|
32
|
-
end
|
|
33
|
-
end
|
|
@@ -1,55 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class MethodAndVariableSnakeCase < Cop
|
|
6
|
-
MSG = 'Use snake_case for methods and variables.'
|
|
7
|
-
SNAKE_CASE = /^@?[\da-z_]+[!?=]?$/
|
|
8
|
-
|
|
9
|
-
# http://phrogz.net/programmingruby/language.html#table_18.4
|
|
10
|
-
OPERATOR_METHODS = %w(
|
|
11
|
-
| ^ & <=> == === =~ > >= < <= << >>
|
|
12
|
-
+ - * / % ** ~ +@ -@ [] []= ` ! != !~
|
|
13
|
-
).map(&:to_sym)
|
|
14
|
-
|
|
15
|
-
def inspect(source, tokens, node, comments)
|
|
16
|
-
on_node([:def, :defs, :lvasgn, :ivasgn, :send], node) do |n|
|
|
17
|
-
name = case n.type
|
|
18
|
-
when :def
|
|
19
|
-
name_of_instance_method(n)
|
|
20
|
-
when :defs
|
|
21
|
-
name_of_singleton_method(n)
|
|
22
|
-
when :lvasgn, :ivasgn
|
|
23
|
-
name_of_variable(n)
|
|
24
|
-
when :send
|
|
25
|
-
name_of_setter(n)
|
|
26
|
-
end
|
|
27
|
-
|
|
28
|
-
next unless name
|
|
29
|
-
next if name =~ SNAKE_CASE || OPERATOR_METHODS.include?(name)
|
|
30
|
-
|
|
31
|
-
add_offence(:convention, n.location.line, MSG)
|
|
32
|
-
end
|
|
33
|
-
end
|
|
34
|
-
|
|
35
|
-
def name_of_instance_method(def_node)
|
|
36
|
-
def_node.children.first
|
|
37
|
-
end
|
|
38
|
-
|
|
39
|
-
def name_of_singleton_method(defs_node)
|
|
40
|
-
defs_node.children[1]
|
|
41
|
-
end
|
|
42
|
-
|
|
43
|
-
def name_of_variable(vasgn_node)
|
|
44
|
-
vasgn_node.children.first
|
|
45
|
-
end
|
|
46
|
-
|
|
47
|
-
def name_of_setter(send_node)
|
|
48
|
-
receiver, method_name = *send_node
|
|
49
|
-
return nil unless receiver && receiver.type == :self
|
|
50
|
-
return nil unless method_name.to_s.end_with?('=')
|
|
51
|
-
method_name
|
|
52
|
-
end
|
|
53
|
-
end
|
|
54
|
-
end
|
|
55
|
-
end
|
|
@@ -1,52 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class MethodLength < Cop
|
|
6
|
-
MSG = 'Method has too many lines. [%d/%d]'
|
|
7
|
-
|
|
8
|
-
def on_def(node)
|
|
9
|
-
check(node)
|
|
10
|
-
|
|
11
|
-
super
|
|
12
|
-
end
|
|
13
|
-
|
|
14
|
-
def on_defs(node)
|
|
15
|
-
check(node)
|
|
16
|
-
|
|
17
|
-
super
|
|
18
|
-
end
|
|
19
|
-
|
|
20
|
-
def max_length
|
|
21
|
-
MethodLength.config['Max']
|
|
22
|
-
end
|
|
23
|
-
|
|
24
|
-
def count_comments?
|
|
25
|
-
MethodLength.config['CountComments']
|
|
26
|
-
end
|
|
27
|
-
|
|
28
|
-
private
|
|
29
|
-
|
|
30
|
-
def check(node)
|
|
31
|
-
method_length = calculate_length(node.loc.expression.source)
|
|
32
|
-
|
|
33
|
-
if method_length > max_length
|
|
34
|
-
message = sprintf(MSG, method_length, max_length)
|
|
35
|
-
add_offence(:convention, node.loc.keyword.line, message)
|
|
36
|
-
end
|
|
37
|
-
end
|
|
38
|
-
|
|
39
|
-
def calculate_length(source)
|
|
40
|
-
lines = source.lines.to_a[1...-1]
|
|
41
|
-
|
|
42
|
-
return 0 unless lines
|
|
43
|
-
|
|
44
|
-
lines.map!(&:strip).reject!(&:empty?)
|
|
45
|
-
|
|
46
|
-
lines.reject! { |line| line =~ /^\s*#/ } unless count_comments?
|
|
47
|
-
|
|
48
|
-
lines.size
|
|
49
|
-
end
|
|
50
|
-
end
|
|
51
|
-
end
|
|
52
|
-
end
|
|
@@ -1,19 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class NewLambdaLiteral < Cop
|
|
6
|
-
MSG = 'Use the new lambda literal syntax ->(params) {...}.'
|
|
7
|
-
|
|
8
|
-
TARGET = s(:send, nil, :lambda)
|
|
9
|
-
|
|
10
|
-
def on_send(node)
|
|
11
|
-
if node == TARGET && node.loc.selector.source != '->'
|
|
12
|
-
add_offence(:convention, node.loc.line, MSG)
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
super
|
|
16
|
-
end
|
|
17
|
-
end
|
|
18
|
-
end
|
|
19
|
-
end
|
data/lib/rubocop/cop/not.rb
DELETED
|
@@ -1,21 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class Not < Cop
|
|
6
|
-
MSG = 'Use ! instead of not.'
|
|
7
|
-
|
|
8
|
-
def on_send(node)
|
|
9
|
-
_receiver, method_name, *args = *node
|
|
10
|
-
|
|
11
|
-
# not does not take any arguments
|
|
12
|
-
if args.empty? && method_name == :! &&
|
|
13
|
-
node.loc.selector.source == 'not'
|
|
14
|
-
add_offence(:convention, node.loc.line, MSG)
|
|
15
|
-
end
|
|
16
|
-
|
|
17
|
-
super
|
|
18
|
-
end
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
end
|
|
@@ -1,21 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class NumericLiterals < Cop
|
|
6
|
-
MSG = 'Add underscores to large numeric literals to ' +
|
|
7
|
-
'improve their readability.'
|
|
8
|
-
|
|
9
|
-
def on_int(node)
|
|
10
|
-
value, = *node
|
|
11
|
-
|
|
12
|
-
if value > 10000 &&
|
|
13
|
-
node.loc.expression.source.split('.').grep(/\d{6}/).any?
|
|
14
|
-
add_offence(:convention, node.loc.expression.line, MSG)
|
|
15
|
-
end
|
|
16
|
-
end
|
|
17
|
-
|
|
18
|
-
alias_method :on_float, :on_int
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
end
|
|
@@ -1,23 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
class ParameterLists < Cop
|
|
6
|
-
MSG = 'Avoid parameter lists longer than %d parameters.'
|
|
7
|
-
|
|
8
|
-
def on_args(node)
|
|
9
|
-
args_count = node.children.size
|
|
10
|
-
|
|
11
|
-
if args_count > max_params
|
|
12
|
-
add_offence(:convention, node.loc.line, sprintf(MSG, max_params))
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
super
|
|
16
|
-
end
|
|
17
|
-
|
|
18
|
-
def max_params
|
|
19
|
-
ParameterLists.config['Max']
|
|
20
|
-
end
|
|
21
|
-
end
|
|
22
|
-
end
|
|
23
|
-
end
|