rubocop 0.8.0 → 0.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (377) hide show
  1. checksums.yaml +4 -4
  2. data/.travis.yml +0 -4
  3. data/.yardopts +2 -0
  4. data/CHANGELOG.md +95 -1
  5. data/README.md +101 -11
  6. data/config/default.yml +14 -2
  7. data/config/enabled.yml +96 -14
  8. data/lib/rubocop/cli.rb +178 -94
  9. data/lib/rubocop/config.rb +56 -11
  10. data/lib/rubocop/config_store.rb +2 -0
  11. data/lib/rubocop/cop/cop.rb +54 -11
  12. data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
  13. data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
  14. data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
  15. data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
  16. data/lib/rubocop/cop/lint/eval.rb +22 -0
  17. data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
  18. data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
  19. data/lib/rubocop/cop/lint/loop.rb +29 -0
  20. data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
  21. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
  22. data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
  23. data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
  24. data/lib/rubocop/cop/lint/void.rb +58 -0
  25. data/lib/rubocop/cop/offence.rb +112 -12
  26. data/lib/rubocop/cop/rails/validation.rb +34 -0
  27. data/lib/rubocop/cop/style/access_control.rb +58 -0
  28. data/lib/rubocop/cop/style/alias.rb +28 -0
  29. data/lib/rubocop/cop/style/align_parameters.rb +39 -0
  30. data/lib/rubocop/cop/style/and_or.rb +45 -0
  31. data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
  32. data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
  33. data/lib/rubocop/cop/style/attr.rb +20 -0
  34. data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
  35. data/lib/rubocop/cop/style/avoid_for.rb +18 -0
  36. data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
  37. data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
  38. data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
  39. data/lib/rubocop/cop/style/begin_block.rb +18 -0
  40. data/lib/rubocop/cop/style/block_comments.rb +20 -0
  41. data/lib/rubocop/cop/style/block_nesting.rb +47 -0
  42. data/lib/rubocop/cop/style/blocks.rb +27 -0
  43. data/lib/rubocop/cop/style/case_equality.rb +22 -0
  44. data/lib/rubocop/cop/style/case_indentation.rb +28 -0
  45. data/lib/rubocop/cop/style/character_literal.rb +37 -0
  46. data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
  47. data/lib/rubocop/cop/style/class_methods.rb +22 -0
  48. data/lib/rubocop/cop/style/collection_methods.rb +37 -0
  49. data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
  50. data/lib/rubocop/cop/style/constant_name.rb +31 -0
  51. data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
  52. data/lib/rubocop/cop/style/documentation.rb +58 -0
  53. data/lib/rubocop/cop/style/dot_position.rb +25 -0
  54. data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
  55. data/lib/rubocop/cop/style/empty_lines.rb +40 -0
  56. data/lib/rubocop/cop/style/empty_literal.rb +53 -0
  57. data/lib/rubocop/cop/style/encoding.rb +29 -0
  58. data/lib/rubocop/cop/style/end_block.rb +18 -0
  59. data/lib/rubocop/cop/style/end_of_line.rb +23 -0
  60. data/lib/rubocop/cop/style/favor_join.rb +29 -0
  61. data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
  62. data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
  63. data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
  64. data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
  65. data/lib/rubocop/cop/style/if_then_else.rb +80 -0
  66. data/lib/rubocop/cop/style/lambda.rb +47 -0
  67. data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
  68. data/lib/rubocop/cop/style/line_continuation.rb +26 -0
  69. data/lib/rubocop/cop/style/line_length.rb +30 -0
  70. data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
  71. data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
  72. data/lib/rubocop/cop/style/method_length.rb +57 -0
  73. data/lib/rubocop/cop/style/not.rb +24 -0
  74. data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
  75. data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
  76. data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
  77. data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
  78. data/lib/rubocop/cop/style/proc.rb +30 -0
  79. data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
  80. data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
  81. data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
  82. data/lib/rubocop/cop/style/semicolon.rb +51 -0
  83. data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
  84. data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
  85. data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
  86. data/lib/rubocop/cop/style/string_literals.rb +36 -0
  87. data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
  88. data/lib/rubocop/cop/style/symbol_array.rb +31 -0
  89. data/lib/rubocop/cop/style/symbol_name.rb +27 -0
  90. data/lib/rubocop/cop/style/tab.rb +25 -0
  91. data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
  92. data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
  93. data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
  94. data/lib/rubocop/cop/style/unless_else.rb +26 -0
  95. data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
  96. data/lib/rubocop/cop/style/when_then.rb +25 -0
  97. data/lib/rubocop/cop/style/while_until_do.rb +45 -0
  98. data/lib/rubocop/cop/style/word_array.rb +44 -0
  99. data/lib/rubocop/cop/util.rb +1 -0
  100. data/lib/rubocop/cop/variable_inspector.rb +280 -0
  101. data/lib/rubocop/formatter/base_formatter.rb +119 -0
  102. data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
  103. data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
  104. data/lib/rubocop/formatter/formatter_set.rb +77 -0
  105. data/lib/rubocop/formatter/json_formatter.rb +76 -0
  106. data/lib/rubocop/formatter/progress_formatter.rb +63 -0
  107. data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
  108. data/lib/rubocop/version.rb +15 -1
  109. data/lib/rubocop.rb +97 -71
  110. data/rubocop.gemspec +1 -2
  111. data/spec/.rubocop.yml +5 -0
  112. data/spec/project_spec.rb +4 -7
  113. data/spec/rubocop/cli_spec.rb +402 -143
  114. data/spec/rubocop/config_spec.rb +61 -0
  115. data/spec/rubocop/config_store_spec.rb +2 -2
  116. data/spec/rubocop/cops/cop_spec.rb +14 -7
  117. data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
  118. data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
  119. data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
  120. data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
  121. data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
  122. data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
  123. data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
  124. data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
  125. data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
  126. data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
  127. data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
  128. data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
  129. data/spec/rubocop/cops/lint/void_spec.rb +63 -0
  130. data/spec/rubocop/cops/offence_spec.rb +107 -10
  131. data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
  132. data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
  133. data/spec/rubocop/cops/style/alias_spec.rb +47 -0
  134. data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
  135. data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
  136. data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
  137. data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
  138. data/spec/rubocop/cops/style/attr_spec.rb +20 -0
  139. data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
  140. data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
  141. data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
  142. data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
  143. data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
  144. data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
  145. data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
  146. data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
  147. data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
  148. data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
  149. data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
  150. data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
  151. data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
  152. data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
  153. data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
  154. data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
  155. data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
  156. data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
  157. data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
  158. data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
  159. data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
  160. data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
  161. data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
  162. data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
  163. data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
  164. data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
  165. data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
  166. data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
  167. data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
  168. data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
  169. data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
  170. data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
  171. data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
  172. data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
  173. data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
  174. data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
  175. data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
  176. data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
  177. data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
  178. data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
  179. data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
  180. data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
  181. data/spec/rubocop/cops/style/not_spec.rb +28 -0
  182. data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
  183. data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
  184. data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
  185. data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
  186. data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
  187. data/spec/rubocop/cops/style/proc_spec.rb +28 -0
  188. data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
  189. data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
  190. data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
  191. data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
  192. data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
  193. data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
  194. data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
  195. data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
  196. data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
  197. data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
  198. data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
  199. data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
  200. data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
  201. data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
  202. data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
  203. data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
  204. data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
  205. data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
  206. data/spec/rubocop/cops/style/tab_spec.rb +23 -0
  207. data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
  208. data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
  209. data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
  210. data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
  211. data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
  212. data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
  213. data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
  214. data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
  215. data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
  216. data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
  217. data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
  218. data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
  219. data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
  220. data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
  221. data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
  222. data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
  223. data/spec/spec_helper.rb +24 -9
  224. data/spec/support/mri_syntax_checker.rb +69 -0
  225. data/spec/support/shared_examples.rb +33 -0
  226. metadata +317 -239
  227. data/lib/rubocop/cop/access_control.rb +0 -41
  228. data/lib/rubocop/cop/alias.rb +0 -17
  229. data/lib/rubocop/cop/align_parameters.rb +0 -37
  230. data/lib/rubocop/cop/and_or.rb +0 -26
  231. data/lib/rubocop/cop/ascii_comments.rb +0 -13
  232. data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
  233. data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
  234. data/lib/rubocop/cop/avoid_for.rb +0 -17
  235. data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
  236. data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
  237. data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
  238. data/lib/rubocop/cop/block_comments.rb +0 -15
  239. data/lib/rubocop/cop/blocks.rb +0 -23
  240. data/lib/rubocop/cop/case_indentation.rb +0 -22
  241. data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
  242. data/lib/rubocop/cop/class_methods.rb +0 -15
  243. data/lib/rubocop/cop/collection_methods.rb +0 -29
  244. data/lib/rubocop/cop/colon_method_call.rb +0 -20
  245. data/lib/rubocop/cop/constant_name.rb +0 -24
  246. data/lib/rubocop/cop/def_parentheses.rb +0 -62
  247. data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
  248. data/lib/rubocop/cop/empty_lines.rb +0 -34
  249. data/lib/rubocop/cop/empty_literal.rb +0 -47
  250. data/lib/rubocop/cop/encoding.rb +0 -19
  251. data/lib/rubocop/cop/end_of_line.rb +0 -15
  252. data/lib/rubocop/cop/ensure_return.rb +0 -19
  253. data/lib/rubocop/cop/eval.rb +0 -19
  254. data/lib/rubocop/cop/favor_join.rb +0 -22
  255. data/lib/rubocop/cop/favor_modifier.rb +0 -72
  256. data/lib/rubocop/cop/favor_percent_r.rb +0 -19
  257. data/lib/rubocop/cop/favor_sprintf.rb +0 -21
  258. data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
  259. data/lib/rubocop/cop/handle_exceptions.rb +0 -17
  260. data/lib/rubocop/cop/hash_syntax.rb +0 -41
  261. data/lib/rubocop/cop/if_then_else.rb +0 -65
  262. data/lib/rubocop/cop/leading_comment_space.rb +0 -17
  263. data/lib/rubocop/cop/line_continuation.rb +0 -15
  264. data/lib/rubocop/cop/line_length.rb +0 -23
  265. data/lib/rubocop/cop/loop.rb +0 -33
  266. data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
  267. data/lib/rubocop/cop/method_length.rb +0 -52
  268. data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
  269. data/lib/rubocop/cop/not.rb +0 -21
  270. data/lib/rubocop/cop/numeric_literals.rb +0 -21
  271. data/lib/rubocop/cop/parameter_lists.rb +0 -23
  272. data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
  273. data/lib/rubocop/cop/percent_r.rb +0 -19
  274. data/lib/rubocop/cop/reduce_arguments.rb +0 -29
  275. data/lib/rubocop/cop/rescue_exception.rb +0 -26
  276. data/lib/rubocop/cop/rescue_modifier.rb +0 -17
  277. data/lib/rubocop/cop/semicolon.rb +0 -31
  278. data/lib/rubocop/cop/single_line_methods.rb +0 -44
  279. data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
  280. data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
  281. data/lib/rubocop/cop/string_literals.rb +0 -22
  282. data/lib/rubocop/cop/surrounding_space.rb +0 -283
  283. data/lib/rubocop/cop/symbol_array.rb +0 -31
  284. data/lib/rubocop/cop/symbol_name.rb +0 -23
  285. data/lib/rubocop/cop/syntax.rb +0 -49
  286. data/lib/rubocop/cop/tab.rb +0 -15
  287. data/lib/rubocop/cop/ternary_operator.rb +0 -43
  288. data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
  289. data/lib/rubocop/cop/trivial_accessors.rb +0 -26
  290. data/lib/rubocop/cop/unless_else.rb +0 -23
  291. data/lib/rubocop/cop/variable_interpolation.rb +0 -29
  292. data/lib/rubocop/cop/when_then.rb +0 -17
  293. data/lib/rubocop/cop/word_array.rb +0 -37
  294. data/lib/rubocop/report/emacs_style.rb +0 -17
  295. data/lib/rubocop/report/plain_text.rb +0 -18
  296. data/lib/rubocop/report/report.rb +0 -44
  297. data/spec/rubocop/cops/access_control_spec.rb +0 -129
  298. data/spec/rubocop/cops/alias_spec.rb +0 -39
  299. data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
  300. data/spec/rubocop/cops/and_or_spec.rb +0 -37
  301. data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
  302. data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
  303. data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
  304. data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
  305. data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
  306. data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
  307. data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
  308. data/spec/rubocop/cops/block_comments_spec.rb +0 -25
  309. data/spec/rubocop/cops/blocks_spec.rb +0 -33
  310. data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
  311. data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
  312. data/spec/rubocop/cops/class_methods_spec.rb +0 -49
  313. data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
  314. data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
  315. data/spec/rubocop/cops/constant_name_spec.rb +0 -42
  316. data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
  317. data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
  318. data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
  319. data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
  320. data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
  321. data/spec/rubocop/cops/encoding_spec.rb +0 -47
  322. data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
  323. data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
  324. data/spec/rubocop/cops/eval_spec.rb +0 -39
  325. data/spec/rubocop/cops/favor_join_spec.rb +0 -35
  326. data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
  327. data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
  328. data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
  329. data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
  330. data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
  331. data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
  332. data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
  333. data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
  334. data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
  335. data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
  336. data/spec/rubocop/cops/line_length_spec.rb +0 -23
  337. data/spec/rubocop/cops/loop_spec.rb +0 -31
  338. data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
  339. data/spec/rubocop/cops/method_length_spec.rb +0 -147
  340. data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
  341. data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
  342. data/spec/rubocop/cops/not_spec.rb +0 -31
  343. data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
  344. data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
  345. data/spec/rubocop/cops/op_method_spec.rb +0 -78
  346. data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
  347. data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
  348. data/spec/rubocop/cops/percent_r_spec.rb +0 -29
  349. data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
  350. data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
  351. data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
  352. data/spec/rubocop/cops/semicolon_spec.rb +0 -88
  353. data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
  354. data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
  355. data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
  356. data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
  357. data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
  358. data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
  359. data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
  360. data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
  361. data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
  362. data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
  363. data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
  364. data/spec/rubocop/cops/string_literals_spec.rb +0 -47
  365. data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
  366. data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
  367. data/spec/rubocop/cops/syntax_spec.rb +0 -41
  368. data/spec/rubocop/cops/tab_spec.rb +0 -21
  369. data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
  370. data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
  371. data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
  372. data/spec/rubocop/cops/unless_else_spec.rb +0 -29
  373. data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
  374. data/spec/rubocop/cops/when_then_spec.rb +0 -38
  375. data/spec/rubocop/cops/word_array_spec.rb +0 -47
  376. data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
  377. data/spec/rubocop/reports/report_spec.rb +0 -29
@@ -1,147 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe MethodLength do
8
- let(:method_length) { MethodLength.new }
9
- before { MethodLength.config = { 'Max' => 5, 'CountComments' => false } }
10
-
11
- it 'rejects a method with more than 5 lines' do
12
- inspect_source(method_length, ['def m()',
13
- ' a = 1',
14
- ' a = 2',
15
- ' a = 3',
16
- ' a = 4',
17
- ' a = 5',
18
- ' a = 6',
19
- 'end'])
20
- expect(method_length.offences.size).to eq(1)
21
- expect(method_length.offences.map(&:line_number).sort).to eq([1])
22
- end
23
-
24
- it 'accepts a method with less than 5 lines' do
25
- inspect_source(method_length, ['def m()',
26
- ' a = 1',
27
- ' a = 2',
28
- ' a = 3',
29
- ' a = 4',
30
- 'end'])
31
- expect(method_length.offences).to be_empty
32
- end
33
-
34
- it 'does not count blank lines' do
35
- inspect_source(method_length, ['def m()',
36
- ' a = 1',
37
- ' a = 2',
38
- ' a = 3',
39
- ' a = 4',
40
- '',
41
- '',
42
- ' a = 7',
43
- 'end'])
44
- expect(method_length.offences).to be_empty
45
- end
46
-
47
- it 'accepts empty methods' do
48
- inspect_source(method_length, ['def m()',
49
- 'end'])
50
- expect(method_length.offences).to be_empty
51
- end
52
-
53
- it 'is not fooled by one-liner methods, syntax #1' do
54
- inspect_source(method_length, ['def one_line; 10 end',
55
- 'def self.m()',
56
- ' a = 1',
57
- ' a = 2',
58
- ' a = 4',
59
- ' a = 5',
60
- ' a = 6',
61
- 'end'])
62
- expect(method_length.offences).to be_empty
63
- end
64
-
65
- it 'is not fooled by one-liner methods, syntax #2' do
66
- inspect_source(method_length, ['def one_line(test) 10 end',
67
- 'def self.m()',
68
- ' a = 1',
69
- ' a = 2',
70
- ' a = 4',
71
- ' a = 5',
72
- ' a = 6',
73
- 'end'])
74
- expect(method_length.offences).to be_empty
75
- end
76
-
77
- it 'checks class methods, syntax #1' do
78
- inspect_source(method_length, ['def self.m()',
79
- ' a = 1',
80
- ' a = 2',
81
- ' a = 3',
82
- ' a = 4',
83
- ' a = 5',
84
- ' a = 6',
85
- 'end'])
86
- expect(method_length.offences.size).to eq(1)
87
- expect(method_length.offences.map(&:line_number).sort).to eq([1])
88
- end
89
-
90
- it 'checks class methods, syntax #2' do
91
- inspect_source(method_length, ['class K',
92
- ' class << self',
93
- ' def m()',
94
- ' a = 1',
95
- ' a = 2',
96
- ' a = 3',
97
- ' a = 4',
98
- ' a = 5',
99
- ' a = 6',
100
- ' end',
101
- ' end',
102
- 'end'])
103
- expect(method_length.offences.size).to eq(1)
104
- expect(method_length.offences.map(&:line_number).sort).to eq([3])
105
- end
106
-
107
- it 'properly counts lines when method ends with block' do
108
- inspect_source(method_length, ['def m()',
109
- ' something do',
110
- ' a = 2',
111
- ' a = 3',
112
- ' a = 4',
113
- ' a = 5',
114
- ' end',
115
- 'end'])
116
- expect(method_length.offences.size).to eq(1)
117
- expect(method_length.offences.map(&:line_number).sort).to eq([1])
118
- end
119
-
120
- it 'does not count commented lines by default' do
121
- inspect_source(method_length, ['def m()',
122
- ' a = 1',
123
- ' #a = 2',
124
- ' a = 3',
125
- ' #a = 4',
126
- ' a = 5',
127
- ' a = 6',
128
- 'end'])
129
- expect(method_length.offences).to be_empty
130
- end
131
-
132
- it 'has the option of counting commented lines' do
133
- MethodLength.config['CountComments'] = true
134
- inspect_source(method_length, ['def m()',
135
- ' a = 1',
136
- ' #a = 2',
137
- ' a = 3',
138
- ' #a = 4',
139
- ' a = 5',
140
- ' a = 6',
141
- 'end'])
142
- expect(method_length.offences.size).to eq(1)
143
- expect(method_length.offences.map(&:line_number).sort).to eq([1])
144
- end
145
- end
146
- end
147
- end
@@ -1,56 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe MultilineIfThen do
8
- let(:mit) { MultilineIfThen.new }
9
-
10
- # if
11
-
12
- it 'registers an offence for then in multiline if' do
13
- inspect_source(mit, ['if cond then',
14
- 'end',
15
- "if cond then\t",
16
- 'end',
17
- 'if cond then ',
18
- 'end',
19
- 'if cond then # bad',
20
- 'end'])
21
- expect(mit.offences.map(&:line_number)).to eq([1, 3, 5, 7])
22
- end
23
-
24
- it 'accepts multiline if without then' do
25
- inspect_source(mit, ['if cond',
26
- 'end'])
27
- expect(mit.offences.map(&:message)).to be_empty
28
- end
29
-
30
- it 'accepts table style if/then/elsif/ends' do
31
- inspect_source(mit,
32
- ['if @io == $stdout then str << "$stdout"',
33
- 'elsif @io == $stdin then str << "$stdin"',
34
- 'elsif @io == $stderr then str << "$stderr"',
35
- 'else str << @io.class.to_s',
36
- 'end'])
37
- expect(mit.offences.map(&:message)).to be_empty
38
- end
39
-
40
- # unless
41
-
42
- it 'registers an offence for then in multiline unless' do
43
- inspect_source(mit, ['unless cond then',
44
- 'end'])
45
- expect(mit.offences.map(&:message)).to eq(
46
- ['Never use then for multi-line if/unless.'])
47
- end
48
-
49
- it 'accepts multiline unless without then' do
50
- inspect_source(mit, ['unless cond',
51
- 'end'])
52
- expect(mit.offences.map(&:message)).to be_empty
53
- end
54
- end
55
- end
56
- end
@@ -1,22 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe NewLambdaLiteral do
8
- let(:lambda_literal) { NewLambdaLiteral.new }
9
-
10
- it 'registers an offence for an old lambda call' do
11
- inspect_source(lambda_literal, ['f = lambda { |x| x }'])
12
- expect(lambda_literal.offences.size).to eq(1)
13
- end
14
-
15
- it 'accepts the new lambda literal' do
16
- inspect_source(lambda_literal, ['lambda = ->(x) { x }',
17
- 'lambda.(1)'])
18
- expect(lambda_literal.offences).to be_empty
19
- end
20
- end
21
- end
22
- end
@@ -1,31 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe Not do
8
- let(:a) { Not.new }
9
-
10
- it 'registers an offence for not' do
11
- inspect_source(a,
12
- ['not test'])
13
- expect(a.offences.size).to eq(1)
14
- expect(a.offences.map(&:message))
15
- .to eq([Not::MSG])
16
- end
17
-
18
- it 'does not register an offence for !' do
19
- inspect_source(a,
20
- ['!test'])
21
- expect(a.offences).to be_empty
22
- end
23
-
24
- it 'does not register an offence for :not' do
25
- inspect_source(a,
26
- ['[:not, :if, :else]'])
27
- expect(a.offences).to be_empty
28
- end
29
- end
30
- end
31
- end
@@ -1,49 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe NumericLiterals do
8
- let(:num) { NumericLiterals.new }
9
-
10
- it 'registers an offence for a long integer without underscores' do
11
- inspect_source(num, ['a = 123456'])
12
- expect(num.offences.map(&:message)).to eq(
13
- ['Add underscores to large numeric literals to improve their ' +
14
- 'readability.'])
15
- end
16
-
17
- it 'registers an offence for an integer with not enough underscores' do
18
- inspect_source(num, ['a = 123456_789000'])
19
- expect(num.offences.map(&:message)).to eq(
20
- ['Add underscores to large numeric literals to improve their ' +
21
- 'readability.'])
22
- end
23
-
24
- # it 'registers an offence for a long float without underscores' do
25
- # inspect_source(num, ['a = 1.234567'])
26
- # expect(num.offences.map(&:message)).to eq(
27
- # ['Add underscores to large numeric literals to improve their ' +
28
- # 'readability.'])
29
- # end
30
-
31
- it 'accepts long numbers with underscore' do
32
- inspect_source(num, ['a = 123_456',
33
- 'b = 1.234_56'])
34
- expect(num.offences.map(&:message)).to be_empty
35
- end
36
-
37
- it 'accepts a short integer without underscore' do
38
- inspect_source(num, ['a = 123'])
39
- expect(num.offences.map(&:message)).to be_empty
40
- end
41
-
42
- it 'accepts short numbers without underscore' do
43
- inspect_source(num, ['a = 123',
44
- 'b = 123.456'])
45
- expect(num.offences.map(&:message)).to be_empty
46
- end
47
- end
48
- end
49
- end
@@ -1,16 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe OneLineConditional do
8
- let(:olc) { OneLineConditional.new }
9
-
10
- it 'registers an offence for one line if/then/end' do
11
- inspect_source(olc, ['if cond then run else dont end'])
12
- expect(olc.offences.map(&:message)).to eq([olc.error_message])
13
- end
14
- end
15
- end
16
- end
@@ -1,78 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe OpMethod do
8
- let(:om) { OpMethod.new }
9
-
10
- it 'registers an offence for arg not named other' do
11
- inspect_source(om,
12
- ['def +(another)',
13
- ' another',
14
- 'end'])
15
- expect(om.offences.size).to eq(1)
16
- expect(om.offences.map(&:message))
17
- .to eq([sprintf(OpMethod::MSG, '+')])
18
- end
19
-
20
- it 'works properly even if the argument is not surrounded with braces' do
21
- inspect_source(om,
22
- ['def + another',
23
- ' another',
24
- 'end'])
25
- expect(om.offences.size).to eq(1)
26
- expect(om.offences.map(&:message))
27
- .to eq([sprintf(OpMethod::MSG, '+')])
28
- end
29
-
30
- it 'does not register an offence for arg named other' do
31
- inspect_source(om,
32
- ['def +(other)',
33
- ' other',
34
- 'end'])
35
- expect(om.offences).to be_empty
36
- end
37
-
38
- it 'does not register an offence for []' do
39
- inspect_source(om,
40
- ['def [](index)',
41
- ' other',
42
- 'end'])
43
- expect(om.offences).to be_empty
44
- end
45
-
46
- it 'does not register an offence for []=' do
47
- inspect_source(om,
48
- ['def []=(index, value)',
49
- ' other',
50
- 'end'])
51
- expect(om.offences).to be_empty
52
- end
53
-
54
- it 'does not register an offence for <<' do
55
- inspect_source(om,
56
- ['def <<(cop)',
57
- ' other',
58
- 'end'])
59
- expect(om.offences).to be_empty
60
- end
61
-
62
- it 'does not register an offence for non binary operators' do
63
- inspect_source(om,
64
- ['def -@', # Unary minus
65
- 'end',
66
- '',
67
- # This + is not a unary operator. It can only be
68
- # called with dot notation.
69
- 'def +',
70
- 'end',
71
- '',
72
- 'def *(a, b)', # Quite strange, but legal ruby.
73
- 'end'])
74
- expect(om.offences).to be_empty
75
- end
76
- end
77
- end
78
- end
@@ -1,24 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe ParameterLists do
8
- let(:list) { ParameterLists.new }
9
-
10
- it 'registers an offence for a method def with 5 parameters' do
11
- inspect_source(list, ['def meth(a, b, c, d, e)',
12
- 'end'])
13
- expect(list.messages).to eq(
14
- ['Avoid parameter lists longer than 4 parameters.'])
15
- end
16
-
17
- it 'accepts a method def with 4 parameters' do
18
- inspect_source(list, ['def meth(a, b, c, d)',
19
- 'end'])
20
- expect(list.offences).to be_empty
21
- end
22
- end
23
- end
24
- end
@@ -1,61 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe ParenthesesAroundCondition do
8
- let(:pac) { ParenthesesAroundCondition.new }
9
-
10
- it 'registers an offence for parentheses around condition' do
11
- inspect_source(pac, ['if (x > 10)',
12
- 'elsif (x < 3)',
13
- 'end',
14
- 'unless (x > 10)',
15
- 'end',
16
- 'while (x > 10)',
17
- 'end',
18
- 'until (x > 10)',
19
- 'end',
20
- 'x += 1 if (x < 10)',
21
- 'x += 1 unless (x < 10)',
22
- 'x += 1 while (x < 10)',
23
- 'x += 1 until (x < 10)',
24
- ])
25
- expect(pac.offences.size).to eq(9)
26
- end
27
-
28
- it 'accepts condition without parentheses' do
29
- inspect_source(pac, ['if x > 10',
30
- 'end',
31
- 'unless x > 10',
32
- 'end',
33
- 'while x > 10',
34
- 'end',
35
- 'until x > 10',
36
- 'end',
37
- 'x += 1 if x < 10',
38
- 'x += 1 unless x < 10',
39
- 'x += 1 while x < 10',
40
- 'x += 1 until x < 10',
41
- ])
42
- expect(pac.offences).to be_empty
43
- end
44
-
45
- it 'is not confused by leading brace in subexpression' do
46
- inspect_source(pac, ['(a > b) && other ? one : two'])
47
- expect(pac.offences).to be_empty
48
- end
49
-
50
- # Parentheses are sometimes used to help the editor make nice
51
- # indentation of conditions spanning several lines.
52
- # it 'accepts parentheses around multiline conditions' do
53
- # inspect_source(pac, ['if (@lex_state != EXPR_BEG &&',
54
- # ' @lex_state != EXPR_FNAME &&',
55
- # ' trans[1])',
56
- # 'end'])
57
- # expect(pac.offences.map(&:message)).to be_empty
58
- # end
59
- end
60
- end
61
- end
@@ -1,29 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe PercentR do
8
- let(:apr) { PercentR.new }
9
-
10
- it 'registers an offence for %r with zero or one slash in regexp' do
11
- inspect_source(apr, ['x =~ %r(/home)',
12
- 'y =~ %r(etc)'])
13
- expect(apr.offences.map(&:message))
14
- .to eq([PercentR::MSG] * 2)
15
- end
16
-
17
- it 'accepts %r with at least two slashes in regexp' do
18
- inspect_source(apr, ['x =~ %r(/home/)',
19
- 'y =~ %r(/////)'])
20
- expect(apr.offences.map(&:message)).to be_empty
21
- end
22
-
23
- it 'accepts slash delimiters for regexp' do
24
- inspect_source(apr, ['x =~ /\/home/'])
25
- expect(apr.offences.map(&:message)).to be_empty
26
- end
27
- end
28
- end
29
- end
@@ -1,57 +0,0 @@
1
- # encoding: utf-8
2
-
3
- require 'spec_helper'
4
-
5
- module Rubocop
6
- module Cop
7
- describe ReduceArguments do
8
- let(:reduce_arguments) { ReduceArguments.new }
9
-
10
- it 'find wrong argument names in calls with different syntax' do
11
- inspect_source(reduce_arguments,
12
- ['def m',
13
- ' [0, 1].reduce { |c, d| c + d }',
14
- ' [0, 1].reduce{ |c, d| c + d }',
15
- ' [0, 1].reduce(5) { |c, d| c + d }',
16
- ' [0, 1].reduce(5){ |c, d| c + d }',
17
- ' [0, 1].reduce (5) { |c, d| c + d }',
18
- ' [0, 1].reduce(5) { |c, d| c + d }',
19
- 'end'])
20
- expect(reduce_arguments.offences.size).to eq(6)
21
- expect(reduce_arguments.offences
22
- .map(&:line_number).sort).to eq((2..7).to_a)
23
- end
24
-
25
- it 'allows calls with proper argument names' do
26
- inspect_source(reduce_arguments,
27
- ['def m',
28
- ' [0, 1].reduce { |a, e| a + e }',
29
- ' [0, 1].reduce{ |a, e| a + e }',
30
- ' [0, 1].reduce(5) { |a, e| a + e }',
31
- ' [0, 1].reduce(5){ |a, e| a + e }',
32
- ' [0, 1].reduce (5) { |a, e| a + e }',
33
- ' [0, 1].reduce(5) { |a, e| a + e }',
34
- 'end'])
35
- expect(reduce_arguments.offences).to be_empty
36
- end
37
-
38
- it 'ignores do..end blocks' do
39
- inspect_source(reduce_arguments,
40
- ['def m',
41
- ' [0, 1].reduce do |c, d|',
42
- ' c + d',
43
- ' end',
44
- 'end'])
45
- expect(reduce_arguments.offences).to be_empty
46
- end
47
-
48
- it 'ignores :reduce symbols' do
49
- inspect_source(reduce_arguments,
50
- ['def m',
51
- ' call_method(:reduce) { |a, b| a + b}',
52
- 'end'])
53
- expect(reduce_arguments.offences).to be_empty
54
- end
55
- end
56
- end
57
- end