rubocop 0.8.0 → 0.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.travis.yml +0 -4
- data/.yardopts +2 -0
- data/CHANGELOG.md +95 -1
- data/README.md +101 -11
- data/config/default.yml +14 -2
- data/config/enabled.yml +96 -14
- data/lib/rubocop/cli.rb +178 -94
- data/lib/rubocop/config.rb +56 -11
- data/lib/rubocop/config_store.rb +2 -0
- data/lib/rubocop/cop/cop.rb +54 -11
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
- data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
- data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
- data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
- data/lib/rubocop/cop/lint/eval.rb +22 -0
- data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
- data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
- data/lib/rubocop/cop/lint/loop.rb +29 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
- data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
- data/lib/rubocop/cop/lint/void.rb +58 -0
- data/lib/rubocop/cop/offence.rb +112 -12
- data/lib/rubocop/cop/rails/validation.rb +34 -0
- data/lib/rubocop/cop/style/access_control.rb +58 -0
- data/lib/rubocop/cop/style/alias.rb +28 -0
- data/lib/rubocop/cop/style/align_parameters.rb +39 -0
- data/lib/rubocop/cop/style/and_or.rb +45 -0
- data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
- data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
- data/lib/rubocop/cop/style/attr.rb +20 -0
- data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
- data/lib/rubocop/cop/style/avoid_for.rb +18 -0
- data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
- data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
- data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
- data/lib/rubocop/cop/style/begin_block.rb +18 -0
- data/lib/rubocop/cop/style/block_comments.rb +20 -0
- data/lib/rubocop/cop/style/block_nesting.rb +47 -0
- data/lib/rubocop/cop/style/blocks.rb +27 -0
- data/lib/rubocop/cop/style/case_equality.rb +22 -0
- data/lib/rubocop/cop/style/case_indentation.rb +28 -0
- data/lib/rubocop/cop/style/character_literal.rb +37 -0
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
- data/lib/rubocop/cop/style/class_methods.rb +22 -0
- data/lib/rubocop/cop/style/collection_methods.rb +37 -0
- data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
- data/lib/rubocop/cop/style/constant_name.rb +31 -0
- data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
- data/lib/rubocop/cop/style/documentation.rb +58 -0
- data/lib/rubocop/cop/style/dot_position.rb +25 -0
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
- data/lib/rubocop/cop/style/empty_lines.rb +40 -0
- data/lib/rubocop/cop/style/empty_literal.rb +53 -0
- data/lib/rubocop/cop/style/encoding.rb +29 -0
- data/lib/rubocop/cop/style/end_block.rb +18 -0
- data/lib/rubocop/cop/style/end_of_line.rb +23 -0
- data/lib/rubocop/cop/style/favor_join.rb +29 -0
- data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
- data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
- data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
- data/lib/rubocop/cop/style/if_then_else.rb +80 -0
- data/lib/rubocop/cop/style/lambda.rb +47 -0
- data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
- data/lib/rubocop/cop/style/line_continuation.rb +26 -0
- data/lib/rubocop/cop/style/line_length.rb +30 -0
- data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
- data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
- data/lib/rubocop/cop/style/method_length.rb +57 -0
- data/lib/rubocop/cop/style/not.rb +24 -0
- data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
- data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
- data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
- data/lib/rubocop/cop/style/proc.rb +30 -0
- data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
- data/lib/rubocop/cop/style/semicolon.rb +51 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
- data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
- data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
- data/lib/rubocop/cop/style/string_literals.rb +36 -0
- data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
- data/lib/rubocop/cop/style/symbol_array.rb +31 -0
- data/lib/rubocop/cop/style/symbol_name.rb +27 -0
- data/lib/rubocop/cop/style/tab.rb +25 -0
- data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
- data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
- data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
- data/lib/rubocop/cop/style/unless_else.rb +26 -0
- data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
- data/lib/rubocop/cop/style/when_then.rb +25 -0
- data/lib/rubocop/cop/style/while_until_do.rb +45 -0
- data/lib/rubocop/cop/style/word_array.rb +44 -0
- data/lib/rubocop/cop/util.rb +1 -0
- data/lib/rubocop/cop/variable_inspector.rb +280 -0
- data/lib/rubocop/formatter/base_formatter.rb +119 -0
- data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
- data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
- data/lib/rubocop/formatter/formatter_set.rb +77 -0
- data/lib/rubocop/formatter/json_formatter.rb +76 -0
- data/lib/rubocop/formatter/progress_formatter.rb +63 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
- data/lib/rubocop/version.rb +15 -1
- data/lib/rubocop.rb +97 -71
- data/rubocop.gemspec +1 -2
- data/spec/.rubocop.yml +5 -0
- data/spec/project_spec.rb +4 -7
- data/spec/rubocop/cli_spec.rb +402 -143
- data/spec/rubocop/config_spec.rb +61 -0
- data/spec/rubocop/config_store_spec.rb +2 -2
- data/spec/rubocop/cops/cop_spec.rb +14 -7
- data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
- data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
- data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
- data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
- data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
- data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
- data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
- data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
- data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
- data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
- data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
- data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
- data/spec/rubocop/cops/lint/void_spec.rb +63 -0
- data/spec/rubocop/cops/offence_spec.rb +107 -10
- data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
- data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
- data/spec/rubocop/cops/style/alias_spec.rb +47 -0
- data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
- data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
- data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
- data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
- data/spec/rubocop/cops/style/attr_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
- data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
- data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
- data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
- data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
- data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
- data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
- data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
- data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
- data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
- data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
- data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
- data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
- data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
- data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
- data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
- data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
- data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
- data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
- data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
- data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
- data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
- data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
- data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
- data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
- data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
- data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
- data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
- data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
- data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
- data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
- data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
- data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
- data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
- data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
- data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
- data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
- data/spec/rubocop/cops/style/not_spec.rb +28 -0
- data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
- data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
- data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
- data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
- data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
- data/spec/rubocop/cops/style/proc_spec.rb +28 -0
- data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
- data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
- data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
- data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
- data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
- data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
- data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
- data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
- data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
- data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
- data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
- data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
- data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
- data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
- data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
- data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
- data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
- data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
- data/spec/rubocop/cops/style/tab_spec.rb +23 -0
- data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
- data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
- data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
- data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
- data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
- data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
- data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
- data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
- data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
- data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
- data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
- data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
- data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
- data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
- data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
- data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
- data/spec/spec_helper.rb +24 -9
- data/spec/support/mri_syntax_checker.rb +69 -0
- data/spec/support/shared_examples.rb +33 -0
- metadata +317 -239
- data/lib/rubocop/cop/access_control.rb +0 -41
- data/lib/rubocop/cop/alias.rb +0 -17
- data/lib/rubocop/cop/align_parameters.rb +0 -37
- data/lib/rubocop/cop/and_or.rb +0 -26
- data/lib/rubocop/cop/ascii_comments.rb +0 -13
- data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
- data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
- data/lib/rubocop/cop/avoid_for.rb +0 -17
- data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
- data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
- data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
- data/lib/rubocop/cop/block_comments.rb +0 -15
- data/lib/rubocop/cop/blocks.rb +0 -23
- data/lib/rubocop/cop/case_indentation.rb +0 -22
- data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
- data/lib/rubocop/cop/class_methods.rb +0 -15
- data/lib/rubocop/cop/collection_methods.rb +0 -29
- data/lib/rubocop/cop/colon_method_call.rb +0 -20
- data/lib/rubocop/cop/constant_name.rb +0 -24
- data/lib/rubocop/cop/def_parentheses.rb +0 -62
- data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
- data/lib/rubocop/cop/empty_lines.rb +0 -34
- data/lib/rubocop/cop/empty_literal.rb +0 -47
- data/lib/rubocop/cop/encoding.rb +0 -19
- data/lib/rubocop/cop/end_of_line.rb +0 -15
- data/lib/rubocop/cop/ensure_return.rb +0 -19
- data/lib/rubocop/cop/eval.rb +0 -19
- data/lib/rubocop/cop/favor_join.rb +0 -22
- data/lib/rubocop/cop/favor_modifier.rb +0 -72
- data/lib/rubocop/cop/favor_percent_r.rb +0 -19
- data/lib/rubocop/cop/favor_sprintf.rb +0 -21
- data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
- data/lib/rubocop/cop/handle_exceptions.rb +0 -17
- data/lib/rubocop/cop/hash_syntax.rb +0 -41
- data/lib/rubocop/cop/if_then_else.rb +0 -65
- data/lib/rubocop/cop/leading_comment_space.rb +0 -17
- data/lib/rubocop/cop/line_continuation.rb +0 -15
- data/lib/rubocop/cop/line_length.rb +0 -23
- data/lib/rubocop/cop/loop.rb +0 -33
- data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
- data/lib/rubocop/cop/method_length.rb +0 -52
- data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
- data/lib/rubocop/cop/not.rb +0 -21
- data/lib/rubocop/cop/numeric_literals.rb +0 -21
- data/lib/rubocop/cop/parameter_lists.rb +0 -23
- data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
- data/lib/rubocop/cop/percent_r.rb +0 -19
- data/lib/rubocop/cop/reduce_arguments.rb +0 -29
- data/lib/rubocop/cop/rescue_exception.rb +0 -26
- data/lib/rubocop/cop/rescue_modifier.rb +0 -17
- data/lib/rubocop/cop/semicolon.rb +0 -31
- data/lib/rubocop/cop/single_line_methods.rb +0 -44
- data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
- data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
- data/lib/rubocop/cop/string_literals.rb +0 -22
- data/lib/rubocop/cop/surrounding_space.rb +0 -283
- data/lib/rubocop/cop/symbol_array.rb +0 -31
- data/lib/rubocop/cop/symbol_name.rb +0 -23
- data/lib/rubocop/cop/syntax.rb +0 -49
- data/lib/rubocop/cop/tab.rb +0 -15
- data/lib/rubocop/cop/ternary_operator.rb +0 -43
- data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
- data/lib/rubocop/cop/trivial_accessors.rb +0 -26
- data/lib/rubocop/cop/unless_else.rb +0 -23
- data/lib/rubocop/cop/variable_interpolation.rb +0 -29
- data/lib/rubocop/cop/when_then.rb +0 -17
- data/lib/rubocop/cop/word_array.rb +0 -37
- data/lib/rubocop/report/emacs_style.rb +0 -17
- data/lib/rubocop/report/plain_text.rb +0 -18
- data/lib/rubocop/report/report.rb +0 -44
- data/spec/rubocop/cops/access_control_spec.rb +0 -129
- data/spec/rubocop/cops/alias_spec.rb +0 -39
- data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
- data/spec/rubocop/cops/and_or_spec.rb +0 -37
- data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
- data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
- data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
- data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
- data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
- data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
- data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
- data/spec/rubocop/cops/block_comments_spec.rb +0 -25
- data/spec/rubocop/cops/blocks_spec.rb +0 -33
- data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
- data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
- data/spec/rubocop/cops/class_methods_spec.rb +0 -49
- data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
- data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
- data/spec/rubocop/cops/constant_name_spec.rb +0 -42
- data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
- data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
- data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
- data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
- data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
- data/spec/rubocop/cops/encoding_spec.rb +0 -47
- data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
- data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
- data/spec/rubocop/cops/eval_spec.rb +0 -39
- data/spec/rubocop/cops/favor_join_spec.rb +0 -35
- data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
- data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
- data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
- data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
- data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
- data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
- data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
- data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
- data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
- data/spec/rubocop/cops/line_length_spec.rb +0 -23
- data/spec/rubocop/cops/loop_spec.rb +0 -31
- data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
- data/spec/rubocop/cops/method_length_spec.rb +0 -147
- data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
- data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
- data/spec/rubocop/cops/not_spec.rb +0 -31
- data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
- data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
- data/spec/rubocop/cops/op_method_spec.rb +0 -78
- data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
- data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
- data/spec/rubocop/cops/percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
- data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
- data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
- data/spec/rubocop/cops/semicolon_spec.rb +0 -88
- data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
- data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
- data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
- data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
- data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
- data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
- data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
- data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
- data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
- data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
- data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
- data/spec/rubocop/cops/string_literals_spec.rb +0 -47
- data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
- data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
- data/spec/rubocop/cops/syntax_spec.rb +0 -41
- data/spec/rubocop/cops/tab_spec.rb +0 -21
- data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
- data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
- data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
- data/spec/rubocop/cops/unless_else_spec.rb +0 -29
- data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
- data/spec/rubocop/cops/when_then_spec.rb +0 -38
- data/spec/rubocop/cops/word_array_spec.rb +0 -47
- data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
- data/spec/rubocop/reports/report_spec.rb +0 -29
|
@@ -0,0 +1,54 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for assignments in the conditions of
|
|
7
|
+
# if/while/until.
|
|
8
|
+
class AssignmentInCondition < Cop
|
|
9
|
+
ASGN_NODES = [:lvasgn, :ivasgn, :cvasgn, :gvasgn, :casgn]
|
|
10
|
+
MSG = 'Assignment in condition - you probably meant to use ==.'
|
|
11
|
+
|
|
12
|
+
def on_if(node)
|
|
13
|
+
check(node)
|
|
14
|
+
super
|
|
15
|
+
end
|
|
16
|
+
|
|
17
|
+
def on_while(node)
|
|
18
|
+
check(node)
|
|
19
|
+
super
|
|
20
|
+
end
|
|
21
|
+
|
|
22
|
+
def on_until(node)
|
|
23
|
+
check(node)
|
|
24
|
+
super
|
|
25
|
+
end
|
|
26
|
+
|
|
27
|
+
private
|
|
28
|
+
|
|
29
|
+
def check(node)
|
|
30
|
+
condition, = *node
|
|
31
|
+
|
|
32
|
+
on_node([:begin, *ASGN_NODES], condition) do |asgn_node|
|
|
33
|
+
# skip safe assignment nodes if safe assignment is allowed
|
|
34
|
+
return if safe_assignment_allowed? && safe_assignment?(asgn_node)
|
|
35
|
+
|
|
36
|
+
# assignment nodes from shorthand ops like ||= don't have operator
|
|
37
|
+
if asgn_node.type != :begin && asgn_node.loc.operator
|
|
38
|
+
add_offence(:warning, asgn_node.loc.operator, MSG)
|
|
39
|
+
end
|
|
40
|
+
end
|
|
41
|
+
end
|
|
42
|
+
|
|
43
|
+
def safe_assignment?(node)
|
|
44
|
+
node.type == :begin && node.children.size == 1 &&
|
|
45
|
+
ASGN_NODES.include?(node.children[0].type)
|
|
46
|
+
end
|
|
47
|
+
|
|
48
|
+
def safe_assignment_allowed?
|
|
49
|
+
AssignmentInCondition.config['AllowSafeAssignment']
|
|
50
|
+
end
|
|
51
|
+
end
|
|
52
|
+
end
|
|
53
|
+
end
|
|
54
|
+
end
|
|
@@ -0,0 +1,180 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks whether the end keywords are aligned properly.
|
|
7
|
+
#
|
|
8
|
+
# There are two ways to align the end of a block.
|
|
9
|
+
# Set BlockAlignSchema to StartOfAssignment if you want to
|
|
10
|
+
# align the end to the beginning of assignment expression.
|
|
11
|
+
# This is the default behavior.
|
|
12
|
+
# @example
|
|
13
|
+
#
|
|
14
|
+
# variable = lambda do |i|
|
|
15
|
+
# i
|
|
16
|
+
# end
|
|
17
|
+
#
|
|
18
|
+
# Set BlockAlignSchema to StartOfBlockCommand if you want to
|
|
19
|
+
# align the end to the beginning of the expression that called the block.
|
|
20
|
+
# @example
|
|
21
|
+
#
|
|
22
|
+
# variable = lambda do |i|
|
|
23
|
+
# i
|
|
24
|
+
# end
|
|
25
|
+
class EndAlignment < Cop
|
|
26
|
+
MSG = 'end at %d, %d is not aligned with %s at %d, %d'
|
|
27
|
+
|
|
28
|
+
def initialize
|
|
29
|
+
super
|
|
30
|
+
@inspected_blocks = []
|
|
31
|
+
end
|
|
32
|
+
|
|
33
|
+
def inspect(source_buffer, source, tokens, ast, comments)
|
|
34
|
+
@inspected_blocks = []
|
|
35
|
+
super
|
|
36
|
+
end
|
|
37
|
+
|
|
38
|
+
def on_def(node)
|
|
39
|
+
check(node)
|
|
40
|
+
super
|
|
41
|
+
end
|
|
42
|
+
|
|
43
|
+
def on_defs(node)
|
|
44
|
+
check(node)
|
|
45
|
+
super
|
|
46
|
+
end
|
|
47
|
+
|
|
48
|
+
def on_class(node)
|
|
49
|
+
check(node)
|
|
50
|
+
super
|
|
51
|
+
end
|
|
52
|
+
|
|
53
|
+
def on_module(node)
|
|
54
|
+
check(node)
|
|
55
|
+
super
|
|
56
|
+
end
|
|
57
|
+
|
|
58
|
+
def on_if(node)
|
|
59
|
+
check(node) if node.loc.respond_to?(:end)
|
|
60
|
+
super
|
|
61
|
+
end
|
|
62
|
+
|
|
63
|
+
def on_while(node)
|
|
64
|
+
check(node)
|
|
65
|
+
super
|
|
66
|
+
end
|
|
67
|
+
|
|
68
|
+
def on_until(node)
|
|
69
|
+
check(node)
|
|
70
|
+
super
|
|
71
|
+
end
|
|
72
|
+
|
|
73
|
+
# Block related alignments
|
|
74
|
+
|
|
75
|
+
def on_block(node)
|
|
76
|
+
return if already_processed_node?(node)
|
|
77
|
+
check_block_alignment(node.loc.expression, node.loc)
|
|
78
|
+
super
|
|
79
|
+
end
|
|
80
|
+
|
|
81
|
+
def on_lvasgn(node)
|
|
82
|
+
if align_with_start_of_assignment?
|
|
83
|
+
_, children = *node
|
|
84
|
+
process_block_assignment(node, children)
|
|
85
|
+
end
|
|
86
|
+
super
|
|
87
|
+
end
|
|
88
|
+
|
|
89
|
+
alias_method :on_ivasgn, :on_lvasgn
|
|
90
|
+
alias_method :on_cvasgn, :on_lvasgn
|
|
91
|
+
alias_method :on_gvasgn, :on_lvasgn
|
|
92
|
+
alias_method :on_and_asgn, :on_lvasgn
|
|
93
|
+
alias_method :on_or_asgn, :on_lvasgn
|
|
94
|
+
|
|
95
|
+
def on_casgn(node)
|
|
96
|
+
if align_with_start_of_assignment?
|
|
97
|
+
_, _, children = *node
|
|
98
|
+
process_block_assignment(node, children)
|
|
99
|
+
end
|
|
100
|
+
super
|
|
101
|
+
end
|
|
102
|
+
|
|
103
|
+
def on_op_asgn(node)
|
|
104
|
+
if align_with_start_of_assignment?
|
|
105
|
+
variable, _op, args = *node
|
|
106
|
+
process_block_assignment(variable, args)
|
|
107
|
+
end
|
|
108
|
+
super
|
|
109
|
+
end
|
|
110
|
+
|
|
111
|
+
def on_send(node)
|
|
112
|
+
if align_with_start_of_assignment?
|
|
113
|
+
receiver, method, args = *node
|
|
114
|
+
if attribute_writer?(method)
|
|
115
|
+
process_block_assignment(receiver, args)
|
|
116
|
+
end
|
|
117
|
+
end
|
|
118
|
+
super
|
|
119
|
+
end
|
|
120
|
+
|
|
121
|
+
def on_masgn(node)
|
|
122
|
+
if align_with_start_of_assignment?
|
|
123
|
+
variables, args = *node
|
|
124
|
+
process_block_assignment(variables, args)
|
|
125
|
+
end
|
|
126
|
+
super
|
|
127
|
+
end
|
|
128
|
+
|
|
129
|
+
private
|
|
130
|
+
|
|
131
|
+
def process_block_assignment(begin_node, block_node)
|
|
132
|
+
if block_node && block_node.type == :block
|
|
133
|
+
@inspected_blocks << block_node
|
|
134
|
+
check_block_alignment(begin_node.loc.expression, block_node.loc)
|
|
135
|
+
end
|
|
136
|
+
end
|
|
137
|
+
|
|
138
|
+
def check_block_alignment(start_loc, block_loc)
|
|
139
|
+
end_loc = block_loc.end
|
|
140
|
+
|
|
141
|
+
if block_loc.begin.line != end_loc.line &&
|
|
142
|
+
start_loc.column != end_loc.column
|
|
143
|
+
add_offence(:warning,
|
|
144
|
+
end_loc,
|
|
145
|
+
sprintf(MSG, end_loc.line, end_loc.column,
|
|
146
|
+
start_loc.source.lines.to_a.first.chomp,
|
|
147
|
+
start_loc.line, start_loc.column))
|
|
148
|
+
end
|
|
149
|
+
end
|
|
150
|
+
|
|
151
|
+
def check(node)
|
|
152
|
+
# discard modifier forms of if/while/until
|
|
153
|
+
return unless node.loc.end
|
|
154
|
+
|
|
155
|
+
kw_loc = node.loc.keyword
|
|
156
|
+
end_loc = node.loc.end
|
|
157
|
+
|
|
158
|
+
if kw_loc.line != end_loc.line && kw_loc.column != end_loc.column
|
|
159
|
+
add_offence(:warning,
|
|
160
|
+
end_loc,
|
|
161
|
+
sprintf(MSG, end_loc.line, end_loc.column,
|
|
162
|
+
kw_loc.source, kw_loc.line, kw_loc.column))
|
|
163
|
+
end
|
|
164
|
+
end
|
|
165
|
+
|
|
166
|
+
def already_processed_node?(node)
|
|
167
|
+
@inspected_blocks.include?(node)
|
|
168
|
+
end
|
|
169
|
+
|
|
170
|
+
def attribute_writer?(method)
|
|
171
|
+
method.to_s[-1] == '='
|
|
172
|
+
end
|
|
173
|
+
|
|
174
|
+
def align_with_start_of_assignment?
|
|
175
|
+
EndAlignment.config['BlockAlignSchema'] == 'StartOfAssignment'
|
|
176
|
+
end
|
|
177
|
+
end
|
|
178
|
+
end
|
|
179
|
+
end
|
|
180
|
+
end
|
|
@@ -0,0 +1,30 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for END blocks in method definitions.
|
|
7
|
+
class EndInMethod < Cop
|
|
8
|
+
MSG = 'END found in method definition. Use `at_exit` instead.'
|
|
9
|
+
|
|
10
|
+
def on_def(node)
|
|
11
|
+
check(node)
|
|
12
|
+
super
|
|
13
|
+
end
|
|
14
|
+
|
|
15
|
+
def on_defs(node)
|
|
16
|
+
check(node)
|
|
17
|
+
super
|
|
18
|
+
end
|
|
19
|
+
|
|
20
|
+
private
|
|
21
|
+
|
|
22
|
+
def check(node)
|
|
23
|
+
on_node(:postexe, node) do |end_node|
|
|
24
|
+
add_offence(:warning, end_node.loc.keyword, MSG)
|
|
25
|
+
end
|
|
26
|
+
end
|
|
27
|
+
end
|
|
28
|
+
end
|
|
29
|
+
end
|
|
30
|
+
end
|
|
@@ -0,0 +1,22 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for *return* from an *ensure* block.
|
|
7
|
+
class EnsureReturn < Cop
|
|
8
|
+
MSG = 'Never return from an ensure block.'
|
|
9
|
+
|
|
10
|
+
def on_ensure(node)
|
|
11
|
+
_body, ensure_body = *node
|
|
12
|
+
|
|
13
|
+
on_node(:return, ensure_body) do |e|
|
|
14
|
+
add_offence(:warning, e.loc.expression, MSG)
|
|
15
|
+
end
|
|
16
|
+
|
|
17
|
+
super
|
|
18
|
+
end
|
|
19
|
+
end
|
|
20
|
+
end
|
|
21
|
+
end
|
|
22
|
+
end
|
|
@@ -0,0 +1,22 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for the use of *Kernel#eval*.
|
|
7
|
+
class Eval < Cop
|
|
8
|
+
MSG = 'The use of eval is a serious security risk.'
|
|
9
|
+
|
|
10
|
+
def on_send(node)
|
|
11
|
+
receiver, method_name, = *node
|
|
12
|
+
|
|
13
|
+
if receiver.nil? && method_name == :eval
|
|
14
|
+
add_offence(:warning, node.loc.selector, MSG)
|
|
15
|
+
end
|
|
16
|
+
|
|
17
|
+
super
|
|
18
|
+
end
|
|
19
|
+
end
|
|
20
|
+
end
|
|
21
|
+
end
|
|
22
|
+
end
|
|
@@ -0,0 +1,20 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for *rescue* blocks with no body.
|
|
7
|
+
class HandleExceptions < Cop
|
|
8
|
+
MSG = 'Do not suppress exceptions.'
|
|
9
|
+
|
|
10
|
+
def on_resbody(node)
|
|
11
|
+
_exc_list_node, _exc_var_node, body_node = *node
|
|
12
|
+
|
|
13
|
+
add_offence(:warning, node.loc.expression, MSG) unless body_node
|
|
14
|
+
|
|
15
|
+
super
|
|
16
|
+
end
|
|
17
|
+
end
|
|
18
|
+
end
|
|
19
|
+
end
|
|
20
|
+
end
|
|
@@ -0,0 +1,63 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for literals used as operands in and/or
|
|
7
|
+
# expressions in the conditions of if/while/until.
|
|
8
|
+
class LiteralInCondition < Cop
|
|
9
|
+
MSG = 'Literal %s appeared in a condition.'
|
|
10
|
+
|
|
11
|
+
LITERALS = [:str, :dstr, :int, :float, :array,
|
|
12
|
+
:hash, :regexp, :nil, :true, :false]
|
|
13
|
+
|
|
14
|
+
def on_if(node)
|
|
15
|
+
check_for_literal(node)
|
|
16
|
+
|
|
17
|
+
super
|
|
18
|
+
end
|
|
19
|
+
|
|
20
|
+
def on_while(node)
|
|
21
|
+
check_for_literal(node)
|
|
22
|
+
|
|
23
|
+
super
|
|
24
|
+
end
|
|
25
|
+
|
|
26
|
+
def on_while_post(node)
|
|
27
|
+
check_for_literal(node)
|
|
28
|
+
|
|
29
|
+
super
|
|
30
|
+
end
|
|
31
|
+
|
|
32
|
+
def on_until(node)
|
|
33
|
+
check_for_literal(node)
|
|
34
|
+
|
|
35
|
+
super
|
|
36
|
+
end
|
|
37
|
+
|
|
38
|
+
def on_until_post(node)
|
|
39
|
+
check_for_literal(node)
|
|
40
|
+
|
|
41
|
+
super
|
|
42
|
+
end
|
|
43
|
+
|
|
44
|
+
private
|
|
45
|
+
|
|
46
|
+
def check_for_literal(node)
|
|
47
|
+
cond, = *node
|
|
48
|
+
|
|
49
|
+
on_node([:and, :or], cond) do |logic_node|
|
|
50
|
+
*operands = *logic_node
|
|
51
|
+
operands.each do |op|
|
|
52
|
+
if LITERALS.include?(op.type)
|
|
53
|
+
add_offence(:warning, op.loc.expression,
|
|
54
|
+
format(MSG, op.loc.expression.source))
|
|
55
|
+
|
|
56
|
+
end
|
|
57
|
+
end
|
|
58
|
+
end
|
|
59
|
+
end
|
|
60
|
+
end
|
|
61
|
+
end
|
|
62
|
+
end
|
|
63
|
+
end
|
|
@@ -0,0 +1,29 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for uses of *begin...end while/until something*.
|
|
7
|
+
class Loop < Cop
|
|
8
|
+
MSG = 'Use Kernel#loop with break rather than ' +
|
|
9
|
+
'begin/end/until(or while).'
|
|
10
|
+
|
|
11
|
+
def on_while_post(node)
|
|
12
|
+
register_offence(node)
|
|
13
|
+
super
|
|
14
|
+
end
|
|
15
|
+
|
|
16
|
+
def on_until_post(node)
|
|
17
|
+
register_offence(node)
|
|
18
|
+
super
|
|
19
|
+
end
|
|
20
|
+
|
|
21
|
+
private
|
|
22
|
+
|
|
23
|
+
def register_offence(node)
|
|
24
|
+
add_offence(:warning, node.loc.keyword, MSG)
|
|
25
|
+
end
|
|
26
|
+
end
|
|
27
|
+
end
|
|
28
|
+
end
|
|
29
|
+
end
|
|
@@ -0,0 +1,29 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for *rescue* blocks targeting the Exception class.
|
|
7
|
+
class RescueException < Cop
|
|
8
|
+
MSG = 'Avoid rescuing the Exception class.'
|
|
9
|
+
|
|
10
|
+
def on_resbody(node)
|
|
11
|
+
return unless node.children.first
|
|
12
|
+
rescue_args = node.children.first.children
|
|
13
|
+
if rescue_args.any? { |a| targets_exception?(a) }
|
|
14
|
+
add_offence(:warning, node.location.expression, MSG)
|
|
15
|
+
end
|
|
16
|
+
|
|
17
|
+
super
|
|
18
|
+
end
|
|
19
|
+
|
|
20
|
+
def targets_exception?(rescue_arg_node)
|
|
21
|
+
return false unless rescue_arg_node.type == :const
|
|
22
|
+
namespace, klass_name = *rescue_arg_node
|
|
23
|
+
return false unless namespace.nil? || namespace.type == :cbase
|
|
24
|
+
klass_name == :Exception
|
|
25
|
+
end
|
|
26
|
+
end
|
|
27
|
+
end
|
|
28
|
+
end
|
|
29
|
+
end
|
|
@@ -0,0 +1,33 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop looks for use of the same name as outer local variables
|
|
7
|
+
# for block arguments or block local variables.
|
|
8
|
+
# This is a mimic of the warning
|
|
9
|
+
# "shadowing outer local variable - foo" from `ruby -cw`.
|
|
10
|
+
class ShadowingOuterLocalVariable < Cop
|
|
11
|
+
include VariableInspector
|
|
12
|
+
|
|
13
|
+
MSG = 'Shadowing outer local variable - %s'
|
|
14
|
+
|
|
15
|
+
def inspect(source_buffer, source, tokens, ast, comments)
|
|
16
|
+
inspect_variables(ast)
|
|
17
|
+
end
|
|
18
|
+
|
|
19
|
+
def before_declaring_variable(entry)
|
|
20
|
+
# Only block scope can reference outer local variables.
|
|
21
|
+
return unless variable_table.current_scope.node.type == :block
|
|
22
|
+
return unless ARGUMENT_DECLARATION_TYPES.include?(entry.node.type)
|
|
23
|
+
|
|
24
|
+
outer_local_variable = variable_table.find_variable_entry(entry.name)
|
|
25
|
+
return unless outer_local_variable
|
|
26
|
+
|
|
27
|
+
message = sprintf(MSG, entry.name)
|
|
28
|
+
add_offence(:warning, entry.node.loc.expression, message)
|
|
29
|
+
end
|
|
30
|
+
end
|
|
31
|
+
end
|
|
32
|
+
end
|
|
33
|
+
end
|
|
@@ -0,0 +1,35 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for unreachable code.
|
|
7
|
+
# The check are based on the presence of flow of control
|
|
8
|
+
# statement in non-final position in *begin*(implicit) blocks.
|
|
9
|
+
class UnreachableCode < Cop
|
|
10
|
+
MSG = 'Unreachable code detected.'
|
|
11
|
+
|
|
12
|
+
NODE_TYPES = [:return, :next, :break, :retry, :redo]
|
|
13
|
+
FLOW_COMMANDS = [:throw, :raise, :fail]
|
|
14
|
+
|
|
15
|
+
def on_begin(node)
|
|
16
|
+
expressions = *node
|
|
17
|
+
|
|
18
|
+
expressions.each_cons(2) do |e1, e2|
|
|
19
|
+
if NODE_TYPES.include?(e1.type) || flow_command?(e1)
|
|
20
|
+
add_offence(:warning, e2.loc.expression, MSG)
|
|
21
|
+
end
|
|
22
|
+
end
|
|
23
|
+
|
|
24
|
+
super
|
|
25
|
+
end
|
|
26
|
+
|
|
27
|
+
private
|
|
28
|
+
|
|
29
|
+
def flow_command?(node)
|
|
30
|
+
FLOW_COMMANDS.any? { |c| command?(c, node) }
|
|
31
|
+
end
|
|
32
|
+
end
|
|
33
|
+
end
|
|
34
|
+
end
|
|
35
|
+
end
|
|
@@ -0,0 +1,32 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop looks for unused local variables in each scope.
|
|
7
|
+
# Actually this is a mimic of the warning
|
|
8
|
+
# "assigned but unused variable - foo" from `ruby -cw`.
|
|
9
|
+
class UnusedLocalVariable < Cop
|
|
10
|
+
include VariableInspector
|
|
11
|
+
|
|
12
|
+
MSG = 'Assigned but unused variable - %s'
|
|
13
|
+
TYPES_TO_ACCEPT_UNUSED =
|
|
14
|
+
(ARGUMENT_DECLARATION_TYPES - [:shadowarg]).freeze
|
|
15
|
+
|
|
16
|
+
def inspect(source_buffer, source, tokens, ast, comments)
|
|
17
|
+
inspect_variables(ast)
|
|
18
|
+
end
|
|
19
|
+
|
|
20
|
+
def after_leaving_scope(scope)
|
|
21
|
+
scope.variable_entries.each_value do |entry|
|
|
22
|
+
next if entry.used?
|
|
23
|
+
next if TYPES_TO_ACCEPT_UNUSED.include?(entry.node.type)
|
|
24
|
+
next if entry.name.to_s.start_with?('_')
|
|
25
|
+
message = sprintf(MSG, entry.name)
|
|
26
|
+
add_offence(:warning, entry.node.loc.expression, message)
|
|
27
|
+
end
|
|
28
|
+
end
|
|
29
|
+
end
|
|
30
|
+
end
|
|
31
|
+
end
|
|
32
|
+
end
|
|
@@ -0,0 +1,58 @@
|
|
|
1
|
+
# encoding: utf-8
|
|
2
|
+
|
|
3
|
+
module Rubocop
|
|
4
|
+
module Cop
|
|
5
|
+
module Lint
|
|
6
|
+
# This cop checks for operators, variables and literals used
|
|
7
|
+
# in void context.
|
|
8
|
+
class Void < Cop
|
|
9
|
+
OP_MSG = 'Operator %s used in void context.'
|
|
10
|
+
VAR_MSG = 'Variable %s used in void context.'
|
|
11
|
+
LIT_MSG = 'Literal %s used in void context'
|
|
12
|
+
|
|
13
|
+
OPS = %w(* / % + - == === != < > <= >= <=>)
|
|
14
|
+
VARS = [:ivar, :lvar, :cvar, :const]
|
|
15
|
+
LITERALS = [:str, :dstr, :int, :float, :array,
|
|
16
|
+
:hash, :regexp, :nil, :true, :false]
|
|
17
|
+
|
|
18
|
+
def on_begin(node)
|
|
19
|
+
expressions = *node
|
|
20
|
+
|
|
21
|
+
expressions[0...-1].each do |expr|
|
|
22
|
+
check_for_void_op(expr)
|
|
23
|
+
check_for_literal(expr)
|
|
24
|
+
check_for_var(expr)
|
|
25
|
+
end
|
|
26
|
+
|
|
27
|
+
super
|
|
28
|
+
end
|
|
29
|
+
|
|
30
|
+
private
|
|
31
|
+
|
|
32
|
+
def check_for_void_op(node)
|
|
33
|
+
return unless node.type == :send
|
|
34
|
+
|
|
35
|
+
op = node.loc.selector.source
|
|
36
|
+
|
|
37
|
+
if OPS.include?(op)
|
|
38
|
+
add_offence(:warning, node.loc.selector, sprintf(OP_MSG, op))
|
|
39
|
+
end
|
|
40
|
+
end
|
|
41
|
+
|
|
42
|
+
def check_for_var(node)
|
|
43
|
+
if VARS.include?(node.type)
|
|
44
|
+
add_offence(:warning, node.loc.name,
|
|
45
|
+
sprintf(VAR_MSG, node.loc.name.source))
|
|
46
|
+
end
|
|
47
|
+
end
|
|
48
|
+
|
|
49
|
+
def check_for_literal(node)
|
|
50
|
+
if LITERALS.include?(node.type)
|
|
51
|
+
add_offence(:warning, node.loc.expression,
|
|
52
|
+
sprintf(LIT_MSG, node.loc.expression.source))
|
|
53
|
+
end
|
|
54
|
+
end
|
|
55
|
+
end
|
|
56
|
+
end
|
|
57
|
+
end
|
|
58
|
+
end
|