rubocop 0.8.0 → 0.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.travis.yml +0 -4
- data/.yardopts +2 -0
- data/CHANGELOG.md +95 -1
- data/README.md +101 -11
- data/config/default.yml +14 -2
- data/config/enabled.yml +96 -14
- data/lib/rubocop/cli.rb +178 -94
- data/lib/rubocop/config.rb +56 -11
- data/lib/rubocop/config_store.rb +2 -0
- data/lib/rubocop/cop/cop.rb +54 -11
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +54 -0
- data/lib/rubocop/cop/lint/end_alignment.rb +180 -0
- data/lib/rubocop/cop/lint/end_in_method.rb +30 -0
- data/lib/rubocop/cop/lint/ensure_return.rb +22 -0
- data/lib/rubocop/cop/lint/eval.rb +22 -0
- data/lib/rubocop/cop/lint/handle_exceptions.rb +20 -0
- data/lib/rubocop/cop/lint/literal_in_condition.rb +63 -0
- data/lib/rubocop/cop/lint/loop.rb +29 -0
- data/lib/rubocop/cop/lint/rescue_exception.rb +29 -0
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +33 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +35 -0
- data/lib/rubocop/cop/lint/unused_local_variable.rb +32 -0
- data/lib/rubocop/cop/lint/void.rb +58 -0
- data/lib/rubocop/cop/offence.rb +112 -12
- data/lib/rubocop/cop/rails/validation.rb +34 -0
- data/lib/rubocop/cop/style/access_control.rb +58 -0
- data/lib/rubocop/cop/style/alias.rb +28 -0
- data/lib/rubocop/cop/style/align_parameters.rb +39 -0
- data/lib/rubocop/cop/style/and_or.rb +45 -0
- data/lib/rubocop/cop/style/ascii_comments.rb +21 -0
- data/lib/rubocop/cop/style/ascii_identifiers.rb +22 -0
- data/lib/rubocop/cop/style/attr.rb +20 -0
- data/lib/rubocop/cop/style/avoid_class_vars.rb +20 -0
- data/lib/rubocop/cop/style/avoid_for.rb +18 -0
- data/lib/rubocop/cop/style/avoid_global_vars.rb +65 -0
- data/lib/rubocop/cop/style/avoid_perl_backrefs.rb +21 -0
- data/lib/rubocop/cop/style/avoid_perlisms.rb +50 -0
- data/lib/rubocop/cop/style/begin_block.rb +18 -0
- data/lib/rubocop/cop/style/block_comments.rb +20 -0
- data/lib/rubocop/cop/style/block_nesting.rb +47 -0
- data/lib/rubocop/cop/style/blocks.rb +27 -0
- data/lib/rubocop/cop/style/case_equality.rb +22 -0
- data/lib/rubocop/cop/style/case_indentation.rb +28 -0
- data/lib/rubocop/cop/style/character_literal.rb +37 -0
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +33 -0
- data/lib/rubocop/cop/style/class_methods.rb +22 -0
- data/lib/rubocop/cop/style/collection_methods.rb +37 -0
- data/lib/rubocop/cop/style/colon_method_call.rb +29 -0
- data/lib/rubocop/cop/style/constant_name.rb +31 -0
- data/lib/rubocop/cop/style/def_parentheses.rb +70 -0
- data/lib/rubocop/cop/style/documentation.rb +58 -0
- data/lib/rubocop/cop/style/dot_position.rb +25 -0
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +26 -0
- data/lib/rubocop/cop/style/empty_lines.rb +40 -0
- data/lib/rubocop/cop/style/empty_literal.rb +53 -0
- data/lib/rubocop/cop/style/encoding.rb +29 -0
- data/lib/rubocop/cop/style/end_block.rb +18 -0
- data/lib/rubocop/cop/style/end_of_line.rb +23 -0
- data/lib/rubocop/cop/style/favor_join.rb +29 -0
- data/lib/rubocop/cop/style/favor_modifier.rb +118 -0
- data/lib/rubocop/cop/style/favor_sprintf.rb +28 -0
- data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +54 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +47 -0
- data/lib/rubocop/cop/style/if_then_else.rb +80 -0
- data/lib/rubocop/cop/style/lambda.rb +47 -0
- data/lib/rubocop/cop/style/leading_comment_space.rb +25 -0
- data/lib/rubocop/cop/style/line_continuation.rb +26 -0
- data/lib/rubocop/cop/style/line_length.rb +30 -0
- data/lib/rubocop/cop/style/method_and_variable_snake_case.rb +61 -0
- data/lib/rubocop/cop/style/method_call_parentheses.rb +22 -0
- data/lib/rubocop/cop/style/method_length.rb +57 -0
- data/lib/rubocop/cop/style/not.rb +24 -0
- data/lib/rubocop/cop/style/numeric_literals.rb +25 -0
- data/lib/rubocop/cop/{op_method.rb → style/op_method.rb} +4 -3
- data/lib/rubocop/cop/style/parameter_lists.rb +42 -0
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +42 -0
- data/lib/rubocop/cop/style/proc.rb +30 -0
- data/lib/rubocop/cop/style/reduce_arguments.rb +34 -0
- data/lib/rubocop/cop/style/regexp_literal.rb +39 -0
- data/lib/rubocop/cop/style/rescue_modifier.rb +55 -0
- data/lib/rubocop/cop/style/semicolon.rb +51 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +48 -0
- data/lib/rubocop/cop/style/space_after_comma_etc.rb +69 -0
- data/lib/rubocop/cop/style/space_after_control_keyword.rb +32 -0
- data/lib/rubocop/cop/style/string_literals.rb +36 -0
- data/lib/rubocop/cop/style/surrounding_space.rb +314 -0
- data/lib/rubocop/cop/style/symbol_array.rb +31 -0
- data/lib/rubocop/cop/style/symbol_name.rb +27 -0
- data/lib/rubocop/cop/style/tab.rb +25 -0
- data/lib/rubocop/cop/style/ternary_operator.rb +49 -0
- data/lib/rubocop/cop/style/trailing_whitespace.rb +24 -0
- data/lib/rubocop/cop/style/trivial_accessors.rb +32 -0
- data/lib/rubocop/cop/style/unless_else.rb +26 -0
- data/lib/rubocop/cop/style/variable_interpolation.rb +32 -0
- data/lib/rubocop/cop/style/when_then.rb +25 -0
- data/lib/rubocop/cop/style/while_until_do.rb +45 -0
- data/lib/rubocop/cop/style/word_array.rb +44 -0
- data/lib/rubocop/cop/util.rb +1 -0
- data/lib/rubocop/cop/variable_inspector.rb +280 -0
- data/lib/rubocop/formatter/base_formatter.rb +119 -0
- data/lib/rubocop/formatter/clang_style_formatter.rb +21 -0
- data/lib/rubocop/formatter/emacs_style_formatter.rb +17 -0
- data/lib/rubocop/formatter/formatter_set.rb +77 -0
- data/lib/rubocop/formatter/json_formatter.rb +76 -0
- data/lib/rubocop/formatter/progress_formatter.rb +63 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +62 -0
- data/lib/rubocop/version.rb +15 -1
- data/lib/rubocop.rb +97 -71
- data/rubocop.gemspec +1 -2
- data/spec/.rubocop.yml +5 -0
- data/spec/project_spec.rb +4 -7
- data/spec/rubocop/cli_spec.rb +402 -143
- data/spec/rubocop/config_spec.rb +61 -0
- data/spec/rubocop/config_store_spec.rb +2 -2
- data/spec/rubocop/cops/cop_spec.rb +14 -7
- data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb +111 -0
- data/spec/rubocop/cops/lint/end_alignment_spec.rb +426 -0
- data/spec/rubocop/cops/lint/end_in_method_spec.rb +35 -0
- data/spec/rubocop/cops/lint/ensure_return_spec.rb +37 -0
- data/spec/rubocop/cops/lint/eval_spec.rb +41 -0
- data/spec/rubocop/cops/lint/handle_exceptions_spec.rb +36 -0
- data/spec/rubocop/cops/lint/literal_in_condition_spec.rb +35 -0
- data/spec/rubocop/cops/lint/loop_spec.rb +33 -0
- data/spec/rubocop/cops/lint/rescue_exception_spec.rb +127 -0
- data/spec/rubocop/cops/lint/shadowing_outer_local_variable_spec.rb +180 -0
- data/spec/rubocop/cops/lint/unreachable_code_spec.rb +69 -0
- data/spec/rubocop/cops/lint/unused_local_variable_spec.rb +484 -0
- data/spec/rubocop/cops/lint/void_spec.rb +63 -0
- data/spec/rubocop/cops/offence_spec.rb +107 -10
- data/spec/rubocop/cops/rails/validation_spec.rb +27 -0
- data/spec/rubocop/cops/style/access_control_spec.rb +142 -0
- data/spec/rubocop/cops/style/alias_spec.rb +47 -0
- data/spec/rubocop/cops/style/align_parameters_spec.rb +199 -0
- data/spec/rubocop/cops/style/and_or_spec.rb +39 -0
- data/spec/rubocop/cops/style/ascii_comments_spec.rb +28 -0
- data/spec/rubocop/cops/style/ascii_identifiers_spec.rb +28 -0
- data/spec/rubocop/cops/style/attr_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_class_vars_spec.rb +27 -0
- data/spec/rubocop/cops/style/avoid_for_spec.rb +37 -0
- data/spec/rubocop/cops/style/avoid_global_vars_spec.rb +34 -0
- data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb +20 -0
- data/spec/rubocop/cops/style/avoid_perlisms_spec.rb +47 -0
- data/spec/rubocop/cops/style/begin_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/block_comments_spec.rb +27 -0
- data/spec/rubocop/cops/style/block_nesting_spec.rb +159 -0
- data/spec/rubocop/cops/style/blocks_spec.rb +35 -0
- data/spec/rubocop/cops/style/case_equality_spec.rb +18 -0
- data/spec/rubocop/cops/style/case_indentation_spec.rb +88 -0
- data/spec/rubocop/cops/style/character_literal_spec.rb +28 -0
- data/spec/rubocop/cops/style/class_and_module_camel_case_spec.rb +46 -0
- data/spec/rubocop/cops/style/class_methods_spec.rb +51 -0
- data/spec/rubocop/cops/style/collection_methods_spec.rb +46 -0
- data/spec/rubocop/cops/style/colon_method_call_spec.rb +55 -0
- data/spec/rubocop/cops/style/constant_name_spec.rb +56 -0
- data/spec/rubocop/cops/style/def_with_parentheses_spec.rb +40 -0
- data/spec/rubocop/cops/style/def_without_parentheses_spec.rb +34 -0
- data/spec/rubocop/cops/style/documentation_spec.rb +79 -0
- data/spec/rubocop/cops/style/dot_position_spec.rb +30 -0
- data/spec/rubocop/cops/style/empty_line_between_defs_spec.rb +85 -0
- data/spec/rubocop/cops/style/empty_lines_spec.rb +40 -0
- data/spec/rubocop/cops/style/empty_literal_spec.rb +91 -0
- data/spec/rubocop/cops/style/encoding_spec.rb +49 -0
- data/spec/rubocop/cops/style/end_block_spec.rb +19 -0
- data/spec/rubocop/cops/style/end_of_line_spec.rb +25 -0
- data/spec/rubocop/cops/style/favor_join_spec.rb +37 -0
- data/spec/rubocop/cops/style/favor_modifier_spec.rb +160 -0
- data/spec/rubocop/cops/style/favor_sprintf_spec.rb +53 -0
- data/spec/rubocop/cops/style/favor_unless_over_negated_if_spec.rb +64 -0
- data/spec/rubocop/cops/style/favor_until_over_negated_while_spec.rb +47 -0
- data/spec/rubocop/cops/style/hash_syntax_spec.rb +51 -0
- data/spec/rubocop/cops/style/if_with_semicolon_spec.rb +25 -0
- data/spec/rubocop/cops/style/lambda_spec.rb +45 -0
- data/spec/rubocop/cops/style/leading_comment_space_spec.rb +65 -0
- data/spec/rubocop/cops/style/line_continuation_spec.rb +26 -0
- data/spec/rubocop/cops/style/line_length_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_and_variable_snake_case_spec.rb +95 -0
- data/spec/rubocop/cops/style/method_call_parentheses_spec.rb +25 -0
- data/spec/rubocop/cops/style/method_length_spec.rb +151 -0
- data/spec/rubocop/cops/style/multiline_if_then_spec.rb +81 -0
- data/spec/rubocop/cops/style/not_spec.rb +28 -0
- data/spec/rubocop/cops/style/numeric_literals_spec.rb +51 -0
- data/spec/rubocop/cops/style/one_line_conditional_spec.rb +18 -0
- data/spec/rubocop/cops/style/op_method_spec.rb +80 -0
- data/spec/rubocop/cops/style/parameter_lists_spec.rb +49 -0
- data/spec/rubocop/cops/style/parentheses_around_condition_spec.rb +59 -0
- data/spec/rubocop/cops/style/proc_spec.rb +28 -0
- data/spec/rubocop/cops/style/reduce_arguments_spec.rb +59 -0
- data/spec/rubocop/cops/style/regexp_literal_spec.rb +83 -0
- data/spec/rubocop/cops/style/rescue_modifier_spec.rb +122 -0
- data/spec/rubocop/cops/style/semicolon_spec.rb +95 -0
- data/spec/rubocop/cops/style/single_line_methods_spec.rb +54 -0
- data/spec/rubocop/cops/style/space_after_colon_spec.rb +29 -0
- data/spec/rubocop/cops/style/space_after_comma_spec.rb +31 -0
- data/spec/rubocop/cops/style/space_after_control_keyword_spec.rb +69 -0
- data/spec/rubocop/cops/style/space_after_semicolon_spec.rb +24 -0
- data/spec/rubocop/cops/style/space_around_braces_spec.rb +49 -0
- data/spec/rubocop/cops/style/space_around_equals_in_default_parameter_spec.rb +34 -0
- data/spec/rubocop/cops/style/space_around_operators_spec.rb +216 -0
- data/spec/rubocop/cops/style/space_inside_brackets_spec.rb +51 -0
- data/spec/rubocop/cops/style/space_inside_hash_literal_braces_spec.rb +99 -0
- data/spec/rubocop/cops/style/space_inside_parens_spec.rb +33 -0
- data/spec/rubocop/cops/style/string_literals_spec.rb +62 -0
- data/spec/rubocop/cops/style/symbol_array_spec.rb +45 -0
- data/spec/rubocop/cops/style/symbol_name_spec.rb +122 -0
- data/spec/rubocop/cops/style/tab_spec.rb +23 -0
- data/spec/rubocop/cops/style/ternary_operator_spec.rb +42 -0
- data/spec/rubocop/cops/style/trailing_whitespace_spec.rb +29 -0
- data/spec/rubocop/cops/style/trivial_accessors_spec.rb +338 -0
- data/spec/rubocop/cops/style/unless_else_spec.rb +31 -0
- data/spec/rubocop/cops/style/variable_interpolation_spec.rb +53 -0
- data/spec/rubocop/cops/style/when_then_spec.rb +40 -0
- data/spec/rubocop/cops/style/while_until_do_spec.rb +47 -0
- data/spec/rubocop/cops/style/word_array_spec.rb +61 -0
- data/spec/rubocop/cops/variable_inspector_spec.rb +374 -0
- data/spec/rubocop/formatter/base_formatter_spec.rb +190 -0
- data/spec/rubocop/formatter/clang_style_formatter_spec.rb +70 -0
- data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +32 -0
- data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
- data/spec/rubocop/formatter/json_formatter_spec.rb +142 -0
- data/spec/rubocop/formatter/progress_formatter_spec.rb +196 -0
- data/spec/rubocop/formatter/simple_text_formatter_spec.rb +74 -0
- data/spec/spec_helper.rb +24 -9
- data/spec/support/mri_syntax_checker.rb +69 -0
- data/spec/support/shared_examples.rb +33 -0
- metadata +317 -239
- data/lib/rubocop/cop/access_control.rb +0 -41
- data/lib/rubocop/cop/alias.rb +0 -17
- data/lib/rubocop/cop/align_parameters.rb +0 -37
- data/lib/rubocop/cop/and_or.rb +0 -26
- data/lib/rubocop/cop/ascii_comments.rb +0 -13
- data/lib/rubocop/cop/ascii_identifiers.rb +0 -19
- data/lib/rubocop/cop/avoid_class_vars.rb +0 -15
- data/lib/rubocop/cop/avoid_for.rb +0 -17
- data/lib/rubocop/cop/avoid_global_vars.rb +0 -61
- data/lib/rubocop/cop/avoid_perl_backrefs.rb +0 -17
- data/lib/rubocop/cop/avoid_perlisms.rb +0 -47
- data/lib/rubocop/cop/block_comments.rb +0 -15
- data/lib/rubocop/cop/blocks.rb +0 -23
- data/lib/rubocop/cop/case_indentation.rb +0 -22
- data/lib/rubocop/cop/class_and_module_camel_case.rb +0 -29
- data/lib/rubocop/cop/class_methods.rb +0 -15
- data/lib/rubocop/cop/collection_methods.rb +0 -29
- data/lib/rubocop/cop/colon_method_call.rb +0 -20
- data/lib/rubocop/cop/constant_name.rb +0 -24
- data/lib/rubocop/cop/def_parentheses.rb +0 -62
- data/lib/rubocop/cop/empty_line_between_defs.rb +0 -22
- data/lib/rubocop/cop/empty_lines.rb +0 -34
- data/lib/rubocop/cop/empty_literal.rb +0 -47
- data/lib/rubocop/cop/encoding.rb +0 -19
- data/lib/rubocop/cop/end_of_line.rb +0 -15
- data/lib/rubocop/cop/ensure_return.rb +0 -19
- data/lib/rubocop/cop/eval.rb +0 -19
- data/lib/rubocop/cop/favor_join.rb +0 -22
- data/lib/rubocop/cop/favor_modifier.rb +0 -72
- data/lib/rubocop/cop/favor_percent_r.rb +0 -19
- data/lib/rubocop/cop/favor_sprintf.rb +0 -21
- data/lib/rubocop/cop/favor_unless_over_negated_if.rb +0 -49
- data/lib/rubocop/cop/handle_exceptions.rb +0 -17
- data/lib/rubocop/cop/hash_syntax.rb +0 -41
- data/lib/rubocop/cop/if_then_else.rb +0 -65
- data/lib/rubocop/cop/leading_comment_space.rb +0 -17
- data/lib/rubocop/cop/line_continuation.rb +0 -15
- data/lib/rubocop/cop/line_length.rb +0 -23
- data/lib/rubocop/cop/loop.rb +0 -33
- data/lib/rubocop/cop/method_and_variable_snake_case.rb +0 -55
- data/lib/rubocop/cop/method_length.rb +0 -52
- data/lib/rubocop/cop/new_lambda_literal.rb +0 -19
- data/lib/rubocop/cop/not.rb +0 -21
- data/lib/rubocop/cop/numeric_literals.rb +0 -21
- data/lib/rubocop/cop/parameter_lists.rb +0 -23
- data/lib/rubocop/cop/parentheses_around_condition.rb +0 -24
- data/lib/rubocop/cop/percent_r.rb +0 -19
- data/lib/rubocop/cop/reduce_arguments.rb +0 -29
- data/lib/rubocop/cop/rescue_exception.rb +0 -26
- data/lib/rubocop/cop/rescue_modifier.rb +0 -17
- data/lib/rubocop/cop/semicolon.rb +0 -31
- data/lib/rubocop/cop/single_line_methods.rb +0 -44
- data/lib/rubocop/cop/space_after_comma_etc.rb +0 -62
- data/lib/rubocop/cop/space_after_control_keyword.rb +0 -29
- data/lib/rubocop/cop/string_literals.rb +0 -22
- data/lib/rubocop/cop/surrounding_space.rb +0 -283
- data/lib/rubocop/cop/symbol_array.rb +0 -31
- data/lib/rubocop/cop/symbol_name.rb +0 -23
- data/lib/rubocop/cop/syntax.rb +0 -49
- data/lib/rubocop/cop/tab.rb +0 -15
- data/lib/rubocop/cop/ternary_operator.rb +0 -43
- data/lib/rubocop/cop/trailing_whitespace.rb +0 -15
- data/lib/rubocop/cop/trivial_accessors.rb +0 -26
- data/lib/rubocop/cop/unless_else.rb +0 -23
- data/lib/rubocop/cop/variable_interpolation.rb +0 -29
- data/lib/rubocop/cop/when_then.rb +0 -17
- data/lib/rubocop/cop/word_array.rb +0 -37
- data/lib/rubocop/report/emacs_style.rb +0 -17
- data/lib/rubocop/report/plain_text.rb +0 -18
- data/lib/rubocop/report/report.rb +0 -44
- data/spec/rubocop/cops/access_control_spec.rb +0 -129
- data/spec/rubocop/cops/alias_spec.rb +0 -39
- data/spec/rubocop/cops/align_parameters_spec.rb +0 -197
- data/spec/rubocop/cops/and_or_spec.rb +0 -37
- data/spec/rubocop/cops/ascii_comments_spec.rb +0 -26
- data/spec/rubocop/cops/ascii_identifiers_spec.rb +0 -26
- data/spec/rubocop/cops/avoid_class_vars_spec.rb +0 -25
- data/spec/rubocop/cops/avoid_for_spec.rb +0 -35
- data/spec/rubocop/cops/avoid_global_vars_spec.rb +0 -32
- data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb +0 -18
- data/spec/rubocop/cops/avoid_perlisms_spec.rb +0 -44
- data/spec/rubocop/cops/block_comments_spec.rb +0 -25
- data/spec/rubocop/cops/blocks_spec.rb +0 -33
- data/spec/rubocop/cops/case_indentation_spec.rb +0 -86
- data/spec/rubocop/cops/class_and_module_camel_case_spec.rb +0 -44
- data/spec/rubocop/cops/class_methods_spec.rb +0 -49
- data/spec/rubocop/cops/collection_methods_spec.rb +0 -44
- data/spec/rubocop/cops/colon_method_call_spec.rb +0 -53
- data/spec/rubocop/cops/constant_name_spec.rb +0 -42
- data/spec/rubocop/cops/def_with_parentheses_spec.rb +0 -38
- data/spec/rubocop/cops/def_without_parentheses_spec.rb +0 -32
- data/spec/rubocop/cops/empty_line_between_defs_spec.rb +0 -83
- data/spec/rubocop/cops/empty_lines_spec.rb +0 -38
- data/spec/rubocop/cops/empty_literal_spec.rb +0 -90
- data/spec/rubocop/cops/encoding_spec.rb +0 -47
- data/spec/rubocop/cops/end_of_line_spec.rb +0 -23
- data/spec/rubocop/cops/ensure_return_spec.rb +0 -35
- data/spec/rubocop/cops/eval_spec.rb +0 -39
- data/spec/rubocop/cops/favor_join_spec.rb +0 -35
- data/spec/rubocop/cops/favor_modifier_spec.rb +0 -114
- data/spec/rubocop/cops/favor_percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/favor_sprintf_spec.rb +0 -51
- data/spec/rubocop/cops/favor_unless_over_negated_if_spec.rb +0 -62
- data/spec/rubocop/cops/favor_until_over_negated_while_spec.rb +0 -45
- data/spec/rubocop/cops/handle_exceptions_spec.rb +0 -34
- data/spec/rubocop/cops/hash_syntax_spec.rb +0 -49
- data/spec/rubocop/cops/if_with_semicolon_spec.rb +0 -23
- data/spec/rubocop/cops/leading_comment_space_spec.rb +0 -54
- data/spec/rubocop/cops/line_continuation_spec.rb +0 -24
- data/spec/rubocop/cops/line_length_spec.rb +0 -23
- data/spec/rubocop/cops/loop_spec.rb +0 -31
- data/spec/rubocop/cops/method_and_variable_snake_case_spec.rb +0 -93
- data/spec/rubocop/cops/method_length_spec.rb +0 -147
- data/spec/rubocop/cops/multiline_if_then_spec.rb +0 -56
- data/spec/rubocop/cops/new_lambda_literal_spec.rb +0 -22
- data/spec/rubocop/cops/not_spec.rb +0 -31
- data/spec/rubocop/cops/numeric_literals_spec.rb +0 -49
- data/spec/rubocop/cops/one_line_conditional_spec.rb +0 -16
- data/spec/rubocop/cops/op_method_spec.rb +0 -78
- data/spec/rubocop/cops/parameter_lists_spec.rb +0 -24
- data/spec/rubocop/cops/parentheses_around_condition_spec.rb +0 -61
- data/spec/rubocop/cops/percent_r_spec.rb +0 -29
- data/spec/rubocop/cops/reduce_arguments_spec.rb +0 -57
- data/spec/rubocop/cops/rescue_exception_spec.rb +0 -125
- data/spec/rubocop/cops/rescue_modifier_spec.rb +0 -37
- data/spec/rubocop/cops/semicolon_spec.rb +0 -88
- data/spec/rubocop/cops/single_line_methods_spec.rb +0 -50
- data/spec/rubocop/cops/space_after_colon_spec.rb +0 -27
- data/spec/rubocop/cops/space_after_comma_spec.rb +0 -29
- data/spec/rubocop/cops/space_after_control_keyword_spec.rb +0 -67
- data/spec/rubocop/cops/space_after_semicolon_spec.rb +0 -22
- data/spec/rubocop/cops/space_around_braces_spec.rb +0 -47
- data/spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb +0 -32
- data/spec/rubocop/cops/space_around_operators_spec.rb +0 -209
- data/spec/rubocop/cops/space_inside_brackets_spec.rb +0 -49
- data/spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb +0 -79
- data/spec/rubocop/cops/space_inside_parens_spec.rb +0 -31
- data/spec/rubocop/cops/string_literals_spec.rb +0 -47
- data/spec/rubocop/cops/symbol_array_spec.rb +0 -41
- data/spec/rubocop/cops/symbol_name_spec.rb +0 -119
- data/spec/rubocop/cops/syntax_spec.rb +0 -41
- data/spec/rubocop/cops/tab_spec.rb +0 -21
- data/spec/rubocop/cops/ternary_operator_spec.rb +0 -40
- data/spec/rubocop/cops/trailing_whitespace_spec.rb +0 -27
- data/spec/rubocop/cops/trivial_accessors_spec.rb +0 -329
- data/spec/rubocop/cops/unless_else_spec.rb +0 -29
- data/spec/rubocop/cops/variable_interpolation_spec.rb +0 -49
- data/spec/rubocop/cops/when_then_spec.rb +0 -38
- data/spec/rubocop/cops/word_array_spec.rb +0 -47
- data/spec/rubocop/reports/emacs_style_spec.rb +0 -25
- data/spec/rubocop/reports/report_spec.rb +0 -29
|
@@ -1,209 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe SpaceAroundOperators do
|
|
8
|
-
let(:space) { SpaceAroundOperators.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for assignment without space on both sides' do
|
|
11
|
-
inspect_source(space, ['x=0', 'y= 0', 'z =0'])
|
|
12
|
-
expect(space.offences.map(&:message)).to eq(
|
|
13
|
-
["Surrounding space missing for operator '='."] * 3)
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
it 'registers an offence for ternary operator without space' do
|
|
17
|
-
inspect_source(space, ['x == 0?1:2'])
|
|
18
|
-
expect(space.offences.map(&:message)).to eq(
|
|
19
|
-
["Surrounding space missing for operator '?'.",
|
|
20
|
-
"Surrounding space missing for operator ':'."])
|
|
21
|
-
end
|
|
22
|
-
|
|
23
|
-
it 'registers an offence in presence of modifier if statement' do
|
|
24
|
-
check_modifier('if')
|
|
25
|
-
end
|
|
26
|
-
|
|
27
|
-
it 'registers an offence in presence of modifier unless statement' do
|
|
28
|
-
check_modifier('unless')
|
|
29
|
-
end
|
|
30
|
-
|
|
31
|
-
it 'registers an offence in presence of modifier while statement' do
|
|
32
|
-
check_modifier('unless')
|
|
33
|
-
end
|
|
34
|
-
|
|
35
|
-
it 'registers an offence in presence of modifier until statement' do
|
|
36
|
-
check_modifier('unless')
|
|
37
|
-
end
|
|
38
|
-
|
|
39
|
-
def check_modifier(keyword)
|
|
40
|
-
src = ["a=1 #{keyword} condition",
|
|
41
|
-
'c=2']
|
|
42
|
-
inspect_source(space, src)
|
|
43
|
-
expect(space.offences.map(&:line_number)).to eq([1, 2])
|
|
44
|
-
expect(space.offences.map(&:message)).to eq(
|
|
45
|
-
["Surrounding space missing for operator '='."] * 2)
|
|
46
|
-
end
|
|
47
|
-
|
|
48
|
-
it 'registers an offence for binary operators that could be unary' do
|
|
49
|
-
inspect_source(space, ['a-3', 'x&0xff', 'z+0'])
|
|
50
|
-
expect(space.offences.map(&:message)).to eq(
|
|
51
|
-
["Surrounding space missing for operator '-'.",
|
|
52
|
-
"Surrounding space missing for operator '&'.",
|
|
53
|
-
"Surrounding space missing for operator '+'."])
|
|
54
|
-
end
|
|
55
|
-
|
|
56
|
-
it 'registers an offence for arguments to a method' do
|
|
57
|
-
inspect_source(space, ['puts 1+2'])
|
|
58
|
-
expect(space.offences.map(&:message)).to eq(
|
|
59
|
-
["Surrounding space missing for operator '+'."])
|
|
60
|
-
end
|
|
61
|
-
|
|
62
|
-
it 'accepts operator symbols' do
|
|
63
|
-
inspect_source(space, ['func(:-)'])
|
|
64
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
65
|
-
end
|
|
66
|
-
|
|
67
|
-
it 'accepts ranges' do
|
|
68
|
-
inspect_source(space, ['a, b = (1..2), (1...3)'])
|
|
69
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
70
|
-
end
|
|
71
|
-
|
|
72
|
-
it 'accepts scope operator' do
|
|
73
|
-
source = ['@io.class == Zlib::GzipWriter']
|
|
74
|
-
inspect_source(space, source)
|
|
75
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
76
|
-
end
|
|
77
|
-
|
|
78
|
-
it 'accepts ::Kernel::raise' do
|
|
79
|
-
source = ['::Kernel::raise IllegalBlockError.new']
|
|
80
|
-
inspect_source(space, source)
|
|
81
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
82
|
-
end
|
|
83
|
-
|
|
84
|
-
it 'accepts exclamation point negation' do
|
|
85
|
-
inspect_source(space, ['x = !a&&!b'])
|
|
86
|
-
expect(space.offences.map(&:message)).to eq(
|
|
87
|
-
["Surrounding space missing for operator '&&'."])
|
|
88
|
-
end
|
|
89
|
-
|
|
90
|
-
it 'accepts exclamation point definition' do
|
|
91
|
-
inspect_source(space, [' def !',
|
|
92
|
-
' !__getobj__',
|
|
93
|
-
' end'])
|
|
94
|
-
expect(space.offences).to be_empty
|
|
95
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
96
|
-
end
|
|
97
|
-
|
|
98
|
-
it 'accepts a unary' do
|
|
99
|
-
inspect_source(space,
|
|
100
|
-
[' def bm(label_width = 0, *labels, &blk)',
|
|
101
|
-
' benchmark(CAPTION, label_width, FORMAT,',
|
|
102
|
-
' *labels, &blk)',
|
|
103
|
-
' end',
|
|
104
|
-
'',
|
|
105
|
-
' def each &block',
|
|
106
|
-
' end',
|
|
107
|
-
'',
|
|
108
|
-
' def each *args',
|
|
109
|
-
' end',
|
|
110
|
-
''])
|
|
111
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
112
|
-
end
|
|
113
|
-
|
|
114
|
-
it 'accepts splat operator' do
|
|
115
|
-
inspect_source(space, ['return *list if options'])
|
|
116
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
117
|
-
end
|
|
118
|
-
|
|
119
|
-
it 'accepts def of operator' do
|
|
120
|
-
inspect_source(space, ['def +(other); end',
|
|
121
|
-
'def self.===(other); end'])
|
|
122
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
123
|
-
end
|
|
124
|
-
|
|
125
|
-
it 'accepts an operator at the end of a line' do
|
|
126
|
-
inspect_source(space,
|
|
127
|
-
["['Favor unless over if for negative ' +",
|
|
128
|
-
" 'conditions.'] * 2"])
|
|
129
|
-
expect(space.offences.map(&:message)).to eq([])
|
|
130
|
-
end
|
|
131
|
-
|
|
132
|
-
it 'accepts an assignment with spaces' do
|
|
133
|
-
inspect_source(space, ['x = 0'])
|
|
134
|
-
expect(space.offences).to be_empty
|
|
135
|
-
end
|
|
136
|
-
|
|
137
|
-
it 'registers an offence for operators without spaces' do
|
|
138
|
-
inspect_source(space,
|
|
139
|
-
['x+= a+b-c*d/e%f^g|h&i||j',
|
|
140
|
-
'y -=k&&l'])
|
|
141
|
-
expect(space.offences.map(&:message))
|
|
142
|
-
.to eq(["Surrounding space missing for operator '+='.",
|
|
143
|
-
"Surrounding space missing for operator '+'.",
|
|
144
|
-
"Surrounding space missing for operator '-'.",
|
|
145
|
-
"Surrounding space missing for operator '*'.",
|
|
146
|
-
"Surrounding space missing for operator '/'.",
|
|
147
|
-
"Surrounding space missing for operator '%'.",
|
|
148
|
-
"Surrounding space missing for operator '^'.",
|
|
149
|
-
"Surrounding space missing for operator '|'.",
|
|
150
|
-
"Surrounding space missing for operator '&'.",
|
|
151
|
-
"Surrounding space missing for operator '||'.",
|
|
152
|
-
"Surrounding space missing for operator '-='.",
|
|
153
|
-
"Surrounding space missing for operator '&&'."])
|
|
154
|
-
end
|
|
155
|
-
|
|
156
|
-
it 'accepts operators with spaces' do
|
|
157
|
-
inspect_source(space,
|
|
158
|
-
['x += a + b - c * d / e % f ^ g | h & i || j',
|
|
159
|
-
'y -= k && l'])
|
|
160
|
-
expect(space.offences.map(&:message)).to eq([])
|
|
161
|
-
end
|
|
162
|
-
|
|
163
|
-
it "accepts some operators that are exceptions and don't need spaces" do
|
|
164
|
-
inspect_source(space, ['(1..3)',
|
|
165
|
-
'ActionController::Base',
|
|
166
|
-
'each { |s, t| }'])
|
|
167
|
-
expect(space.offences.map(&:message)).to eq([])
|
|
168
|
-
end
|
|
169
|
-
|
|
170
|
-
it 'accepts an assignment followed by newline' do
|
|
171
|
-
inspect_source(space, ['x =', '0'])
|
|
172
|
-
expect(space.offences).to be_empty
|
|
173
|
-
end
|
|
174
|
-
|
|
175
|
-
it 'registers an offences for exponent operator with spaces' do
|
|
176
|
-
inspect_source(space, ['x = a * b ** 2'])
|
|
177
|
-
expect(space.offences.map(&:message)).to eq(
|
|
178
|
-
['Space around operator ** detected.'])
|
|
179
|
-
end
|
|
180
|
-
|
|
181
|
-
it 'accepts exponent operator without spaces' do
|
|
182
|
-
inspect_source(space, ['x = a * b**2'])
|
|
183
|
-
expect(space.offences).to be_empty
|
|
184
|
-
end
|
|
185
|
-
|
|
186
|
-
it 'accepts unary operators without space' do
|
|
187
|
-
inspect_source(space, ['[].map(&:size)',
|
|
188
|
-
'-3',
|
|
189
|
-
'x = +2'])
|
|
190
|
-
expect(space.offences.map(&:message)).to eq([])
|
|
191
|
-
end
|
|
192
|
-
|
|
193
|
-
it 'accepts argument default values without space' do
|
|
194
|
-
# These are handled by SpaceAroundEqualsInParameterDefault,
|
|
195
|
-
# so SpaceAroundOperators leaves them alone.
|
|
196
|
-
inspect_source(space,
|
|
197
|
-
['def init(name=nil)',
|
|
198
|
-
'end'])
|
|
199
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
200
|
-
end
|
|
201
|
-
|
|
202
|
-
it 'accepts the construct class <<self with no space after <<' do
|
|
203
|
-
inspect_source(space, ['class <<self',
|
|
204
|
-
'end'])
|
|
205
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
206
|
-
end
|
|
207
|
-
end
|
|
208
|
-
end
|
|
209
|
-
end
|
|
@@ -1,49 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe SpaceInsideBrackets do
|
|
8
|
-
let(:space) { SpaceInsideBrackets.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for an array literal with spaces inside' do
|
|
11
|
-
inspect_source(space, ['a = [1, 2 ]',
|
|
12
|
-
'b = [ 1, 2]'])
|
|
13
|
-
expect(space.offences.map(&:message)).to eq(
|
|
14
|
-
['Space inside square brackets detected.',
|
|
15
|
-
'Space inside square brackets detected.'])
|
|
16
|
-
end
|
|
17
|
-
|
|
18
|
-
it 'accepts space inside strings within square brackets' do
|
|
19
|
-
inspect_source(space, ["['Encoding:',",
|
|
20
|
-
" ' Enabled: false']"])
|
|
21
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
22
|
-
end
|
|
23
|
-
|
|
24
|
-
it 'accepts space inside square brackets if on its own row' do
|
|
25
|
-
inspect_source(space, ['a = [',
|
|
26
|
-
' 1, 2',
|
|
27
|
-
' ]'])
|
|
28
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
29
|
-
end
|
|
30
|
-
|
|
31
|
-
it 'accepts square brackets as method name' do
|
|
32
|
-
inspect_source(space, ['def Vector.[](*array)',
|
|
33
|
-
'end'])
|
|
34
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
35
|
-
end
|
|
36
|
-
|
|
37
|
-
it 'accepts square brackets called with method call syntax' do
|
|
38
|
-
inspect_source(space, ['subject.[](0)'])
|
|
39
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
40
|
-
end
|
|
41
|
-
|
|
42
|
-
it 'only reports a single space once' do
|
|
43
|
-
inspect_source(space, ['[ ]'])
|
|
44
|
-
expect(space.offences.map(&:message)).to eq(
|
|
45
|
-
['Space inside square brackets detected.'])
|
|
46
|
-
end
|
|
47
|
-
end
|
|
48
|
-
end
|
|
49
|
-
end
|
|
@@ -1,79 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe SpaceInsideHashLiteralBraces do
|
|
8
|
-
let(:sihlb) { SpaceInsideHashLiteralBraces.new }
|
|
9
|
-
before do
|
|
10
|
-
SpaceInsideHashLiteralBraces.config = {
|
|
11
|
-
'EnforcedStyleIsWithSpaces' => true
|
|
12
|
-
}
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
it 'registers an offence for hashes with no spaces by default' do
|
|
16
|
-
inspect_source(sihlb,
|
|
17
|
-
['h = {a: 1, b: :two}',
|
|
18
|
-
'h = {a => 1 }'])
|
|
19
|
-
expect(sihlb.offences.map(&:message)).to eq(
|
|
20
|
-
['Space inside hash literal braces missing.'] * 3)
|
|
21
|
-
end
|
|
22
|
-
|
|
23
|
-
it 'registers an offence for hashes with no spaces if so configured' do
|
|
24
|
-
inspect_source(sihlb,
|
|
25
|
-
['h = {a: 1, b: 2}',
|
|
26
|
-
'h = {a => 1 }'])
|
|
27
|
-
expect(sihlb.offences.map(&:message)).to eq(
|
|
28
|
-
['Space inside hash literal braces missing.'] * 3)
|
|
29
|
-
end
|
|
30
|
-
|
|
31
|
-
it 'registers an offence for hashes with spaces if so configured' do
|
|
32
|
-
SpaceInsideHashLiteralBraces.config['EnforcedStyleIsWithSpaces'] =
|
|
33
|
-
false
|
|
34
|
-
inspect_source(sihlb,
|
|
35
|
-
['h = { a: 1, b: 2 }'])
|
|
36
|
-
expect(sihlb.offences.map(&:message)).to eq(
|
|
37
|
-
['Space inside hash literal braces detected.'] * 2)
|
|
38
|
-
end
|
|
39
|
-
|
|
40
|
-
it 'accepts hashes with spaces by default' do
|
|
41
|
-
inspect_source(sihlb,
|
|
42
|
-
['h = { a: 1, b: 2 }',
|
|
43
|
-
'h = { a => 1 }'])
|
|
44
|
-
expect(sihlb.offences.map(&:message)).to be_empty
|
|
45
|
-
end
|
|
46
|
-
|
|
47
|
-
it 'accepts hashes with no spaces if so configured' do
|
|
48
|
-
SpaceInsideHashLiteralBraces.config['EnforcedStyleIsWithSpaces'] =
|
|
49
|
-
false
|
|
50
|
-
inspect_source(sihlb,
|
|
51
|
-
['h = {a: 1, b: 2}',
|
|
52
|
-
'h = {a => 1}'])
|
|
53
|
-
expect(sihlb.offences.map(&:message)).to be_empty
|
|
54
|
-
end
|
|
55
|
-
|
|
56
|
-
it 'accepts empty hashes without spaces by default' do
|
|
57
|
-
inspect_source(sihlb, ['h = {}'])
|
|
58
|
-
expect(sihlb.offences).to be_empty
|
|
59
|
-
end
|
|
60
|
-
|
|
61
|
-
it 'accepts empty hashes without spaces if configured false' do
|
|
62
|
-
SpaceInsideHashLiteralBraces.config['EnforcedStyleIsWithSpaces'] =
|
|
63
|
-
false
|
|
64
|
-
inspect_source(sihlb, ['h = {}'])
|
|
65
|
-
expect(sihlb.offences).to be_empty
|
|
66
|
-
end
|
|
67
|
-
|
|
68
|
-
it 'accepts empty hashes without spaces even if configured true' do
|
|
69
|
-
inspect_source(sihlb, ['h = {}'])
|
|
70
|
-
expect(sihlb.offences).to be_empty
|
|
71
|
-
end
|
|
72
|
-
|
|
73
|
-
it 'accepts hash literals with no braces' do
|
|
74
|
-
inspect_source(sihlb, ['x(a: b.c)'])
|
|
75
|
-
expect(sihlb.offences).to be_empty
|
|
76
|
-
end
|
|
77
|
-
end
|
|
78
|
-
end
|
|
79
|
-
end
|
|
@@ -1,31 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe SpaceInsideParens do
|
|
8
|
-
let(:space) { SpaceInsideParens.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for spaces inside parens' do
|
|
11
|
-
inspect_source(space, ['f( 3)',
|
|
12
|
-
'g(3 )'])
|
|
13
|
-
expect(space.offences.map(&:message)).to eq(
|
|
14
|
-
['Space inside parentheses detected.',
|
|
15
|
-
'Space inside parentheses detected.'])
|
|
16
|
-
end
|
|
17
|
-
|
|
18
|
-
it 'accepts parentheses in block parameter list' do
|
|
19
|
-
inspect_source(space,
|
|
20
|
-
['list.inject(Tms.new) { |sum, (label, item)|',
|
|
21
|
-
'}'])
|
|
22
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
23
|
-
end
|
|
24
|
-
|
|
25
|
-
it 'accepts parentheses with no spaces' do
|
|
26
|
-
inspect_source(space, ['split("\n")'])
|
|
27
|
-
expect(space.offences.map(&:message)).to be_empty
|
|
28
|
-
end
|
|
29
|
-
end
|
|
30
|
-
end
|
|
31
|
-
end
|
|
@@ -1,47 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe StringLiterals do
|
|
8
|
-
let(:sl) { StringLiterals.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for double quotes when single quotes suffice' do
|
|
11
|
-
inspect_source(sl, ['s = "abc"'])
|
|
12
|
-
expect(sl.offences.map(&:message)).to eq(
|
|
13
|
-
["Prefer single-quoted strings when you don't need string " +
|
|
14
|
-
'interpolation or special symbols.'])
|
|
15
|
-
end
|
|
16
|
-
|
|
17
|
-
it 'accepts double quotes when they are needed' do
|
|
18
|
-
src = ['a = "\n"',
|
|
19
|
-
'b = "#{encode_severity}:#{sprintf("%3d", line_number)}: #{m}"',
|
|
20
|
-
'c = "\'"',
|
|
21
|
-
'd = "#@test"',
|
|
22
|
-
'e = "#$test"',
|
|
23
|
-
'f = "#@@test"']
|
|
24
|
-
inspect_source(sl, src)
|
|
25
|
-
expect(sl.offences.map(&:message)).to be_empty
|
|
26
|
-
end
|
|
27
|
-
|
|
28
|
-
it 'accepts double quotes with some other special symbols' do
|
|
29
|
-
pending
|
|
30
|
-
# "Substitutions in double-quoted strings"
|
|
31
|
-
# http://www.ruby-doc.org/docs/ProgrammingRuby/html/language.html
|
|
32
|
-
src = ['g = "\xf9"']
|
|
33
|
-
inspect_source(sl, src)
|
|
34
|
-
expect(sl.offences.map(&:message)).to be_empty
|
|
35
|
-
end
|
|
36
|
-
|
|
37
|
-
it 'can handle double quotes within embedded expression' do
|
|
38
|
-
# This seems to be a Parser bug
|
|
39
|
-
pending do
|
|
40
|
-
src = ['"#{"A"}"']
|
|
41
|
-
inspect_source(sl, src)
|
|
42
|
-
expect(sl.offences.map(&:message)).to be_empty
|
|
43
|
-
end
|
|
44
|
-
end
|
|
45
|
-
end
|
|
46
|
-
end
|
|
47
|
-
end
|
|
@@ -1,41 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe SymbolArray do
|
|
8
|
-
let(:sa) { SymbolArray.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for arrays of symbols', { ruby: 2.0 } do
|
|
11
|
-
inspect_source(sa,
|
|
12
|
-
['[:one, :two, :three]'])
|
|
13
|
-
expect(sa.offences.size).to eq(1)
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
it 'does not reg an offence for array with non-syms', { ruby: 2.0 } do
|
|
17
|
-
inspect_source(sa,
|
|
18
|
-
['[:one, :two, "three"]'])
|
|
19
|
-
expect(sa.offences).to be_empty
|
|
20
|
-
end
|
|
21
|
-
|
|
22
|
-
it 'does not reg an offence for array starting with %i', { ruby: 2.0 } do
|
|
23
|
-
inspect_source(sa,
|
|
24
|
-
['%i(one two three)'])
|
|
25
|
-
expect(sa.offences).to be_empty
|
|
26
|
-
end
|
|
27
|
-
|
|
28
|
-
it 'does not reg an offence for array with one element', { ruby: 2.0 } do
|
|
29
|
-
inspect_source(sa,
|
|
30
|
-
['[:three]'])
|
|
31
|
-
expect(sa.offences).to be_empty
|
|
32
|
-
end
|
|
33
|
-
|
|
34
|
-
it 'does nothing on Ruby 1.9', { ruby: 1.9 } do
|
|
35
|
-
inspect_source(sa,
|
|
36
|
-
['[:one, :two, :three]'])
|
|
37
|
-
expect(sa.offences).to be_empty
|
|
38
|
-
end
|
|
39
|
-
end
|
|
40
|
-
end
|
|
41
|
-
end
|
|
@@ -1,119 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe SymbolName do
|
|
8
|
-
let(:symbol_name) { SymbolName.new }
|
|
9
|
-
|
|
10
|
-
before do
|
|
11
|
-
SymbolName.config = Config.default_configuration.for_cop('SymbolName')
|
|
12
|
-
end
|
|
13
|
-
|
|
14
|
-
context 'when AllowCamelCase is true' do
|
|
15
|
-
before do
|
|
16
|
-
SymbolName.config = {
|
|
17
|
-
'AllowCamelCase' => true
|
|
18
|
-
}
|
|
19
|
-
end
|
|
20
|
-
|
|
21
|
-
it 'does not register an offence for camel case in names' do
|
|
22
|
-
inspect_source(symbol_name,
|
|
23
|
-
['test = :BadIdea'])
|
|
24
|
-
expect(symbol_name.offences).to be_empty
|
|
25
|
-
end
|
|
26
|
-
end
|
|
27
|
-
|
|
28
|
-
context 'when AllowCamelCase is false' do
|
|
29
|
-
before do
|
|
30
|
-
SymbolName.config = {
|
|
31
|
-
'AllowCamelCase' => false
|
|
32
|
-
}
|
|
33
|
-
end
|
|
34
|
-
|
|
35
|
-
it 'registers an offence for camel case in names' do
|
|
36
|
-
inspect_source(symbol_name,
|
|
37
|
-
['test = :BadIdea'])
|
|
38
|
-
expect(symbol_name.offences.map(&:message)).to eq(
|
|
39
|
-
['Use snake_case for symbols.'])
|
|
40
|
-
end
|
|
41
|
-
end
|
|
42
|
-
|
|
43
|
-
it 'registers an offence for symbol used as hash label' do
|
|
44
|
-
inspect_source(symbol_name,
|
|
45
|
-
['{ KEY_ONE: 1, KEY_TWO: 2 }'])
|
|
46
|
-
expect(symbol_name.offences.map(&:message)).to eq(
|
|
47
|
-
['Use snake_case for symbols.'] * 2)
|
|
48
|
-
end
|
|
49
|
-
|
|
50
|
-
it 'accepts snake case in names' do
|
|
51
|
-
inspect_source(symbol_name,
|
|
52
|
-
['test = :good_idea'])
|
|
53
|
-
expect(symbol_name.offences).to be_empty
|
|
54
|
-
end
|
|
55
|
-
|
|
56
|
-
it 'accepts snake case in hash label names' do
|
|
57
|
-
inspect_source(symbol_name,
|
|
58
|
-
['{ one: 1, one_more_3: 2 }'])
|
|
59
|
-
expect(symbol_name.offences).to be_empty
|
|
60
|
-
end
|
|
61
|
-
|
|
62
|
-
it 'accepts snake case with a prefix @ in names' do
|
|
63
|
-
inspect_source(symbol_name,
|
|
64
|
-
['test = :@good_idea'])
|
|
65
|
-
expect(symbol_name.offences).to be_empty
|
|
66
|
-
end
|
|
67
|
-
|
|
68
|
-
it 'accepts snake case with ? suffix' do
|
|
69
|
-
inspect_source(symbol_name,
|
|
70
|
-
['test = :good_idea?'])
|
|
71
|
-
expect(symbol_name.offences).to be_empty
|
|
72
|
-
end
|
|
73
|
-
|
|
74
|
-
it 'accepts snake case with ! suffix' do
|
|
75
|
-
inspect_source(symbol_name,
|
|
76
|
-
['test = :good_idea!'])
|
|
77
|
-
expect(symbol_name.offences).to be_empty
|
|
78
|
-
end
|
|
79
|
-
|
|
80
|
-
it 'accepts snake case with = suffix' do
|
|
81
|
-
inspect_source(symbol_name,
|
|
82
|
-
['test = :good_idea='])
|
|
83
|
-
expect(symbol_name.offences).to be_empty
|
|
84
|
-
end
|
|
85
|
-
|
|
86
|
-
it 'accepts special cases - !, [] and **' do
|
|
87
|
-
inspect_source(symbol_name,
|
|
88
|
-
['test = :**',
|
|
89
|
-
'test = :!',
|
|
90
|
-
'test = :[]',
|
|
91
|
-
'test = :[]='])
|
|
92
|
-
expect(symbol_name.offences).to be_empty
|
|
93
|
-
end
|
|
94
|
-
|
|
95
|
-
it 'accepts special cases - ==, <=>, >, <, >=, <=' do
|
|
96
|
-
inspect_source(symbol_name,
|
|
97
|
-
['test = :==',
|
|
98
|
-
'test = :<=>',
|
|
99
|
-
'test = :>',
|
|
100
|
-
'test = :<',
|
|
101
|
-
'test = :>=',
|
|
102
|
-
'test = :<='])
|
|
103
|
-
expect(symbol_name.offences).to be_empty
|
|
104
|
-
end
|
|
105
|
-
|
|
106
|
-
it 'can handle an alias of and operator without crashing' do
|
|
107
|
-
inspect_source(symbol_name,
|
|
108
|
-
['alias + add'])
|
|
109
|
-
expect(symbol_name.offences).to be_empty
|
|
110
|
-
end
|
|
111
|
-
|
|
112
|
-
it 'registers an offence for SCREAMING_symbol_name' do
|
|
113
|
-
inspect_source(symbol_name,
|
|
114
|
-
['test = :BAD_IDEA'])
|
|
115
|
-
expect(symbol_name.offences.size).to eq(1)
|
|
116
|
-
end
|
|
117
|
-
end
|
|
118
|
-
end
|
|
119
|
-
end
|
|
@@ -1,41 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe Syntax do
|
|
8
|
-
let(:sc) { Syntax.new }
|
|
9
|
-
|
|
10
|
-
if RUBY_ENGINE == 'ruby'
|
|
11
|
-
it 'registers an offence for unused variables', ruby: 2.0 do
|
|
12
|
-
source = "x = 5\nputs 10"
|
|
13
|
-
Dir.mktmpdir do |tmpdir|
|
|
14
|
-
path = File.join(tmpdir, 'file.rb')
|
|
15
|
-
File.open(path, 'w') { |f| f.write(source) }
|
|
16
|
-
sc.inspect_file(path)
|
|
17
|
-
end
|
|
18
|
-
expect(sc.offences.size).to eq(1)
|
|
19
|
-
expect(sc.offences.first.message)
|
|
20
|
-
.to eq('Assigned but unused variable - x')
|
|
21
|
-
end
|
|
22
|
-
|
|
23
|
-
describe '#process_line' do
|
|
24
|
-
it 'processes warnings correctly' do
|
|
25
|
-
l, s, m = sc.process_line('admin.rb:1: warning: possibly useless')
|
|
26
|
-
expect(l).to eq(1)
|
|
27
|
-
expect(s).to eq(:warning)
|
|
28
|
-
expect(m).to eq('Possibly useless')
|
|
29
|
-
end
|
|
30
|
-
|
|
31
|
-
it 'processes errors correctly' do
|
|
32
|
-
l, s, m = sc.process_line('admin.rb:1: unterminated string meets')
|
|
33
|
-
expect(l).to eq(1)
|
|
34
|
-
expect(s).to eq(:error)
|
|
35
|
-
expect(m).to eq('Unterminated string meets')
|
|
36
|
-
end
|
|
37
|
-
end
|
|
38
|
-
end
|
|
39
|
-
end
|
|
40
|
-
end
|
|
41
|
-
end
|
|
@@ -1,21 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe Tab do
|
|
8
|
-
let(:tab) { Tab.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for a line indented with tab' do
|
|
11
|
-
tab.inspect(["\tx = 0"], nil, nil, nil)
|
|
12
|
-
expect(tab.offences.size).to eq(1)
|
|
13
|
-
end
|
|
14
|
-
|
|
15
|
-
it 'accepts a line with tab in a string' do
|
|
16
|
-
tab.inspect(["(x = \"\t\")"], nil, nil, nil)
|
|
17
|
-
expect(tab.offences).to be_empty
|
|
18
|
-
end
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
end
|
|
@@ -1,40 +0,0 @@
|
|
|
1
|
-
# encoding: utf-8
|
|
2
|
-
|
|
3
|
-
require 'spec_helper'
|
|
4
|
-
|
|
5
|
-
module Rubocop
|
|
6
|
-
module Cop
|
|
7
|
-
describe MultilineTernaryOperator do
|
|
8
|
-
let(:op) { MultilineTernaryOperator.new }
|
|
9
|
-
|
|
10
|
-
it 'registers an offence for a multiline ternary operator expression' do
|
|
11
|
-
inspect_source(op, ['a = cond ?',
|
|
12
|
-
' b : c'])
|
|
13
|
-
expect(op.offences.size).to eq(1)
|
|
14
|
-
end
|
|
15
|
-
|
|
16
|
-
it 'accepts a single line ternary operator expression' do
|
|
17
|
-
inspect_source(op, ['a = cond ? b : c'])
|
|
18
|
-
expect(op.offences).to be_empty
|
|
19
|
-
end
|
|
20
|
-
end
|
|
21
|
-
|
|
22
|
-
describe NestedTernaryOperator do
|
|
23
|
-
let(:op) { NestedTernaryOperator.new }
|
|
24
|
-
|
|
25
|
-
it 'registers an offence for a nested ternary operator expression' do
|
|
26
|
-
inspect_source(op, ['a ? (b ? b1 : b2) : a2'])
|
|
27
|
-
expect(op.offences.size).to eq(1)
|
|
28
|
-
end
|
|
29
|
-
|
|
30
|
-
it 'accepts a non-nested ternary operator within an if' do
|
|
31
|
-
inspect_source(op, ['a = if x',
|
|
32
|
-
' cond ? b : c',
|
|
33
|
-
'else',
|
|
34
|
-
' d',
|
|
35
|
-
'end'])
|
|
36
|
-
expect(op.offences).to be_empty
|
|
37
|
-
end
|
|
38
|
-
end
|
|
39
|
-
end
|
|
40
|
-
end
|