rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb

@@ -1,171 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::FactoryBot::CreateList, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) do
-    { 'EnforcedStyle' => enforced_style }
-  end
-
-  context 'when EnforcedStyle is :create_list' do
-    let(:enforced_style) { :create_list }
-
-    it 'flags usage of n.times with no arguments' do
-      expect_offense(<<-RUBY)
-        3.times { create :user }
-        ^^^^^^^ Prefer create_list.
-      RUBY
-    end
-
-    it 'flags usage of n.times when FactoryGirl.create is used' do
-      expect_offense(<<-RUBY)
-        3.times { FactoryGirl.create :user }
-        ^^^^^^^ Prefer create_list.
-      RUBY
-    end
-
-    it 'flags usage of n.times when FactoryBot.create is used' do
-      expect_offense(<<-RUBY)
-        3.times { FactoryBot.create :user }
-        ^^^^^^^ Prefer create_list.
-      RUBY
-    end
-
-    it 'ignores create method of other object' do
-      expect_no_offenses(<<-RUBY)
-        3.times { SomeFactory.create :user }
-      RUBY
-    end
-
-    it 'ignores create in other block' do
-      expect_no_offenses(<<-RUBY)
-        allow(User).to receive(:create) { create :user }
-      RUBY
-    end
-
-    it 'ignores n.times with argument' do
-      expect_no_offenses(<<-RUBY)
-        3.times { |n| create :user, created_at: n.days.ago }
-      RUBY
-    end
-
-    it 'ignores n.times when there is no create call inside' do
-      expect_no_offenses(<<-RUBY)
-        3.times { do_something }
-      RUBY
-    end
-
-    it 'ignores n.times when there is other calls but create' do
-      expect_no_offenses(<<-RUBY)
-        used_passwords = []
-        3.times do
-          u = create :user
-          expect(used_passwords).not_to include(u.password)
-          used_passwords << u.password
-        end
-      RUBY
-    end
-
-    it 'flags FactoryGirl.create calls with a block' do
-      expect_offense(<<-RUBY)
-        3.times do
-        ^^^^^^^ Prefer create_list.
-          create(:user) { |user| create :account, user: user }
-        end
-      RUBY
-    end
-
-    include_examples 'autocorrect',
-                     '5.times { create :user }',
-                     'create_list :user, 5'
-
-    include_examples 'autocorrect',
-                     '5.times { create(:user, :trait) }',
-                     'create_list(:user, 5, :trait)'
-
-    include_examples 'autocorrect',
-                     '5.times { create :user, :trait, key: val }',
-                     'create_list :user, 5, :trait, key: val'
-
-    include_examples 'autocorrect',
-                     '5.times { FactoryGirl.create :user }',
-                     'FactoryGirl.create_list :user, 5'
-
-    bad_code = <<-RUBY
-      3.times do
-        create(:user, :trait) { |user| create :account, user: user }
-      end
-    RUBY
-
-    good_code = <<-RUBY
-      create_list(:user, 3, :trait) { |user| create :account, user: user }
-    RUBY
-
-    include_examples 'autocorrect', bad_code, good_code
-
-    bad_code = <<-RUBY
-      3.times do
-        create(:user, :trait) do |user|
-          create :account, user: user
-          create :profile, user: user
-        end
-      end
-    RUBY
-
-    good_code = <<-RUBY
-      create_list(:user, 3, :trait) do |user|
-          create :account, user: user
-          create :profile, user: user
-      end
-    RUBY
-
-    include_examples 'autocorrect', bad_code, good_code
-  end
-
-  context 'when EnforcedStyle is :n_times' do
-    let(:enforced_style) { :n_times }
-
-    it 'flags usage of create_list' do
-      expect_offense(<<-RUBY)
-        create_list :user, 3
-        ^^^^^^^^^^^ Prefer 3.times.
-      RUBY
-    end
-
-    it 'flags usage of FactoryGirl.create_list' do
-      expect_offense(<<-RUBY)
-       FactoryGirl.create_list :user, 3
-                   ^^^^^^^^^^^ Prefer 3.times.
-      RUBY
-    end
-
-    it 'flags usage of FactoryGirl.create_list with a block' do
-      expect_offense(<<-RUBY)
-       FactoryGirl.create_list(:user, 3) { |user| user.points = rand(1000) }
-                   ^^^^^^^^^^^ Prefer 3.times.
-      RUBY
-    end
-
-    it 'ignores create method of other object' do
-      expect_no_offenses(<<-RUBY)
-        SomeFactory.create_list :user, 3
-      RUBY
-    end
-
-    include_examples 'autocorrect',
-                     'create_list :user, 5',
-                     '5.times { create :user }'
-
-    include_examples 'autocorrect',
-                     'create_list(:user, 5, :trait)',
-                     '5.times { create(:user, :trait) }'
-
-    include_examples 'autocorrect',
-                     'create_list :user, 5, :trait, key: val',
-                     '5.times { create :user, :trait, key: val }'
-
-    include_examples 'autocorrect',
-                     'FactoryGirl.create_list :user, 5',
-                     '5.times { FactoryGirl.create :user }'
-  end
-end

data/spec/rubocop/cop/rspec/file_path_spec.rb

@@ -1,200 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::FilePath, :config do
-  subject(:cop) { described_class.new(config) }
-
-  it 'registers an offense for a bad path' do
-    expect_offense(<<-RUBY, 'wrong_path_foo_spec.rb')
-      describe MyClass, 'foo' do; end
-      ^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
-    RUBY
-  end
-
-  it 'registers an offense for a wrong class but a correct method' do
-    expect_offense(<<-RUBY, 'wrong_class_foo_spec.rb')
-      describe MyClass, '#foo' do; end
-      ^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
-    RUBY
-  end
-
-  it 'registers an offense for a repeated .rb' do
-    expect_offense(<<-RUBY, 'my_class/foo_spec.rb.rb')
-      describe MyClass, '#foo' do; end
-      ^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
-    RUBY
-  end
-
-  it 'registers an offense for a file missing a .rb' do
-    expect_offense(<<-RUBY, 'my_class/foo_specorb')
-      describe MyClass, '#foo' do; end
-      ^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
-    RUBY
-  end
-
-  it 'registers an offense for a wrong class and highlights metadata' do
-    expect_offense(<<-RUBY, 'wrong_class_foo_spec.rb')
-      describe MyClass, '#foo', blah: :blah do; end
-      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
-    RUBY
-  end
-
-  it 'registers an offense for a wrong class name' do
-    expect_offense(<<-RUBY, 'wrong_class_spec.rb')
-      describe MyClass do; end
-      ^^^^^^^^^^^^^^^^ Spec path should end with `my_class*_spec.rb`.
-    RUBY
-  end
-
-  it 'registers an offense for a wrong class name with a symbol argument' do
-    expect_offense(<<-RUBY, 'wrong_class_spec.rb')
-      describe MyClass, :foo do; end
-      ^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*_spec.rb`.
-    RUBY
-  end
-
-  it 'registers an offense for a file missing _spec' do
-    expect_offense(<<-RUBY, 'user.rb')
-      describe User do; end
-      ^^^^^^^^^^^^^ Spec path should end with `user*_spec.rb`.
-    RUBY
-  end
-
-  it 'skips specs that do not describe a class / method' do
-    expect_no_offenses(<<-RUBY, 'some/class/spec.rb')
-      describe 'Test something' do; end
-    RUBY
-  end
-
-  it 'skips specs that do have multiple top level describes' do
-    expect_no_offenses(<<-RUBY, 'some/class/spec.rb')
-      describe MyClass, 'do_this' do; end
-      describe MyClass, 'do_that' do; end
-    RUBY
-  end
-
-  it 'checks class specs' do
-    expect_no_offenses(<<-RUBY, 'some/class_spec.rb')
-      describe Some::Class do; end
-    RUBY
-  end
-
-  it 'allows different parent directories' do
-    expect_no_offenses(<<-RUBY, 'parent_dir/some/class_spec.rb')
-      describe Some::Class do; end
-    RUBY
-  end
-
-  it 'handles CamelCaps class names' do
-    expect_no_offenses(<<-RUBY, 'my_class_spec.rb')
-      describe MyClass do; end
-    RUBY
-  end
-
-  it 'handles ACRONYMClassNames' do
-    expect_no_offenses(<<-RUBY, 'abc_one/two_spec.rb')
-      describe ABCOne::Two do; end
-    RUBY
-  end
-
-  it 'handles ALLCAPS class names' do
-    expect_no_offenses(<<-RUBY, 'allcaps_spec.rb')
-      describe ALLCAPS do; end
-    RUBY
-  end
-
-  it 'handles alphanumeric class names' do
-    expect_no_offenses(<<-RUBY, 'ipv4_and_ipv6_spec.rb')
-      describe IPV4AndIPV6 do; end
-    RUBY
-  end
-
-  it 'checks instance methods' do
-    expect_no_offenses(<<-RUBY, 'some/class/inst_spec.rb')
-      describe Some::Class, '#inst' do; end
-    RUBY
-  end
-
-  it 'checks class methods' do
-    expect_no_offenses(<<-RUBY, 'some/class/inst_spec.rb')
-      describe Some::Class, '.inst' do; end
-    RUBY
-  end
-
-  it 'allows flat hierarchies for instance methods' do
-    expect_no_offenses(<<-RUBY, 'some/class_inst_spec.rb')
-      describe Some::Class, '#inst' do; end
-    RUBY
-  end
-
-  it 'allows flat hierarchies for class methods' do
-    expect_no_offenses(<<-RUBY, 'some/class_inst_spec.rb')
-      describe Some::Class, '.inst' do; end
-    RUBY
-  end
-
-  it 'allows subdirs for instance methods' do
-    filename = 'some/class/instance_methods/inst_spec.rb'
-    expect_no_offenses(<<-RUBY, filename)
-      describe Some::Class, '#inst' do; end
-    RUBY
-  end
-
-  it 'allows subdirs for class methods' do
-    filename = 'some/class/class_methods/inst_spec.rb'
-    expect_no_offenses(<<-RUBY, filename)
-      describe Some::Class, '.inst' do; end
-    RUBY
-  end
-
-  it 'ignores non-alphanumeric characters' do
-    expect_no_offenses(<<-RUBY, 'some/class/pred_spec.rb')
-      describe Some::Class, '#pred?' do; end
-    RUBY
-  end
-
-  it 'allows bang method' do
-    expect_no_offenses(<<-RUBY, 'some/class/bang_spec.rb')
-      describe Some::Class, '#bang!' do; end
-    RUBY
-  end
-
-  it 'allows flexibility with predicates' do
-    filename = 'some/class/thing_predicate_spec.rb'
-    expect_no_offenses(<<-RUBY, filename)
-      describe Some::Class, '#thing?' do; end
-    RUBY
-  end
-
-  it 'allows flexibility with operators' do
-    filename = 'my_little_class/spaceship_operator_spec.rb'
-    expect_no_offenses(<<-RUBY, filename)
-      describe MyLittleClass, '#<=>' do; end
-    RUBY
-  end
-
-  context 'when configured with CustomTransform' do
-    let(:cop_config) { { 'CustomTransform' => { 'FooFoo' => 'foofoo' } } }
-
-    it 'respects custom module name transformation' do
-      expect_no_offenses(<<-RUBY, 'foofoo/some/class/bar_spec.rb')
-        describe FooFoo::Some::Class, '#bar' do; end
-      RUBY
-    end
-
-    it 'ignores routing specs' do
-      expect_no_offenses(<<-RUBY, 'foofoo/some/class/bar_spec.rb')
-        describe MyController, "#foo", type: :routing do; end
-      RUBY
-    end
-  end
-
-  context 'when configured with IgnoreMethods' do
-    let(:cop_config) { { 'IgnoreMethods' => true } }
-
-    it 'does not care about the described method' do
-      expect_no_offenses(<<-RUBY, 'my_class_spec.rb')
-        describe MyClass, '#look_here_a_method' do; end
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/focus_spec.rb

@@ -1,139 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::Focus do
-  subject(:cop) { described_class.new }
-
-  # rubocop:disable RSpec/ExampleLength
-  it 'flags all rspec example blocks with that include `focus: true`' do
-    expect_offense(<<-RUBY)
-      example 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      xit 'test', meta: true, focus: true do; end
-                              ^^^^^^^^^^^ Focused spec found.
-      describe 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      RSpec.describe 'test', meta: true, focus: true do; end
-                                         ^^^^^^^^^^^ Focused spec found.
-      it 'test', meta: true, focus: true do; end
-                             ^^^^^^^^^^^ Focused spec found.
-      xspecify 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      specify 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      example_group 'test', meta: true, focus: true do; end
-                                        ^^^^^^^^^^^ Focused spec found.
-      scenario 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      xexample 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      xdescribe 'test', meta: true, focus: true do; end
-                                    ^^^^^^^^^^^ Focused spec found.
-      context 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      xcontext 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      feature 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      xfeature 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      xscenario 'test', meta: true, focus: true do; end
-                                    ^^^^^^^^^^^ Focused spec found.
-    RUBY
-  end
-
-  it 'flags all rspec example blocks that include `:focus`' do
-    expect_offense(<<-RUBY)
-      example_group 'test', :focus do; end
-                            ^^^^^^ Focused spec found.
-      feature 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      xexample 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      xdescribe 'test', :focus do; end
-                        ^^^^^^ Focused spec found.
-      xscenario 'test', :focus do; end
-                        ^^^^^^ Focused spec found.
-      specify 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      example 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      xfeature 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      xspecify 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      scenario 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      describe 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      RSpec.describe 'test', :focus do; end
-                             ^^^^^^ Focused spec found.
-      xit 'test', :focus do; end
-                  ^^^^^^ Focused spec found.
-      context 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      xcontext 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      it 'test', :focus do; end
-                 ^^^^^^ Focused spec found.
-    RUBY
-  end
-  # rubocop:enable RSpec/ExampleLength
-
-  it 'does not flag unfocused specs' do
-    expect_no_offenses(<<-RUBY)
-      xcontext      'test' do; end
-      xscenario     'test' do; end
-      xspecify      'test' do; end
-      describe      'test' do; end
-      example       'test' do; end
-      xexample      'test' do; end
-      scenario      'test' do; end
-      specify       'test' do; end
-      xit           'test' do; end
-      feature       'test' do; end
-      xfeature      'test' do; end
-      context       'test' do; end
-      it            'test' do; end
-      example_group 'test' do; end
-      xdescribe     'test' do; end
-    RUBY
-  end
-
-  it 'does not flag a method that is focused twice' do
-    expect_offense(<<-RUBY)
-      fit "foo", :focus do
-      ^^^^^^^^^^^^^^^^^ Focused spec found.
-      end
-    RUBY
-  end
-
-  it 'ignores non-rspec code with :focus blocks' do
-    expect_no_offenses(<<-RUBY)
-      some_method "foo", focus: true do
-      end
-    RUBY
-  end
-
-  it 'flags focused block types' do
-    expect_offense(<<-RUBY)
-      fdescribe 'test' do; end
-      ^^^^^^^^^^^^^^^^ Focused spec found.
-      RSpec.fdescribe 'test' do; end
-      ^^^^^^^^^^^^^^^^^^^^^^ Focused spec found.
-      ffeature 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      fcontext 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      fit 'test' do; end
-      ^^^^^^^^^^ Focused spec found.
-      fscenario 'test' do; end
-      ^^^^^^^^^^^^^^^^ Focused spec found.
-      fexample 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      fspecify 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      focus 'test' do; end
-      ^^^^^^^^^^^^ Focused spec found.
-    RUBY
-  end
-end