rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/multiple_subjects_spec.rb

@@ -1,83 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::MultipleSubjects do
-  let(:cop) { described_class.new }
-
-  it 'registers an offense for every overwritten subject' do
-    expect_offense(<<-RUBY)
-      describe 'hello there' do
-        subject(:foo) { 1 }
-        ^^^^^^^^^^^^^^^^^^^ Do not set more than one subject per example group
-        subject(:bar) { 2 }
-        ^^^^^^^^^^^^^^^^^^^ Do not set more than one subject per example group
-        subject { 3 }
-        ^^^^^^^^^^^^^ Do not set more than one subject per example group
-        subject(:baz) { 4 }
-
-        describe 'baz' do
-          subject(:norf) { 1 }
-        end
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      describe 'hello there' do
-        let(:foo) { 1 }
-        let(:bar) { 2 }
-        subject(:baz) { 4 }
-
-        describe 'baz' do
-          subject(:norf) { 1 }
-        end
-      end
-    RUBY
-  end
-
-  it 'does not try to autocorrect subject!' do
-    source = <<-RUBY
-      describe Foo do
-        subject! { a }
-        ^^^^^^^^^^^^^^ Do not set more than one subject per example group
-        subject! { b }
-      end
-    RUBY
-
-    expect_offense(source)
-    expect_no_corrections
-  end
-
-  it 'does not flag shared example groups' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        it_behaves_like 'user' do
-          subject { described_class.new(user, described_class) }
-
-          it { expect(subject).not_to be_accessible }
-        end
-
-        it_behaves_like 'admin' do
-          subject { described_class.new(user, described_class) }
-
-          it { expect(subject).to be_accessible }
-        end
-      end
-    RUBY
-  end
-
-  it 'autocorrects' do
-    expect_offense(<<-RUBY)
-      describe 'hello there' do
-        subject { 1 }
-        ^^^^^^^^^^^^^ Do not set more than one subject per example group
-        subject { 2 }
-        ^^^^^^^^^^^^^ Do not set more than one subject per example group
-        subject { 3 }
-      end
-    RUBY
-    expect_correction(<<-RUBY)
-      describe 'hello there' do
-        subject { 3 }
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/named_subject_spec.rb

@@ -1,123 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::NamedSubject, :config do
-  subject(:cop) { described_class.new(config) }
-
-  shared_examples_for 'checking subject outside of shared examples' do
-    it 'checks `it` and `specify` for explicit subject usage' do
-      expect_offense(<<-RUBY)
-        RSpec.describe User do
-          subject { described_class.new }
-
-          it "is valid" do
-            expect(subject.valid?).to be(true)
-                   ^^^^^^^ Name your test subject if you need to reference it explicitly.
-          end
-
-          specify do
-            expect(subject.valid?).to be(true)
-                   ^^^^^^^ Name your test subject if you need to reference it explicitly.
-          end
-        end
-      RUBY
-    end
-
-    it 'checks before and after for explicit subject usage' do
-      expect_offense(<<-RUBY)
-        RSpec.describe User do
-          subject { described_class.new }
-
-          before(:each) do
-            do_something_with(subject)
-                              ^^^^^^^ Name your test subject if you need to reference it explicitly.
-          end
-
-          after do
-            do_something_with(subject)
-                              ^^^^^^^ Name your test subject if you need to reference it explicitly.
-          end
-        end
-      RUBY
-    end
-
-    it 'checks around(:each) for explicit subject usage' do
-      expect_offense(<<-RUBY)
-        RSpec.describe User do
-          subject { described_class.new }
-
-          around(:each) do |test|
-            do_something_with(subject)
-                              ^^^^^^^ Name your test subject if you need to reference it explicitly.
-          end
-        end
-      RUBY
-    end
-
-    it 'ignores subject when not wrapped inside a test' do
-      expect_no_offenses(<<-RUBY)
-        def foo
-          it(subject)
-        end
-      RUBY
-    end
-  end
-
-  context 'when IgnoreSharedExamples is false' do
-    let(:cop_config) { { 'IgnoreSharedExamples' => false } }
-
-    it_behaves_like 'checking subject outside of shared examples'
-
-    it 'checks shared_examples for explicit subject usage' do
-      expect_offense(<<-RUBY)
-        RSpec.describe User do
-          subject(:new_user) { described_class.new }
-
-          shared_examples_for 'a valid new user' do
-            it "is a User" do
-              expect(subject).to be_a(User)
-                     ^^^^^^^ Name your test subject if you need to reference it explicitly.
-            end
-
-            it "is valid" do
-              expect(subject.valid?).to be(true)
-                     ^^^^^^^ Name your test subject if you need to reference it explicitly.
-            end
-
-            it "is new" do
-              expect(subject).to be_new_record
-                     ^^^^^^^ Name your test subject if you need to reference it explicitly.
-            end
-          end
-        end
-      RUBY
-    end
-  end
-
-  context 'when IgnoreSharedExamples is true' do
-    let(:cop_config) { { 'IgnoreSharedExamples' => true } }
-
-    it_behaves_like 'checking subject outside of shared examples'
-
-    it 'ignores explicit subject in shared_examples' do
-      expect_no_offenses(<<-RUBY)
-        RSpec.describe User do
-          subject(:new_user) { described_class.new }
-
-          shared_examples_for 'a valid new user' do
-            it "is a User" do
-              expect(subject).to be_a(User)
-            end
-
-            it "is valid" do
-              expect(subject.valid?).to be(true)
-            end
-
-            it "is new" do
-              expect(subject).to be_new_record
-            end
-          end
-        end
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/nested_groups_spec.rb

@@ -1,81 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::NestedGroups, :config do
-  subject(:cop) { described_class.new(config) }
-
-  it 'flags nested contexts' do
-    expect_offense(<<-RUBY)
-      describe MyClass do
-        context 'when foo' do
-          context 'when bar' do
-            context 'when baz' do
-            ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded [4/3].
-            end
-          end
-        end
-
-        context 'when qux' do
-          context 'when norf' do
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'support --auto-gen-config' do
-    inspect_source(<<-RUBY, 'spec/foo_spec.rb')
-      describe MyClass do
-        context 'when foo' do
-          context 'when bar' do
-            context 'when baz' do
-            end
-          end
-        end
-      end
-    RUBY
-
-    expect(cop.config_to_allow_offenses[:exclude_limit]).to eq('Max' => 4)
-  end
-
-  it 'ignores non-spec context methods' do
-    expect_no_offenses(<<-RUBY)
-      class MyThingy
-        context 'this is not rspec' do
-          context 'but it uses contexts' do
-          end
-        end
-      end
-    RUBY
-  end
-
-  context 'when Max is configured as 2' do
-    let(:cop_config) { { 'Max' => '2' } }
-
-    it 'flags two levels of nesting' do
-      expect_offense(<<-RUBY)
-        describe MyClass do
-          context 'when foo' do
-            context 'when bar' do
-            ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded [3/2].
-              context 'when baz' do
-              ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded [4/2].
-              end
-            end
-          end
-        end
-      RUBY
-    end
-  end
-
-  context 'when configured with MaxNesting' do
-    let(:cop_config) { { 'MaxNesting' => '1' } }
-
-    it 'emits a deprecation warning' do
-      expect { inspect_source('describe(Foo) { }', 'foo_spec.rb') }
-        .to output(
-          'Configuration key `MaxNesting` for RSpec/NestedGroups is ' \
-          "deprecated in favor of `Max`. Please use that instead.\n"
-        ).to_stderr
-    end
-  end
-end

data/spec/rubocop/cop/rspec/not_to_not_spec.rb

@@ -1,77 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when EnforcedStyle is `not_to`' do
-    let(:cop_config) { { 'EnforcedStyle' => 'not_to' } }
-
-    it 'detects the `to_not` offense' do
-      expect_offense(<<-RUBY)
-        it { expect(false).to_not be_true }
-                           ^^^^^^ Prefer `not_to` over `to_not`.
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it { expect(false).not_to be_true }
-      RUBY
-    end
-
-    it 'detects the `to_not` offense on an expect block' do
-      expect_offense(<<-RUBY)
-        expect {
-          2 + 2
-        }.to_not raise_error
-          ^^^^^^ Prefer `not_to` over `to_not`.
-      RUBY
-
-      expect_correction(<<-RUBY)
-        expect {
-          2 + 2
-        }.not_to raise_error
-      RUBY
-    end
-
-    it 'detects no offense when using `not_to`' do
-      expect_no_offenses(<<-RUBY)
-        it { expect(false).not_to be_true }
-      RUBY
-    end
-  end
-
-  context 'when AcceptedMethod is `to_not`' do
-    let(:cop_config) { { 'EnforcedStyle' => 'to_not' } }
-
-    it 'detects the `not_to` offense' do
-      expect_offense(<<-RUBY)
-        it { expect(false).not_to be_true }
-                           ^^^^^^ Prefer `to_not` over `not_to`.
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it { expect(false).to_not be_true }
-      RUBY
-    end
-
-    it 'detects the `not_to` offense on an expect block' do
-      expect_offense(<<-RUBY)
-        expect {
-          2 + 2
-        }.not_to raise_error
-          ^^^^^^ Prefer `to_not` over `not_to`.
-      RUBY
-
-      expect_correction(<<-RUBY)
-        expect {
-          2 + 2
-        }.to_not raise_error
-      RUBY
-    end
-
-    it 'detects no offense when using `to_not`' do
-      expect_no_offenses(<<-RUBY)
-        it { expect(false).to_not be_true }
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/overwriting_setup_spec.rb

@@ -1,91 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::OverwritingSetup do
-  subject(:cop) { described_class.new }
-
-  it 'finds overwriten `let`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        let(:a) { a }
-        let(:a) { b }
-        ^^^^^^^^^^^^^ `a` is already defined.
-      end
-    RUBY
-  end
-
-  it 'finds overwriten `subject`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        subject(:a) { a }
-
-        let(:a) { b }
-        ^^^^^^^^^^^^^ `a` is already defined.
-      end
-    RUBY
-  end
-
-  it 'works with `subject!` and `let!`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        subject!(:a) { a }
-
-        let!(:a) { b }
-        ^^^^^^^^^^^^^^ `a` is already defined.
-      end
-    RUBY
-  end
-
-  it 'finds `let!` overwriting `let`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        let(:a) { b }
-        let!(:a) { b }
-        ^^^^^^^^^^^^^^ `a` is already defined.
-      end
-    RUBY
-  end
-
-  it 'ignores overwriting in different context' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        let(:a) { a }
-
-        context `different` do
-          let(:a) { b }
-        end
-      end
-    RUBY
-  end
-
-  it 'handles unnamed subjects' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        subject { a }
-
-        let(:subject) { b }
-        ^^^^^^^^^^^^^^^^^^^ `subject` is already defined.
-      end
-    RUBY
-  end
-
-  it 'handles dynamic names for `let`' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        subject(:name) { a }
-
-        let(name) { b }
-      end
-    RUBY
-  end
-
-  it 'handles string arguments' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        subject(:name) { a }
-
-        let("name") { b }
-        ^^^^^^^^^^^^^^^^^ `name` is already defined.
-      end
-    RUBY
-  end
-end