rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/empty_line_after_hook_spec.rb

@@ -1,133 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterHook do
-  subject(:cop) { described_class.new }
-
-  it 'checks for empty line after `before` hook' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        before { do_something }
-        ^^^^^^^^^^^^^^^^^^^^^^^ Add an empty line after `before`.
-        it { does_something }
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        before { do_something }
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'checks for empty line after `after` hook' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        after { do_something }
-        ^^^^^^^^^^^^^^^^^^^^^^ Add an empty line after `after`.
-        it { does_something }
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        after { do_something }
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'checks for empty line after `around` hook' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        around { |test| test.run }
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Add an empty line after `around`.
-        it { does_something }
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        around { |test| test.run }
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'approves empty line after `before` hook' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        before { do_something }
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'approves empty line after `after` hook' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        after { do_something }
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'approves empty line after `around` hook' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        around { |test| test.run }
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'handles multiline `before` block' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        before do
-          do_something
-        end
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'handles multiline `after` block' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        after do
-          do_something
-        end
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'handles multiline `around` block' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        around do |test|
-          test.run
-        end
-
-        it { does_something }
-      end
-    RUBY
-  end
-
-  it 'handles `before` being the latest node' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        before { do_something }
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/empty_line_after_subject_spec.rb

@@ -1,94 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterSubject do
-  subject(:cop) { described_class.new }
-
-  it 'checks for empty line after subject' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        subject { described_class.new }
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Add empty line after `subject`.
-        let(:params) { foo }
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        subject { described_class.new }
-
-        let(:params) { foo }
-      end
-    RUBY
-  end
-
-  it 'checks for empty line after subject!' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        subject! { described_class.new }
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Add empty line after `subject`.
-        let(:params) { foo }
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        subject! { described_class.new }
-
-        let(:params) { foo }
-      end
-    RUBY
-  end
-
-  it 'approves empty line after subject' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        subject { described_class.new }
-
-        let(:params) { foo }
-      end
-    RUBY
-  end
-
-  it 'approves empty line after subject!' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        subject! { described_class.new }
-
-        let(:params) { foo }
-      end
-    RUBY
-  end
-
-  it 'handles subjects in tests' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        # This shouldn't really ever happen in a sane codebase but I still
-        # want to avoid false positives
-        it "doesn't mind me calling a method called subject in the test" do
-          subject { bar }
-          let(foo)
-        end
-      end
-    RUBY
-  end
-
-  it 'handles multiline subject block' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        subject do
-          described_class.new
-        end
-
-        let(:params) { foo }
-      end
-    RUBY
-  end
-
-  it 'handles subject being the latest node' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        subject { described_user }
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/example_length_spec.rb

@@ -1,78 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ExampleLength, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) { { 'Max' => 3 } }
-
-  it 'ignores non-spec blocks' do
-    expect_no_offenses(<<-RUBY)
-      foo do
-        line 1
-        line 2
-        line 3
-        line 4
-      end
-    RUBY
-  end
-
-  it 'allows an empty example' do
-    expect_no_offenses(<<-RUBY)
-      it do
-      end
-    RUBY
-  end
-
-  it 'allows a short example' do
-    expect_no_offenses(<<-RUBY)
-      it do
-        line 1
-        line 2
-        line 3
-      end
-    RUBY
-  end
-
-  it 'ignores comments' do
-    expect_no_offenses(<<-RUBY)
-      it do
-        line 1
-        line 2
-        # comment
-        line 3
-      end
-    RUBY
-  end
-
-  context 'when inspecting large examples' do
-    it 'flags the example' do
-      expect_offense(<<-RUBY)
-        it do
-        ^^^^^ Example has too many lines [4/3].
-          line 1
-          line 2
-          line 3
-          line 4
-        end
-      RUBY
-    end
-  end
-
-  context 'with CountComments enabled' do
-    let(:cop_config) do
-      { 'Max' => 3, 'CountComments' => true }
-    end
-
-    it 'flags the example' do
-      expect_offense(<<-RUBY)
-        it do
-        ^^^^^ Example has too many lines [4/3].
-          line 1
-          line 2
-          # comment
-          line 3
-        end
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/example_without_description_spec.rb

@@ -1,92 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ExampleWithoutDescription, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) do
-    { 'EnforcedStyle' => enforced_style }
-  end
-
-  context 'with EnforcedStyle `always_allow`' do
-    let(:enforced_style) { 'always_allow' }
-
-    it 'flags empty strings for description' do
-      expect_offense(<<-RUBY)
-        it '' do
-           ^^ Omit the argument when you want to have auto-generated description.
-          expect(subject).to be_good
-        end
-      RUBY
-    end
-
-    it 'ignores `it` with a description' do
-      expect_no_offenses(<<-RUBY)
-        it 'is good' do
-          expect(subject).to be_good
-        end
-      RUBY
-    end
-
-    it 'ignores `it` without an argument' do
-      expect_no_offenses(<<-RUBY)
-        it do
-          expect(subject).to be_good
-        end
-      RUBY
-    end
-  end
-
-  context 'with EnforcedStyle `single_line_only`' do
-    let(:enforced_style) { 'single_line_only' }
-
-    it 'flags missing description in multi-line examples' do
-      expect_offense(<<-RUBY)
-        it do
-        ^^ Add a description.
-          expect(subject).to be_good
-        end
-      RUBY
-    end
-
-    it 'ignores missing description in single-line examples' do
-      expect_no_offenses(<<-RUBY)
-        it { expect(subject).to be_good }
-      RUBY
-    end
-
-    it 'flags example with an empty string for description' do
-      expect_offense(<<-RUBY)
-        it('') { expect(subject).to be_good }
-           ^^ Omit the argument when you want to have auto-generated description.
-      RUBY
-    end
-  end
-
-  context 'with EnforcedStyle `disallow`' do
-    let(:enforced_style) { 'disallow' }
-
-    it 'flags missing description in multi-line examples' do
-      expect_offense(<<-RUBY)
-        it do
-        ^^ Add a description.
-          expect(subject).to be_good
-        end
-      RUBY
-    end
-
-    it 'flags missing description in single-line examples' do
-      expect_offense(<<-RUBY)
-        it { expect(subject).to be_good }
-        ^^ Add a description.
-      RUBY
-    end
-
-    it 'ignores `it` with a description' do
-      expect_no_offenses(<<-RUBY)
-        it 'is good' do
-          expect(subject).to be_good
-        end
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/example_wording_spec.rb

@@ -1,173 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'with configuration' do
-    let(:cop_config) do
-      {
-        'CustomTransform' => { 'have' => 'has' },
-        'IgnoredWords'    => %w[only really]
-      }
-    end
-
-    it 'ignores non-example blocks' do
-      expect_no_offenses('foo "should do something" do; end')
-    end
-
-    it 'finds description with `should` at the beginning' do
-      expect_offense(<<-RUBY)
-        it 'should do something' do
-            ^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it 'does something' do
-        end
-      RUBY
-    end
-
-    it 'finds interpolated description with `should` at the beginning' do
-      expect_offense(<<-'RUBY')
-        it "should do #{:stuff}" do
-            ^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-'RUBY')
-        it "does #{:stuff}" do
-        end
-      RUBY
-    end
-
-    it 'finds description with `Should` at the beginning' do
-      expect_offense(<<-RUBY)
-        it 'Should do something' do
-            ^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it 'does something' do
-        end
-      RUBY
-    end
-
-    it 'finds description with `shouldn\'t` at the beginning' do
-      expect_offense(<<-RUBY)
-        it "shouldn't do something" do
-            ^^^^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it "does not do something" do
-        end
-      RUBY
-    end
-
-    it 'finds description with `SHOULDN\'T` at the beginning' do
-      expect_offense(<<-RUBY)
-        it "SHOULDN'T do something" do
-            ^^^^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it "DOES NOT do something" do
-        end
-      RUBY
-    end
-
-    it 'flags a lone should' do
-      expect_offense(<<-RUBY)
-        it 'should' do
-            ^^^^^^ Do not use should when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it '' do
-        end
-      RUBY
-    end
-
-    it 'flags a lone should not' do
-      expect_offense(<<-RUBY)
-        it 'should not' do
-            ^^^^^^^^^^ Do not use should when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it 'does not' do
-        end
-      RUBY
-    end
-
-    it 'finds leading its' do
-      expect_offense(<<-RUBY)
-        it "it does something" do
-            ^^^^^^^^^^^^^^^^^ Do not repeat 'it' when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it "does something" do
-        end
-      RUBY
-    end
-
-    it 'finds leading it in interpolated description' do
-      expect_offense(<<-'RUBY')
-        it "it does #{action}" do
-            ^^^^^^^^^^^^^^^^^ Do not repeat 'it' when describing your tests.
-        end
-      RUBY
-
-      expect_correction(<<-'RUBY')
-        it "does #{action}" do
-        end
-      RUBY
-    end
-
-    it "skips words beginning with 'it'" do
-      expect_no_offenses(<<-RUBY)
-        it 'itemizes items' do
-        end
-      RUBY
-    end
-
-    it 'skips descriptions without `should` at the beginning' do
-      expect_no_offenses(<<-RUBY)
-        it 'finds no should here' do
-        end
-      RUBY
-    end
-
-    it 'skips descriptions starting with words that begin with `should`' do
-      expect_no_offenses(<<-RUBY)
-        it 'shoulders the burden' do
-        end
-      RUBY
-    end
-
-    it 'skips interpolated description without literal `should` at the start' do
-      expect_no_offenses(<<-'RUBY')
-        it "#{should} not be here" do
-        end
-      RUBY
-    end
-  end
-
-  context 'when configuration is empty' do
-    include_examples 'autocorrect',
-                     'it "should have trait" do end',
-                     'it "haves trait" do end'
-
-    include_examples 'autocorrect',
-                     'it "should only fail" do end',
-                     'it "onlies fail" do end'
-  end
-end