rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/subject_stub_spec.rb

@@ -1,293 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
-  subject(:cop) { described_class.new }
-
-  it 'flags when subject is stubbed' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        before do
-          allow(foo).to receive(:bar).and_return(baz)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-
-        it 'uses expect twice' do
-          expect(foo.bar).to eq(baz)
-        end
-      end
-    RUBY
-  end
-
-  it 'flags when subject is mocked' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        before do
-          expect(foo).to receive(:bar).and_return(baz)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          expect(foo).to receive(:bar)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          expect(foo).to receive(:bar).with(1)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          expect(foo).to receive(:bar).with(1).and_return(2)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-
-        it 'uses expect twice' do
-          expect(foo.bar).to eq(baz)
-        end
-      end
-    RUBY
-  end
-
-  it 'flags when an unnamed subject is mocked' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject { described_class.new }
-
-        it 'uses unnamed subject' do
-          expect(subject).to receive(:bar)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags an expectation made on an unnamed subject' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        it 'uses unnamed subject' do
-          expect(subject).to receive(:bar)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags one-line expectcation syntax' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        it 'uses one-line expectation syntax' do
-          is_expected.to receive(:bar)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-      end
-    RUBY
-  end
-
-  it 'ignores stub within context where subject name changed' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        context 'when I shake things up' do
-          subject(:bar) { described_class.new }
-
-          it 'tries to trick rubocop-rspec' do
-            allow(foo).to receive(:baz)
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'flags stub inside all matcher' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { [Object.new] }
-        it 'tries to trick rubocop-rspec' do
-          expect(foo).to all(receive(:baz))
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags nested subject stubs when nested subject uses same name' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        context 'when I shake things up' do
-          subject(:foo) { described_class.new }
-
-          before do
-            allow(foo).to receive(:wow)
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          end
-
-          it 'tries to trick rubocop-rspec' do
-            expect(foo).to eql(:neat)
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'ignores nested stubs when nested subject is anonymous' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        context 'when I shake things up' do
-          subject { described_class.new }
-
-          before do
-            allow(foo).to receive(:wow)
-          end
-
-          it 'tries to trick rubocop-rspec' do
-            expect(foo).to eql(:neat)
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'flags nested subject stubs when example group does not define subject' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        context 'when I shake things up' do
-          before do
-            allow(foo).to receive(:wow)
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          end
-
-          it 'tries to trick rubocop-rspec' do
-            expect(foo).to eql(:neat)
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'flags nested subject stubs' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        context 'when I shake things up' do
-          subject(:bar) { described_class.new }
-
-          before do
-            allow(foo).to receive(:wow)
-            allow(bar).to receive(:wow)
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          end
-
-          it 'tries to trick rubocop-rspec' do
-            expect(bar).to eql(foo)
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'flags nested subject stubs when adjacent context redefines' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        context 'when I do something in a context' do
-          subject { blah }
-        end
-
-        it 'still flags this test' do
-          allow(foo).to receive(:blah)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags deeply nested subject stubs' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        context 'level 1' do
-          subject(:bar) { described_class.new }
-
-          context 'level 2' do
-            subject(:baz) { described_class.new }
-
-            before do
-              allow(foo).to receive(:wow)
-              allow(bar).to receive(:wow)
-              allow(baz).to receive(:wow)
-              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-            end
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'flags negated runners' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        specify do
-          expect(foo).not_to receive(:bar)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          expect(foo).to_not receive(:bar)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          expect(foo.bar).to eq(baz)
-        end
-      end
-    RUBY
-  end
-
-  it 'flags multiple-method stubs' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        specify do
-          expect(foo).to receive_messages(bar: :baz, baz: :baz)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          expect(foo.bar).to eq(baz)
-        end
-      end
-    RUBY
-  end
-
-  it 'flags chain stubs' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        specify do
-          expect(foo).to receive_message_chain(:bar, baz: :baz)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-          expect(foo.bar.baz).to eq(baz)
-        end
-      end
-    RUBY
-  end
-
-  it 'flags spy subject stubs' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        subject(:foo) { described_class.new }
-
-        specify do
-          allow(foo).to some_matcher_that_allows_a_bar_message
-          expect(foo.bar).to eq(baz)
-          expect(foo).to have_received(:bar)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
-        end
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/unspecified_exception_spec.rb

@@ -1,177 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::UnspecifiedException do
-  subject(:cop) { described_class.new }
-
-  context 'with raise_error matcher' do
-    it 'detects the `unspecified_exception` offense' do
-      expect_offense(<<-RUBY)
-        expect {
-          raise StandardError
-        }.to raise_error
-             ^^^^^^^^^^^ Specify the exception being captured
-      RUBY
-    end
-
-    it 'allows empty exception specification when not expecting an error' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError
-        }.not_to raise_error
-      RUBY
-    end
-
-    it 'allows exception classes' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError
-        }.to raise_error(StandardError)
-      RUBY
-    end
-
-    it 'allows exception messages' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_error('error')
-      RUBY
-    end
-
-    it 'allows exception types with messages' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_error(StandardError, 'error')
-      RUBY
-    end
-
-    it 'allows exception matching regular expressions' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_error(/err/)
-      RUBY
-    end
-
-    it 'allows exception types with matching regular expressions' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_error(StandardError, /err/)
-      RUBY
-    end
-
-    it 'allows classes with blocks with braces' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_error { |err| err.data }
-      RUBY
-    end
-
-    it 'allows classes with blocks with do/end' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_error do |error|
-          error.data
-        end
-      RUBY
-    end
-
-    it 'allows parameterized exceptions' do
-      expect_no_offenses(<<-RUBY)
-        my_exception = StandardError.new('my exception')
-        expect {
-          raise my_exception
-        }.to raise_error(my_exception)
-      RUBY
-    end
-  end
-
-  context 'with raise_exception matcher' do
-    it 'detects the `unspecified_exception` offense' do
-      expect_offense(<<-RUBY)
-        expect {
-          raise StandardError
-        }.to raise_exception
-             ^^^^^^^^^^^^^^^ Specify the exception being captured
-      RUBY
-    end
-
-    it 'allows empty exception specification when not expecting an error' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError
-        }.not_to raise_exception
-      RUBY
-    end
-
-    it 'allows exception classes' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError
-        }.to raise_exception(StandardError)
-      RUBY
-    end
-
-    it 'allows exception messages' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_exception('error')
-      RUBY
-    end
-
-    it 'allows exception types with messages' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_exception(StandardError, 'error')
-      RUBY
-    end
-
-    it 'allows exception matching regular expressions' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_exception(/err/)
-      RUBY
-    end
-
-    it 'allows exception types with matching regular expressions' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_exception(StandardError, /err/)
-      RUBY
-    end
-
-    it 'allows classes with blocks with braces' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_exception { |err| err.data }
-      RUBY
-    end
-
-    it 'allows classes with blocks with do/end' do
-      expect_no_offenses(<<-RUBY)
-        expect {
-          raise StandardError.new('error')
-        }.to raise_exception do |error|
-          error.data
-        end
-      RUBY
-    end
-
-    it 'allows parameterized exceptions' do
-      expect_no_offenses(<<-RUBY)
-        my_exception = StandardError.new('my exception')
-        expect {
-          raise my_exception
-        }.to raise_exception(my_exception)
-      RUBY
-    end
-  end
-end