rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/cop_spec.rb

@@ -1,95 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::Cop do
-  subject(:cop) { fake_cop.new(config) }
-
-  let(:config) do
-    rubocop_config =
-      {
-        'AllCops' => {
-          'RSpec' => {
-            'Patterns' => rspec_patterns
-          }
-        },
-        'RSpec/FakeCop' => {
-          'Exclude' => %w[bar_spec.rb]
-        }
-      }
-
-    RuboCop::Config.new(rubocop_config, 'fake_cop_config.yml')
-  end
-
-  let(:fake_cop) do
-    stub_const('RuboCop::RSpec', Module.new)
-    # rubocop:disable ClassAndModuleChildren, RSpec/LeakyConstantDeclaration
-    class RuboCop::RSpec::FakeCop < described_class
-      def on_send(node)
-        add_offense(node, message: 'I flag everything')
-      end
-    end
-    # rubocop:enable ClassAndModuleChildren, RSpec/LeakyConstantDeclaration
-    RuboCop::RSpec::FakeCop
-  end
-
-  let(:rspec_patterns) { ['_spec.rb$', '(?:^|/)spec/'] }
-
-  context 'when the source path ends with `_spec.rb`' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY, 'foo_spec.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-
-    it 'ignores the file if it is ignored' do
-      expect_no_offenses(<<-RUBY, 'bar_spec.rb')
-        foo(1)
-      RUBY
-    end
-  end
-
-  context 'when the source path contains `/spec/`' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY, '/spec/support/thing.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-  end
-
-  context 'when the source path starts with `spec/`' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY, 'spec/support/thing.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-  end
-
-  context 'when the file is a source file without "spec" in the name' do
-    it 'ignores the source when the path is not a spec file' do
-      expect_no_offenses(<<-RUBY, 'foo.rb')
-        foo(1)
-      RUBY
-    end
-
-    it 'ignores the source when the path is not a specified pattern' do
-      expect_no_offenses(<<-RUBY, 'foo_test.rb')
-        foo(1)
-      RUBY
-    end
-  end
-
-  context 'when custom patterns are specified' do
-    let(:rspec_patterns) do
-      ['_test\.rb$']
-    end
-
-    it 'registers offenses when the path matches a custom specified pattern' do
-      expect_offense(<<-RUBY, 'foo_test.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/describe_class_spec.rb

@@ -1,168 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
-  subject(:cop) { described_class.new }
-
-  it 'checks first-line describe statements' do
-    expect_offense(<<-RUBY)
-      describe "bad describe" do
-               ^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
-      end
-    RUBY
-  end
-
-  it 'supports RSpec.describe' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe Foo do
-      end
-    RUBY
-  end
-
-  it 'supports ::RSpec.describe' do
-    expect_no_offenses(<<-RUBY)
-      ::RSpec.describe Foo do
-      end
-    RUBY
-  end
-
-  it 'checks describe statements after a require' do
-    expect_offense(<<-RUBY)
-      require 'spec_helper'
-      describe "bad describe" do
-               ^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
-      end
-    RUBY
-  end
-
-  it 'checks highlights the first argument of a describe' do
-    expect_offense(<<-RUBY)
-      describe "bad describe", "blah blah" do
-               ^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
-      end
-    RUBY
-  end
-
-  it 'ignores nested describe statements' do
-    expect_no_offenses(<<-RUBY)
-      describe Some::Class do
-        describe "bad describe" do
-        end
-      end
-    RUBY
-  end
-
-  it 'ignores request specs' do
-    expect_no_offenses(<<-RUBY)
-      describe 'my new feature', type: :request do
-      end
-    RUBY
-  end
-
-  it 'ignores feature specs' do
-    expect_no_offenses(<<-RUBY)
-      describe 'my new feature', type: :feature do
-      end
-    RUBY
-  end
-
-  it 'ignores system specs' do
-    expect_no_offenses(<<-RUBY)
-      describe 'my new system test', type: :system do
-      end
-    RUBY
-  end
-
-  it 'ignores feature specs when RSpec.describe is used' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe 'my new feature', type: :feature do
-      end
-    RUBY
-  end
-
-  it 'flags specs with non :type metadata' do
-    expect_offense(<<-RUBY)
-      describe 'my new feature', foo: :feature do
-               ^^^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
-      end
-    RUBY
-  end
-
-  it 'flags normal metadata in describe' do
-    expect_offense(<<-RUBY)
-      describe 'my new feature', blah, type: :wow do
-               ^^^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
-      end
-    RUBY
-  end
-
-  it 'ignores feature specs - also with complex options' do
-    expect_no_offenses(<<-RUBY)
-      describe 'my new feature', :test, :type => :feature, :foo => :bar do
-      end
-    RUBY
-  end
-
-  it 'ignores an empty describe' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe do
-      end
-
-      describe do
-      end
-    RUBY
-  end
-
-  it 'ignores routing specs' do
-    expect_no_offenses(<<-RUBY)
-      describe 'my new route', type: :routing do
-      end
-    RUBY
-  end
-
-  it 'ignores view specs' do
-    expect_no_offenses(<<-RUBY)
-      describe 'widgets/index', type: :view do
-      end
-    RUBY
-  end
-
-  it "doesn't blow up on single-line describes" do
-    expect_no_offenses('describe Some::Class')
-  end
-
-  it "doesn't flag top level describe in a shared example" do
-    expect_no_offenses(<<-RUBY)
-      shared_examples 'Common::Interface' do
-        describe '#public_interface' do
-          it 'conforms to interface' do
-            # ...
-          end
-        end
-      end
-    RUBY
-  end
-
-  it "doesn't flag top level describe in a shared context" do
-    expect_no_offenses(<<-RUBY)
-      RSpec.shared_context 'Common::Interface' do
-        describe '#public_interface' do
-          it 'conforms to interface' do
-            # ...
-          end
-        end
-      end
-    RUBY
-  end
-
-  it "doesn't flag top level describe in an unnamed shared context" do
-    expect_no_offenses(<<-RUBY)
-      shared_context do
-        describe '#public_interface' do
-          it 'conforms to interface' do
-            # ...
-          end
-        end
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/describe_method_spec.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::DescribeMethod do
-  subject(:cop) { described_class.new }
-
-  it 'ignores describes with only a class' do
-    expect_no_offenses('describe Some::Class do; end')
-  end
-
-  it 'enforces non-method names' do
-    expect_offense(<<-RUBY)
-      describe Some::Class, 'nope', '.incorrect_usage' do
-                            ^^^^^^ The second argument to describe should be the method being tested. '#instance' or '.class'.
-      end
-    RUBY
-  end
-
-  it 'skips methods starting with a . or #' do
-    expect_no_offenses(<<-RUBY)
-      describe Some::Class, '.asdf' do
-      end
-
-      describe Some::Class, '#fdsa' do
-      end
-    RUBY
-  end
-
-  it 'skips specs not having a string second argument' do
-    expect_no_offenses(<<-RUBY)
-      describe Some::Class, :config do
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/describe_symbol_spec.rb

@@ -1,44 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::DescribeSymbol do
-  subject(:cop) { described_class.new }
-
-  it 'flags violations for `describe :symbol`' do
-    expect_offense(<<-RUBY)
-      describe(:some_method) { }
-               ^^^^^^^^^^^^ Avoid describing symbols.
-    RUBY
-  end
-
-  it 'flags violations for `describe :symbol` with multiple arguments' do
-    expect_offense(<<-RUBY)
-      describe(:some_method, "description") { }
-               ^^^^^^^^^^^^ Avoid describing symbols.
-    RUBY
-  end
-
-  it 'flags violations for `RSpec.describe :symbol`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe(:some_method, "description") { }
-                     ^^^^^^^^^^^^ Avoid describing symbols.
-    RUBY
-  end
-
-  it 'flags violations for a nested `describe`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe Foo do
-        describe :to_s do
-                 ^^^^^ Avoid describing symbols.
-        end
-      end
-    RUBY
-  end
-
-  it 'does not flag non-Symbol arguments' do
-    expect_no_offenses('describe("#some_method") { }')
-  end
-
-  it 'does not flag `context :symbol`' do
-    expect_no_offenses('context(:some_method) { }')
-  end
-end

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -1,352 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) { {} }
-
-  context 'when SkipBlocks is `true`' do
-    let(:cop_config) { { 'SkipBlocks' => true } }
-
-    it 'ignores violations within non-rspec blocks' do
-      expect_offense(<<-RUBY)
-        describe MyClass do
-          controller(ApplicationController) do
-            bar = MyClass
-          end
-
-          before do
-            MyClass
-            ^^^^^^^ Use `described_class` instead of `MyClass`.
-
-            Foo.custom_block do
-              MyClass
-            end
-          end
-        end
-      RUBY
-    end
-  end
-
-  context 'when SkipBlocks is `false`' do
-    it 'flags violations within all blocks' do
-      expect_offense(<<-RUBY)
-        describe MyClass do
-          controller(ApplicationController) do
-            bar = MyClass
-                  ^^^^^^^ Use `described_class` instead of `MyClass`.
-          end
-
-          before do
-            MyClass
-            ^^^^^^^ Use `described_class` instead of `MyClass`.
-
-            Foo.custom_block do
-              MyClass
-              ^^^^^^^ Use `described_class` instead of `MyClass`.
-            end
-          end
-        end
-      RUBY
-    end
-  end
-
-  context 'when EnforcedStyle is :described_class' do
-    let(:cop_config) { { 'EnforcedStyle' => :described_class } }
-
-    it 'flags for the use of the described class' do
-      expect_offense(<<-RUBY)
-        describe MyClass do
-          include MyClass
-                  ^^^^^^^ Use `described_class` instead of `MyClass`.
-
-          subject { MyClass.do_something }
-                    ^^^^^^^ Use `described_class` instead of `MyClass`.
-
-          before { MyClass.do_something }
-                   ^^^^^^^ Use `described_class` instead of `MyClass`.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        describe MyClass do
-          include described_class
-
-          subject { described_class.do_something }
-
-          before { described_class.do_something }
-        end
-      RUBY
-    end
-
-    it 'flags with metadata' do
-      expect_offense(<<-RUBY)
-        describe MyClass, some: :metadata do
-          subject { MyClass }
-                    ^^^^^^^ Use `described_class` instead of `MyClass`.
-        end
-      RUBY
-    end
-
-    it 'ignores described class as string' do
-      expect_no_offenses(<<-RUBY)
-        describe MyClass do
-          subject { "MyClass" }
-        end
-      RUBY
-    end
-
-    it 'ignores describe that do not reference to a class' do
-      expect_no_offenses(<<-RUBY)
-        describe "MyClass" do
-          subject { "MyClass" }
-        end
-      RUBY
-    end
-
-    it 'ignores class if the scope is changing' do
-      expect_no_offenses(<<-RUBY)
-        describe MyClass do
-          Class.new  { foo = MyClass }
-          Module.new { bar = MyClass }
-          Struct.new { lol = MyClass }
-
-          def method
-            include MyClass
-          end
-
-          class OtherClass
-            include MyClass
-          end
-
-          module MyModule
-            include MyClass
-          end
-        end
-      RUBY
-    end
-
-    it 'takes class from innermost describe' do
-      expect_offense(<<-RUBY)
-        describe MyClass do
-          describe MyClass::Foo do
-            subject { MyClass::Foo }
-                      ^^^^^^^^^^^^ Use `described_class` instead of `MyClass::Foo`.
-
-            let(:foo) { MyClass }
-          end
-        end
-      RUBY
-    end
-
-    it 'ignores subclasses' do
-      expect_no_offenses(<<-RUBY)
-        describe MyClass do
-          subject { MyClass::SubClass }
-        end
-      RUBY
-    end
-
-    it 'ignores non-matching namespace defined on `describe` level' do
-      expect_no_offenses(<<-RUBY)
-        describe MyNamespace::MyClass do
-          subject { ::MyClass }
-          let(:foo) { MyClass }
-        end
-      RUBY
-    end
-
-    it 'ignores non-matching namespace' do
-      expect_no_offenses(<<-RUBY)
-        module MyNamespace
-          describe MyClass do
-            subject { ::MyClass }
-          end
-        end
-      RUBY
-    end
-
-    it 'flags the use of described class with namespace' do
-      expect_offense(<<-RUBY)
-        describe MyNamespace::MyClass do
-          subject { MyNamespace::MyClass }
-                    ^^^^^^^^^^^^^^^^^^^^ Use `described_class` instead of `MyNamespace::MyClass`.
-        end
-      RUBY
-    end
-
-    it 'ignores non-matching namespace in usages' do
-      expect_no_offenses(<<-RUBY)
-        module UnrelatedNamespace
-          describe MyClass do
-            subject { MyNamespace::MyClass }
-          end
-        end
-      RUBY
-    end
-
-    it 'ignores violations within a class scope change' do
-      expect_no_offenses(<<-RUBY)
-        describe MyNamespace::MyClass do
-          before do
-            class Foo
-              thing = MyNamespace::MyClass.new
-            end
-          end
-        end
-      RUBY
-    end
-
-    it 'ignores violations within a hook scope change' do
-      expect_no_offenses(<<-RUBY)
-        describe do
-          before do
-            MyNamespace::MyClass.new
-          end
-        end
-      RUBY
-    end
-
-    it 'flags the use of described class with module' do
-      expect_offense(<<-RUBY)
-        module MyNamespace
-          describe MyClass do
-            subject { MyNamespace::MyClass }
-                      ^^^^^^^^^^^^^^^^^^^^ Use `described_class` instead of `MyNamespace::MyClass`.
-          end
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        module MyNamespace
-          describe MyClass do
-            subject { described_class }
-          end
-        end
-      RUBY
-    end
-
-    it 'flags the use of described class with nested namespace' do
-      expect_offense(<<-RUBY)
-          module A
-            class B::C
-              module D
-                describe E do
-                  subject { A::B::C::D::E }
-                            ^^^^^^^^^^^^^ Use `described_class` instead of `A::B::C::D::E`.
-                  let(:one) { B::C::D::E }
-                              ^^^^^^^^^^ Use `described_class` instead of `B::C::D::E`.
-                  let(:two) { C::D::E }
-                              ^^^^^^^ Use `described_class` instead of `C::D::E`.
-                  let(:six) { D::E }
-                              ^^^^ Use `described_class` instead of `D::E`.
-                  let(:ten) { E }
-                              ^ Use `described_class` instead of `E`.
-                end
-              end
-            end
-          end
-      RUBY
-    end
-
-    it 'accepts an empty block' do
-      expect_no_offenses(<<-RUBY)
-        describe MyClass do
-        end
-      RUBY
-    end
-
-    it 'ignores if a local variable is part of the namespace' do
-      expect_no_offenses(<<-RUBY)
-        describe Broken do
-          [Foo, Bar].each do |klass|
-            describe klass::Baz.name do
-              it { }
-            end
-          end
-        end
-      RUBY
-    end
-  end
-
-  context 'when EnforcedStyle is :explicit' do
-    let(:cop_config) { { 'EnforcedStyle' => :explicit } }
-
-    it 'flags the use of the described_class' do
-      expect_offense(<<-RUBY)
-        describe MyClass do
-          include described_class
-                  ^^^^^^^^^^^^^^^ Use `MyClass` instead of `described_class`.
-
-          subject { described_class.do_something }
-                    ^^^^^^^^^^^^^^^ Use `MyClass` instead of `described_class`.
-
-          before { described_class.do_something }
-                   ^^^^^^^^^^^^^^^ Use `MyClass` instead of `described_class`.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        describe MyClass do
-          include MyClass
-
-          subject { MyClass.do_something }
-
-          before { MyClass.do_something }
-        end
-      RUBY
-    end
-
-    it 'ignores described_class as string' do
-      expect_no_offenses(<<-RUBY)
-        describe MyClass do
-          subject { "described_class" }
-        end
-      RUBY
-    end
-
-    it 'ignores describe that do not reference to a class' do
-      expect_no_offenses(<<-RUBY)
-        describe "MyClass" do
-          subject { described_class }
-        end
-      RUBY
-    end
-
-    it 'ignores violations within a class scope change' do
-      expect_no_offenses(<<-RUBY)
-        describe MyNamespace::MyClass do
-          before do
-            class Foo
-              thing = described_class.new
-            end
-          end
-        end
-      RUBY
-    end
-
-    it 'ignores violations within a hook scope change' do
-      expect_no_offenses(<<-RUBY)
-        describe do
-          before do
-            described_class.new
-          end
-        end
-      RUBY
-    end
-
-    it 'autocorrects corresponding' do
-      expect_offense(<<-RUBY)
-        describe(Foo) { include described_class }
-                                ^^^^^^^^^^^^^^^ Use `Foo` instead of `described_class`.
-        describe(Bar) { include described_class }
-                                ^^^^^^^^^^^^^^^ Use `Bar` instead of `described_class`.
-      RUBY
-
-      expect_correction(<<-RUBY)
-        describe(Foo) { include Foo }
-        describe(Bar) { include Bar }
-      RUBY
-    end
-  end
-end