rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/scattered_let_spec.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ScatteredLet do
-  subject(:cop) { described_class.new }
-
-  it 'flags `let` after the first different node ' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        let(:a) { a }
-        subject { User }
-        let(:b) { b }
-        ^^^^^^^^^^^^^ Group all let/let! blocks in the example group together.
-      end
-    RUBY
-  end
-
-  it 'doesnt flag `let!` in the middle of multiple `let`s' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        subject { User }
-
-        let(:a) { a }
-        let!(:b) { b }
-        let(:c) { c }
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/scattered_setup_spec.rb

@@ -1,98 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
-  subject(:cop) { described_class.new }
-
-  it 'flags multiple hooks in the same example group' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        before { bar }
-        ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
-        before { baz }
-        ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
-      end
-    RUBY
-  end
-
-  it 'flags multiple hooks of the same scope with different symbols' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        before { bar }
-        ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
-        before(:each) { baz }
-        ^^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
-        before(:example) { baz }
-        ^^^^^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
-      end
-    RUBY
-  end
-
-  it 'flags multiple before(:all) hooks in the same example group' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        before(:all) { bar }
-        ^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
-        before(:all) { baz }
-        ^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
-      end
-    RUBY
-  end
-
-  it 'does not flag different hooks' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        before { bar }
-        after { baz }
-        around { qux }
-      end
-    RUBY
-  end
-
-  it 'does not flag different hook types' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        before { bar }
-        before(:all) { baz }
-        before(:suite) { baz }
-      end
-    RUBY
-  end
-
-  it 'does not flag hooks in different example groups' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        before { bar }
-
-        describe '.baz' do
-          before { baz }
-        end
-      end
-    RUBY
-  end
-
-  it 'does not flag hooks in different shared contexts' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        shared_context 'one' do
-          before { bar }
-        end
-
-        shared_context 'two' do
-          before { baz }
-        end
-      end
-    RUBY
-  end
-
-  it 'does not flag similar method names inside of examples' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        before { bar }
-
-        it 'uses an instance method called before' do
-          expect(before { tricky }).to_not confuse_rubocop_rspec
-        end
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/shared_context_spec.rb

@@ -1,137 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::SharedContext do
-  subject(:cop) { described_class.new }
-
-  describe 'shared_context' do
-    it 'does not register an offense for empty contexts' do
-      expect_no_offenses(<<-RUBY)
-        shared_context 'empty' do
-        end
-      RUBY
-    end
-
-    it 'registers an offense for shared_context with only examples' do
-      expect_offense(<<-RUBY)
-        shared_context 'foo' do
-        ^^^^^^^^^^^^^^^^^^^^ Use `shared_examples` when you don't define context.
-          it 'performs actions' do
-          end
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        shared_examples 'foo' do
-          it 'performs actions' do
-          end
-        end
-      RUBY
-    end
-
-    it 'does not register an offense for `shared_context` with let' do
-      expect_no_offenses(<<-RUBY)
-        shared_context 'foo' do
-          let(:foo) { :bar }
-
-          it 'performs actions' do
-          end
-        end
-      RUBY
-    end
-
-    it 'does not register an offense for `shared_context` with subject' do
-      expect_no_offenses(<<-RUBY)
-        shared_context 'foo' do
-          subject(:foo) { :bar }
-
-          it 'performs actions' do
-          end
-        end
-      RUBY
-    end
-
-    it 'does not register an offense for `shared_context` with before' do
-      expect_no_offenses(<<-RUBY)
-        shared_context 'foo' do
-          before do
-            something
-          end
-
-          it 'performs actions' do
-          end
-        end
-      RUBY
-    end
-  end
-
-  describe 'shared_examples' do
-    it 'does not register an offense for empty examples' do
-      expect_no_offenses(<<-RUBY)
-        shared_examples 'empty' do
-        end
-      RUBY
-    end
-
-    it 'registers an offense for shared_examples with only let' do
-      expect_offense(<<-RUBY)
-        shared_examples 'foo' do
-        ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
-          let(:foo) { :bar }
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        shared_context 'foo' do
-          let(:foo) { :bar }
-        end
-      RUBY
-    end
-
-    it 'registers an offense for shared_examples with only subject' do
-      expect_offense(<<-RUBY)
-        shared_examples 'foo' do
-        ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
-          subject(:foo) { :bar }
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        shared_context 'foo' do
-          subject(:foo) { :bar }
-        end
-      RUBY
-    end
-
-    it 'registers an offense for shared_examples with only hooks' do
-      expect_offense(<<-RUBY)
-        shared_examples 'foo' do
-        ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
-          before do
-            foo
-          end
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        shared_context 'foo' do
-          before do
-            foo
-          end
-        end
-      RUBY
-    end
-
-    it 'does not register an offense for `shared_examples` with it' do
-      expect_no_offenses(<<-RUBY)
-        shared_examples 'foo' do
-          subject(:foo) { 'foo' }
-          let(:bar) { :baz }
-          before { initialize }
-
-          it 'works' do
-          end
-        end
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/shared_examples_spec.rb

@@ -1,75 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::SharedExamples do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense when using symbolic title' do
-    expect_offense(<<-RUBY)
-      it_behaves_like :foo_bar_baz
-                      ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-      it_should_behave_like :foo_bar_baz
-                            ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-      shared_examples :foo_bar_baz
-                      ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-      shared_examples_for :foo_bar_baz
-                          ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-      include_examples :foo_bar_baz
-                       ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-      include_examples :foo_bar_baz, 'foo', 'bar'
-                       ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-
-      shared_examples :foo_bar_baz, 'foo', 'bar' do |param|
-                      ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-        # ...
-      end
-
-      RSpec.shared_examples :foo_bar_baz
-                            ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
-    RUBY
-
-    expect_correction(<<-RUBY)
-      it_behaves_like 'foo bar baz'
-      it_should_behave_like 'foo bar baz'
-      shared_examples 'foo bar baz'
-      shared_examples_for 'foo bar baz'
-      include_examples 'foo bar baz'
-      include_examples 'foo bar baz', 'foo', 'bar'
-
-      shared_examples 'foo bar baz', 'foo', 'bar' do |param|
-        # ...
-      end
-
-      RSpec.shared_examples 'foo bar baz'
-    RUBY
-  end
-
-  it 'does not register an offense when using string title' do
-    expect_no_offenses(<<-RUBY)
-      it_behaves_like 'foo bar baz'
-      it_should_behave_like 'foo bar baz'
-      shared_examples 'foo bar baz'
-      shared_examples_for 'foo bar baz'
-      include_examples 'foo bar baz'
-      include_examples 'foo bar baz', 'foo', 'bar'
-
-      shared_examples 'foo bar baz', 'foo', 'bar' do |param|
-        # ...
-      end
-    RUBY
-  end
-
-  it 'does not register an offense when using Module/Class title' do
-    expect_no_offenses(<<-RUBY)
-      it_behaves_like FooBarBaz
-      it_should_behave_like FooBarBaz
-      shared_examples FooBarBaz
-      shared_examples_for FooBarBaz
-      include_examples FooBarBaz
-      include_examples FooBarBaz, 'foo', 'bar'
-
-      shared_examples FooBarBaz, 'foo', 'bar' do |param|
-        # ...
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb

@@ -1,178 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
-  subject(:cop) { described_class.new }
-
-  describe 'receive_message_chain' do
-    it 'reports single-argument calls' do
-      expect_offense(<<-RUBY)
-        before do
-          allow(foo).to receive_message_chain(:one) { :two }
-                        ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        before do
-          allow(foo).to receive(:one) { :two }
-        end
-      RUBY
-    end
-
-    it 'accepts multi-argument calls' do
-      expect_no_offenses(<<-RUBY)
-        before do
-          allow(foo).to receive_message_chain(:one, :two) { :three }
-        end
-      RUBY
-    end
-
-    it 'reports single-argument string calls' do
-      expect_offense(<<-RUBY)
-        before do
-          allow(foo).to receive_message_chain("one") { :two }
-                        ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        before do
-          allow(foo).to receive("one") { :two }
-        end
-      RUBY
-    end
-
-    it 'accepts multi-argument string calls' do
-      expect_no_offenses(<<-RUBY)
-        before do
-          allow(foo).to receive_message_chain("one.two") { :three }
-        end
-      RUBY
-    end
-
-    it 'accepts single-argument calls with variable' do
-      expect_no_offenses(<<-RUBY)
-        before do
-          foo = %i[:one :two]
-          allow(foo).to receive_message_chain(foo) { :many }
-        end
-      RUBY
-    end
-
-    it 'accepts single-argument calls with send node' do
-      expect_no_offenses(<<-RUBY)
-        before do
-          allow(foo).to receive_message_chain(foo) { :many }
-        end
-      RUBY
-    end
-
-    context 'with single-element array argument' do
-      it 'reports an offense' do
-        expect_offense(<<-RUBY)
-          before do
-            allow(foo).to receive_message_chain([:one]) { :two }
-                          ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
-          end
-        RUBY
-
-        expect_correction(<<-RUBY)
-          before do
-            allow(foo).to receive(:one) { :two }
-          end
-        RUBY
-      end
-    end
-
-    context 'with multiple-element array argument' do
-      it "doesn't report an offense" do
-        expect_no_offenses(<<-RUBY)
-          before do
-            allow(foo).to receive_message_chain([:one, :two]) { :many }
-          end
-        RUBY
-      end
-    end
-
-    context 'with single-key hash argument' do
-      it 'reports an offense' do
-        expect_offense(<<-RUBY)
-          before do
-            allow(foo).to receive_message_chain(bar: 42)
-                          ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
-            allow(foo).to receive_message_chain("bar" => 42)
-                          ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
-            allow(foo).to receive_message_chain(:"\#{foo}" => 42)
-                          ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
-          end
-        RUBY
-
-        expect_correction(<<-RUBY)
-          before do
-            allow(foo).to receive(:bar).and_return(42)
-            allow(foo).to receive("bar").and_return(42)
-            allow(foo).to receive(:"\#{foo}").and_return(42)
-          end
-        RUBY
-      end
-    end
-
-    context 'with multiple keys hash argument' do
-      it "doesn't report an offense" do
-        expect_no_offenses(<<-RUBY)
-          before do
-            allow(foo).to receive_message_chain(bar: 42, baz: 42)
-          end
-        RUBY
-      end
-    end
-  end
-
-  describe 'stub_chain' do
-    it 'reports single-argument calls' do
-      expect_offense(<<-RUBY)
-        before do
-          foo.stub_chain(:one) { :two }
-              ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        before do
-          foo.stub(:one) { :two }
-        end
-      RUBY
-    end
-
-    it 'accepts multi-argument calls' do
-      expect_no_offenses(<<-RUBY)
-        before do
-          foo.stub_chain(:one, :two) { :three }
-        end
-      RUBY
-    end
-
-    it 'reports single-argument string calls' do
-      expect_offense(<<-RUBY)
-        before do
-          foo.stub_chain("one") { :two }
-              ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        before do
-          foo.stub("one") { :two }
-        end
-      RUBY
-    end
-
-    it 'accepts multi-argument string calls' do
-      expect_no_offenses(<<-RUBY)
-        before do
-          foo.stub_chain("one.two") { :three }
-        end
-      RUBY
-    end
-  end
-end