rubocop-rspec 1.35.0 → 1.36.0

data/rubocop-rspec.gemspec

@@ -1,49 +0,0 @@
-# frozen_string_literal: true
-
-$LOAD_PATH.unshift File.expand_path('lib', __dir__)
-require 'rubocop/rspec/version'
-
-Gem::Specification.new do |spec|
-  spec.name = 'rubocop-rspec'
-  spec.summary = 'Code style checking for RSpec files'
-  spec.description = <<-DESCRIPTION
-    Code style checking for RSpec files.
-    A plugin for the RuboCop code style enforcing & linting tool.
-  DESCRIPTION
-  spec.homepage = 'https://github.com/rubocop-hq/rubocop-rspec'
-  spec.authors = ['John Backus', 'Ian MacLeod', 'Nils Gemeinhardt']
-  spec.email = [
-    'johncbackus@gmail.com',
-    'ian@nevir.net',
-    'git@nilsgemeinhardt.de'
-  ]
-  spec.licenses = ['MIT']
-
-  spec.version = RuboCop::RSpec::Version::STRING
-  spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.3.0'
-
-  spec.require_paths = ['lib']
-  spec.files = Dir[
-    '{config,lib,spec}/**/*',
-    '*.md',
-    '*.gemspec',
-    'Gemfile',
-    'Rakefile'
-  ]
-  spec.test_files = spec.files.grep(%r{^spec/})
-  spec.extra_rdoc_files = ['MIT-LICENSE.md', 'README.md']
-
-  spec.metadata = {
-    'changelog_uri' => 'https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md',
-    'documentation_uri' => 'https://rubocop-rspec.readthedocs.io/'
-  }
-
-  spec.add_runtime_dependency 'rubocop', '>= 0.60.0'
-
-  spec.add_development_dependency 'rack'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '>= 3.4'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'yard'
-end

data/spec/project/changelog_spec.rb

@@ -1,76 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe 'CHANGELOG.md' do
-  subject(:changelog) { SpecHelper::ROOT.join('CHANGELOG.md').read }
-
-  it 'has link definitions for all implicit links' do
-    implicit_link_names = changelog.scan(/\[([^\]]+)\]\[\]/).flatten.uniq
-    implicit_link_names.each do |name|
-      expect(changelog).to include("[#{name}]: http")
-    end
-  end
-
-  describe 'entry' do
-    subject(:entries) { lines.grep(/^\*/).map(&:chomp) }
-
-    let(:lines) { changelog.each_line }
-
-    it 'has a whitespace between the * and the body' do
-      expect(entries).to all(match(/^\* \S/))
-    end
-
-    it 'has a link to the contributors at the end' do
-      expect(entries).to all(match(/\(\[@\S+\]\[\](?:, \[@\S+\]\[\])*\)$/))
-    end
-
-    describe 'link to related issue on github' do
-      let(:issues) do
-        entries.map do |entry|
-          entry.match(/\[(?<number>[#\d]+)\]\((?<url>[^\)]+)\)/)
-        end.compact
-      end
-
-      it 'has an issue number prefixed with #' do
-        issues.each do |issue|
-          expect(issue[:number]).to match(/^#\d+$/)
-        end
-      end
-
-      it 'has a valid URL' do
-        issues.each do |issue|
-          number = issue[:number].gsub(/\D/, '')
-          pattern = %r{^https://github\.com/.+/.+/(?:issues|pull)/#{number}$} # rubocop:disable LineLength
-          expect(issue[:url]).to match(pattern)
-        end
-      end
-
-      it 'has a colon and a whitespace at the end' do
-        entries_including_issue_link = entries.select do |entry|
-          entry.match(/^\*\s*\[/)
-        end
-
-        expect(entries_including_issue_link).to all(include('): '))
-      end
-    end
-
-    describe 'body' do
-      let(:bodies) do
-        entries.map do |entry|
-          entry
-            .sub(/^\*\s*(?:\[.+?\):\s*)?/, '')
-            .sub(/\s*\([^\)]+\)$/, '')
-        end
-      end
-
-      it 'does not start with a lower case' do
-        bodies.each do |body|
-          expect(body).not_to match(/^[a-z]/)
-        end
-      end
-
-      it 'ends with a punctuation' do
-        expect(bodies).to all(match(/[\.\!]$/))
-      end
-    end
-  end
-end

data/spec/project/default_config_spec.rb

@@ -1,76 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe 'config/default.yml' do
-  subject(:default_config) do
-    RuboCop::ConfigLoader.load_file('config/default.yml')
-  end
-
-  let(:namespaces) do
-    {
-      'rspec' => 'RSpec',
-      'capybara' => 'Capybara',
-      'factory_bot' => 'FactoryBot',
-      'rails' => 'Rails'
-    }
-  end
-
-  let(:cop_names) do
-    glob = SpecHelper::ROOT.join('lib', 'rubocop', 'cop', 'rspec',
-                                 '{,capybara,factory_bot,rails}', '*.rb')
-    cop_names =
-      Pathname.glob(glob).map do |file|
-        file_name = file.basename('.rb').to_s
-        cop_name  = file_name.gsub(/(^|_)(.)/) { Regexp.last_match(2).upcase }
-        namespace = namespaces[file.dirname.basename.to_s]
-        "#{namespace}/#{cop_name}"
-      end
-
-    cop_names - %w[RSpec/Cop]
-  end
-
-  let(:config_keys) do
-    cop_names + %w[AllCops]
-  end
-
-  def cop_configuration(config_key)
-    cop_names.map do |cop_name|
-      cop_config = default_config[cop_name]
-
-      cop_config.fetch(config_key) do
-        raise "Expected #{cop_name} to have #{config_key} configuration key"
-      end
-    end
-  end
-
-  it 'has configuration for all cops' do
-    expect(default_config.keys).to match_array(config_keys)
-  end
-
-  it 'sorts configuration keys alphabetically' do
-    namespaces.each do |_path, prefix|
-      expected = config_keys.select { |key| key.start_with?(prefix) }.sort
-      actual = default_config.keys.select { |key| key.start_with?(prefix) }
-      actual.each_with_index do |key, idx|
-        expect(key).to eq expected[idx]
-      end
-    end
-  end
-
-  it 'has descriptions for all cops' do
-    expect(cop_configuration('Description')).to all(be_a(String))
-  end
-
-  it 'does not have newlines in cop descriptions' do
-    cop_configuration('Description').each do |value|
-      expect(value).not_to include("\n")
-    end
-  end
-
-  it 'ends every description with a period' do
-    expect(cop_configuration('Description')).to all(end_with('.'))
-  end
-
-  it 'includes Enabled: true for every cop' do
-    expect(cop_configuration('Enabled')).to all(be(true).or(be(false)))
-  end
-end

data/spec/project/project_requires_spec.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe 'Project requires' do
-  it 'alphabetizes cop requires' do
-    source   = SpecHelper::ROOT.join('lib', 'rubocop', 'cop', 'rspec_cops.rb')
-    captures = source.read.scan(%r{^(require_relative 'rspec/(.*?/)?(.*?)')$})
-
-    require_statements = captures.map(&:first)
-    sorted_require_statements =
-      captures.sort_by do |_require_statement, cop_category, name|
-        [cop_category || 'rspec', name]
-      end.map(&:first)
-
-    aggregate_failures do
-      # Sanity check that we actually discovered require statements.
-      expect(captures).not_to be_empty
-      expect(require_statements).to eql(sorted_require_statements)
-    end
-  end
-end

data/spec/rubocop/cop/rspec/align_left_let_brace_spec.rb

@@ -1,51 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::AlignLeftLetBrace do
-  subject(:cop) { described_class.new }
-
-  # rubocop:disable RSpec/ExampleLength
-  it 'registers offense for unaligned braces' do
-    expect_offense(<<-RUBY)
-      let(:foo) { bar }
-                ^ Align left let brace
-      let(:hi) { baz }
-               ^ Align left let brace
-      let(:blahblah) { baz }
-
-      let(:thing) { ignore_this }
-      let(:other) {
-        ignore_this_too
-      }
-
-      describe 'blah' do
-        let(:long_name) { thing }
-        let(:blah) { thing }
-                   ^ Align left let brace
-        let(:a) { thing }
-                ^ Align left let brace
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      let(:foo)      { bar }
-      let(:hi)       { baz }
-      let(:blahblah) { baz }
-
-      let(:thing) { ignore_this }
-      let(:other) {
-        ignore_this_too
-      }
-
-      describe 'blah' do
-        let(:long_name) { thing }
-        let(:blah)      { thing }
-        let(:a)         { thing }
-      end
-    RUBY
-  end
-  # rubocop:enable RSpec/ExampleLength
-
-  it 'works with empty file' do
-    expect_no_offenses('')
-  end
-end

data/spec/rubocop/cop/rspec/align_right_let_brace_spec.rb

@@ -1,51 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::AlignRightLetBrace do
-  subject(:cop) { described_class.new }
-
-  # rubocop:disable RSpec/ExampleLength
-  it 'registers offense for unaligned braces' do
-    expect_offense(<<-RUBY)
-      let(:foo)      { a }
-                         ^ Align right let brace
-      let(:hi)       { ab }
-                          ^ Align right let brace
-      let(:blahblah) { abcd }
-
-      let(:thing) { ignore_this }
-      let(:other) {
-        ignore_this_too
-      }
-
-      describe 'blah' do
-        let(:blahblah) { a }
-                           ^ Align right let brace
-        let(:blah)     { bc }
-                            ^ Align right let brace
-        let(:a)        { abc }
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      let(:foo)      { a    }
-      let(:hi)       { ab   }
-      let(:blahblah) { abcd }
-
-      let(:thing) { ignore_this }
-      let(:other) {
-        ignore_this_too
-      }
-
-      describe 'blah' do
-        let(:blahblah) { a   }
-        let(:blah)     { bc  }
-        let(:a)        { abc }
-      end
-    RUBY
-  end
-  # rubocop:enable RSpec/ExampleLength
-
-  it 'works with empty file' do
-    expect_no_offenses('')
-  end
-end

data/spec/rubocop/cop/rspec/any_instance_spec.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::AnyInstance do
-  subject(:cop) { described_class.new }
-
-  it 'finds `allow_any_instance_of` instead of an instance double' do
-    expect_offense(<<-RUBY)
-      before do
-        allow_any_instance_of(Object).to receive(:foo)
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid stubbing using `allow_any_instance_of`.
-      end
-    RUBY
-  end
-
-  it 'finds `expect_any_instance_of` instead of an instance double' do
-    expect_offense(<<-RUBY)
-      before do
-        expect_any_instance_of(Object).to receive(:foo)
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid stubbing using `expect_any_instance_of`.
-      end
-    RUBY
-  end
-
-  it 'finds old `any_instance` syntax instead of an instance double' do
-    expect_offense(<<-RUBY)
-      before do
-        Object.any_instance.should_receive(:foo)
-        ^^^^^^^^^^^^^^^^^^^ Avoid stubbing using `any_instance`.
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/around_block_spec.rb

@@ -1,121 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
-  subject(:cop) { described_class.new }
-
-  context 'when no value is yielded' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY)
-        around do
-        ^^^^^^^^^ Test object should be passed to around block.
-          do_something
-        end
-      RUBY
-    end
-  end
-
-  context 'when the hook is scoped with a symbol' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY)
-        around(:each) do
-        ^^^^^^^^^^^^^^^^ Test object should be passed to around block.
-          do_something
-        end
-      RUBY
-    end
-  end
-
-  context 'when the yielded value is unused' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY)
-        around do |test|
-                   ^^^^ You should call `test.call` or `test.run`.
-          do_something
-        end
-      RUBY
-    end
-  end
-
-  context 'when two values are yielded and the first is unused' do
-    it 'registers an offense for the first argument' do
-      expect_offense(<<-RUBY)
-        around do |test, unused|
-                   ^^^^ You should call `test.call` or `test.run`.
-          unused.run
-        end
-      RUBY
-    end
-  end
-
-  context 'when the yielded value is referenced but not used' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY)
-        around do |test|
-                   ^^^^ You should call `test.call` or `test.run`.
-          test
-        end
-      RUBY
-    end
-  end
-
-  context 'when a method other than #run or #call is called' do
-    it 'registers an offense' do
-      expect_offense(<<-RUBY)
-        around do |test|
-                   ^^^^ You should call `test.call` or `test.run`.
-          test.inspect
-        end
-      RUBY
-    end
-  end
-
-  context 'when #run is called' do
-    it 'does not register an offense' do
-      expect_no_offenses(<<-RUBY)
-        around do |test|
-          test.run
-        end
-      RUBY
-    end
-  end
-
-  context 'when #call is called' do
-    it 'does not register an offense' do
-      expect_no_offenses(<<-RUBY)
-        around do |test|
-          test.call
-        end
-      RUBY
-    end
-  end
-
-  context 'when used as a block arg' do
-    it 'does not register an offense' do
-      expect_no_offenses(<<-RUBY)
-        around do |test|
-          1.times(&test)
-        end
-      RUBY
-    end
-  end
-
-  context 'when passed to another method' do
-    it 'does not register an offense' do
-      expect_no_offenses(<<-RUBY)
-        around do |test|
-          something_that_might_run_test(test, another_arg)
-        end
-      RUBY
-    end
-  end
-
-  context 'when yielded to another block' do
-    it 'does not register an offense' do
-      expect_no_offenses(<<-RUBY)
-        around do |test|
-          foo { yield(some_arg, test) }
-        end
-      RUBY
-    end
-  end
-end