rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/expect_actual_spec.rb

@@ -1,150 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
-  subject(:cop) { described_class.new(config) }
-
-  it 'flags numeric literal values within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect(123).to eq(bar)
-                 ^^^ Provide the actual you are testing to `expect(...)`.
-          expect(12.3).to eq(bar)
-                 ^^^^ Provide the actual you are testing to `expect(...)`.
-          expect(1i).to eq(bar)
-                 ^^ Provide the actual you are testing to `expect(...)`.
-          expect(1r).to eq(bar)
-                 ^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags boolean literal values within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect(true).to eq(bar)
-                 ^^^^ Provide the actual you are testing to `expect(...)`.
-          expect(false).to eq(bar)
-                 ^^^^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags string and symbol literal values within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect("foo").to eq(bar)
-                 ^^^^^ Provide the actual you are testing to `expect(...)`.
-          expect(:foo).to eq(bar)
-                 ^^^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags literal nil value within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect(nil).to eq(bar)
-                 ^^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'does not flag dynamic values within expect(...)' do
-    expect_no_offenses(<<-'RUBY')
-      describe Foo do
-        it 'uses expect correctly' do
-          expect(foo).to eq(bar)
-          expect("foo#{baz}").to eq(bar)
-          expect(:"foo#{baz}").to  eq(bar)
-        end
-      end
-    RUBY
-  end
-
-  it 'flags arrays containing only literal values within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect([123]).to eq(bar)
-                 ^^^^^ Provide the actual you are testing to `expect(...)`.
-          expect([[123]]).to eq(bar)
-                 ^^^^^^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags hashes containing only literal values within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect(foo: 1, bar: 2).to eq(bar)
-                 ^^^^^^^^^^^^^^ Provide the actual you are testing to `expect(...)`.
-          expect(foo: 1, bar: [{}]).to eq(bar)
-                 ^^^^^^^^^^^^^^^^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags ranges containing only literal values within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect(1..2).to eq(bar)
-                 ^^^^ Provide the actual you are testing to `expect(...)`.
-          expect(1...2).to eq(bar)
-                 ^^^^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'flags regexps containing only literal values within expect(...)' do
-    expect_offense(<<-RUBY)
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect(/foo|bar/).to eq(bar)
-                 ^^^^^^^^^ Provide the actual you are testing to `expect(...)`.
-        end
-      end
-    RUBY
-  end
-
-  it 'does not flag complex values with dynamic parts within expect(...)' do
-    expect_no_offenses(<<-'RUBY')
-      describe Foo do
-        it 'uses expect incorrectly' do
-          expect.to eq(bar)
-          expect([foo]).to eq(bar)
-          expect([[foo]]).to eq(bar)
-          expect(foo: 1, bar: foo).to eq(bar)
-          expect(1..foo).to eq(bar)
-          expect(1...foo).to eq(bar)
-          expect(/foo|#{bar}/).to eq(bar)
-        end
-      end
-    RUBY
-  end
-
-  context 'when inspecting rspec-rails routing specs' do
-    let(:cop_config) { {} }
-
-    it 'ignores rspec-rails routing specs' do
-      inspect_source(
-        'expect(get: "/foo").to be_routeable',
-        'spec/routing/foo_spec.rb'
-      )
-
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/rspec/expect_change_spec.rb

@@ -1,86 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ExpectChange, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) do
-    { 'EnforcedStyle' => enforced_style }
-  end
-
-  context 'with EnforcedStyle `method_call`' do
-    let(:enforced_style) { 'method_call' }
-
-    it 'finds blocks that contain simple message sending' do
-      expect_offense(<<-RUBY)
-        it do
-          expect(run).to change { User.count }.by(1)
-                         ^^^^^^^^^^^^^^^^^^^^^ Prefer `change(User, :count)`.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it do
-          expect(run).to change(User, :count).by(1)
-        end
-      RUBY
-    end
-
-    it 'ignores blocks that cannot be converted to obj/attribute pair' do
-      expect_no_offenses(<<-RUBY)
-        it do
-          expect(run).to change { User.sum(:points) }
-        end
-      RUBY
-    end
-
-    it 'ignores change method of object that happens to receive a block' do
-      expect_no_offenses(<<-RUBY)
-        it do
-          Record.change { User.count }
-        end
-      RUBY
-    end
-  end
-
-  context 'with EnforcedStyle `block`' do
-    let(:enforced_style) { 'block' }
-
-    it 'finds change matcher without block' do
-      expect_offense(<<-RUBY)
-        it do
-          expect(run).to change(User, :count).by(1)
-                         ^^^^^^^^^^^^^^^^^^^^ Prefer `change { User.count }`.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it do
-          expect(run).to change { User.count }.by(1)
-        end
-      RUBY
-    end
-
-    it 'finds change matcher when receiver is a variable' do
-      expect_offense(<<-RUBY)
-        it do
-          expect(run).to change(user, :count)
-                         ^^^^^^^^^^^^^^^^^^^^ Prefer `change { user.count }`.
-        end
-      RUBY
-
-      expect_correction(<<-RUBY)
-        it do
-          expect(run).to change { user.count }
-        end
-      RUBY
-    end
-
-    it 'ignores methods called change' do
-      expect_no_offenses(<<-RUBY)
-        it do
-          record.change(user, :count)
-        end
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/expect_in_hook_spec.rb

@@ -1,79 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ExpectInHook do
-  subject(:cop) { described_class.new }
-
-  it 'adds an offense for `expect` in `before` hook' do
-    expect_offense(<<-RUBY)
-      before do
-        expect(something).to eq('foo')
-        ^^^^^^ Do not use `expect` in `before` hook
-        is_expected.to eq('foo')
-        ^^^^^^^^^^^ Do not use `is_expected` in `before` hook
-        expect_any_instance_of(Something).to receive(:foo)
-        ^^^^^^^^^^^^^^^^^^^^^^ Do not use `expect_any_instance_of` in `before` hook
-      end
-    RUBY
-  end
-
-  it 'adds an offense for `expect` in `after` hook' do
-    expect_offense(<<-RUBY)
-      after do
-        expect(something).to eq('foo')
-        ^^^^^^ Do not use `expect` in `after` hook
-        is_expected.to eq('foo')
-        ^^^^^^^^^^^ Do not use `is_expected` in `after` hook
-        expect_any_instance_of(Something).to receive(:foo)
-        ^^^^^^^^^^^^^^^^^^^^^^ Do not use `expect_any_instance_of` in `after` hook
-      end
-    RUBY
-  end
-
-  it 'adds an offense for `expect` in `around` hook' do
-    expect_offense(<<-RUBY)
-      around do
-        expect(something).to eq('foo')
-        ^^^^^^ Do not use `expect` in `around` hook
-        is_expected(something).to eq('foo')
-        ^^^^^^^^^^^ Do not use `is_expected` in `around` hook
-        expect_any_instance_of(Something).to receive(:foo)
-        ^^^^^^^^^^^^^^^^^^^^^^ Do not use `expect_any_instance_of` in `around` hook
-      end
-    RUBY
-  end
-
-  it 'adds an offense for `expect` with block in `before` hook' do
-    expect_offense(<<-RUBY)
-      before do
-        expect { something }.to eq('foo')
-        ^^^^^^ Do not use `expect` in `before` hook
-      end
-    RUBY
-  end
-
-  it 'accepts an empty `before` hook' do
-    expect_no_offenses(<<-RUBY)
-      before do
-      end
-    RUBY
-  end
-
-  it 'accepts `allow` in `before` hook' do
-    expect_no_offenses(<<-RUBY)
-      before do
-        allow(something).to receive(:foo)
-        allow_any_instance_of(something).to receive(:foo)
-      end
-    RUBY
-  end
-
-  it 'accepts `expect` in `it`' do
-    expect_no_offenses(<<-RUBY)
-      it do
-        expect(something).to eq('foo')
-        is_expected.to eq('foo')
-        expect_any_instance_of(something).to receive(:foo)
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/expect_output_spec.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for overwriting $stdout within an example' do
-    expect_offense(<<-RUBY)
-      specify do
-        $stdout = StringIO.new
-        ^^^^^^^ Use `expect { ... }.to output(...).to_stdout` instead of mutating $stdout.
-      end
-    RUBY
-  end
-
-  it 'registers an offense for overwriting $stderr ' \
-     'within an example scoped hook' do
-    expect_offense(<<-RUBY)
-      before(:each) do
-        $stderr = StringIO.new
-        ^^^^^^^ Use `expect { ... }.to output(...).to_stderr` instead of mutating $stderr.
-      end
-    RUBY
-  end
-
-  it 'does not register an offense for interacting with $stdout' do
-    expect_no_offenses(<<-RUBY)
-      specify do
-        $stdout.puts("hi")
-      end
-    RUBY
-  end
-
-  it 'does not flag assignments to other global variables' do
-    expect_no_offenses(<<-RUBY)
-      specify do
-        $blah = StringIO.new
-      end
-    RUBY
-  end
-
-  it 'does not flag assignments to $stdout outside of example scope' do
-    expect_no_offenses(<<-RUBY)
-      before(:suite) do
-        $stderr = StringIO.new
-      end
-    RUBY
-  end
-
-  it 'does not flag assignments to $stdout in example_group scope' do
-    expect_no_offenses(<<-RUBY)
-      describe Foo do
-        $stderr = StringIO.new
-      end
-    RUBY
-  end
-
-  it 'does not flag assigns to $stdout when in the root scope' do
-    expect_no_offenses('$stderr = StringIO.new')
-  end
-end

data/spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb

@@ -1,208 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically do # rubocop:disable Metrics/LineLength
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for offending code' do
-    expect_offense(<<-RUBY)
-      FactoryBot.define do
-        factory :post do
-          title "Something"
-          ^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          published_at 1.day.from_now
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          status [:draft, :published].sample
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          created_at 1.day.ago
-          ^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          update_times [Time.current]
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          meta_tags(foo: Time.current)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-        end
-      end
-    RUBY
-  end
-
-  it 'registers an offense in a trait' do
-    expect_offense(<<-RUBY)
-      FactoryBot.define do
-        factory :post do
-          trait :published do
-            title "Something"
-            ^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-            published_at 1.day.from_now
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'registers an offense in a transient block' do
-    expect_offense(<<-RUBY)
-      FactoryBot.define do
-        factory :post do
-          transient do
-            title "Something"
-            ^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-            published_at 1.day.from_now
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'registers an offense for an attribute defined on `self`' do
-    expect_offense(<<-RUBY)
-      FactoryBot.define do
-        factory :post do
-          self.start { Date.today }
-          self.end Date.tomorrow
-          ^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-        end
-      end
-    RUBY
-  end
-
-  it 'registers an offense for attributes defined on explicit receiver' do
-    expect_offense(<<-RUBY)
-      FactoryBot.define do
-        factory :post do |post_definition|
-          post_definition.end Date.tomorrow
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          post_definition.trait :published do |published_definition|
-            published_definition.published_at 1.day.from_now
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'accepts valid factory definitions' do
-    expect_no_offenses(<<-RUBY)
-      FactoryBot.define do
-        factory :post do
-          trait :published do
-            published_at { 1.day.from_now }
-          end
-          created_at { 1.day.ago }
-          status { :draft }
-          comments_count { 0 }
-          title { "Static" }
-          description { FFaker::Lorem.paragraph(10) }
-          recent_statuses { [] }
-          tags { { like_count: 2 } }
-
-          before(:create, &:initialize_something)
-          after(:create, &:rebuild_cache)
-        end
-      end
-    RUBY
-  end
-
-  it 'does not add offense if out of factory bot block' do
-    expect_no_offenses(<<-RUBY)
-      status [:draft, :published].sample
-      published_at 1.day.from_now
-      created_at 1.day.ago
-      update_times [Time.current]
-      meta_tags(foo: Time.current)
-    RUBY
-  end
-
-  it 'does not add offense if method called on another object' do
-    expect_no_offenses(<<-RUBY)
-      FactoryBot.define do
-        factory :post do |post_definition|
-          Registrar.register :post_factory
-        end
-      end
-    RUBY
-  end
-
-  it 'does not add offense if method called on a local variable' do
-    expect_no_offenses(<<-RUBY)
-      FactoryBot.define do
-        factory :post do |post_definition|
-          local = Registrar
-          local.register :post_factory
-        end
-      end
-    RUBY
-  end
-
-  it 'accepts valid association definitions' do
-    expect_no_offenses(<<-RUBY)
-      FactoryBot.define do
-        factory :post do
-          author age: 42, factory: :user
-        end
-      end
-    RUBY
-  end
-
-  it 'accepts valid sequence definition' do
-    expect_no_offenses(<<-RUBY)
-      FactoryBot.define do
-        factory :post do
-          sequence :negative_numbers, &:-@
-        end
-      end
-    RUBY
-  end
-
-  bad = <<-RUBY
-    FactoryBot.define do
-      factory :post do
-        title "Something"
-        comments_count 0
-        tag Tag::MAGIC
-        recent_statuses []
-        status([:draft, :published].sample)
-        published_at 1.day.from_now
-        created_at(1.day.ago)
-        updated_at Time.current
-        update_times [Time.current]
-        meta_tags(foo: Time.current)
-        other_tags({ foo: Time.current })
-        options color: :blue
-        other_options Tag::MAGIC => :magic
-        self.end Date.tomorrow
-
-        trait :old do
-          published_at 1.week.ago
-        end
-      end
-    end
-  RUBY
-
-  corrected = <<-RUBY
-    FactoryBot.define do
-      factory :post do
-        title { "Something" }
-        comments_count { 0 }
-        tag { Tag::MAGIC }
-        recent_statuses { [] }
-        status { [:draft, :published].sample }
-        published_at { 1.day.from_now }
-        created_at { 1.day.ago }
-        updated_at { Time.current }
-        update_times { [Time.current] }
-        meta_tags { { foo: Time.current } }
-        other_tags { { foo: Time.current } }
-        options { { color: :blue } }
-        other_options { { Tag::MAGIC => :magic } }
-        self.end { Date.tomorrow }
-
-        trait :old do
-          published_at { 1.week.ago }
-        end
-      end
-    end
-  RUBY
-
-  include_examples 'autocorrect', bad, corrected
-end