rubocop-rspec 1.35.0 → 1.36.0

data/spec/rubocop/cop/rspec/hook_argument_spec.rb

@@ -1,173 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) do
-    { 'EnforcedStyle' => enforced_style }
-  end
-
-  shared_examples 'ignored hooks' do
-    it 'ignores :context and :suite' do
-      expect_no_offenses(<<-RUBY)
-        before(:suite) { true }
-        after(:suite) { true }
-        before(:context) { true }
-        after(:context) { true }
-      RUBY
-    end
-
-    it 'ignores hooks with more than one argument' do
-      expect_no_offenses(<<-RUBY)
-        before(:each, :something_custom) { true }
-      RUBY
-    end
-
-    it 'ignores non-rspec hooks' do
-      expect_no_offenses(<<-RUBY)
-        setup(:each) { true }
-      RUBY
-    end
-  end
-
-  shared_examples 'hook autocorrect' do |output|
-    include_examples 'autocorrect', 'before(:each) { }', output
-    include_examples 'autocorrect', 'before(:example) { }', output
-    include_examples 'autocorrect', 'before { }', output
-
-    include_examples 'autocorrect', 'config.before(:each) { }',
-                     'config.' + output
-    include_examples 'autocorrect', 'config.before(:example) { }',
-                     'config.' + output
-    include_examples 'autocorrect', 'config.before { }',
-                     'config.' + output
-  end
-
-  shared_examples 'an example hook' do
-    include_examples 'ignored hooks'
-    include_examples 'detects style', 'before(:each) { foo }', 'each'
-    include_examples 'detects style', 'before(:example) { foo }', 'example'
-    include_examples 'detects style', 'before { foo }', 'implicit'
-  end
-
-  context 'when EnforcedStyle is :implicit' do
-    let(:enforced_style) { :implicit }
-
-    it 'detects :each for hooks' do
-      expect_offense(<<-RUBY)
-        before(:each) { true }
-        ^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
-        after(:each)  { true }
-        ^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
-        around(:each) { true }
-        ^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
-        config.after(:each)  { true }
-        ^^^^^^^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
-      RUBY
-    end
-
-    it 'detects :example for hooks' do
-      expect_offense(<<-RUBY)
-        before(:example) { true }
-        ^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
-        after(:example)  { true }
-        ^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
-        around(:example) { true }
-        ^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
-        config.before(:example) { true }
-        ^^^^^^^^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
-      RUBY
-    end
-
-    it 'does not flag hooks without default scopes' do
-      expect_no_offenses(<<-RUBY)
-        before { true }
-        after { true }
-        config.before { true }
-      RUBY
-    end
-
-    include_examples 'an example hook'
-    include_examples 'hook autocorrect', 'before { }'
-  end
-
-  context 'when EnforcedStyle is :each' do
-    let(:enforced_style) { :each }
-
-    it 'detects :each for hooks' do
-      expect_no_offenses(<<-RUBY)
-        before(:each) { true }
-        after(:each)  { true }
-        around(:each) { true }
-        config.before(:each) { true }
-      RUBY
-    end
-
-    it 'detects :example for hooks' do
-      expect_offense(<<-RUBY)
-        before(:example) { true }
-        ^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
-        after(:example)  { true }
-        ^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
-        around(:example) { true }
-        ^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
-        config.before(:example) { true }
-        ^^^^^^^^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
-      RUBY
-    end
-
-    it 'detects hooks without default scopes' do
-      expect_offense(<<-RUBY)
-        before { true }
-        ^^^^^^ Use `:each` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:each` for RSpec hooks.
-        config.before { true }
-               ^^^^^^ Use `:each` for RSpec hooks.
-      RUBY
-    end
-
-    include_examples 'an example hook'
-    include_examples 'hook autocorrect', 'before(:each) { }'
-  end
-
-  context 'when EnforcedStyle is :example' do
-    let(:enforced_style) { :example }
-
-    it 'detects :example for hooks' do
-      expect_no_offenses(<<-RUBY)
-        before(:example) { true }
-        after(:example)  { true }
-        around(:example) { true }
-        config.before(:example) { true }
-      RUBY
-    end
-
-    it 'detects :each for hooks' do
-      expect_offense(<<-RUBY)
-        before(:each) { true }
-        ^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
-        after(:each)  { true }
-        ^^^^^^^^^^^^ Use `:example` for RSpec hooks.
-        around(:each) { true }
-        ^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
-        config.before(:each) { true }
-        ^^^^^^^^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
-      RUBY
-    end
-
-    it 'does not flag hooks without default scopes' do
-      expect_offense(<<-RUBY)
-        before { true }
-        ^^^^^^ Use `:example` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:example` for RSpec hooks.
-        config.before { true }
-               ^^^^^^ Use `:example` for RSpec hooks.
-      RUBY
-    end
-
-    include_examples 'an example hook'
-    include_examples 'hook autocorrect', 'before(:example) { }'
-  end
-end

data/spec/rubocop/cop/rspec/hooks_before_examples_spec.rb

@@ -1,150 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::HooksBeforeExamples do
-  subject(:cop) { described_class.new }
-
-  it 'flags `before` after `it`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        it { is_expected.to be_after_before_hook }
-        before { setup }
-        ^^^^^^^^^^^^^^^^ Move `before` above the examples in the group.
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        before { setup }
-        it { is_expected.to be_after_before_hook }
-      end
-    RUBY
-  end
-
-  it 'flags `before` after `context`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        context 'a context' do
-          it { is_expected.to be_after_before_hook }
-        end
-
-        before { setup }
-        ^^^^^^^^^^^^^^^^ Move `before` above the examples in the group.
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        before { setup }
-        context 'a context' do
-          it { is_expected.to be_after_before_hook }
-        end
-
-      end
-    RUBY
-  end
-
-  it 'flags `before` after `include_examples`' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        include_examples('should be after before-hook')
-
-        before { setup }
-        ^^^^^^^^^^^^^^^^ Move `before` above the examples in the group.
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        before { setup }
-        include_examples('should be after before-hook')
-
-      end
-    RUBY
-  end
-
-  it 'flags `after` after an example' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        it { is_expected.to be_after_after_hook }
-        after { cleanup }
-        ^^^^^^^^^^^^^^^^^ Move `after` above the examples in the group.
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        after { cleanup }
-        it { is_expected.to be_after_after_hook }
-      end
-    RUBY
-  end
-
-  it 'flags scoped hook after an example' do
-    expect_offense(<<-RUBY)
-      RSpec.describe User do
-        it { is_expected.to be_after_before_hook }
-        before(:each) { cleanup }
-        ^^^^^^^^^^^^^^^^^^^^^^^^^ Move `before` above the examples in the group.
-      end
-    RUBY
-
-    expect_correction(<<-RUBY)
-      RSpec.describe User do
-        before(:each) { cleanup }
-        it { is_expected.to be_after_before_hook }
-      end
-    RUBY
-  end
-
-  it 'does not flag hooks before the examples' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        before(:each) { setup }
-        after(:each) { cleanup }
-
-        it { is_expected.to be_after_hooks }
-
-        context 'a context' do
-          it { is_expected.to work }
-        end
-
-        include_examples('everything is fine')
-      end
-    RUBY
-  end
-
-  it 'does not flag `before` in a nested context' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        before { setup }
-
-        context 'something else' do
-          before { additional_setup }
-          it { is_expected.to work }
-        end
-
-        include_examples('everything is fine')
-      end
-    RUBY
-  end
-
-  it 'allows inclusion of context before hooks' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        include_context 'special user'
-
-        before { setup }
-      end
-    RUBY
-  end
-
-  it 'ignores single-line example blocks' do
-    expect_no_offenses(<<-RUBY)
-      RSpec.describe User do
-        include_examples 'special user' do
-          before { setup }
-        end
-      end
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/implicit_block_expectation_spec.rb

@@ -1,135 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::ImplicitBlockExpectation do
-  subject(:cop) { described_class.new }
-
-  it 'flags lambda in subject' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject { -> { boom } }
-        it { is_expected.to change { something }.to(new_value) }
-             ^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'ignores non-lambda subject' do
-    expect_no_offenses(<<-RUBY)
-      describe do
-        subject { 'normal' }
-        it { is_expected.to eq(something) }
-      end
-    RUBY
-  end
-
-  it 'flags lambda in subject!' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject! { -> { boom } }
-        it { is_expected.to change { something }.to(new_value) }
-             ^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'flags literal lambda' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject! { lambda { boom } }
-        it { is_expected.to change { something }.to(new_value) }
-             ^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'flags proc' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject! { proc { boom } }
-        it { is_expected.to change { something }.to(new_value) }
-             ^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'flags Proc.new' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject! { Proc.new { boom } }
-        it { is_expected.to change { something }.to(new_value) }
-             ^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'flags named subject' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject(:name) { -> { boom } }
-        it { is_expected.to change { something }.to(new_value) }
-             ^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'flags when subject is defined in the outer example group' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject { -> { boom } }
-        context do
-          it { is_expected.to change { something }.to(new_value) }
-               ^^^^^^^^^^^ Avoid implicit block expectations.
-        end
-      end
-    RUBY
-  end
-
-  it 'ignores normal local subject' do
-    expect_no_offenses(<<-RUBY)
-      describe do
-        subject { -> { boom } }
-        context do
-          subject { 'normal' }
-          it { is_expected.to eq(something) }
-        end
-      end
-    RUBY
-  end
-
-  it 'ignores named subject with deeply nested lambda' do
-    expect_no_offenses(<<-RUBY)
-      describe do
-        subject { {hash: -> { boom }} }
-        it { is_expected.to be(something) }
-      end
-    RUBY
-  end
-
-  it 'flags with `should` as implicit subject' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject { -> { boom } }
-        it { should change { something }.to(new_value) }
-             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'flags with `should_not` as implicit subject' do
-    expect_offense(<<-RUBY)
-      describe do
-        subject { -> { boom } }
-        it { should_not change { something }.to(new_value) }
-             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid implicit block expectations.
-      end
-    RUBY
-  end
-
-  it 'ignores when there is no subject defined' do
-    expect_no_offenses(<<-RUBY)
-      shared_examples 'subject is defined somewhere else' do
-        it { is_expected.to change { something }.to(new_value) }
-      end
-    RUBY
-  end
-end