rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/prepares/schema_prepare_spec.rb

@@ -1,28 +1,32 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Prepares::SchemaPrepare do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:prepares => RailsBestPractices::Prepares::SchemaPrepare.new) }
+module RailsBestPractices
+  module Prepares
+    describe SchemaPrepare do
+      let(:runner) { Core::Runner.new(:prepares => SchemaPrepare.new) }
 
-  it "should parse model attributes" do
-    content =<<-EOF
-    ActiveRecord::Schema.define(:version => 20110319172136) do
-      create_table "posts", :force => true do |t|
-        t.string   "title"
-        t.text     "body",           :limit => 16777215
-        t.datetime "created_at"
-        t.integer  "user_id"
-        t.integer  "comments_count",                     :default => 0
-        t.boolean  "published",                          :default => false, :null => false
+      it "should parse model attributes" do
+        content =<<-EOF
+        ActiveRecord::Schema.define(:version => 20110319172136) do
+          create_table "posts", :force => true do |t|
+            t.string   "title"
+            t.text     "body",           :limit => 16777215
+            t.datetime "created_at"
+            t.integer  "user_id"
+            t.integer  "comments_count",                     :default => 0
+            t.boolean  "published",                          :default => false, :null => false
+          end
+        end
+        EOF
+        runner.prepare("db/schema.rb", content)
+        model_attributes = Prepares.model_attributes
+        model_attributes.get_attribute_type("Post", "title").should == "string"
+        model_attributes.get_attribute_type("Post", "body").should == "text"
+        model_attributes.get_attribute_type("Post", "created_at").should == "datetime"
+        model_attributes.get_attribute_type("Post", "user_id").should == "integer"
+        model_attributes.get_attribute_type("Post", "comments_count").should == "integer"
+        model_attributes.get_attribute_type("Post", "published").should == "boolean"
       end
     end
-    EOF
-    runner.prepare("db/schema.rb", content)
-    model_attributes = RailsBestPractices::Prepares.model_attributes
-    model_attributes.get_attribute_type("Post", "title").should == "string"
-    model_attributes.get_attribute_type("Post", "body").should == "text"
-    model_attributes.get_attribute_type("Post", "created_at").should == "datetime"
-    model_attributes.get_attribute_type("Post", "user_id").should == "integer"
-    model_attributes.get_attribute_type("Post", "comments_count").should == "integer"
-    model_attributes.get_attribute_type("Post", "published").should == "boolean"
   end
 end

data/spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb

@@ -1,105 +1,103 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::AddModelVirtualAttributeReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::AddModelVirtualAttributeReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe AddModelVirtualAttributeReview do
+      let(:runner) { Core::Runner.new(:reviews => AddModelVirtualAttributeReview.new) }
 
-  it "should add model virtual attribute" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:full_name].split(' ', 2).first
-        @user.last_name = params[:full_name].split(' ', 2).last
-        @user.save
+      it "should add model virtual attribute" do
+        content = <<-EOF
+        class UsersController < ApplicationController
+          def create
+            @user = User.new(params[:user])
+            @user.first_name = params[:full_name].split(' ', 2).first
+            @user.last_name = params[:full_name].split(' ', 2).last
+            @user.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/users_controller.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for @user)"
       end
-    end
-    EOF
-    runner.review('app/controllers/users_controller.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for @user)"
-  end
-
-  it "should add model virtual attribute with local assignment" do
-    content = <<-EOF
-    class UsersController < ApplicationController
 
-      def create
-        user = User.new(params[:user])
-        user.first_name = params[:full_name].split(' ', 2).first
-        user.last_name = params[:full_name].split(' ', 2).last
-        user.save
+      it "should add model virtual attribute with local assignment" do
+        content = <<-EOF
+        class UsersController < ApplicationController
+          def create
+            user = User.new(params[:user])
+            user.first_name = params[:full_name].split(' ', 2).first
+            user.last_name = params[:full_name].split(' ', 2).last
+            user.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/users_controller.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for user)"
       end
-    end
-    EOF
-    runner.review('app/controllers/users_controller.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for user)"
-  end
-
-  it "should not add model virtual attribute with differen param" do
-    content = <<-EOF
-    class UsersController < ApplicationController
 
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:first_name]
-        @user.last_name = params[:last_name]
-        @user.save
+      it "should not add model virtual attribute with differen param" do
+        content = <<-EOF
+        class UsersController < ApplicationController
+          def create
+            @user = User.new(params[:user])
+            @user.first_name = params[:first_name]
+            @user.last_name = params[:last_name]
+            @user.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/users_controller.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('app/controllers/users_controller.rb', content)
-    runner.should have(0).errors
-  end
-
-  it "should not add model virtual attribute with read" do
-    content = <<-EOF
-    class UsersController < ApplicationController
 
-      def show
-        if params[:id]
-          @user = User.find(params[:id])
-        else
-          @user = current_user
+      it "should not add model virtual attribute with read" do
+        content = <<-EOF
+        class UsersController < ApplicationController
+          def show
+            if params[:id]
+              @user = User.find(params[:id])
+            else
+              @user = current_user
+            end
+          end
         end
+        EOF
+        runner.review('app/controllers/users_controller.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('app/controllers/users_controller.rb', content)
-    runner.should have(0).errors
-  end
-
-  it "should add model virtual attribute with two dimension params" do
-    content = <<-EOF
-    class UsersController < ApplicationController
 
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:user][:full_name].split(' ', 2).first
-        @user.last_name = params[:user][:full_name].split(' ', 2).last
-        @user.save
+      it "should add model virtual attribute with two dimension params" do
+        content = <<-EOF
+        class UsersController < ApplicationController
+          def create
+            @user = User.new(params[:user])
+            @user.first_name = params[:user][:full_name].split(' ', 2).first
+            @user.last_name = params[:user][:full_name].split(' ', 2).last
+            @user.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/users_controller.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for @user)"
       end
-    end
-    EOF
-    runner.review('app/controllers/users_controller.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/users_controller.rb:3 - add model virtual attribute (for @user)"
-  end
 
-  it "should no add model virtual attribute with two dimension params" do
-    content = <<-EOF
-    class UsersController < ApplicationController
-
-      def create
-        @user = User.new(params[:user])
-        @user.first_name = params[:user][:first_name]
-        @user.last_name = params[:user][:last_name]
-        @user.save
+      it "should no add model virtual attribute with two dimension params" do
+        content = <<-EOF
+        class UsersController < ApplicationController
+          def create
+            @user = User.new(params[:user])
+            @user.first_name = params[:user][:first_name]
+            @user.last_name = params[:user][:last_name]
+            @user.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/users_controller.rb', content)
+        runner.should have(0).errors
       end
     end
-    EOF
-    runner.review('app/controllers/users_controller.rb', content)
-    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb

@@ -1,260 +1,262 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(
-    :reviews => RailsBestPractices::Reviews::AlwaysAddDbIndexReview.new
-  ) }
+module RailsBestPractices
+  module Reviews
+    describe AlwaysAddDbIndexReview do
+      let(:runner) { Core::Runner.new(:reviews => AlwaysAddDbIndexReview.new) }
 
-  it "should always add db index" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.string "content"
-        t.integer "post_id"
-        t.integer "user_id"
+      it "should always add db index" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "comments", :force => true do |t|
+            t.string "content"
+            t.integer "post_id"
+            t.integer "user_id"
+          end
+          create_table "posts", :force => true do |t|
+          end
+          create_table "users", :force => true do |t|
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(2).errors
+        runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (comments => [post_id])"
+        runner.errors[1].to_s.should == "db/schema.rb:2 - always add db index (comments => [user_id])"
       end
-      create_table "posts", :force => true do |t|
-      end
-      create_table "users", :force => true do |t|
-      end
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(2).errors
-    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (comments => [post_id])"
-    runner.errors[1].to_s.should == "db/schema.rb:2 - always add db index (comments => [user_id])"
-  end
 
-  it "should always add db index with polymorphic foreign key" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "versions", :force => true do |t|
-        t.integer  "versioned_id"
-        t.string   "versioned_type"
-        t.string   "tag"
+      it "should always add db index with polymorphic foreign key" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "versions", :force => true do |t|
+            t.integer  "versioned_id"
+            t.string   "versioned_type"
+            t.string   "tag"
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
       end
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
-  end
 
-  it "should always add db index with polymorphic foreign key and _type is defined before _id" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "versions", :force => true do |t|
-        t.string   "versioned_type"
-        t.integer  "versioned_id"
-        t.string   "tag"
+      it "should always add db index with polymorphic foreign key and _type is defined before _id" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "versions", :force => true do |t|
+            t.string   "versioned_type"
+            t.integer  "versioned_id"
+            t.string   "tag"
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
       end
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
-  end
 
-  it "should always add db index with single index, but without polymorphic foreign key" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "taggings", :force => true do |t|
-        t.integer  "tag_id"
-        t.integer  "taggable_id"
-        t.string   "taggable_type"
-      end
-      create_table "tags", :force => true do |t|
-      end
+      it "should always add db index with single index, but without polymorphic foreign key" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "taggings", :force => true do |t|
+            t.integer  "tag_id"
+            t.integer  "taggable_id"
+            t.string   "taggable_type"
+          end
+          create_table "tags", :force => true do |t|
+          end
 
-      add_index "taggings", ["tag_id"], :name => "index_taggings_on_tag_id"
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [taggable_id, taggable_type])"
-  end
-
-  it "should always add db index with polymorphic foreign key, but without single index" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "taggings", :force => true do |t|
-        t.integer  "tag_id"
-        t.integer  "taggable_id"
-        t.string   "taggable_type"
-      end
-      create_table "tags", :force => true do |t|
+          add_index "taggings", ["tag_id"], :name => "index_taggings_on_tag_id"
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [taggable_id, taggable_type])"
       end
 
-      add_index "taggings", ["taggable_id", "taggable_type"], :name => "index_taggings_on_taggable_id_and_taggable_type"
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [tag_id])"
-  end
+      it "should always add db index with polymorphic foreign key, but without single index" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "taggings", :force => true do |t|
+            t.integer  "tag_id"
+            t.integer  "taggable_id"
+            t.string   "taggable_type"
+          end
+          create_table "tags", :force => true do |t|
+          end
 
-  it "should always add db index only _id without non related _type column" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "websites", :force => true do |t|
-        t.integer  "user_id"
-        t.string   "icon_file_name"
-        t.integer  "icon_file_size"
-        t.string   "icon_content_type"
-      end
-      create_table "users", :force => true do |t|
+          add_index "taggings", ["taggable_id", "taggable_type"], :name => "index_taggings_on_taggable_id_and_taggable_type"
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [tag_id])"
       end
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (websites => [user_id])"
-  end
 
-  it "should not always add db index with column has no id" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.string "content"
-        t.integer "position"
+      it "should always add db index only _id without non related _type column" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "websites", :force => true do |t|
+            t.integer  "user_id"
+            t.string   "icon_file_name"
+            t.integer  "icon_file_size"
+            t.string   "icon_content_type"
+          end
+          create_table "users", :force => true do |t|
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (websites => [user_id])"
       end
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(0).errors
-  end
 
-  it "should not always add db index with add_index" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.string "content"
-        t.integer "post_id"
-        t.integer "user_id"
-      end
-      create_table "posts", :force => true do |t|
-      end
-      create_table "users", :force => true do |t|
+      it "should not always add db index with column has no id" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "comments", :force => true do |t|
+            t.string "content"
+            t.integer "position"
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(0).errors
       end
 
-      add_index "comments", ["post_id"], :name => "index_comments_on_post_id"
-      add_index "comments", ["user_id"], :name => "index_comments_on_user_id"
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(0).errors
-  end
+      it "should not always add db index with add_index" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "comments", :force => true do |t|
+            t.string "content"
+            t.integer "post_id"
+            t.integer "user_id"
+          end
+          create_table "posts", :force => true do |t|
+          end
+          create_table "users", :force => true do |t|
+          end
 
-  it "should not always add db index with only _type column" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "versions", :force => true do |t|
-        t.string   "versioned_type"
+          add_index "comments", ["post_id"], :name => "index_comments_on_post_id"
+          add_index "comments", ["user_id"], :name => "index_comments_on_user_id"
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(0).errors
-  end
 
-  it "should not always add db index with multi-column index" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "versions", :force => true do |t|
-        t.integer  "versioned_id"
-        t.string   "versioned_type"
-        t.string   "tag"
+      it "should not always add db index with only _type column" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "versions", :force => true do |t|
+            t.string   "versioned_type"
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(0).errors
       end
 
-      add_index "versions", ["versioned_id", "versioned_type"], :name => "index_versions_on_versioned_id_and_versioned_type"
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(0).errors
-  end
+      it "should not always add db index with multi-column index" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "versions", :force => true do |t|
+            t.integer  "versioned_id"
+            t.string   "versioned_type"
+            t.string   "tag"
+          end
 
-  it "should not always add db index if there is an index contains more columns" do
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "taggings", :force => true do |t|
-        t.integer  "taggable_id"
-        t.string   "taggable_type"
-        t.string   "context"
+          add_index "versions", ["versioned_id", "versioned_type"], :name => "index_versions_on_versioned_id_and_versioned_type"
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(0).errors
       end
 
-      add_index "taggings", ["taggable_id", "taggable_type", "context"], :name => "index_taggings_on_taggable_id_and_taggable_type_and_context"
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(0).errors
-  end
+      it "should not always add db index if there is an index contains more columns" do
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "taggings", :force => true do |t|
+            t.integer  "taggable_id"
+            t.string   "taggable_type"
+            t.string   "context"
+          end
 
-  it "should not always add db index if two indexes for polymorphic association" do
-    content =<<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "taggings", :force => true do |t|
-        t.integer "tagger_id"
-        t.string "tagger_type"
-        t.datetime "created_at"
+          add_index "taggings", ["taggable_id", "taggable_type", "context"], :name => "index_taggings_on_taggable_id_and_taggable_type_and_context"
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(0).errors
       end
 
-      add_index "taggings", ["tagger_id"], :name => "index_taggings_on_tagger_id"
-      add_index "taggings", ["tagger_type"], :name => "index_taggings_on_tagger_type"
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(0).errors
-  end
+      it "should not always add db index if two indexes for polymorphic association" do
+        content =<<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "taggings", :force => true do |t|
+            t.integer "tagger_id"
+            t.string "tagger_type"
+            t.datetime "created_at"
+          end
 
-  it "should not always add db index if table does not exist" do
-    content =<<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.integer "post_id"
+          add_index "taggings", ["tagger_id"], :name => "index_taggings_on_tagger_id"
+          add_index "taggings", ["tagger_type"], :name => "index_taggings_on_tagger_type"
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(0).errors
-  end
 
-  it "should always add db index if association_name is different to foreign_key" do
-    content =<<-EOF
-    class Comment < ActiveRecord::Base
-      belongs_to :commentor, :class_name => "User"
-    end
-    EOF
-    runner.prepare('app/models/comment.rb', content)
-    content =<<-EOF
-    class User < ActiveRecord::Base
-    end
-    EOF
-    runner.prepare('app/models/user.rb', content)
-    content =<<-EOF
-    ActiveRecord::Schema.define(:version => 20100603080629) do
-      create_table "comments", :force => true do |t|
-        t.integer "commentor_id"
+      it "should not always add db index if table does not exist" do
+        content =<<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "comments", :force => true do |t|
+            t.integer "post_id"
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(0).errors
       end
-      create_table "users", :force => true do |t|
+
+      it "should always add db index if association_name is different to foreign_key" do
+        content =<<-EOF
+        class Comment < ActiveRecord::Base
+          belongs_to :commentor, :class_name => "User"
+        end
+        EOF
+        runner.prepare('app/models/comment.rb', content)
+        content =<<-EOF
+        class User < ActiveRecord::Base
+        end
+        EOF
+        runner.prepare('app/models/user.rb', content)
+        content =<<-EOF
+        ActiveRecord::Schema.define(:version => 20100603080629) do
+          create_table "comments", :force => true do |t|
+            t.integer "commentor_id"
+          end
+          create_table "users", :force => true do |t|
+          end
+        end
+        EOF
+        runner.review('db/schema.rb', content)
+        runner.after_review
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (comments => [commentor_id])"
       end
     end
-    EOF
-    runner.review('db/schema.rb', content)
-    runner.after_review
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (comments => [commentor_id])"
   end
 end