rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/reviews/use_observer_review_spec.rb

@@ -1,154 +1,147 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::UseObserverReview do
-  let(:runner) {
-    RailsBestPractices::Core::Runner.new(
-      :prepares => RailsBestPractices::Prepares::MailerPrepare.new,
-      :reviews => RailsBestPractices::Reviews::UseObserverReview.new
-    )
-  }
-
-  before :each do
-    content =<<-EOF
-    class ProjectMailer < ActionMailer::Base
-    end
-    EOF
-    runner.prepare('app/models/project_mailer.rb', content)
-  end
-
-  describe "rails2" do
-    it "should use observer" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        after_create :send_create_notification
-
-        private
-
-        def send_create_notification
-          self.members.each do |member|
-            ProjectMailer.deliver_notification(self, member)
-          end
+module RailsBestPractices
+  module Reviews
+    describe UseObserverReview do
+      let(:runner) { Core::Runner.new(:prepares => Prepares::MailerPrepare.new, :reviews => UseObserverReview.new) }
+
+      before :each do
+        content =<<-EOF
+        class ProjectMailer < ActionMailer::Base
         end
+        EOF
+        runner.prepare('app/models/project_mailer.rb', content)
       end
-      EOF
-      runner.review('app/models/project.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
-    end
 
-    it "should not use observer without callback" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        private
+      describe "rails2" do
+        it "should use observer" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            after_create :send_create_notification
+
+            private
+            def send_create_notification
+              self.members.each do |member|
+                ProjectMailer.deliver_notification(self, member)
+              end
+            end
+          end
+          EOF
+          runner.review('app/models/project.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
+        end
 
-        def send_create_notification
-          self.members.each do |member|
-            ProjectMailer.deliver_notification(self, member)
+        it "should not use observer without callback" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            private
+            def send_create_notification
+              self.members.each do |member|
+                ProjectMailer.deliver_notification(self, member)
+              end
+            end
           end
+          EOF
+          runner.review('app/models/project.rb', content)
+          runner.should have(0).errors
         end
-      end
-      EOF
-      runner.review('app/models/project.rb', content)
-      runner.should have(0).errors
-    end
 
-    it "should use observer with two after_create" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        after_create :send_create_notification, :update_author
+        it "should use observer with two after_create" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            after_create :send_create_notification, :update_author
 
-        private
+            private
+            def send_create_notification
+              self.members.each do |member|
+                ProjectMailer.deliver_notification(self, member)
+              end
+            end
 
-        def send_create_notification
-          self.members.each do |member|
-            ProjectMailer.deliver_notification(self, member)
+            def update_author
+            end
           end
+          EOF
+          runner.review('app/models/project.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
         end
 
-        def update_author
+        it "should not raise when initiate an object in callback" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            after_create ProjectMailer.new
+          end
+          EOF
+          lambda { runner.review('app/models/project.rb', content) }.should_not raise_error
         end
       end
-      EOF
-      runner.review('app/models/project.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
-    end
-
-    it "should not raise when initiate an object in callback" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        after_create ProjectMailer.new
-      end
-      EOF
-      lambda { runner.review('app/models/project.rb', content) }.should_not raise_error
-    end
-  end
-
-  describe "rails3" do
-    it "should use observer" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        after_create :send_create_notification
 
-        private
-
-        def send_create_notification
-          self.members.each do |member|
-            ProjectMailer.notification(self, member).deliver
+      describe "rails3" do
+        it "should use observer" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            after_create :send_create_notification
+
+            private
+            def send_create_notification
+              self.members.each do |member|
+                ProjectMailer.notification(self, member).deliver
+              end
+            end
           end
+          EOF
+          runner.review('app/models/project.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
         end
-      end
-      EOF
-      runner.review('app/models/project.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
-    end
 
-    it "should not use observer without callback" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        private
-
-        def send_create_notification
-          self.members.each do |member|
-            ProjectMailer.notification(self, member).deliver
+        it "should not use observer without callback" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            private
+            def send_create_notification
+              self.members.each do |member|
+                ProjectMailer.notification(self, member).deliver
+              end
+            end
           end
+          EOF
+          runner.review('app/models/project.rb', content)
+          runner.should have(0).errors
         end
-      end
-      EOF
-      runner.review('app/models/project.rb', content)
-      runner.should have(0).errors
-    end
 
-    it "should use observer with two after_create" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        after_create :send_create_notification, :update_author
+        it "should use observer with two after_create" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            after_create :send_create_notification, :update_author
 
-        private
+            private
+            def send_create_notification
+              self.members.each do |member|
+                ProjectMailer.notification(self, member).deliver
+              end
+            end
 
-        def send_create_notification
-          self.members.each do |member|
-            ProjectMailer.notification(self, member).deliver
+            def update_author
+            end
           end
+          EOF
+          runner.review('app/models/project.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
         end
 
-        def update_author
+        it "should not raise when initiate an object in callback" do
+          content =<<-EOF
+          class Project < ActiveRecord::Base
+            after_create ProjectMailer.new
+          end
+          EOF
+          lambda { runner.review('app/models/project.rb', content) }.should_not raise_error
         end
       end
-      EOF
-      runner.review('app/models/project.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/models/project.rb:6 - use observer"
-    end
-
-    it "should not raise when initiate an object in callback" do
-      content =<<-EOF
-      class Project < ActiveRecord::Base
-        after_create ProjectMailer.new
-      end
-      EOF
-      lambda { runner.review('app/models/project.rb', content) }.should_not raise_error
     end
   end
 end

data/spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb

@@ -1,210 +1,209 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::UseQueryAttributeReview do
-  let(:runner) {
-    RailsBestPractices::Core::Runner.new(
-      :prepares => [RailsBestPractices::Prepares::ModelPrepare.new, RailsBestPractices::Prepares::SchemaPrepare.new],
-      :reviews => RailsBestPractices::Reviews::UseQueryAttributeReview.new
-    )
-  }
-
-  before :each do
-    content = <<-EOF
-    class User < ActiveRecord::Base
-      has_many :projects
-      belongs_to :location
-      has_one :phone
-
-      belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
-    end
-    EOF
-    runner.prepare('app/models/user.rb', content)
-
-    content = <<-EOF
-    ActiveRecord::Schema.define(:version => 20110216150853) do
-      create_table "users", force => true do |t|
-        t.string :login
-        t.integer :age
+module RailsBestPractices
+  module Reviews
+    describe UseQueryAttributeReview do
+      let(:runner) { Core::Runner.new(:prepares => [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], :reviews => UseQueryAttributeReview.new) }
+
+      before :each do
+        content = <<-EOF
+        class User < ActiveRecord::Base
+          has_many :projects
+          belongs_to :location
+          has_one :phone
+
+          belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
+        end
+        EOF
+        runner.prepare('app/models/user.rb', content)
+
+        content = <<-EOF
+        ActiveRecord::Schema.define(:version => 20110216150853) do
+          create_table "users", force => true do |t|
+            t.string :login
+            t.integer :age
+          end
+        end
+        EOF
+        runner.prepare('db/schema.rb', content)
       end
-    end
-    EOF
-    runner.prepare('db/schema.rb', content)
-  end
-
-  it "should use query attribute by blank call" do
-    content = <<-EOF
-    <% if @user.login.blank? %>
-      <%= link_to 'login', new_session_path %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
-  end
 
-  it "should use query attribute by comparing empty string" do
-    content = <<-EOF
-    <% if @user.login == "" %>
-      <%= link_to 'login', new_session_path %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
-  end
-
-  it "should use query attribute by nil call" do
-    content = <<-EOF
-    <% if @user.login.nil? %>
-      <%= link_to 'login', new_session_path %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
-  end
-
-  it "should use query attribute by present call" do
-    content = <<-EOF
-    <% if @user.login.present? %>
-      <%= @user.login %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
-  end
+      it "should use query attribute by blank call" do
+        content = <<-EOF
+        <% if @user.login.blank? %>
+          <%= link_to 'login', new_session_path %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+      end
 
-  it "should use query attribute within and conditions" do
-    content = <<-EOF
-    <% if @user.active? && @user.login.present? %>
-      <%= @user.login %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
-  end
+      it "should use query attribute by comparing empty string" do
+        content = <<-EOF
+        <% if @user.login == "" %>
+          <%= link_to 'login', new_session_path %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+      end
 
-  it "should use query attribute within or conditions" do
-    content = <<-EOF
-    <% if @user.active? or @user.login != "" %>
-      <%= @user.login %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
-  end
+      it "should use query attribute by nil call" do
+        content = <<-EOF
+        <% if @user.login.nil? %>
+          <%= link_to 'login', new_session_path %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+      end
 
-  it "should not use query attribute" do
-    content = <<-EOF
-    <% if @user.login? %>
-      <%= @user.login %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should use query attribute by present call" do
+        content = <<-EOF
+        <% if @user.login.present? %>
+          <%= @user.login %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+      end
 
-  it "should not use query attribute for number" do
-    content =<<-EOF
-    <% unless @user.age.blank? %>
-      <%= @user.age %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should use query attribute within and conditions" do
+        content = <<-EOF
+        <% if @user.active? && @user.login.present? %>
+          <%= @user.login %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+      end
 
-  it "should not review for pluralize attribute" do
-    content = <<-EOF
-    <% if @user.roles.blank? %>
-      <%= @user.login %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should use query attribute within or conditions" do
+        content = <<-EOF
+        <% if @user.active? or @user.login != "" %>
+          <%= @user.login %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+      end
 
-  it "should not review non model class" do
-    content = <<-EOF
-    <% if @person.login.present? %>
-      <%= @person.login %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should not use query attribute" do
+        content = <<-EOF
+        <% if @user.login? %>
+          <%= @user.login %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(0).errors
+      end
 
-  context "association" do
-    it "should not review belongs_to association" do
-      content = <<-EOF
-      <% if @user.location.present? %>
-        <%= @user.location.name %>
-      <% end %>
-      EOF
-      runner.review('app/views/users/show.html.erb', content)
-      runner.should have(0).errors
-    end
+      it "should not use query attribute for number" do
+        content =<<-EOF
+        <% unless @user.age.blank? %>
+          <%= @user.age %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(0).errors
+      end
 
-    it "should not review belongs_to category" do
-      content = <<-EOF
-      <% if @user.category.present? %>
-        <%= @user.category.name %>
-      <% end %>
-      EOF
-      runner.review('app/views/users/show.html.erb', content)
-      runner.should have(0).errors
-    end
+      it "should not review for pluralize attribute" do
+        content = <<-EOF
+        <% if @user.roles.blank? %>
+          <%= @user.login %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(0).errors
+      end
 
-    it "should not review has_one association" do
-      content = <<-EOF
-      <% if @user.phone.present? %>
-        <%= @user.phone.number %>
-      <% end %>
-      EOF
-      runner.review('app/views/users/show.html.erb', content)
-      runner.should have(0).errors
-    end
+      it "should not review non model class" do
+        content = <<-EOF
+        <% if @person.login.present? %>
+          <%= @person.login %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(0).errors
+      end
 
-    it "should not review has_many association" do
-      content = <<-EOF
-      <% if @user.projects.present? %>
-        <%= @user.projects.first.name %>
-      <% end %>
-      EOF
-      runner.review('app/views/users/show.html.erb', content)
-      runner.should have(0).errors
-    end
-  end
+      context "association" do
+        it "should not review belongs_to association" do
+          content = <<-EOF
+          <% if @user.location.present? %>
+            <%= @user.location.name %>
+          <% end %>
+          EOF
+          runner.review('app/views/users/show.html.erb', content)
+          runner.should have(0).errors
+        end
+
+        it "should not review belongs_to category" do
+          content = <<-EOF
+          <% if @user.category.present? %>
+            <%= @user.category.name %>
+          <% end %>
+          EOF
+          runner.review('app/views/users/show.html.erb', content)
+          runner.should have(0).errors
+        end
+
+        it "should not review has_one association" do
+          content = <<-EOF
+          <% if @user.phone.present? %>
+            <%= @user.phone.number %>
+          <% end %>
+          EOF
+          runner.review('app/views/users/show.html.erb', content)
+          runner.should have(0).errors
+        end
+
+        it "should not review has_many association" do
+          content = <<-EOF
+          <% if @user.projects.present? %>
+            <%= @user.projects.first.name %>
+          <% end %>
+          EOF
+          runner.review('app/views/users/show.html.erb', content)
+          runner.should have(0).errors
+        end
+      end
 
-  it "should not review for class method" do
-    content = <<-EOF
-    <% if User.name.present? %>
-      <%= User.name %>
-    <% end %>
-    EOF
-    runner.review('app/views/users/show.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should not review for class method" do
+        content = <<-EOF
+        <% if User.name.present? %>
+          <%= User.name %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not review for non attribute call" do
-    content = <<-EOF
-    if @user.login(false).nil?
-      puts @user.login(false)
-    end
-    EOF
-    runner.review('app/models/users_controller.rb', content)
-    runner.should have(0).errors
-  end
+      it "should not review for non attribute call" do
+        content = <<-EOF
+        if @user.login(false).nil?
+          puts @user.login(false)
+        end
+        EOF
+        runner.review('app/models/users_controller.rb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not raise error for common conditional statement" do
-    content = <<-EOF
-    if voteable.is_a? Answer
-      puts voteable.title
+      it "should not raise error for common conditional statement" do
+        content = <<-EOF
+        if voteable.is_a? Answer
+          puts voteable.title
+        end
+        EOF
+        lambda { runner.review('app/models/users_controller.rb', content) }.should_not raise_error
+      end
     end
-    EOF
-    lambda { runner.review('app/models/users_controller.rb', content) }.should_not raise_error
   end
 end