rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb

@@ -1,118 +1,122 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::UseSayWithTimeInMigrationsReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe UseSayWithTimeInMigrationsReview do
+      let(:runner) { Core::Runner.new(:reviews => UseSayWithTimeInMigrationsReview.new) }
 
-  it "should use say with time in migrations" do
-    content =<<-EOF
-    def self.up
-      User.find_each do |user|
-        user.first_name, user.last_name = user.full_name.split(' ')
-        user.save
+      it "should use say with time in migrations" do
+        content =<<-EOF
+        def self.up
+          User.find_each do |user|
+            user.first_name, user.last_name = user.full_name.split(' ')
+            user.save
+          end
+        end
+        EOF
+        runner.review('db/migrate/20101010080658_update_users.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations"
       end
-    end
-    EOF
-    runner.review('db/migrate/20101010080658_update_users.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations"
-  end
 
-  it "should use say with time in migrations with create_table" do
-    content =<<-EOF
-    def self.up
-      create_table :users do |t|
-        t.string :login
-        t.timestamps
-      end
+      it "should use say with time in migrations with create_table" do
+        content =<<-EOF
+        def self.up
+          create_table :users do |t|
+            t.string :login
+            t.timestamps
+          end
 
-      User.find_each do |user|
-        user.first_name, user.last_name = user.full_name.split(' ')
-        user.save
+          User.find_each do |user|
+            user.first_name, user.last_name = user.full_name.split(' ')
+            user.save
+          end
+        end
+        EOF
+        runner.review('db/migrate/20101010080658_update_users.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations"
       end
-    end
-    EOF
-    runner.review('db/migrate/20101010080658_update_users.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations"
-  end
 
-  it "should not use say with time in migrations" do
-    content =<<-EOF
-    def self.up
-      say_with_time("Initialize first_name and last_name for users") do
-        User.find_each do |user|
-          user.first_name, user.last_name = user.full_name.split(' ')
-          user.save
-          say(user.id + " was updated.")
+      it "should not use say with time in migrations" do
+        content =<<-EOF
+        def self.up
+          say_with_time("Initialize first_name and last_name for users") do
+            User.find_each do |user|
+              user.first_name, user.last_name = user.full_name.split(' ')
+              user.save
+              say(user.id + " was updated.")
+            end
+          end
         end
+        EOF
+        runner.review('db/migrate/20101010080658_update_users.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('db/migrate/20101010080658_update_users.rb', content)
-    runner.should have(0).errors
-  end
 
-  it "should not use say with time in migrations when not first code line" do
-    content =<<-EOF
-    def self.up
-      User.find_each do |user|
-        say_with_time 'Updating user with latest data' do
-          user.do_time_consuming_stuff
+      it "should not use say with time in migrations when not first code line" do
+        content =<<-EOF
+        def self.up
+          User.find_each do |user|
+            say_with_time 'Updating user with latest data' do
+              user.do_time_consuming_stuff
+            end
+          end
         end
+        EOF
+        runner.review('db/migrate/20101010080658_update_users.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('db/migrate/20101010080658_update_users.rb', content)
-    runner.should have(0).errors
-  end
 
-  it "should not use say with time when default migration message" do
-    content =<<-EOF
-    def self.up
-      create_table :users do |t|
-        t.string :login
-        t.string :email
-        t.timestamps
+      it "should not use say with time when default migration message" do
+        content =<<-EOF
+        def self.up
+          create_table :users do |t|
+            t.string :login
+            t.string :email
+            t.timestamps
+          end
+        end
+        EOF
+        runner.review('db/migrate/20101010080658_create_users.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('db/migrate/20101010080658_create_users.rb', content)
-    runner.should have(0).errors
-  end
 
-  it "should not raise an error" do
-    content =<<-EOF
-    class AddAdmin < ActiveRecord::Migration
+      it "should not raise an error" do
+        content =<<-EOF
+        class AddAdmin < ActiveRecord::Migration
 
-      class Person < ActiveRecord::Base
-      end
+          class Person < ActiveRecord::Base
+          end
 
-      class Blog < ActiveRecord::Base
-      end
+          class Blog < ActiveRecord::Base
+          end
 
-      def self.up
-        add_column :people, :admin, :boolean, :default => false, :null => false
-        add_column :people, :deactivated, :boolean,
-                            :default => false, :null => false
+          def self.up
+            add_column :people, :admin, :boolean, :default => false, :null => false
+            add_column :people, :deactivated, :boolean,
+                                :default => false, :null => false
 
-        key = Crypto::Key.from_file("\#{RAILS_ROOT}/rsa_key.pub")
-        person = Person.new(:email => "admin@example.com",
-                            :name => "admin",
-                            :crypted_password => key.encrypt("admin"),
-                            :description => "")
-        person.admin = true
-        person.save!
-        Blog.create(:person_id => person.id)
-      end
+            key = Crypto::Key.from_file("\#{RAILS_ROOT}/rsa_key.pub")
+            person = Person.new(:email => "admin@example.com",
+                                :name => "admin",
+                                :crypted_password => key.encrypt("admin"),
+                                :description => "")
+            person.admin = true
+            person.save!
+            Blog.create(:person_id => person.id)
+          end
 
-      def self.down
-        remove_column :people, :deactivated
-        Person.delete(Person.find_by_name("admin"))
-        remove_column :people, :admin
+          def self.down
+            remove_column :people, :deactivated
+            Person.delete(Person.find_by_name("admin"))
+            remove_column :people, :admin
+          end
+        end
+        EOF
+        runner.review('db/migrate/20101010080658_create_users.rb', content)
+        runner.should have(3).errors
       end
     end
-    EOF
-    runner.review('db/migrate/20101010080658_create_users.rb', content)
-    runner.should have(3).errors
   end
 end

data/spec/rails_best_practices/reviews/use_scope_access_review_spec.rb

@@ -1,184 +1,179 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::UseScopeAccessReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::UseScopeAccessReview.new) }
-
-  context "if" do
-    it "shoud use scope access" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          if @post.user != current_user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+module RailsBestPractices
+  module Reviews
+    describe UseScopeAccessReview do
+      let(:runner) { Core::Runner.new(:reviews => UseScopeAccessReview.new) }
+
+      context "if" do
+        it "shoud use scope access" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              if @post.user != current_user
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
-      end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
 
-    it "shoud use scope access by comparing with id" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          if @post.user_id != current_user.id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+        it "shoud use scope access by comparing with id" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              if @post.user_id != current_user.id
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
-      end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
 
-    it "shoud use scope access with current_user ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          if current_user != @post.user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+        it "shoud use scope access with current_user ==" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              if current_user != @post.user
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
-      end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
 
-    it "shoud use scope access by current_user.id ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          if current_user.id != @post.user_id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+        it "shoud use scope access by current_user.id ==" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              if current_user.id != @post.user_id
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
       end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-  end
 
-  context "unless" do
-    it "shoud use scope access" do
-      content = <<-EOF
-      class PostsController < ApplicationController
-
-        def edit
-          @post = Post.find(params[:id])
-
-          unless @post.user == current_user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+      context "unless" do
+        it "shoud use scope access" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              unless @post.user == current_user
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
-      end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-
-    it "shoud use scope access by comparing with id" do
-      content = <<-EOF
-      class PostsController < ApplicationController
 
-        def edit
-          @post = Post.find(params[:id])
-
-          unless @post.user_id == current_user.id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+        it "shoud use scope access by comparing with id" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              unless @post.user_id == current_user.id
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
-      end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-
-    it "shoud use scope access with current_user ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
 
-        def edit
-          @post = Post.find(params[:id])
-
-          unless current_user == @post.user
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+        it "shoud use scope access with current_user ==" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              unless current_user == @post.user
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
-      end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
-
-    it "shoud use scope access by current_user.id ==" do
-      content = <<-EOF
-      class PostsController < ApplicationController
 
-        def edit
-          @post = Post.find(params[:id])
-
-          unless current_user.id == @post.user_id
-            flash[:warning] = 'Access Denied'
-            redirect_to posts_url
+        it "shoud use scope access by current_user.id ==" do
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              unless current_user.id == @post.user_id
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
         end
-      end
-      EOF
-      runner.review('app/controllers/posts_controller.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:6 - use scope access"
-    end
 
-    it "should no error in use_scope_access_review" do
-      content = <<-EOF
-      class CommentsController < ApplicationController
-
-        def add_comment
-          @current_user = User.find_by_id(session[:user_id])
-          @id = params[:post_id]
-          @error = ""
-          if (@text = params[:text]) == ""
-            @error = "Please enter a comment!"
-          else
-            @comment = Comment.create_object(@text,  @id, @current_user.id)
-          end
-          unless @comment
-            @error = "Comment could not be saved."
+        it "should no error in use_scope_access_review" do
+          content = <<-EOF
+          class CommentsController < ApplicationController
+            def add_comment
+              @current_user = User.find_by_id(session[:user_id])
+              @id = params[:post_id]
+              @error = ""
+              if (@text = params[:text]) == ""
+                @error = "Please enter a comment!"
+              else
+                @comment = Comment.create_object(@text,  @id, @current_user.id)
+              end
+              unless @comment
+                @error = "Comment could not be saved."
+              end
+            end
           end
+          EOF
+          runner.review('app/controllers/comments_controller.rb', content)
+          runner.should have(0).errors
         end
       end
-      EOF
-      runner.review('app/controllers/comments_controller.rb', content)
-      runner.should have(0).errors
     end
   end
 end