rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -1,167 +1,171 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::NeedlessDeepNestingReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::NeedlessDeepNestingReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe NeedlessDeepNestingReview do
+      let(:runner) { Core::Runner.new(:reviews => NeedlessDeepNestingReview.new) }
 
-  describe "rails2" do
-    it "should needless deep nesting" do
-      content = <<-EOF
-      map.resources :posts do |post|
-        post.resources :comments do |comment|
-          comment.resources :favorites
+      describe "rails2" do
+        it "should needless deep nesting" do
+          content = <<-EOF
+          map.resources :posts do |post|
+            post.resources :comments do |comment|
+              comment.resources :favorites
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
-    end
 
-    it "should not needless deep nesting for shallow" do
-      content = <<-EOF
-      map.resources :posts, :shallow => true do |post|
-        post.resources :comments do |comment|
-          comment.resources :favorites
+        it "should not needless deep nesting for shallow" do
+          content = <<-EOF
+          map.resources :posts, :shallow => true do |post|
+            post.resources :comments do |comment|
+              comment.resources :favorites
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
 
-    it "should needless deep nesting with resource" do
-      content = <<-EOF
-      map.resources :posts do |post|
-        post.resources :comments do |comment|
-          comment.resource :vote
+        it "should needless deep nesting with resource" do
+          content = <<-EOF
+          map.resources :posts do |post|
+            post.resources :comments do |comment|
+              comment.resource :vote
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
-    end
 
-    it "should needless deep nesting with block node" do
-      content = <<-EOF
-      map.resources :posts do |post|
-        post.resources :comments do |comment|
-          comment.resources :favorites
+        it "should needless deep nesting with block node" do
+          content = <<-EOF
+          map.resources :posts do |post|
+            post.resources :comments do |comment|
+              comment.resources :favorites
+            end
+            post.resources :votes
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
         end
-        post.resources :votes
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
-    end
 
-    it "should no needless deep nesting" do
-      content = <<-EOF
-      map.resources :posts do |post|
-        post.resources :comments
-      end
+        it "should no needless deep nesting" do
+          content = <<-EOF
+          map.resources :posts do |post|
+            post.resources :comments
+          end
 
-      map.resources :comments do |comment|
-        comment.resources :favorites
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
+          map.resources :comments do |comment|
+            comment.resources :favorites
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
 
-    it "should no needless deep nesting with block node" do
-      content = <<-EOF
-      map.resources :comments do |comment|
-        comment.resources :favorites
-        comment.resources :votes
+        it "should no needless deep nesting with block node" do
+          content = <<-EOF
+          map.resources :comments do |comment|
+            comment.resources :favorites
+            comment.resources :votes
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
       end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
-  end
 
-  describe "rails3" do
-    it "should needless deep nesting" do
-      content = <<-EOF
-      resources :posts do
-        resources :comments do
-          resources :favorites
+      describe "rails3" do
+        it "should needless deep nesting" do
+          content = <<-EOF
+          resources :posts do
+            resources :comments do
+              resources :favorites
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
-    end
 
-    it "should not needless deep nesting for shallow" do
-      content = <<-EOF
-      resources :posts, :shallow => true do
-        resources :comments do
-          resources :favorites
+        it "should not needless deep nesting for shallow" do
+          content = <<-EOF
+          resources :posts, :shallow => true do
+            resources :comments do
+              resources :favorites
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
 
-    it "should not needless deep nesting for shallow 4 levels" do
-      content = <<-EOF
-      resources :applications, shallow: true, only: [:index, :show, :create] do
-        resources :events, only: [:index, :show, :create, :subscribe, :push] do
-          resources :executions, only: [:index, :show] do
-            resources :execution_statuses, only: :index
+        it "should not needless deep nesting for shallow 4 levels" do
+          content = <<-EOF
+          resources :applications, shallow: true, only: [:index, :show, :create] do
+            resources :events, only: [:index, :show, :create, :subscribe, :push] do
+              resources :executions, only: [:index, :show] do
+                resources :execution_statuses, only: :index
+              end
+            end
           end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
 
-    it "should needless deep nesting with resource" do
-      content = <<-EOF
-      resources :posts do
-        resources :comments do
-          resource :vote
+        it "should needless deep nesting with resource" do
+          content = <<-EOF
+          resources :posts do
+            resources :comments do
+              resource :vote
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
-    end
 
-    it "should needless deep nesting with block node" do
-      content = <<-EOF
-      resources :posts do
-        resources :comments do
-          resources :favorites
+        it "should needless deep nesting with block node" do
+          content = <<-EOF
+          resources :posts do
+            resources :comments do
+              resources :favorites
+            end
+            resources :votes
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
         end
-        resources :votes
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
-    end
 
-    it "should no needless deep nesting" do
-      content = <<-EOF
-      resources :posts do
-        resources :comments
-        resources :votes
-      end
+        it "should no needless deep nesting" do
+          content = <<-EOF
+          resources :posts do
+            resources :comments
+            resources :votes
+          end
 
-      resources :comments do
-        resources :favorites
+          resources :comments do
+            resources :favorites
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
       end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
     end
   end
 end

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -1,57 +1,61 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::NotUseDefaultRouteReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::NotUseDefaultRouteReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe NotUseDefaultRouteReview do
+      let(:runner) { Core::Runner.new(:reviews => NotUseDefaultRouteReview.new) }
 
-  describe "rails2" do
-    it "should not use default route" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :push => :post }
+      describe "rails2" do
+        it "should not use default route" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts, :member => { :push => :post }
 
-        map.connect ':controller/:action/:id'
-        map.connect ':controller/:action/:id.:format'
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(2).errors
-      runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
-      runner.errors[1].to_s.should == "config/routes.rb:5 - not use default route"
-    end
+            map.connect ':controller/:action/:id'
+            map.connect ':controller/:action/:id.:format'
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(2).errors
+          runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
+          runner.errors[1].to_s.should == "config/routes.rb:5 - not use default route"
+        end
 
-    it "should no not use default route" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :push => :post }
+        it "should no not use default route" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts, :member => { :push => :post }
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
       end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
-  end
 
-  describe "rails3" do
-    it "should not use default route" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts
+      describe "rails3" do
+        it "should not use default route" do
+          content = <<-EOF
+          RailsBestpracticesCom::Application.routes.draw do |map|
+            resources :posts
 
-        match ':controller(/:action(/:id(.:format)))'
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
-    end
+            match ':controller(/:action(/:id(.:format)))'
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
+        end
 
-    it "should no not use default route" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do |map|
-        resources :posts
+        it "should no not use default route" do
+          content = <<-EOF
+          RailsBestpracticesCom::Application.routes.draw do |map|
+            resources :posts
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
       end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
     end
   end
 end

data/spec/rails_best_practices/reviews/not_use_times_ago_in_words_review_spec.rb

@@ -1,49 +1,53 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::NotUseTimeAgoInWordsReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::NotUseTimeAgoInWordsReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe NotUseTimeAgoInWordsReview do
+      let(:runner) { Core::Runner.new(:reviews => NotUseTimeAgoInWordsReview.new) }
 
-  describe "time_ago_in_words" do
-    it "should not use in views" do
-      content =<<-EOF
-      <%= time_ago_in_words(post.created_at) %>
-      EOF
-      runner.review('app/views/posts/show.html.erb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - not use time_ago_in_words"
-    end
+      describe "time_ago_in_words" do
+        it "should not use in views" do
+          content =<<-EOF
+          <%= time_ago_in_words(post.created_at) %>
+          EOF
+          runner.review('app/views/posts/show.html.erb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - not use time_ago_in_words"
+        end
 
-    it "should not use in helpers" do
-      content =<<-EOF
-      def timeago
-        content_tag(:p, time_ago_in_words(post.created_at))
+        it "should not use in helpers" do
+          content =<<-EOF
+          def timeago
+            content_tag(:p, time_ago_in_words(post.created_at))
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:2 - not use time_ago_in_words"
+        end
       end
-      EOF
-      runner.review('app/helpers/posts_helper.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:2 - not use time_ago_in_words"
-    end
-  end
 
-  describe "distance_of_time_in_words_to_now" do
-    it "should not use in views" do
-      content =<<-EOF
-      <%= distance_of_time_in_words_to_now(post.created_at) %>
-      EOF
-      runner.review('app/views/posts/show.html.erb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - not use time_ago_in_words"
-    end
+      describe "distance_of_time_in_words_to_now" do
+        it "should not use in views" do
+          content =<<-EOF
+          <%= distance_of_time_in_words_to_now(post.created_at) %>
+          EOF
+          runner.review('app/views/posts/show.html.erb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - not use time_ago_in_words"
+        end
 
-    it "should not use in helpers" do
-      content =<<-EOF
-      def timeago
-        content_tag(:p, distance_of_time_in_words_to_now(post.created_at))
+        it "should not use in helpers" do
+          content =<<-EOF
+          def timeago
+            content_tag(:p, distance_of_time_in_words_to_now(post.created_at))
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:2 - not use time_ago_in_words"
+        end
       end
-      EOF
-      runner.review('app/helpers/posts_helper.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:2 - not use time_ago_in_words"
     end
   end
 end