rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -1,177 +1,179 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::OveruseRouteCustomizationsReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(
-    :reviews => RailsBestPractices::Reviews::OveruseRouteCustomizationsReview.new
-  ) }
+module RailsBestPractices
+  module Reviews
+    describe OveruseRouteCustomizationsReview do
+      let(:runner) { Core::Runner.new(:reviews => OveruseRouteCustomizationsReview.new) }
 
-  describe "rails2" do
-    it "should overuse route customizations" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :comments => :get,
-                                           :create_comment => :post,
-                                           :update_comment => :update,
-                                           :delete_comment => :delete }
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
+      describe "rails2" do
+        it "should overuse route customizations" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts, :member => { :comments => :get,
+                                               :create_comment => :post,
+                                               :update_comment => :update,
+                                               :delete_comment => :delete }
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+        end
 
-    it "should overuse route customizations with member" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :create_comment => :post,
-                                           :update_comment => :update,
-                                           :delete_comment => :delete,
-                                           :disable_comment => :post }
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
+        it "should overuse route customizations with member" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts, :member => { :create_comment => :post,
+                                               :update_comment => :update,
+                                               :delete_comment => :delete,
+                                               :disable_comment => :post }
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+        end
 
-    it "should overuse route customizations with collection" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :collection => { :list_comments => :get,
-                                               :update_comments => :get,
-                                               :delete_comments => :get,
-                                               :disable_comments  => :get }
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
+        it "should overuse route customizations with collection" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts, :collection => { :list_comments => :get,
+                                                   :update_comments => :get,
+                                                   :delete_comments => :get,
+                                                   :disable_comments  => :get }
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+        end
 
-    it "should overuse route customizations with hash member and collection" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :categories do |category|
-          category.resources :posts, :member => { :create_comment => :post,
-                                                  :update_comment => :update,
-                                                  :delete_comment => :delete },
-                                     :collection => { :comments => :get }
+        it "should overuse route customizations with hash member and collection" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :categories do |category|
+              category.resources :posts, :member => { :create_comment => :post,
+                                                      :update_comment => :update,
+                                                      :delete_comment => :delete },
+                                         :collection => { :comments => :get }
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
-    end
 
-    it "should overuse route customizations with array member and collection" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :categories do |category|
-          category.resources :posts, :member => [:create_comment, :update_comment, :delete_comment],
-                                     :collection => [:comments]
+        it "should overuse route customizations with array member and collection" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :categories do |category|
+              category.resources :posts, :member => [:create_comment, :update_comment, :delete_comment],
+                                         :collection => [:comments]
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:3 - overuse route customizations (customize_count > 3)"
-    end
 
-    it "should not overuse route customizations without customization" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
+        it "should not overuse route customizations without customization" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
 
-    it "should not overuse route customizations when customize route is only one" do
-      content = <<-EOF
-      ActionController::Routing::Routes.draw do |map|
-        map.resources :posts, :member => { :vote => :post }
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
+        it "should not overuse route customizations when customize route is only one" do
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts, :member => { :vote => :post }
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
 
-    it "should not raise error for constants in routes" do
-      content =<<-EOF
-      IP_PATTERN = /(((25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2})\.){3}(25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2}))|[\d]+/.freeze
-      map.resources :vlans do |vlan|
-        vlan.resources :ip_ranges, :member => {:move => [:get, :post]} do |range|
-          range.resources :ips, :requirements => { :id => IP_PATTERN }
+        it "should not raise error for constants in routes" do
+          content =<<-EOF
+          IP_PATTERN = /(((25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2})\.){3}(25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2}))|[\d]+/.freeze
+          map.resources :vlans do |vlan|
+            vlan.resources :ip_ranges, :member => {:move => [:get, :post]} do |range|
+              range.resources :ips, :requirements => { :id => IP_PATTERN }
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
         end
       end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
-  end
 
-  describe "rails3" do
-    it "should overuse route customizations" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do
-        resources :posts do
-          member do
-            post :create_comment
-            update :update_comment
-            delete :delete_comment
-          end
+      describe "rails3" do
+        it "should overuse route customizations" do
+          content = <<-EOF
+          RailsBestpracticesCom::Application.routes.draw do
+            resources :posts do
+              member do
+                post :create_comment
+                update :update_comment
+                delete :delete_comment
+              end
 
-          collection do
-            get :comments
+              collection do
+                get :comments
+              end
+            end
           end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
 
-    it "should overuse route customizations another way" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do
-        resources :posts do
-          post :create_comment, :on => :member
-          update :update_comment, :on => :member
-          delete :delete_comment, :on => :member
-          get :comments, :on => :collection
+        it "should overuse route customizations another way" do
+          content = <<-EOF
+          RailsBestpracticesCom::Application.routes.draw do
+            resources :posts do
+              post :create_comment, :on => :member
+              update :update_comment, :on => :member
+              delete :delete_comment, :on => :member
+              get :comments, :on => :collection
+            end
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(1).errors
+          runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
         end
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(1).errors
-      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
-    end
 
-    it "should not overuse route customizations without customization" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do
-        resources :posts
-      end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
-    end
+        it "should not overuse route customizations without customization" do
+          content = <<-EOF
+          RailsBestpracticesCom::Application.routes.draw do
+            resources :posts
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
+        end
 
-    it "should not overuse route customizations when customize route is only one" do
-      content = <<-EOF
-      RailsBestpracticesCom::Application.routes.draw do
-        resources :posts do
-          member do
-            post :vote
+        it "should not overuse route customizations when customize route is only one" do
+          content = <<-EOF
+          RailsBestpracticesCom::Application.routes.draw do
+            resources :posts do
+              member do
+                post :vote
+              end
+            end
           end
+          EOF
+          runner.review('config/routes.rb', content)
+          runner.should have(0).errors
         end
       end
-      EOF
-      runner.review('config/routes.rb', content)
-      runner.should have(0).errors
     end
   end
 end

data/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb

@@ -1,67 +1,98 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::ProtectMassAssignmentReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::ProtectMassAssignmentReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe ProtectMassAssignmentReview do
+      let(:runner) { Core::Runner.new(:reviews => ProtectMassAssignmentReview.new) }
 
-  it "should protect mass assignment" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-    end
-    EOF
-    runner.review('app/models/user.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/models/user.rb:1 - protect mass assignment"
-  end
+      it "should protect mass assignment" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/models/user.rb:1 - protect mass assignment"
+      end
 
-  it "should not protect mass assignment with attr_accessible" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      attr_accessible :email, :password, :password_confirmation
-    end
-    EOF
-    runner.review('app/models/user.rb', content)
-    runner.should have(0).errors
-  end
+      it "should not protect mass assignment if attr_accessible is used with arguments" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          attr_accessible :email, :password, :password_confirmation
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not protect mass assignment with attr_protected" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      attr_protected :role
-    end
-    EOF
-    runner.review('app/models/user.rb', content)
-    runner.should have(0).errors
-  end
+      it "should not protect mass assignment if attr_accessible is used without arguments" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          attr_accessible
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not protect mass assignment if using devise" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      devise :database_authenticatable, :registerable, :confirmable, :recoverable, :stretches => 20
-    end
-    EOF
-    runner.review('app/models/user.rb', content)
-    runner.should have(0).errors
-  end
+      it "should not protect mass assignment with attr_protected" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          attr_protected :role
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not protect mass assignment if using authlogic with configuration" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      acts_as_authentic do |c|
-        c.my_config_option = my_value
+      it "should not protect mass assignment if using devise" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          devise :database_authenticatable, :registerable, :confirmable, :recoverable, :stretches => 20
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('app/models/user.rb', content)
-    runner.should have(0).errors
-  end
 
-  it "should not protect mass assignment if using authlogic without configuration" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      acts_as_authentic
+      it "should not protect mass assignment if using authlogic with configuration" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          acts_as_authentic do |c|
+            c.my_config_option = my_value
+          end
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
+
+      it "should not protect mass assignment if using authlogic without configuration" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          acts_as_authentic
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
+
+      it "should not protect mass assignment if user set config.active_record.whitelist_attributes" do
+        content =<<-EOF
+        module RailsBestPracticesCom
+          class Application < Rails::Application
+            config.active_record.whitelist_attributes = true
+          end
+        end
+        EOF
+        runner.prepare('config/application.rb', content)
+        content =<<-EOF
+        class User < ActiveRecord::Base
+        end
+        EOF
+        runner.review('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
     end
-    EOF
-    runner.review('app/models/user.rb', content)
-    runner.should have(0).errors
   end
 end