rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb

@@ -1,66 +1,70 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::SimplifyRenderInControllersReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::SimplifyRenderInControllersReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe SimplifyRenderInControllersReview do
+      let(:runner) { Core::Runner.new(:reviews => SimplifyRenderInControllersReview.new) }
 
-  it "should simplify render action view" do
-    content =<<-EOF
-    def edit
-      render :action => :edit
-    end
-    EOF
-    runner.review("app/controllers/posts_controller.rb", content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
-  end
+      it "should simplify render action view" do
+        content =<<-EOF
+        def edit
+          render :action => :edit
+        end
+        EOF
+        runner.review("app/controllers/posts_controller.rb", content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
+      end
 
-  it "should simplify render actions's template" do
-    content =<<-EOF
-    def edit
-      render :template => 'books/edit'
-    end
-    EOF
-    runner.review("app/controllers/posts_controller.rb", content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
-  end
+      it "should simplify render actions's template" do
+        content =<<-EOF
+        def edit
+          render :template => 'books/edit'
+        end
+        EOF
+        runner.review("app/controllers/posts_controller.rb", content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
+      end
 
-  it "should simplify render an arbitrary file" do
-    content =<<-EOF
-    def edit
-      render :file => '/path/to/rails/app/views/books/edit'
-    end
-    EOF
-    runner.review("app/controllers/posts_controller.rb", content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
-  end
+      it "should simplify render an arbitrary file" do
+        content =<<-EOF
+        def edit
+          render :file => '/path/to/rails/app/views/books/edit'
+        end
+        EOF
+        runner.review("app/controllers/posts_controller.rb", content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
+      end
 
-  it "should not simplify render action view" do
-    content =<<-EOF
-    render :edit
-    EOF
-    runner.review("app/controllers/posts_controller", content)
-    runner.should have(0).errors
-  end
+      it "should not simplify render action view" do
+        content =<<-EOF
+        render :edit
+        EOF
+        runner.review("app/controllers/posts_controller", content)
+        runner.should have(0).errors
+      end
 
-  it "should not simplify render actions's template" do
-    content =<<-EOF
-    def edit
-      render 'books/edit'
-    end
-    EOF
-    runner.review("app/controllers/posts_controller.rb", content)
-    runner.should have(0).errors
-  end
+      it "should not simplify render actions's template" do
+        content =<<-EOF
+        def edit
+          render 'books/edit'
+        end
+        EOF
+        runner.review("app/controllers/posts_controller.rb", content)
+        runner.should have(0).errors
+      end
 
-  it "should not simplify render an arbitrary file" do
-    content =<<-EOF
-    def edit
-      render '/path/to/rails/app/views/books/edit'
+      it "should not simplify render an arbitrary file" do
+        content =<<-EOF
+        def edit
+          render '/path/to/rails/app/views/books/edit'
+        end
+        EOF
+        runner.review("app/controllers/posts_controller.rb", content)
+        runner.should have(0).errors
+      end
     end
-    EOF
-    runner.review("app/controllers/posts_controller.rb", content)
-    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/reviews/simplify_render_in_views_review_spec.rb

@@ -1,82 +1,86 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::SimplifyRenderInViewsReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::SimplifyRenderInViewsReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe SimplifyRenderInViewsReview do
+      let(:runner) { Core::Runner.new(:reviews => SimplifyRenderInViewsReview.new) }
 
-  it "should simplify render simple partial" do
-    content =<<-EOF
-    <%= render :partial => 'sidebar' %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
-  end
+      it "should simplify render simple partial" do
+        content =<<-EOF
+        <%= render :partial => 'sidebar' %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+      end
 
-  it "should simplify render partial with object" do
-    content =<<-EOF
-    <%= render :partial => 'post', :object => @post %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
-  end
+      it "should simplify render partial with object" do
+        content =<<-EOF
+        <%= render :partial => 'post', :object => @post %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+      end
 
-  it "should simplify render partial with collection" do
-    content =<<-EOF
-    <%= render :partial => 'posts', :collection => @posts %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
-  end
+      it "should simplify render partial with collection" do
+        content =<<-EOF
+        <%= render :partial => 'posts', :collection => @posts %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+      end
 
-  it "should simplify render partial with local variables" do
-    content =<<-EOF
-    <%= render :partial => 'comment', :locals => { :parent => post } %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
-  end
+      it "should simplify render partial with local variables" do
+        content =<<-EOF
+        <%= render :partial => 'comment', :locals => { :parent => post } %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+      end
 
-  it "should not simplify render simple partial" do
-    content =<<-EOF
-    <%= render 'sidebar' %>
-    <%= render 'shared/sidebar' %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should not simplify render simple partial" do
+        content =<<-EOF
+        <%= render 'sidebar' %>
+        <%= render 'shared/sidebar' %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not simplify render partial with object" do
-    content =<<-EOF
-    <%= render @post %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should not simplify render partial with object" do
+        content =<<-EOF
+        <%= render @post %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not simplify render partial with collection" do
-    content =<<-EOF
-    <%= render @posts %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should not simplify render partial with collection" do
+        content =<<-EOF
+        <%= render @posts %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not simplify render partial with local variables" do
-    content =<<-EOF
-    <%= render 'comment', :parent => post %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(0).errors
-  end
+      it "should not simplify render partial with local variables" do
+        content =<<-EOF
+        <%= render 'comment', :parent => post %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(0).errors
+      end
 
-  it "should not simplify render partial with complex partial" do
-    content =<<-EOF
-    <%= render :partial => 'shared/post', :object => @post %>
-    EOF
-    runner.review('app/views/posts/index.html.erb', content)
-    runner.should have(0).errors
+      it "should not simplify render partial with complex partial" do
+        content =<<-EOF
+        <%= render :partial => 'shared/post', :object => @post %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        runner.should have(0).errors
+      end
+    end
   end
 end

data/spec/rails_best_practices/reviews/use_before_filter_review_spec.rb

@@ -1,116 +1,107 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::UseBeforeFilterReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::UseBeforeFilterReview.new('customize_count' => 2)) }
-
-  it "should use before_filter" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def show
-        @post = current_user.posts.find(params[:id])
-      end
-
-      def edit
-        @post = current_user.posts.find(params[:id])
-      end
-
-      def update
-        @post = current_user.posts.find(params[:id])
-        @post.update_attributes(params[:post])
-      end
-
-      def destroy
-        @post = current_user.posts.find(params[:id])
-        @post.destroy
-      end
-
-    end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3,7,11,16 - use before_filter for show,edit,update,destroy"
-  end
-
-  it "should not use before_filter when equal to customize count" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def show
-        @post = Post.find(params[:id])
-      end
-
-      def edit
-        @post = Post.find(params[:id])
-      end
-    end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(0).errors
-  end
-
-  it "should not use before_filter" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-      before_filter :find_post, :only => [:show, :edit, :update, :destroy]
-
-      def update
-        @post.update_attributes(params[:post])
-      end
-
-      def destroy
-        @post.destroy
+module RailsBestPractices
+  module Reviews
+    describe UseBeforeFilterReview do
+      let(:runner) { Core::Runner.new(:reviews => UseBeforeFilterReview.new('customize_count' => 2)) }
+
+      it "should use before_filter" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def show
+            @post = current_user.posts.find(params[:id])
+          end
+
+          def edit
+            @post = current_user.posts.find(params[:id])
+          end
+
+          def update
+            @post = current_user.posts.find(params[:id])
+            @post.update_attributes(params[:post])
+          end
+
+          def destroy
+            @post = current_user.posts.find(params[:id])
+            @post.destroy
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3,7,11,16 - use before_filter for show,edit,update,destroy"
       end
 
-      protected
+      it "should not use before_filter when equal to customize count" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def show
+            @post = Post.find(params[:id])
+          end
 
-      def find_post
-        @post = current_user.posts.find(params[:id])
+          def edit
+            @post = Post.find(params[:id])
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(0).errors
-  end
-
-  it "should not use before_filter by nil" do
-    content = <<-EOF
-    class PostsController < ApplicationController
 
-      def show
-      end
+      it "should not use before_filter" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          before_filter :find_post, :only => [:show, :edit, :update, :destroy]
 
-      def edit
-      end
+          def update
+            @post.update_attributes(params[:post])
+          end
 
-      def update
-      end
+          def destroy
+            @post.destroy
+          end
 
-      def destroy
+          protected
+          def find_post
+            @post = current_user.posts.find(params[:id])
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(0).errors
       end
 
-    end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(0).errors
-  end
-
-  it "should not use before_filter for protected/private methods" do
-    content =<<-EOF
-    class PostsController < ApplicationController
-      protected
-        def load_comments
-          load_post
-          @comments = @post.comments
+      it "should not use before_filter by nil" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def show; end
+          def edit; end
+          def update; end
+          def destroy; end
         end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(0).errors
+      end
 
-        def load_user
-          load_post
-          @user = @post.user
+      it "should not use before_filter for protected/private methods" do
+        content =<<-EOF
+        class PostsController < ApplicationController
+          protected
+          def load_comments
+            load_post
+            @comments = @post.comments
+          end
+
+          def load_user
+            load_post
+            @user = @post.user
+          end
         end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(0).errors
+      end
     end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(0).errors
   end
 end