rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/core/error_spec.rb

@@ -1,28 +1,34 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Error do
-  it "should return error with filename, line number and message" do
-    RailsBestPractices::Core::Error.new(
-      :filename => "app/models/user.rb",
-      :line_number => "100",
-      :message => "not good",
-      :type => "BogusReview").to_s.should == "app/models/user.rb:100 - not good"
-  end
+module RailsBestPractices::Core
+  describe Error do
+    it "should have highlight with false by default" do
+      Error.new.highlight.should == false
+    end
 
-  it "should return short filename" do
-    RailsBestPractices::Core::Runner.base_path = "../rails-bestpractices.com"
-    RailsBestPractices::Core::Error.new(
-      :filename => "../rails-bestpractices.com/app/models/user.rb",
-      :line_number => "100",
-      :message => "not good",
-      :type => "BogusReview").short_filename.should == "app/models/user.rb"
-  end
+    it "should return error with filename, line number and message" do
+      Error.new(
+        :filename => "app/models/user.rb",
+        :line_number => "100",
+        :message => "not good",
+        :type => "BogusReview").to_s.should == "app/models/user.rb:100 - not good"
+    end
+
+    it "should return short filename" do
+      Runner.base_path = "../rails-bestpractices.com"
+      Error.new(
+        :filename => "../rails-bestpractices.com/app/models/user.rb",
+        :line_number => "100",
+        :message => "not good",
+        :type => "BogusReview").short_filename.should == "app/models/user.rb"
+    end
 
-  it "should return first line number" do
-    RailsBestPractices::Core::Error.new(
-      :filename => "app/models/user.rb",
-      :line_number => "50,70,100",
-      :message => "not good",
-      :type => "BogusReview").first_line_number.should == "50"
+    it "should return first line number" do
+      Error.new(
+        :filename => "app/models/user.rb",
+        :line_number => "50,70,100",
+        :message => "not good",
+        :type => "BogusReview").first_line_number.should == "50"
+    end
   end
 end

data/spec/rails_best_practices/core/helpers_spec.rb

@@ -1,5 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Helpers do
-  it { should be_a_kind_of RailsBestPractices::Core::Modules }
+module RailsBestPractices::Core
+  describe Helpers do
+    it { should be_a_kind_of Modules }
+  end
 end

data/spec/rails_best_practices/core/klasses_spec.rb

@@ -1,12 +1,14 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Klasses do
-  it { should be_a_kind_of Array }
+module RailsBestPractices::Core
+  describe Klasses do
+    it { should be_a_kind_of Array }
 
-  context "Klass" do
-    it "should get to_s" do
-      klass = RailsBestPractices::Core::Klass.new("BlogPost", "Post", ["Admin"])
-      klass.to_s.should == "Admin::BlogPost"
+    context "Klass" do
+      it "should get to_s" do
+        klass = Klass.new("BlogPost", "Post", ["Admin"])
+        klass.to_s.should == "Admin::BlogPost"
+      end
     end
   end
 end

data/spec/rails_best_practices/core/mailers_spec.rb

@@ -1,5 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Mailers do
-  it { should be_a_kind_of RailsBestPractices::Core::Klasses }
+module RailsBestPractices::Core
+  describe Mailers do
+    it { should be_a_kind_of Klasses }
+  end
 end

data/spec/rails_best_practices/core/methods_spec.rb

@@ -1,44 +1,46 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Methods do
-  let(:methods) { RailsBestPractices::Core::Methods.new }
+module RailsBestPractices::Core
+  describe Methods do
+    let(:methods) { Methods.new }
 
-  before :each do
-    methods.add_method("Post", "create")
-    methods.add_method("Post", "destroy")
-    methods.add_method("Post", "save_or_update", {}, "protected")
-    methods.add_method("Post", "find_by_sql", {}, "private")
-    methods.add_method("Comment", "create")
-  end
+    before :each do
+      methods.add_method("Post", "create")
+      methods.add_method("Post", "destroy")
+      methods.add_method("Post", "save_or_update", {}, "protected")
+      methods.add_method("Post", "find_by_sql", {}, "private")
+      methods.add_method("Comment", "create")
+    end
 
-  it "should get_methods" do
-    methods.get_methods("Post").map(&:method_name).should == ["create", "destroy", "save_or_update", "find_by_sql"]
-    methods.get_methods("Post", "public").map(&:method_name).should == ["create", "destroy"]
-    methods.get_methods("Post", "protected").map(&:method_name).should == ["save_or_update"]
-    methods.get_methods("Post", "private").map(&:method_name).should == ["find_by_sql"]
-    methods.get_methods("Comment").map(&:method_name).should == ["create"]
-  end
+    it "should get_methods" do
+      methods.get_methods("Post").map(&:method_name).should == ["create", "destroy", "save_or_update", "find_by_sql"]
+      methods.get_methods("Post", "public").map(&:method_name).should == ["create", "destroy"]
+      methods.get_methods("Post", "protected").map(&:method_name).should == ["save_or_update"]
+      methods.get_methods("Post", "private").map(&:method_name).should == ["find_by_sql"]
+      methods.get_methods("Comment").map(&:method_name).should == ["create"]
+    end
 
-  it "should has_method?" do
-    methods.should be_has_method("Post", "create", "public")
-    methods.should be_has_method("Post", "destroy", "public")
-    methods.should_not be_has_method("Post", "save_or_update", "public")
-    methods.should be_has_method("Post", "save_or_update", "protected")
-    methods.should_not be_has_method("Post", "find_by_sql", "public")
-    methods.should be_has_method("Post", "find_by_sql", "private")
-    methods.should_not be_has_method("Comment", "destroy")
-  end
+    it "should has_method?" do
+      methods.should be_has_method("Post", "create", "public")
+      methods.should be_has_method("Post", "destroy", "public")
+      methods.should_not be_has_method("Post", "save_or_update", "public")
+      methods.should be_has_method("Post", "save_or_update", "protected")
+      methods.should_not be_has_method("Post", "find_by_sql", "public")
+      methods.should be_has_method("Post", "find_by_sql", "private")
+      methods.should_not be_has_method("Comment", "destroy")
+    end
 
-  it "should get_method" do
-    methods.get_method("Post", "create", "public").should_not be_nil
-    methods.get_method("Post", "create", "protected").should be_nil
-  end
+    it "should get_method" do
+      methods.get_method("Post", "create", "public").should_not be_nil
+      methods.get_method("Post", "create", "protected").should be_nil
+    end
 
-  it "should get_all_unused_methods" do
-    methods.get_method("Comment", "create").mark_used
-    methods.get_all_unused_methods("public").map(&:method_name).should == ["create", "destroy"]
-    methods.get_all_unused_methods("protected").map(&:method_name).should == ["save_or_update"]
-    methods.get_all_unused_methods("private").map(&:method_name).should == ["find_by_sql"]
-    methods.get_all_unused_methods.map(&:method_name).should == ["create", "destroy", "save_or_update", "find_by_sql"]
+    it "should get_all_unused_methods" do
+      methods.get_method("Comment", "create").mark_used
+      methods.get_all_unused_methods("public").map(&:method_name).should == ["create", "destroy"]
+      methods.get_all_unused_methods("protected").map(&:method_name).should == ["save_or_update"]
+      methods.get_all_unused_methods("private").map(&:method_name).should == ["find_by_sql"]
+      methods.get_all_unused_methods.map(&:method_name).should == ["create", "destroy", "save_or_update", "find_by_sql"]
+    end
   end
 end

data/spec/rails_best_practices/core/model_associations_spec.rb

@@ -1,22 +1,24 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::ModelAssociations do
-  let(:model_associations) { RailsBestPractices::Core::ModelAssociations.new }
+module RailsBestPractices::Core
+  describe ModelAssociations do
+    let(:model_associations) { ModelAssociations.new }
 
-  before :each do
-    model_associations.add_association("Project", "project_manager", "belongs_to")
-    model_associations.add_association("Project", "people", "has_many", "Person")
-  end
+    before :each do
+      model_associations.add_association("Project", "project_manager", "belongs_to")
+      model_associations.add_association("Project", "people", "has_many", "Person")
+    end
 
-  it "should get model associations" do
-    model_associations.get_association("Project", "project_manager").should == {"meta" => "belongs_to", "class_name" => "ProjectManager"}
-    model_associations.get_association("Project", "people").should == {"meta" => "has_many", "class_name" => "Person"}
-    model_associations.get_association("Project", "unknown").should be_nil
-  end
+    it "should get model associations" do
+      model_associations.get_association("Project", "project_manager").should == {"meta" => "belongs_to", "class_name" => "ProjectManager"}
+      model_associations.get_association("Project", "people").should == {"meta" => "has_many", "class_name" => "Person"}
+      model_associations.get_association("Project", "unknown").should be_nil
+    end
 
-  it "should check is model associatiosn" do
-    model_associations.is_association?("Project", "project_manager").should be_true
-    model_associations.is_association?("Project", "people").should be_true
-    model_associations.is_association?("Project", "unknown").should be_false
+    it "should check is model associatiosn" do
+      model_associations.is_association?("Project", "project_manager").should be_true
+      model_associations.is_association?("Project", "people").should be_true
+      model_associations.is_association?("Project", "unknown").should be_false
+    end
   end
 end

data/spec/rails_best_practices/core/model_attributes_spec.rb

@@ -1,22 +1,24 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::ModelAttributes do
-  let(:model_attributes) { RailsBestPractices::Core::ModelAttributes.new }
+module RailsBestPractices::Core
+  describe ModelAttributes do
+    let(:model_attributes) { ModelAttributes.new }
 
-  before :each do
-    model_attributes.add_attribute("Post", "title", :string)
-    model_attributes.add_attribute("Post", "user_id", :integer)
-  end
+    before :each do
+      model_attributes.add_attribute("Post", "title", :string)
+      model_attributes.add_attribute("Post", "user_id", :integer)
+    end
 
-  it "should get model attributes" do
-    model_attributes.get_attribute_type("Post", "title").should == :string
-    model_attributes.get_attribute_type("Post", "user_id").should == :integer
-    model_attributes.get_attribute_type("Post", "unknonw").should be_nil
-  end
+    it "should get model attributes" do
+      model_attributes.get_attribute_type("Post", "title").should == :string
+      model_attributes.get_attribute_type("Post", "user_id").should == :integer
+      model_attributes.get_attribute_type("Post", "unknonw").should be_nil
+    end
 
-  it "should check is model attributes" do
-    model_attributes.is_attribute?("Post", "title").should be_true
-    model_attributes.is_attribute?("Post", "user_id").should be_true
-    model_attributes.is_attribute?("Post", "unknonw").should be_false
+    it "should check is model attributes" do
+      model_attributes.is_attribute?("Post", "title").should be_true
+      model_attributes.is_attribute?("Post", "user_id").should be_true
+      model_attributes.is_attribute?("Post", "unknonw").should be_false
+    end
   end
 end

data/spec/rails_best_practices/core/models_spec.rb

@@ -1,5 +1,7 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Models do
-  it { should be_a_kind_of RailsBestPractices::Core::Klasses }
+module RailsBestPractices::Core
+  describe Models do
+    it { should be_a_kind_of Klasses }
+  end
 end

data/spec/rails_best_practices/core/modules_spec.rb

@@ -1,26 +1,28 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Modules do
-  it { should be_a_kind_of Array }
+module RailsBestPractices::Core
+  describe Modules do
+    it { should be_a_kind_of Array }
 
-  context "Modules" do
-    before do
-      @mod = RailsBestPractices::Core::Mod.new("PostsHelper", [])
-    end
-    subject { RailsBestPractices::Core::Modules.new.tap { |modules| modules << @mod } }
-    it "should add decendant to the corresponding module" do
-      @mod.should_receive(:add_decendant).with("PostsController")
-      subject.add_module_decendant("PostsHelper", "PostsController")
+    context "Modules" do
+      before do
+        @mod = Mod.new("PostsHelper", [])
+      end
+      subject { Modules.new.tap { |modules| modules << @mod } }
+      it "should add decendant to the corresponding module" do
+        @mod.should_receive(:add_decendant).with("PostsController")
+        subject.add_module_decendant("PostsHelper", "PostsController")
+      end
     end
-  end
 
-  context "Mod" do
-    subject {
-      RailsBestPractices::Core::Mod.new("UsersHelper", ["Admin"]).tap do |mod|
-        mod.add_decendant("Admin::UsersController")
-      end
-    }
-    its(:to_s) { should == "Admin::UsersHelper" }
-    its(:decendants) { should == ["Admin::UsersController"] }
+    context "Mod" do
+      subject {
+        Mod.new("UsersHelper", ["Admin"]).tap do |mod|
+          mod.add_decendant("Admin::UsersController")
+        end
+      }
+      its(:to_s) { should == "Admin::UsersHelper" }
+      its(:decendants) { should == ["Admin::UsersController"] }
+    end
   end
 end

data/spec/rails_best_practices/core/nil_spec.rb

@@ -1,35 +1,37 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Nil do
-  let(:core_nil) { RailsBestPractices::Core::Nil.new }
+module RailsBestPractices::Core
+  describe Nil do
+    let(:core_nil) { Nil.new }
 
-  context "to_s" do
-    it "should return self" do
-      core_nil.to_s.should == core_nil
+    context "to_s" do
+      it "should return self" do
+        core_nil.to_s.should == core_nil
+      end
     end
-  end
 
-  context "hash_size" do
-    it "should return 0" do
-      core_nil.hash_size.should == 0
+    context "hash_size" do
+      it "should return 0" do
+        core_nil.hash_size.should == 0
+      end
     end
-  end
 
-  context "method_missing" do
-    it "should return self" do
-      core_nil.undefined.should == core_nil
+    context "method_missing" do
+      it "should return self" do
+        core_nil.undefined.should == core_nil
+      end
     end
-  end
 
-  context "present?" do
-    it "should return false" do
-      core_nil.should_not be_present
+    context "present?" do
+      it "should return false" do
+        core_nil.should_not be_present
+      end
     end
-  end
 
-  context "blank?" do
-    it "should return true" do
-      core_nil.should be_blank
+    context "blank?" do
+      it "should return true" do
+        core_nil.should be_blank
+      end
     end
   end
 end

data/spec/rails_best_practices/core/routes_spec.rb

@@ -1,22 +1,29 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Routes do
-  let(:routes) { RailsBestPractices::Core::Routes.new }
+module RailsBestPractices::Core
+  describe Routes do
+    let(:routes) { Routes.new }
 
-  it "should add route" do
-    routes.add_route(["admin", "test"], "posts", "new")
-    routes.map(&:to_s).should == ["Admin::Test::PostsController#new"]
-  end
-
-  context "route" do
-    it "should add namesapces, controller name and action name" do
-      route = RailsBestPractices::Core::Route.new(['admin', 'test'], 'posts', 'new')
-      route.to_s.should == "Admin::Test::PostsController#new"
+    it "should add route" do
+      routes.add_route(["admin", "test"], "posts", "new")
+      routes.map(&:to_s).should == ["Admin::Test::PostsController#new"]
     end
 
-    it "should add controller name with namespace" do
-      route = RailsBestPractices::Core::Route.new(['admin'], 'test/posts', 'new')
-      route.to_s.should == "Admin::Test::PostsController#new"
+    context "route" do
+      it "should add namesapces, controller name and action name" do
+        route = Route.new(['admin', 'test'], 'posts', 'new')
+        route.to_s.should == "Admin::Test::PostsController#new"
+      end
+
+      it "should add controller name with namespace" do
+        route = Route.new(['admin'], 'test/posts', 'new')
+        route.to_s.should == "Admin::Test::PostsController#new"
+      end
+
+      it "should add routes without controller" do
+        route = Route.new(['posts'], nil, 'new')
+        route.to_s.should == "PostsController#new"
+      end
     end
   end
 end

data/spec/rails_best_practices/core/runner_spec.rb

@@ -1,22 +1,24 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Core::Runner do
-  describe "load_plugin_reviews" do
-    shared_examples_for 'load_plugin_reviews' do
-      it "should load plugins in lib/rails_best_practices/plugins/reviews" do
-        runner = RailsBestPractices::Core::Runner.new
-        runner.instance_variable_get('@reviews').map(&:class).should include(RailsBestPractices::Plugins::Reviews::NotUseRailsRootReview)
+module RailsBestPractices::Core
+  describe Runner do
+    describe "load_plugin_reviews" do
+      shared_examples_for 'load_plugin_reviews' do
+        it "should load plugins in lib/rails_best_practices/plugins/reviews" do
+          runner = Runner.new
+          runner.instance_variable_get('@reviews').map(&:class).should include(RailsBestPractices::Plugins::Reviews::NotUseRailsRootReview)
+        end
       end
-    end
 
-    context "given a path that ends with a slash" do
-      before { RailsBestPractices::Core::Runner.base_path = 'spec/fixtures/' }
-      it_should_behave_like 'load_plugin_reviews'
-    end
+      context "given a path that ends with a slash" do
+        before { Runner.base_path = 'spec/fixtures/' }
+        it_should_behave_like 'load_plugin_reviews'
+      end
 
-    context "given a path that does not end with a slash" do
-      before { RailsBestPractices::Core::Runner.base_path = 'spec/fixtures' }
-      it_should_behave_like 'load_plugin_reviews'
+      context "given a path that does not end with a slash" do
+        before { Runner.base_path = 'spec/fixtures' }
+        it_should_behave_like 'load_plugin_reviews'
+      end
     end
   end
-end
+end