rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/reviews/use_model_association_review_spec.rb

@@ -1,65 +1,65 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::UseModelAssociationReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::UseModelAssociationReview.new) }
+module RailsBestPractices
+  module Reviews
+    describe UseModelAssociationReview do
+      let(:runner) { Core::Runner.new(:reviews => UseModelAssociationReview.new) }
 
-  it "should use model association for instance variable" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def create
-        @post = Post.new(params[:post])
-        @post.user_id = current_user.id
-        @post.save
+      it "should use model association for instance variable" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def create
+            @post = Post.new(params[:post])
+            @post.user_id = current_user.id
+            @post.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - use model association (for @post)"
       end
-    end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - use model association (for @post)"
-  end
 
-  it "should not use model association without association assign" do
-    content = <<-EOF
-    class PostsController < ApplicationController
-
-      def create
-        @post = Post.new(params[:post])
-        @post.save
+      it "should not use model association without association assign" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def create
+            @post = Post.new(params[:post])
+            @post.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(0).errors
       end
-    end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(0).errors
-  end
-
-  it "should use model association for local variable" do
-    content = <<-EOF
-    class PostsController < ApplicationController
 
-      def create
-        post = Post.new(params[:post])
-        post.user_id = current_user.id
-        post.save
+      it "should use model association for local variable" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def create
+            post = Post.new(params[:post])
+            post.user_id = current_user.id
+            post.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - use model association (for post)"
       end
-    end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - use model association (for post)"
-  end
-
-  it "should not use model association" do
-    content = <<-EOF
-    class PostsController < ApplicationController
 
-      def create
-        post = current_user.posts.buid(params[:post])
-        post.save
+      it "should not use model association" do
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def create
+            post = current_user.posts.buid(params[:post])
+            post.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        runner.should have(0).errors
       end
     end
-    EOF
-    runner.review('app/controllers/posts_controller.rb', content)
-    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb

@@ -1,211 +1,213 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Reviews::UseMultipartAlternativeAsContentTypeOfEmailReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::UseMultipartAlternativeAsContentTypeOfEmailReview.new) }
-
-  before :each do
-    RailsBestPractices::Core::Runner.stub!(:base_path).and_return(".")
-  end
-
-  def mock_email_files(entry_files, options={})
-    Dir.stub!(:entries).with("./app/views/project_mailer").and_return(entry_files)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.erb").and_return(options["text.plain.erb"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.erb").and_return(options["text.html.erb"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.erb").and_return(options["text.erb"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.erb").and_return(options["html.erb"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.haml").and_return(options["text.plain.haml"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.haml").and_return(options["text.html.haml"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.haml").and_return(options["text.haml"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.haml").and_return(options["html.haml"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.slim").and_return(options["text.plain.slim"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.slim").and_return(options["text.html.slim"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.slim").and_return(options["text.slim"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.slim").and_return(options["html.slim"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.rhtml").and_return(options["text.plain.rhtml"] || false)
-    File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.rhtml").and_return(options["text.html.rhtml"] || false)
-  end
-
-  context "rails2" do
-    context "project_mailer" do
-      let(:content) {
-        <<-EOF
-        class ProjectMailer < ActionMailer::Base
-          def send_email(email)
-            subject       email.subject
-            from          email.from
-            recipients    email.recipients
-            sent_on       Time.now
-            body          :email => email
-          end
-        end
-        EOF
-      }
-
-      context "erb" do
-        it "should use mulipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.erb"], "text.html.erb" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
-        end
-
-        it "should not use multipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.erb"], "text.plain.erb" => true, "text.html.erb" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-
-        it "should not use multiple/alternative as content_type of email when only plain text" do
-          mock_email_files(["send_email.text.plain.erb"], "text.plain.erb" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
+module RailsBestPractices
+  module Reviews
+    describe UseMultipartAlternativeAsContentTypeOfEmailReview do
+      let(:runner) { Core::Runner.new(:reviews => UseMultipartAlternativeAsContentTypeOfEmailReview.new) }
+
+      before(:each) { Core::Runner.stub!(:base_path).and_return(".") }
+
+      def mock_email_files(entry_files, options={})
+        Dir.stub!(:entries).with("./app/views/project_mailer").and_return(entry_files)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.erb").and_return(options["text.plain.erb"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.erb").and_return(options["text.html.erb"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.erb").and_return(options["text.erb"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.erb").and_return(options["html.erb"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.haml").and_return(options["text.plain.haml"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.haml").and_return(options["text.html.haml"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.haml").and_return(options["text.haml"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.haml").and_return(options["html.haml"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.slim").and_return(options["text.plain.slim"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.slim").and_return(options["text.html.slim"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.slim").and_return(options["text.slim"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.slim").and_return(options["html.slim"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.rhtml").and_return(options["text.plain.rhtml"] || false)
+        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.rhtml").and_return(options["text.html.rhtml"] || false)
       end
 
-      context "haml" do
-        it "should use mulipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.haml"], "text.html.haml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
-        end
-
-        it "should not use multipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.haml"], "text.plain.haml" => true, "text.html.haml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-
-        it "should not use multiple/alternative as content_type of email when only plain text" do
-          mock_email_files(["send_email.text.plain.haml"], "text.plain.haml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-      end
-
-      context "slim" do
-        it "should use mulipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.slim"], "text.html.slim" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
-        end
-
-        it "should not use multipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.slim"], "text.plain.slim" => true, "text.html.slim" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-
-        it "should not use multiple/alternative as content_type of email when only plain text" do
-          mock_email_files(["send_email.text.plain.slim"], "text.plain.slim" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-      end
-
-      context "rhtml" do
-        it "should use mulipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.rhtml"], "text.html.rhtml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
-        end
-
-        it "should not use multipart/alternative as content_type of email" do
-          mock_email_files(["send_email.text.html.rhtml"], "text.plain.rhtml" => true, "text.html.rhtml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-
-        it "should not use multiple/alternative as content_type of email when only plain text" do
-          mock_email_files(["send_email.text.plain.rhtml"], "text.plain.rhtml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-      end
-    end
-
-    it "should not use mulipart/alternative as content_type of email for non deliver method" do
-      content =<<-EOF
-      class ProjectMailer < ActionMailer::Base
-        def no_deliver
-        end
-      end
-      EOF
-      mock_email_files(["send_email.text.html.erb"])
-      runner.review('app/mailers/project_mailer.rb', content)
-      runner.should have(0).errors
-    end
-  end
+      context "rails2" do
+        context "project_mailer" do
+          let(:content) {
+            <<-EOF
+            class ProjectMailer < ActionMailer::Base
+              def send_email(email)
+                subject       email.subject
+                from          email.from
+                recipients    email.recipients
+                sent_on       Time.now
+                body          :email => email
+              end
+            end
+            EOF
+          }
+
+          context "erb" do
+            it "should use mulipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.erb"], "text.html.erb" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(1).errors
+              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+            end
+
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.erb"], "text.plain.erb" => true, "text.html.erb" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+
+            it "should not use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.erb"], "text.plain.erb" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+          end
 
-  context "rails3" do
-    context "project_mailer" do
-      let(:content) {
-        <<-EOF
-        class ProjectMailer < ActionMailer::Base
-          def send_email(email)
-            subject       email.subject
-            from          email.from
-            recipients    email.recipients
-            sent_on       Time.now
-            body          :email => email
+          context "haml" do
+            it "should use mulipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.haml"], "text.html.haml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(1).errors
+              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+            end
+
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.haml"], "text.plain.haml" => true, "text.html.haml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+
+            it "should not use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.haml"], "text.plain.haml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
           end
-        end
-        EOF
-      }
 
-      context "erb" do
-        it "should use mulipart/alternative as content_type of email" do
-          mock_email_files(["send_email.html.erb"], "html.erb" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
-        end
+          context "slim" do
+            it "should use mulipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.slim"], "text.html.slim" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(1).errors
+              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+            end
+
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.slim"], "text.plain.slim" => true, "text.html.slim" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+
+            it "should not use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.slim"], "text.plain.slim" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+          end
 
-        it "should not use multipart/alternative as content_type of email" do
-          mock_email_files(["send_email.html.erb"], "text.erb" => true, "html.erb" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
+          context "rhtml" do
+            it "should use mulipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.rhtml"], "text.html.rhtml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(1).errors
+              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+            end
+
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.html.rhtml"], "text.plain.rhtml" => true, "text.html.rhtml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+
+            it "should not use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.rhtml"], "text.plain.rhtml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+          end
         end
 
-        it "should not use multiple/alternative as content_type of email when only plain text" do
-          mock_email_files(["send_email.text.erb"], "text.erb" => true)
+        it "should not use mulipart/alternative as content_type of email for non deliver method" do
+          content =<<-EOF
+          class ProjectMailer < ActionMailer::Base
+            def no_deliver
+            end
+          end
+          EOF
+          mock_email_files(["send_email.text.html.erb"])
           runner.review('app/mailers/project_mailer.rb', content)
           runner.should have(0).errors
         end
       end
 
-      context "haml" do
-        it "should use mulipart/alternative as content_type of email" do
-          mock_email_files(["send_email.html.haml"], "html.haml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
-        end
-
-        it "should not use multipart/alternative as content_type of email" do
-          mock_email_files(["send_email.html.haml", "send_email.text.haml"], "html.haml" => true, "text.haml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
+      context "rails3" do
+        context "project_mailer" do
+          let(:content) {
+            <<-EOF
+            class ProjectMailer < ActionMailer::Base
+              def send_email(email)
+                subject       email.subject
+                from          email.from
+                recipients    email.recipients
+                sent_on       Time.now
+                body          :email => email
+              end
+            end
+            EOF
+          }
+
+          context "erb" do
+            it "should use mulipart/alternative as content_type of email" do
+              mock_email_files(["send_email.html.erb"], "html.erb" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(1).errors
+              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+            end
+
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.html.erb"], "text.erb" => true, "html.erb" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+
+            it "should not use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.erb"], "text.erb" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+          end
 
-        it "should not use multiple/alternative as content_type of email when only plain text" do
-          mock_email_files(["send_email.text.haml"], "text.haml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
-        end
-      end
+          context "haml" do
+            it "should use mulipart/alternative as content_type of email" do
+              mock_email_files(["send_email.html.haml"], "html.haml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(1).errors
+              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+            end
+
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.html.haml", "send_email.text.haml"], "html.haml" => true, "text.haml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+
+            it "should not use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.haml"], "text.haml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+          end
 
-      context "haml/erb mix" do
-        it "should not suggest using multipart/alternative when mixing html.haml and text.erb" do
-          mock_email_files(["send_email.html.haml", "send_email.text.erb"], "html.haml" => true, "text.erb" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
+          context "haml/erb mix" do
+            it "should not suggest using multipart/alternative when mixing html.haml and text.erb" do
+              mock_email_files(["send_email.html.haml", "send_email.text.erb"], "html.haml" => true, "text.erb" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
 
-          mock_email_files(["send_email.html.erb", "send_email.text.haml"], "html.erb" => true, "text.haml" => true)
-          runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
+              mock_email_files(["send_email.html.erb", "send_email.text.haml"], "html.erb" => true, "text.haml" => true)
+              runner.review('app/mailers/project_mailer.rb', content)
+              runner.should have(0).errors
+            end
+          end
         end
       end
     end