rails_best_practices 1.9.0 → 1.9.1

data/spec/rails_best_practices/core_ext/sexp_spec.rb

@@ -48,19 +48,35 @@ describe Sexp do
     it "should get the call nodes with subject current_user" do
       nodes = []
       @node.grep_nodes(:sexp_type => :call, :subject => "current_user") { |node| nodes << node }
-      nodes.should == [s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))]
+      if RUBY_VERSION == "1.9.2"
+        nodes.should == [s(:call, s(:var_ref, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))]
+      else
+        nodes.should == [s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))]
+      end
     end
 
     it "should get the call nodes with different messages" do
       nodes = []
       @node.grep_nodes(:sexp_type => :call, :message => ["posts", "find"]) { |node| nodes << node }
-      nodes.should == [s(:call, s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21))), :".", s(:@ident, "find", s(2, 27))), s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))]
+      if RUBY_VERSION == "1.9.2"
+        nodes.should == [s(:call, s(:call, s(:var_ref, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21))), :".", s(:@ident, "find", s(2, 27))), s(:call, s(:var_ref, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))]
+      else
+        nodes.should == [s(:call, s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21))), :".", s(:@ident, "find", s(2, 27))), s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))]
+      end
     end
 
-    it "should get the vcall node with to_s" do
-      nodes = []
-      @node.grep_nodes(:sexp_type => :vcall, :to_s => "current_user") { |node| nodes << node }
-      nodes.should == [s(:vcall, s(:@ident, "current_user", s(2, 8)))]
+    if RUBY_VERSION == "1.9.2"
+      it "should get the var_ref node with to_s" do
+        nodes = []
+        @node.grep_nodes(:sexp_type => :var_ref, :to_s => "current_user") { |node| nodes << node }
+        nodes.should == [s(:var_ref, s(:@ident, "current_user", s(2, 8)))]
+      end
+    else
+      it "should get the vcall node with to_s" do
+        nodes = []
+        @node.grep_nodes(:sexp_type => :vcall, :to_s => "current_user") { |node| nodes << node }
+        nodes.should == [s(:vcall, s(:@ident, "current_user", s(2, 8)))]
+      end
     end
   end
 
@@ -76,7 +92,11 @@ describe Sexp do
 
     it "should get first node with empty argument" do
       node = @node.grep_node(:sexp_type => :call, :subject => "current_user")
-      node.should == s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))
+      if RUBY_VERSION == "1.9.2"
+        node.should == s(:call, s(:var_ref, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))
+      else
+        node.should == s(:call, s(:vcall, s(:@ident, "current_user", s(2, 8))), :".", s(:@ident, "posts", s(2, 21)))
+      end
     end
   end
 
@@ -525,6 +545,11 @@ describe Sexp do
       node = parse_content("{first_name: 'Richard'}").grep_node(:sexp_type => :@label)
       node.to_s.should == "first_name"
     end
+
+    it "should get to_s for call" do
+      node = parse_content("current_user.post").grep_node(:sexp_type => :call)
+      node.to_s.should == "current_user.post"
+    end
   end
 
   describe "const?" do

data/spec/rails_best_practices/lexicals/remove_tab_check_spec.rb

@@ -1,39 +1,43 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Lexicals::RemoveTabCheck do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:lexicals => RailsBestPractices::Lexicals::RemoveTabCheck.new) }
+module RailsBestPractices
+  module Lexicals
+    describe RemoveTabCheck do
+      let(:runner) { Core::Runner.new(:lexicals => RemoveTabCheck.new) }
 
-  it "should remove tab" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      has_many :projects
-    end
-    EOF
-    content.gsub!("\n", "\t\n")
-    runner.lexical('app/models/user.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/models/user.rb:1 - remove tab, use spaces instead"
-  end
+      it "should remove tab" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          has_many :projects
+        end
+        EOF
+        content.gsub!("\n", "\t\n")
+        runner.lexical('app/models/user.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/models/user.rb:1 - remove tab, use spaces instead"
+      end
 
-  it "should remove tab with third line" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      has_many :projects
-\t
-    end
-    EOF
-    runner.lexical('app/models/user.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/models/user.rb:3 - remove tab, use spaces instead"
-  end
+      it "should remove tab with third line" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          has_many :projects
+  \t
+        end
+        EOF
+        runner.lexical('app/models/user.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/models/user.rb:3 - remove tab, use spaces instead"
+      end
 
-  it "should not remove trailing whitespace" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      has_many :projects
+      it "should not remove trailing whitespace" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          has_many :projects
+        end
+        EOF
+        runner.lexical('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
     end
-    EOF
-    runner.lexical('app/models/user.rb', content)
-    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb

@@ -1,39 +1,43 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Lexicals::RemoveTrailingWhitespaceCheck do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:lexicals => RailsBestPractices::Lexicals::RemoveTrailingWhitespaceCheck.new) }
+module RailsBestPractices
+  module Lexicals
+    describe RemoveTrailingWhitespaceCheck do
+      let(:runner) { Core::Runner.new(:lexicals => RemoveTrailingWhitespaceCheck.new) }
 
-  it "should remove trailing whitespace" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      has_many :projects
-    end
-    EOF
-    content.gsub!("\n", "  \n")
-    runner.lexical('app/models/user.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/models/user.rb:1 - remove trailing whitespace"
-  end
+      it "should remove trailing whitespace" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          has_many :projects
+        end
+        EOF
+        content.gsub!("\n", "  \n")
+        runner.lexical('app/models/user.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/models/user.rb:1 - remove trailing whitespace"
+      end
 
-  it "should remove whitespace with third line" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      has_many :projects
-    end
-    EOF
-    content.gsub!("d\n", "d  \n")
-    runner.lexical('app/models/user.rb', content)
-    runner.should have(1).errors
-    runner.errors[0].to_s.should == "app/models/user.rb:3 - remove trailing whitespace"
-  end
+      it "should remove whitespace with third line" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          has_many :projects
+        end
+        EOF
+        content.gsub!("d\n", "d  \n")
+        runner.lexical('app/models/user.rb', content)
+        runner.should have(1).errors
+        runner.errors[0].to_s.should == "app/models/user.rb:3 - remove trailing whitespace"
+      end
 
-  it "should not remove trailing whitespace" do
-    content =<<-EOF
-    class User < ActiveRecord::Base
-      has_many :projects
+      it "should not remove trailing whitespace" do
+        content =<<-EOF
+        class User < ActiveRecord::Base
+          has_many :projects
+        end
+        EOF
+        runner.lexical('app/models/user.rb', content)
+        runner.should have(0).errors
+      end
     end
-    EOF
-    runner.lexical('app/models/user.rb', content)
-    runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/prepares/config_prepare_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module RailsBestPractices
+  module Prepares
+    describe ConfigPrepare do
+      let(:runner) { Core::Runner.new(:prepares => ConfigPrepare.new) }
+
+      context "configs" do
+        it "should parse configs" do
+          content =<<-EOF
+          module RailsBestPracticesCom
+            class Application < Rails::Application
+              config.active_record.whitelist_attributes = true
+            end
+          end
+          EOF
+          runner.prepare('config/application.rb', content)
+          configs = Prepares.configs
+          configs["config.active_record.whitelist_attributes"].should == "true"
+        end
+      end
+    end
+  end
+end

data/spec/rails_best_practices/prepares/controller_prepare_spec.rb

@@ -1,146 +1,145 @@
 require 'spec_helper'
 
-describe RailsBestPractices::Prepares::ControllerPrepare do
-  let(:runner) { RailsBestPractices::Core::Runner.new(
-    :prepares => [RailsBestPractices::Prepares::ControllerPrepare.new, RailsBestPractices::Prepares::HelperPrepare.new]
-  ) }
+module RailsBestPractices
+  module Prepares
+    describe ControllerPrepare do
+      let(:runner) { Core::Runner.new(:prepares => [ControllerPrepare.new, HelperPrepare.new]) }
+      before(:each) { runner.whiny = true }
 
-  before :each do
-    runner.whiny = true
-  end
-
-  context "methods" do
-    it "should parse controller methods" do
-      content =<<-EOF
-      class PostsController < ApplicationController
-        def index; end
-        def show; end
-      end
-      EOF
-      runner.prepare('app/controllers/posts_controller.rb', content)
-      methods = RailsBestPractices::Prepares.controller_methods
-      methods.get_methods("PostsController").map(&:method_name).should == ["index", "show"]
-    end
-
-    it "should parse model methods with access control" do
-      content =<<-EOF
-      class PostsController < ApplicationController
-        def index; end
-        def show; end
-        protected
-        def resources; end
-        private
-        def resource; end
-      end
-      EOF
-      runner.prepare('app/controllers/posts_controller.rb', content)
-      methods = RailsBestPractices::Prepares.controller_methods
-      methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "resources", "resource"]
-      methods.get_methods("PostsController", "public").map(&:method_name).should == ["index", "show"]
-      methods.get_methods("PostsController", "protected").map(&:method_name).should == ["resources"]
-      methods.get_methods("PostsController", "private").map(&:method_name).should == ["resource"]
-    end
-
-    it "should parse controller methods with module ::" do
-      content =<<-EOF
-      class Admin::Blog::PostsController < ApplicationController
-        def index; end
-        def show; end
-      end
-      EOF
-      runner.prepare('app/controllers/admin/posts_controller.rb', content)
-      methods = RailsBestPractices::Prepares.controller_methods
-      methods.get_methods("Admin::Blog::PostsController").map(&:method_name).should == ["index", "show"]
-    end
-
-    it "should parse controller methods with module" do
-      content =<<-EOF
-      module Admin
-        module Blog
+      context "methods" do
+        it "should parse controller methods" do
+          content =<<-EOF
           class PostsController < ApplicationController
             def index; end
             def show; end
           end
+          EOF
+          runner.prepare('app/controllers/posts_controller.rb', content)
+          methods = Prepares.controller_methods
+          methods.get_methods("PostsController").map(&:method_name).should == ["index", "show"]
         end
-      end
-      EOF
-      runner.prepare('app/controllers/admin/posts_controller.rb', content)
-      methods = RailsBestPractices::Prepares.controller_methods
-      methods.get_methods("Admin::Blog::PostsController").map(&:method_name).should == ["index", "show"]
-    end
 
-    context "inherited_resources" do
-      it "extend inherited_resources" do
-        content =<<-EOF
-        class PostsController < InheritedResources::Base
+        it "should parse model methods with access control" do
+          content =<<-EOF
+          class PostsController < ApplicationController
+            def index; end
+            def show; end
+            protected
+            def resources; end
+            private
+            def resource; end
+          end
+          EOF
+          runner.prepare('app/controllers/posts_controller.rb', content)
+          methods = Prepares.controller_methods
+          methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "resources", "resource"]
+          methods.get_methods("PostsController", "public").map(&:method_name).should == ["index", "show"]
+          methods.get_methods("PostsController", "protected").map(&:method_name).should == ["resources"]
+          methods.get_methods("PostsController", "private").map(&:method_name).should == ["resource"]
         end
-        EOF
-        runner.prepare('app/controllers/posts_controller.rb', content)
-        methods = RailsBestPractices::Prepares.controller_methods
-        methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "new", "create", "edit", "update", "destroy"]
-      end
 
-      it "extend inherited_resources with actions" do
-        content =<<-EOF
-        class PostsController < InheritedResources::Base
-          actions :index, :show
+        it "should parse controller methods with module ::" do
+          content =<<-EOF
+          class Admin::Blog::PostsController < ApplicationController
+            def index; end
+            def show; end
+          end
+          EOF
+          runner.prepare('app/controllers/admin/posts_controller.rb', content)
+          methods = Prepares.controller_methods
+          methods.get_methods("Admin::Blog::PostsController").map(&:method_name).should == ["index", "show"]
         end
-        EOF
-        runner.prepare('app/controllers/posts_controller.rb', content)
-        methods = RailsBestPractices::Prepares.controller_methods
-        methods.get_methods("PostsController").map(&:method_name).should == ["index", "show"]
-      end
 
-      it "extend inherited_resources with all actions" do
-        content =<<-EOF
-        class PostsController < InheritedResources::Base
-          actions :all, except: [:show]
+        it "should parse controller methods with module" do
+          content =<<-EOF
+          module Admin
+            module Blog
+              class PostsController < ApplicationController
+                def index; end
+                def show; end
+              end
+            end
+          end
+          EOF
+          runner.prepare('app/controllers/admin/posts_controller.rb', content)
+          methods = Prepares.controller_methods
+          methods.get_methods("Admin::Blog::PostsController").map(&:method_name).should == ["index", "show"]
         end
-        EOF
-        runner.prepare('app/controllers/posts_controller.rb', content)
-        methods = RailsBestPractices::Prepares.controller_methods
-        methods.get_methods("PostsController").map(&:method_name).should == ["index", "new", "create", "edit", "update", "destroy"]
-      end
 
-      it "extend inherited_resources with all actions with no arguments" do
-        content =<<-EOF
-        class PostsController < InheritedResources::Base
-          actions :all
-        end
-        EOF
-        runner.prepare('app/controllers/posts_controller.rb', content)
-        methods = RailsBestPractices::Prepares.controller_methods
-        methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "new", "create", "edit", "update", "destroy"]
-      end
+        context "inherited_resources" do
+          it "extend inherited_resources" do
+            content =<<-EOF
+            class PostsController < InheritedResources::Base
+            end
+            EOF
+            runner.prepare('app/controllers/posts_controller.rb', content)
+            methods = Prepares.controller_methods
+            methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "new", "create", "edit", "update", "destroy"]
+          end
+
+          it "extend inherited_resources with actions" do
+            content =<<-EOF
+            class PostsController < InheritedResources::Base
+              actions :index, :show
+            end
+            EOF
+            runner.prepare('app/controllers/posts_controller.rb', content)
+            methods = Prepares.controller_methods
+            methods.get_methods("PostsController").map(&:method_name).should == ["index", "show"]
+          end
+
+          it "extend inherited_resources with all actions" do
+            content =<<-EOF
+            class PostsController < InheritedResources::Base
+              actions :all, except: [:show]
+            end
+            EOF
+            runner.prepare('app/controllers/posts_controller.rb', content)
+            methods = Prepares.controller_methods
+            methods.get_methods("PostsController").map(&:method_name).should == ["index", "new", "create", "edit", "update", "destroy"]
+          end
+
+          it "extend inherited_resources with all actions with no arguments" do
+            content =<<-EOF
+            class PostsController < InheritedResources::Base
+              actions :all
+            end
+            EOF
+            runner.prepare('app/controllers/posts_controller.rb', content)
+            methods = Prepares.controller_methods
+            methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "new", "create", "edit", "update", "destroy"]
+          end
 
-      it "DSL inherit_resources" do
-        content =<<-EOF
-        class PostsController
-          inherit_resources
+          it "DSL inherit_resources" do
+            content =<<-EOF
+            class PostsController
+              inherit_resources
+            end
+            EOF
+            runner.prepare('app/controllers/posts_controller.rb', content)
+            methods = Prepares.controller_methods
+            methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "new", "create", "edit", "update", "destroy"]
+          end
         end
-        EOF
-        runner.prepare('app/controllers/posts_controller.rb', content)
-        methods = RailsBestPractices::Prepares.controller_methods
-        methods.get_methods("PostsController").map(&:method_name).should == ["index", "show", "new", "create", "edit", "update", "destroy"]
       end
-    end
-  end
 
-  context "helpers" do
-    it "should add helper decendant" do
-      content =<<-EOF
-      module PostsHelper
-      end
-      EOF
-      runner.prepare('app/helpers/posts_helper.rb', content)
-      content =<<-EOF
-      class PostsController
-        include PostsHelper
+      context "helpers" do
+        it "should add helper decendant" do
+          content =<<-EOF
+          module PostsHelper
+          end
+          EOF
+          runner.prepare('app/helpers/posts_helper.rb', content)
+          content =<<-EOF
+          class PostsController
+            include PostsHelper
+          end
+          EOF
+          runner.prepare('app/controllers/posts_controller.rb', content)
+          helpers = Prepares.helpers
+          helpers.first.decendants.should == ["PostsController"]
+        end
       end
-      EOF
-      runner.prepare('app/controllers/posts_controller.rb', content)
-      helpers = RailsBestPractices::Prepares.helpers
-      helpers.first.decendants.should == ["PostsController"]
     end
   end
 end