puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

data/spec/unit/type/file/ctime_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 
 describe Puppet::Type.type(:file).attrclass(:ctime) do

data/spec/unit/type/file/ensure_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 require 'puppet/type/file/ensure'
 
@@ -15,14 +14,14 @@ describe Puppet::Type::File::Ensure do
 
   describe "when retrieving the current state" do
     it "should return :absent if the file does not exist" do
-      resource.expects(:stat).returns nil
+      expect(resource).to receive(:stat).and_return(nil)
 
       expect(property.retrieve).to eq(:absent)
     end
 
     it "should return the current file type if the file exists" do
-      stat = mock 'stat', :ftype => "directory"
-      resource.expects(:stat).returns stat
+      stat = double('stat', :ftype => "directory")
+      expect(resource).to receive(:stat).and_return(stat)
 
       expect(property.retrieve).to eq(:directory)
     end
@@ -31,7 +30,7 @@ describe Puppet::Type::File::Ensure do
   describe "when testing whether :ensure is in sync" do
     it "should always be in sync if replace is 'false' unless the file is missing" do
       property.should = :file
-      resource.expects(:replace?).returns false
+      expect(resource).to receive(:replace?).and_return(false)
       expect(property.safe_insync?(:link)).to be_truthy
     end
 
@@ -89,32 +88,32 @@ describe Puppet::Type::File::Ensure do
 
       it "should accept octal mode as fixnum" do
         resource[:mode] = '0700'
-        resource.expects(:property_fix)
-        Dir.expects(:mkdir).with(path, 0700)
+        expect(resource).to receive(:property_fix)
+        expect(Dir).to receive(:mkdir).with(path, 0700)
 
         property.sync
       end
 
       it "should accept octal mode as string" do
         resource[:mode] = "700"
-        resource.expects(:property_fix)
-        Dir.expects(:mkdir).with(path, 0700)
+        expect(resource).to receive(:property_fix)
+        expect(Dir).to receive(:mkdir).with(path, 0700)
 
         property.sync
       end
 
       it "should accept octal mode as string with leading zero" do
         resource[:mode] = "0700"
-        resource.expects(:property_fix)
-        Dir.expects(:mkdir).with(path, 0700)
+        expect(resource).to receive(:property_fix)
+        expect(Dir).to receive(:mkdir).with(path, 0700)
 
         property.sync
       end
 
       it "should accept symbolic mode" do
         resource[:mode] = "u=rwx,go=x"
-        resource.expects(:property_fix)
-        Dir.expects(:mkdir).with(path, 0711)
+        expect(resource).to receive(:property_fix)
+        expect(Dir).to receive(:mkdir).with(path, 0711)
 
         property.sync
       end

data/spec/unit/type/file/group_spec.rb

@@ -1,5 +1,3 @@
-#! /usr/bin/env ruby
-
 require 'spec_helper'
 
 describe Puppet::Type.type(:file).attrclass(:group) do
@@ -19,12 +17,12 @@ describe Puppet::Type.type(:file).attrclass(:group) do
     before :each do
       resource[:group] = ['foos', 'bars']
 
-      resource.provider.stubs(:name2gid).with('foos').returns 1001
-      resource.provider.stubs(:name2gid).with('bars').returns 1002
+      allow(resource.provider).to receive(:name2gid).with('foos').and_return(1001)
+      allow(resource.provider).to receive(:name2gid).with('bars').and_return(1002)
     end
 
     it "should fail if a group's id can't be found by name" do
-      resource.provider.stubs(:name2gid).returns nil
+      allow(resource.provider).to receive(:name2gid).and_return(nil)
 
       expect { group.insync?(5) }.to raise_error(/Could not find group foos/)
     end
@@ -45,13 +43,13 @@ describe Puppet::Type.type(:file).attrclass(:group) do
   %w[is_to_s should_to_s].each do |prop_to_s|
     describe "##{prop_to_s}" do
       it "should use the name of the user if it can find it" do
-        resource.provider.stubs(:gid2name).with(1001).returns 'foos'
+        allow(resource.provider).to receive(:gid2name).with(1001).and_return('foos')
 
         expect(group.send(prop_to_s, 1001)).to eq("'foos'")
       end
 
       it "should use the id of the user if it can't" do
-        resource.provider.stubs(:gid2name).with(1001).returns nil
+        allow(resource.provider).to receive(:gid2name).with(1001).and_return(nil)
 
         expect(group.send(prop_to_s, 1001)).to eq('1001')
       end

data/spec/unit/type/file/mode_spec.rb

@@ -1,5 +1,3 @@
-#! /usr/bin/env ruby
-
 require 'spec_helper'
 
 describe Puppet::Type.type(:file).attrclass(:mode) do
@@ -121,8 +119,8 @@ describe Puppet::Type.type(:file).attrclass(:mode) do
     it "should retrieve the directory mode from the provider" do
       Dir.mkdir(path)
 
-      mode.expects(:dirmask).with('644').returns '755'
-      resource.provider.expects(:mode).returns '755'
+      expect(mode).to receive(:dirmask).with('644').and_return('755')
+      expect(resource.provider).to receive(:mode).and_return('755')
 
       expect(mode.retrieve).to eq('755')
     end
@@ -130,8 +128,8 @@ describe Puppet::Type.type(:file).attrclass(:mode) do
     it "should retrieve the file mode from the provider" do
       FileUtils.touch(path)
 
-      mode.expects(:dirmask).with('644').returns '644'
-      resource.provider.expects(:mode).returns '644'
+      expect(mode).to receive(:dirmask).with('644').and_return('644')
+      expect(resource.provider).to receive(:mode).and_return('644')
 
       expect(mode.retrieve).to eq('644')
     end

data/spec/unit/type/file/mtime_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 
 describe Puppet::Type.type(:file).attrclass(:mtime) do

data/spec/unit/type/file/owner_spec.rb

@@ -1,5 +1,3 @@
-#! /usr/bin/env ruby
-
 require 'spec_helper'
 
 describe Puppet::Type.type(:file).attrclass(:owner) do
@@ -10,19 +8,19 @@ describe Puppet::Type.type(:file).attrclass(:owner) do
   let(:owner) { resource.property(:owner) }
 
   before :each do
-    Puppet.features.stubs(:root?).returns(true)
+    allow(Puppet.features).to receive(:root?).and_return(true)
   end
 
   describe "#insync?" do
     before :each do
       resource[:owner] = ['foo', 'bar']
 
-      resource.provider.stubs(:name2uid).with('foo').returns 1001
-      resource.provider.stubs(:name2uid).with('bar').returns 1002
+      allow(resource.provider).to receive(:name2uid).with('foo').and_return(1001)
+      allow(resource.provider).to receive(:name2uid).with('bar').and_return(1002)
     end
 
     it "should fail if an owner's id can't be found by name" do
-      resource.provider.stubs(:name2uid).returns nil
+      allow(resource.provider).to receive(:name2uid).and_return(nil)
 
       expect { owner.insync?(5) }.to raise_error(/Could not find user foo/)
     end
@@ -43,13 +41,13 @@ describe Puppet::Type.type(:file).attrclass(:owner) do
   %w[is_to_s should_to_s].each do |prop_to_s|
     describe "##{prop_to_s}" do
       it "should use the name of the user if it can find it" do
-        resource.provider.stubs(:uid2name).with(1001).returns 'foo'
+        allow(resource.provider).to receive(:uid2name).with(1001).and_return('foo')
 
         expect(owner.send(prop_to_s, 1001)).to eq("'foo'")
       end
 
       it "should use the id of the user if it can't" do
-        resource.provider.stubs(:uid2name).with(1001).returns nil
+        allow(resource.provider).to receive(:uid2name).with(1001).and_return(nil)
 
         expect(owner.send(prop_to_s, 1001)).to eq('1001')
       end

data/spec/unit/type/file/selinux_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 
 [:seluser, :selrole, :seltype, :selrange].each do |param|
@@ -10,26 +9,26 @@ require 'spec_helper'
       @path = make_absolute("/my/file")
       @resource = Puppet::Type.type(:file).new :path => @path
       @sel = property.new :resource => @resource
-      @sel.stubs(:normalize_selinux_category).with("s0").returns("s0")
-      @sel.stubs(:normalize_selinux_category).with(nil).returns(nil)
+      allow(@sel).to receive(:normalize_selinux_category).with("s0").and_return("s0")
+      allow(@sel).to receive(:normalize_selinux_category).with(nil).and_return(nil)
     end
 
     it "retrieve on #{param} should return :absent if the file isn't statable" do
-      @resource.expects(:stat).returns nil
+      expect(@resource).to receive(:stat).and_return(nil)
       expect(@sel.retrieve).to eq(:absent)
     end
 
     it "should retrieve nil for #{param} if there is no SELinux support" do
-      stat = stub 'stat', :ftype => "foo"
-      @resource.expects(:stat).returns stat
-      @sel.expects(:get_selinux_current_context).with(@path).returns nil
+      stat = double('stat', :ftype => "foo")
+      expect(@resource).to receive(:stat).and_return(stat)
+      expect(@sel).to receive(:get_selinux_current_context).with(@path).and_return(nil)
       expect(@sel.retrieve).to be_nil
     end
 
     it "should retrieve #{param} if a SELinux context is found with a range" do
-      stat = stub 'stat', :ftype => "foo"
-      @resource.expects(:stat).returns stat
-      @sel.expects(:get_selinux_current_context).with(@path).returns "user_u:role_r:type_t:s0"
+      stat = double('stat', :ftype => "foo")
+      expect(@resource).to receive(:stat).and_return(stat)
+      expect(@sel).to receive(:get_selinux_current_context).with(@path).and_return("user_u:role_r:type_t:s0")
       expectedresult = case param
         when :seluser; "user_u"
         when :selrole; "role_r"
@@ -40,9 +39,9 @@ require 'spec_helper'
     end
 
     it "should retrieve #{param} if a SELinux context is found without a range" do
-      stat = stub 'stat', :ftype => "foo"
-      @resource.expects(:stat).returns stat
-      @sel.expects(:get_selinux_current_context).with(@path).returns "user_u:role_r:type_t"
+      stat = double('stat', :ftype => "foo")
+      expect(@resource).to receive(:stat).and_return(stat)
+      expect(@sel).to receive(:get_selinux_current_context).with(@path).and_return("user_u:role_r:type_t")
       expectedresult = case param
         when :seluser; "user_u"
         when :selrole; "role_r"
@@ -53,13 +52,13 @@ require 'spec_helper'
     end
 
     it "should handle no default gracefully" do
-      @sel.expects(:get_selinux_default_context).with(@path).returns nil
+      expect(@sel).to receive(:get_selinux_default_context).with(@path).and_return(nil)
       expect(@sel.default).to be_nil
     end
 
     it "should be able to detect matchpathcon defaults" do
-      @sel.stubs(:debug)
-      @sel.expects(:get_selinux_default_context).with(@path).returns "user_u:role_r:type_t:s0"
+      allow(@sel).to receive(:debug)
+      expect(@sel).to receive(:get_selinux_default_context).with(@path).and_return("user_u:role_r:type_t:s0")
       expectedresult = case param
         when :seluser; "user_u"
         when :selrole; "role_r"
@@ -76,15 +75,14 @@ require 'spec_helper'
 
     it "should be able to set a new context" do
       @sel.should = %w{newone}
-      @sel.expects(:set_selinux_context).with(@path, ["newone"], param)
+      expect(@sel).to receive(:set_selinux_context).with(@path, ["newone"], param)
       @sel.sync
     end
 
     it "should do nothing for safe_insync? if no SELinux support" do
       @sel.should = %{newcontext}
-      @sel.expects(:selinux_support?).returns false
+      expect(@sel).to receive(:selinux_support?).and_return(false)
       expect(@sel.safe_insync?("oldcontext")).to eq(true)
     end
   end
 end
-

data/spec/unit/type/file/source_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 require 'uri'
 require 'puppet/network/http_pool'
@@ -33,7 +32,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
   describe "#validate" do
     it "should fail if the set values are not URLs" do
-      URI.expects(:parse).with('foo').raises RuntimeError
+      expect(URI).to receive(:parse).with('foo').and_raise(RuntimeError)
 
       expect(lambda { resource[:source] = %w{foo} }).to raise_error(Puppet::Error)
     end
@@ -96,10 +95,10 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
   describe "when returning the metadata" do
     before do
-      @metadata = stub 'metadata', :source= => nil
-      resource.stubs(:[]).with(:links).returns :manage
-      resource.stubs(:[]).with(:source_permissions).returns :use
-      resource.stubs(:[]).with(:checksum).returns :checksum
+      @metadata = double('metadata', :source= => nil)
+      allow(resource).to receive(:[]).with(:links).and_return(:manage)
+      allow(resource).to receive(:[]).with(:source_permissions).and_return(:use)
+      allow(resource).to receive(:[]).with(:checksum).and_return(:checksum)
     end
 
     it "should return already-available metadata" do
@@ -115,18 +114,20 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
     it "should collect its metadata using the Metadata class if it is not already set" do
       @source = described_class.new(:resource => resource, :value => @foobar)
-      Puppet::FileServing::Metadata.indirection.expects(:find).with do |uri, options|
-        expect(uri).to eq @foobar_uri
-        expect(options[:environment]).to eq environment
-        expect(options[:links]).to eq :manage
-        expect(options[:checksum_type]).to eq :checksum
-      end.returns @metadata
+      expect(Puppet::FileServing::Metadata.indirection).to receive(:find) do |uri, options|
+        expect(uri).to eq(@foobar_uri)
+        expect(options[:environment]).to eq(environment)
+        expect(options[:links]).to eq(:manage)
+        expect(options[:checksum_type]).to eq(:checksum)
+
+        @metadata
+      end
 
       @source.metadata
     end
 
     it "should use the metadata from the first found source" do
-      metadata = stub 'metadata', :source= => nil
+      metadata = double('metadata', :source= => nil)
       @source = described_class.new(:resource => resource, :value => [@foobar, @feebooz])
       options = {
         :environment => environment,
@@ -134,48 +135,52 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
         :source_permissions => :use,
         :checksum_type => :checksum
       }
-      Puppet::FileServing::Metadata.indirection.expects(:find).with(@foobar_uri, options).returns nil
-      Puppet::FileServing::Metadata.indirection.expects(:find).with(@feebooz_uri, options).returns metadata
+      expect(Puppet::FileServing::Metadata.indirection).to receive(:find).with(@foobar_uri, options).and_return(nil)
+      expect(Puppet::FileServing::Metadata.indirection).to receive(:find).with(@feebooz_uri, options).and_return(metadata)
       expect(@source.metadata).to equal(metadata)
     end
 
     it "should store the found source as the metadata's source" do
-      metadata = mock 'metadata'
+      metadata = double('metadata')
       @source = described_class.new(:resource => resource, :value => @foobar)
-      Puppet::FileServing::Metadata.indirection.expects(:find).with do |uri, options|
-        expect(uri).to eq @foobar_uri
-        expect(options[:environment]).to eq environment
-        expect(options[:links]).to eq :manage
-        expect(options[:checksum_type]).to eq :checksum
-      end.returns metadata
-
-      metadata.expects(:source=).with(@foobar_uri)
+      expect(Puppet::FileServing::Metadata.indirection).to receive(:find) do |uri, options|
+        expect(uri).to eq(@foobar_uri)
+        expect(options[:environment]).to eq(environment)
+        expect(options[:links]).to eq(:manage)
+        expect(options[:checksum_type]).to eq(:checksum)
+
+        metadata
+      end
+
+      expect(metadata).to receive(:source=).with(@foobar_uri)
       @source.metadata
     end
 
     it "should fail intelligently if an exception is encountered while querying for metadata" do
       @source = described_class.new(:resource => resource, :value => @foobar)
-      Puppet::FileServing::Metadata.indirection.expects(:find).with do |uri, options|
-        expect(uri).to eq @foobar_uri
-        expect(options[:environment]).to eq environment
-        expect(options[:links]).to eq :manage
-        expect(options[:checksum_type]).to eq :checksum
-      end.raises RuntimeError
-
-      @source.expects(:fail).raises ArgumentError
+      expect(Puppet::FileServing::Metadata.indirection).to receive(:find) do |uri, options|
+        expect(uri).to eq(@foobar_uri)
+        expect(options[:environment]).to eq(environment)
+        expect(options[:links]).to eq(:manage)
+        expect(options[:checksum_type]).to eq(:checksum)
+      end.and_raise(RuntimeError)
+
+      expect(@source).to receive(:fail).and_raise(ArgumentError)
       expect { @source.metadata }.to raise_error(ArgumentError)
     end
 
     it "should fail if no specified sources can be found" do
       @source = described_class.new(:resource => resource, :value => @foobar)
-      Puppet::FileServing::Metadata.indirection.expects(:find).with  do |uri, options|
-        expect(uri).to eq @foobar_uri
-        expect(options[:environment]).to eq environment
-        expect(options[:links]).to eq :manage
-        expect(options[:checksum_type]).to eq :checksum
-      end.returns nil
+      expect(Puppet::FileServing::Metadata.indirection).to receive(:find)  do |uri, options|
+        expect(uri).to eq(@foobar_uri)
+        expect(options[:environment]).to eq(environment)
+        expect(options[:links]).to eq(:manage)
+        expect(options[:checksum_type]).to eq(:checksum)
+
+        nil
+      end
 
-      @source.expects(:fail).raises RuntimeError
+      expect(@source).to receive(:fail).and_raise(RuntimeError)
 
       expect { @source.metadata }.to raise_error(RuntimeError)
     end
@@ -186,24 +191,23 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
   end
 
   describe "when copying the source values" do
-
     before do
-      Puppet::Type.type(:file).any_instance.stubs(:file).returns('my/file.pp')
-      Puppet::Type.type(:file).any_instance.stubs(:line).returns 5
+      allow_any_instance_of(Puppet::Type.type(:file)).to receive(:file).and_return('my/file.pp')
+      allow_any_instance_of(Puppet::Type.type(:file)).to receive(:line).and_return(5)
     end
 
     before :each do
       @resource = Puppet::Type.type(:file).new :path => @foobar
 
       @source = described_class.new(:resource => @resource)
-      @metadata = stub 'metadata', :owner => 100, :group => 200, :mode => "173", :checksum => "{md5}asdfasdf", :checksum_type => "md5", :ftype => "file", :source => @foobar
-      @source.stubs(:metadata).returns @metadata
+      @metadata = double('metadata', :owner => 100, :group => 200, :mode => "173", :checksum => "{md5}asdfasdf", :checksum_type => "md5", :ftype => "file", :source => @foobar)
+      allow(@source).to receive(:metadata).and_return(@metadata)
 
-      Puppet.features.stubs(:root?).returns true
+      allow(Puppet.features).to receive(:root?).and_return(true)
     end
 
     it "should not issue an error - except on Windows - if the source mode value is a Numeric" do
-      @metadata.stubs(:mode).returns 0173
+      allow(@metadata).to receive(:mode).and_return(0173)
       @resource[:source_permissions] = :use
       if Puppet::Util::Platform.windows?
         expect { @source.copy_source_values }.to raise_error("Should not have tried to use source owner/mode/group on Windows (file: my/file.pp, line: 5)")
@@ -213,7 +217,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
     end
 
     it "should not issue an error - except on Windows - if the source mode value is a String" do
-      @metadata.stubs(:mode).returns "173"
+      allow(@metadata).to receive(:mode).and_return("173")
       @resource[:source_permissions] = :use
       if Puppet::Util::Platform.windows?
         expect { @source.copy_source_values }.to raise_error("Should not have tried to use source owner/mode/group on Windows (file: my/file.pp, line: 5)")
@@ -223,20 +227,20 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
     end
 
     it "should fail if there is no metadata" do
-      @source.stubs(:metadata).returns nil
-      @source.expects(:devfail).raises ArgumentError
+      allow(@source).to receive(:metadata).and_return(nil)
+      expect(@source).to receive(:devfail).and_raise(ArgumentError)
       expect { @source.copy_source_values }.to raise_error(ArgumentError)
     end
 
     it "should set :ensure to the file type" do
-      @metadata.stubs(:ftype).returns "file"
+      allow(@metadata).to receive(:ftype).and_return("file")
 
       @source.copy_source_values
       expect(@resource[:ensure]).to eq(:file)
     end
 
     it "should not set 'ensure' if it is already set to 'absent'" do
-      @metadata.stubs(:ftype).returns "file"
+      allow(@metadata).to receive(:ftype).and_return("file")
 
       @resource[:ensure] = :absent
       @source.copy_source_values
@@ -245,8 +249,8 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
     describe "and the source is a file" do
       before do
-        @metadata.stubs(:ftype).returns "file"
-        Puppet.features.stubs(:microsoft_windows?).returns false
+        allow(@metadata).to receive(:ftype).and_return("file")
+        allow(Puppet.features).to receive(:microsoft_windows?).and_return(false)
       end
 
       context "when source_permissions is `use`" do
@@ -284,7 +288,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
         describe "and puppet is not running as root" do
           before do
-            Puppet.features.stubs(:root?).returns false
+            allow(Puppet.features).to receive(:root?).and_return(false)
           end
 
           it "should not try to set the owner" do
@@ -302,13 +306,13 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
       context "when source_permissions is `use_when_creating`" do
         before :each do
           @resource[:source_permissions] = "use_when_creating"
-          Puppet.features.expects(:root?).returns true
-          @source.stubs(:local?).returns(false)
+          expect(Puppet.features).to receive(:root?).and_return(true)
+          allow(@source).to receive(:local?).and_return(false)
         end
 
         context "when managing a new file" do
           it "should copy owner and group from local sources" do
-            @source.stubs(:local?).returns true
+            allow(@source).to receive(:local?).and_return(true)
 
             @source.copy_source_values
 
@@ -338,11 +342,11 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
         context "when managing an existing file" do
           before :each do
-            Puppet::FileSystem.stubs(:exist?).with(@resource[:path]).returns(true)
+            allow(Puppet::FileSystem).to receive(:exist?).with(@resource[:path]).and_return(true)
           end
 
           it "should not copy owner, group or mode from local sources" do
-            @source.stubs(:local?).returns true
+            allow(@source).to receive(:local?).and_return(true)
 
             @source.copy_source_values
 
@@ -373,12 +377,12 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
       context "when source_permissions is default" do
         before :each do
-          @source.stubs(:local?).returns(false)
-          Puppet.features.expects(:root?).returns true
+          allow(@source).to receive(:local?).and_return(false)
+          expect(Puppet.features).to receive(:root?).and_return(true)
         end
 
         it "should not copy owner, group or mode from local sources" do
-          @source.stubs(:local?).returns true
+          allow(@source).to receive(:local?).and_return(true)
 
           @source.copy_source_values
 
@@ -409,19 +413,19 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
     describe "and the source is a link" do
       before do
-        Puppet.features.stubs(:microsoft_windows?).returns false
+        allow(Puppet.features).to receive(:microsoft_windows?).and_return(false)
       end
 
       it "should set the target to the link destination" do
-        @metadata.stubs(:ftype).returns "link"
-        @metadata.stubs(:links).returns "manage"
-        @metadata.stubs(:checksum_type).returns nil
-        @resource.stubs(:[])
-        @resource.stubs(:[]=)
+        allow(@metadata).to receive(:ftype).and_return("link")
+        allow(@metadata).to receive(:links).and_return("manage")
+        allow(@metadata).to receive(:checksum_type).and_return(nil)
+        allow(@resource).to receive(:[])
+        allow(@resource).to receive(:[]=)
 
-        @metadata.expects(:destination).returns "/path/to/symlink"
+        expect(@metadata).to receive(:destination).and_return("/path/to/symlink")
 
-        @resource.expects(:[]=).with(:target, "/path/to/symlink")
+        expect(@resource).to receive(:[]=).with(:target, "/path/to/symlink")
         @source.copy_source_values
       end
     end
@@ -484,11 +488,10 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
 
         before(:each) do
           metadata = Puppet::FileServing::Metadata.new(path, :source => uri, 'type' => 'file')
-          #metadata = stub('remote', :ftype => "file", :source => uri)
-          Puppet::FileServing::Metadata.indirection.stubs(:find).
-            with(uri,all_of(has_key(:environment), has_key(:links))).returns metadata
-          Puppet::FileServing::Metadata.indirection.stubs(:find).
-            with(uri,all_of(has_key(:environment), has_key(:links))).returns metadata
+          allow(Puppet::FileServing::Metadata.indirection).to receive(:find).
+            with(uri, include(:environment, :links)).and_return(metadata)
+          allow(Puppet::FileServing::Metadata.indirection).to receive(:find).
+            with(uri, include(:environment, :links)).and_return(metadata)
           resource[:source] = uri
         end
 
@@ -581,52 +584,52 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
     describe 'from remote source' do
       let(:source_content) { "source file content\n"*10 }
       let(:source) { resource.newattr(:source) }
-      let(:response) { stub_everything('response') }
-      let(:conn) { mock('connection') }
+      let(:response) { double('response', :[] => nil, :body => nil, :message => nil) }
+      let(:conn) { double('connection') }
 
       before do
         resource[:backup] = false
 
-        response.stubs(:read_body).multiple_yields(*source_content.lines)
-        conn.stubs(:request_get).yields(response)
+        expectation = receive(:read_body)
+        source_content.lines.each { |line| expectation = expectation.and_yield(line) }
+        allow(response).to expectation
+        allow(conn).to receive(:request_get).and_yield(response)
       end
 
       it 'should use an explicit fileserver if source starts with puppet://' do
-        response.stubs(:code).returns('200')
-        source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet://somehostname/test/foo', :ftype => 'file')
-        Puppet::Network::HttpPool.expects(:http_instance).with('somehostname', anything).returns(conn)
+        allow(response).to receive(:code).and_return('200')
+        allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet://somehostname/test/foo', :ftype => 'file', :content_uri => nil))
+        expect(Puppet::Network::HttpPool).to receive(:http_instance).with('somehostname', anything).and_return(conn)
 
         resource.write(source)
       end
 
       it 'should use the default fileserver if source starts with puppet:///' do
-        response.stubs(:code).returns('200')
-        source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo', :ftype => 'file')
-        Puppet::Network::HttpPool.expects(:http_instance).with(Puppet.settings[:server], anything).returns(conn)
+        allow(response).to receive(:code).and_return('200')
+        allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo', :ftype => 'file', :content_uri => nil))
+        expect(Puppet::Network::HttpPool).to receive(:http_instance).with(Puppet.settings[:server], anything).and_return(conn)
 
         resource.write(source)
       end
 
       it 'should percent encode reserved characters' do
-        response.stubs(:code).returns('200')
-        Puppet::Network::HttpPool.stubs(:http_instance).returns(conn)
-        source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file')
+        allow(response).to receive(:code).and_return('200')
+        allow(Puppet::Network::HttpPool).to receive(:http_instance).and_return(conn)
+        allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file', :content_uri => nil))
 
-        conn.unstub(:request_get)
-        conn.expects(:request_get).with("#{Puppet::Network::HTTP::MASTER_URL_PREFIX}/v3/file_content/test/foo%20bar?environment=myenv&", anything).yields(response)
+        expect(conn).to receive(:request_get).with("#{Puppet::Network::HTTP::MASTER_URL_PREFIX}/v3/file_content/test/foo%20bar?environment=myenv&", anything).and_yield(response)
 
         resource.write(source)
       end
 
       it 'should request binary content' do
-        response.stubs(:code).returns('200')
-        Puppet::Network::HttpPool.stubs(:http_instance).returns(conn)
-        source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file')
+        allow(response).to receive(:code).and_return('200')
+        allow(Puppet::Network::HttpPool).to receive(:http_instance).and_return(conn)
+        allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo bar', :ftype => 'file', :content_uri => nil))
 
-        conn.unstub(:request_get)
-        conn.expects(:request_get).with do |_, options|
+        expect(conn).to receive(:request_get) do |_, options|
           expect(options).to include('Accept' => 'application/octet-stream')
-        end.yields(response)
+        end.and_yield(response)
 
         resource.write(source)
       end
@@ -637,25 +640,25 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do
         end
 
         before(:each) do
-          Puppet::Network::HttpPool.stubs(:http_instance).returns(conn)
-          source.stubs(:metadata).returns stub_everything('metadata', :source => 'puppet:///test/foo', :ftype => 'file')
+          allow(Puppet::Network::HttpPool).to receive(:http_instance).and_return(conn)
+          allow(source).to receive(:metadata).and_return(double('metadata', :source => 'puppet:///test/foo', :ftype => 'file', :content_uri => nil))
         end
 
         it 'should not write anything if source is not found' do
-          response.stubs(:code).returns('404')
+          allow(response).to receive(:code).and_return('404')
 
           expect { resource.write(source) }.to raise_error(Net::HTTPError, /404/)
           expect(File.read(filename)).to eq('initial file content')
         end
 
         it 'should raise an HTTP error in case of server error' do
-          response.stubs(:code).returns('500')
+          allow(response).to receive(:code).and_return('500')
 
           expect { resource.write(source) }.to raise_error(Net::HTTPError, /500/)
         end
 
         context 'and the request was successful' do
-          before(:each) { response.stubs(:code).returns '200' }
+          before(:each) { allow(response).to receive(:code).and_return('200') }
 
           it 'should write the contents to the file' do
             resource.write(source)