puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/application/master'
@@ -9,16 +8,20 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
9
8
  before :each do
10
9
  Puppet[:bindaddress] = '127.0.0.1'
11
10
  @master = Puppet::Application[:master]
12
- @daemon = stub_everything 'daemon'
13
- Puppet::Daemon.stubs(:new).returns(@daemon)
14
- Puppet::Util::Log.stubs(:newdestination)
15
-
16
- Puppet::Node.indirection.stubs(:terminus_class=)
17
- Puppet::Node::Facts.indirection.stubs(:terminus_class=)
18
- Puppet::Node::Facts.indirection.stubs(:cache_class=)
19
- Puppet::Transaction::Report.indirection.stubs(:terminus_class=)
20
- Puppet::Resource::Catalog.indirection.stubs(:terminus_class=)
21
- Puppet::SSL::Host.stubs(:ca_location=)
11
+ @daemon = double('daemon')
12
+ allow(@daemon).to receive(:argv=)
13
+ allow(@daemon).to receive(:server=)
14
+ allow(@daemon).to receive(:set_signal_traps)
15
+ allow(@daemon).to receive(:start)
16
+ allow(Puppet::Daemon).to receive(:new).and_return(@daemon)
17
+ allow(Puppet::Util::Log).to receive(:newdestination)
18
+
19
+ allow(Puppet::Node.indirection).to receive(:terminus_class=)
20
+ allow(Puppet::Node::Facts.indirection).to receive(:terminus_class=)
21
+ allow(Puppet::Node::Facts.indirection).to receive(:cache_class=)
22
+ allow(Puppet::Transaction::Report.indirection).to receive(:terminus_class=)
23
+ allow(Puppet::Resource::Catalog.indirection).to receive(:terminus_class=)
24
+ allow(Puppet::SSL::Host).to receive(:ca_location=)
22
25
  end
23
26
 
24
27
  it "should operate in master run_mode" do
@@ -39,11 +42,11 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
39
42
 
40
43
  describe "during preinit" do
41
44
  before :each do
42
- @master.stubs(:trap)
45
+ allow(@master).to receive(:trap)
43
46
  end
44
47
 
45
48
  it "should catch INT" do
46
- @master.stubs(:trap).with { |arg,block| arg == :INT }
49
+ allow(@master).to receive(:trap) { |arg,block| arg == :INT }
47
50
 
48
51
  @master.preinit
49
52
  end
@@ -55,32 +58,32 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
55
58
  end
56
59
 
57
60
  it "should store argument value when calling handle_#{option}" do
58
- @master.options.expects(:[]=).with(option, 'arg')
61
+ expect(@master.options).to receive(:[]=).with(option, 'arg')
59
62
  @master.send("handle_#{option}".to_sym, 'arg')
60
63
  end
61
64
  end
62
65
 
63
66
  describe "when applying options" do
64
67
  before do
65
- @master.command_line.stubs(:args).returns([])
68
+ allow(@master.command_line).to receive(:args).and_return([])
66
69
  end
67
70
 
68
71
  it "should set the log destination with --logdest" do
69
- Puppet::Log.expects(:newdestination).with("console")
72
+ expect(Puppet::Log).to receive(:newdestination).with("console")
70
73
 
71
74
  @master.handle_logdest("console")
72
75
  end
73
76
 
74
77
  it "should put the setdest options to true" do
75
- @master.options.expects(:[]=).with(:setdest,true)
78
+ expect(@master.options).to receive(:[]=).with(:setdest,true)
76
79
 
77
80
  @master.handle_logdest("console")
78
81
  end
79
82
 
80
83
  it "should parse the log destination from ARGV" do
81
- @master.command_line.stubs(:args).returns(%w{--logdest /my/file})
84
+ allow(@master.command_line).to receive(:args).and_return(%w{--logdest /my/file})
82
85
 
83
- Puppet::Util::Log.expects(:newdestination).with("/my/file")
86
+ expect(Puppet::Util::Log).to receive(:newdestination).with("/my/file")
84
87
 
85
88
  @master.parse_options
86
89
  end
@@ -99,65 +102,64 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
99
102
 
100
103
  describe "during setup" do
101
104
  before :each do
102
- Puppet::Log.stubs(:newdestination)
103
- Puppet.stubs(:settraps)
104
- Puppet::SSL::CertificateAuthority.stubs(:instance)
105
- Puppet::SSL::CertificateAuthority.stubs(:ca?)
106
- Puppet.settings.stubs(:use)
105
+ allow(Puppet::Log).to receive(:newdestination)
106
+ allow(Puppet).to receive(:settraps)
107
+ allow(Puppet::SSL::CertificateAuthority).to receive(:instance)
108
+ allow(Puppet::SSL::CertificateAuthority).to receive(:ca?)
109
+ allow(Puppet.settings).to receive(:use)
107
110
 
108
- @master.options.stubs(:[]).with(any_parameters)
111
+ allow(@master.options).to receive(:[])
109
112
  end
110
113
 
111
114
  it "should abort stating that the master is not supported on Windows" do
112
- Puppet.features.stubs(:microsoft_windows?).returns(true)
115
+ allow(Puppet.features).to receive(:microsoft_windows?).and_return(true)
113
116
 
114
117
  expect { @master.setup }.to raise_error(Puppet::Error, /Puppet master is not supported on Microsoft Windows/)
115
118
  end
116
119
 
117
120
  describe "setting up logging" do
118
121
  it "sets the log level" do
119
- @master.expects(:set_log_level)
122
+ expect(@master).to receive(:set_log_level)
120
123
  @master.setup
121
124
  end
122
125
 
123
126
  describe "when the log destination is not explicitly configured" do
124
127
  before do
125
- @master.options.stubs(:[]).with(:setdest).returns false
128
+ allow(@master.options).to receive(:[]).with(:setdest).and_return(false)
126
129
  end
127
130
 
128
131
  it "should log to the console when --compile is given" do
129
- @master.options.stubs(:[]).with(:node).returns "default"
130
- Puppet::Util::Log.expects(:newdestination).with(:console)
132
+ allow(@master.options).to receive(:[]).with(:node).and_return("default")
133
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:console)
131
134
  @master.setup
132
135
  end
133
136
 
134
137
  it "should log to the console when the master is not daemonized or run with rack" do
135
- Puppet::Util::Log.expects(:newdestination).with(:console)
138
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:console)
136
139
  Puppet[:daemonize] = false
137
- @master.options.stubs(:[]).with(:rack).returns(false)
140
+ allow(@master.options).to receive(:[]).with(:rack).and_return(false)
138
141
  @master.setup
139
142
  end
140
143
 
141
144
  it "should log to syslog when the master is daemonized" do
142
-
143
- Puppet::Util::Log.expects(:newdestination).with(:console).never
144
- Puppet::Util::Log.expects(:newdestination).with(:syslog)
145
+ expect(Puppet::Util::Log).not_to receive(:newdestination).with(:console)
146
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:syslog)
145
147
  Puppet[:daemonize] = true
146
- @master.options.stubs(:[]).with(:rack).returns(false)
148
+ allow(@master.options).to receive(:[]).with(:rack).and_return(false)
147
149
  @master.setup
148
150
  end
149
151
 
150
152
  it "should log to syslog when the master is run with rack" do
151
- Puppet::Util::Log.expects(:newdestination).with(:console).never
152
- Puppet::Util::Log.expects(:newdestination).with(:syslog)
153
+ expect(Puppet::Util::Log).not_to receive(:newdestination).with(:console)
154
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:syslog)
153
155
  Puppet[:daemonize] = false
154
- @master.options.stubs(:[]).with(:rack).returns(true)
156
+ allow(@master.options).to receive(:[]).with(:rack).and_return(true)
155
157
  @master.setup
156
158
  end
157
159
  end
158
160
 
159
161
  it "sets the log destination using settings" do
160
- Puppet::Util::Log.expects(:newdestination).with("set_via_config")
162
+ expect(Puppet::Util::Log).to receive(:newdestination).with("set_via_config")
161
163
  Puppet[:logdest] = "set_via_config"
162
164
 
163
165
  @master.setup
@@ -165,26 +167,25 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
165
167
  end
166
168
 
167
169
  it "should print puppet config if asked to in Puppet config" do
168
- Puppet.settings.stubs(:print_configs?).returns(true)
169
- Puppet.settings.expects(:print_configs).returns(true)
170
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
171
+ expect(Puppet.settings).to receive(:print_configs).and_return(true)
170
172
  expect { @master.setup }.to exit_with 0
171
173
  end
172
174
 
173
175
  it "should exit after printing puppet config if asked to in Puppet config" do
174
- Puppet.settings.stubs(:print_configs?).returns(true)
176
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
175
177
  expect { @master.setup }.to exit_with 1
176
178
  end
177
179
 
178
180
  it "should tell Puppet.settings to use :main,:ssl,:master and :metrics category" do
179
- Puppet.settings.expects(:use).with(:main,:master,:ssl,:metrics)
181
+ expect(Puppet.settings).to receive(:use).with(:main,:master,:ssl,:metrics)
180
182
 
181
183
  @master.setup
182
184
  end
183
185
 
184
186
  describe "with no ca" do
185
-
186
187
  it "should set the ca_location to none" do
187
- Puppet::SSL::Host.expects(:ca_location=).with(:none)
188
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:none)
188
189
 
189
190
  @master.setup
190
191
  end
@@ -192,25 +193,24 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
192
193
  end
193
194
 
194
195
  describe "with a ca configured" do
195
-
196
196
  before :each do
197
- Puppet::SSL::CertificateAuthority.stubs(:ca?).returns(true)
197
+ allow(Puppet::SSL::CertificateAuthority).to receive(:ca?).and_return(true)
198
198
  end
199
199
 
200
200
  it "should set the ca_location to local" do
201
- Puppet::SSL::Host.expects(:ca_location=).with(:local)
201
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:local)
202
202
 
203
203
  @master.setup
204
204
  end
205
205
 
206
206
  it "should tell Puppet.settings to use :ca category" do
207
- Puppet.settings.expects(:use).with(:ca)
207
+ expect(Puppet.settings).to receive(:use).with(:ca)
208
208
 
209
209
  @master.setup
210
210
  end
211
211
 
212
212
  it "should instantiate the CertificateAuthority singleton" do
213
- Puppet::SSL::CertificateAuthority.expects(:instance)
213
+ expect(Puppet::SSL::CertificateAuthority).to receive(:instance)
214
214
 
215
215
  @master.setup
216
216
  end
@@ -244,55 +244,55 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
244
244
 
245
245
  it "should dispatch to compile if called with --compile" do
246
246
  @master.options[:node] = "foo"
247
- @master.expects(:compile)
247
+ expect(@master).to receive(:compile)
248
248
  @master.run_command
249
249
  end
250
250
 
251
251
  it "should dispatch to main otherwise" do
252
252
  @master.options[:node] = nil
253
253
 
254
- @master.expects(:main)
254
+ expect(@master).to receive(:main)
255
255
  @master.run_command
256
256
  end
257
257
 
258
258
  describe "the compile command" do
259
259
  before do
260
260
  Puppet[:manifest] = "site.pp"
261
- Puppet.stubs(:err)
262
- @master.stubs(:puts)
261
+ allow(Puppet).to receive(:err)
262
+ allow(@master).to receive(:puts)
263
263
  end
264
264
 
265
265
  it "should compile a catalog for the specified node" do
266
266
  @master.options[:node] = "foo"
267
- Puppet::Resource::Catalog.indirection.expects(:find).with("foo").returns Puppet::Resource::Catalog.new
267
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).with("foo").and_return(Puppet::Resource::Catalog.new)
268
268
 
269
269
  expect { @master.compile }.to exit_with 0
270
270
  end
271
271
 
272
272
  it "should convert the catalog to a pure-resource catalog and use 'JSON::pretty_generate' to pretty-print the catalog" do
273
273
  catalog = Puppet::Resource::Catalog.new
274
- JSON.stubs(:pretty_generate)
275
- Puppet::Resource::Catalog.indirection.expects(:find).returns catalog
274
+ allow(JSON).to receive(:pretty_generate)
275
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(catalog)
276
276
 
277
- catalog.expects(:to_resource).returns("rescat")
277
+ expect(catalog).to receive(:to_resource).and_return("rescat")
278
278
 
279
279
  @master.options[:node] = "foo"
280
- JSON.expects(:pretty_generate).with('rescat', :allow_nan => true, :max_nesting => false)
280
+ expect(JSON).to receive(:pretty_generate).with('rescat', :allow_nan => true, :max_nesting => false)
281
281
 
282
282
  expect { @master.compile }.to exit_with 0
283
283
  end
284
284
 
285
285
  it "should exit with error code 30 if no catalog can be found" do
286
286
  @master.options[:node] = "foo"
287
- Puppet::Resource::Catalog.indirection.expects(:find).returns nil
288
- Puppet.expects(:log_exception)
287
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(nil)
288
+ expect(Puppet).to receive(:log_exception)
289
289
  expect { @master.compile }.to exit_with 30
290
290
  end
291
291
 
292
292
  it "should exit with error code 30 if there's a failure" do
293
293
  @master.options[:node] = "foo"
294
- Puppet::Resource::Catalog.indirection.expects(:find).raises ArgumentError
295
- Puppet.expects(:log_exception)
294
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_raise(ArgumentError)
295
+ expect(Puppet).to receive(:log_exception)
296
296
  expect { @master.compile }.to exit_with 30
297
297
  end
298
298
  end
@@ -300,72 +300,72 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
300
300
  describe "the main command" do
301
301
  before :each do
302
302
  @master.preinit
303
- @server = stub_everything 'server'
304
- Puppet::Network::Server.stubs(:new).returns(@server)
305
- @app = stub_everything 'app'
306
- Puppet::SSL::Host.stubs(:localhost)
307
- Puppet::SSL::CertificateAuthority.stubs(:ca?)
308
- Process.stubs(:uid).returns(1000)
309
- Puppet.stubs(:service)
303
+ @server = double('server')
304
+ allow(Puppet::Network::Server).to receive(:new).and_return(@server)
305
+ @app = double('app')
306
+ allow(Puppet::SSL::Host).to receive(:localhost)
307
+ allow(Puppet::SSL::CertificateAuthority).to receive(:ca?)
308
+ allow(Process).to receive(:uid).and_return(1000)
309
+ allow(Puppet).to receive(:service)
310
310
  Puppet[:daemonize] = false
311
- Puppet.stubs(:notice)
312
- Puppet.stubs(:start)
313
- Puppet::Util.stubs(:chuser)
311
+ allow(Puppet).to receive(:notice)
312
+ allow(Puppet).to receive(:start)
313
+ allow(Puppet::Util).to receive(:chuser)
314
314
  end
315
315
 
316
316
  it "should create a Server" do
317
- Puppet::Network::Server.expects(:new)
317
+ expect(Puppet::Network::Server).to receive(:new)
318
318
 
319
319
  @master.main
320
320
  end
321
321
 
322
322
  it "should give the server to the daemon" do
323
- @daemon.expects(:server=).with(@server)
323
+ expect(@daemon).to receive(:server=).with(@server)
324
324
 
325
325
  @master.main
326
326
  end
327
327
 
328
328
  it "should generate a SSL cert for localhost" do
329
- Puppet::SSL::Host.expects(:localhost)
329
+ expect(Puppet::SSL::Host).to receive(:localhost)
330
330
 
331
331
  @master.main
332
332
  end
333
333
 
334
334
  it "should make sure to *only* hit the CA for data" do
335
- Puppet::SSL::CertificateAuthority.stubs(:ca?).returns(true)
335
+ allow(Puppet::SSL::CertificateAuthority).to receive(:ca?).and_return(true)
336
336
 
337
- Puppet::SSL::Host.expects(:ca_location=).with(:only)
337
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:only)
338
338
 
339
339
  @master.main
340
340
  end
341
341
 
342
342
  def a_user_type_for(username)
343
- user = mock 'user'
344
- Puppet::Type.type(:user).expects(:new).with { |args| args[:name] == username }.returns user
343
+ user = double('user')
344
+ expect(Puppet::Type.type(:user)).to receive(:new).with(hash_including(name: username)).and_return(user)
345
345
  user
346
346
  end
347
347
 
348
348
  context "user privileges" do
349
349
  it "should drop privileges if running as root and the puppet user exists" do
350
- Puppet.features.stubs(:root?).returns true
351
- a_user_type_for("puppet").expects(:exists?).returns true
350
+ allow(Puppet.features).to receive(:root?).and_return(true)
351
+ expect(a_user_type_for("puppet")).to receive(:exists?).and_return(true)
352
352
 
353
- Puppet::Util.expects(:chuser)
353
+ expect(Puppet::Util).to receive(:chuser)
354
354
 
355
355
  @master.main
356
356
  end
357
357
 
358
358
  it "should exit and log an error if running as root and the puppet user does not exist" do
359
- Puppet.features.stubs(:root?).returns true
360
- a_user_type_for("puppet").expects(:exists?).returns false
361
- Puppet.expects(:err).with('Could not change user to puppet. User does not exist and is required to continue.')
359
+ allow(Puppet.features).to receive(:root?).and_return(true)
360
+ expect(a_user_type_for("puppet")).to receive(:exists?).and_return(false)
361
+ expect(Puppet).to receive(:err).with('Could not change user to puppet. User does not exist and is required to continue.')
362
362
  expect { @master.main }.to exit_with 74
363
363
  end
364
364
  end
365
365
 
366
366
  it "should log a deprecation notice when running a WEBrick server" do
367
- Puppet.expects(:deprecation_warning).with("The WEBrick Puppet master server is deprecated and will be removed in a future release. Please use Puppet Server instead. See http://links.puppet.com/deprecate-rack-webrick-servers for more information.")
368
- Puppet.expects(:deprecation_warning).with("Accessing 'bindaddress' as a setting is deprecated.")
367
+ expect(Puppet).to receive(:deprecation_warning).with("The WEBrick Puppet master server is deprecated and will be removed in a future release. Please use Puppet Server instead. See http://links.puppet.com/deprecate-rack-webrick-servers for more information.")
368
+ expect(Puppet).to receive(:deprecation_warning).with("Accessing 'bindaddress' as a setting is deprecated.")
369
369
 
370
370
  @master.main
371
371
  end
@@ -373,13 +373,13 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
373
373
  it "should daemonize if needed" do
374
374
  Puppet[:daemonize] = true
375
375
 
376
- @daemon.expects(:daemonize)
376
+ expect(@daemon).to receive(:daemonize)
377
377
 
378
378
  @master.main
379
379
  end
380
380
 
381
381
  it "should start the service" do
382
- @daemon.expects(:start)
382
+ expect(@daemon).to receive(:start)
383
383
 
384
384
  @master.main
385
385
  end
@@ -387,13 +387,13 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
387
387
  describe "with --rack", :if => Puppet.features.rack? do
388
388
  before do
389
389
  require 'puppet/network/http/rack'
390
- Puppet::Network::HTTP::Rack.stubs(:new).returns(@app)
390
+ allow(Puppet::Network::HTTP::Rack).to receive(:new).and_return(@app)
391
391
 
392
- @master.options.stubs(:[]).with(:rack).returns(:true)
392
+ allow(@master.options).to receive(:[]).with(:rack).and_return(:true)
393
393
  end
394
394
 
395
395
  it "it should not start a daemon" do
396
- @daemon.expects(:start).never
396
+ expect(@daemon).not_to receive(:start)
397
397
 
398
398
  @master.main
399
399
  end
@@ -404,7 +404,7 @@ describe Puppet::Application::Master, :unless => Puppet.features.microsoft_windo
404
404
  end
405
405
 
406
406
  it "should log a deprecation notice" do
407
- Puppet.expects(:deprecation_warning).with("The Rack Puppet master server is deprecated and will be removed in a future release. Please use Puppet Server instead. See http://links.puppet.com/deprecate-rack-webrick-servers for more information.")
407
+ expect(Puppet).to receive(:deprecation_warning).with("The Rack Puppet master server is deprecated and will be removed in a future release. Please use Puppet Server instead. See http://links.puppet.com/deprecate-rack-webrick-servers for more information.")
408
408
 
409
409
  @master.main
410
410
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/application/resource'
@@ -6,9 +5,10 @@ require 'puppet_spec/character_encoding'
6
5
 
7
6
  describe Puppet::Application::Resource do
8
7
  include PuppetSpec::Files
8
+
9
9
  before :each do
10
10
  @resource_app = Puppet::Application[:resource]
11
- Puppet::Util::Log.stubs(:newdestination)
11
+ allow(Puppet::Util::Log).to receive(:newdestination)
12
12
  end
13
13
 
14
14
  describe "in preinit" do
@@ -21,17 +21,17 @@ describe Puppet::Application::Resource do
21
21
  describe "when handling options" do
22
22
  [:debug, :verbose, :edit].each do |option|
23
23
  it "should store argument value when calling handle_#{option}" do
24
- @resource_app.options.expects(:[]=).with(option, 'arg')
24
+ expect(@resource_app.options).to receive(:[]=).with(option, 'arg')
25
25
  @resource_app.send("handle_#{option}".to_sym, 'arg')
26
26
  end
27
27
  end
28
28
 
29
29
  it "should load a display all types with types option" do
30
- type1 = stub_everything 'type1', :name => :type1
31
- type2 = stub_everything 'type2', :name => :type2
32
- Puppet::Type.stubs(:loadall)
33
- Puppet::Type.stubs(:eachtype).multiple_yields(type1,type2)
34
- @resource_app.expects(:puts).with(['type1','type2'])
30
+ type1 = double('type1', :name => :type1)
31
+ type2 = double('type2', :name => :type2)
32
+ allow(Puppet::Type).to receive(:loadall)
33
+ allow(Puppet::Type).to receive(:eachtype).and_yield(type1).and_yield(type2)
34
+ expect(@resource_app).to receive(:puts).with(['type1','type2'])
35
35
  expect { @resource_app.handle_types(nil) }.to exit_with 0
36
36
  end
37
37
 
@@ -43,10 +43,10 @@ describe Puppet::Application::Resource do
43
43
  end
44
44
 
45
45
  it "should get a parameter in the printed data if extra_params are passed" do
46
- tty = stub("tty", :tty? => true )
46
+ tty = double("tty", :tty? => true )
47
47
  path = tmpfile('testfile')
48
48
  command_line = Puppet::Util::CommandLine.new("puppet", [ 'resource', 'file', path ], tty )
49
- @resource_app.stubs(:command_line).returns command_line
49
+ allow(@resource_app).to receive(:command_line).and_return(command_line)
50
50
 
51
51
  # provider is a parameter that should always be available
52
52
  @resource_app.extra_params = [ :provider ]
@@ -57,75 +57,70 @@ describe Puppet::Application::Resource do
57
57
 
58
58
  describe "during setup" do
59
59
  before :each do
60
- Puppet::Log.stubs(:newdestination)
60
+ allow(Puppet::Log).to receive(:newdestination)
61
61
  end
62
62
 
63
63
  it "should set console as the log destination" do
64
- Puppet::Log.expects(:newdestination).with(:console)
64
+ expect(Puppet::Log).to receive(:newdestination).with(:console)
65
65
 
66
66
  @resource_app.setup
67
67
  end
68
68
 
69
69
  it "should set log level to debug if --debug was passed" do
70
- @resource_app.options.stubs(:[]).with(:debug).returns(true)
70
+ allow(@resource_app.options).to receive(:[]).with(:debug).and_return(true)
71
71
  @resource_app.setup
72
72
  expect(Puppet::Log.level).to eq(:debug)
73
73
  end
74
74
 
75
75
  it "should set log level to info if --verbose was passed" do
76
- @resource_app.options.stubs(:[]).with(:debug).returns(false)
77
- @resource_app.options.stubs(:[]).with(:verbose).returns(true)
76
+ allow(@resource_app.options).to receive(:[]).with(:debug).and_return(false)
77
+ allow(@resource_app.options).to receive(:[]).with(:verbose).and_return(true)
78
78
  @resource_app.setup
79
79
  expect(Puppet::Log.level).to eq(:info)
80
80
  end
81
-
82
81
  end
83
82
 
84
83
  describe "when running" do
85
84
  before :each do
86
- @type = stub_everything 'type', :properties => []
87
- @resource_app.command_line.stubs(:args).returns(['mytype'])
88
- Puppet::Type.stubs(:type).returns(@type)
89
-
90
- @res = stub_everything "resource"
91
- @res.stubs(:prune_parameters).returns(@res)
92
- @res.stubs(:to_manifest).returns("resource")
93
- @report = stub_everything "report"
85
+ @type = double('type', :properties => [])
86
+ allow(@resource_app.command_line).to receive(:args).and_return(['mytype'])
87
+ allow(Puppet::Type).to receive(:type).and_return(@type)
94
88
 
95
- @resource_app.stubs(:puts)
89
+ @res = double("resource")
90
+ allow(@res).to receive(:prune_parameters).and_return(@res)
91
+ allow(@res).to receive(:to_manifest).and_return("resource")
92
+ @report = double("report")
96
93
 
97
- Puppet::Resource.indirection.stubs(:find ).never
98
- Puppet::Resource.indirection.stubs(:search).never
99
- Puppet::Resource.indirection.stubs(:save ).never
94
+ allow(@resource_app).to receive(:puts)
100
95
  end
101
96
 
102
97
  it "should raise an error if no type is given" do
103
- @resource_app.command_line.stubs(:args).returns([])
98
+ allow(@resource_app.command_line).to receive(:args).and_return([])
104
99
  expect { @resource_app.main }.to raise_error(RuntimeError, "You must specify the type to display")
105
100
  end
106
101
 
107
102
  it "should raise an error if the type is not found" do
108
- Puppet::Type.stubs(:type).returns(nil)
103
+ allow(Puppet::Type).to receive(:type).and_return(nil)
109
104
 
110
105
  expect { @resource_app.main }.to raise_error(RuntimeError, 'Could not find type mytype')
111
106
  end
112
107
 
113
108
  it "should search for resources" do
114
- Puppet::Resource.indirection.expects(:search).with('mytype/', {}).returns([])
109
+ expect(Puppet::Resource.indirection).to receive(:search).with('mytype/', {}).and_return([])
115
110
  @resource_app.main
116
111
  end
117
112
 
118
113
  it "should describe the given resource" do
119
- @resource_app.command_line.stubs(:args).returns(['type','name'])
120
- Puppet::Resource.indirection.expects(:find).with('type/name').returns(@res)
114
+ allow(@resource_app.command_line).to receive(:args).and_return(['type','name'])
115
+ expect(Puppet::Resource.indirection).to receive(:find).with('type/name').and_return(@res)
121
116
  @resource_app.main
122
117
  end
123
118
 
124
119
  it "should add given parameters to the object" do
125
- @resource_app.command_line.stubs(:args).returns(['type','name','param=temp'])
120
+ allow(@resource_app.command_line).to receive(:args).and_return(['type','name','param=temp'])
126
121
 
127
- Puppet::Resource.indirection.expects(:save).with(@res, 'type/name').returns([@res, @report])
128
- Puppet::Resource.expects(:new).with('type', 'name', :parameters => {'param' => 'temp'}).returns(@res)
122
+ expect(Puppet::Resource.indirection).to receive(:save).with(@res, 'type/name').and_return([@res, @report])
123
+ expect(Puppet::Resource).to receive(:new).with('type', 'name', :parameters => {'param' => 'temp'}).and_return(@res)
129
124
 
130
125
  @resource_app.main
131
126
  end
@@ -137,11 +132,11 @@ describe Puppet::Application::Resource do
137
132
  Puppet::Type.type(:user).new(:name => "\u2603".force_encoding(Encoding::UTF_8)).to_resource,
138
133
  Puppet::Type.type(:user).new(:name => "Jos\xE9".force_encoding(Encoding::ISO_8859_1)).to_resource
139
134
  ]
140
- Puppet::Resource.indirection.expects(:search).with('user/', {}).returns(resources)
141
- @resource_app.command_line.stubs(:args).returns(['user'])
135
+ expect(Puppet::Resource.indirection).to receive(:search).with('user/', {}).and_return(resources)
136
+ allow(@resource_app.command_line).to receive(:args).and_return(['user'])
142
137
 
143
138
  # All of our output should be in external encoding
144
- @resource_app.expects(:puts).with { |args| expect(args.encoding).to eq(Encoding::ISO_8859_1) }
139
+ expect(@resource_app).to receive(:puts) { |args| expect(args.encoding).to eq(Encoding::ISO_8859_1) }
145
140
 
146
141
  # This would raise an error if we weren't handling it
147
142
  PuppetSpec::CharacterEncoding.with_external_encoding(Encoding::ISO_8859_1) do
@@ -152,12 +147,12 @@ describe Puppet::Application::Resource do
152
147
 
153
148
  describe "when handling file type" do
154
149
  before :each do
155
- Facter.stubs(:loadfacts)
150
+ allow(Facter).to receive(:loadfacts)
156
151
  @resource_app.preinit
157
152
  end
158
153
 
159
154
  it "should raise an exception if no file specified" do
160
- @resource_app.command_line.stubs(:args).returns(['file'])
155
+ allow(@resource_app.command_line).to receive(:args).and_return(['file'])
161
156
 
162
157
  expect { @resource_app.main }.to raise_error(RuntimeError, /Listing all file instances is not supported/)
163
158
  end
@@ -165,12 +160,10 @@ describe Puppet::Application::Resource do
165
160
  it "should output a file resource when given a file path" do
166
161
  path = File.expand_path('/etc')
167
162
  res = Puppet::Type.type(:file).new(:path => path).to_resource
168
- Puppet::Resource.indirection.expects(:find).returns(res)
163
+ expect(Puppet::Resource.indirection).to receive(:find).and_return(res)
169
164
 
170
- @resource_app.command_line.stubs(:args).returns(['file', path])
171
- @resource_app.expects(:puts).with do |args|
172
- expect(args).to match(/file \{ '#{Regexp.escape(path)}'/m)
173
- end
165
+ allow(@resource_app.command_line).to receive(:args).and_return(['file', path])
166
+ expect(@resource_app).to receive(:puts).with(/file \{ '#{Regexp.escape(path)}'/m)
174
167
 
175
168
  @resource_app.main
176
169
  end
@@ -187,8 +180,9 @@ describe Puppet::Application::Resource do
187
180
  @instances ||= [new(:name => name)]
188
181
  end
189
182
  end
190
- @resource_app.command_line.stubs(:args).returns(['testing', 'hello'])
191
- @resource_app.expects(:puts).with { |args| expect(args).to eql("testing { 'hello':\n}") }
183
+
184
+ allow(@resource_app.command_line).to receive(:args).and_return(['testing', 'hello'])
185
+ expect(@resource_app).to receive(:puts).with("testing { 'hello':\n}")
192
186
  expect { @resource_app.main }.not_to raise_error
193
187
  end
194
188
  end