puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:stage) do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/file_bucket/dipper'
4
3
 
@@ -9,7 +8,7 @@ describe tidy do
9
8
 
10
9
  before do
11
10
  @basepath = make_absolute("/what/ever")
12
- Puppet.settings.stubs(:use)
11
+ allow(Puppet.settings).to receive(:use)
13
12
  end
14
13
 
15
14
  context "when normalizing 'path' on windows", :if => Puppet.features.microsoft_windows? do
@@ -21,8 +20,8 @@ describe tidy do
21
20
 
22
21
  it "should use :lstat when stating a file" do
23
22
  path = '/foo/bar'
24
- stat = mock 'stat'
25
- Puppet::FileSystem.expects(:lstat).with(path).returns stat
23
+ stat = double('stat')
24
+ expect(Puppet::FileSystem).to receive(:lstat).with(path).and_return(stat)
26
25
 
27
26
  resource = tidy.new :path => path, :age => "1d"
28
27
 
@@ -135,32 +134,32 @@ describe tidy do
135
134
  describe "when tidying" do
136
135
  before do
137
136
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
138
- @stat = stub 'stat', :ftype => "directory"
137
+ @stat = double('stat', :ftype => "directory")
139
138
  lstat_is(@basepath, @stat)
140
139
  end
141
140
 
142
141
  describe "and generating files" do
143
142
  it "should set the backup on the file if backup is set on the tidy instance" do
144
143
  @tidy[:backup] = "whatever"
145
- Puppet::Type.type(:file).expects(:new).with { |args| args[:backup] == "whatever" }
144
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(backup: "whatever"))
146
145
 
147
146
  @tidy.mkfile(@basepath)
148
147
  end
149
148
 
150
149
  it "should set the file's path to the tidy's path" do
151
- Puppet::Type.type(:file).expects(:new).with { |args| args[:path] == @basepath }
150
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(path: @basepath))
152
151
 
153
152
  @tidy.mkfile(@basepath)
154
153
  end
155
154
 
156
155
  it "should configure the file for deletion" do
157
- Puppet::Type.type(:file).expects(:new).with { |args| args[:ensure] == :absent }
156
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(ensure: :absent))
158
157
 
159
158
  @tidy.mkfile(@basepath)
160
159
  end
161
160
 
162
161
  it "should force deletion on the file" do
163
- Puppet::Type.type(:file).expects(:new).with { |args| args[:force] == true }
162
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(force: true))
164
163
 
165
164
  @tidy.mkfile(@basepath)
166
165
  end
@@ -174,16 +173,16 @@ describe tidy do
174
173
 
175
174
  describe "and recursion is not used" do
176
175
  it "should generate a file resource if the file should be tidied" do
177
- @tidy.expects(:tidy?).with(@basepath).returns true
176
+ expect(@tidy).to receive(:tidy?).with(@basepath).and_return(true)
178
177
  file = Puppet::Type.type(:file).new(:path => @basepath+"/eh")
179
- @tidy.expects(:mkfile).with(@basepath).returns file
178
+ expect(@tidy).to receive(:mkfile).with(@basepath).and_return(file)
180
179
 
181
180
  expect(@tidy.generate).to eq([file])
182
181
  end
183
182
 
184
183
  it "should do nothing if the file should not be tidied" do
185
- @tidy.expects(:tidy?).with(@basepath).returns false
186
- @tidy.expects(:mkfile).never
184
+ expect(@tidy).to receive(:tidy?).with(@basepath).and_return(false)
185
+ expect(@tidy).not_to receive(:mkfile)
187
186
 
188
187
  expect(@tidy.generate).to eq([])
189
188
  end
@@ -192,38 +191,38 @@ describe tidy do
192
191
  describe "and recursion is used" do
193
192
  before do
194
193
  @tidy[:recurse] = true
195
- Puppet::FileServing::Fileset.any_instance.stubs(:stat).returns mock("stat")
194
+ allow_any_instance_of(Puppet::FileServing::Fileset).to receive(:stat).and_return(double("stat"))
196
195
  @fileset = Puppet::FileServing::Fileset.new(@basepath)
197
- Puppet::FileServing::Fileset.stubs(:new).returns @fileset
196
+ allow(Puppet::FileServing::Fileset).to receive(:new).and_return(@fileset)
198
197
  end
199
198
 
200
199
  it "should use a Fileset for infinite recursion" do
201
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns @fileset
202
- @fileset.expects(:files).returns %w{. one two}
203
- @tidy.stubs(:tidy?).returns false
200
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(@fileset)
201
+ expect(@fileset).to receive(:files).and_return(%w{. one two})
202
+ allow(@tidy).to receive(:tidy?).and_return(false)
204
203
 
205
204
  @tidy.generate
206
205
  end
207
206
 
208
207
  it "should use a Fileset for limited recursion" do
209
208
  @tidy[:recurse] = 42
210
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true, :recurselimit => 42).returns @fileset
211
- @fileset.expects(:files).returns %w{. one two}
212
- @tidy.stubs(:tidy?).returns false
209
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true, :recurselimit => 42).and_return(@fileset)
210
+ expect(@fileset).to receive(:files).and_return(%w{. one two})
211
+ allow(@tidy).to receive(:tidy?).and_return(false)
213
212
 
214
213
  @tidy.generate
215
214
  end
216
215
 
217
216
  it "should generate a file resource for every file that should be tidied but not for files that should not be tidied" do
218
- @fileset.expects(:files).returns %w{. one two}
217
+ expect(@fileset).to receive(:files).and_return(%w{. one two})
219
218
 
220
- @tidy.expects(:tidy?).with(@basepath).returns true
221
- @tidy.expects(:tidy?).with(@basepath+"/one").returns true
222
- @tidy.expects(:tidy?).with(@basepath+"/two").returns false
219
+ expect(@tidy).to receive(:tidy?).with(@basepath).and_return(true)
220
+ expect(@tidy).to receive(:tidy?).with(@basepath+"/one").and_return(true)
221
+ expect(@tidy).to receive(:tidy?).with(@basepath+"/two").and_return(false)
223
222
 
224
223
  file = Puppet::Type.type(:file).new(:path => @basepath+"/eh")
225
- @tidy.expects(:mkfile).with(@basepath).returns file
226
- @tidy.expects(:mkfile).with(@basepath+"/one").returns file
224
+ expect(@tidy).to receive(:mkfile).with(@basepath).and_return(file)
225
+ expect(@tidy).to receive(:mkfile).with(@basepath+"/one").and_return(file)
227
226
 
228
227
  @tidy.generate
229
228
  end
@@ -234,7 +233,7 @@ describe tidy do
234
233
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath, :recurse => 1
235
234
  @tidy[:matches] = %w{*foo* *bar*}
236
235
 
237
- @stat = mock 'stat'
236
+ @stat = double('stat')
238
237
 
239
238
  @matcher = @tidy.parameter(:matches)
240
239
  end
@@ -258,7 +257,7 @@ describe tidy do
258
257
  describe "and determining whether a file is too old" do
259
258
  before do
260
259
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
261
- @stat = stub 'stat'
260
+ @stat = double('stat')
262
261
 
263
262
  @tidy[:age] = "1s"
264
263
  @tidy[:type] = "mtime"
@@ -267,19 +266,19 @@ describe tidy do
267
266
 
268
267
  it "should use the age type specified" do
269
268
  @tidy[:type] = :ctime
270
- @stat.expects(:ctime).returns(Time.now)
269
+ expect(@stat).to receive(:ctime).and_return(Time.now)
271
270
 
272
271
  @ager.tidy?(@basepath, @stat)
273
272
  end
274
273
 
275
274
  it "should return false if the file is more recent than the specified age" do
276
- @stat.expects(:mtime).returns(Time.now)
275
+ expect(@stat).to receive(:mtime).and_return(Time.now)
277
276
 
278
277
  expect(@ager).not_to be_tidy(@basepath, @stat)
279
278
  end
280
279
 
281
280
  it "should return true if the file is older than the specified age" do
282
- @stat.expects(:mtime).returns(Time.now - 10)
281
+ expect(@stat).to receive(:mtime).and_return(Time.now - 10)
283
282
 
284
283
  expect(@ager).to be_tidy(@basepath, @stat)
285
284
  end
@@ -288,26 +287,26 @@ describe tidy do
288
287
  describe "and determining whether a file is too large" do
289
288
  before do
290
289
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
291
- @stat = stub 'stat', :ftype => "file"
290
+ @stat = double('stat', :ftype => "file")
292
291
 
293
292
  @tidy[:size] = "1kb"
294
293
  @sizer = @tidy.parameter(:size)
295
294
  end
296
295
 
297
296
  it "should return false if the file is smaller than the specified size" do
298
- @stat.expects(:size).returns(4) # smaller than a kilobyte
297
+ expect(@stat).to receive(:size).and_return(4) # smaller than a kilobyte
299
298
 
300
299
  expect(@sizer).not_to be_tidy(@basepath, @stat)
301
300
  end
302
301
 
303
302
  it "should return true if the file is larger than the specified size" do
304
- @stat.expects(:size).returns(1500) # larger than a kilobyte
303
+ expect(@stat).to receive(:size).and_return(1500) # larger than a kilobyte
305
304
 
306
305
  expect(@sizer).to be_tidy(@basepath, @stat)
307
306
  end
308
307
 
309
308
  it "should return true if the file is equal to the specified size" do
310
- @stat.expects(:size).returns(1024)
309
+ expect(@stat).to receive(:size).and_return(1024)
311
310
 
312
311
  expect(@sizer).to be_tidy(@basepath, @stat)
313
312
  end
@@ -318,7 +317,7 @@ describe tidy do
318
317
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
319
318
  @catalog = Puppet::Resource::Catalog.new
320
319
  @tidy.catalog = @catalog
321
- @stat = stub 'stat', :ftype => "file"
320
+ @stat = double('stat', :ftype => "file")
322
321
  lstat_is(@basepath, @stat)
323
322
  end
324
323
 
@@ -343,7 +342,7 @@ describe tidy do
343
342
  end
344
343
 
345
344
  it "should not be tidied if it is a directory and rmdirs is set to false" do
346
- stat = mock 'stat', :ftype => "directory"
345
+ stat = double('stat', :ftype => "directory")
347
346
  lstat_is(@basepath, stat)
348
347
 
349
348
  expect(@tidy).not_to be_tidy(@basepath)
@@ -354,7 +353,7 @@ describe tidy do
354
353
  @tidy[:matches] = "globs"
355
354
 
356
355
  matches = @tidy.parameter(:matches)
357
- matches.expects(:tidy?).with(@basepath, @stat).returns false
356
+ expect(matches).to receive(:tidy?).with(@basepath, @stat).and_return(false)
358
357
  expect(@tidy).not_to be_tidy(@basepath)
359
358
  end
360
359
 
@@ -362,7 +361,7 @@ describe tidy do
362
361
  @tidy[:age] = "1d"
363
362
 
364
363
  ager = @tidy.parameter(:age)
365
- ager.expects(:tidy?).with(@basepath, @stat).returns false
364
+ expect(ager).to receive(:tidy?).with(@basepath, @stat).and_return(false)
366
365
  expect(@tidy).not_to be_tidy(@basepath)
367
366
  end
368
367
 
@@ -370,7 +369,7 @@ describe tidy do
370
369
  @tidy[:size] = "1b"
371
370
 
372
371
  sizer = @tidy.parameter(:size)
373
- sizer.expects(:tidy?).with(@basepath, @stat).returns false
372
+ expect(sizer).to receive(:tidy?).with(@basepath, @stat).and_return(false)
374
373
  expect(@tidy).not_to be_tidy(@basepath)
375
374
  end
376
375
 
@@ -378,8 +377,8 @@ describe tidy do
378
377
  @tidy[:size] = "1b"
379
378
  @tidy[:age] = "1d"
380
379
 
381
- @tidy.parameter(:size).stubs(:tidy?).returns true
382
- @tidy.parameter(:age).stubs(:tidy?).returns false
380
+ allow(@tidy.parameter(:size)).to receive(:tidy?).and_return(true)
381
+ allow(@tidy.parameter(:age)).to receive(:tidy?).and_return(false)
383
382
  expect(@tidy).to be_tidy(@basepath)
384
383
  end
385
384
 
@@ -387,8 +386,8 @@ describe tidy do
387
386
  @tidy[:size] = "1b"
388
387
  @tidy[:age] = "1d"
389
388
 
390
- @tidy.parameter(:size).stubs(:tidy?).returns false
391
- @tidy.parameter(:age).stubs(:tidy?).returns true
389
+ allow(@tidy.parameter(:size)).to receive(:tidy?).and_return(false)
390
+ allow(@tidy.parameter(:age)).to receive(:tidy?).and_return(true)
392
391
  expect(@tidy).to be_tidy(@basepath)
393
392
  end
394
393
 
@@ -400,10 +399,10 @@ describe tidy do
400
399
  @tidy[:recurse] = true
401
400
  @tidy[:rmdirs] = true
402
401
  fileset = Puppet::FileServing::Fileset.new(@basepath)
403
- Puppet::FileServing::Fileset.expects(:new).returns fileset
404
- fileset.expects(:files).returns %w{. one one/two}
402
+ expect(Puppet::FileServing::Fileset).to receive(:new).and_return(fileset)
403
+ expect(fileset).to receive(:files).and_return(%w{. one one/two})
405
404
 
406
- @tidy.stubs(:tidy?).returns true
405
+ allow(@tidy).to receive(:tidy?).and_return(true)
407
406
 
408
407
  expect(@tidy.generate.collect { |r| r[:path] }).to eq([@basepath+"/one/two", @basepath+"/one", @basepath])
409
408
  end
@@ -412,10 +411,10 @@ describe tidy do
412
411
  it "should configure directories to require their contained files if rmdirs is enabled, so the files will be deleted first" do
413
412
  @tidy[:recurse] = true
414
413
  @tidy[:rmdirs] = true
415
- fileset = mock 'fileset'
416
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns fileset
417
- fileset.expects(:files).returns %w{. one two one/subone two/subtwo one/subone/ssone}
418
- @tidy.stubs(:tidy?).returns true
414
+ fileset = double('fileset')
415
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(fileset)
416
+ expect(fileset).to receive(:files).and_return(%w{. one two one/subone two/subtwo one/subone/ssone})
417
+ allow(@tidy).to receive(:tidy?).and_return(true)
419
418
 
420
419
  result = @tidy.generate.inject({}) { |hash, res| hash[res[:path]] = res; hash }
421
420
  {
@@ -434,10 +433,10 @@ describe tidy do
434
433
  it "should configure directories to require their contained files in sorted order" do
435
434
  @tidy[:recurse] = true
436
435
  @tidy[:rmdirs] = true
437
- fileset = mock 'fileset'
438
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns fileset
439
- fileset.expects(:files).returns %w{. a a/2 a/1 a/3}
440
- @tidy.stubs(:tidy?).returns true
436
+ fileset = double('fileset')
437
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(fileset)
438
+ expect(fileset).to receive(:files).and_return(%w{. a a/2 a/1 a/3})
439
+ allow(@tidy).to receive(:tidy?).and_return(true)
441
440
 
442
441
  result = @tidy.generate.inject({}) { |hash, res| hash[res[:path]] = res; hash }
443
442
  expect(result[@basepath + '/a'][:require].collect{|a| a.name[('File//a/' + @basepath).length..-1]}.join()).to eq('321')
@@ -447,10 +446,10 @@ describe tidy do
447
446
  @tidy[:recurse] = true
448
447
  @tidy[:noop] = true
449
448
 
450
- fileset = mock 'fileset'
451
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns fileset
452
- fileset.expects(:files).returns %w{. a a/2 a/1 a/3}
453
- @tidy.stubs(:tidy?).returns true
449
+ fileset = double('fileset')
450
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(fileset)
451
+ expect(fileset).to receive(:files).and_return(%w{. a a/2 a/1 a/3})
452
+ allow(@tidy).to receive(:tidy?).and_return(true)
454
453
 
455
454
  result = @tidy.generate.inject({}) { |hash, res| hash[res[:path]] = res; hash }
456
455
 
@@ -459,10 +458,10 @@ describe tidy do
459
458
  end
460
459
 
461
460
  def lstat_is(path, stat)
462
- Puppet::FileSystem.stubs(:lstat).with(path).returns(stat)
461
+ allow(Puppet::FileSystem).to receive(:lstat).with(path).and_return(stat)
463
462
  end
464
463
 
465
464
  def lstat_raises(path, error_class)
466
- Puppet::FileSystem.expects(:lstat).with(path).raises Errno::ENOENT
465
+ expect(Puppet::FileSystem).to receive(:lstat).with(path).and_raise(Errno::ENOENT)
467
466
  end
468
467
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  # encoding: UTF-8
3
2
  require 'spec_helper'
4
3
 
@@ -13,7 +12,7 @@ describe Puppet::Type.type(:user) do
13
12
  def flush; end
14
13
  def self.instances; []; end
15
14
  end
16
- described_class.stubs(:defaultprovider).returns @provider_class
15
+ allow(described_class).to receive(:defaultprovider).and_return(@provider_class)
17
16
  end
18
17
 
19
18
  it "should be able to create an instance" do
@@ -65,12 +64,12 @@ describe Puppet::Type.type(:user) do
65
64
  end
66
65
 
67
66
  it "cannot be set to true for a provider that does not manage homedirs" do
68
- provider.class.stubs(:manages_homedir?).returns false
67
+ allow(provider.class).to receive(:manages_homedir?).and_return(false)
69
68
  expect { instance[:managehome] = 'yes' }.to raise_error(Puppet::Error, /can not manage home directories/)
70
69
  end
71
70
 
72
71
  it "can be set to true for a provider that does manage homedirs" do
73
- provider.class.stubs(:manages_homedir?).returns true
72
+ allow(provider.class).to receive(:manages_homedir?).and_return(true)
74
73
  instance[:managehome] = 'yes'
75
74
  end
76
75
  end
@@ -127,8 +126,8 @@ describe Puppet::Type.type(:user) do
127
126
  end
128
127
 
129
128
  it "should set all values to :absent if the user is absent" do
130
- @user.property(:ensure).expects(:retrieve).returns :absent
131
- @user.property(:uid).expects(:retrieve).never
129
+ expect(@user.property(:ensure)).to receive(:retrieve).and_return(:absent)
130
+ expect(@user.property(:uid)).not_to receive(:retrieve)
132
131
  expect(@user.retrieve[@user.property(:uid)]).to eq(:absent)
133
132
  end
134
133
 
@@ -148,13 +147,13 @@ describe Puppet::Type.type(:user) do
148
147
 
149
148
  it "should call :create on the provider when asked to sync to the :present state" do
150
149
  @provider = @provider_class.new(:name => 'foo', :ensure => :absent)
151
- @provider.expects(:create)
150
+ expect(@provider).to receive(:create)
152
151
  described_class.new(:name => 'foo', :ensure => :present, :provider => @provider).parameter(:ensure).sync
153
152
  end
154
153
 
155
154
  it "should call :delete on the provider when asked to sync to the :absent state" do
156
155
  @provider = @provider_class.new(:name => 'foo', :ensure => :present)
157
- @provider.expects(:delete)
156
+ expect(@provider).to receive(:delete)
158
157
  described_class.new(:name => 'foo', :ensure => :absent, :provider => @provider).parameter(:ensure).sync
159
158
  end
160
159
 
@@ -212,27 +211,27 @@ describe Puppet::Type.type(:user) do
212
211
  end
213
212
 
214
213
  it "should return true if any of the specified groups are equal to the current integer" do
215
- Puppet::Util.expects(:gid).with("foo").returns 300
216
- Puppet::Util.expects(:gid).with("bar").returns 500
214
+ expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
215
+ expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
217
216
  expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to be_safe_insync(500)
218
217
  end
219
218
 
220
219
  it "should return false if none of the specified groups are equal to the current integer" do
221
- Puppet::Util.expects(:gid).with("foo").returns 300
222
- Puppet::Util.expects(:gid).with("bar").returns 500
220
+ expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
221
+ expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
223
222
  expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to_not be_safe_insync(700)
224
223
  end
225
224
  end
226
225
 
227
226
  describe "when syncing" do
228
227
  it "should use the first found, specified group as the desired value and send it to the provider" do
229
- Puppet::Util.expects(:gid).with("foo").returns nil
230
- Puppet::Util.expects(:gid).with("bar").returns 500
228
+ expect(Puppet::Util).to receive(:gid).with("foo").and_return(nil)
229
+ expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
231
230
 
232
231
  @provider = @provider_class.new(:name => 'foo')
233
232
  resource = described_class.new(:name => 'foo', :provider => @provider, :gid => [ 'foo', 'bar' ])
234
233
 
235
- @provider.expects(:gid=).with 500
234
+ expect(@provider).to receive(:gid=).with(500)
236
235
  resource.parameter(:gid).sync
237
236
  end
238
237
  end
@@ -257,7 +256,6 @@ describe Puppet::Type.type(:user) do
257
256
  end
258
257
 
259
258
  describe "when testing is in sync" do
260
-
261
259
  before :each do
262
260
  # the useradd provider uses a single string to represent groups and so does Puppet::Property::List when converting to should values
263
261
  @provider = @provider_class.new(:name => 'foo', :groups => 'a,b,e,f')
@@ -366,7 +364,7 @@ describe Puppet::Type.type(:user) do
366
364
  # useradd subclasses nameservice and thus inherits #comments_insync?
367
365
  user = described_class.new(:name => 'foo', :comment => @value, :provider => :useradd)
368
366
  comment_property = user.properties.find {|p| p.name == :comment}
369
- user.provider.expects(:comments_insync?)
367
+ expect(user.provider).to receive(:comments_insync?)
370
368
  comment_property.insync?('bar')
371
369
  end
372
370
 
@@ -374,6 +372,7 @@ describe Puppet::Type.type(:user) do
374
372
  let(:is) { "\u2603" }
375
373
  let(:should) { "\u06FF" }
376
374
  let(:comment_property) { @user.properties.find { |p| p.name == :comment } }
375
+
377
376
  context "given is and should strings with incompatible encoding" do
378
377
  it "should return a formatted string" do
379
378
  is.force_encoding(Encoding::ASCII_8BIT)
@@ -409,7 +408,7 @@ describe Puppet::Type.type(:user) do
409
408
  Puppet::Resource::Catalog.new :testing do |conf|
410
409
  [testuser, testrole].each { |resource| conf.add_resource resource }
411
410
  end
412
- Puppet::Type::User::ProviderDirectoryservice.stubs(:get_macosx_version_major).returns "10.5"
411
+ allow(Puppet::Type::User::ProviderDirectoryservice).to receive(:get_macosx_version_major).and_return("10.5")
413
412
 
414
413
  rel = testuser.autorequire[0]
415
414
  expect(rel.source.ref).to eq(testrole.ref)
@@ -431,15 +430,15 @@ describe Puppet::Type.type(:user) do
431
430
  def check_valid_shell; end
432
431
  end
433
432
 
434
- described_class.stubs(:defaultprovider).returns @shell_provider_class
433
+ allow(described_class).to receive(:defaultprovider).and_return(@shell_provider_class)
435
434
  end
436
435
 
437
436
  it "should call :check_valid_shell on the provider when changing shell value" do
438
437
  @provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :present)
439
- @provider.expects(:check_valid_shell)
438
+ expect(@provider).to receive(:check_valid_shell)
440
439
  resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
441
- Puppet::Util::Storage.stubs(:load)
442
- Puppet::Util::Storage.stubs(:store)
440
+ allow(Puppet::Util::Storage).to receive(:load)
441
+ allow(Puppet::Util::Storage).to receive(:store)
443
442
  catalog = Puppet::Resource::Catalog.new
444
443
  catalog.add_resource resource
445
444
  catalog.apply
@@ -447,10 +446,10 @@ describe Puppet::Type.type(:user) do
447
446
 
448
447
  it "should call :check_valid_shell on the provider when changing ensure from present to absent" do
449
448
  @provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :absent)
450
- @provider.expects(:check_valid_shell)
449
+ expect(@provider).to receive(:check_valid_shell)
451
450
  resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
452
- Puppet::Util::Storage.stubs(:load)
453
- Puppet::Util::Storage.stubs(:store)
451
+ allow(Puppet::Util::Storage).to receive(:load)
452
+ allow(Puppet::Util::Storage).to receive(:store)
454
453
  catalog = Puppet::Resource::Catalog.new
455
454
  catalog.add_resource resource
456
455
  catalog.apply
@@ -468,12 +467,15 @@ describe Puppet::Type.type(:user) do
468
467
  it "should accept true" do
469
468
  described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => true)
470
469
  end
470
+
471
471
  it "should accept the ~ wildcard" do
472
472
  described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => "~/keys")
473
473
  end
474
+
474
475
  it "should accept the %h wildcard" do
475
476
  described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => "%h/keys")
476
477
  end
478
+
477
479
  it "raises when given a relative path" do
478
480
  expect {
479
481
  described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => "keys")
@@ -487,11 +489,13 @@ describe Puppet::Type.type(:user) do
487
489
  described_class.new(:name => "a", :purge_ssh_keys => true)
488
490
  }.to raise_error(Puppet::Error, /purge_ssh_keys can only be true for users with a defined home directory/)
489
491
  end
492
+
490
493
  it "should not accept the ~ wildcard" do
491
494
  expect {
492
495
  described_class.new(:name => "a", :purge_ssh_keys => "~/keys")
493
496
  }.to raise_error(Puppet::Error, /meta character ~ or %h only allowed for users with a defined home directory/)
494
497
  end
498
+
495
499
  it "should not accept the %h wildcard" do
496
500
  expect {
497
501
  described_class.new(:name => "a", :purge_ssh_keys => "%h/keys")
@@ -503,18 +507,21 @@ describe Puppet::Type.type(:user) do
503
507
  let(:paths) do
504
508
  [ "/dev/null", "/tmp/keyfile" ].map { |path| File.expand_path(path) }
505
509
  end
510
+
506
511
  subject do
507
512
  res = described_class.new(:name => "test", :purge_ssh_keys => paths)
508
513
  res.catalog = Puppet::Resource::Catalog.new
509
514
  res
510
515
  end
516
+
511
517
  it "should not just return from generate" do
512
- subject.expects :find_unmanaged_keys
518
+ expect(subject).to receive(:find_unmanaged_keys)
513
519
  subject.generate
514
520
  end
521
+
515
522
  it "should check each keyfile for readability" do
516
523
  paths.each do |path|
517
- File.expects(:readable?).with(path)
524
+ expect(File).to receive(:readable?).with(path)
518
525
  end
519
526
  subject.generate
520
527
  end
@@ -526,27 +533,34 @@ describe Puppet::Type.type(:user) do
526
533
  res.catalog = Puppet::Resource::Catalog.new
527
534
  res
528
535
  end
536
+
529
537
  context "when purging is disabled" do
530
538
  let(:purge_param) { false }
539
+
531
540
  its(:generate) { should be_empty }
532
541
  end
542
+
533
543
  context "when purging is enabled" do
534
544
  let(:purge_param) { my_fixture('authorized_keys') }
535
545
  let(:resources) { subject.generate }
546
+
536
547
  it "should contain a resource for each key" do
537
548
  names = resources.collect { |res| res.name }
538
549
  expect(names).to include("key1 name")
539
550
  expect(names).to include("keyname2")
540
551
  end
552
+
541
553
  it "should not include keys in comment lines" do
542
554
  names = resources.collect { |res| res.name }
543
555
  expect(names).not_to include("keyname3")
544
556
  end
557
+
545
558
  it "should generate names for unnamed keys" do
546
559
  names = resources.collect { |res| res.name }
547
560
  fixture_path = File.join(my_fixture_dir, 'authorized_keys')
548
561
  expect(names).to include("#{fixture_path}:unnamed-1")
549
562
  end
563
+
550
564
  it "should each have a value for the user property" do
551
565
  expect(resources.map { |res|
552
566
  res[:user]