puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of puppet might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/Gemfile +0 -5
- data/Gemfile.lock +11 -11
- data/lib/puppet/application/filebucket.rb +4 -0
- data/lib/puppet/configurer.rb +9 -3
- data/lib/puppet/indirector/request.rb +26 -15
- data/lib/puppet/indirector/rest.rb +16 -7
- data/lib/puppet/network/http/connection.rb +15 -7
- data/lib/puppet/transaction/event_manager.rb +1 -5
- data/lib/puppet/type/file/source.rb +0 -1
- data/lib/puppet/util/http_proxy.rb +3 -2
- data/lib/puppet/version.rb +1 -1
- data/locales/puppet.pot +108 -36
- data/man/man5/puppet.conf.5 +2 -2
- data/man/man8/puppet-agent.8 +1 -1
- data/man/man8/puppet-apply.8 +1 -1
- data/man/man8/puppet-ca.8 +1 -1
- data/man/man8/puppet-catalog.8 +1 -1
- data/man/man8/puppet-cert.8 +1 -1
- data/man/man8/puppet-certificate.8 +1 -1
- data/man/man8/puppet-certificate_request.8 +1 -1
- data/man/man8/puppet-certificate_revocation_list.8 +1 -1
- data/man/man8/puppet-config.8 +1 -1
- data/man/man8/puppet-describe.8 +1 -1
- data/man/man8/puppet-device.8 +1 -1
- data/man/man8/puppet-doc.8 +1 -1
- data/man/man8/puppet-epp.8 +1 -1
- data/man/man8/puppet-facts.8 +1 -1
- data/man/man8/puppet-filebucket.8 +1 -1
- data/man/man8/puppet-generate.8 +1 -1
- data/man/man8/puppet-help.8 +1 -1
- data/man/man8/puppet-key.8 +1 -1
- data/man/man8/puppet-lookup.8 +1 -1
- data/man/man8/puppet-man.8 +1 -1
- data/man/man8/puppet-master.8 +1 -1
- data/man/man8/puppet-module.8 +1 -1
- data/man/man8/puppet-node.8 +1 -1
- data/man/man8/puppet-parser.8 +1 -1
- data/man/man8/puppet-plugin.8 +1 -1
- data/man/man8/puppet-report.8 +1 -1
- data/man/man8/puppet-resource.8 +1 -1
- data/man/man8/puppet-script.8 +1 -1
- data/man/man8/puppet-status.8 +1 -1
- data/man/man8/puppet.8 +2 -2
- data/spec/integration/agent/logging_spec.rb +5 -7
- data/spec/integration/application/apply_spec.rb +28 -26
- data/spec/integration/application/doc_spec.rb +1 -2
- data/spec/integration/application/lookup_spec.rb +5 -5
- data/spec/integration/configurer_spec.rb +5 -6
- data/spec/integration/defaults_spec.rb +5 -6
- data/spec/integration/directory_environments_spec.rb +1 -1
- data/spec/integration/faces/ca_spec.rb +2 -3
- data/spec/integration/faces/config_spec.rb +3 -4
- data/spec/integration/faces/documentation_spec.rb +0 -1
- data/spec/integration/faces/plugin_spec.rb +1 -1
- data/spec/integration/file_bucket/file_spec.rb +3 -5
- data/spec/integration/file_serving/content_spec.rb +0 -1
- data/spec/integration/file_serving/fileset_spec.rb +0 -1
- data/spec/integration/file_serving/metadata_spec.rb +0 -1
- data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
- data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
- data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
- data/spec/integration/indirector/facts/facter_spec.rb +5 -5
- data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
- data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
- data/spec/integration/indirector/node/ldap_spec.rb +2 -3
- data/spec/integration/network/authconfig_spec.rb +23 -24
- data/spec/integration/network/formats_spec.rb +0 -1
- data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
- data/spec/integration/node/environment_spec.rb +0 -1
- data/spec/integration/node/facts_spec.rb +9 -10
- data/spec/integration/node_spec.rb +6 -7
- data/spec/integration/parser/catalog_spec.rb +4 -2
- data/spec/integration/parser/collection_spec.rb +1 -2
- data/spec/integration/parser/compiler_spec.rb +6 -6
- data/spec/integration/parser/scope_spec.rb +1 -1
- data/spec/integration/parser/undef_param_spec.rb +1 -1
- data/spec/integration/provider/cron/crontab_spec.rb +8 -10
- data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
- data/spec/integration/provider/mount_spec.rb +9 -9
- data/spec/integration/provider/service/init_spec.rb +4 -5
- data/spec/integration/provider/service/systemd_spec.rb +0 -2
- data/spec/integration/provider/service/windows_spec.rb +1 -2
- data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
- data/spec/integration/provider/sshkey_spec.rb +6 -12
- data/spec/integration/provider/yumrepo_spec.rb +8 -12
- data/spec/integration/reference/providers_spec.rb +0 -1
- data/spec/integration/reports_spec.rb +1 -2
- data/spec/integration/resource/catalog_spec.rb +14 -17
- data/spec/integration/resource/type_collection_spec.rb +4 -5
- data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
- data/spec/integration/ssl/certificate_request_spec.rb +0 -1
- data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
- data/spec/integration/ssl/host_spec.rb +0 -1
- data/spec/integration/ssl/key_spec.rb +0 -1
- data/spec/integration/test/test_helper_spec.rb +1 -2
- data/spec/integration/transaction/report_spec.rb +6 -11
- data/spec/integration/transaction_spec.rb +18 -19
- data/spec/integration/type/exec_spec.rb +0 -1
- data/spec/integration/type/file_spec.rb +13 -14
- data/spec/integration/type/nagios_spec.rb +3 -5
- data/spec/integration/type/package_spec.rb +19 -23
- data/spec/integration/type/tidy_spec.rb +1 -2
- data/spec/integration/type/user_spec.rb +0 -1
- data/spec/integration/type_spec.rb +0 -1
- data/spec/integration/util/autoload_spec.rb +1 -2
- data/spec/integration/util/rdoc/parser_spec.rb +0 -1
- data/spec/integration/util/settings_spec.rb +0 -1
- data/spec/integration/util/windows/adsi_spec.rb +3 -5
- data/spec/integration/util/windows/principal_spec.rb +0 -1
- data/spec/integration/util/windows/process_spec.rb +4 -6
- data/spec/integration/util/windows/registry_spec.rb +41 -51
- data/spec/integration/util/windows/security_spec.rb +2 -4
- data/spec/integration/util/windows/user_spec.rb +18 -20
- data/spec/integration/util_spec.rb +4 -7
- data/spec/lib/puppet_spec/compiler.rb +1 -1
- data/spec/lib/puppet_spec/files.rb +0 -1
- data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
- data/spec/lib/puppet_spec/scope.rb +1 -2
- data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
- data/spec/shared_behaviours/file_server_terminus.rb +8 -9
- data/spec/shared_behaviours/file_serving.rb +6 -8
- data/spec/shared_behaviours/file_serving_model.rb +4 -6
- data/spec/shared_behaviours/hiera_indirections.rb +3 -4
- data/spec/shared_behaviours/iterative_functions.rb +0 -1
- data/spec/shared_behaviours/memory_terminus.rb +2 -2
- data/spec/shared_examples/rhel_package_provider.rb +112 -70
- data/spec/spec_helper.rb +11 -2
- data/spec/unit/agent/disabler_spec.rb +4 -5
- data/spec/unit/agent/locker_spec.rb +12 -13
- data/spec/unit/agent_spec.rb +80 -85
- data/spec/unit/application/agent_spec.rb +88 -93
- data/spec/unit/application/apply_spec.rb +78 -79
- data/spec/unit/application/cert_spec.rb +42 -49
- data/spec/unit/application/certificate_spec.rb +2 -3
- data/spec/unit/application/config_spec.rb +0 -1
- data/spec/unit/application/describe_spec.rb +6 -7
- data/spec/unit/application/device_spec.rb +175 -184
- data/spec/unit/application/doc_spec.rb +44 -46
- data/spec/unit/application/face_base_spec.rb +61 -62
- data/spec/unit/application/facts_spec.rb +3 -4
- data/spec/unit/application/filebucket_spec.rb +66 -74
- data/spec/unit/application/indirection_base_spec.rb +8 -6
- data/spec/unit/application/lookup_spec.rb +26 -26
- data/spec/unit/application/master_spec.rb +95 -95
- data/spec/unit/application/resource_spec.rb +42 -48
- data/spec/unit/application_spec.rb +74 -84
- data/spec/unit/capability_spec.rb +9 -6
- data/spec/unit/configurer/downloader_spec.rb +20 -21
- data/spec/unit/configurer/fact_handler_spec.rb +2 -3
- data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
- data/spec/unit/configurer_spec.rb +190 -193
- data/spec/unit/confine/exists_spec.rb +17 -15
- data/spec/unit/confine/false_spec.rb +5 -6
- data/spec/unit/confine/feature_spec.rb +7 -5
- data/spec/unit/confine/true_spec.rb +5 -6
- data/spec/unit/confine/variable_spec.rb +14 -15
- data/spec/unit/confine_collection_spec.rb +28 -29
- data/spec/unit/confine_spec.rb +13 -14
- data/spec/unit/confiner_spec.rb +10 -11
- data/spec/unit/context/trusted_information_spec.rb +1 -1
- data/spec/unit/daemon_spec.rb +34 -35
- data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
- data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
- data/spec/unit/datatypes_spec.rb +3 -4
- data/spec/unit/defaults_spec.rb +17 -12
- data/spec/unit/environments_spec.rb +7 -7
- data/spec/unit/etc_spec.rb +30 -32
- data/spec/unit/external/pson_spec.rb +0 -1
- data/spec/unit/face/ca_spec.rb +0 -1
- data/spec/unit/face/catalog_spec.rb +0 -1
- data/spec/unit/face/certificate_request_spec.rb +0 -1
- data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
- data/spec/unit/face/certificate_spec.rb +7 -10
- data/spec/unit/face/config_spec.rb +31 -35
- data/spec/unit/face/epp_face_spec.rb +3 -4
- data/spec/unit/face/facts_spec.rb +5 -6
- data/spec/unit/face/generate_spec.rb +4 -5
- data/spec/unit/face/help_spec.rb +7 -8
- data/spec/unit/face/key_spec.rb +0 -1
- data/spec/unit/face/man_spec.rb +1 -2
- data/spec/unit/face/module/build_spec.rb +17 -17
- data/spec/unit/face/module/install_spec.rb +3 -5
- data/spec/unit/face/module/list_spec.rb +2 -12
- data/spec/unit/face/module/search_spec.rb +11 -9
- data/spec/unit/face/module/uninstall_spec.rb +4 -8
- data/spec/unit/face/node_spec.rb +33 -34
- data/spec/unit/face/parser_spec.rb +3 -3
- data/spec/unit/face/plugin_spec.rb +36 -9
- data/spec/unit/face/status_spec.rb +0 -1
- data/spec/unit/file_bucket/dipper_spec.rb +24 -20
- data/spec/unit/file_bucket/file_spec.rb +0 -2
- data/spec/unit/file_serving/base_spec.rb +16 -17
- data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
- data/spec/unit/file_serving/configuration_spec.rb +63 -66
- data/spec/unit/file_serving/content_spec.rb +10 -11
- data/spec/unit/file_serving/fileset_spec.rb +63 -58
- data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
- data/spec/unit/file_serving/metadata_spec.rb +36 -36
- data/spec/unit/file_serving/mount/file_spec.rb +31 -32
- data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
- data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
- data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
- data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
- data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
- data/spec/unit/file_serving/mount_spec.rb +0 -1
- data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
- data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
- data/spec/unit/file_system/uniquefile_spec.rb +4 -4
- data/spec/unit/file_system_spec.rb +2 -2
- data/spec/unit/forge/errors_spec.rb +1 -1
- data/spec/unit/forge/forge_spec.rb +13 -14
- data/spec/unit/forge/module_release_spec.rb +18 -18
- data/spec/unit/forge/repository_spec.rb +29 -30
- data/spec/unit/forge_spec.rb +15 -11
- data/spec/unit/functions/binary_file_spec.rb +3 -3
- data/spec/unit/functions/contain_spec.rb +0 -2
- data/spec/unit/functions/defined_spec.rb +0 -1
- data/spec/unit/functions/epp_spec.rb +2 -2
- data/spec/unit/functions/find_file_spec.rb +7 -7
- data/spec/unit/functions/include_spec.rb +0 -4
- data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
- data/spec/unit/functions/lookup_spec.rb +1 -2
- data/spec/unit/functions/module_directory_spec.rb +12 -12
- data/spec/unit/functions/require_spec.rb +0 -3
- data/spec/unit/functions/shared.rb +5 -8
- data/spec/unit/functions/versioncmp_spec.rb +1 -2
- data/spec/unit/functions4_spec.rb +7 -8
- data/spec/unit/gettext/config_spec.rb +4 -4
- data/spec/unit/gettext/module_loading_spec.rb +7 -7
- data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
- data/spec/unit/graph/relationship_graph_spec.rb +1 -2
- data/spec/unit/graph/simple_graph_spec.rb +8 -9
- data/spec/unit/hiera_puppet_spec.rb +20 -20
- data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
- data/spec/unit/indirector/catalog/json_spec.rb +1 -2
- data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
- data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
- data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
- data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
- data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
- data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
- data/spec/unit/indirector/certificate/file_spec.rb +2 -3
- data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
- data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
- data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
- data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
- data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
- data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
- data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
- data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
- data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
- data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
- data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
- data/spec/unit/indirector/code_spec.rb +5 -6
- data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
- data/spec/unit/indirector/envelope_spec.rb +1 -2
- data/spec/unit/indirector/exec_spec.rb +15 -14
- data/spec/unit/indirector/face_spec.rb +9 -9
- data/spec/unit/indirector/facts/facter_spec.rb +37 -43
- data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
- data/spec/unit/indirector/facts/rest_spec.rb +7 -8
- data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
- data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
- data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
- data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
- data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
- data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
- data/spec/unit/indirector/file_content/file_spec.rb +0 -1
- data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
- data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
- data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
- data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
- data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
- data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
- data/spec/unit/indirector/file_server_spec.rb +99 -93
- data/spec/unit/indirector/indirection_spec.rb +242 -226
- data/spec/unit/indirector/json_spec.rb +7 -9
- data/spec/unit/indirector/key/ca_spec.rb +2 -3
- data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
- data/spec/unit/indirector/key/file_spec.rb +25 -26
- data/spec/unit/indirector/ldap_spec.rb +34 -41
- data/spec/unit/indirector/memory_spec.rb +6 -7
- data/spec/unit/indirector/msgpack_spec.rb +7 -9
- data/spec/unit/indirector/node/exec_spec.rb +6 -6
- data/spec/unit/indirector/node/ldap_spec.rb +74 -76
- data/spec/unit/indirector/node/memory_spec.rb +2 -4
- data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
- data/spec/unit/indirector/node/plain_spec.rb +2 -4
- data/spec/unit/indirector/node/rest_spec.rb +0 -1
- data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
- data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
- data/spec/unit/indirector/node/yaml_spec.rb +0 -1
- data/spec/unit/indirector/none_spec.rb +5 -5
- data/spec/unit/indirector/plain_spec.rb +7 -8
- data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
- data/spec/unit/indirector/report/processor_spec.rb +21 -22
- data/spec/unit/indirector/report/rest_spec.rb +11 -12
- data/spec/unit/indirector/report/yaml_spec.rb +0 -1
- data/spec/unit/indirector/request_spec.rb +11 -12
- data/spec/unit/indirector/resource/ral_spec.rb +47 -54
- data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
- data/spec/unit/indirector/rest_spec.rb +113 -110
- data/spec/unit/indirector/ssl_file_spec.rb +74 -77
- data/spec/unit/indirector/status/local_spec.rb +0 -1
- data/spec/unit/indirector/status/rest_spec.rb +0 -1
- data/spec/unit/indirector/store_configs_spec.rb +0 -1
- data/spec/unit/indirector/terminus_spec.rb +31 -29
- data/spec/unit/indirector/yaml_spec.rb +33 -32
- data/spec/unit/indirector_spec.rb +1 -2
- data/spec/unit/info_service_spec.rb +3 -1
- data/spec/unit/interface/action_builder_spec.rb +0 -1
- data/spec/unit/interface/action_manager_spec.rb +0 -1
- data/spec/unit/interface/action_spec.rb +2 -3
- data/spec/unit/interface/documentation_spec.rb +0 -1
- data/spec/unit/interface/face_collection_spec.rb +19 -12
- data/spec/unit/interface_spec.rb +3 -3
- data/spec/unit/man_spec.rb +3 -4
- data/spec/unit/module_spec.rb +46 -51
- data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
- data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
- data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
- data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
- data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
- data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
- data/spec/unit/module_tool/install_directory_spec.rb +8 -8
- data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
- data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
- data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
- data/spec/unit/module_tool/tar_spec.rb +12 -13
- data/spec/unit/module_tool_spec.rb +7 -12
- data/spec/unit/network/auth_config_parser_spec.rb +11 -13
- data/spec/unit/network/authconfig_spec.rb +17 -18
- data/spec/unit/network/authorization_spec.rb +4 -5
- data/spec/unit/network/authstore_spec.rb +0 -1
- data/spec/unit/network/format_handler_spec.rb +0 -1
- data/spec/unit/network/format_spec.rb +9 -10
- data/spec/unit/network/format_support_spec.rb +28 -29
- data/spec/unit/network/formats_spec.rb +4 -5
- data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
- data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
- data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
- data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
- data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
- data/spec/unit/network/http/api_spec.rb +1 -3
- data/spec/unit/network/http/compression_spec.rb +21 -22
- data/spec/unit/network/http/connection_spec.rb +39 -36
- data/spec/unit/network/http/factory_spec.rb +5 -6
- data/spec/unit/network/http/handler_spec.rb +9 -18
- data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
- data/spec/unit/network/http/pool_spec.rb +28 -29
- data/spec/unit/network/http/rack/rest_spec.rb +24 -27
- data/spec/unit/network/http/rack_spec.rb +5 -6
- data/spec/unit/network/http/request_spec.rb +0 -2
- data/spec/unit/network/http/response_spec.rb +11 -13
- data/spec/unit/network/http/route_spec.rb +0 -1
- data/spec/unit/network/http/session_spec.rb +1 -2
- data/spec/unit/network/http/site_spec.rb +0 -1
- data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
- data/spec/unit/network/http/webrick_spec.rb +49 -52
- data/spec/unit/network/http_pool_spec.rb +18 -9
- data/spec/unit/network/http_spec.rb +0 -1
- data/spec/unit/network/resolver_spec.rb +16 -17
- data/spec/unit/network/rights_spec.rb +52 -53
- data/spec/unit/network/server_spec.rb +12 -13
- data/spec/unit/node/environment_spec.rb +16 -14
- data/spec/unit/node/facts_spec.rb +5 -7
- data/spec/unit/node_spec.rb +4 -10
- data/spec/unit/other/selinux_spec.rb +2 -3
- data/spec/unit/parameter/boolean_spec.rb +1 -2
- data/spec/unit/parameter/package_options_spec.rb +1 -2
- data/spec/unit/parameter/path_spec.rb +0 -1
- data/spec/unit/parameter/value_collection_spec.rb +0 -1
- data/spec/unit/parameter/value_spec.rb +0 -1
- data/spec/unit/parameter_spec.rb +9 -9
- data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
- data/spec/unit/parser/ast/leaf_spec.rb +20 -21
- data/spec/unit/parser/compiler_spec.rb +84 -96
- data/spec/unit/parser/environment_compiler_spec.rb +11 -9
- data/spec/unit/parser/files_spec.rb +0 -1
- data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
- data/spec/unit/parser/functions/digest_spec.rb +0 -1
- data/spec/unit/parser/functions/fail_spec.rb +1 -2
- data/spec/unit/parser/functions/file_spec.rb +13 -14
- data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
- data/spec/unit/parser/functions/generate_spec.rb +7 -8
- data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
- data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
- data/spec/unit/parser/functions/scanf_spec.rb +0 -1
- data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
- data/spec/unit/parser/functions/split_spec.rb +0 -1
- data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
- data/spec/unit/parser/functions/tag_spec.rb +1 -2
- data/spec/unit/parser/functions/tagged_spec.rb +2 -3
- data/spec/unit/parser/functions/template_spec.rb +13 -13
- data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
- data/spec/unit/parser/functions_spec.rb +3 -4
- data/spec/unit/parser/relationship_spec.rb +0 -1
- data/spec/unit/parser/resource_spec.rb +42 -42
- data/spec/unit/parser/scope_spec.rb +39 -35
- data/spec/unit/parser/templatewrapper_spec.rb +11 -12
- data/spec/unit/parser/type_loader_spec.rb +17 -19
- data/spec/unit/pops/adaptable_spec.rb +0 -1
- data/spec/unit/pops/benchmark_spec.rb +0 -1
- data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
- data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
- data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
- data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
- data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
- data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
- data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
- data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
- data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
- data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
- data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
- data/spec/unit/pops/factory_spec.rb +3 -4
- data/spec/unit/pops/issues_spec.rb +19 -20
- data/spec/unit/pops/loaders/loader_spec.rb +8 -4
- data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
- data/spec/unit/pops/lookup/context_spec.rb +0 -1
- data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
- data/spec/unit/pops/merge_strategy_spec.rb +0 -1
- data/spec/unit/pops/migration_spec.rb +3 -5
- data/spec/unit/pops/model/model_spec.rb +0 -1
- data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
- data/spec/unit/pops/parser/locator_spec.rb +3 -6
- data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
- data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
- data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
- data/spec/unit/pops/pn_spec.rb +0 -1
- data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
- data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
- data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
- data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
- data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
- data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
- data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
- data/spec/unit/pops/types/type_parser_spec.rb +13 -13
- data/spec/unit/pops/validator/validator_spec.rb +1 -2
- data/spec/unit/pops/visitor_spec.rb +0 -1
- data/spec/unit/property/boolean_spec.rb +1 -1
- data/spec/unit/property/ensure_spec.rb +0 -1
- data/spec/unit/property/keyvalue_spec.rb +32 -34
- data/spec/unit/property/list_spec.rb +26 -27
- data/spec/unit/property/ordered_list_spec.rb +10 -14
- data/spec/unit/property_spec.rb +42 -43
- data/spec/unit/provider/aix_object_spec.rb +47 -45
- data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
- data/spec/unit/provider/cisco_spec.rb +1 -2
- data/spec/unit/provider/command_spec.rb +9 -9
- data/spec/unit/provider/cron/crontab_spec.rb +10 -11
- data/spec/unit/provider/cron/parsed_spec.rb +22 -24
- data/spec/unit/provider/exec/posix_spec.rb +6 -7
- data/spec/unit/provider/exec/shell_spec.rb +0 -1
- data/spec/unit/provider/exec/windows_spec.rb +2 -4
- data/spec/unit/provider/exec_spec.rb +0 -1
- data/spec/unit/provider/file/posix_spec.rb +22 -24
- data/spec/unit/provider/file/windows_spec.rb +15 -17
- data/spec/unit/provider/group/aix_spec.rb +3 -2
- data/spec/unit/provider/group/groupadd_spec.rb +30 -26
- data/spec/unit/provider/group/ldap_spec.rb +18 -18
- data/spec/unit/provider/group/pw_spec.rb +11 -11
- data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
- data/spec/unit/provider/host/parsed_spec.rb +6 -6
- data/spec/unit/provider/interface/cisco_spec.rb +20 -24
- data/spec/unit/provider/ldap_spec.rb +61 -62
- data/spec/unit/provider/macauthorization_spec.rb +26 -47
- data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
- data/spec/unit/provider/mount/parsed_spec.rb +18 -24
- data/spec/unit/provider/mount_spec.rb +57 -66
- data/spec/unit/provider/naginator_spec.rb +13 -14
- data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
- data/spec/unit/provider/nameservice_spec.rb +38 -40
- data/spec/unit/provider/network_device_spec.rb +28 -28
- data/spec/unit/provider/package/aix_spec.rb +15 -15
- data/spec/unit/provider/package/appdmg_spec.rb +13 -13
- data/spec/unit/provider/package/apt_spec.rb +44 -27
- data/spec/unit/provider/package/aptitude_spec.rb +6 -7
- data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
- data/spec/unit/provider/package/base_spec.rb +4 -4
- data/spec/unit/provider/package/dnf_spec.rb +14 -16
- data/spec/unit/provider/package/dpkg_spec.rb +52 -52
- data/spec/unit/provider/package/freebsd_spec.rb +11 -11
- data/spec/unit/provider/package/gem_spec.rb +51 -43
- data/spec/unit/provider/package/hpux_spec.rb +8 -8
- data/spec/unit/provider/package/macports_spec.rb +46 -42
- data/spec/unit/provider/package/nim_spec.rb +30 -39
- data/spec/unit/provider/package/openbsd_spec.rb +36 -39
- data/spec/unit/provider/package/opkg_spec.rb +23 -26
- data/spec/unit/provider/package/pacman_spec.rb +97 -118
- data/spec/unit/provider/package/pip_spec.rb +69 -71
- data/spec/unit/provider/package/pkg_spec.rb +109 -109
- data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
- data/spec/unit/provider/package/pkgin_spec.rb +10 -8
- data/spec/unit/provider/package/pkgng_spec.rb +17 -18
- data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
- data/spec/unit/provider/package/portage_spec.rb +70 -74
- data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
- data/spec/unit/provider/package/rpm_spec.rb +53 -64
- data/spec/unit/provider/package/sun_spec.rb +16 -18
- data/spec/unit/provider/package/tdnf_spec.rb +2 -2
- data/spec/unit/provider/package/up2date_spec.rb +2 -4
- data/spec/unit/provider/package/urpmi_spec.rb +15 -17
- data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
- data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
- data/spec/unit/provider/package/windows/package_spec.rb +37 -42
- data/spec/unit/provider/package/windows_spec.rb +36 -32
- data/spec/unit/provider/package/yum_spec.rb +4 -4
- data/spec/unit/provider/package/zypper_spec.rb +87 -87
- data/spec/unit/provider/parsedfile_spec.rb +44 -45
- data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
- data/spec/unit/provider/selboolean_spec.rb +9 -11
- data/spec/unit/provider/selmodule_spec.rb +20 -22
- data/spec/unit/provider/service/base_spec.rb +4 -5
- data/spec/unit/provider/service/bsd_spec.rb +27 -29
- data/spec/unit/provider/service/daemontools_spec.rb +35 -35
- data/spec/unit/provider/service/debian_spec.rb +37 -37
- data/spec/unit/provider/service/freebsd_spec.rb +18 -18
- data/spec/unit/provider/service/gentoo_spec.rb +50 -56
- data/spec/unit/provider/service/init_spec.rb +55 -55
- data/spec/unit/provider/service/launchd_spec.rb +138 -116
- data/spec/unit/provider/service/openbsd_spec.rb +50 -50
- data/spec/unit/provider/service/openrc_spec.rb +43 -46
- data/spec/unit/provider/service/openwrt_spec.rb +26 -32
- data/spec/unit/provider/service/rcng_spec.rb +14 -14
- data/spec/unit/provider/service/redhat_spec.rb +45 -43
- data/spec/unit/provider/service/runit_spec.rb +29 -27
- data/spec/unit/provider/service/smf_spec.rb +74 -66
- data/spec/unit/provider/service/src_spec.rb +46 -47
- data/spec/unit/provider/service/systemd_spec.rb +93 -98
- data/spec/unit/provider/service/upstart_spec.rb +74 -72
- data/spec/unit/provider/service/windows_spec.rb +33 -41
- data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
- data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
- data/spec/unit/provider/user/aix_spec.rb +31 -31
- data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
- data/spec/unit/provider/user/hpux_spec.rb +15 -15
- data/spec/unit/provider/user/ldap_spec.rb +57 -57
- data/spec/unit/provider/user/openbsd_spec.rb +10 -12
- data/spec/unit/provider/user/pw_spec.rb +37 -35
- data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
- data/spec/unit/provider/user/useradd_spec.rb +93 -92
- data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
- data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
- data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
- data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
- data/spec/unit/provider/zone/solaris_spec.rb +56 -42
- data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
- data/spec/unit/provider_spec.rb +29 -29
- data/spec/unit/puppet_pal_2pec.rb +4 -5
- data/spec/unit/puppet_pal_spec.rb +0 -1
- data/spec/unit/puppet_spec.rb +7 -8
- data/spec/unit/relationship_spec.rb +0 -1
- data/spec/unit/reports/http_spec.rb +21 -23
- data/spec/unit/reports/store_spec.rb +3 -4
- data/spec/unit/reports_spec.rb +12 -14
- data/spec/unit/resource/capability_finder_spec.rb +18 -16
- data/spec/unit/resource/catalog_spec.rb +72 -68
- data/spec/unit/resource/status_spec.rb +6 -8
- data/spec/unit/resource/type_collection_spec.rb +17 -18
- data/spec/unit/resource/type_spec.rb +34 -35
- data/spec/unit/resource_spec.rb +36 -32
- data/spec/unit/scheduler/job_spec.rb +0 -1
- data/spec/unit/scheduler/scheduler_spec.rb +0 -1
- data/spec/unit/scheduler/splay_job_spec.rb +1 -2
- data/spec/unit/settings/array_setting_spec.rb +1 -1
- data/spec/unit/settings/autosign_setting_spec.rb +9 -9
- data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
- data/spec/unit/settings/config_file_spec.rb +0 -1
- data/spec/unit/settings/directory_setting_spec.rb +2 -7
- data/spec/unit/settings/duration_setting_spec.rb +1 -2
- data/spec/unit/settings/enum_setting_spec.rb +1 -1
- data/spec/unit/settings/environment_conf_spec.rb +4 -6
- data/spec/unit/settings/file_setting_spec.rb +44 -46
- data/spec/unit/settings/path_setting_spec.rb +1 -2
- data/spec/unit/settings/priority_setting_spec.rb +1 -2
- data/spec/unit/settings/string_setting_spec.rb +14 -15
- data/spec/unit/settings/terminus_setting_spec.rb +1 -2
- data/spec/unit/settings/value_translator_spec.rb +0 -1
- data/spec/unit/settings_spec.rb +226 -233
- data/spec/unit/ssl/base_spec.rb +14 -15
- data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
- data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
- data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
- data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
- data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
- data/spec/unit/ssl/certificate_request_spec.rb +66 -67
- data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
- data/spec/unit/ssl/certificate_spec.rb +23 -25
- data/spec/unit/ssl/configuration_spec.rb +1 -4
- data/spec/unit/ssl/digest_spec.rb +0 -1
- data/spec/unit/ssl/host_spec.rb +217 -188
- data/spec/unit/ssl/inventory_spec.rb +25 -21
- data/spec/unit/ssl/key_spec.rb +30 -31
- data/spec/unit/ssl/validator_spec.rb +40 -40
- data/spec/unit/task_spec.rb +6 -7
- data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
- data/spec/unit/transaction/event_manager_spec.rb +88 -88
- data/spec/unit/transaction/event_spec.rb +16 -15
- data/spec/unit/transaction/persistence_spec.rb +16 -17
- data/spec/unit/transaction/report_spec.rb +11 -12
- data/spec/unit/transaction/resource_harness_spec.rb +28 -33
- data/spec/unit/transaction_spec.rb +98 -100
- data/spec/unit/type/augeas_spec.rb +11 -10
- data/spec/unit/type/component_spec.rb +0 -1
- data/spec/unit/type/computer_spec.rb +7 -10
- data/spec/unit/type/cron_spec.rb +3 -7
- data/spec/unit/type/exec_spec.rb +60 -56
- data/spec/unit/type/file/checksum_spec.rb +9 -10
- data/spec/unit/type/file/checksum_value_spec.rb +31 -32
- data/spec/unit/type/file/content_spec.rb +58 -61
- data/spec/unit/type/file/ctime_spec.rb +0 -1
- data/spec/unit/type/file/ensure_spec.rb +12 -13
- data/spec/unit/type/file/group_spec.rb +5 -7
- data/spec/unit/type/file/mode_spec.rb +4 -6
- data/spec/unit/type/file/mtime_spec.rb +0 -1
- data/spec/unit/type/file/owner_spec.rb +6 -8
- data/spec/unit/type/file/selinux_spec.rb +17 -19
- data/spec/unit/type/file/source_spec.rb +104 -101
- data/spec/unit/type/file/type_spec.rb +0 -1
- data/spec/unit/type/file_spec.rb +195 -185
- data/spec/unit/type/filebucket_spec.rb +4 -5
- data/spec/unit/type/group_spec.rb +6 -8
- data/spec/unit/type/host_spec.rb +2 -3
- data/spec/unit/type/interface_spec.rb +2 -3
- data/spec/unit/type/k5login_spec.rb +3 -4
- data/spec/unit/type/macauthorization_spec.rb +6 -8
- data/spec/unit/type/mailalias_spec.rb +2 -3
- data/spec/unit/type/maillist_spec.rb +6 -9
- data/spec/unit/type/mcx_spec.rb +4 -8
- data/spec/unit/type/mount_spec.rb +26 -38
- data/spec/unit/type/nagios_spec.rb +0 -1
- data/spec/unit/type/noop_metaparam_spec.rb +1 -2
- data/spec/unit/type/package/package_settings_spec.rb +44 -23
- data/spec/unit/type/package_spec.rb +53 -54
- data/spec/unit/type/resources_spec.rb +86 -88
- data/spec/unit/type/schedule_spec.rb +24 -26
- data/spec/unit/type/scheduled_task_spec.rb +1 -2
- data/spec/unit/type/selboolean_spec.rb +5 -6
- data/spec/unit/type/selmodule_spec.rb +0 -1
- data/spec/unit/type/service_spec.rb +47 -47
- data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
- data/spec/unit/type/sshkey_spec.rb +0 -2
- data/spec/unit/type/stage_spec.rb +0 -1
- data/spec/unit/type/tidy_spec.rb +61 -62
- data/spec/unit/type/user_spec.rb +41 -27
- data/spec/unit/type/vlan_spec.rb +2 -4
- data/spec/unit/type/whit_spec.rb +0 -1
- data/spec/unit/type/zfs_spec.rb +6 -7
- data/spec/unit/type/zone_spec.rb +14 -4
- data/spec/unit/type/zpool_spec.rb +4 -5
- data/spec/unit/type_spec.rb +54 -53
- data/spec/unit/util/at_fork_spec.rb +18 -19
- data/spec/unit/util/autoload_spec.rb +53 -54
- data/spec/unit/util/backups_spec.rb +34 -35
- data/spec/unit/util/character_encoding_spec.rb +8 -8
- data/spec/unit/util/checksums_spec.rb +38 -39
- data/spec/unit/util/colors_spec.rb +1 -2
- data/spec/unit/util/command_line_spec.rb +24 -25
- data/spec/unit/util/constant_inflector_spec.rb +0 -1
- data/spec/unit/util/diff_spec.rb +7 -8
- data/spec/unit/util/errors_spec.rb +0 -1
- data/spec/unit/util/execution_spec.rb +187 -162
- data/spec/unit/util/execution_stub_spec.rb +0 -1
- data/spec/unit/util/feature_spec.rb +13 -13
- data/spec/unit/util/filetype_spec.rb +49 -49
- data/spec/unit/util/http_proxy_spec.rb +12 -12
- data/spec/unit/util/inifile_spec.rb +26 -31
- data/spec/unit/util/json_lockfile_spec.rb +3 -5
- data/spec/unit/util/ldap/connection_spec.rb +26 -25
- data/spec/unit/util/ldap/generator_spec.rb +0 -1
- data/spec/unit/util/ldap/manager_spec.rb +102 -101
- data/spec/unit/util/lockfile_spec.rb +0 -1
- data/spec/unit/util/log/destinations_spec.rb +30 -33
- data/spec/unit/util/log_spec.rb +35 -36
- data/spec/unit/util/logging_spec.rb +58 -66
- data/spec/unit/util/metric_spec.rb +0 -1
- data/spec/unit/util/monkey_patches_spec.rb +7 -9
- data/spec/unit/util/multi_match_spec.rb +0 -1
- data/spec/unit/util/nagios_maker_spec.rb +35 -36
- data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
- data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
- data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
- data/spec/unit/util/network_device/config_spec.rb +0 -1
- data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
- data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
- data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
- data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
- data/spec/unit/util/network_device_spec.rb +7 -9
- data/spec/unit/util/package_spec.rb +0 -1
- data/spec/unit/util/pidlock_spec.rb +13 -14
- data/spec/unit/util/plist_spec.rb +40 -33
- data/spec/unit/util/posix_spec.rb +54 -51
- data/spec/unit/util/rdoc_spec.rb +9 -10
- data/spec/unit/util/reference_spec.rb +0 -1
- data/spec/unit/util/resource_template_spec.rb +20 -20
- data/spec/unit/util/retry_action_spec.rb +7 -8
- data/spec/unit/util/rubygems_spec.rb +14 -14
- data/spec/unit/util/run_mode_spec.rb +3 -4
- data/spec/unit/util/selinux_spec.rb +79 -72
- data/spec/unit/util/splayer_spec.rb +8 -9
- data/spec/unit/util/ssl_spec.rb +0 -1
- data/spec/unit/util/storage_spec.rb +3 -4
- data/spec/unit/util/suidmanager_spec.rb +45 -54
- data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
- data/spec/unit/util/tag_set_spec.rb +0 -1
- data/spec/unit/util/tagging_spec.rb +0 -1
- data/spec/unit/util/terminal_spec.rb +9 -10
- data/spec/unit/util/user_attr_spec.rb +1 -2
- data/spec/unit/util/warnings_spec.rb +3 -4
- data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
- data/spec/unit/util/watcher_spec.rb +51 -21
- data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
- data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
- data/spec/unit/util/windows/adsi_spec.rb +136 -138
- data/spec/unit/util/windows/api_types_spec.rb +0 -1
- data/spec/unit/util/windows/eventlog_spec.rb +9 -12
- data/spec/unit/util/windows/file_spec.rb +0 -1
- data/spec/unit/util/windows/root_certs_spec.rb +0 -1
- data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
- data/spec/unit/util/windows/service_spec.rb +66 -68
- data/spec/unit/util/windows/sid_spec.rb +11 -13
- data/spec/unit/util/windows/string_spec.rb +0 -1
- data/spec/unit/util_spec.rb +55 -59
- data/spec/unit/version_spec.rb +6 -6
- metadata +2 -2
@@ -1,4 +1,3 @@
|
|
1
|
-
#! /usr/bin/env ruby
|
2
1
|
require 'spec_helper'
|
3
2
|
require 'puppet/util/json'
|
4
3
|
|
@@ -14,16 +13,15 @@ describe Puppet::Util::Log.desttypes[:report] do
|
|
14
13
|
end
|
15
14
|
|
16
15
|
it "should send new messages to the report" do
|
17
|
-
report =
|
16
|
+
report = double('report')
|
18
17
|
dest = @dest.new(report)
|
19
18
|
|
20
|
-
report.
|
19
|
+
expect(report).to receive(:<<).with("my log")
|
21
20
|
|
22
21
|
dest.handle "my log"
|
23
22
|
end
|
24
23
|
end
|
25
24
|
|
26
|
-
|
27
25
|
describe Puppet::Util::Log.desttypes[:file] do
|
28
26
|
include PuppetSpec::Files
|
29
27
|
|
@@ -54,26 +52,26 @@ describe Puppet::Util::Log.desttypes[:file] do
|
|
54
52
|
it_behaves_like "file destination"
|
55
53
|
|
56
54
|
it "logs an error if it can't chown the file owner & group" do
|
57
|
-
File.
|
58
|
-
FileUtils.
|
59
|
-
Puppet.features.
|
60
|
-
Puppet.
|
55
|
+
expect(File).to receive(:exists?).with(abspath).and_return(false)
|
56
|
+
expect(FileUtils).to receive(:chown).with(Puppet[:user], Puppet[:group], abspath).and_raise(Errno::EPERM)
|
57
|
+
expect(Puppet.features).to receive(:root?).and_return(true)
|
58
|
+
expect(Puppet).to receive(:err).with("Unable to set ownership to #{Puppet[:user]}:#{Puppet[:group]} for log file: #{abspath}")
|
61
59
|
|
62
60
|
@class.new(abspath)
|
63
61
|
end
|
64
62
|
|
65
63
|
it "doesn't attempt to chown when running as non-root" do
|
66
|
-
File.
|
67
|
-
FileUtils.
|
68
|
-
Puppet.features.
|
64
|
+
expect(File).to receive(:exists?).with(abspath).and_return(false)
|
65
|
+
expect(FileUtils).not_to receive(:chown).with(Puppet[:user], Puppet[:group], abspath)
|
66
|
+
expect(Puppet.features).to receive(:root?).and_return(false)
|
69
67
|
|
70
68
|
@class.new(abspath)
|
71
69
|
end
|
72
70
|
|
73
71
|
it "doesn't attempt to chown when file already exists" do
|
74
|
-
File.
|
75
|
-
FileUtils.
|
76
|
-
Puppet.features.
|
72
|
+
expect(File).to receive(:exists?).with(abspath).and_return(true)
|
73
|
+
expect(FileUtils).not_to receive(:chown).with(Puppet[:user], Puppet[:group], abspath)
|
74
|
+
expect(Puppet.features).to receive(:root?).and_return(true)
|
77
75
|
|
78
76
|
@class.new(abspath)
|
79
77
|
end
|
@@ -110,28 +108,28 @@ describe Puppet::Util::Log.desttypes[:syslog] do
|
|
110
108
|
# we can't stub the top-level Syslog module
|
111
109
|
describe "when syslog is available", :if => Puppet.features.syslog? do
|
112
110
|
before :each do
|
113
|
-
Syslog.
|
114
|
-
Syslog.
|
115
|
-
Syslog.
|
111
|
+
allow(Syslog).to receive(:opened?).and_return(false)
|
112
|
+
allow(Syslog).to receive(:const_get).and_return("LOG_KERN", 0)
|
113
|
+
allow(Syslog).to receive(:open)
|
116
114
|
end
|
117
115
|
|
118
116
|
it "should open syslog" do
|
119
|
-
Syslog.
|
117
|
+
expect(Syslog).to receive(:open)
|
120
118
|
|
121
119
|
klass.new
|
122
120
|
end
|
123
121
|
|
124
122
|
it "should close syslog" do
|
125
|
-
Syslog.
|
123
|
+
expect(Syslog).to receive(:close)
|
126
124
|
|
127
125
|
dest = klass.new
|
128
126
|
dest.close
|
129
127
|
end
|
130
128
|
|
131
129
|
it "should send messages to syslog" do
|
132
|
-
syslog =
|
133
|
-
syslog.
|
134
|
-
Syslog.
|
130
|
+
syslog = double('syslog')
|
131
|
+
expect(syslog).to receive(:info).with("don't panic")
|
132
|
+
allow(Syslog).to receive(:open).and_return(syslog)
|
135
133
|
|
136
134
|
msg = Puppet::Util::Log.new(:level => :info, :message => "don't panic")
|
137
135
|
dest = klass.new
|
@@ -141,7 +139,7 @@ describe Puppet::Util::Log.desttypes[:syslog] do
|
|
141
139
|
|
142
140
|
describe "when syslog is unavailable" do
|
143
141
|
it "should not be a suitable log destination" do
|
144
|
-
Puppet.features.
|
142
|
+
allow(Puppet.features).to receive(:syslog?).and_return(false)
|
145
143
|
|
146
144
|
expect(klass.suitable?(:syslog)).to be_falsey
|
147
145
|
end
|
@@ -149,7 +147,6 @@ describe Puppet::Util::Log.desttypes[:syslog] do
|
|
149
147
|
end
|
150
148
|
|
151
149
|
describe Puppet::Util::Log.desttypes[:logstash_event] do
|
152
|
-
|
153
150
|
describe "when using structured log format with logstash_event schema" do
|
154
151
|
before :each do
|
155
152
|
@msg = Puppet::Util::Log.new(:level => :info, :message => "So long, and thanks for all the fish.", :source => "a dolphin")
|
@@ -173,7 +170,7 @@ describe Puppet::Util::Log.desttypes[:logstash_event] do
|
|
173
170
|
end
|
174
171
|
|
175
172
|
it "handle should send the output to stdout" do
|
176
|
-
$stdout.
|
173
|
+
expect($stdout).to receive(:puts).once
|
177
174
|
dest = described_class.new
|
178
175
|
dest.handle(@msg)
|
179
176
|
end
|
@@ -207,7 +204,7 @@ describe Puppet::Util::Log.desttypes[:console] do
|
|
207
204
|
|
208
205
|
it "should include the log message's source/context in the output when available" do
|
209
206
|
Puppet[:color] = false
|
210
|
-
$stdout.
|
207
|
+
expect($stdout).to receive(:puts).with("Info: a hitchhiker: don't panic")
|
211
208
|
|
212
209
|
msg = Puppet::Util::Log.new(:level => :info, :message => "don't panic", :source => "a hitchhiker")
|
213
210
|
dest = klass.new
|
@@ -220,9 +217,9 @@ describe ":eventlog", :if => Puppet::Util::Platform.windows? do
|
|
220
217
|
let(:klass) { Puppet::Util::Log.desttypes[:eventlog] }
|
221
218
|
|
222
219
|
def expects_message_with_type(klass, level, eventlog_type, eventlog_id)
|
223
|
-
eventlog =
|
224
|
-
eventlog.
|
225
|
-
Puppet::Util::Windows::EventLog.
|
220
|
+
eventlog = double('eventlog')
|
221
|
+
expect(eventlog).to receive(:report_event).with(hash_including(:event_type => eventlog_type, :event_id => eventlog_id, :data => "a hitchhiker: don't panic"))
|
222
|
+
allow(Puppet::Util::Windows::EventLog).to receive(:open).and_return(eventlog)
|
226
223
|
|
227
224
|
msg = Puppet::Util::Log.new(:level => level, :message => "don't panic", :source => "a hitchhiker")
|
228
225
|
dest = klass.new
|
@@ -238,17 +235,17 @@ describe ":eventlog", :if => Puppet::Util::Platform.windows? do
|
|
238
235
|
expected_truncated_msg = "#{'x' * 31785}...Message exceeds character length limit, truncating."
|
239
236
|
expected_data = "a vogon ship: " + expected_truncated_msg
|
240
237
|
|
241
|
-
eventlog =
|
242
|
-
eventlog.
|
238
|
+
eventlog = double('eventlog')
|
239
|
+
expect(eventlog).to receive(:report_event).with(hash_including(:event_type => 2, :event_id => 2, :data => expected_data))
|
243
240
|
msg = Puppet::Util::Log.new(:level => :warning, :message => long_msg, :source => "a vogon ship")
|
244
|
-
Puppet::Util::Windows::EventLog.
|
241
|
+
allow(Puppet::Util::Windows::EventLog).to receive(:open).and_return(eventlog)
|
245
242
|
|
246
243
|
dest = klass.new
|
247
244
|
dest.handle(msg)
|
248
245
|
end
|
249
246
|
|
250
247
|
it "logs to the Puppet Application event log" do
|
251
|
-
Puppet::Util::Windows::EventLog.
|
248
|
+
expect(Puppet::Util::Windows::EventLog).to receive(:open).with('Puppet').and_return(double('eventlog'))
|
252
249
|
|
253
250
|
klass.new
|
254
251
|
end
|
data/spec/unit/util/log_spec.rb
CHANGED
@@ -1,4 +1,3 @@
|
|
1
|
-
#! /usr/bin/env ruby
|
2
1
|
# coding: utf-8
|
3
2
|
require 'spec_helper'
|
4
3
|
|
@@ -64,7 +63,7 @@ describe Puppet::Util::Log do
|
|
64
63
|
win_31j_msg = [130, 187].pack('C*').force_encoding(Encoding::Windows_31J)
|
65
64
|
utf_8_msg = "\u305d"
|
66
65
|
|
67
|
-
$stdout.
|
66
|
+
expect($stdout).to receive(:puts).with("\e[mNotice: #{mixed_utf8}: #{utf_8_msg}\e[0m")
|
68
67
|
|
69
68
|
# most handlers do special things with a :source => 'Puppet', so use something else
|
70
69
|
Puppet::Util::Log.new(:level => :notice, :message => win_31j_msg, :source => mixed_utf8)
|
@@ -82,7 +81,7 @@ describe Puppet::Util::Log do
|
|
82
81
|
win_31j_msg = [130, 187].pack('C*').force_encoding(Encoding::Windows_31J)
|
83
82
|
utf_8_msg = "\u305d"
|
84
83
|
|
85
|
-
$stdout.
|
84
|
+
expect($stdout).to receive(:puts).with("\e[mNotice: #{utf_8_msg}: #{mixed_utf8}\e[0m")
|
86
85
|
|
87
86
|
Puppet::Util::Log.new(:level => :notice, :message => mixed_utf8, :source => win_31j_msg)
|
88
87
|
expect(logs.last.source).to eq(utf_8_msg)
|
@@ -94,10 +93,10 @@ describe Puppet::Util::Log do
|
|
94
93
|
# spec_helper.rb redirects log output away from the console,
|
95
94
|
# so we have to stop that here, or else the logic we are testing
|
96
95
|
# will not be reached.
|
97
|
-
Puppet::Util::Log.
|
96
|
+
allow(Puppet::Util::Log).to receive(:destinations).and_return({})
|
98
97
|
|
99
98
|
our_exception = Puppet::DevError.new("test exception")
|
100
|
-
Puppet::FileSystem.
|
99
|
+
expect(Puppet::FileSystem).to receive(:dir).and_raise(our_exception)
|
101
100
|
bad_file = tmpfile("bad_file")
|
102
101
|
|
103
102
|
expect { Puppet::Util::Log.newdestination(bad_file) }.to raise_error(Puppet::DevError)
|
@@ -105,24 +104,24 @@ describe Puppet::Util::Log do
|
|
105
104
|
|
106
105
|
describe ".setup_default" do
|
107
106
|
it "should default to :syslog" do
|
108
|
-
Puppet.features.
|
109
|
-
Puppet::Util::Log.
|
107
|
+
allow(Puppet.features).to receive(:syslog?).and_return(true)
|
108
|
+
expect(Puppet::Util::Log).to receive(:newdestination).with(:syslog)
|
110
109
|
|
111
110
|
Puppet::Util::Log.setup_default
|
112
111
|
end
|
113
112
|
|
114
113
|
it "should fall back to :eventlog" do
|
115
|
-
Puppet.features.
|
116
|
-
Puppet.features.
|
117
|
-
Puppet::Util::Log.
|
114
|
+
allow(Puppet.features).to receive(:syslog?).and_return(false)
|
115
|
+
allow(Puppet.features).to receive(:eventlog?).and_return(true)
|
116
|
+
expect(Puppet::Util::Log).to receive(:newdestination).with(:eventlog)
|
118
117
|
|
119
118
|
Puppet::Util::Log.setup_default
|
120
119
|
end
|
121
120
|
|
122
121
|
it "should fall back to :file" do
|
123
|
-
Puppet.features.
|
124
|
-
Puppet.features.
|
125
|
-
Puppet::Util::Log.
|
122
|
+
allow(Puppet.features).to receive(:syslog?).and_return(false)
|
123
|
+
allow(Puppet.features).to receive(:eventlog?).and_return(false)
|
124
|
+
expect(Puppet::Util::Log).to receive(:newdestination).with(Puppet[:puppetdlog])
|
126
125
|
|
127
126
|
Puppet::Util::Log.setup_default
|
128
127
|
end
|
@@ -336,28 +335,28 @@ describe Puppet::Util::Log do
|
|
336
335
|
|
337
336
|
describe Puppet::Util::Log::DestEventlog, :if => Puppet.features.eventlog? do
|
338
337
|
before :each do
|
339
|
-
Puppet::Util::Windows::EventLog.
|
340
|
-
Puppet::Util::Windows::EventLog.
|
341
|
-
Puppet::Util::Windows::EventLog.
|
342
|
-
Puppet.features.
|
338
|
+
allow(Puppet::Util::Windows::EventLog).to receive(:open).and_return(double('mylog', :close => nil))
|
339
|
+
allow(Puppet::Util::Windows::EventLog).to receive(:report_event)
|
340
|
+
allow(Puppet::Util::Windows::EventLog).to receive(:close)
|
341
|
+
allow(Puppet.features).to receive(:eventlog?).and_return(true)
|
343
342
|
end
|
344
343
|
|
345
344
|
it "should restrict its suitability to Windows" do
|
346
|
-
Puppet.features.
|
345
|
+
expect(Puppet.features).to receive(:microsoft_windows?).and_return(false)
|
347
346
|
|
348
347
|
expect(Puppet::Util::Log::DestEventlog.suitable?('whatever')).to eq(false)
|
349
348
|
end
|
350
349
|
|
351
350
|
it "should open the 'Puppet' event log" do
|
352
|
-
Puppet::Util::Windows::EventLog.
|
351
|
+
expect(Puppet::Util::Windows::EventLog).to receive(:open).with('Puppet')
|
353
352
|
|
354
353
|
Puppet::Util::Log.newdestination(:eventlog)
|
355
354
|
end
|
356
355
|
|
357
356
|
it "should close the event log" do
|
358
|
-
log =
|
359
|
-
log.
|
360
|
-
Puppet::Util::Windows::EventLog.
|
357
|
+
log = double('myeventlog')
|
358
|
+
expect(log).to receive(:close)
|
359
|
+
expect(Puppet::Util::Windows::EventLog).to receive(:open).and_return(log)
|
361
360
|
|
362
361
|
Puppet::Util::Log.newdestination(:eventlog)
|
363
362
|
Puppet::Util::Log.close(:eventlog)
|
@@ -374,7 +373,7 @@ describe Puppet::Util::Log do
|
|
374
373
|
|
375
374
|
describe "instances" do
|
376
375
|
before do
|
377
|
-
Puppet::Util::Log.
|
376
|
+
allow(Puppet::Util::Log).to receive(:newmessage)
|
378
377
|
end
|
379
378
|
|
380
379
|
[:level, :message, :time, :remote].each do |attr|
|
@@ -409,7 +408,7 @@ describe Puppet::Util::Log do
|
|
409
408
|
|
410
409
|
it "should flush the log queue when the first destination is specified" do
|
411
410
|
Puppet::Util::Log.close_all
|
412
|
-
Puppet::Util::Log.
|
411
|
+
expect(Puppet::Util::Log).to receive(:flushqueue)
|
413
412
|
Puppet::Util::Log.newdestination(:console)
|
414
413
|
end
|
415
414
|
|
@@ -422,13 +421,13 @@ describe Puppet::Util::Log do
|
|
422
421
|
end
|
423
422
|
|
424
423
|
it "should fail if the provided level is not valid" do
|
425
|
-
Puppet::Util::Log.
|
424
|
+
expect(Puppet::Util::Log).to receive(:validlevel?).with(:notice).and_return(false)
|
426
425
|
expect { Puppet::Util::Log.new(:level => :notice, :message => :foo) }.to raise_error(ArgumentError)
|
427
426
|
end
|
428
427
|
|
429
428
|
it "should set its time to the initialization time" do
|
430
|
-
time =
|
431
|
-
Time.
|
429
|
+
time = double('time')
|
430
|
+
expect(Time).to receive(:now).and_return(time)
|
432
431
|
expect(Puppet::Util::Log.new(:level => "notice", :message => :foo).time).to equal(time)
|
433
432
|
end
|
434
433
|
|
@@ -439,13 +438,13 @@ describe Puppet::Util::Log do
|
|
439
438
|
end
|
440
439
|
|
441
440
|
it "should use a passed-in source" do
|
442
|
-
Puppet::Util::Log.
|
441
|
+
expect_any_instance_of(Puppet::Util::Log).to receive(:source=).with("foo")
|
443
442
|
Puppet::Util::Log.new(:level => "notice", :message => :foo, :source => "foo")
|
444
443
|
end
|
445
444
|
|
446
445
|
[:file, :line].each do |attr|
|
447
446
|
it "should use #{attr} if provided" do
|
448
|
-
Puppet::Util::Log.
|
447
|
+
expect_any_instance_of(Puppet::Util::Log).to receive(attr.to_s + "=").with("foo")
|
449
448
|
Puppet::Util::Log.new(:level => "notice", :message => :foo, attr => "foo")
|
450
449
|
end
|
451
450
|
end
|
@@ -455,12 +454,12 @@ describe Puppet::Util::Log do
|
|
455
454
|
end
|
456
455
|
|
457
456
|
it "should register itself with Log" do
|
458
|
-
Puppet::Util::Log.
|
457
|
+
expect(Puppet::Util::Log).to receive(:newmessage)
|
459
458
|
Puppet::Util::Log.new(:level => "notice", :message => :foo)
|
460
459
|
end
|
461
460
|
|
462
461
|
it "should update Log autoflush when Puppet[:autoflush] is set" do
|
463
|
-
Puppet::Util::Log.
|
462
|
+
expect(Puppet::Util::Log).to receive(:autoflush=).once.with(true)
|
464
463
|
Puppet[:autoflush] = true
|
465
464
|
end
|
466
465
|
|
@@ -490,10 +489,10 @@ describe Puppet::Util::Log do
|
|
490
489
|
end
|
491
490
|
|
492
491
|
it "should not create unsuitable log destinations" do
|
493
|
-
Puppet.features.
|
492
|
+
allow(Puppet.features).to receive(:syslog?).and_return(false)
|
494
493
|
|
495
|
-
Puppet::Util::Log::DestSyslog.
|
496
|
-
Puppet::Util::Log::DestSyslog.
|
494
|
+
expect(Puppet::Util::Log::DestSyslog).to receive(:suitable?)
|
495
|
+
expect(Puppet::Util::Log::DestSyslog).not_to receive(:new)
|
497
496
|
|
498
497
|
Puppet::Util::Log.newdestination(:syslog)
|
499
498
|
end
|
@@ -546,8 +545,8 @@ describe Puppet::Util::Log do
|
|
546
545
|
|
547
546
|
describe "when setting the source as a non-RAL object" do
|
548
547
|
it "should not try to copy over file, version, line, or tag information" do
|
549
|
-
source =
|
550
|
-
source.
|
548
|
+
source = double('source')
|
549
|
+
expect(source).not_to receive(:file)
|
551
550
|
Puppet::Util::Log.new(:level => "notice", :message => :foo, :source => source)
|
552
551
|
end
|
553
552
|
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
#! /usr/bin/env ruby
|
2
1
|
require 'spec_helper'
|
3
2
|
|
4
3
|
require 'puppet/util/logging'
|
@@ -19,29 +18,29 @@ describe Puppet::Util::Logging do
|
|
19
18
|
end
|
20
19
|
|
21
20
|
it "should have a method for sending a log with a specified log level" do
|
22
|
-
@logger.
|
23
|
-
Puppet::Util::Log.
|
21
|
+
expect(@logger).to receive(:to_s).and_return("I'm a string!")
|
22
|
+
expect(Puppet::Util::Log).to receive(:create).with(hash_including(source: "I'm a string!", level: "loglevel", message: "mymessage"))
|
24
23
|
|
25
24
|
@logger.send_log "loglevel", "mymessage"
|
26
25
|
end
|
27
26
|
|
28
27
|
describe "when sending a log" do
|
29
28
|
it "should use the Log's 'create' entrance method" do
|
30
|
-
Puppet::Util::Log.
|
29
|
+
expect(Puppet::Util::Log).to receive(:create)
|
31
30
|
|
32
31
|
@logger.notice "foo"
|
33
32
|
end
|
34
33
|
|
35
34
|
it "should send itself converted to a string as the log source" do
|
36
|
-
@logger.
|
37
|
-
Puppet::Util::Log.
|
35
|
+
expect(@logger).to receive(:to_s).and_return("I'm a string!")
|
36
|
+
expect(Puppet::Util::Log).to receive(:create).with(hash_including(source: "I'm a string!"))
|
38
37
|
|
39
38
|
@logger.notice "foo"
|
40
39
|
end
|
41
40
|
|
42
41
|
it "should queue logs sent without a specified destination" do
|
43
42
|
Puppet::Util::Log.close_all
|
44
|
-
Puppet::Util::Log.
|
43
|
+
expect(Puppet::Util::Log).to receive(:queuemessage)
|
45
44
|
|
46
45
|
@logger.notice "foo"
|
47
46
|
end
|
@@ -49,9 +48,9 @@ describe Puppet::Util::Logging do
|
|
49
48
|
it "should use the path of any provided resource type" do
|
50
49
|
resource = Puppet::Type.type(:host).new :name => "foo"
|
51
50
|
|
52
|
-
resource.
|
51
|
+
expect(resource).to receive(:path).and_return("/path/to/host".to_sym)
|
53
52
|
|
54
|
-
Puppet::Util::Log.
|
53
|
+
expect(Puppet::Util::Log).to receive(:create).with(hash_including(source: "/path/to/host"))
|
55
54
|
|
56
55
|
resource.notice "foo"
|
57
56
|
end
|
@@ -61,21 +60,21 @@ describe Puppet::Util::Logging do
|
|
61
60
|
|
62
61
|
param = resource.parameter(:name)
|
63
62
|
|
64
|
-
param.
|
63
|
+
expect(param).to receive(:path).and_return("/path/to/param".to_sym)
|
65
64
|
|
66
|
-
Puppet::Util::Log.
|
65
|
+
expect(Puppet::Util::Log).to receive(:create).with(hash_including(source: "/path/to/param"))
|
67
66
|
|
68
67
|
param.notice "foo"
|
69
68
|
end
|
70
69
|
|
71
70
|
it "should send the provided argument as the log message" do
|
72
|
-
Puppet::Util::Log.
|
71
|
+
expect(Puppet::Util::Log).to receive(:create).with(hash_including(message: "foo"))
|
73
72
|
|
74
73
|
@logger.notice "foo"
|
75
74
|
end
|
76
75
|
|
77
76
|
it "should join any provided arguments into a single string for the message" do
|
78
|
-
Puppet::Util::Log.
|
77
|
+
expect(Puppet::Util::Log).to receive(:create).with(hash_including(message: "foo bar baz"))
|
79
78
|
|
80
79
|
@logger.notice ["foo", "bar", "baz"]
|
81
80
|
end
|
@@ -86,7 +85,7 @@ describe Puppet::Util::Logging do
|
|
86
85
|
|
87
86
|
@logger.send(attr.to_s + "=", "myval")
|
88
87
|
|
89
|
-
Puppet::Util::Log.
|
88
|
+
expect(Puppet::Util::Log).to receive(:create).with(hash_including(attr => "myval"))
|
90
89
|
@logger.notice "foo"
|
91
90
|
end
|
92
91
|
end
|
@@ -94,47 +93,41 @@ describe Puppet::Util::Logging do
|
|
94
93
|
|
95
94
|
describe "when sending a deprecation warning" do
|
96
95
|
it "does not log a message when deprecation warnings are disabled" do
|
97
|
-
Puppet.
|
98
|
-
@logger.
|
96
|
+
expect(Puppet).to receive(:[]).with(:disable_warnings).and_return(%w[deprecations])
|
97
|
+
expect(@logger).not_to receive(:warning)
|
99
98
|
@logger.deprecation_warning 'foo'
|
100
99
|
end
|
101
100
|
|
102
101
|
it "logs the message with warn" do
|
103
|
-
@logger.
|
104
|
-
msg =~ /^foo\n/
|
105
|
-
end
|
102
|
+
expect(@logger).to receive(:warning).with(/^foo\n/)
|
106
103
|
@logger.deprecation_warning 'foo'
|
107
104
|
end
|
108
105
|
|
109
106
|
it "only logs each offending line once" do
|
110
|
-
@logger.
|
111
|
-
msg =~ /^foo\n/
|
112
|
-
end .once
|
107
|
+
expect(@logger).to receive(:warning).with(/^foo\n/).once
|
113
108
|
5.times { @logger.deprecation_warning 'foo' }
|
114
109
|
end
|
115
110
|
|
116
111
|
it "ensures that deprecations from same origin are logged if their keys differ" do
|
117
|
-
@logger.
|
112
|
+
expect(@logger).to receive(:warning).with(/deprecated foo/).exactly(5).times()
|
118
113
|
5.times { |i| @logger.deprecation_warning('deprecated foo', :key => "foo#{i}") }
|
119
114
|
end
|
120
115
|
|
121
116
|
it "does not duplicate deprecations for a given key" do
|
122
|
-
@logger.
|
117
|
+
expect(@logger).to receive(:warning).with(/deprecated foo/).once
|
123
118
|
5.times { @logger.deprecation_warning('deprecated foo', :key => 'foo-msg') }
|
124
119
|
end
|
125
120
|
|
126
121
|
it "only logs the first 100 messages" do
|
127
122
|
(1..100).each { |i|
|
128
|
-
@logger.
|
129
|
-
msg =~ /^#{i}\n/
|
130
|
-
end .once
|
123
|
+
expect(@logger).to receive(:warning).with(/^#{i}\n/).once
|
131
124
|
# since the deprecation warning will only log each offending line once, we have to do some tomfoolery
|
132
125
|
# here in order to make it think each of these calls is coming from a unique call stack; we're basically
|
133
126
|
# mocking the method that it would normally use to find the call stack.
|
134
|
-
@logger.
|
127
|
+
expect(@logger).to receive(:get_deprecation_offender).and_return(["deprecation log count test ##{i}"])
|
135
128
|
@logger.deprecation_warning i
|
136
129
|
}
|
137
|
-
@logger.
|
130
|
+
expect(@logger).not_to receive(:warning).with(101)
|
138
131
|
@logger.deprecation_warning 101
|
139
132
|
end
|
140
133
|
end
|
@@ -154,25 +147,25 @@ describe Puppet::Util::Logging do
|
|
154
147
|
end
|
155
148
|
|
156
149
|
it "warns with file and line" do
|
157
|
-
@logger.
|
150
|
+
expect(@logger).to receive(:warning).with(/deprecated foo.*\(file: afile, line: 5\)/m)
|
158
151
|
@logger.puppet_deprecation_warning("deprecated foo", :file => 'afile', :line => 5)
|
159
152
|
end
|
160
153
|
|
161
154
|
it "warns keyed from file and line" do
|
162
|
-
@logger.
|
155
|
+
expect(@logger).to receive(:warning).with(/deprecated foo.*\(file: afile, line: 5\)/m).once
|
163
156
|
5.times do
|
164
157
|
@logger.puppet_deprecation_warning("deprecated foo", :file => 'afile', :line => 5)
|
165
158
|
end
|
166
159
|
end
|
167
160
|
|
168
161
|
it "warns with separate key only once regardless of file and line" do
|
169
|
-
@logger.
|
162
|
+
expect(@logger).to receive(:warning).with(/deprecated foo.*\(file: afile, line: 5\)/m).once
|
170
163
|
@logger.puppet_deprecation_warning("deprecated foo", :key => 'some_key', :file => 'afile', :line => 5)
|
171
164
|
@logger.puppet_deprecation_warning("deprecated foo", :key => 'some_key', :file => 'bfile', :line => 3)
|
172
165
|
end
|
173
166
|
|
174
167
|
it "warns with key but no file and line" do
|
175
|
-
@logger.
|
168
|
+
expect(@logger).to receive(:warning).with(/deprecated foo.*\(file: unknown, line: unknown\)/m)
|
176
169
|
@logger.puppet_deprecation_warning("deprecated foo", :key => 'some_key')
|
177
170
|
end
|
178
171
|
end
|
@@ -181,29 +174,24 @@ describe Puppet::Util::Logging do
|
|
181
174
|
before(:each) {
|
182
175
|
@logger.clear_deprecation_warnings
|
183
176
|
}
|
184
|
-
after(:each) {
|
185
|
-
# this is required because of bugs in Mocha whe tearing down expectations for each test
|
186
|
-
# why it works elsewhere is a mystery.
|
187
|
-
@logger.unstub(:send_log)
|
188
|
-
}
|
189
177
|
|
190
178
|
it "warns with file when only file is given" do
|
191
|
-
@logger.
|
179
|
+
expect(@logger).to receive(:send_log).with(:warning, /wet paint.*\(file: aFile\)/m)
|
192
180
|
@logger.warn_once('kind', 'wp', "wet paint", 'aFile')
|
193
181
|
end
|
194
182
|
|
195
183
|
it "warns with unknown file and line when only line is given" do
|
196
|
-
@logger.
|
184
|
+
expect(@logger).to receive(:send_log).with(:warning, /wet paint.*\(line: 5\)/m)
|
197
185
|
@logger.warn_once('kind', 'wp', "wet paint", nil, 5)
|
198
186
|
end
|
199
187
|
|
200
188
|
it "warns with file and line when both are given" do
|
201
|
-
@logger.
|
189
|
+
expect(@logger).to receive(:send_log).with(:warning, /wet paint.*\(file: aFile, line: 5\)/m)
|
202
190
|
@logger.warn_once('kind', 'wp', "wet paint",'aFile', 5)
|
203
191
|
end
|
204
192
|
|
205
193
|
it "warns once per key" do
|
206
|
-
@logger.
|
194
|
+
expect(@logger).to receive(:send_log).with(:warning, /wet paint.*/m).once
|
207
195
|
5.times do
|
208
196
|
@logger.warn_once('kind', 'wp', "wet paint")
|
209
197
|
end
|
@@ -211,7 +199,7 @@ describe Puppet::Util::Logging do
|
|
211
199
|
|
212
200
|
Puppet::Util::Log.eachlevel do |level|
|
213
201
|
it "can use log level #{level}" do
|
214
|
-
@logger.
|
202
|
+
expect(@logger).to receive(:send_log).with(level, /wet paint.*/m).once
|
215
203
|
5.times do
|
216
204
|
@logger.warn_once('kind', 'wp', "wet paint", nil, nil, level)
|
217
205
|
end
|
@@ -222,17 +210,21 @@ describe Puppet::Util::Logging do
|
|
222
210
|
describe "does not warn about undefined variables when disabled_warnings says so" do
|
223
211
|
let(:logger) { LoggingTester.new }
|
224
212
|
|
225
|
-
|
213
|
+
before(:each) do
|
226
214
|
Puppet.settings.initialize_global_settings
|
227
215
|
logger.clear_deprecation_warnings
|
228
216
|
Puppet[:disable_warnings] = ['undefined_variables']
|
229
|
-
|
217
|
+
end
|
218
|
+
|
219
|
+
after(:each) do
|
230
220
|
Puppet[:disable_warnings] = []
|
231
|
-
|
221
|
+
allow(Facter).to receive(:respond_to?).and_call_original()
|
222
|
+
allow(Facter).to receive(:debugging).and_call_original()
|
223
|
+
allow(logger).to receive(:send_log).and_call_original()
|
232
224
|
end
|
233
225
|
|
234
226
|
it "does not produce warning if kind is disabled" do
|
235
|
-
logger.
|
227
|
+
expect(logger).not_to receive(:send_log)
|
236
228
|
logger.warn_once('undefined_variables', 'wp', "wet paint")
|
237
229
|
end
|
238
230
|
end
|
@@ -240,17 +232,21 @@ describe Puppet::Util::Logging do
|
|
240
232
|
describe "warns about undefined variables when deprecations are in disabled_warnings" do
|
241
233
|
let(:logger) { LoggingTester.new }
|
242
234
|
|
243
|
-
|
235
|
+
before(:each) do
|
244
236
|
Puppet.settings.initialize_global_settings
|
245
237
|
logger.clear_deprecation_warnings
|
246
238
|
Puppet[:disable_warnings] = ['deprecations']
|
247
|
-
|
239
|
+
end
|
240
|
+
|
241
|
+
after(:each) do
|
248
242
|
Puppet[:disable_warnings] = []
|
249
|
-
|
243
|
+
allow(Facter).to receive(:respond_to?).and_call_original()
|
244
|
+
allow(Facter).to receive(:debugging).and_call_original()
|
245
|
+
allow(logger).to receive(:send_log).and_call_original()
|
250
246
|
end
|
251
247
|
|
252
248
|
it "produces warning even if deprecation warnings are disabled " do
|
253
|
-
logger.
|
249
|
+
expect(logger).to receive(:send_log).with(:warning, /wet paint/).once
|
254
250
|
logger.warn_once('undefined_variables', 'wp', "wet paint")
|
255
251
|
end
|
256
252
|
end
|
@@ -285,49 +281,49 @@ original
|
|
285
281
|
after :each do
|
286
282
|
# Unstub these calls as there is global code run after
|
287
283
|
# each spec that may reset the log level to debug
|
288
|
-
Facter.
|
289
|
-
Facter.
|
284
|
+
allow(Facter).to receive(:respond_to?).and_call_original()
|
285
|
+
allow(Facter).to receive(:debugging).and_call_original()
|
290
286
|
end
|
291
287
|
|
292
288
|
describe 'does support debugging' do
|
293
289
|
before :each do
|
294
|
-
Facter.
|
290
|
+
allow(Facter).to receive(:respond_to?).with(:debugging).and_return(true)
|
295
291
|
end
|
296
292
|
|
297
293
|
it 'enables Facter debugging when debug level' do
|
298
|
-
Facter.
|
294
|
+
allow(Facter).to receive(:debugging).with(true)
|
299
295
|
Puppet::Util::Log.level = :debug
|
300
296
|
end
|
301
297
|
|
302
298
|
it 'disables Facter debugging when not debug level' do
|
303
|
-
Facter.
|
299
|
+
allow(Facter).to receive(:debugging).with(false)
|
304
300
|
Puppet::Util::Log.level = :info
|
305
301
|
end
|
306
302
|
end
|
307
303
|
|
308
304
|
describe 'does support trace' do
|
309
305
|
before :each do
|
310
|
-
Facter.
|
306
|
+
allow(Facter).to receive(:respond_to?).with(:trace).and_return(true)
|
311
307
|
end
|
312
308
|
|
313
309
|
it 'enables Facter trace when enabled' do
|
314
|
-
Facter.
|
310
|
+
allow(Facter).to receive(:trace).with(true)
|
315
311
|
Puppet[:trace] = true
|
316
312
|
end
|
317
313
|
|
318
314
|
it 'disables Facter trace when disabled' do
|
319
|
-
Facter.
|
315
|
+
allow(Facter).to receive(:trace).with(false)
|
320
316
|
Puppet[:trace] = false
|
321
317
|
end
|
322
318
|
end
|
323
319
|
|
324
320
|
describe 'does support on_message' do
|
325
321
|
before :each do
|
326
|
-
Facter.
|
322
|
+
allow(Facter).to receive(:respond_to?).with(:on_message).and_return(true)
|
327
323
|
end
|
328
324
|
|
329
325
|
def setup(level, message)
|
330
|
-
Facter.
|
326
|
+
allow(Facter).to receive(:on_message).and_yield(level, message)
|
331
327
|
|
332
328
|
# Transform from Facter level to Puppet level
|
333
329
|
case level
|
@@ -341,11 +337,7 @@ original
|
|
341
337
|
level = :crit
|
342
338
|
end
|
343
339
|
|
344
|
-
Puppet::Util::Log.
|
345
|
-
expect(options[:level]).to eq(level)
|
346
|
-
expect(options[:message]).to eq(message)
|
347
|
-
expect(options[:source]).to eq('Facter')
|
348
|
-
end.once
|
340
|
+
allow(Puppet::Util::Log).to receive(:create).with(hash_including(level: level, message: message, source: 'Facter')).once
|
349
341
|
end
|
350
342
|
|
351
343
|
[:trace, :debug, :info, :warn, :error, :fatal].each do |level|
|