puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/application/apply'
@@ -11,7 +10,7 @@ describe Puppet::Application::Apply do
11
10
 
12
11
  before :each do
13
12
  @apply = Puppet::Application[:apply]
14
- Puppet::Util::Log.stubs(:newdestination)
13
+ allow(Puppet::Util::Log).to receive(:newdestination)
15
14
  Puppet[:reports] = "none"
16
15
  end
17
16
 
@@ -29,26 +28,25 @@ describe Puppet::Application::Apply do
29
28
  end
30
29
 
31
30
  it "should store argument value when calling handle_#{option}" do
32
- @apply.options.expects(:[]=).with(option, 'arg')
31
+ expect(@apply.options).to receive(:[]=).with(option, 'arg')
33
32
  @apply.send("handle_#{option}".to_sym, 'arg')
34
33
  end
35
34
  end
36
35
 
37
36
  it "should set the code to the provided code when :execute is used" do
38
- @apply.options.expects(:[]=).with(:code, 'arg')
37
+ expect(@apply.options).to receive(:[]=).with(:code, 'arg')
39
38
  @apply.send("handle_execute".to_sym, 'arg')
40
39
  end
41
40
 
42
41
  describe "when applying options" do
43
-
44
42
  it "should set the log destination with --logdest" do
45
- Puppet::Log.expects(:newdestination).with("console")
43
+ expect(Puppet::Log).to receive(:newdestination).with("console")
46
44
 
47
45
  @apply.handle_logdest("console")
48
46
  end
49
47
 
50
48
  it "should set the setdest options to true" do
51
- @apply.options.expects(:[]=).with(:setdest,true)
49
+ expect(@apply.options).to receive(:[]=).with(:setdest,true)
52
50
 
53
51
  @apply.handle_logdest("console")
54
52
  end
@@ -56,16 +54,16 @@ describe Puppet::Application::Apply do
56
54
 
57
55
  describe "during setup" do
58
56
  before :each do
59
- Puppet::Log.stubs(:newdestination)
60
- Puppet::FileBucket::Dipper.stubs(:new)
61
- STDIN.stubs(:read)
62
- Puppet::Transaction::Report.indirection.stubs(:cache_class=)
57
+ allow(Puppet::Log).to receive(:newdestination)
58
+ allow(Puppet::FileBucket::Dipper).to receive(:new)
59
+ allow(STDIN).to receive(:read)
60
+ allow(Puppet::Transaction::Report.indirection).to receive(:cache_class=)
63
61
  end
64
62
 
65
63
  describe "with --test" do
66
64
  it "should call setup_test" do
67
65
  @apply.options[:test] = true
68
- @apply.expects(:setup_test)
66
+ expect(@apply).to receive(:setup_test)
69
67
 
70
68
  @apply.setup
71
69
  end
@@ -88,20 +86,20 @@ describe Puppet::Application::Apply do
88
86
  end
89
87
 
90
88
  it "should set console as the log destination if logdest option wasn't provided" do
91
- Puppet::Log.expects(:newdestination).with(:console)
89
+ expect(Puppet::Log).to receive(:newdestination).with(:console)
92
90
 
93
91
  @apply.setup
94
92
  end
95
93
 
96
94
  it "sets the log destination if logdest is provided via settings" do
97
- Puppet::Log.expects(:newdestination).with("set_via_config")
95
+ expect(Puppet::Log).to receive(:newdestination).with("set_via_config")
98
96
  Puppet[:logdest] = "set_via_config"
99
97
 
100
98
  @apply.setup
101
99
  end
102
100
 
103
101
  it "should set INT trap" do
104
- Signal.expects(:trap).with(:INT)
102
+ expect(Signal).to receive(:trap).with(:INT)
105
103
 
106
104
  @apply.setup
107
105
  end
@@ -119,25 +117,24 @@ describe Puppet::Application::Apply do
119
117
  end
120
118
 
121
119
  it "should print puppet config if asked to in Puppet config" do
122
- Puppet.settings.stubs(:print_configs?).returns true
123
- Puppet.settings.expects(:print_configs).returns true
120
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
121
+ expect(Puppet.settings).to receive(:print_configs).and_return(true)
124
122
  expect { @apply.setup }.to exit_with 0
125
123
  end
126
124
 
127
125
  it "should exit after printing puppet config if asked to in Puppet config" do
128
- Puppet.settings.stubs(:print_configs?).returns(true)
126
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
129
127
  expect { @apply.setup }.to exit_with 1
130
128
  end
131
129
 
132
130
  it "should use :main, :puppetd, and :ssl" do
133
- Puppet.settings.unstub(:use)
134
- Puppet.settings.expects(:use).with(:main, :agent, :ssl)
131
+ expect(Puppet.settings).to receive(:use).with(:main, :agent, :ssl)
135
132
 
136
133
  @apply.setup
137
134
  end
138
135
 
139
136
  it "should tell the report handler to cache locally as yaml" do
140
- Puppet::Transaction::Report.indirection.expects(:cache_class=).with(:yaml)
137
+ expect(Puppet::Transaction::Report.indirection).to receive(:cache_class=).with(:yaml)
141
138
 
142
139
  @apply.setup
143
140
  end
@@ -169,14 +166,14 @@ describe Puppet::Application::Apply do
169
166
  it "should dispatch to 'apply' if it was called with 'apply'" do
170
167
  @apply.options[:catalog] = "foo"
171
168
 
172
- @apply.expects(:apply)
169
+ expect(@apply).to receive(:apply)
173
170
  @apply.run_command
174
171
  end
175
172
 
176
173
  it "should dispatch to main otherwise" do
177
- @apply.stubs(:options).returns({})
174
+ allow(@apply).to receive(:options).and_return({})
178
175
 
179
- @apply.expects(:main)
176
+ expect(@apply).to receive(:main)
180
177
  @apply.run_command
181
178
  end
182
179
 
@@ -197,17 +194,17 @@ describe Puppet::Application::Apply do
197
194
  Puppet::Node.indirection.save(@node)
198
195
 
199
196
  @catalog = Puppet::Resource::Catalog.new("testing", Puppet.lookup(:environments).get(Puppet[:environment]))
200
- @catalog.stubs(:to_ral).returns(@catalog)
197
+ allow(@catalog).to receive(:to_ral).and_return(@catalog)
201
198
 
202
- Puppet::Resource::Catalog.indirection.stubs(:find).returns(@catalog)
199
+ allow(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
203
200
 
204
- STDIN.stubs(:read)
201
+ allow(STDIN).to receive(:read)
205
202
 
206
- @transaction = stub('transaction')
207
- @catalog.stubs(:apply).returns(@transaction)
203
+ @transaction = double('transaction')
204
+ allow(@catalog).to receive(:apply).and_return(@transaction)
208
205
 
209
- Puppet::Util::Storage.stubs(:load)
210
- Puppet::Configurer.any_instance.stubs(:save_last_run_summary) # to prevent it from trying to write files
206
+ allow(Puppet::Util::Storage).to receive(:load)
207
+ allow_any_instance_of(Puppet::Configurer).to receive(:save_last_run_summary) # to prevent it from trying to write files
211
208
  end
212
209
 
213
210
  after :each do
@@ -224,23 +221,23 @@ describe Puppet::Application::Apply do
224
221
 
225
222
  it "should set the code to run from --code" do
226
223
  @apply.options[:code] = "code to run"
227
- Puppet.expects(:[]=).with(:code,"code to run")
224
+ expect(Puppet).to receive(:[]=).with(:code,"code to run")
228
225
 
229
226
  expect { @apply.main }.to exit_with 0
230
227
  end
231
228
 
232
229
  it "should set the code to run from STDIN if no arguments" do
233
- @apply.command_line.stubs(:args).returns([])
234
- STDIN.stubs(:read).returns("code to run")
230
+ allow(@apply.command_line).to receive(:args).and_return([])
231
+ allow(STDIN).to receive(:read).and_return("code to run")
235
232
 
236
- Puppet.expects(:[]=).with(:code,"code to run")
233
+ expect(Puppet).to receive(:[]=).with(:code,"code to run")
237
234
 
238
235
  expect { @apply.main }.to exit_with 0
239
236
  end
240
237
 
241
238
  it "should raise an error if a file is passed on command line and the file does not exist" do
242
239
  noexist = tmpfile('noexist.pp')
243
- @apply.command_line.stubs(:args).returns([noexist])
240
+ allow(@apply.command_line).to receive(:args).and_return([noexist])
244
241
  expect { @apply.main }.to raise_error(RuntimeError, "Could not find file #{noexist}")
245
242
  end
246
243
 
@@ -248,7 +245,7 @@ describe Puppet::Application::Apply do
248
245
  manifest = tmpfile('starwarsIV')
249
246
  FileUtils.touch(manifest)
250
247
 
251
- @apply.command_line.stubs(:args).returns([manifest, 'starwarsI', 'starwarsII'])
248
+ allow(@apply.command_line).to receive(:args).and_return([manifest, 'starwarsI', 'starwarsII'])
252
249
 
253
250
  expect { @apply.main }.to exit_with 0
254
251
 
@@ -258,13 +255,13 @@ describe Puppet::Application::Apply do
258
255
  end
259
256
 
260
257
  it "should splay" do
261
- @apply.expects(:splay)
258
+ expect(@apply).to receive(:splay)
262
259
 
263
260
  expect { @apply.main }.to exit_with 0
264
261
  end
265
262
 
266
263
  it "should raise an error if we can't find the node" do
267
- Puppet::Node.indirection.expects(:find).returns(nil)
264
+ expect(Puppet::Node.indirection).to receive(:find).and_return(nil)
268
265
 
269
266
  expect { @apply.main }.to raise_error(RuntimeError, /Could not find node/)
270
267
  end
@@ -275,63 +272,63 @@ describe Puppet::Application::Apply do
275
272
  File.open(classfile, 'w') { |c| c.puts 'class' }
276
273
  Puppet[:classfile] = classfile
277
274
 
278
- @node.expects(:classes=).with(['class'])
275
+ expect(@node).to receive(:classes=).with(['class'])
279
276
 
280
277
  expect { @apply.main }.to exit_with 0
281
278
  end
282
279
 
283
280
  it "should compile the catalog" do
284
- Puppet::Resource::Catalog.indirection.expects(:find).returns(@catalog)
281
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
285
282
 
286
283
  expect { @apply.main }.to exit_with 0
287
284
  end
288
285
 
289
286
  it 'should make the Puppet::Pops::Loaders available when applying the compiled catalog' do
290
- Puppet::Resource::Catalog.indirection.expects(:find).returns(@catalog)
291
- @apply.expects(:apply_catalog).with(@catalog) do
287
+ expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
288
+ expect(@apply).to receive(:apply_catalog) do |catalog|
289
+ expect(@catalog).to eq(@catalog)
292
290
  fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
293
291
  true
294
- end.returns(0)
292
+ end.and_return(0)
295
293
  expect { @apply.main }.to exit_with 0
296
294
  end
297
295
 
298
296
  it "should transform the catalog to ral" do
299
-
300
- @catalog.expects(:to_ral).returns(@catalog)
297
+ expect(@catalog).to receive(:to_ral).and_return(@catalog)
301
298
 
302
299
  expect { @apply.main }.to exit_with 0
303
300
  end
304
301
 
305
302
  it "should finalize the catalog" do
306
- @catalog.expects(:finalize)
303
+ expect(@catalog).to receive(:finalize)
307
304
 
308
305
  expect { @apply.main }.to exit_with 0
309
306
  end
310
307
 
311
308
  it "should not save the classes or resource file by default" do
312
- @catalog.expects(:write_class_file).never
313
- @catalog.expects(:write_resource_file).never
309
+ expect(@catalog).not_to receive(:write_class_file)
310
+ expect(@catalog).not_to receive(:write_resource_file)
314
311
  expect { @apply.main }.to exit_with 0
315
312
  end
316
313
 
317
314
  it "should save the classes and resources files when requested" do
318
315
  @apply.options[:write_catalog_summary] = true
319
316
 
320
- @catalog.expects(:write_class_file).once
321
- @catalog.expects(:write_resource_file).once
317
+ expect(@catalog).to receive(:write_class_file).once
318
+ expect(@catalog).to receive(:write_resource_file).once
322
319
 
323
320
  expect { @apply.main }.to exit_with 0
324
321
  end
325
322
 
326
323
  it "should call the prerun and postrun commands on a Configurer instance" do
327
- Puppet::Configurer.any_instance.expects(:execute_prerun_command).returns(true)
328
- Puppet::Configurer.any_instance.expects(:execute_postrun_command).returns(true)
324
+ expect_any_instance_of(Puppet::Configurer).to receive(:execute_prerun_command).and_return(true)
325
+ expect_any_instance_of(Puppet::Configurer).to receive(:execute_postrun_command).and_return(true)
329
326
 
330
327
  expect { @apply.main }.to exit_with 0
331
328
  end
332
329
 
333
330
  it "should apply the catalog" do
334
- @catalog.expects(:apply).returns(stub_everything('transaction'))
331
+ expect(@catalog).to receive(:apply).and_return(double('transaction'))
335
332
 
336
333
  expect { @apply.main }.to exit_with 0
337
334
  end
@@ -339,9 +336,9 @@ describe Puppet::Application::Apply do
339
336
  it "should save the last run summary" do
340
337
  Puppet[:noop] = false
341
338
  report = Puppet::Transaction::Report.new
342
- Puppet::Transaction::Report.stubs(:new).returns(report)
339
+ allow(Puppet::Transaction::Report).to receive(:new).and_return(report)
343
340
 
344
- Puppet::Configurer.any_instance.expects(:save_last_run_summary).with(report)
341
+ expect_any_instance_of(Puppet::Configurer).to receive(:save_last_run_summary).with(report)
345
342
  expect { @apply.main }.to exit_with 0
346
343
  end
347
344
 
@@ -373,7 +370,7 @@ describe Puppet::Application::Apply do
373
370
  end
374
371
 
375
372
  it "should raise an error if we can't find the facts" do
376
- Puppet::Node::Facts.indirection.expects(:find).returns(nil)
373
+ expect(Puppet::Node::Facts.indirection).to receive(:find).and_return(nil)
377
374
 
378
375
  expect { @apply.main }.to raise_error(RuntimeError, /Could not find facts/)
379
376
  end
@@ -386,30 +383,30 @@ describe Puppet::Application::Apply do
386
383
 
387
384
  it "should exit with report's computed exit status" do
388
385
  Puppet[:noop] = false
389
- Puppet::Transaction::Report.any_instance.stubs(:exit_status).returns(666)
386
+ allow_any_instance_of(Puppet::Transaction::Report).to receive(:exit_status).and_return(666)
390
387
 
391
388
  expect { @apply.main }.to exit_with 666
392
389
  end
393
390
 
394
391
  it "should exit with report's computed exit status, even if --noop is set" do
395
392
  Puppet[:noop] = true
396
- Puppet::Transaction::Report.any_instance.stubs(:exit_status).returns(666)
393
+ allow_any_instance_of(Puppet::Transaction::Report).to receive(:exit_status).and_return(666)
397
394
 
398
395
  expect { @apply.main }.to exit_with 666
399
396
  end
400
397
 
401
398
  it "should always exit with 0 if option is disabled" do
402
399
  Puppet[:noop] = false
403
- report = stub 'report', :exit_status => 666
404
- @transaction.stubs(:report).returns(report)
400
+ report = double('report', :exit_status => 666)
401
+ allow(@transaction).to receive(:report).and_return(report)
405
402
 
406
403
  expect { @apply.main }.to exit_with 0
407
404
  end
408
405
 
409
406
  it "should always exit with 0 if --noop" do
410
407
  Puppet[:noop] = true
411
- report = stub 'report', :exit_status => 666
412
- @transaction.stubs(:report).returns(report)
408
+ report = double('report', :exit_status => 666)
409
+ allow(@transaction).to receive(:report).and_return(report)
413
410
 
414
411
  expect { @apply.main }.to exit_with 0
415
412
  end
@@ -429,23 +426,23 @@ describe Puppet::Application::Apply do
429
426
  it "should read the catalog in from disk if a file name is provided" do
430
427
  @apply.options[:catalog] = temporary_catalog
431
428
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
432
- Puppet::Resource::Catalog.stubs(:convert_from).with(:json,'"something"').returns(catalog)
429
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:json,'"something"').and_return(catalog)
433
430
  @apply.apply
434
431
  end
435
432
 
436
433
  it "should read the catalog in from stdin if '-' is provided" do
437
434
  @apply.options[:catalog] = "-"
438
- $stdin.expects(:read).returns '"something"'
435
+ expect($stdin).to receive(:read).and_return('"something"')
439
436
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
440
- Puppet::Resource::Catalog.stubs(:convert_from).with(:json,'"something"').returns(catalog)
437
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:json,'"something"').and_return(catalog)
441
438
  @apply.apply
442
439
  end
443
440
 
444
441
  it "should deserialize the catalog from the default format" do
445
442
  @apply.options[:catalog] = temporary_catalog
446
- Puppet::Resource::Catalog.stubs(:default_format).returns :rot13_piglatin
443
+ allow(Puppet::Resource::Catalog).to receive(:default_format).and_return(:rot13_piglatin)
447
444
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
448
- Puppet::Resource::Catalog.stubs(:convert_from).with(:rot13_piglatin,'"something"').returns(catalog)
445
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:rot13_piglatin,'"something"').and_return(catalog)
449
446
  @apply.apply
450
447
  end
451
448
 
@@ -457,12 +454,12 @@ describe Puppet::Application::Apply do
457
454
  it "should convert the catalog to a RAL catalog and use a Configurer instance to apply it" do
458
455
  @apply.options[:catalog] = temporary_catalog
459
456
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
460
- Puppet::Resource::Catalog.stubs(:convert_from).with(:json,'"something"').returns catalog
461
- catalog.expects(:to_ral).returns "mycatalog"
457
+ allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:json,'"something"').and_return(catalog)
458
+ expect(catalog).to receive(:to_ral).and_return("mycatalog")
462
459
 
463
- configurer = stub 'configurer'
464
- Puppet::Configurer.expects(:new).returns configurer
465
- configurer.expects(:run).
460
+ configurer = double('configurer')
461
+ expect(Puppet::Configurer).to receive(:new).and_return(configurer)
462
+ expect(configurer).to receive(:run).
466
463
  with(:catalog => "mycatalog", :pluginsync => false)
467
464
 
468
465
  @apply.apply
@@ -471,11 +468,13 @@ describe Puppet::Application::Apply do
471
468
  it 'should make the Puppet::Pops::Loaders available when applying a catalog' do
472
469
  @apply.options[:catalog] = temporary_catalog
473
470
  catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
474
- @apply.expects(:read_catalog).with('something') do
471
+ expect(@apply).to receive(:read_catalog) do |arg|
472
+ expect(arg).to eq('"something"')
475
473
  fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
476
474
  true
477
- end.returns(catalog)
478
- @apply.expects(:apply_catalog).with(catalog) do
475
+ end.and_return(catalog)
476
+ expect(@apply).to receive(:apply_catalog) do |cat|
477
+ expect(cat).to eq(catalog)
479
478
  fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
480
479
  true
481
480
  end
@@ -505,7 +504,7 @@ describe Puppet::Application::Apply do
505
504
  Puppet.settings[:classfile] = classfile
506
505
 
507
506
  #We don't actually need the resource to do anything, we are using it's properties in other parts of the workflow.
508
- Puppet::Util::Execution.stubs(:execute)
507
+ allow(Puppet::Util::Execution).to receive(:execute)
509
508
 
510
509
  expect { @apply.main }.to exit_with 0
511
510
 
@@ -519,7 +518,7 @@ describe Puppet::Application::Apply do
519
518
  describe "apply_catalog" do
520
519
  it "should call the configurer with the catalog" do
521
520
  catalog = "I am a catalog"
522
- Puppet::Configurer.any_instance.expects(:run).
521
+ expect_any_instance_of(Puppet::Configurer).to receive(:run).
523
522
  with(:catalog => catalog, :pluginsync => false)
524
523
  @apply.send(:apply_catalog, catalog)
525
524
  end
@@ -527,7 +526,7 @@ describe Puppet::Application::Apply do
527
526
 
528
527
  it "should honor the catalog_cache_terminus setting" do
529
528
  Puppet.settings[:catalog_cache_terminus] = "json"
530
- Puppet::Resource::Catalog.indirection.expects(:cache_class=).with(:json)
529
+ expect(Puppet::Resource::Catalog.indirection).to receive(:cache_class=).with(:json)
531
530
 
532
531
  @apply.initialize_app_defaults
533
532
  @apply.setup
@@ -1,11 +1,10 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/application/cert'
4
3
 
5
4
  describe Puppet::Application::Cert => true do
6
5
  before :each do
7
6
  @cert_app = Puppet::Application[:cert]
8
- Puppet::Util::Log.stubs(:newdestination)
7
+ allow(Puppet::Util::Log).to receive(:newdestination)
9
8
  end
10
9
 
11
10
  it "should operate in master run_mode" do
@@ -83,55 +82,55 @@ describe Puppet::Application::Cert => true do
83
82
  describe "during setup" do
84
83
 
85
84
  before :each do
86
- Puppet::Log.stubs(:newdestination)
87
- Puppet::SSL::Host.stubs(:ca_location=)
88
- Puppet::SSL::CertificateAuthority.stubs(:new)
85
+ allow(Puppet::Log).to receive(:newdestination)
86
+ allow(Puppet::SSL::Host).to receive(:ca_location=)
87
+ allow(Puppet::SSL::CertificateAuthority).to receive(:new)
89
88
  end
90
89
 
91
90
  it "should set console as the log destination" do
92
- Puppet::Log.expects(:newdestination).with(:console)
91
+ expect(Puppet::Log).to receive(:newdestination).with(:console)
93
92
 
94
93
  @cert_app.setup
95
94
  end
96
95
 
97
96
  it "should print puppet config if asked to in Puppet config" do
98
- Puppet.settings.stubs(:print_configs?).returns(true)
99
- Puppet.settings.expects(:print_configs).returns true
97
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
98
+ expect(Puppet.settings).to receive(:print_configs).and_return(true)
100
99
  expect { @cert_app.setup }.to exit_with 0
101
100
  end
102
101
 
103
102
  it "should exit after printing puppet config if asked to in Puppet config" do
104
- Puppet.settings.stubs(:print_configs?).returns(true)
103
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
105
104
  expect { @cert_app.setup }.to exit_with 1
106
105
  end
107
106
 
108
107
  it "should set the CA location to 'only'" do
109
- Puppet::SSL::Host.expects(:ca_location=).with(:only)
108
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:only)
110
109
 
111
110
  @cert_app.setup
112
111
  end
113
112
 
114
113
  it "should create a new certificate authority" do
115
- Puppet::SSL::CertificateAuthority.expects(:new)
114
+ expect(Puppet::SSL::CertificateAuthority).to receive(:new)
116
115
 
117
116
  @cert_app.setup
118
117
  end
119
118
 
120
119
  it "should set the ca_location to :local if the cert_mode is generate" do
121
120
  @cert_app.subcommand = 'generate'
122
- Puppet::SSL::Host.expects(:ca_location=).with(:local)
121
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:local)
123
122
  @cert_app.setup
124
123
  end
125
124
 
126
125
  it "should set the ca_location to :local if the cert_mode is destroy" do
127
126
  @cert_app.subcommand = 'destroy'
128
- Puppet::SSL::Host.expects(:ca_location=).with(:local)
127
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:local)
129
128
  @cert_app.setup
130
129
  end
131
130
 
132
131
  it "should set the ca_location to :only if the cert_mode is print" do
133
132
  @cert_app.subcommand = 'print'
134
- Puppet::SSL::Host.expects(:ca_location=).with(:only)
133
+ expect(Puppet::SSL::Host).to receive(:ca_location=).with(:only)
135
134
  @cert_app.setup
136
135
  end
137
136
  end
@@ -139,15 +138,15 @@ describe Puppet::Application::Cert => true do
139
138
  describe "when running" do
140
139
  before :each do
141
140
  @cert_app.all = false
142
- @ca = stub_everything( 'ca', :waiting? => ['unsigned-node'] )
141
+ @ca = double('ca', :waiting? => ['unsigned-node'])
143
142
  @cert_app.ca = @ca
144
- @cert_app.command_line.stubs(:args).returns([])
145
- @iface = stub_everything 'iface'
146
- Puppet::SSL::CertificateAuthority::Interface.stubs(:new).returns(@iface)
143
+ allow(@cert_app.command_line).to receive(:args).and_return([])
144
+ @iface = double('iface', apply: nil)
145
+ allow(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).and_return(@iface)
147
146
  end
148
147
 
149
148
  it "should delegate to the CertificateAuthority" do
150
- @iface.expects(:apply)
149
+ expect(@iface).to receive(:apply)
151
150
 
152
151
  @cert_app.main
153
152
  end
@@ -155,61 +154,55 @@ describe Puppet::Application::Cert => true do
155
154
  it "should delegate with :all if option --all was given" do
156
155
  @cert_app.handle_all(0)
157
156
 
158
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).returns(@iface).with { |cert_mode,to| to[:to] == :all }
157
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(anything, hash_including(to: :all)).and_return(@iface)
159
158
 
160
159
  @cert_app.main
161
160
  end
162
161
 
163
162
  it "should delegate to ca.apply with the hosts given on command line" do
164
- @cert_app.command_line.stubs(:args).returns(["host"])
163
+ allow(@cert_app.command_line).to receive(:args).and_return(["host"])
165
164
 
166
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).returns(@iface).with { |cert_mode,to| to[:to] == ["host"]}
165
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(anything, hash_including(to: ["host"])).and_return(@iface)
167
166
 
168
167
  @cert_app.main
169
168
  end
170
169
 
171
170
  it "should send the currently set digest" do
172
- @cert_app.command_line.stubs(:args).returns(["host"])
171
+ allow(@cert_app.command_line).to receive(:args).and_return(["host"])
173
172
  @cert_app.handle_digest(:digest)
174
173
 
175
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).returns(@iface).with { |cert_mode,to| to[:digest] == :digest}
174
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(anything, hash_including(digest: :digest)).and_return(@iface)
176
175
 
177
176
  @cert_app.main
178
177
  end
179
178
 
180
179
  it "should revoke cert if cert_mode is clean" do
181
180
  @cert_app.subcommand = :destroy
182
- @cert_app.command_line.stubs(:args).returns(["host"])
181
+ allow(@cert_app.command_line).to receive(:args).and_return(["host"])
183
182
 
184
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).returns(@iface).with { |cert_mode,to| cert_mode == :revoke }
185
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).returns(@iface).with { |cert_mode,to| cert_mode == :destroy }
183
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(:revoke, anything).and_return(@iface)
184
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(:destroy, anything).and_return(@iface)
186
185
 
187
186
  @cert_app.main
188
187
  end
189
188
 
190
189
  it "should not revoke cert if node does not have a signed certificate" do
191
190
  @cert_app.subcommand = :destroy
192
- @cert_app.command_line.stubs(:args).returns(["unsigned-node"])
191
+ allow(@cert_app.command_line).to receive(:args).and_return(["unsigned-node"])
193
192
 
194
- Puppet::SSL::CertificateAuthority::Interface.unstub(:new)
195
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).with(:revoke, anything).never
196
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).with(:destroy, {:to => ['unsigned-node'], :digest => nil}).returns(@iface)
193
+ allow(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).and_call_original
194
+ expect(Puppet::SSL::CertificateAuthority::Interface).not_to receive(:new).with(:revoke, anything)
195
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(:destroy, {:to => ['unsigned-node'], :digest => nil}).and_return(@iface)
197
196
 
198
197
  @cert_app.main
199
198
  end
200
199
 
201
200
  it "should only revoke signed certificate and destroy certificate signing requests" do
202
201
  @cert_app.subcommand = :destroy
203
- @cert_app.command_line.stubs(:args).returns(["host","unsigned-node"])
202
+ allow(@cert_app.command_line).to receive(:args).and_return(["host","unsigned-node"])
204
203
 
205
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).returns(@iface).with do |cert_mode,to|
206
- cert_mode == :revoke &&
207
- to[:to] == ["host"]
208
- end
209
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).returns(@iface).with do |cert_mode,to|
210
- cert_mode == :destroy &&
211
- to[:to] == ["host","unsigned-node"]
212
- end
204
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(:revoke, hash_including(to: ["host"])).and_return(@iface)
205
+ expect(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).with(:destroy, hash_including(to: ["host", "unsigned-node"])).and_return(@iface)
213
206
 
214
207
  @cert_app.main
215
208
  end
@@ -218,10 +211,10 @@ describe Puppet::Application::Cert => true do
218
211
  @cert_app.subcommand = :destroy
219
212
  @cert_app.all = true
220
213
 
221
- Puppet::SSL::CertificateAuthority::Interface.unstub(:new)
222
- Puppet::SSL::CertificateAuthority::Interface.expects(:new).never
214
+ allow(Puppet::SSL::CertificateAuthority::Interface).to receive(:new).and_call_original
215
+ expect(Puppet::SSL::CertificateAuthority::Interface).not_to receive(:new)
223
216
 
224
- Puppet.expects(:log_exception).with {|e| e.message == "Refusing to destroy all certs, provide an explicit list of certs to destroy"}
217
+ expect(Puppet).to receive(:log_exception) {|e| expect(e.message).to eq("Refusing to destroy all certs, provide an explicit list of certs to destroy")}
225
218
 
226
219
  expect { @cert_app.main }.to exit_with(24)
227
220
  end
@@ -230,7 +223,7 @@ describe Puppet::Application::Cert => true do
230
223
  describe "when identifying subcommands" do
231
224
  before :each do
232
225
  @cert_app.all = false
233
- @ca = stub_everything 'ca'
226
+ @ca = double('ca')
234
227
  @cert_app.ca = @ca
235
228
  end
236
229
 
@@ -245,7 +238,7 @@ describe Puppet::Application::Cert => true do
245
238
  it "should recognise '#{option}'" do
246
239
  args = [option, "fun.example.com"]
247
240
 
248
- @cert_app.command_line.stubs(:args).returns(args)
241
+ allow(@cert_app.command_line).to receive(:args).and_return(args)
249
242
  @cert_app.parse_options
250
243
  expect(@cert_app.subcommand).to eq(cmd.to_sym)
251
244
 
@@ -258,7 +251,7 @@ describe Puppet::Application::Cert => true do
258
251
  it "should recognise the '#{ugly}' option as destroy" do
259
252
  args = [ugly, "fun.example.com"]
260
253
 
261
- @cert_app.command_line.stubs(:args).returns(args)
254
+ allow(@cert_app.command_line).to receive(:args).and_return(args)
262
255
  @cert_app.parse_options
263
256
  expect(@cert_app.subcommand).to eq(:destroy)
264
257
 
@@ -268,9 +261,9 @@ describe Puppet::Application::Cert => true do
268
261
 
269
262
  it "should print help and exit if there is no subcommand" do
270
263
  args = []
271
- @cert_app.command_line.stubs(:args).returns(args)
272
- @cert_app.stubs(:help).returns("I called for help!")
273
- @cert_app.expects(:puts).with("I called for help!")
264
+ allow(@cert_app.command_line).to receive(:args).and_return(args)
265
+ allow(@cert_app).to receive(:help).and_return("I called for help!")
266
+ expect(@cert_app).to receive(:puts).with("I called for help!")
274
267
 
275
268
  expect { @cert_app.parse_options }.to exit_with 0
276
269
  expect(@cert_app.subcommand).to be_nil