puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/indirector/node/exec'
@@ -6,7 +5,7 @@ require 'puppet/indirector/request'
6
5
 
7
6
  describe Puppet::Node::Exec do
8
7
  before do
9
- @indirection = mock 'indirection'
8
+ @indirection = double('indirection')
10
9
  Puppet.settings[:external_nodes] = File.expand_path("/echo")
11
10
  @searcher = Puppet::Node::Exec.new
12
11
  end
@@ -19,7 +18,7 @@ describe Puppet::Node::Exec do
19
18
 
20
19
  it "should throw an exception if no external node command is set" do
21
20
  Puppet[:external_nodes] = "none"
22
- expect { @searcher.find(stub('request', :key => "foo")) }.to raise_error(ArgumentError)
21
+ expect { @searcher.find(double('request', :key => "foo")) }.to raise_error(ArgumentError)
23
22
  end
24
23
  end
25
24
 
@@ -27,11 +26,12 @@ describe Puppet::Node::Exec do
27
26
  let(:testing_env) { Puppet::Node::Environment.create(:testing, []) }
28
27
  let(:other_env) { Puppet::Node::Environment.create(:other, []) }
29
28
  let(:request) { Puppet::Indirector::Request.new(:node, :find, @name, nil) }
29
+
30
30
  before do
31
31
  @name = "yay"
32
32
  @node = Puppet::Node.new(@name)
33
- @node.stubs(:fact_merge)
34
- Puppet::Node.expects(:new).with(@name).returns(@node)
33
+ allow(@node).to receive(:fact_merge)
34
+ expect(Puppet::Node).to receive(:new).with(@name).and_return(@node)
35
35
  @result = {}
36
36
  # Use a local variable so the reference is usable in the execute definition.
37
37
  result = @result
@@ -68,7 +68,7 @@ describe Puppet::Node::Exec do
68
68
  it "should merge facts from the request if supplied" do
69
69
  facts = Puppet::Node::Facts.new('test', 'foo' => 'bar')
70
70
  request.options[:facts] = facts
71
- @node.expects(:fact_merge).with(facts)
71
+ expect(@node).to receive(:fact_merge).with(facts)
72
72
  @searcher.find(request)
73
73
  end
74
74
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/indirector/node/ldap'
@@ -11,34 +10,34 @@ describe Puppet::Node::Ldap do
11
10
  let(:facts) { Puppet::Node::Facts.new(nodename, fact_values) }
12
11
 
13
12
  before do
14
- Puppet::Node::Facts.indirection.stubs(:find).with(nodename, :environment => environment).returns(facts)
13
+ allow(Puppet::Node::Facts.indirection).to receive(:find).with(nodename, :environment => environment).and_return(facts)
15
14
  end
16
15
 
17
16
  describe "when searching for a single node" do
18
17
  let(:request) { Puppet::Indirector::Request.new(:node, :find, nodename, nil, :environment => environment) }
19
18
 
20
19
  it "should convert the hostname into a search filter" do
21
- node_indirection.stubs(:ldap_entry_to_hash).returns({})
22
- entry = stub 'entry', :dn => 'cn=mynode.domain.com,ou=hosts,dc=madstop,dc=com', :vals => %w{}
23
- node_indirection.expects(:ldapsearch).with("(&(objectclass=puppetClient)(cn=#{nodename}))").yields entry
20
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({})
21
+ entry = double('entry', :dn => 'cn=mynode.domain.com,ou=hosts,dc=madstop,dc=com', :vals => %w{})
22
+ expect(node_indirection).to receive(:ldapsearch).with("(&(objectclass=puppetClient)(cn=#{nodename}))").and_yield(entry)
24
23
  node_indirection.name2hash(nodename)
25
24
  end
26
25
 
27
26
  it "should convert any found entry into a hash" do
28
- node_indirection.stubs(:ldap_entry_to_hash).returns({})
29
- entry = stub 'entry', :dn => 'cn=mynode.domain.com,ou=hosts,dc=madstop,dc=com', :vals => %w{}
30
- node_indirection.expects(:ldapsearch).with("(&(objectclass=puppetClient)(cn=#{nodename}))").yields entry
27
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({})
28
+ entry = double('entry', :dn => 'cn=mynode.domain.com,ou=hosts,dc=madstop,dc=com', :vals => %w{})
29
+ expect(node_indirection).to receive(:ldapsearch).with("(&(objectclass=puppetClient)(cn=#{nodename}))").and_yield(entry)
31
30
  myhash = {"myhash" => true}
32
- node_indirection.expects(:entry2hash).with(entry).returns myhash
31
+ expect(node_indirection).to receive(:entry2hash).with(entry).and_return(myhash)
33
32
  expect(node_indirection.name2hash(nodename)).to eq(myhash)
34
33
  end
35
34
 
36
35
  # This heavily tests our entry2hash method, so we don't have to stub out the stupid entry information any more.
37
36
  describe "when an ldap entry is found" do
38
37
  before do
39
- @entry = stub 'entry', :dn => 'cn=mynode,ou=hosts,dc=madstop,dc=com', :vals => %w{}
40
- node_indirection.stubs(:ldap_entry_to_hash).returns({})
41
- node_indirection.stubs(:ldapsearch).yields @entry
38
+ @entry = double('entry', :dn => 'cn=mynode,ou=hosts,dc=madstop,dc=com', :vals => %w{})
39
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({})
40
+ allow(node_indirection).to receive(:ldapsearch).and_yield(@entry)
42
41
  end
43
42
 
44
43
  it "should convert the entry to a hash" do
@@ -54,114 +53,114 @@ describe Puppet::Node::Ldap do
54
53
  end
55
54
 
56
55
  it "should add all of the entry's classes to the hash" do
57
- @entry.stubs(:vals).with("puppetclass").returns %w{one two}
56
+ allow(@entry).to receive(:vals).with("puppetclass").and_return(%w{one two})
58
57
  expect(node_indirection.entry2hash(@entry)[:classes]).to eq(%w{one two})
59
58
  end
60
59
 
61
60
  it "should deduplicate class values" do
62
- node_indirection.stubs(:ldap_entry_to_hash).returns({})
63
- node_indirection.stubs(:class_attributes).returns(%w{one two})
64
- @entry.stubs(:vals).with("one").returns(%w{a b})
65
- @entry.stubs(:vals).with("two").returns(%w{b c})
61
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({})
62
+ allow(node_indirection).to receive(:class_attributes).and_return(%w{one two})
63
+ allow(@entry).to receive(:vals).with("one").and_return(%w{a b})
64
+ allow(@entry).to receive(:vals).with("two").and_return(%w{b c})
66
65
  expect(node_indirection.entry2hash(@entry)[:classes]).to eq(%w{a b c})
67
66
  end
68
67
 
69
68
  it "should add the entry's environment to the hash" do
70
- node_indirection.stubs(:ldap_entry_to_hash).returns(:environment => %w{production})
69
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return(:environment => %w{production})
71
70
  expect(node_indirection.entry2hash(@entry)[:environment]).to eq("production")
72
71
  end
73
72
 
74
73
  it "should add all stacked parameters as parameters in the hash" do
75
- @entry.stubs(:vals).with("puppetvar").returns(%w{one=two three=four})
74
+ allow(@entry).to receive(:vals).with("puppetvar").and_return(%w{one=two three=four})
76
75
  result = node_indirection.entry2hash(@entry)
77
76
  expect(result[:parameters]["one"]).to eq("two")
78
77
  expect(result[:parameters]["three"]).to eq("four")
79
78
  end
80
79
 
81
80
  it "should not add the stacked parameter as a normal parameter" do
82
- @entry.stubs(:vals).with("puppetvar").returns(%w{one=two three=four})
83
- node_indirection.stubs(:ldap_entry_to_hash).returns("puppetvar" => %w{one=two three=four})
81
+ allow(@entry).to receive(:vals).with("puppetvar").and_return(%w{one=two three=four})
82
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return("puppetvar" => %w{one=two three=four})
84
83
  expect(node_indirection.entry2hash(@entry)[:parameters]["puppetvar"]).to be_nil
85
84
  end
86
85
 
87
86
  it "should add all other attributes as parameters in the hash" do
88
- node_indirection.stubs(:ldap_entry_to_hash).returns("foo" => %w{one two})
87
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return("foo" => %w{one two})
89
88
  expect(node_indirection.entry2hash(@entry)[:parameters]["foo"]).to eq(%w{one two})
90
89
  end
91
90
 
92
91
  it "should return single-value parameters as strings, not arrays" do
93
- node_indirection.stubs(:ldap_entry_to_hash).returns("foo" => %w{one})
92
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return("foo" => %w{one})
94
93
  expect(node_indirection.entry2hash(@entry)[:parameters]["foo"]).to eq("one")
95
94
  end
96
95
 
97
96
  it "should convert 'true' values to the boolean 'true'" do
98
- node_indirection.stubs(:ldap_entry_to_hash).returns({"one" => ["true"]})
97
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({"one" => ["true"]})
99
98
  expect(node_indirection.entry2hash(@entry)[:parameters]["one"]).to eq(true)
100
99
  end
101
100
 
102
101
  it "should convert 'false' values to the boolean 'false'" do
103
- node_indirection.stubs(:ldap_entry_to_hash).returns({"one" => ["false"]})
102
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({"one" => ["false"]})
104
103
  expect(node_indirection.entry2hash(@entry)[:parameters]["one"]).to eq(false)
105
104
  end
106
105
 
107
106
  it "should convert 'true' values to the boolean 'true' inside an array" do
108
- node_indirection.stubs(:ldap_entry_to_hash).returns({"one" => ["true", "other"]})
107
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({"one" => ["true", "other"]})
109
108
  expect(node_indirection.entry2hash(@entry)[:parameters]["one"]).to eq([true, "other"])
110
109
  end
111
110
 
112
111
  it "should convert 'false' values to the boolean 'false' inside an array" do
113
- node_indirection.stubs(:ldap_entry_to_hash).returns({"one" => ["false", "other"]})
112
+ allow(node_indirection).to receive(:ldap_entry_to_hash).and_return({"one" => ["false", "other"]})
114
113
  expect(node_indirection.entry2hash(@entry)[:parameters]["one"]).to eq([false, "other"])
115
114
  end
116
115
 
117
116
  it "should add the parent's name if present" do
118
- @entry.stubs(:vals).with("parentnode").returns(%w{foo})
117
+ allow(@entry).to receive(:vals).with("parentnode").and_return(%w{foo})
119
118
  expect(node_indirection.entry2hash(@entry)[:parent]).to eq("foo")
120
119
  end
121
120
 
122
121
  it "should fail if more than one parent is specified" do
123
- @entry.stubs(:vals).with("parentnode").returns(%w{foo})
122
+ allow(@entry).to receive(:vals).with("parentnode").and_return(%w{foo})
124
123
  expect(node_indirection.entry2hash(@entry)[:parent]).to eq("foo")
125
124
  end
126
125
  end
127
126
 
128
127
  it "should search first for the provided key" do
129
- node_indirection.expects(:name2hash).with("mynode.domain.com").returns({})
128
+ expect(node_indirection).to receive(:name2hash).with("mynode.domain.com").and_return({})
130
129
  node_indirection.find(request)
131
130
  end
132
131
 
133
132
  it "should search for the short version of the provided key if the key looks like a hostname and no results are found for the key itself" do
134
- node_indirection.expects(:name2hash).with("mynode.domain.com").returns(nil)
135
- node_indirection.expects(:name2hash).with("mynode").returns({})
133
+ expect(node_indirection).to receive(:name2hash).with("mynode.domain.com").and_return(nil)
134
+ expect(node_indirection).to receive(:name2hash).with("mynode").and_return({})
136
135
  node_indirection.find(request)
137
136
  end
138
137
 
139
138
  it "should search for default information if no information can be found for the key" do
140
- node_indirection.expects(:name2hash).with("mynode.domain.com").returns(nil)
141
- node_indirection.expects(:name2hash).with("mynode").returns(nil)
142
- node_indirection.expects(:name2hash).with("default").returns({})
139
+ expect(node_indirection).to receive(:name2hash).with("mynode.domain.com").and_return(nil)
140
+ expect(node_indirection).to receive(:name2hash).with("mynode").and_return(nil)
141
+ expect(node_indirection).to receive(:name2hash).with("default").and_return({})
143
142
  node_indirection.find(request)
144
143
  end
145
144
 
146
145
  it "should return nil if no results are found in ldap" do
147
- node_indirection.stubs(:name2hash).returns nil
146
+ allow(node_indirection).to receive(:name2hash).and_return(nil)
148
147
  expect(node_indirection.find(request)).to be_nil
149
148
  end
150
149
 
151
150
  it "should return a node object if results are found in ldap" do
152
- node_indirection.stubs(:name2hash).returns({})
151
+ allow(node_indirection).to receive(:name2hash).and_return({})
153
152
  expect(node_indirection.find(request)).to be
154
153
  end
155
154
 
156
155
  describe "and node information is found in LDAP" do
157
156
  before do
158
157
  @result = {}
159
- node_indirection.stubs(:name2hash).returns @result
158
+ allow(node_indirection).to receive(:name2hash).and_return(@result)
160
159
  end
161
160
 
162
161
  it "should create the node with the correct name, even if it was found by a different name" do
163
- node_indirection.expects(:name2hash).with(nodename).returns nil
164
- node_indirection.expects(:name2hash).with("mynode").returns @result
162
+ expect(node_indirection).to receive(:name2hash).with(nodename).and_return(nil)
163
+ expect(node_indirection).to receive(:name2hash).with("mynode").and_return(@result)
165
164
 
166
165
  expect(node_indirection.find(request).name).to eq(nodename)
167
166
  end
@@ -180,7 +179,7 @@ describe Puppet::Node::Ldap do
180
179
 
181
180
  it "should set the node's environment to the environment of the results" do
182
181
  result_env = Puppet::Node::Environment.create(:local_test, [])
183
- Puppet::Node::Facts.indirection.stubs(:find).with(nodename, :environment => result_env).returns(facts)
182
+ allow(Puppet::Node::Facts.indirection).to receive(:find).with(nodename, :environment => result_env).and_return(facts)
184
183
  @result[:environment] = "local_test"
185
184
 
186
185
  Puppet.override(:environments => Puppet::Environments::Static.new(result_env)) do
@@ -200,14 +199,14 @@ describe Puppet::Node::Ldap do
200
199
 
201
200
  it "should merge facts from the request if supplied" do
202
201
  request.options[:facts] = request_facts
203
- Puppet::Node::Facts.stubs(:find) { indirection_facts }
202
+ allow(Puppet::Node::Facts).to receive(:find).and_return(indirection_facts)
204
203
 
205
204
  expect(node_indirection.find(request).parameters).to include(request_facts.values)
206
205
  expect(node_indirection.find(request).facts).to eq(request_facts)
207
206
  end
208
207
 
209
208
  it "should find facts if none are supplied" do
210
- Puppet::Node::Facts.indirection.stubs(:find).with(nodename, :environment => environment).returns(indirection_facts)
209
+ allow(Puppet::Node::Facts.indirection).to receive(:find).with(nodename, :environment => environment).and_return(indirection_facts)
211
210
  request.options.delete(:facts)
212
211
 
213
212
  expect(node_indirection.find(request).parameters).to include(indirection_facts.values)
@@ -232,17 +231,17 @@ describe Puppet::Node::Ldap do
232
231
  @parent = {:classes => [], :parameters => {}}
233
232
  @parent_parent = {:classes => [], :parameters => {}}
234
233
 
235
- node_indirection.stubs(:name2hash).with(nodename).returns(@entry)
236
- node_indirection.stubs(:name2hash).with('parent').returns(@parent)
237
- node_indirection.stubs(:name2hash).with('parent_parent').returns(@parent_parent)
234
+ allow(node_indirection).to receive(:name2hash).with(nodename).and_return(@entry)
235
+ allow(node_indirection).to receive(:name2hash).with('parent').and_return(@parent)
236
+ allow(node_indirection).to receive(:name2hash).with('parent_parent').and_return(@parent_parent)
238
237
 
239
- node_indirection.stubs(:parent_attribute).returns(:parent)
238
+ allow(node_indirection).to receive(:parent_attribute).and_return(:parent)
240
239
  end
241
240
 
242
241
  it "should search for the parent node" do
243
242
  @entry[:parent] = "parent"
244
- node_indirection.expects(:name2hash).with(nodename).returns @entry
245
- node_indirection.expects(:name2hash).with('parent').returns @parent
243
+ expect(node_indirection).to receive(:name2hash).with(nodename).and_return(@entry)
244
+ expect(node_indirection).to receive(:name2hash).with('parent').and_return(@parent)
246
245
 
247
246
  node_indirection.find(request)
248
247
  end
@@ -250,7 +249,7 @@ describe Puppet::Node::Ldap do
250
249
  it "should fail if the parent cannot be found" do
251
250
  @entry[:parent] = "parent"
252
251
 
253
- node_indirection.expects(:name2hash).with('parent').returns nil
252
+ expect(node_indirection).to receive(:name2hash).with('parent').and_return(nil)
254
253
 
255
254
  expect { node_indirection.find(request) }.to raise_error(Puppet::Error, /Could not find parent node/)
256
255
  end
@@ -288,7 +287,7 @@ describe Puppet::Node::Ldap do
288
287
 
289
288
  @parent[:environment] = "parent"
290
289
 
291
- Puppet::Node::Facts.indirection.stubs(:find).with(nodename, :environment => env).returns(facts)
290
+ allow(Puppet::Node::Facts.indirection).to receive(:find).with(nodename, :environment => env).and_return(facts)
292
291
 
293
292
  Puppet.override(:environments => Puppet::Environments::Static.new(env)) do
294
293
  expect(node_indirection.find(request).environment).to eq(env)
@@ -302,7 +301,7 @@ describe Puppet::Node::Ldap do
302
301
 
303
302
  @parent[:environment] = "parent"
304
303
 
305
- Puppet::Node::Facts.indirection.stubs(:find).with(nodename, :environment => child_env).returns(facts)
304
+ allow(Puppet::Node::Facts.indirection).to receive(:find).with(nodename, :environment => child_env).and_return(facts)
306
305
 
307
306
  Puppet.override(:environments => Puppet::Environments::Static.new(child_env)) do
308
307
 
@@ -336,11 +335,11 @@ describe Puppet::Node::Ldap do
336
335
  let(:request) { Puppet::Indirector::Request.new(:node, :find, nodename, nil, options) }
337
336
 
338
337
  before :each do
339
- Puppet::Node::Facts.indirection.stubs(:terminus_class).returns :yaml
338
+ allow(Puppet::Node::Facts.indirection).to receive(:terminus_class).and_return(:yaml)
340
339
  end
341
340
 
342
341
  it "should find all nodes if no arguments are provided" do
343
- node_indirection.expects(:ldapsearch).with("(objectclass=puppetClient)")
342
+ expect(node_indirection).to receive(:ldapsearch).with("(objectclass=puppetClient)")
344
343
  # LAK:NOTE The search method requires an essentially bogus key. It's
345
344
  # an API problem that I don't really know how to fix.
346
345
  node_indirection.search request
@@ -348,7 +347,7 @@ describe Puppet::Node::Ldap do
348
347
 
349
348
  describe "and a class is specified" do
350
349
  it "should find all nodes that are members of that class" do
351
- node_indirection.expects(:ldapsearch).with("(&(objectclass=puppetClient)(puppetclass=one))")
350
+ expect(node_indirection).to receive(:ldapsearch).with("(&(objectclass=puppetClient)(puppetclass=one))")
352
351
 
353
352
  options[:class] = "one"
354
353
  node_indirection.search request
@@ -357,37 +356,36 @@ describe Puppet::Node::Ldap do
357
356
 
358
357
  describe "multiple classes are specified" do
359
358
  it "should find all nodes that are members of all classes" do
360
- node_indirection.expects(:ldapsearch).with("(&(objectclass=puppetClient)(puppetclass=one)(puppetclass=two))")
359
+ expect(node_indirection).to receive(:ldapsearch).with("(&(objectclass=puppetClient)(puppetclass=one)(puppetclass=two))")
361
360
  options[:class] = %w{one two}
362
361
  node_indirection.search request
363
362
  end
364
363
  end
365
364
 
366
365
  it "should process each found entry" do
367
- # .yields can't be used to yield multiple values :/
368
- node_indirection.expects(:ldapsearch).yields("one")
369
- node_indirection.expects(:entry2hash).with("one",nil).returns(:name => nodename)
366
+ expect(node_indirection).to receive(:ldapsearch).and_yield("one")
367
+ expect(node_indirection).to receive(:entry2hash).with("one",nil).and_return(:name => nodename)
370
368
  node_indirection.search request
371
369
  end
372
370
 
373
371
  it "should return a node for each processed entry with the name from the entry" do
374
- node_indirection.expects(:ldapsearch).yields("whatever")
375
- node_indirection.expects(:entry2hash).with("whatever",nil).returns(:name => nodename)
372
+ expect(node_indirection).to receive(:ldapsearch).and_yield("whatever")
373
+ expect(node_indirection).to receive(:entry2hash).with("whatever",nil).and_return(:name => nodename)
376
374
  result = node_indirection.search(request)
377
375
  expect(result[0]).to be_instance_of(Puppet::Node)
378
376
  expect(result[0].name).to eq(nodename)
379
377
  end
380
378
 
381
379
  it "should merge each node's facts" do
382
- node_indirection.stubs(:ldapsearch).yields("one")
383
- node_indirection.stubs(:entry2hash).with("one",nil).returns(:name => nodename)
380
+ allow(node_indirection).to receive(:ldapsearch).and_yield("one")
381
+ allow(node_indirection).to receive(:entry2hash).with("one",nil).and_return(:name => nodename)
384
382
  expect(node_indirection.search(request)[0].parameters).to include(fact_values)
385
383
  end
386
384
 
387
385
  it "should pass the request's fqdn option to entry2hash" do
388
386
  options[:fqdn] = :hello
389
- node_indirection.stubs(:ldapsearch).yields("one")
390
- node_indirection.expects(:entry2hash).with("one",:hello).returns(:name => nodename)
387
+ allow(node_indirection).to receive(:ldapsearch).and_yield("one")
388
+ expect(node_indirection).to receive(:entry2hash).with("one",:hello).and_return(:name => nodename)
391
389
  node_indirection.search(request)
392
390
  end
393
391
  end
@@ -419,9 +417,9 @@ describe Puppet::Node::Ldap do
419
417
  end
420
418
 
421
419
  it "should not modify the global :ldapstring when replacing '%s' in the search filter" do
422
- filter = mock 'filter'
423
- filter.expects(:include?).with("%s").returns(true)
424
- filter.expects(:gsub).with("%s", "testing").returns("mynewstring")
420
+ filter = double('filter')
421
+ expect(filter).to receive(:include?).with("%s").and_return(true)
422
+ expect(filter).to receive(:gsub).with("%s", "testing").and_return("mynewstring")
425
423
  Puppet[:ldapstring] = filter
426
424
  expect(node_indirection.search_filter("testing")).to eq("mynewstring")
427
425
  end
@@ -435,30 +433,30 @@ describe Puppet::Node::Ldap do
435
433
 
436
434
  it "should split the value of :ldapattrs on commas and use the result as the attribute list" do
437
435
  Puppet[:ldapattrs] = "one,two"
438
- node_indirection.stubs(:class_attributes).returns([])
439
- node_indirection.stubs(:parent_attribute).returns(nil)
436
+ allow(node_indirection).to receive(:class_attributes).and_return([])
437
+ allow(node_indirection).to receive(:parent_attribute).and_return(nil)
440
438
  expect(node_indirection.search_attributes).to eq(%w{one two})
441
439
  end
442
440
 
443
441
  it "should add the class attributes to the search attributes if not returning all attributes" do
444
442
  Puppet[:ldapattrs] = "one,two"
445
- node_indirection.stubs(:class_attributes).returns(%w{three four})
446
- node_indirection.stubs(:parent_attribute).returns(nil)
443
+ allow(node_indirection).to receive(:class_attributes).and_return(%w{three four})
444
+ allow(node_indirection).to receive(:parent_attribute).and_return(nil)
447
445
  # Sort them so i don't have to care about return order
448
446
  expect(node_indirection.search_attributes.sort).to eq(%w{one two three four}.sort)
449
447
  end
450
448
 
451
449
  it "should add the parent attribute to the search attributes if not returning all attributes" do
452
450
  Puppet[:ldapattrs] = "one,two"
453
- node_indirection.stubs(:class_attributes).returns([])
454
- node_indirection.stubs(:parent_attribute).returns("parent")
451
+ allow(node_indirection).to receive(:class_attributes).and_return([])
452
+ allow(node_indirection).to receive(:parent_attribute).and_return("parent")
455
453
  expect(node_indirection.search_attributes.sort).to eq(%w{one two parent}.sort)
456
454
  end
457
455
 
458
456
  it "should not add nil parent attributes to the search attributes" do
459
457
  Puppet[:ldapattrs] = "one,two"
460
- node_indirection.stubs(:class_attributes).returns([])
461
- node_indirection.stubs(:parent_attribute).returns(nil)
458
+ allow(node_indirection).to receive(:class_attributes).and_return([])
459
+ allow(node_indirection).to receive(:parent_attribute).and_return(nil)
462
460
  expect(node_indirection.search_attributes).to eq(%w{one two})
463
461
  end
464
462
  end
@@ -1,17 +1,15 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/indirector/node/memory'
5
-
6
4
  require 'shared_behaviours/memory_terminus'
7
5
 
8
6
  describe Puppet::Node::Memory do
9
7
  before do
10
8
  @name = "me"
11
9
  @searcher = Puppet::Node::Memory.new
12
- @instance = stub 'instance', :name => @name
10
+ @instance = double('instance', :name => @name)
13
11
 
14
- @request = stub 'request', :key => @name, :instance => @instance
12
+ @request = double('request', :key => @name, :instance => @instance)
15
13
  end
16
14
 
17
15
  it_should_behave_like "A Memory Terminus"