puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -12,14 +12,14 @@ describe Puppet::Type.type(:user).provider(:hpuxuseradd), :unless => Puppet.feat
12
12
  let(:provider) { resource.provider }
13
13
 
14
14
  it "should add -F when modifying a user" do
15
- resource.stubs(:allowdupe?).returns true
16
- provider.expects(:execute).with { |args| args.include?("-F") }
15
+ allow(resource).to receive(:allowdupe?).and_return(true)
16
+ expect(provider).to receive(:execute).with(include("-F"), anything)
17
17
  provider.uid = 1000
18
18
  end
19
19
 
20
20
  it "should add -F when deleting a user" do
21
- provider.stubs(:exists?).returns(true)
22
- provider.expects(:execute).with { |args| args.include?("-F") }
21
+ allow(provider).to receive(:exists?).and_return(true)
22
+ expect(provider).to receive(:execute).with(include("-F"), anything)
23
23
  provider.delete
24
24
  end
25
25
 
@@ -29,9 +29,9 @@ describe Puppet::Type.type(:user).provider(:hpuxuseradd), :unless => Puppet.feat
29
29
  end
30
30
 
31
31
  before :each do
32
- Etc.stubs(:getpwent).returns(pwent)
33
- Etc.stubs(:getpwnam).returns(pwent)
34
- resource.stubs(:command).with(:modify).returns '/usr/sam/lbin/usermod.sam'
32
+ allow(Etc).to receive(:getpwent).and_return(pwent)
33
+ allow(Etc).to receive(:getpwnam).and_return(pwent)
34
+ allow(resource).to receive(:command).with(:modify).and_return('/usr/sam/lbin/usermod.sam')
35
35
  end
36
36
 
37
37
  it "should have feature manages_passwords" do
@@ -39,7 +39,7 @@ describe Puppet::Type.type(:user).provider(:hpuxuseradd), :unless => Puppet.feat
39
39
  end
40
40
 
41
41
  it "should return nil if user does not exist" do
42
- Etc.stubs(:getpwent).returns(nil)
42
+ allow(Etc).to receive(:getpwent).and_return(nil)
43
43
  expect(provider.password).to be_nil
44
44
  end
45
45
 
@@ -50,20 +50,20 @@ describe Puppet::Type.type(:user).provider(:hpuxuseradd), :unless => Puppet.feat
50
50
 
51
51
  context "check for trusted computing" do
52
52
  before :each do
53
- provider.stubs(:command).with(:modify).returns '/usr/sam/lbin/usermod.sam'
53
+ allow(provider).to receive(:command).with(:modify).and_return('/usr/sam/lbin/usermod.sam')
54
54
  end
55
55
 
56
56
  it "should add modprpw to modifycmd if Trusted System" do
57
- resource.stubs(:allowdupe?).returns true
58
- provider.expects(:exec_getprpw).with('root','-m uid').returns('uid=0')
59
- provider.expects(:execute).with(['/usr/sam/lbin/usermod.sam', '-u', 1000, '-o', 'testuser', '-F', ';', '/usr/lbin/modprpw', '-v', '-l', 'testuser'], has_entry(:custom_environment, {}))
57
+ allow(resource).to receive(:allowdupe?).and_return(true)
58
+ expect(provider).to receive(:exec_getprpw).with('root','-m uid').and_return('uid=0')
59
+ expect(provider).to receive(:execute).with(['/usr/sam/lbin/usermod.sam', '-u', 1000, '-o', 'testuser', '-F', ';', '/usr/lbin/modprpw', '-v', '-l', 'testuser'], hash_including(custom_environment: {}))
60
60
  provider.uid = 1000
61
61
  end
62
62
 
63
63
  it "should not add modprpw if not Trusted System" do
64
- resource.stubs(:allowdupe?).returns true
65
- provider.expects(:exec_getprpw).with('root','-m uid').returns('System is not trusted')
66
- provider.expects(:execute).with(['/usr/sam/lbin/usermod.sam', '-u', 1000, '-o', 'testuser', '-F'], has_entry(:custom_environment, {}))
64
+ allow(resource).to receive(:allowdupe?).and_return(true)
65
+ expect(provider).to receive(:exec_getprpw).with('root','-m uid').and_return('System is not trusted')
66
+ expect(provider).to receive(:execute).with(['/usr/sam/lbin/usermod.sam', '-u', 1000, '-o', 'testuser', '-F'], hash_including(custom_environment: {}))
67
67
  provider.uid = 1000
68
68
  end
69
69
  end
@@ -37,36 +37,36 @@ describe Puppet::Type.type(:user).provider(:ldap) do
37
37
  context "when being created" do
38
38
  before do
39
39
  # So we don't try to actually talk to ldap
40
- @connection = mock 'connection'
41
- described_class.manager.stubs(:connect).yields @connection
40
+ @connection = double('connection')
41
+ allow(described_class.manager).to receive(:connect).and_yield(@connection)
42
42
  end
43
43
 
44
44
  it "should generate the sn as the last field of the cn" do
45
- Puppet::Type.type(:group).provider(:ldap).expects(:name2id).with(["whatever"]).returns [123]
45
+ expect(Puppet::Type.type(:group).provider(:ldap)).to receive(:name2id).with(["whatever"]).and_return([123])
46
46
 
47
- resource = stub 'resource', :should => %w{whatever}
48
- resource.stubs(:should).with(:comment).returns ["Luke Kanies"]
49
- resource.stubs(:should).with(:ensure).returns :present
47
+ resource = double('resource', :should => %w{whatever})
48
+ allow(resource).to receive(:should).with(:comment).and_return(["Luke Kanies"])
49
+ allow(resource).to receive(:should).with(:ensure).and_return(:present)
50
50
  instance = described_class.new(:name => "luke", :ensure => :absent)
51
51
 
52
- instance.stubs(:resource).returns resource
52
+ allow(instance).to receive(:resource).and_return(resource)
53
53
 
54
- @connection.expects(:add).with { |dn, attrs| attrs["sn"] == ["Kanies"] }
54
+ expect(@connection).to receive(:add).with(anything, hash_including("sn" => ["Kanies"]))
55
55
 
56
56
  instance.create
57
57
  instance.flush
58
58
  end
59
59
 
60
60
  it "should translate a group name to the numeric id" do
61
- Puppet::Type.type(:group).provider(:ldap).expects(:name2id).with("bar").returns 101
61
+ expect(Puppet::Type.type(:group).provider(:ldap)).to receive(:name2id).with("bar").and_return(101)
62
62
 
63
- resource = stub 'resource', :should => %w{whatever}
64
- resource.stubs(:should).with(:gid).returns 'bar'
65
- resource.stubs(:should).with(:ensure).returns :present
63
+ resource = double('resource', :should => %w{whatever})
64
+ allow(resource).to receive(:should).with(:gid).and_return('bar')
65
+ allow(resource).to receive(:should).with(:ensure).and_return(:present)
66
66
  instance = described_class.new(:name => "luke", :ensure => :absent)
67
- instance.stubs(:resource).returns resource
67
+ allow(instance).to receive(:resource).and_return(resource)
68
68
 
69
- @connection.expects(:add).with { |dn, attrs| attrs["gidNumber"] == ["101"] }
69
+ expect(@connection).to receive(:add).with(anything, hash_including("gidNumber" => ["101"]))
70
70
 
71
71
  instance.create
72
72
  instance.flush
@@ -74,36 +74,36 @@ describe Puppet::Type.type(:user).provider(:ldap) do
74
74
 
75
75
  context "with no uid specified" do
76
76
  it "should pick the first available UID after the largest existing UID" do
77
- Puppet::Type.type(:group).provider(:ldap).expects(:name2id).with(["whatever"]).returns [123]
77
+ expect(Puppet::Type.type(:group).provider(:ldap)).to receive(:name2id).with(["whatever"]).and_return([123])
78
78
 
79
79
  low = {:name=>["luke"], :shell=>:absent, :uid=>["600"], :home=>["/h"], :gid=>["1000"], :password=>["blah"], :comment=>["l k"]}
80
80
  high = {:name=>["testing"], :shell=>:absent, :uid=>["640"], :home=>["/h"], :gid=>["1000"], :password=>["blah"], :comment=>["t u"]}
81
- described_class.manager.expects(:search).returns([low, high])
81
+ expect(described_class.manager).to receive(:search).and_return([low, high])
82
82
 
83
- resource = stub 'resource', :should => %w{whatever}
84
- resource.stubs(:should).with(:uid).returns nil
85
- resource.stubs(:should).with(:ensure).returns :present
83
+ resource = double('resource', :should => %w{whatever})
84
+ allow(resource).to receive(:should).with(:uid).and_return(nil)
85
+ allow(resource).to receive(:should).with(:ensure).and_return(:present)
86
86
  instance = described_class.new(:name => "luke", :ensure => :absent)
87
- instance.stubs(:resource).returns resource
87
+ allow(instance).to receive(:resource).and_return(resource)
88
88
 
89
- @connection.expects(:add).with { |dn, attrs| attrs["uidNumber"] == ["641"] }
89
+ expect(@connection).to receive(:add).with(anything, hash_including("uidNumber" => ["641"]))
90
90
 
91
91
  instance.create
92
92
  instance.flush
93
93
  end
94
94
 
95
95
  it "should pick 501 of no users exist" do
96
- Puppet::Type.type(:group).provider(:ldap).expects(:name2id).with(["whatever"]).returns [123]
96
+ expect(Puppet::Type.type(:group).provider(:ldap)).to receive(:name2id).with(["whatever"]).and_return([123])
97
97
 
98
- described_class.manager.expects(:search).returns nil
98
+ expect(described_class.manager).to receive(:search).and_return(nil)
99
99
 
100
- resource = stub 'resource', :should => %w{whatever}
101
- resource.stubs(:should).with(:uid).returns nil
102
- resource.stubs(:should).with(:ensure).returns :present
100
+ resource = double('resource', :should => %w{whatever})
101
+ allow(resource).to receive(:should).with(:uid).and_return(nil)
102
+ allow(resource).to receive(:should).with(:ensure).and_return(:present)
103
103
  instance = described_class.new(:name => "luke", :ensure => :absent)
104
- instance.stubs(:resource).returns resource
104
+ allow(instance).to receive(:resource).and_return(resource)
105
105
 
106
- @connection.expects(:add).with { |dn, attrs| attrs["uidNumber"] == ["501"] }
106
+ expect(@connection).to receive(:add).with(anything, hash_including("uidNumber" => ["501"]))
107
107
 
108
108
  instance.create
109
109
  instance.flush
@@ -113,19 +113,19 @@ describe Puppet::Type.type(:user).provider(:ldap) do
113
113
 
114
114
  context "when flushing" do
115
115
  before do
116
- described_class.stubs(:suitable?).returns true
116
+ allow(described_class).to receive(:suitable?).and_return(true)
117
117
 
118
118
  @instance = described_class.new(:name => "myname", :groups => %w{whatever}, :uid => "400")
119
119
  end
120
120
 
121
121
  it "should remove the :groups value before updating" do
122
- @instance.class.manager.expects(:update).with { |name, ldap, puppet| puppet[:groups].nil? }
122
+ expect(@instance.class.manager).to receive(:update).with(anything, anything, hash_excluding(:groups))
123
123
 
124
124
  @instance.flush
125
125
  end
126
126
 
127
127
  it "should empty the property hash" do
128
- @instance.class.manager.stubs(:update)
128
+ allow(@instance.class.manager).to receive(:update)
129
129
 
130
130
  @instance.flush
131
131
 
@@ -133,7 +133,7 @@ describe Puppet::Type.type(:user).provider(:ldap) do
133
133
  end
134
134
 
135
135
  it "should empty the ldap property hash" do
136
- @instance.class.manager.stubs(:update)
136
+ allow(@instance.class.manager).to receive(:update)
137
137
 
138
138
  @instance.flush
139
139
 
@@ -145,7 +145,7 @@ describe Puppet::Type.type(:user).provider(:ldap) do
145
145
  before do
146
146
  @groups = Puppet::Type.type(:group).provider(:ldap)
147
147
  @group_manager = @groups.manager
148
- described_class.stubs(:suitable?).returns true
148
+ allow(described_class).to receive(:suitable?).and_return(true)
149
149
 
150
150
  @instance = described_class.new(:name => "myname")
151
151
  end
@@ -153,19 +153,19 @@ describe Puppet::Type.type(:user).provider(:ldap) do
153
153
  it "should show its group membership as the sorted list of all groups returned by an ldap query of group memberships" do
154
154
  one = {:name => "one"}
155
155
  two = {:name => "two"}
156
- @group_manager.expects(:search).with("memberUid=myname").returns([two, one])
156
+ expect(@group_manager).to receive(:search).with("memberUid=myname").and_return([two, one])
157
157
 
158
158
  expect(@instance.groups).to eq("one,two")
159
159
  end
160
160
 
161
161
  it "should show its group membership as :absent if no matching groups are found in ldap" do
162
- @group_manager.expects(:search).with("memberUid=myname").returns(nil)
162
+ expect(@group_manager).to receive(:search).with("memberUid=myname").and_return(nil)
163
163
 
164
164
  expect(@instance.groups).to eq(:absent)
165
165
  end
166
166
 
167
167
  it "should cache the group value" do
168
- @group_manager.expects(:search).with("memberUid=myname").once.returns nil
168
+ expect(@group_manager).to receive(:search).with("memberUid=myname").once.and_return(nil)
169
169
 
170
170
  @instance.groups
171
171
  expect(@instance.groups).to eq(:absent)
@@ -176,61 +176,61 @@ describe Puppet::Type.type(:user).provider(:ldap) do
176
176
  before do
177
177
  @groups = Puppet::Type.type(:group).provider(:ldap)
178
178
  @group_manager = @groups.manager
179
- described_class.stubs(:suitable?).returns true
179
+ allow(described_class).to receive(:suitable?).and_return(true)
180
180
 
181
181
  @one = {:name => "one", :gid => "500"}
182
- @group_manager.stubs(:find).with("one").returns(@one)
182
+ allow(@group_manager).to receive(:find).with("one").and_return(@one)
183
183
 
184
184
  @two = {:name => "one", :gid => "600"}
185
- @group_manager.stubs(:find).with("two").returns(@two)
185
+ allow(@group_manager).to receive(:find).with("two").and_return(@two)
186
186
 
187
187
  @instance = described_class.new(:name => "myname")
188
188
 
189
- @instance.stubs(:groups).returns :absent
189
+ allow(@instance).to receive(:groups).and_return(:absent)
190
190
  end
191
191
 
192
192
  it "should fail if the group does not exist" do
193
- @group_manager.expects(:find).with("mygroup").returns nil
193
+ expect(@group_manager).to receive(:find).with("mygroup").and_return(nil)
194
194
 
195
195
  expect { @instance.groups = "mygroup" }.to raise_error(Puppet::Error)
196
196
  end
197
197
 
198
198
  it "should only pass the attributes it cares about to the group manager" do
199
- @group_manager.expects(:update).with { |name, attrs| attrs[:gid].nil? }
199
+ expect(@group_manager).to receive(:update).with(anything, hash_excluding(:gid), anything)
200
200
 
201
201
  @instance.groups = "one"
202
202
  end
203
203
 
204
204
  it "should always include :ensure => :present in the current values" do
205
- @group_manager.expects(:update).with { |name, is, should| is[:ensure] == :present }
205
+ expect(@group_manager).to receive(:update).with(anything, hash_including(ensure: :present), anything)
206
206
 
207
207
  @instance.groups = "one"
208
208
  end
209
209
 
210
210
  it "should always include :ensure => :present in the desired values" do
211
- @group_manager.expects(:update).with { |name, is, should| should[:ensure] == :present }
211
+ expect(@group_manager).to receive(:update).with(anything, anything, hash_including(ensure: :present))
212
212
 
213
213
  @instance.groups = "one"
214
214
  end
215
215
 
216
216
  it "should always pass the group's original member list" do
217
217
  @one[:members] = %w{yay ness}
218
- @group_manager.expects(:update).with { |name, is, should| is[:members] == %w{yay ness} }
218
+ expect(@group_manager).to receive(:update).with(anything, hash_including(members: %w{yay ness}), anything)
219
219
 
220
220
  @instance.groups = "one"
221
221
  end
222
222
 
223
223
  it "should find the group again when resetting its member list, so it has the full member list" do
224
- @group_manager.expects(:find).with("one").returns(@one)
224
+ expect(@group_manager).to receive(:find).with("one").and_return(@one)
225
225
 
226
- @group_manager.stubs(:update)
226
+ allow(@group_manager).to receive(:update)
227
227
 
228
228
  @instance.groups = "one"
229
229
  end
230
230
 
231
231
  context "for groups that have no members" do
232
232
  it "should create a new members attribute with its value being the user's name" do
233
- @group_manager.expects(:update).with { |name, is, should| should[:members] == %w{myname} }
233
+ expect(@group_manager).to receive(:update).with(anything, anything, hash_including(members: %w{myname}))
234
234
 
235
235
  @instance.groups = "one"
236
236
  end
@@ -241,9 +241,9 @@ describe Puppet::Type.type(:user).provider(:ldap) do
241
241
  @one[:members] = %w{myname a}
242
242
  @two[:members] = %w{myname b}
243
243
 
244
- @group_manager.expects(:update).with { |name, is, should| name == "two" and should[:members] == %w{b} }
244
+ expect(@group_manager).to receive(:update).with("two", anything, hash_including(members: %w{b}))
245
245
 
246
- @instance.stubs(:groups).returns "one,two"
246
+ allow(@instance).to receive(:groups).and_return("one,two")
247
247
  @instance.groups = "one"
248
248
  end
249
249
 
@@ -251,9 +251,9 @@ describe Puppet::Type.type(:user).provider(:ldap) do
251
251
  @one[:members] = %w{myname}
252
252
  @two[:members] = %w{myname b}
253
253
 
254
- @group_manager.expects(:update).with { |name, is, should| name == "one" and should[:members] == :absent }
254
+ expect(@group_manager).to receive(:update).with("one", anything, hash_including(members: :absent))
255
255
 
256
- @instance.stubs(:groups).returns "one,two"
256
+ allow(@instance).to receive(:groups).and_return("one,two")
257
257
  @instance.groups = "two"
258
258
  end
259
259
  end
@@ -261,9 +261,9 @@ describe Puppet::Type.type(:user).provider(:ldap) do
261
261
  context "for groups that already have members" do
262
262
  it "should replace each group's member list with a new list including the user's name" do
263
263
  @one[:members] = %w{a b}
264
- @group_manager.expects(:update).with { |name, is, should| should[:members] == %w{a b myname} }
264
+ expect(@group_manager).to receive(:update).with(anything, anything, hash_including(members: %w{a b myname}))
265
265
  @two[:members] = %w{b c}
266
- @group_manager.expects(:update).with { |name, is, should| should[:members] == %w{b c myname} }
266
+ expect(@group_manager).to receive(:update).with(anything, anything, hash_including(members: %w{b c myname}))
267
267
 
268
268
  @instance.groups = "one,two"
269
269
  end
@@ -272,12 +272,12 @@ describe Puppet::Type.type(:user).provider(:ldap) do
272
272
  context "for groups of which it is a member" do
273
273
  it "should do nothing" do
274
274
  @one[:members] = %w{a b}
275
- @group_manager.expects(:update).with { |name, is, should| should[:members] == %w{a b myname} }
275
+ expect(@group_manager).to receive(:update).with(anything, anything, hash_including(members: %w{a b myname}))
276
276
 
277
277
  @two[:members] = %w{c myname}
278
- @group_manager.expects(:update).with { |name, *other| name == "two" }.never
278
+ expect(@group_manager).not_to receive(:update).with("two", any_args)
279
279
 
280
- @instance.stubs(:groups).returns "two"
280
+ allow(@instance).to receive(:groups).and_return("two")
281
281
 
282
282
  @instance.groups = "one,two"
283
283
  end
@@ -1,13 +1,11 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:user).provider(:openbsd) do
5
-
6
4
  before :each do
7
- described_class.stubs(:command).with(:password).returns '/usr/sbin/passwd'
8
- described_class.stubs(:command).with(:add).returns '/usr/sbin/useradd'
9
- described_class.stubs(:command).with(:modify).returns '/usr/sbin/usermod'
10
- described_class.stubs(:command).with(:delete).returns '/usr/sbin/userdel'
5
+ allow(described_class).to receive(:command).with(:password).and_return('/usr/sbin/passwd')
6
+ allow(described_class).to receive(:command).with(:add).and_return('/usr/sbin/useradd')
7
+ allow(described_class).to receive(:command).with(:modify).and_return('/usr/sbin/usermod')
8
+ allow(described_class).to receive(:command).with(:delete).and_return('/usr/sbin/userdel')
11
9
  end
12
10
 
13
11
  let(:resource) do
@@ -33,20 +31,20 @@ describe Puppet::Type.type(:user).provider(:openbsd) do
33
31
  describe "#expiry=" do
34
32
  it "should pass expiry to usermod as MM/DD/YY" do
35
33
  resource[:expiry] = '2014-11-05'
36
- provider.expects(:execute).with(['/usr/sbin/usermod', '-e', 'November 05 2014', 'myuser'], has_entry(:custom_environment, {}))
34
+ expect(provider).to receive(:execute).with(['/usr/sbin/usermod', '-e', 'November 05 2014', 'myuser'], hash_including(custom_environment: {}))
37
35
  provider.expiry = '2014-11-05'
38
36
  end
39
37
 
40
38
  it "should use -e with an empty string when the expiry property is removed" do
41
39
  resource[:expiry] = :absent
42
- provider.expects(:execute).with(['/usr/sbin/usermod', '-e', '', 'myuser'], has_entry(:custom_environment, {}))
40
+ expect(provider).to receive(:execute).with(['/usr/sbin/usermod', '-e', '', 'myuser'], hash_including(custom_environment: {}))
43
41
  provider.expiry = :absent
44
42
  end
45
43
  end
46
44
 
47
45
  describe "#addcmd" do
48
46
  it "should return an array with the full command and expiry as MM/DD/YY" do
49
- Facter.stubs(:value).with(:osfamily).returns('OpenBSD')
47
+ allow(Facter).to receive(:value).with(:osfamily).and_return('OpenBSD')
50
48
  resource[:expiry] = "1997-06-01"
51
49
  expect(provider.addcmd).to eq(['/usr/sbin/useradd', '-e', 'June 01 1997', 'myuser'])
52
50
  end
@@ -58,19 +56,19 @@ describe Puppet::Type.type(:user).provider(:openbsd) do
58
56
  end
59
57
 
60
58
  it "should return the loginclass if set", :if => Puppet.features.libshadow? do
61
- Shadow::Passwd.expects(:getspnam).with('myuser').returns shadow_entry
59
+ expect(Shadow::Passwd).to receive(:getspnam).with('myuser').and_return(shadow_entry)
62
60
  provider.send(:loginclass).should == 'staff'
63
61
  end
64
62
 
65
63
  it "should return the empty string when loginclass isn't set", :if => Puppet.features.libshadow? do
66
64
  shadow_entry[:sp_loginclass] = ''
67
- Shadow::Passwd.expects(:getspnam).with('myuser').returns shadow_entry
65
+ expect(Shadow::Passwd).to receive(:getspnam).with('myuser').and_return(shadow_entry)
68
66
  provider.send(:loginclass).should == ''
69
67
  end
70
68
 
71
69
  it "should return nil when loginclass isn't available", :if => Puppet.features.libshadow? do
72
70
  shadow_entry[:sp_loginclass] = nil
73
- Shadow::Passwd.expects(:getspnam).with('myuser').returns shadow_entry
71
+ expect(Shadow::Passwd).to receive(:getspnam).with('myuser').and_return(shadow_entry)
74
72
  provider.send(:loginclass).should be_nil
75
73
  end
76
74
  end
@@ -1,5 +1,7 @@
1
1
  require 'spec_helper'
2
2
 
3
+ RSpec::Matchers.define_negated_matcher :excluding, :include
4
+
3
5
  describe Puppet::Type.type(:user).provider(:pw) do
4
6
  let :resource do
5
7
  Puppet::Type.type(:user).new(:name => "testuser", :provider => :pw)
@@ -8,86 +10,86 @@ describe Puppet::Type.type(:user).provider(:pw) do
8
10
  context "when creating users" do
9
11
  let :provider do
10
12
  prov = resource.provider
11
- prov.expects(:exists?).returns nil
13
+ expect(prov).to receive(:exists?).and_return(nil)
12
14
  prov
13
15
  end
14
16
 
15
17
  it "should run pw with no additional flags when no properties are given" do
16
18
  expect(provider.addcmd).to eq([described_class.command(:pw), "useradd", "testuser"])
17
- provider.expects(:execute).with([described_class.command(:pw), "useradd", "testuser"], kind_of(Hash))
19
+ expect(provider).to receive(:execute).with([described_class.command(:pw), "useradd", "testuser"], kind_of(Hash))
18
20
  provider.create
19
21
  end
20
22
 
21
23
  it "should use -o when allowdupe is enabled" do
22
24
  resource[:allowdupe] = true
23
- provider.expects(:execute).with(includes("-o"), kind_of(Hash))
25
+ expect(provider).to receive(:execute).with(include("-o"), kind_of(Hash))
24
26
  provider.create
25
27
  end
26
28
 
27
29
  it "should use -c with the correct argument when the comment property is set" do
28
30
  resource[:comment] = "Testuser Name"
29
- provider.expects(:execute).with(all_of(includes("-c"), includes("Testuser Name")), kind_of(Hash))
31
+ expect(provider).to receive(:execute).with(include("-c").and(include("Testuser Name")), kind_of(Hash))
30
32
  provider.create
31
33
  end
32
34
 
33
35
  it "should use -e with the correct argument when the expiry property is set" do
34
36
  resource[:expiry] = "2010-02-19"
35
- provider.expects(:execute).with(all_of(includes("-e"), includes("19-02-2010")), kind_of(Hash))
37
+ expect(provider).to receive(:execute).with(include("-e").and(include("19-02-2010")), kind_of(Hash))
36
38
  provider.create
37
39
  end
38
40
 
39
41
  it "should use -e 00-00-0000 if the expiry property has to be removed" do
40
42
  resource[:expiry] = :absent
41
- provider.expects(:execute).with(all_of(includes("-e"), includes("00-00-0000")), kind_of(Hash))
43
+ expect(provider).to receive(:execute).with(include("-e").and(include("00-00-0000")), kind_of(Hash))
42
44
  provider.create
43
45
  end
44
46
 
45
47
  it "should use -g with the correct argument when the gid property is set" do
46
48
  resource[:gid] = 12345
47
- provider.expects(:execute).with(all_of(includes("-g"), includes(12345)), kind_of(Hash))
49
+ expect(provider).to receive(:execute).with(include("-g").and(include(12345)), kind_of(Hash))
48
50
  provider.create
49
51
  end
50
52
 
51
53
  it "should use -G with the correct argument when the groups property is set" do
52
54
  resource[:groups] = "group1"
53
- provider.expects(:execute).with(all_of(includes("-G"), includes("group1")), kind_of(Hash))
55
+ expect(provider).to receive(:execute).with(include("-G").and(include("group1")), kind_of(Hash))
54
56
  provider.create
55
57
  end
56
58
 
57
59
  it "should use -G with all the given groups when the groups property is set to an array" do
58
60
  resource[:groups] = ["group1", "group2"]
59
- provider.expects(:execute).with(all_of(includes("-G"), includes("group1,group2")), kind_of(Hash))
61
+ expect(provider).to receive(:execute).with(include("-G").and(include("group1,group2")), kind_of(Hash))
60
62
  provider.create
61
63
  end
62
64
 
63
65
  it "should use -d with the correct argument when the home property is set" do
64
66
  resource[:home] = "/home/testuser"
65
- provider.expects(:execute).with(all_of(includes("-d"), includes("/home/testuser")), kind_of(Hash))
67
+ expect(provider).to receive(:execute).with(include("-d").and(include("/home/testuser")), kind_of(Hash))
66
68
  provider.create
67
69
  end
68
70
 
69
71
  it "should use -m when the managehome property is enabled" do
70
72
  resource[:managehome] = true
71
- provider.expects(:execute).with(includes("-m"), kind_of(Hash))
73
+ expect(provider).to receive(:execute).with(include("-m"), kind_of(Hash))
72
74
  provider.create
73
75
  end
74
76
 
75
77
  it "should call the password set function with the correct argument when the password property is set" do
76
78
  resource[:password] = "*"
77
- provider.expects(:execute)
78
- provider.expects(:password=).with("*")
79
+ expect(provider).to receive(:execute)
80
+ expect(provider).to receive(:password=).with("*")
79
81
  provider.create
80
82
  end
81
83
 
82
84
  it "should use -s with the correct argument when the shell property is set" do
83
85
  resource[:shell] = "/bin/sh"
84
- provider.expects(:execute).with(all_of(includes("-s"), includes("/bin/sh")), kind_of(Hash))
86
+ expect(provider).to receive(:execute).with(include("-s").and(include("/bin/sh")), kind_of(Hash))
85
87
  provider.create
86
88
  end
87
89
 
88
90
  it "should use -u with the correct argument when the uid property is set" do
89
91
  resource[:uid] = 12345
90
- provider.expects(:execute).with(all_of(includes("-u"), includes(12345)), kind_of(Hash))
92
+ expect(provider).to receive(:execute).with(include("-u").and(include(12345)), kind_of(Hash))
91
93
  provider.create
92
94
  end
93
95
 
@@ -95,8 +97,8 @@ describe Puppet::Type.type(:user).provider(:pw) do
95
97
  it "should not use -p when a password is given" do
96
98
  resource[:password] = "*"
97
99
  expect(provider.addcmd).not_to include("-p")
98
- provider.expects(:password=)
99
- provider.expects(:execute).with(Not(includes("-p")), kind_of(Hash))
100
+ expect(provider).to receive(:password=)
101
+ expect(provider).to receive(:execute).with(excluding("-p"), kind_of(Hash))
100
102
  provider.create
101
103
  end
102
104
  end
@@ -104,9 +106,9 @@ describe Puppet::Type.type(:user).provider(:pw) do
104
106
  context "when deleting users" do
105
107
  it "should run pw with no additional flags" do
106
108
  provider = resource.provider
107
- provider.expects(:exists?).returns true
109
+ expect(provider).to receive(:exists?).and_return(true)
108
110
  expect(provider.deletecmd).to eq([described_class.command(:pw), "userdel", "testuser"])
109
- provider.expects(:execute).with([described_class.command(:pw), "userdel", "testuser"], has_entry(:custom_environment, {}))
111
+ expect(provider).to receive(:execute).with([described_class.command(:pw), "userdel", "testuser"], hash_including(custom_environment: {}))
110
112
  provider.delete
111
113
  end
112
114
 
@@ -115,17 +117,17 @@ describe Puppet::Type.type(:user).provider(:pw) do
115
117
  # have an explicit test.
116
118
  it "should not use -r when managehome is not set" do
117
119
  provider = resource.provider
118
- provider.expects(:exists?).returns true
120
+ expect(provider).to receive(:exists?).and_return(true)
119
121
  resource[:managehome] = false
120
- provider.expects(:execute).with(Not(includes("-r")), has_entry(:custom_environment, {}))
122
+ expect(provider).to receive(:execute).with(excluding("-r"), hash_including(custom_environment: {}))
121
123
  provider.delete
122
124
  end
123
125
 
124
126
  it "should use -r when managehome is set" do
125
127
  provider = resource.provider
126
- provider.expects(:exists?).returns true
128
+ expect(provider).to receive(:exists?).and_return(true)
127
129
  resource[:managehome] = true
128
- provider.expects(:execute).with(includes("-r"), has_entry(:custom_environment, {}))
130
+ expect(provider).to receive(:execute).with(include("-r"), hash_including(custom_environment: {}))
129
131
  provider.delete
130
132
  end
131
133
  end
@@ -137,74 +139,74 @@ describe Puppet::Type.type(:user).provider(:pw) do
137
139
 
138
140
  it "should run pw with the correct arguments" do
139
141
  expect(provider.modifycmd("uid", 12345)).to eq([described_class.command(:pw), "usermod", "testuser", "-u", 12345])
140
- provider.expects(:execute).with([described_class.command(:pw), "usermod", "testuser", "-u", 12345], has_entry(:custom_environment, {}))
142
+ expect(provider).to receive(:execute).with([described_class.command(:pw), "usermod", "testuser", "-u", 12345], hash_including(custom_environment: {}))
141
143
  provider.uid = 12345
142
144
  end
143
145
 
144
146
  it "should use -c with the correct argument when the comment property is changed" do
145
147
  resource[:comment] = "Testuser Name"
146
- provider.expects(:execute).with(all_of(includes("-c"), includes("Testuser New Name")), has_entry(:custom_environment, {}))
148
+ expect(provider).to receive(:execute).with(include("-c").and(include("Testuser New Name")), hash_including(custom_environment: {}))
147
149
  provider.comment = "Testuser New Name"
148
150
  end
149
151
 
150
152
  it "should use -e with the correct argument when the expiry property is changed" do
151
153
  resource[:expiry] = "2010-02-19"
152
- provider.expects(:execute).with(all_of(includes("-e"), includes("19-02-2011")), has_entry(:custom_environment, {}))
154
+ expect(provider).to receive(:execute).with(include("-e").and(include("19-02-2011")), hash_including(custom_environment: {}))
153
155
  provider.expiry = "2011-02-19"
154
156
  end
155
157
 
156
158
  it "should use -e with the correct argument when the expiry property is removed" do
157
159
  resource[:expiry] = :absent
158
- provider.expects(:execute).with(all_of(includes("-e"), includes("00-00-0000")), has_entry(:custom_environment, {}))
160
+ expect(provider).to receive(:execute).with(include("-e").and(include("00-00-0000")), hash_including(custom_environment: {}))
159
161
  provider.expiry = :absent
160
162
  end
161
163
 
162
164
  it "should use -g with the correct argument when the gid property is changed" do
163
165
  resource[:gid] = 12345
164
- provider.expects(:execute).with(all_of(includes("-g"), includes(54321)), has_entry(:custom_environment, {}))
166
+ expect(provider).to receive(:execute).with(include("-g").and(include(54321)), hash_including(custom_environment: {}))
165
167
  provider.gid = 54321
166
168
  end
167
169
 
168
170
  it "should use -G with the correct argument when the groups property is changed" do
169
171
  resource[:groups] = "group1"
170
- provider.expects(:execute).with(all_of(includes("-G"), includes("group2")), has_entry(:custom_environment, {}))
172
+ expect(provider).to receive(:execute).with(include("-G").and(include("group2")), hash_including(custom_environment: {}))
171
173
  provider.groups = "group2"
172
174
  end
173
175
 
174
176
  it "should use -G with all the given groups when the groups property is changed with an array" do
175
177
  resource[:groups] = ["group1", "group2"]
176
- provider.expects(:execute).with(all_of(includes("-G"), includes("group3,group4")), has_entry(:custom_environment, {}))
178
+ expect(provider).to receive(:execute).with(include("-G").and(include("group3,group4")), hash_including(custom_environment: {}))
177
179
  provider.groups = "group3,group4"
178
180
  end
179
181
 
180
182
  it "should use -d with the correct argument when the home property is changed" do
181
183
  resource[:home] = "/home/testuser"
182
- provider.expects(:execute).with(all_of(includes("-d"), includes("/newhome/testuser")), has_entry(:custom_environment, {}))
184
+ expect(provider).to receive(:execute).with(include("-d").and(include("/newhome/testuser")), hash_including(custom_environment: {}))
183
185
  provider.home = "/newhome/testuser"
184
186
  end
185
187
 
186
188
  it "should use -m and -d with the correct argument when the home property is changed and managehome is enabled" do
187
189
  resource[:home] = "/home/testuser"
188
190
  resource[:managehome] = true
189
- provider.expects(:execute).with(all_of(includes("-d"), includes("/newhome/testuser"), includes("-m")), has_entry(:custom_environment, {}))
191
+ expect(provider).to receive(:execute).with(include("-d").and(include("/newhome/testuser")).and(include("-m")), hash_including(custom_environment: {}))
190
192
  provider.home = "/newhome/testuser"
191
193
  end
192
194
 
193
195
  it "should call the password set function with the correct argument when the password property is changed" do
194
196
  resource[:password] = "*"
195
- provider.expects(:password=).with("!")
197
+ expect(provider).to receive(:password=).with("!")
196
198
  provider.password = "!"
197
199
  end
198
200
 
199
201
  it "should use -s with the correct argument when the shell property is changed" do
200
202
  resource[:shell] = "/bin/sh"
201
- provider.expects(:execute).with(all_of(includes("-s"), includes("/bin/tcsh")), has_entry(:custom_environment, {}))
203
+ expect(provider).to receive(:execute).with(include("-s").and(include("/bin/tcsh")), hash_including(custom_environment: {}))
202
204
  provider.shell = "/bin/tcsh"
203
205
  end
204
206
 
205
207
  it "should use -u with the correct argument when the uid property is changed" do
206
208
  resource[:uid] = 12345
207
- provider.expects(:execute).with(all_of(includes("-u"), includes(54321)), has_entry(:custom_environment, {}))
209
+ expect(provider).to receive(:execute).with(include("-u").and(include(54321)), hash_including(custom_environment: {}))
208
210
  provider.uid = 54321
209
211
  end
210
212
  end