puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/property/list'
@@ -15,7 +14,7 @@ describe list_class do
15
14
  before do
16
15
  # Wow that's a messy interface to the resource.
17
16
  list_class.initvars
18
- @resource = stub 'resource', :[]= => nil, :property => nil
17
+ @resource = double('resource', :[]= => nil, :property => nil)
19
18
  @property = list_class.new(:resource => @resource)
20
19
  end
21
20
 
@@ -55,20 +54,20 @@ describe list_class do
55
54
 
56
55
  describe "when calling inclusive?" do
57
56
  it "should use the membership method to look up on the @resource" do
58
- @property.expects(:membership).returns(:membership)
59
- @resource.expects(:[]).with(:membership)
57
+ expect(@property).to receive(:membership).and_return(:membership)
58
+ expect(@resource).to receive(:[]).with(:membership)
60
59
  @property.inclusive?
61
60
  end
62
61
 
63
62
  it "should return true when @resource[membership] == inclusive" do
64
- @property.stubs(:membership).returns(:membership)
65
- @resource.stubs(:[]).with(:membership).returns(:inclusive)
63
+ allow(@property).to receive(:membership).and_return(:membership)
64
+ allow(@resource).to receive(:[]).with(:membership).and_return(:inclusive)
66
65
  expect(@property.inclusive?).to eq(true)
67
66
  end
68
67
 
69
68
  it "should return false when @resource[membership] != inclusive" do
70
- @property.stubs(:membership).returns(:membership)
71
- @resource.stubs(:[]).with(:membership).returns(:minimum)
69
+ allow(@property).to receive(:membership).and_return(:membership)
70
+ allow(@resource).to receive(:[]).with(:membership).and_return(:minimum)
72
71
  expect(@property.inclusive?).to eq(false)
73
72
  end
74
73
  end
@@ -80,14 +79,14 @@ describe list_class do
80
79
 
81
80
  it "should return the sorted values of @should as a string if inclusive" do
82
81
  @property.should = ["foo", "bar"]
83
- @property.expects(:inclusive?).returns(true)
82
+ expect(@property).to receive(:inclusive?).and_return(true)
84
83
  expect(@property.should).to eq("bar,foo")
85
84
  end
86
85
 
87
86
  it "should return the uniq sorted values of @should + retrieve as a string if !inclusive" do
88
87
  @property.should = ["foo", "bar"]
89
- @property.expects(:inclusive?).returns(false)
90
- @property.expects(:retrieve).returns(["foo","baz"])
88
+ expect(@property).to receive(:inclusive?).and_return(false)
89
+ expect(@property).to receive(:retrieve).and_return(["foo","baz"])
91
90
  expect(@property.should).to eq("bar,baz,foo")
92
91
  end
93
92
  end
@@ -95,25 +94,25 @@ describe list_class do
95
94
  describe "when calling retrieve" do
96
95
  let(:provider) { @provider }
97
96
  before do
98
- @provider = mock("provider")
99
- @property.stubs(:provider).returns(provider)
97
+ @provider = double("provider")
98
+ allow(@property).to receive(:provider).and_return(provider)
100
99
  end
101
100
 
102
101
  it "should send 'name' to the provider" do
103
- @provider.expects(:send).with(:group)
104
- @property.expects(:name).returns(:group)
102
+ expect(@provider).to receive(:send).with(:group)
103
+ expect(@property).to receive(:name).and_return(:group)
105
104
  @property.retrieve
106
105
  end
107
106
 
108
107
  it "should return an array with the provider returned info" do
109
- @provider.stubs(:send).with(:group).returns("foo,bar,baz")
110
- @property.stubs(:name).returns(:group)
108
+ allow(@provider).to receive(:send).with(:group).and_return("foo,bar,baz")
109
+ allow(@property).to receive(:name).and_return(:group)
111
110
  @property.retrieve == ["foo", "bar", "baz"]
112
111
  end
113
112
 
114
113
  it "should return :absent when the provider returns :absent" do
115
- @provider.stubs(:send).with(:group).returns(:absent)
116
- @property.stubs(:name).returns(:group)
114
+ allow(@provider).to receive(:send).with(:group).and_return(:absent)
115
+ allow(@property).to receive(:name).and_return(:group)
117
116
  @property.retrieve == :absent
118
117
  end
119
118
 
@@ -137,35 +136,35 @@ describe list_class do
137
136
 
138
137
  it "should call prepare_is_for_comparison with value passed in and should" do
139
138
  @property.should = "foo"
140
- @property.expects(:prepare_is_for_comparison).with("bar")
141
- @property.expects(:should)
139
+ expect(@property).to receive(:prepare_is_for_comparison).with("bar")
140
+ expect(@property).to receive(:should)
142
141
  @property.safe_insync?("bar")
143
142
  end
144
143
 
145
144
  it "should return true if 'is' value is array of comma delimited should values" do
146
145
  @property.should = "bar,foo"
147
- @property.expects(:inclusive?).returns(true)
146
+ expect(@property).to receive(:inclusive?).and_return(true)
148
147
  expect(@property).to be_safe_insync(["bar","foo"])
149
148
  end
150
149
 
151
150
  it "should return true if 'is' value is :absent and should value is empty string" do
152
151
  @property.should = ""
153
- @property.expects(:inclusive?).returns(true)
152
+ expect(@property).to receive(:inclusive?).and_return(true)
154
153
  expect(@property).to be_safe_insync([])
155
154
  end
156
155
 
157
156
  it "should return false if prepared value != should value" do
158
157
  @property.should = "bar,baz,foo"
159
- @property.expects(:inclusive?).returns(true)
158
+ expect(@property).to receive(:inclusive?).and_return(true)
160
159
  expect(@property).to_not be_safe_insync(["bar","foo"])
161
160
  end
162
161
  end
163
162
 
164
163
  describe "when calling dearrayify" do
165
164
  it "should sort and join the array with 'delimiter'" do
166
- array = mock "array"
167
- array.expects(:sort).returns(array)
168
- array.expects(:join).with(@property.delimiter)
165
+ array = double("array")
166
+ expect(array).to receive(:sort).and_return(array)
167
+ expect(array).to receive(:join).with(@property.delimiter)
169
168
  @property.dearrayify(array)
170
169
  end
171
170
  end
@@ -1,22 +1,18 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/property/ordered_list'
5
4
 
6
- ordered_list_class = Puppet::Property::OrderedList
7
-
8
- describe ordered_list_class do
9
-
5
+ describe Puppet::Property::OrderedList do
10
6
  it "should be a subclass of List" do
11
- expect(ordered_list_class.superclass).to eq(Puppet::Property::List)
7
+ expect(described_class.superclass).to eq(Puppet::Property::List)
12
8
  end
13
9
 
14
10
  describe "as an instance" do
15
11
  before do
16
12
  # Wow that's a messy interface to the resource.
17
- ordered_list_class.initvars
18
- @resource = stub 'resource', :[]= => nil, :property => nil
19
- @property = ordered_list_class.new(:resource => @resource)
13
+ described_class.initvars
14
+ @resource = double('resource', :[]= => nil, :property => nil)
15
+ @property = described_class.new(:resource => @resource)
20
16
  end
21
17
 
22
18
  describe "when adding should to current" do
@@ -40,22 +36,22 @@ describe ordered_list_class do
40
36
 
41
37
  it "should return the values of @should (without sorting) as a string if inclusive" do
42
38
  @property.should = ["foo", "bar"]
43
- @property.expects(:inclusive?).returns(true)
39
+ expect(@property).to receive(:inclusive?).and_return(true)
44
40
  expect(@property.should).to eq("foo,bar")
45
41
  end
46
42
 
47
43
  it "should return the uniq values of @should + retrieve as a string if !inclusive with the @ values leading" do
48
44
  @property.should = ["foo", "bar"]
49
- @property.expects(:inclusive?).returns(false)
50
- @property.expects(:retrieve).returns(["foo","baz"])
45
+ expect(@property).to receive(:inclusive?).and_return(false)
46
+ expect(@property).to receive(:retrieve).and_return(["foo","baz"])
51
47
  expect(@property.should).to eq("foo,bar,baz")
52
48
  end
53
49
  end
54
50
 
55
51
  describe "when calling dearrayify" do
56
52
  it "should join the array with the delimiter" do
57
- array = mock "array"
58
- array.expects(:join).with(@property.delimiter)
53
+ array = double("array")
54
+ expect(array).to receive(:join).with(@property.delimiter)
59
55
  @property.dearrayify(array)
60
56
  end
61
57
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/property'
4
3
 
@@ -52,73 +51,73 @@ describe Puppet::Property do
52
51
 
53
52
  describe "when returning the default event name" do
54
53
  it "should use the current 'should' value to pick the event name" do
55
- property.expects(:should).returns "myvalue"
56
- subclass.expects(:value_option).with('myvalue', :event).returns :event_name
54
+ expect(property).to receive(:should).and_return("myvalue")
55
+ expect(subclass).to receive(:value_option).with('myvalue', :event).and_return(:event_name)
57
56
 
58
57
  property.event_name
59
58
  end
60
59
 
61
60
  it "should return any event defined with the specified value" do
62
- property.expects(:should).returns :myval
63
- subclass.expects(:value_option).with(:myval, :event).returns :event_name
61
+ expect(property).to receive(:should).and_return(:myval)
62
+ expect(subclass).to receive(:value_option).with(:myval, :event).and_return(:event_name)
64
63
 
65
64
  expect(property.event_name).to eq(:event_name)
66
65
  end
67
66
 
68
67
  describe "and the property is 'ensure'" do
69
68
  before :each do
70
- property.stubs(:name).returns :ensure
71
- resource.expects(:type).returns :mytype
69
+ allow(property).to receive(:name).and_return(:ensure)
70
+ expect(resource).to receive(:type).and_return(:mytype)
72
71
  end
73
72
 
74
73
  it "should use <type>_created if the 'should' value is 'present'" do
75
- property.expects(:should).returns :present
74
+ expect(property).to receive(:should).and_return(:present)
76
75
  expect(property.event_name).to eq(:mytype_created)
77
76
  end
78
77
 
79
78
  it "should use <type>_removed if the 'should' value is 'absent'" do
80
- property.expects(:should).returns :absent
79
+ expect(property).to receive(:should).and_return(:absent)
81
80
  expect(property.event_name).to eq(:mytype_removed)
82
81
  end
83
82
 
84
83
  it "should use <type>_changed if the 'should' value is not 'absent' or 'present'" do
85
- property.expects(:should).returns :foo
84
+ expect(property).to receive(:should).and_return(:foo)
86
85
  expect(property.event_name).to eq(:mytype_changed)
87
86
  end
88
87
 
89
88
  it "should use <type>_changed if the 'should value is nil" do
90
- property.expects(:should).returns nil
89
+ expect(property).to receive(:should).and_return(nil)
91
90
  expect(property.event_name).to eq(:mytype_changed)
92
91
  end
93
92
  end
94
93
 
95
94
  it "should use <property>_changed if the property is not 'ensure'" do
96
- property.stubs(:name).returns :myparam
97
- property.expects(:should).returns :foo
95
+ allow(property).to receive(:name).and_return(:myparam)
96
+ expect(property).to receive(:should).and_return(:foo)
98
97
  expect(property.event_name).to eq(:myparam_changed)
99
98
  end
100
99
 
101
100
  it "should use <property>_changed if no 'should' value is set" do
102
- property.stubs(:name).returns :myparam
103
- property.expects(:should).returns nil
101
+ allow(property).to receive(:name).and_return(:myparam)
102
+ expect(property).to receive(:should).and_return(nil)
104
103
  expect(property.event_name).to eq(:myparam_changed)
105
104
  end
106
105
  end
107
106
 
108
107
  describe "when creating an event" do
109
108
  before :each do
110
- property.stubs(:should).returns "myval"
109
+ allow(property).to receive(:should).and_return("myval")
111
110
  end
112
111
 
113
112
  it "should use an event from the resource as the base event" do
114
113
  event = Puppet::Transaction::Event.new
115
- resource.expects(:event).returns event
114
+ expect(resource).to receive(:event).and_return(event)
116
115
 
117
116
  expect(property.event).to equal(event)
118
117
  end
119
118
 
120
119
  it "should have the default event name" do
121
- property.expects(:event_name).returns :my_event
120
+ expect(property).to receive(:event_name).and_return(:my_event)
122
121
  expect(property.event.name).to eq(:my_event)
123
122
  end
124
123
 
@@ -127,23 +126,23 @@ describe Puppet::Property do
127
126
  end
128
127
 
129
128
  it "should have the 'should' value set" do
130
- property.stubs(:should).returns "foo"
129
+ allow(property).to receive(:should).and_return("foo")
131
130
  expect(property.event.desired_value).to eq("foo")
132
131
  end
133
132
 
134
133
  it "should provide its path as the source description" do
135
- property.stubs(:path).returns "/my/param"
134
+ allow(property).to receive(:path).and_return("/my/param")
136
135
  expect(property.event.source_description).to eq("/my/param")
137
136
  end
138
137
 
139
138
  it "should have the 'invalidate_refreshes' value set if set on a value" do
140
- property.stubs(:event_name).returns :my_event
141
- property.stubs(:should).returns "foo"
142
- foo = mock()
143
- foo.expects(:invalidate_refreshes).returns(true)
144
- collection = mock()
145
- collection.expects(:match?).with("foo").returns(foo)
146
- property.class.stubs(:value_collection).returns(collection)
139
+ allow(property).to receive(:event_name).and_return(:my_event)
140
+ allow(property).to receive(:should).and_return("foo")
141
+ foo = double()
142
+ expect(foo).to receive(:invalidate_refreshes).and_return(true)
143
+ collection = double()
144
+ expect(collection).to receive(:match?).with("foo").and_return(foo)
145
+ allow(property.class).to receive(:value_collection).and_return(collection)
147
146
  expect(property.event.invalidate_refreshes).to be_truthy
148
147
  end
149
148
 
@@ -167,15 +166,15 @@ describe Puppet::Property do
167
166
  end
168
167
 
169
168
  it "should validate each value separately" do
170
- property.expects(:validate).with("one")
171
- property.expects(:validate).with("two")
169
+ expect(property).to receive(:validate).with("one")
170
+ expect(property).to receive(:validate).with("two")
172
171
 
173
172
  property.value = %w{one two}
174
173
  end
175
174
 
176
175
  it "should munge each value separately and use any result as the actual value" do
177
- property.expects(:munge).with("one").returns :one
178
- property.expects(:munge).with("two").returns :two
176
+ expect(property).to receive(:munge).with("one").and_return(:one)
177
+ expect(property).to receive(:munge).with("two").and_return(:two)
179
178
 
180
179
  # Do this so we get the whole array back.
181
180
  subclass.array_matching = :all
@@ -272,7 +271,7 @@ describe Puppet::Property do
272
271
  it "should validate that all required features are present" do
273
272
  subclass.newvalue(:foo, :required_features => [:a, :b])
274
273
 
275
- resource.provider.expects(:satisfies?).with([:a, :b]).returns true
274
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(true)
276
275
 
277
276
  property.should = :foo
278
277
  end
@@ -280,7 +279,7 @@ describe Puppet::Property do
280
279
  it "should fail if required features are missing" do
281
280
  subclass.newvalue(:foo, :required_features => [:a, :b])
282
281
 
283
- resource.provider.expects(:satisfies?).with([:a, :b]).returns false
282
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(false)
284
283
 
285
284
  expect { property.should = :foo }.to raise_error(Puppet::Error)
286
285
  end
@@ -288,7 +287,7 @@ describe Puppet::Property do
288
287
  it "should internally raise an ArgumentError if required features are missing" do
289
288
  subclass.newvalue(:foo, :required_features => [:a, :b])
290
289
 
291
- resource.provider.expects(:satisfies?).with([:a, :b]).returns false
290
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(false)
292
291
 
293
292
  expect { property.validate_features_per_value :foo }.to raise_error(ArgumentError)
294
293
  end
@@ -296,7 +295,7 @@ describe Puppet::Property do
296
295
  it "should validate that all required features are present for regexes" do
297
296
  subclass.newvalue(/./, :required_features => [:a, :b])
298
297
 
299
- resource.provider.expects(:satisfies?).with([:a, :b]).returns true
298
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(true)
300
299
 
301
300
  property.should = "foo"
302
301
  end
@@ -304,7 +303,7 @@ describe Puppet::Property do
304
303
  it "should support specifying an individual required feature" do
305
304
  subclass.newvalue(/./, :required_features => :a)
306
305
 
307
- resource.provider.expects(:satisfies?).returns true
306
+ expect(resource.provider).to receive(:satisfies?).and_return(true)
308
307
 
309
308
  property.should = "foo"
310
309
  end
@@ -341,7 +340,7 @@ describe Puppet::Property do
341
340
  it "should set the value" do
342
341
  subclass.newvalue(:foo)
343
342
  property.should = :foo
344
- property.expects(:set).with(:foo)
343
+ expect(property).to receive(:set).with(:foo)
345
344
  property.sync
346
345
  end
347
346
  end
@@ -370,13 +369,13 @@ describe Puppet::Property do
370
369
  describe "that was defined without a block" do
371
370
  it "should call the settor on the provider" do
372
371
  subclass.newvalue(:bar)
373
- resource.provider.expects(:foo=).with :bar
372
+ expect(resource.provider).to receive(:foo=).with(:bar)
374
373
  property.set(:bar)
375
374
  end
376
375
 
377
376
  it "should generate setter named from :method argument and propagate call to the provider" do
378
377
  subclass.newvalue(:bar, :method => 'set_vv')
379
- resource.provider.expects(:foo=).with :bar
378
+ expect(resource.provider).to receive(:foo=).with(:bar)
380
379
  property.set_vv(:bar)
381
380
  end
382
381
  end
@@ -384,13 +383,13 @@ describe Puppet::Property do
384
383
  describe "that was defined with a block" do
385
384
  it "should call the method created for the value if the value is not a regex" do
386
385
  subclass.newvalue(:bar) {}
387
- property.expects(:set_bar)
386
+ expect(property).to receive(:set_bar)
388
387
  property.set(:bar)
389
388
  end
390
389
 
391
390
  it "should call the provided block if the value is a regex" do
392
- subclass.newvalue(/./) { self.test }
393
- property.expects(:test)
391
+ subclass.newvalue(/./) { test }
392
+ expect(property).to receive(:test)
394
393
  property.set("foo")
395
394
  end
396
395
  end
@@ -547,7 +546,7 @@ describe Puppet::Property do
547
546
 
548
547
  describe "#insync_values?" do
549
548
  it "should log an exception when insync? throws one" do
550
- property.expects(:insync?).raises ArgumentError
549
+ expect(property).to receive(:insync?).and_raise(ArgumentError)
551
550
  expect(property.insync_values?("foo","bar")).to be nil
552
551
  end
553
552
  end
@@ -156,7 +156,7 @@ describe 'Puppet::Provider::AixObject' do
156
156
  provider.instance_variable_set(:@object_info, { :foo => 'foo', :baz => 'baz' })
157
157
 
158
158
  (provider.class.mappings[:aix_attribute].keys + [:attributes]).each do |property|
159
- provider.expects(:get).with(property).returns('value')
159
+ expect(provider).to receive(:get).with(property).and_return('value')
160
160
 
161
161
  expect(provider.send(property)).to eql('value')
162
162
  end
@@ -167,7 +167,7 @@ describe 'Puppet::Provider::AixObject' do
167
167
 
168
168
  value = '15'
169
169
  provider.class.mappings[:aix_attribute].keys.each do |property|
170
- provider.expects(:set).with(property, value)
170
+ expect(provider).to receive(:set).with(property, value)
171
171
 
172
172
  provider.send("#{property}=".to_sym, value)
173
173
  end
@@ -295,8 +295,8 @@ bin:2
295
295
 
296
296
  it 'lists all of the objects' do
297
297
  lscmd = 'lsgroups'
298
- provider.class.stubs(:command).with(:list).returns(lscmd)
299
- provider.class.stubs(:execute).with([lscmd, '-c', '-a', 'id', 'ALL']).returns(output)
298
+ allow(provider.class).to receive(:command).with(:list).and_return(lscmd)
299
+ allow(provider.class).to receive(:execute).with([lscmd, '-c', '-a', 'id', 'ALL']).and_return(output)
300
300
 
301
301
  expected_objects = [
302
302
  { :name => 'system', :id => '0' },
@@ -316,7 +316,7 @@ bin:2
316
316
  end
317
317
 
318
318
  it 'returns all of the available instances' do
319
- provider.class.stubs(:list_all).returns(objects)
319
+ allow(provider.class).to receive(:list_all).and_return(objects)
320
320
 
321
321
  expect(provider.class.instances.map(&:name)).to eql(['group1', 'group2'])
322
322
  end
@@ -419,20 +419,20 @@ bin:2
419
419
 
420
420
  describe '#ia_module_args' do
421
421
  it 'returns no arguments if the ia_load_module parameter is not specified' do
422
- provider.resource.stubs(:[]).with(:ia_load_module).returns(nil)
422
+ allow(provider.resource).to receive(:[]).with(:ia_load_module).and_return(nil)
423
423
  expect(provider.ia_module_args).to eql([])
424
424
  end
425
425
 
426
426
  it 'returns the ia_load_module as a CLI argument' do
427
- provider.resource.stubs(:[]).with(:ia_load_module).returns('module')
427
+ allow(provider.resource).to receive(:[]).with(:ia_load_module).and_return('module')
428
428
  expect(provider.ia_module_args).to eql(['-R', 'module'])
429
429
  end
430
430
  end
431
431
 
432
432
  describe '#lscmd' do
433
433
  it 'returns the lscmd' do
434
- provider.class.stubs(:command).with(:list).returns('list')
435
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
434
+ allow(provider.class).to receive(:command).with(:list).and_return('list')
435
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
436
436
 
437
437
  expect(provider.lscmd).to eql(
438
438
  ['list', '-c', 'ia_module_args', provider.resource.name]
@@ -449,8 +449,8 @@ bin:2
449
449
  end
450
450
 
451
451
  it 'returns the addcmd passing in the attributes as CLI arguments' do
452
- provider.class.stubs(:command).with(:add).returns('add')
453
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
452
+ allow(provider.class).to receive(:command).with(:add).and_return('add')
453
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
454
454
 
455
455
  expect(provider.addcmd(attributes)).to eql(
456
456
  ['add', 'ia_module_args', 'attribute1=value1', 'attribute2=value2', provider.resource.name]
@@ -460,8 +460,8 @@ bin:2
460
460
 
461
461
  describe '#deletecmd' do
462
462
  it 'returns the lscmd' do
463
- provider.class.stubs(:command).with(:delete).returns('delete')
464
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
463
+ allow(provider.class).to receive(:command).with(:delete).and_return('delete')
464
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
465
465
 
466
466
  expect(provider.deletecmd).to eql(
467
467
  ['delete', 'ia_module_args', provider.resource.name]
@@ -478,8 +478,8 @@ bin:2
478
478
  end
479
479
 
480
480
  it 'returns the addcmd passing in the attributes as CLI arguments' do
481
- provider.class.stubs(:command).with(:modify).returns('modify')
482
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
481
+ allow(provider.class).to receive(:command).with(:modify).and_return('modify')
482
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
483
483
 
484
484
  expect(provider.modifycmd(attributes)).to eql(
485
485
  ['modify', 'ia_module_args', 'attribute1=value1', 'attribute2=value2', provider.resource.name]
@@ -496,9 +496,9 @@ bin:2
496
496
  end
497
497
 
498
498
  it 'modifies the AIX object with the new attributes' do
499
- provider.stubs(:modifycmd).with(new_attributes).returns('modify_cmd')
500
- provider.expects(:execute).with('modify_cmd')
501
- provider.expects(:object_info).with(true)
499
+ allow(provider).to receive(:modifycmd).with(new_attributes).and_return('modify_cmd')
500
+ expect(provider).to receive(:execute).with('modify_cmd')
501
+ expect(provider).to receive(:object_info).with(true)
502
502
 
503
503
  provider.modify_object(new_attributes)
504
504
  end
@@ -516,20 +516,20 @@ bin:2
516
516
  end
517
517
 
518
518
  it 'returns :absent if the AIX object does not exist' do
519
- provider.stubs(:exists?).returns(false)
519
+ allow(provider).to receive(:exists?).and_return(false)
520
520
  object_info[property] = 15
521
521
 
522
522
  expect(provider.get(property)).to eql(:absent)
523
523
  end
524
524
 
525
525
  it 'returns :absent if the property is not present on the system' do
526
- provider.stubs(:exists?).returns(true)
526
+ allow(provider).to receive(:exists?).and_return(true)
527
527
 
528
528
  expect(provider.get(property)).to eql(:absent)
529
529
  end
530
530
 
531
531
  it "returns the property's value" do
532
- provider.stubs(:exists?).returns(true)
532
+ allow(provider).to receive(:exists?).and_return(true)
533
533
  object_info[property] = 15
534
534
 
535
535
  expect(provider.get(property)).to eql(15)
@@ -557,9 +557,9 @@ bin:2
557
557
  end
558
558
 
559
559
  it "raises a Puppet::Error if it fails to set the property's value" do
560
- provider.stubs(:modify_object)
560
+ allow(provider).to receive(:modify_object)
561
561
  .with({ :id => value.to_s })
562
- .raises(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
562
+ .and_raise(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
563
563
 
564
564
  expect { provider.set(property, value) }.to raise_error do |error|
565
565
  expect(error).to be_a(Puppet::Error)
@@ -567,7 +567,7 @@ bin:2
567
567
  end
568
568
 
569
569
  it "sets the given property's value to the passed-in value" do
570
- provider.expects(:modify_object).with({ :id => value.to_s })
570
+ expect(provider).to receive(:modify_object).with({ :id => value.to_s })
571
571
 
572
572
  provider.set(property, value)
573
573
  end
@@ -618,9 +618,9 @@ bin:2
618
618
  end
619
619
 
620
620
  it 'raises a Puppet::Error if it fails to set the new AIX attributes' do
621
- provider.stubs(:modify_object)
621
+ allow(provider).to receive(:modify_object)
622
622
  .with(new_attributes)
623
- .raises(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
623
+ .and_raise(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
624
624
 
625
625
  expect { provider.attributes = new_attributes }.to raise_error do |error|
626
626
  expect(error).to be_a(Puppet::Error)
@@ -630,7 +630,7 @@ bin:2
630
630
  end
631
631
 
632
632
  it 'sets the new AIX attributes' do
633
- provider.expects(:modify_object).with(new_attributes)
633
+ expect(provider).to receive(:modify_object).with(new_attributes)
634
634
 
635
635
  provider.attributes = new_attributes
636
636
  end
@@ -650,7 +650,7 @@ bin:2
650
650
  )
651
651
 
652
652
  # Mock out our lscmd
653
- provider.stubs(:lscmd).returns("lsuser #{resource[:name]}")
653
+ allow(provider).to receive(:lscmd).and_return("lsuser #{resource[:name]}")
654
654
  end
655
655
 
656
656
  it 'memoizes the result' do
@@ -659,7 +659,7 @@ bin:2
659
659
  end
660
660
 
661
661
  it 'returns nil if the AIX object does not exist' do
662
- provider.stubs(:execute).with(provider.lscmd).raises(
662
+ allow(provider).to receive(:execute).with(provider.lscmd).and_raise(
663
663
  Puppet::ExecutionFailure, 'lscmd failed!'
664
664
  )
665
665
 
@@ -668,7 +668,7 @@ bin:2
668
668
 
669
669
  it 'collects the Puppet properties' do
670
670
  output = 'mock_output'
671
- provider.stubs(:execute).with(provider.lscmd).returns(output)
671
+ allow(provider).to receive(:execute).with(provider.lscmd).and_return(output)
672
672
 
673
673
  # Mock the AIX attributes on the system
674
674
  mock_attributes = {
@@ -677,9 +677,9 @@ bin:2
677
677
  :attribute1 => 'value1',
678
678
  :attribute2 => 'value2'
679
679
  }
680
- provider.class.stubs(:parse_aix_objects)
680
+ allow(provider.class).to receive(:parse_aix_objects)
681
681
  .with(output)
682
- .returns([{ :name => resource.name, :attributes => mock_attributes }])
682
+ .and_return([{ :name => resource.name, :attributes => mock_attributes }])
683
683
 
684
684
  expected_property_values = {
685
685
  :uid => 1,
@@ -696,12 +696,12 @@ bin:2
696
696
 
697
697
  describe '#exists?' do
698
698
  it 'should return true if the AIX object exists' do
699
- provider.stubs(:object_info).returns({})
699
+ allow(provider).to receive(:object_info).and_return({})
700
700
  expect(provider.exists?).to be(true)
701
701
  end
702
702
 
703
703
  it 'should return false if the AIX object does not exist' do
704
- provider.stubs(:object_info).returns(nil)
704
+ allow(provider).to receive(:object_info).and_return(nil)
705
705
  expect(provider.exists?).to be(false)
706
706
  end
707
707
  end
@@ -710,9 +710,11 @@ bin:2
710
710
  let(:property_attributes) do
711
711
  {}
712
712
  end
713
+
713
714
  def stub_attributes_property(attributes)
714
- provider.resource.stubs(:should).with(:attributes).returns(attributes)
715
+ allow(provider.resource).to receive(:should).with(:attributes).and_return(attributes)
715
716
  end
717
+
716
718
  def set_property(puppet_property, aix_attribute, property_to_attribute, should_value = nil)
717
719
  property_to_attribute ||= lambda { |x| x }
718
720
 
@@ -721,7 +723,7 @@ bin:2
721
723
  aix_attribute: aix_attribute,
722
724
  property_to_attribute: property_to_attribute
723
725
  )
724
- provider.resource.stubs(:should).with(puppet_property).returns(should_value)
726
+ allow(provider.resource).to receive(:should).with(puppet_property).and_return(should_value)
725
727
 
726
728
  if should_value
727
729
  property_attributes[aix_attribute] = property_to_attribute.call(should_value)
@@ -753,8 +755,8 @@ bin:2
753
755
  end
754
756
 
755
757
  it "raises a Puppet::Error if it fails to create the AIX object" do
756
- provider.stubs(:addcmd)
757
- provider.stubs(:execute).raises(
758
+ allow(provider).to receive(:addcmd)
759
+ allow(provider).to receive(:execute).and_raise(
758
760
  Puppet::ExecutionFailure, "addcmd failed!"
759
761
  )
760
762
 
@@ -769,10 +771,10 @@ bin:2
769
771
  attributes = { :fsize => 1000 }
770
772
  stub_attributes_property(attributes)
771
773
 
772
- provider.expects(:addcmd)
774
+ expect(provider).to receive(:addcmd)
773
775
  .with(attributes.merge(property_attributes))
774
- .returns('addcmd')
775
- provider.expects(:execute).with('addcmd')
776
+ .and_return('addcmd')
777
+ expect(provider).to receive(:execute).with('addcmd')
776
778
 
777
779
  provider.create
778
780
  end
@@ -780,11 +782,11 @@ bin:2
780
782
 
781
783
  describe "#delete" do
782
784
  before(:each) do
783
- provider.stubs(:deletecmd).returns('deletecmd')
785
+ allow(provider).to receive(:deletecmd).and_return('deletecmd')
784
786
  end
785
787
 
786
788
  it "raises a Puppet::Error if it fails to delete the AIX object" do
787
- provider.stubs(:execute).with(provider.deletecmd).raises(
789
+ allow(provider).to receive(:execute).with(provider.deletecmd).and_raise(
788
790
  Puppet::ExecutionFailure, "deletecmd failed!"
789
791
  )
790
792
 
@@ -796,8 +798,8 @@ bin:2
796
798
  end
797
799
 
798
800
  it "deletes the AIX object" do
799
- provider.expects(:execute).with(provider.deletecmd)
800
- provider.expects(:object_info).with(true)
801
+ expect(provider).to receive(:execute).with(provider.deletecmd)
802
+ expect(provider).to receive(:object_info).with(true)
801
803
 
802
804
  provider.delete
803
805
  end