puppet 5.5.12-universal-darwin → 5.5.13-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/application/doc'
@@ -8,9 +7,9 @@ require 'puppet/util/rdoc'
8
7
  describe Puppet::Application::Doc do
9
8
  before :each do
10
9
  @doc = Puppet::Application[:doc]
11
- @doc.stubs(:puts)
10
+ allow(@doc).to receive(:puts)
12
11
  @doc.preinit
13
- Puppet::Util::Log.stubs(:newdestination)
12
+ allow(Puppet::Util::Log).to receive(:newdestination)
14
13
  end
15
14
 
16
15
  it "should declare an other command" do
@@ -56,49 +55,49 @@ describe Puppet::Application::Doc do
56
55
  end
57
56
 
58
57
  it "should store argument value when calling handle_#{option}" do
59
- @doc.options.expects(:[]=).with(option, 'arg')
58
+ expect(@doc.options).to receive(:[]=).with(option, 'arg')
60
59
  @doc.send("handle_#{option}".to_sym, 'arg')
61
60
  end
62
61
  end
63
62
 
64
63
  it "should store the format if valid" do
65
- Puppet::Util::Reference.stubs(:method_defined?).with('to_format').returns(true)
64
+ allow(Puppet::Util::Reference).to receive(:method_defined?).with('to_format').and_return(true)
66
65
 
67
66
  @doc.handle_format('format')
68
67
  expect(@doc.options[:format]).to eq('to_format')
69
68
  end
70
69
 
71
70
  it "should raise an error if the format is not valid" do
72
- Puppet::Util::Reference.stubs(:method_defined?).with('to_format').returns(false)
71
+ allow(Puppet::Util::Reference).to receive(:method_defined?).with('to_format').and_return(false)
73
72
  expect { @doc.handle_format('format') }.to raise_error(RuntimeError, /Invalid output format/)
74
73
  end
75
74
 
76
75
  it "should store the mode if valid" do
77
- Puppet::Util::Reference.stubs(:modes).returns(stub('mode', :include? => true))
76
+ allow(Puppet::Util::Reference).to receive(:modes).and_return(double('mode', :include? => true))
78
77
 
79
78
  @doc.handle_mode('mode')
80
79
  expect(@doc.options[:mode]).to eq(:mode)
81
80
  end
82
81
 
83
82
  it "should store the mode if :rdoc" do
84
- Puppet::Util::Reference.modes.stubs(:include?).with('rdoc').returns(false)
83
+ allow(Puppet::Util::Reference.modes).to receive(:include?).with('rdoc').and_return(false)
85
84
 
86
85
  @doc.handle_mode('rdoc')
87
86
  expect(@doc.options[:mode]).to eq(:rdoc)
88
87
  end
89
88
 
90
89
  it "should raise an error if the mode is not valid" do
91
- Puppet::Util::Reference.modes.stubs(:include?).with('unknown').returns(false)
90
+ allow(Puppet::Util::Reference.modes).to receive(:include?).with('unknown').and_return(false)
92
91
  expect { @doc.handle_mode('unknown') }.to raise_error(RuntimeError, /Invalid output mode/)
93
92
  end
94
93
 
95
94
  it "should list all references on list and exit" do
96
- reference = stubs 'reference'
97
- ref = stubs 'ref'
98
- Puppet::Util::Reference.stubs(:references).returns([reference])
95
+ reference = double('reference')
96
+ ref = double('ref')
97
+ allow(Puppet::Util::Reference).to receive(:references).and_return([reference])
99
98
 
100
- Puppet::Util::Reference.expects(:reference).with(reference).returns(ref)
101
- ref.expects(:doc)
99
+ expect(Puppet::Util::Reference).to receive(:reference).with(reference).and_return(ref)
100
+ expect(ref).to receive(:doc)
102
101
 
103
102
  expect { @doc.handle_list(nil) }.to exit_with 0
104
103
  end
@@ -113,15 +112,14 @@ describe Puppet::Application::Doc do
113
112
  end
114
113
 
115
114
  describe "during setup" do
116
-
117
115
  before :each do
118
- Puppet::Log.stubs(:newdestination)
119
- @doc.command_line.stubs(:args).returns([])
116
+ allow(Puppet::Log).to receive(:newdestination)
117
+ allow(@doc.command_line).to receive(:args).and_return([])
120
118
  end
121
119
 
122
120
  it "should default to rdoc mode if there are command line arguments" do
123
- @doc.command_line.stubs(:args).returns(["1"])
124
- @doc.stubs(:setup_rdoc)
121
+ allow(@doc.command_line).to receive(:args).and_return(["1"])
122
+ allow(@doc).to receive(:setup_rdoc)
125
123
 
126
124
  @doc.setup
127
125
  expect(@doc.options[:mode]).to eq(:rdoc)
@@ -130,7 +128,7 @@ describe Puppet::Application::Doc do
130
128
  it "should call setup_rdoc in rdoc mode" do
131
129
  @doc.options[:mode] = :rdoc
132
130
 
133
- @doc.expects(:setup_rdoc)
131
+ expect(@doc).to receive(:setup_rdoc)
134
132
 
135
133
  @doc.setup
136
134
  end
@@ -138,14 +136,14 @@ describe Puppet::Application::Doc do
138
136
  it "should call setup_reference if not rdoc" do
139
137
  @doc.options[:mode] = :test
140
138
 
141
- @doc.expects(:setup_reference)
139
+ expect(@doc).to receive(:setup_reference)
142
140
 
143
141
  @doc.setup
144
142
  end
145
143
 
146
144
  describe "configuring logging" do
147
145
  before :each do
148
- Puppet::Util::Log.stubs(:newdestination)
146
+ allow(Puppet::Util::Log).to receive(:newdestination)
149
147
  end
150
148
 
151
149
  describe "with --debug" do
@@ -159,7 +157,7 @@ describe Puppet::Application::Doc do
159
157
  end
160
158
 
161
159
  it "should set log destination to console" do
162
- Puppet::Util::Log.expects(:newdestination).with(:console)
160
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:console)
163
161
  @doc.setup
164
162
  end
165
163
  end
@@ -175,7 +173,7 @@ describe Puppet::Application::Doc do
175
173
  end
176
174
 
177
175
  it "should set log destination to console" do
178
- Puppet::Util::Log.expects(:newdestination).with(:console)
176
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:console)
179
177
  @doc.setup
180
178
  end
181
179
  end
@@ -192,7 +190,7 @@ describe Puppet::Application::Doc do
192
190
  end
193
191
 
194
192
  it "should set log destination to console" do
195
- Puppet::Util::Log.expects(:newdestination).with(:console)
193
+ expect(Puppet::Util::Log).to receive(:newdestination).with(:console)
196
194
  @doc.setup
197
195
  end
198
196
  end
@@ -201,11 +199,11 @@ describe Puppet::Application::Doc do
201
199
  describe "in non-rdoc mode" do
202
200
  it "should get all non-dynamic reference if --all" do
203
201
  @doc.options[:all] = true
204
- static = stub 'static', :dynamic? => false
205
- dynamic = stub 'dynamic', :dynamic? => true
206
- Puppet::Util::Reference.stubs(:reference).with(:static).returns(static)
207
- Puppet::Util::Reference.stubs(:reference).with(:dynamic).returns(dynamic)
208
- Puppet::Util::Reference.stubs(:references).returns([:static,:dynamic])
202
+ static = double('static', :dynamic? => false)
203
+ dynamic = double('dynamic', :dynamic? => true)
204
+ allow(Puppet::Util::Reference).to receive(:reference).with(:static).and_return(static)
205
+ allow(Puppet::Util::Reference).to receive(:reference).with(:dynamic).and_return(dynamic)
206
+ allow(Puppet::Util::Reference).to receive(:references).and_return([:static,:dynamic])
209
207
 
210
208
  @doc.setup_reference
211
209
  expect(@doc.options[:references]).to eq([:static])
@@ -221,7 +219,7 @@ describe Puppet::Application::Doc do
221
219
  describe "when there are unknown args" do
222
220
  it "should expand --modulepath if any" do
223
221
  @doc.unknown_args = [ { :opt => "--modulepath", :arg => "path" } ]
224
- Puppet.settings.stubs(:handlearg)
222
+ allow(Puppet.settings).to receive(:handlearg)
225
223
 
226
224
  @doc.setup_rdoc
227
225
 
@@ -230,7 +228,7 @@ describe Puppet::Application::Doc do
230
228
 
231
229
  it "should give them to Puppet.settings" do
232
230
  @doc.unknown_args = [ { :opt => :option, :arg => :argument } ]
233
- Puppet.settings.expects(:handlearg).with(:option,:argument)
231
+ expect(Puppet.settings).to receive(:handlearg).with(:option,:argument)
234
232
 
235
233
  @doc.setup_rdoc
236
234
  end
@@ -255,16 +253,16 @@ describe Puppet::Application::Doc do
255
253
 
256
254
  before :each do
257
255
  @doc.manifest = false
258
- Puppet.stubs(:info)
256
+ allow(Puppet).to receive(:info)
259
257
  Puppet[:trace] = false
260
258
  Puppet[:modulepath] = modules
261
259
  Puppet[:manifest] = manifests
262
260
  @doc.options[:all] = false
263
261
  @doc.options[:outputdir] = 'doc'
264
262
  @doc.options[:charset] = nil
265
- Puppet.settings.stubs(:define_settings)
266
- Puppet::Util::RDoc.stubs(:rdoc)
267
- @doc.command_line.stubs(:args).returns([])
263
+ allow(Puppet.settings).to receive(:define_settings)
264
+ allow(Puppet::Util::RDoc).to receive(:rdoc)
265
+ allow(@doc.command_line).to receive(:args).and_return([])
268
266
  end
269
267
 
270
268
  around(:each) do |example|
@@ -277,31 +275,31 @@ describe Puppet::Application::Doc do
277
275
 
278
276
  it "should set document_all on --all" do
279
277
  @doc.options[:all] = true
280
- Puppet.settings.expects(:[]=).with(:document_all, true)
278
+ expect(Puppet.settings).to receive(:[]=).with(:document_all, true)
281
279
 
282
280
  expect { @doc.rdoc }.to exit_with(0)
283
281
  end
284
282
 
285
283
  it "should call Puppet::Util::RDoc.rdoc in full mode" do
286
- Puppet::Util::RDoc.expects(:rdoc).with('doc', [modules, manifests], nil)
284
+ expect(Puppet::Util::RDoc).to receive(:rdoc).with('doc', [modules, manifests], nil)
287
285
  expect { @doc.rdoc }.to exit_with(0)
288
286
  end
289
287
 
290
288
  it "should call Puppet::Util::RDoc.rdoc with a charset if --charset has been provided" do
291
289
  @doc.options[:charset] = 'utf-8'
292
- Puppet::Util::RDoc.expects(:rdoc).with('doc', [modules, manifests], "utf-8")
290
+ expect(Puppet::Util::RDoc).to receive(:rdoc).with('doc', [modules, manifests], "utf-8")
293
291
  expect { @doc.rdoc }.to exit_with(0)
294
292
  end
295
293
 
296
294
  it "should call Puppet::Util::RDoc.rdoc in full mode with outputdir set to doc if no --outputdir" do
297
295
  @doc.options[:outputdir] = false
298
- Puppet::Util::RDoc.expects(:rdoc).with('doc', [modules, manifests], nil)
296
+ expect(Puppet::Util::RDoc).to receive(:rdoc).with('doc', [modules, manifests], nil)
299
297
  expect { @doc.rdoc }.to exit_with(0)
300
298
  end
301
299
 
302
300
  it "should call Puppet::Util::RDoc.manifestdoc in manifest mode" do
303
301
  @doc.manifest = true
304
- Puppet::Util::RDoc.expects(:manifestdoc)
302
+ expect(Puppet::Util::RDoc).to receive(:manifestdoc)
305
303
  expect { @doc.rdoc }.to exit_with(0)
306
304
  end
307
305
 
@@ -312,7 +310,7 @@ describe Puppet::Application::Doc do
312
310
  [modules, modules2],
313
311
  "envmanifests/site.pp")
314
312
  Puppet.override({:environments => Puppet::Environments::Static.new(env), :current_environment => env}) do
315
- Puppet::Util::RDoc.stubs(:rdoc).with('doc', [modules.to_s, modules2.to_s, env.manifest.to_s], nil)
313
+ allow(Puppet::Util::RDoc).to receive(:rdoc).with('doc', [modules.to_s, modules2.to_s, env.manifest.to_s], nil)
316
314
  expect { @doc.rdoc }.to exit_with(0)
317
315
  end
318
316
  end
@@ -320,14 +318,14 @@ describe Puppet::Application::Doc do
320
318
 
321
319
  describe "in the other modes" do
322
320
  it "should get reference in given format" do
323
- reference = stub 'reference'
321
+ reference = double('reference')
324
322
  @doc.options[:mode] = :none
325
323
  @doc.options[:references] = [:ref]
326
- Puppet::Util::Reference.expects(:reference).with(:ref).returns(reference)
324
+ expect(Puppet::Util::Reference).to receive(:reference).with(:ref).and_return(reference)
327
325
  @doc.options[:format] = :format
328
- @doc.stubs(:exit)
326
+ allow(@doc).to receive(:exit)
329
327
 
330
- reference.expects(:send).with { |format,contents| format == :format }.returns('doc')
328
+ expect(reference).to receive(:send).with(:format, anything).and_return('doc')
331
329
  @doc.other
332
330
  end
333
331
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/application/face_base'
4
3
  require 'tmpdir'
@@ -9,8 +8,8 @@ end
9
8
  describe Puppet::Application::FaceBase do
10
9
  let :app do
11
10
  app = Puppet::Application::FaceBase::Basetest.new
12
- app.command_line.stubs(:subcommand_name).returns('subcommand')
13
- Puppet::Util::Log.stubs(:newdestination)
11
+ allow(app.command_line).to receive(:subcommand_name).and_return('subcommand')
12
+ allow(Puppet::Util::Log).to receive(:newdestination)
14
13
  app
15
14
  end
16
15
 
@@ -20,8 +19,8 @@ describe Puppet::Application::FaceBase do
20
19
 
21
20
  describe "#find_global_settings_argument" do
22
21
  it "should not match --ca to --ca-location" do
23
- option = mock('ca option', :optparse_args => ["--ca"])
24
- Puppet.settings.expects(:each).yields(:ca, option)
22
+ option = double('ca option', :optparse_args => ["--ca"])
23
+ expect(Puppet.settings).to receive(:each).and_yield(:ca, option)
25
24
 
26
25
  expect(app.find_global_settings_argument("--ca-location")).to be_nil
27
26
  end
@@ -29,7 +28,7 @@ describe Puppet::Application::FaceBase do
29
28
 
30
29
  describe "#parse_options" do
31
30
  before :each do
32
- app.command_line.stubs(:args).returns %w{}
31
+ allow(app.command_line).to receive(:args).and_return(%w{})
33
32
  end
34
33
 
35
34
  describe "with just an action" do
@@ -40,8 +39,8 @@ describe Puppet::Application::FaceBase do
40
39
  #
41
40
  # It would be nice to fix this elsewhere, but it is actually hard to
42
41
  # capture this in rspec 2.5 and all. :( --daniel 2011-04-08
43
- Signal.stubs(:trap)
44
- app.command_line.stubs(:args).returns %w{foo}
42
+ allow(Signal).to receive(:trap)
43
+ allow(app.command_line).to receive(:args).and_return(%w{foo})
45
44
  app.preinit
46
45
  app.parse_options
47
46
  end
@@ -57,7 +56,7 @@ describe Puppet::Application::FaceBase do
57
56
  end
58
57
 
59
58
  it "should stop if the first thing found is not an action" do
60
- app.command_line.stubs(:args).returns %w{banana count_args}
59
+ allow(app.command_line).to receive(:args).and_return(%w{banana count_args})
61
60
 
62
61
  expect { app.run }.to exit_with(1)
63
62
 
@@ -65,29 +64,29 @@ describe Puppet::Application::FaceBase do
65
64
  end
66
65
 
67
66
  it "should use the default action if not given any arguments" do
68
- app.command_line.stubs(:args).returns []
69
- action = stub(:options => [], :render_as => nil)
70
- Puppet::Face[:basetest, '0.0.1'].expects(:get_default_action).returns(action)
71
- app.stubs(:main)
67
+ allow(app.command_line).to receive(:args).and_return([])
68
+ action = double(:options => [], :render_as => nil)
69
+ expect(Puppet::Face[:basetest, '0.0.1']).to receive(:get_default_action).and_return(action)
70
+ allow(app).to receive(:main)
72
71
  app.run
73
72
  expect(app.action).to eq(action)
74
73
  expect(app.arguments).to eq([ { } ])
75
74
  end
76
75
 
77
76
  it "should use the default action if not given a valid one" do
78
- app.command_line.stubs(:args).returns %w{bar}
79
- action = stub(:options => [], :render_as => nil)
80
- Puppet::Face[:basetest, '0.0.1'].expects(:get_default_action).returns(action)
81
- app.stubs(:main)
77
+ allow(app.command_line).to receive(:args).and_return(%w{bar})
78
+ action = double(:options => [], :render_as => nil)
79
+ expect(Puppet::Face[:basetest, '0.0.1']).to receive(:get_default_action).and_return(action)
80
+ allow(app).to receive(:main)
82
81
  app.run
83
82
  expect(app.action).to eq(action)
84
83
  expect(app.arguments).to eq([ 'bar', { } ])
85
84
  end
86
85
 
87
86
  it "should have no action if not given a valid one and there is no default action" do
88
- app.command_line.stubs(:args).returns %w{bar}
89
- Puppet::Face[:basetest, '0.0.1'].expects(:get_default_action).returns(nil)
90
- app.stubs(:main)
87
+ allow(app.command_line).to receive(:args).and_return(%w{bar})
88
+ expect(Puppet::Face[:basetest, '0.0.1']).to receive(:get_default_action).and_return(nil)
89
+ allow(app).to receive(:main)
91
90
  expect { app.run }.to exit_with(1)
92
91
  expect(@logs.first.message).to match(/has no 'bar' action./)
93
92
  end
@@ -95,9 +94,9 @@ describe Puppet::Application::FaceBase do
95
94
  [%w{something_I_cannot_do},
96
95
  %w{something_I_cannot_do argument}].each do |input|
97
96
  it "should report unknown actions nicely" do
98
- app.command_line.stubs(:args).returns input
99
- Puppet::Face[:basetest, '0.0.1'].expects(:get_default_action).returns(nil)
100
- app.stubs(:main)
97
+ allow(app.command_line).to receive(:args).and_return(input)
98
+ expect(Puppet::Face[:basetest, '0.0.1']).to receive(:get_default_action).and_return(nil)
99
+ allow(app).to receive(:main)
101
100
  expect { app.run }.to exit_with(1)
102
101
  expect(@logs.first.message).to match(/has no 'something_I_cannot_do' action/)
103
102
  end
@@ -106,40 +105,40 @@ describe Puppet::Application::FaceBase do
106
105
  [%w{something_I_cannot_do --unknown-option},
107
106
  %w{something_I_cannot_do argument --unknown-option}].each do |input|
108
107
  it "should report unknown actions even if there are unknown options" do
109
- app.command_line.stubs(:args).returns input
110
- Puppet::Face[:basetest, '0.0.1'].expects(:get_default_action).returns(nil)
111
- app.stubs(:main)
108
+ allow(app.command_line).to receive(:args).and_return(input)
109
+ expect(Puppet::Face[:basetest, '0.0.1']).to receive(:get_default_action).and_return(nil)
110
+ allow(app).to receive(:main)
112
111
  expect { app.run }.to exit_with(1)
113
112
  expect(@logs.first.message).to match(/has no 'something_I_cannot_do' action/)
114
113
  end
115
114
  end
116
115
 
117
116
  it "should report a sensible error when options with = fail" do
118
- app.command_line.stubs(:args).returns %w{--action=bar foo}
117
+ allow(app.command_line).to receive(:args).and_return(%w{--action=bar foo})
119
118
  expect { app.preinit; app.parse_options }.
120
119
  to raise_error(OptionParser::InvalidOption, /invalid option: --action/)
121
120
  end
122
121
 
123
122
  it "should fail if an action option is before the action" do
124
- app.command_line.stubs(:args).returns %w{--action foo}
123
+ allow(app.command_line).to receive(:args).and_return(%w{--action foo})
125
124
  expect { app.preinit; app.parse_options }.
126
125
  to raise_error(OptionParser::InvalidOption, /invalid option: --action/)
127
126
  end
128
127
 
129
128
  it "should fail if an unknown option is before the action" do
130
- app.command_line.stubs(:args).returns %w{--bar foo}
129
+ allow(app.command_line).to receive(:args).and_return(%w{--bar foo})
131
130
  expect { app.preinit; app.parse_options }.
132
131
  to raise_error(OptionParser::InvalidOption, /invalid option: --bar/)
133
132
  end
134
133
 
135
134
  it "should fail if an unknown option is after the action" do
136
- app.command_line.stubs(:args).returns %w{foo --bar}
135
+ allow(app.command_line).to receive(:args).and_return(%w{foo --bar})
137
136
  expect { app.preinit; app.parse_options }.
138
137
  to raise_error(OptionParser::InvalidOption, /invalid option: --bar/)
139
138
  end
140
139
 
141
140
  it "should accept --bar as an argument to a mandatory option after action" do
142
- app.command_line.stubs(:args).returns %w{foo --mandatory --bar}
141
+ allow(app.command_line).to receive(:args).and_return(%w{foo --mandatory --bar})
143
142
  app.preinit
144
143
  app.parse_options
145
144
  expect(app.action.name).to eq(:foo)
@@ -147,7 +146,7 @@ describe Puppet::Application::FaceBase do
147
146
  end
148
147
 
149
148
  it "should accept --bar as an argument to a mandatory option before action" do
150
- app.command_line.stubs(:args).returns %w{--mandatory --bar foo}
149
+ allow(app.command_line).to receive(:args).and_return(%w{--mandatory --bar foo})
151
150
  app.preinit
152
151
  app.parse_options
153
152
  expect(app.action.name).to eq(:foo)
@@ -155,13 +154,13 @@ describe Puppet::Application::FaceBase do
155
154
  end
156
155
 
157
156
  it "should not skip when --foo=bar is given" do
158
- app.command_line.stubs(:args).returns %w{--mandatory=bar --bar foo}
157
+ allow(app.command_line).to receive(:args).and_return(%w{--mandatory=bar --bar foo})
159
158
  expect { app.preinit; app.parse_options }.
160
159
  to raise_error(OptionParser::InvalidOption, /invalid option: --bar/)
161
160
  end
162
161
 
163
162
  it "does not skip when a puppet global setting is given as one item" do
164
- app.command_line.stubs(:args).returns %w{--confdir=/tmp/puppet foo}
163
+ allow(app.command_line).to receive(:args).and_return(%w{--confdir=/tmp/puppet foo})
165
164
  app.preinit
166
165
  app.parse_options
167
166
  expect(app.action.name).to eq(:foo)
@@ -169,7 +168,7 @@ describe Puppet::Application::FaceBase do
169
168
  end
170
169
 
171
170
  it "does not skip when a puppet global setting is given as two items" do
172
- app.command_line.stubs(:args).returns %w{--confdir /tmp/puppet foo}
171
+ allow(app.command_line).to receive(:args).and_return(%w{--confdir /tmp/puppet foo})
173
172
  app.preinit
174
173
  app.parse_options
175
174
  expect(app.action.name).to eq(:foo)
@@ -177,7 +176,7 @@ describe Puppet::Application::FaceBase do
177
176
  end
178
177
 
179
178
  it "should not add :debug to the application-level options" do
180
- app.command_line.stubs(:args).returns %w{--confdir /tmp/puppet foo --debug}
179
+ allow(app.command_line).to receive(:args).and_return(%w{--confdir /tmp/puppet foo --debug})
181
180
  app.preinit
182
181
  app.parse_options
183
182
  expect(app.action.name).to eq(:foo)
@@ -185,7 +184,7 @@ describe Puppet::Application::FaceBase do
185
184
  end
186
185
 
187
186
  it "should not add :verbose to the application-level options" do
188
- app.command_line.stubs(:args).returns %w{--confdir /tmp/puppet foo --verbose}
187
+ allow(app.command_line).to receive(:args).and_return(%w{--confdir /tmp/puppet foo --verbose})
189
188
  app.preinit
190
189
  app.parse_options
191
190
  expect(app.action.name).to eq(:foo)
@@ -196,7 +195,7 @@ describe Puppet::Application::FaceBase do
196
195
  "boolean options after" => %w{foo --trace}
197
196
  }.each do |name, args|
198
197
  it "should accept global boolean settings #{name} the action" do
199
- app.command_line.stubs(:args).returns args
198
+ allow(app.command_line).to receive(:args).and_return(args)
200
199
  Puppet.settings.initialize_global_settings(args)
201
200
  app.preinit
202
201
  app.parse_options
@@ -208,7 +207,7 @@ describe Puppet::Application::FaceBase do
208
207
  " after" => %w{foo --syslogfacility user1}
209
208
  }.each do |name, args|
210
209
  it "should accept global settings with arguments #{name} the action" do
211
- app.command_line.stubs(:args).returns args
210
+ allow(app.command_line).to receive(:args).and_return(args)
212
211
  Puppet.settings.initialize_global_settings(args)
213
212
  app.preinit
214
213
  app.parse_options
@@ -217,7 +216,7 @@ describe Puppet::Application::FaceBase do
217
216
  end
218
217
 
219
218
  it "should handle application-level options" do
220
- app.command_line.stubs(:args).returns %w{--verbose return_true}
219
+ allow(app.command_line).to receive(:args).and_return(%w{--verbose return_true})
221
220
  app.preinit
222
221
  app.parse_options
223
222
  expect(app.face.name).to eq(:basetest)
@@ -226,7 +225,7 @@ describe Puppet::Application::FaceBase do
226
225
 
227
226
  describe "#setup" do
228
227
  it "should remove the action name from the arguments" do
229
- app.command_line.stubs(:args).returns %w{--mandatory --bar foo}
228
+ allow(app.command_line).to receive(:args).and_return(%w{--mandatory --bar foo})
230
229
  app.preinit
231
230
  app.parse_options
232
231
  app.setup
@@ -235,7 +234,7 @@ describe Puppet::Application::FaceBase do
235
234
 
236
235
  it "should pass positional arguments" do
237
236
  myargs = %w{--mandatory --bar foo bar baz quux}
238
- app.command_line.stubs(:args).returns(myargs)
237
+ allow(app.command_line).to receive(:args).and_return(myargs)
239
238
  app.preinit
240
239
  app.parse_options
241
240
  app.setup
@@ -245,7 +244,7 @@ describe Puppet::Application::FaceBase do
245
244
 
246
245
  describe "#main" do
247
246
  before :each do
248
- app.stubs(:puts) # don't dump text to screen.
247
+ allow(app).to receive(:puts) # don't dump text to screen.
249
248
 
250
249
  app.face = Puppet::Face[:basetest, '0.0.1']
251
250
  app.action = app.face.get_action(:foo)
@@ -253,41 +252,41 @@ describe Puppet::Application::FaceBase do
253
252
  end
254
253
 
255
254
  it "should send the specified verb and name to the face" do
256
- app.face.expects(:foo).with(*app.arguments)
255
+ expect(app.face).to receive(:foo).with(*app.arguments)
257
256
  expect { app.main }.to exit_with(0)
258
257
  end
259
258
 
260
259
  it "should lookup help when it cannot do anything else" do
261
260
  app.action = nil
262
- Puppet::Face[:help, :current].expects(:help).with(:basetest)
261
+ expect(Puppet::Face[:help, :current]).to receive(:help).with(:basetest)
263
262
  expect { app.main }.to exit_with(1)
264
263
  end
265
264
 
266
265
  it "should use its render method to render any result" do
267
- app.expects(:render).with(app.arguments.length + 1, ["myname", "myarg"])
266
+ expect(app).to receive(:render).with(app.arguments.length + 1, ["myname", "myarg"])
268
267
  expect { app.main }.to exit_with(0)
269
268
  end
270
269
 
271
270
  it "should issue a deprecation warning if the face is deprecated" do
272
271
  # since app is shared across examples, stub to avoid affecting shared context
273
- app.face.stubs(:deprecated?).returns(true)
274
- app.face.expects(:foo).with(*app.arguments)
275
- Puppet.expects(:deprecation_warning).with(regexp_matches(/'puppet basetest' is deprecated/))
272
+ allow(app.face).to receive(:deprecated?).and_return(true)
273
+ expect(app.face).to receive(:foo).with(*app.arguments)
274
+ expect(Puppet).to receive(:deprecation_warning).with(/'puppet basetest' is deprecated/)
276
275
  expect { app.main }.to exit_with(0)
277
276
  end
278
277
 
279
278
  it "should not issue a deprecation warning if the face is not deprecated" do
280
- Puppet.expects(:deprecation_warning).never
279
+ expect(Puppet).not_to receive(:deprecation_warning)
281
280
  # since app is shared across examples, stub to avoid affecting shared context
282
- app.face.stubs(:deprecated?).returns(false)
283
- app.face.expects(:foo).with(*app.arguments)
281
+ allow(app.face).to receive(:deprecated?).and_return(false)
282
+ expect(app.face).to receive(:foo).with(*app.arguments)
284
283
  expect { app.main }.to exit_with(0)
285
284
  end
286
285
  end
287
286
 
288
287
  describe "error reporting" do
289
288
  before :each do
290
- app.stubs(:puts) # don't dump text to screen.
289
+ allow(app).to receive(:puts) # don't dump text to screen.
291
290
 
292
291
  app.render_as = :json
293
292
  app.face = Puppet::Face[:basetest, '0.0.1']
@@ -411,25 +410,25 @@ EOT
411
410
  end
412
411
 
413
412
  it "should fail early if asked to render an invalid format" do
414
- app.command_line.stubs(:args).returns %w{--render-as interpretive-dance return_true}
413
+ allow(app.command_line).to receive(:args).and_return(%w{--render-as interpretive-dance return_true})
415
414
  # We shouldn't get here, thanks to the exception, and our expectation on
416
415
  # it, but this helps us fail if that slips up and all. --daniel 2011-04-27
417
- Puppet::Face[:help, :current].expects(:help).never
416
+ expect(Puppet::Face[:help, :current]).not_to receive(:help)
418
417
 
419
- Puppet.expects(:err).with("Could not parse application options: I don't know how to render 'interpretive-dance'")
418
+ expect(Puppet).to receive(:err).with("Could not parse application options: I don't know how to render 'interpretive-dance'")
420
419
 
421
420
  expect { app.run }.to exit_with(1)
422
421
  end
423
422
 
424
423
  it "should work if asked to render json" do
425
- app.command_line.stubs(:args).returns %w{count_args a b c --render-as json}
424
+ allow(app.command_line).to receive(:args).and_return(%w{count_args a b c --render-as json})
426
425
  expect {
427
426
  expect { app.run }.to exit_with(0)
428
427
  }.to have_printed(/3/)
429
428
  end
430
429
 
431
430
  it "should invoke when_rendering hook 's' when asked to render-as 's'" do
432
- app.command_line.stubs(:args).returns %w{with_s_rendering_hook --render-as s}
431
+ allow(app.command_line).to receive(:args).and_return(%w{with_s_rendering_hook --render-as s})
433
432
  app.action = app.face.get_action(:with_s_rendering_hook)
434
433
  expect {
435
434
  expect { app.run }.to exit_with(0)
@@ -439,14 +438,14 @@ EOT
439
438
 
440
439
  describe "#help" do
441
440
  it "should generate help for --help" do
442
- app.command_line.stubs(:args).returns %w{--help}
443
- Puppet::Face[:help, :current].expects(:help)
441
+ allow(app.command_line).to receive(:args).and_return(%w{--help})
442
+ expect(Puppet::Face[:help, :current]).to receive(:help)
444
443
  expect { app.run }.to exit_with(0)
445
444
  end
446
445
 
447
446
  it "should generate help for -h" do
448
- app.command_line.stubs(:args).returns %w{-h}
449
- Puppet::Face[:help, :current].expects(:help)
447
+ allow(app.command_line).to receive(:args).and_return(%w{-h})
448
+ expect(Puppet::Face[:help, :current]).to receive(:help)
450
449
  expect { app.run }.to exit_with(0)
451
450
  end
452
451
  end