mongoid 7.2.1 → 9.0.0

data/spec/mongoid/contextual/atomic_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -8,15 +8,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#add_to_set" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave" ])
+      Band.create!(members: [ "Dave" ])
     end
 
     let!(:new_order) do
-      Band.create(members: [ "Peter" ])
+      Band.create!(members: [ "Peter" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     context "when the criteria has no sorting" do
@@ -78,7 +78,6 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let(:criteria) do
         Band.where(members: [ "DAVE" ]).collation(locale: 'en_US', strength: 2)
@@ -105,15 +104,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#add_each_to_set" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave" ])
+      Band.create!(members: [ "Dave" ])
     end
 
     let!(:new_order) do
-      Band.create(members: [ "Peter" ])
+      Band.create!(members: [ "Peter" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     context "when the criteria has no sorting" do
@@ -175,7 +174,6 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let(:criteria) do
         Band.where(members: [ "DAVE" ]).collation(locale: 'en_US', strength: 2)
@@ -202,7 +200,7 @@ describe Mongoid::Contextual::Atomic do
   describe "#bit" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let(:criteria) do
@@ -247,10 +245,9 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ], likes: 60)
+        Band.create!(members: [ "Dave" ], likes: 60)
       end
 
       let(:criteria) do
@@ -274,15 +271,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#inc" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let!(:beatles) do
-      Band.create(years: 2)
+      Band.create!(years: 2)
     end
 
     let(:criteria) do
@@ -307,7 +304,7 @@ describe Mongoid::Contextual::Atomic do
     context "when the field does not exist" do
 
       it "does not error on the inc" do
-        expect(smiths.likes).to be_nil
+        expect(smiths.reload.likes).to be == 10
       end
     end
 
@@ -327,10 +324,9 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -351,14 +347,71 @@ describe Mongoid::Contextual::Atomic do
     end
   end
 
+  describe "#mul" do
+
+    let!(:depeche_mode) { Band.create!(likes: 60) }
+    let!(:smiths) { Band.create! }
+    let!(:beatles) { Band.create!(years: 2) }
+
+    let(:criteria) { Band.all }
+    let(:context) { Mongoid::Contextual::Mongo.new(criteria) }
+
+    before { context.mul(likes: 10) }
+
+    context "when the field exists" do
+
+      it "muls the value" do
+        expect(depeche_mode.reload.likes).to eq(600)
+      end
+    end
+
+    context "when the field does not exist" do
+
+      it "sets undefined fields to zero" do
+        expect(smiths.reload.likes).to be == 0
+      end
+    end
+
+    context "when using the alias" do
+
+      before do
+        context.mul(years: 2)
+      end
+
+      it "muls the value and read from alias" do
+        expect(beatles.reload.years).to eq(4)
+      end
+
+      it "muls the value and read from field" do
+        expect(beatles.reload.y).to eq(4)
+      end
+    end
+
+    context 'when the criteria has a collation' do
+
+      let!(:depeche_mode) { Band.create!(members: [ "Dave" ], years: 3) }
+      let(:criteria) do
+        Band.where(members: [ "DAVE" ]).collation(locale: 'en_US', strength: 2)
+      end
+
+      let(:context) { Mongoid::Contextual::Mongo.new(criteria) }
+
+      before { context.mul(years: 2) }
+
+      it "muls the value" do
+        expect(depeche_mode.reload.years).to eq(6)
+      end
+    end
+  end
+
   describe "#pop" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Martin" ])
+      Band.create!(members: [ "Dave", "Martin" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -400,10 +453,9 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -427,11 +479,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#pull" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Alan" ])
+      Band.create!(members: [ "Dave", "Alan" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -455,10 +507,9 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -484,11 +535,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -513,10 +564,9 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let(:criteria) do
@@ -542,11 +592,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -571,14 +621,13 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -608,11 +657,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -637,14 +686,13 @@ describe Mongoid::Contextual::Atomic do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -670,11 +718,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -686,27 +734,26 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -718,15 +765,15 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
   end
@@ -734,11 +781,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#set" do
 
     let!(:depeche_mode) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -753,12 +800,25 @@ describe Mongoid::Contextual::Atomic do
       context.set(name: "Recoil")
     end
 
-    it "sets existing fields" do
-      expect(depeche_mode.reload.name).to eq("Recoil")
+    shared_examples 'writes as expected' do
+      it "sets existing fields" do
+        expect(depeche_mode.reload.name).to eq("Recoil")
+      end
+
+      it "sets non existent fields" do
+        expect(smiths.reload.name).to eq("Recoil")
+      end
     end
 
-    it "sets non existent fields" do
-      expect(smiths.reload.name).to eq("Recoil")
+    include_examples 'writes as expected'
+
+    context 'when fields being set have been projected out' do
+
+      let(:criteria) do
+        Band.only(:genres)
+      end
+
+      include_examples 'writes as expected'
     end
   end
 
@@ -767,11 +827,11 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting a single field" do
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do
@@ -788,27 +848,28 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name)
         end
 
-        it "unsets the first existing field" do
-          expect(depeche_mode.reload.name).to be_nil
-        end
-
-        it "unsets the last existing field" do
-          expect(new_order.reload.name).to be_nil
+        it "unsets the fields from all documents" do
+          depeche_mode.reload
+          new_order.reload
+          expect(depeche_mode.name).to be_nil
+          expect(depeche_mode.years).to_not be_nil
+          expect(new_order.name).to be_nil
+          expect(new_order.years).to_not be_nil
         end
       end
 
       context "when the field is aliased" do
-
         before do
           context.unset(:years)
         end
 
-        it "unsets the first existing field" do
-          expect(depeche_mode.reload.years).to be_nil
-        end
-
-        it "unsets the last existing field" do
-          expect(new_order.reload.years).to be_nil
+        it "unsets the fields from all documents" do
+          depeche_mode.reload
+          new_order.reload
+          expect(depeche_mode.name).to_not be_nil
+          expect(depeche_mode.years).to be_nil
+          expect(new_order.name).to_not be_nil
+          expect(new_order.years).to be_nil
         end
       end
     end
@@ -816,7 +877,8 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting multiple fields" do
 
       let!(:new_order) do
-        Band.create(name: "New Order", genres: [ "electro", "dub" ], years: 10)
+        Band.create!(name: "New Order", genres: %w[electro dub], years: 10,
+          likes: 200, rating: 4.3, origin: 'Space')
       end
 
       let(:criteria) do
@@ -833,12 +895,13 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name, :genres)
         end
 
-        it "unsets name field" do
-          expect(new_order.reload.name).to be_nil
-        end
-
-        it "unsets genres field" do
-          expect(new_order.reload.genres).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to be_nil
+          expect(new_order.years).to_not be_nil
+          expect(new_order.likes).to_not be_nil
+          expect(new_order.rating).to_not be_nil
         end
       end
 
@@ -848,25 +911,58 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name, :years)
         end
 
-        it "unsets the unaliased field" do
-          expect(new_order.reload.name).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to_not be_nil
+          expect(new_order.rating).to_not be_nil
+        end
+      end
+
+      context "when using Hash arguments" do
+
+        before do
+          context.unset({ years: true, likes: "" }, { rating: false, origin: nil })
+        end
+
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to_not be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to be_nil
+          expect(new_order.rating).to be_nil
+          expect(new_order.origin).to be_nil
+        end
+      end
+
+      context "when mixing argument types" do
+
+        before do
+          context.unset(:name, [:years], { likes: "" }, { rating: false })
         end
 
-        it "unsets the aliased field" do
-          expect(new_order.reload.years).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to be_nil
+          expect(new_order.rating).to be_nil
         end
       end
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do
@@ -882,8 +978,154 @@ describe Mongoid::Contextual::Atomic do
       end
 
       it "unsets the unaliased field" do
-        expect(depeche_mode.reload.name).to be_nil
+        depeche_mode.reload
+        expect(depeche_mode.name).to be_nil
+        expect(depeche_mode.years).to_not be_nil
+      end
+    end
+  end
+
+  describe '#set_min' do
+    let(:member_count) { 5 }
+    let(:views) { 25_000 }
+    let(:founded) { 2.years.ago.to_date }
+    let(:decimal) { 3.1415 }
+
+    let!(:band) do
+      Band.create!(
+        member_count: member_count,
+        founded: founded,
+        views: views)
+    end
+
+    let(:criteria) { Band.all }
+    let(:context) { Mongoid::Contextual::Mongo.new(criteria) }
+
+    shared_examples_for 'min-able comparisons' do
+      shared_examples_for 'a min-able context' do
+        it 'chooses the smaller value' do
+          context.send(min_method, "member_count" => given_members, views: given_views)
+          expect(band.reload.member_count).to be == [ member_count, given_members ].min
+          expect(band.views).to be == [ views, given_views ].min
+        end
+      end
+  
+      context 'when given value < existing value' do
+        let(:given_views) { views - 1 }
+        let(:given_members) { member_count - 1 }
+
+        it_behaves_like 'a min-able context'
+      end
+
+      context 'when given value == existing value' do
+        let(:given_views) { views }
+        let(:given_members) { member_count }
+
+        it_behaves_like 'a min-able context'
+      end
+
+      context 'when given value > existing value' do
+        let(:given_views) { views + 1 }
+        let(:given_members) { member_count + 1 }
+
+        it_behaves_like 'a min-able context'
+      end
+
+      context 'when the named field does not yet exist on the document' do
+        it 'sets the field to the argument' do
+          context.send(min_method, new_field: 100)
+          expect(band.reload.new_field).to be == 100
+        end
+      end
+
+      context 'when arguments are dates/times' do
+        it 'picks the earliest date' do
+          context.send(min_method, founded: founded - 1)
+          expect(band.reload.founded).to be == founded - 1
+        end
+      end
+    end
+
+    context 'as itself' do
+      let(:min_method) { :set_min }
+      include_examples 'min-able comparisons'
+    end
+
+    context 'as #clamp_upper_bound' do
+      let(:min_method) { :clamp_upper_bound }
+      include_examples 'min-able comparisons'
+    end
+  end
+
+  describe '#set_max' do
+    let(:member_count) { 5 }
+    let(:views) { 25_000 }
+    let(:founded) { 2.years.ago.to_date }
+    let(:decimal) { 3.1415 }
+
+    let!(:band) do
+      Band.create!(
+        member_count: member_count,
+        founded: founded,
+        views: views)
+    end
+
+    let(:criteria) { Band.all }
+    let(:context) { Mongoid::Contextual::Mongo.new(criteria) }
+
+    shared_examples_for 'max-able comparisons' do
+      shared_examples_for 'a max-able context' do
+        it 'chooses the larger value' do
+          context.send(max_method, "member_count" => given_members, views: given_views)
+          expect(band.reload.member_count).to be == [ member_count, given_members ].max
+          expect(band.views).to be == [ views, given_views ].max
+        end
       end
+
+      context 'when given value < existing value' do
+        let(:given_views) { views - 1 }
+        let(:given_members) { member_count - 1 }
+
+        it_behaves_like 'a max-able context'
+      end
+
+      context 'when given value == existing value' do
+        let(:given_views) { views }
+        let(:given_members) { member_count }
+
+        it_behaves_like 'a max-able context'
+      end
+
+      context 'when given value > existing value' do
+        let(:given_views) { views + 1 }
+        let(:given_members) { member_count + 1 }
+
+        it_behaves_like 'a max-able context'
+      end
+
+      context 'when the named field does not yet exist on the document' do
+        it 'sets the field to the argument' do
+          context.send(max_method, new_field: 100)
+          expect(band.reload.new_field).to be == 100
+        end
+      end
+
+      context 'when arguments are dates/times' do
+        it 'picks the earliest date' do
+          context.send(max_method, founded: founded + 1)
+          expect(band.reload.founded).to be == founded + 1
+        end
+      end
+    end
+
+    context 'as itself' do
+      let(:max_method) { :set_max }
+      include_examples 'max-able comparisons'
+    end
+
+    context 'as #clamp_lower_bound' do
+      let(:max_method) { :clamp_lower_bound }
+      include_examples 'max-able comparisons'
     end
   end
 end