mongoid 7.2.1 → 9.0.0

data/spec/mongoid/persistable/settable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -45,7 +45,7 @@ describe Mongoid::Persistable::Settable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:date) do
@@ -109,11 +109,11 @@ describe Mongoid::Persistable::Settable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t")
+        person.addresses.create!(street: "t")
       end
 
       let(:date) do
@@ -141,7 +141,7 @@ describe Mongoid::Persistable::Settable do
       context 'when the field is a relation' do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:pet) do
@@ -171,7 +171,7 @@ describe Mongoid::Persistable::Settable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(title: "sir", age: 30)
+        Person.create!(title: "sir", age: 30)
       end
 
       it "marks a dirty change for the set fields" do
@@ -181,11 +181,48 @@ describe Mongoid::Persistable::Settable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(title: "sir", age: 30)
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "title" => 1, "age" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.set(title: "miss", age: 21)
+          expect(person.title).to eq("miss")
+          expect(person.age).to eq(21)
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.set(title: "miss", age: 21)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 
   context "when dynamic attributes are not enabled" do
     let(:account) do
-      Account.create
+      Account.create!(name: 'Foobar')
     end
 
     it "raises exception for an unknown attribute " do
@@ -197,7 +234,7 @@ describe Mongoid::Persistable::Settable do
 
   context "when dynamic attributes enabled" do
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     it "updates non existing attribute" do
@@ -208,7 +245,7 @@ describe Mongoid::Persistable::Settable do
 
   context "with an attribute with private setter" do
     let(:agent) do
-      Agent.create
+      Agent.create!
     end
 
     let(:title) do
@@ -462,7 +499,7 @@ describe Mongoid::Persistable::Settable do
   context 'when the field is not already set locally' do
 
     let(:church) do
-      Church.create
+      Church.create!
     end
 
     context 'when the field is a Hash type' do
@@ -512,4 +549,34 @@ describe Mongoid::Persistable::Settable do
       end
     end
   end
+
+  context "when the field being set was projected out" do
+    let(:full_agent) do
+      Agent.create!(title: "Double-Oh Eight")
+    end
+
+    let(:agent) do
+      Agent.where(_id: full_agent.id).only(:dob).first
+    end
+
+    context 'field exists in database' do
+      it "raises AttributeNotLoaded" do
+        lambda do
+          agent.set(title: '008')
+        end.should raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Agent which was not loaded/)
+
+        expect(agent.reload.title).to eq 'Double-Oh Eight'
+      end
+    end
+
+    context 'field does not exist in database' do
+      it "raises AttributeNotLoaded" do
+        lambda do
+          agent.set(number: '008')
+        end.should raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'number' on Agent which was not loaded/)
+
+        expect(agent.reload.read_attribute(:number)).to be nil
+      end
+    end
+  end
 end

data/spec/mongoid/persistable/unsettable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -41,7 +41,7 @@ describe Mongoid::Persistable::Unsettable do
       end
 
       let(:person) do
-        Person.create(title: "test", age: 30, dob: date)
+        Person.create!(title: "test", age: 30, dob: date)
       end
 
       context "when provided a splat of symbols" do
@@ -111,11 +111,11 @@ describe Mongoid::Persistable::Unsettable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "kreuzberg", number: 40, city: "Berlin")
+        person.addresses.create!(street: "kreuzberg", number: 40, city: "Berlin")
       end
 
       context "when provided a splat of symbols" do
@@ -158,7 +158,7 @@ describe Mongoid::Persistable::Unsettable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(title: "sir", age: 30)
+        Person.create!(title: "sir", age: 30)
       end
 
       it "marks a dirty change for the unset fields" do
@@ -168,5 +168,41 @@ describe Mongoid::Persistable::Unsettable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(title: "sir", age: 30)
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "title" => 1, "age" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.unset(:title)
+          expect(person.title).to be nil
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.unset(:title)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/updatable_spec.rb

@@ -1,16 +1,19 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
+require "support/immutable_ids"
 
 describe Mongoid::Persistable::Updatable do
+  extend Mongoid::ImmutableIds
+  immutable_id_examples_as "persisted _ids are immutable"
 
   describe "#update_attribute" do
 
     context "when the field is aliased" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the setter is overridden" do
@@ -70,7 +73,7 @@ describe Mongoid::Persistable::Updatable do
     context "when setting an array field" do
 
       let(:person) do
-        Person.create(aliases: [])
+        Person.create!(aliases: [])
       end
 
       before do
@@ -118,7 +121,7 @@ describe Mongoid::Persistable::Updatable do
     context "when dynamic attributes are not enabled" do
 
       it "raises exception for an unknown attribute " do
-        account = Account.create
+        account = Account.create!(name: 'Foobar')
 
         expect {
           account.update_attribute(:somethingnew, "somethingnew")
@@ -126,7 +129,7 @@ describe Mongoid::Persistable::Updatable do
       end
 
       it "will update value of aliased field" do
-        person = Person.create
+        person = Person.create!
         person.update_attribute(:t, "test_value")
         expect(person.reload.t).to eq "test_value"
         expect(person.test).to eq "test_value"
@@ -232,21 +235,17 @@ describe Mongoid::Persistable::Updatable do
     end
 
     context "when persisting a localized field" do
+      with_default_i18n_configs
 
       let!(:product) do
-        Product.create(description: "The bomb")
+        Product.create!(description: "The bomb")
       end
 
       before do
-        I18n.enforce_available_locales = false
         ::I18n.locale = :de
         product.update_attribute(:description, "Die Bombe")
       end
 
-      after do
-        ::I18n.locale = :en
-      end
-
       let(:attributes) do
         product.attributes["description"]
       end
@@ -263,15 +262,15 @@ describe Mongoid::Persistable::Updatable do
     context "when updating a deeply embedded document" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "Winterfeldtstr")
+        person.addresses.create!(street: "Winterfeldtstr")
       end
 
       let!(:location) do
-        address.locations.create(name: "work")
+        address.locations.create!(name: "work")
       end
 
       let(:from_db) do
@@ -302,7 +301,7 @@ describe Mongoid::Persistable::Updatable do
       end
 
       let(:person) do
-        Person.create(species: :human)
+        Person.create!(species: :human)
       end
 
       it 'raises an error when trying to set the attribute' do
@@ -347,7 +346,7 @@ describe Mongoid::Persistable::Updatable do
     context 'when the field is loaded explicitly' do
 
       before do
-        Person.create(title: 'Captain')
+        Person.create!(title: 'Captain')
       end
 
       context 'when the loaded attribute is updated' do
@@ -401,7 +400,7 @@ describe Mongoid::Persistable::Updatable do
     context 'when fields are explicitly not loaded' do
 
       before do
-        Person.create(title: 'Captain')
+        Person.create!(title: 'Captain')
       end
 
       context 'when the loaded attribute is updated' do
@@ -430,7 +429,7 @@ describe Mongoid::Persistable::Updatable do
         it 'does not allow the field to be updated' do
           expect {
             person.update_attribute(:title, 'Esteemed')
-          }.to raise_exception(ActiveModel::MissingAttributeError)
+          }.to raise_exception(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Person which was not loaded/)
         end
 
         it 'does not persist the change' do
@@ -442,7 +441,7 @@ describe Mongoid::Persistable::Updatable do
           it 'does not allow the field to be updated' do
             expect {
               person.update_attribute('title', 'Esteemed')
-            }.to raise_exception(ActiveModel::MissingAttributeError)
+            }.to raise_exception(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Person which was not loaded/)
           end
 
           it 'does not persist the change' do
@@ -451,6 +450,14 @@ describe Mongoid::Persistable::Updatable do
         end
       end
     end
+
+    context 'when the field is _id' do
+      def invoke_operation!
+        object.update_attribute "_id", new_id_value
+      end
+
+      it_behaves_like "persisted _ids are immutable"
+    end
   end
 
   [:update_attributes, :update].each do |method|
@@ -458,45 +465,24 @@ describe Mongoid::Persistable::Updatable do
     describe "##{method}" do
 
       context "when saving with a hash field with invalid keys" do
+        max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
           expect {
-            person.update_attributes(map: { "$bad.key" => "value" })
+            person.update_attributes!(map: { "$bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
 
-      context "when validation passes" do
-
-        let(:person) do
-          Person.create
-        end
-
-        let!(:saved) do
-          person.update_attributes(pets: false)
-        end
-
-        let(:from_db) do
-          Person.find(person.id)
-        end
-
-        it "returns true" do
-          expect(saved).to be true
-        end
-
-        it "saves the attributes" do
-          expect(from_db.pets).to be false
-        end
-      end
-
       context "when the document has been destroyed" do
+        max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
@@ -509,7 +495,7 @@ describe Mongoid::Persistable::Updatable do
       context "when validation passes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:saved) do
@@ -532,7 +518,7 @@ describe Mongoid::Persistable::Updatable do
       context "when the document has been destroyed" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         before do
@@ -553,7 +539,7 @@ describe Mongoid::Persistable::Updatable do
         end
 
         let(:game) do
-          Game.create(person: person)
+          Game.create!(person: person)
         end
 
         before do
@@ -590,7 +576,7 @@ describe Mongoid::Persistable::Updatable do
         context "when providing an embedded child" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:name) do
@@ -617,11 +603,11 @@ describe Mongoid::Persistable::Updatable do
         context "when providing a parent to a referenced in" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:post) do
-            Post.create(title: "Testing")
+            Post.create!(title: "Testing")
           end
 
           context "when the relation has not yet been touched" do
@@ -682,7 +668,7 @@ describe Mongoid::Persistable::Updatable do
         before do
           phone_number.country_code = country_code
           person.phone_numbers << phone_number
-          person.save
+          person.save!
         end
 
         it "sets the first level document" do
@@ -720,6 +706,14 @@ describe Mongoid::Persistable::Updatable do
           end
         end
       end
+
+      context 'when the _id is one of the fields' do
+        def invoke_operation!
+          object.update_attributes _id: new_id_value
+        end
+  
+        it_behaves_like "persisted _ids are immutable"
+      end
     end
   end
 
@@ -738,4 +732,22 @@ describe Mongoid::Persistable::Updatable do
       end
     end
   end
+
+  describe "#update_attributes!" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:attributes) do
+      { security_code: 'secret' }
+    end
+
+    it 'calls update_attributes' do
+      person.should receive(:update_attributes).with(attributes).and_call_original
+      lambda do
+        person.update_attributes!(attributes)
+      end.should_not raise_error
+    end
+  end
 end

data/spec/mongoid/persistable/upsertable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -32,7 +32,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when a matching document exists in the db" do
@@ -43,8 +43,10 @@ describe Mongoid::Persistable::Upsertable do
           end
         end
 
+        let(:options) { {} }
+
         before do
-          updated.upsert
+          updated.upsert(options)
         end
 
         it "updates the existing document" do
@@ -54,6 +56,47 @@ describe Mongoid::Persistable::Upsertable do
         it "flags the document as persisted" do
           expect(existing).to be_persisted
         end
+
+        shared_examples "replaces the existing fields" do
+          it 'replaces the existing fields' do
+            Band.count.should == 1
+
+            existing.reload
+            existing.views.should be nil
+            existing.name.should == 'Tool'
+          end
+        end
+
+        shared_examples "retains the existing fields" do
+          it 'retains the existing fields' do
+            Band.count.should == 1
+
+            existing.reload
+            existing.views.should eq(42)
+            existing.name.should == 'Tool'
+          end
+        end
+
+        context 'when existing document contains other fields' do
+          let!(:existing) do
+            Band.create!(name: "Photek", views: 42)
+          end
+
+          context "when not passing any options" do
+            let(:options) { {} }
+            it_behaves_like "retains the existing fields"
+          end
+
+          context "when passing replace: false" do
+            let(:options) { { replace: false } }
+            it_behaves_like "retains the existing fields"
+          end
+
+          context "when passing replace: true" do
+            let(:options) { { replace: true } }
+            it_behaves_like "replaces the existing fields"
+          end
+        end
       end
 
       context "when no matching document exists in the db" do
@@ -83,7 +126,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is not new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when updating fields outside of the id" do
@@ -105,5 +148,82 @@ describe Mongoid::Persistable::Upsertable do
         end
       end
     end
+
+    context 'when `set_on_insert` is given' do
+      let!(:existing_document) { Band.create!(name: "They Might Be Giants") }
+      let!(:new_document) { Band.new(name: "Panic! at the Disco") }
+
+      context 'with `replace: true`' do
+        it 'should raise an ArgumentError' do
+          existing_document.name = "John and John"
+          expect {
+            existing_document.upsert(replace: true, set_on_insert: { member_count: 1 })
+          }.to raise_error(ArgumentError)
+        end
+      end
+
+      context 'without `replace: true`' do
+        context 'when document exists' do
+          it 'ignores set_on_insert' do
+            existing_document.name = "John and John"
+            existing_document.upsert(set_on_insert: { member_count: 1 })
+            expect(existing_document.reload.member_count).to be_nil
+          end
+        end
+
+        context 'when document does not exist' do
+          it 'applies set_on_insert' do
+            new_document.name = "Brendon Urie"
+            new_document.upsert(set_on_insert: { member_count: 1 })
+            expect(new_document.reload.member_count).to be == 1
+          end
+        end
+      end
+    end
+
+    context "when the document is readonly" do
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        let!(:existing) do
+          Band.create!(name: "Photek")
+        end
+
+        before do
+          existing.name = "Depeche Mode"
+        end
+
+        let!(:upsert) do
+          existing.upsert
+        end
+
+        it "updates the existing document" do
+          expect(existing.reload.name).to eq("Depeche Mode")
+        end
+
+        it "returns true" do
+          expect(upsert).to be true
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        let!(:existing) do
+          Band.create!(name: "Photek").tap(&:readonly!)
+        end
+
+        before do
+          existing.name = "Depeche Mode"
+        end
+
+        it 'raises a ReadonlyDocument error' do
+          expect do
+            existing.upsert
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end