mongoid 7.2.1 → 9.0.0

data/spec/mongoid/association/referenced/has_many_models.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 class HmmCompany
   include Mongoid::Document
@@ -24,8 +24,26 @@ class HmmAddress
   belongs_to :company, class_name: 'HmmCompany'
 end
 
+class HmmOwner
+  include Mongoid::Document
+
+  has_many :pets, class_name: 'HmmPet', inverse_of: :current_owner
+
+  field :name, type: String
+end
+
+class HmmPet
+  include Mongoid::Document
+
+  belongs_to :current_owner, class_name: 'HmmOwner', inverse_of: :pets, optional: true
+  belongs_to :previous_owner, class_name: 'HmmOwner', inverse_of: nil, optional: true
+
+  field :name, type: String
+end
+
 class HmmSchool
   include Mongoid::Document
+  include Mongoid::Timestamps
 
   has_many :students, class_name: 'HmmStudent'
 
@@ -35,8 +53,9 @@ end
 
 class HmmStudent
   include Mongoid::Document
+  include Mongoid::Timestamps
 
-  belongs_to :school, class_name: 'HmmSchool'
+  belongs_to :school, class_name: 'HmmSchool', touch: true
 
   field :name, type: String
   field :grade, type: Integer, default: 3
@@ -59,3 +78,21 @@ class HmmBusSeat
 
   # No belongs_to :bus
 end
+
+class HmmTrainer
+  include Mongoid::Document
+
+  field :name, type: String
+
+  has_many :animals, class_name: 'HmmAnimal', scope: :reptile
+end
+
+class HmmAnimal
+  include Mongoid::Document
+
+  field :taxonomy, type: String
+
+  scope :reptile, -> { where(taxonomy: 'reptile') }
+
+  belongs_to :trainer, class_name: 'HmmTrainer', scope: -> { where(name: 'Dave') }
+end

data/spec/mongoid/association/referenced/has_many_query_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 require_relative './has_many_models'
@@ -24,7 +24,7 @@ describe Mongoid::Association::Referenced::HasMany do
       # has a default value specified in the model
       expect do
         student.grade
-      end.to raise_error(ActiveModel::MissingAttributeError)
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded)
       expect(student.attributes.keys).to eq(['_id', 'name'])
     end
 

data/spec/mongoid/association/referenced/has_many_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
+require_relative './has_many_models'
 
 describe Mongoid::Association::Referenced::HasMany do
 
@@ -495,6 +496,27 @@ describe Mongoid::Association::Referenced::HasMany do
     end
   end
 
+  describe '#scope' do
+
+    context 'when scope is specified in the options' do
+
+      let(:options) do
+        { scope: -> { unscoped.where(foo: :bar) } }
+      end
+
+      it 'returns a Criteria Queryable Key' do
+        expect(association.scope).to be_a(Proc)
+      end
+    end
+
+    context 'when scope is not specified in the options' do
+
+      it 'returns nil' do
+        expect(association.scope).to be_nil
+      end
+    end
+  end
+
   describe '#as' do
 
     context 'when :as is specified in the options' do
@@ -1225,4 +1247,28 @@ describe Mongoid::Association::Referenced::HasMany do
       expect(association.create_relation(owner, target)).to be_a(Array)
     end
   end
+
+  context "when adding an object to the association" do
+    let!(:start_time) { Timecop.freeze(Time.at(Time.now.to_i)) }
+
+    let(:update_time) do
+      Timecop.freeze(Time.at(Time.now.to_i) + 2)
+    end
+
+    after do
+      Timecop.return
+    end
+
+    let!(:school) { HmmSchool.create! }
+    let!(:student) { HmmStudent.create! }
+
+    before do
+      update_time
+      student.update(school: school)
+    end
+
+    it "updates the updated_at" do
+      expect(student.updated_at).to eq(update_time)
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_one/binding_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/association/referenced/has_one/buildable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -15,14 +15,18 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       association.build(base, object)
     end
 
+    let(:options) do
+      {}
+    end
+
     let(:association) do
-      Mongoid::Association::Referenced::HasOne.new(Person, :account)
+      Mongoid::Association::Referenced::HasOne.new(Person, :account, options)
     end
 
     context "when provided an id" do
 
       let!(:account) do
-        Account.create!(person_id: object, name: 'banking')
+        Account.create!(person_id: object, name: 'banking', balance: 200)
       end
 
       let(:object) do
@@ -30,7 +34,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       end
 
       before do
-        expect(Account).to receive(:where).with(association.foreign_key => object).and_call_original
+        expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.foreign_key => object).and_call_original
       end
 
       it "sets the document" do
@@ -38,6 +42,46 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       end
     end
 
+    context "when scope is specified" do
+
+      let!(:account) do
+        Account.create!(person_id: object, name: 'banking', balance: 200)
+      end
+
+      let(:object) do
+        BSON::ObjectId.new
+      end
+
+      let(:options) do
+        {
+            scope: -> { gt(balance: 100) }
+        }
+      end
+
+      before do
+        expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.foreign_key => object).and_call_original
+        expect_any_instance_of(Mongoid::Criteria).to receive(:gt).with(balance: 100).and_call_original
+      end
+
+      context "when document satisfies scope" do
+
+        it "sets the document" do
+          expect(document).to eq(account)
+        end
+      end
+
+      context "when document does not satisfy scope" do
+
+        let!(:account) do
+          Account.create!(person_id: object, name: 'banking', balance: 50)
+        end
+
+        it "returns nil" do
+          expect(document).to eq(nil)
+        end
+      end
+    end
+
     context "when provided a object" do
 
       let(:object) do
@@ -48,7 +92,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
         expect(document).to eq(object)
       end
 
-      context 'when the object is already related to another object' do
+      context 'when the object is already associated with another object' do
 
         let(:original_person) do
           Person.new
@@ -62,7 +106,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
           association.build(Person.new, object)
         end
 
-        it 'clears the object of its previous relation' do
+        it 'clears the object of its previous association' do
           expect(original_person.account).to be_nil
         end
 
@@ -86,11 +130,11 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
     context "when the document is persisted" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:game) do
-        Game.create(person: person)
+        Game.create!(person: person)
       end
 
       it "returns the document" do
@@ -101,11 +145,11 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
     context "when the document have a non standard pk" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:cat) do
-        Cat.create(person: person)
+        Cat.create!(person: person)
       end
 
       it "returns the document" do

data/spec/mongoid/association/referenced/has_one/eager_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
+require_relative '../has_one_models'
 
 describe Mongoid::Association::Referenced::HasOne::Eager do
 
@@ -153,7 +154,7 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     context "when the relation is polymorphic" do
 
       let!(:book) do
-        Book.create(name: "Game of Thrones")
+        Book.create!(name: "Game of Thrones")
       end
 
       let!(:rating) do
@@ -174,5 +175,20 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
         end
       end
     end
+
+    context "when the association has scope" do
+      let!(:trainer1) { HomTrainer.create!(name: 'Dave') }
+      let!(:trainer2) { HomTrainer.create!(name: 'Ash') }
+      let!(:animal1) { HomAnimal.create!(taxonomy: 'reptile', trainer: trainer1) }
+      let!(:animal2) { HomAnimal.create!(taxonomy: 'bird', trainer: trainer1) }
+
+      let(:eager) do
+        HomTrainer.includes(:animal).where(_id: trainer1._id).to_a.first
+      end
+
+      it 'eager loads the included docs' do
+        expect(eager.animal).to eq animal1
+      end
+    end
   end
 end

data/spec/mongoid/association/referenced/has_one/proxy_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -88,7 +88,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -134,7 +134,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
             it "detaches the previous relation" do
               expect {
                 game.reload
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Game with id\(s\)/)
             end
           end
         end
@@ -143,7 +143,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when relation have a different primary_key" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:cat) do
@@ -216,7 +216,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -251,7 +251,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing persisted (dependent: :destroy) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
@@ -324,7 +324,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing unpersisted (dependent: :destroy) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
@@ -397,7 +397,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing persisted (dependent: :nullify) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:cat) do
@@ -470,7 +470,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing unpersisted (dependent: :nullify) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:cat) do
@@ -543,7 +543,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing relation with a new one" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         context "when dependent is destroy" do
@@ -553,7 +553,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
           end
 
           let!(:new_game) do
-            Game.create(name: "Starcraft 2")
+            Game.create!(name: "Starcraft 2")
           end
 
           before do
@@ -584,7 +584,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
           end
 
           let!(:new_account) do
-            Account.create(name: "checking")
+            Account.create!(name: "checking")
           end
 
           before do
@@ -646,7 +646,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -709,7 +709,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -760,7 +760,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when using object ids" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -787,7 +787,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when providing no attributes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -810,7 +810,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when providing nil attributes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -836,7 +836,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when using object ids" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -880,7 +880,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when the relation is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -907,7 +907,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when providing no attributes" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -930,7 +930,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when providing nil attributes" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -953,7 +953,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when the relation is polymorphic" do
 
       let(:bar) do
-        Bar.create
+        Bar.create!
       end
 
       let(:rating) do
@@ -988,7 +988,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
   describe "#nullify" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:game) do
@@ -1062,15 +1062,15 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
   context "when reloading the relation" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:game_one) do
-      Game.create(name: "Warcraft 3")
+      Game.create!(name: "Warcraft 3")
     end
 
     let!(:game_two) do
-      Game.create(name: "Starcraft 2")
+      Game.create!(name: "Starcraft 2")
     end
 
     before do
@@ -1122,11 +1122,11 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when autobuild is true for child" do
 
       let(:explosion) do
-        Explosion.create
+        Explosion.create!
       end
 
       let(:bomb) do
-        bomb = Bomb.create
+        bomb = Bomb.create!
         bomb.explosion = explosion
         bomb
       end
@@ -1140,4 +1140,110 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       end
     end
   end
+
+  context "when there is a foreign key in the aliased associations" do
+    it "has the correct aliases" do
+      # Instances of Driver do not respond to vehicle_id.
+      expect(Driver.aliased_associations.key?("vehicle_id")).to be false
+      expect(Vehicle.aliased_associations.key?("driver_id")).to be false
+      expect(Vehicle.aliased_fields["driver"]).to eq("driver_id")
+    end
+  end
+
+  context "when the document is not persisted and the association is invalid" do
+
+    before do
+      class HomParent
+        include Mongoid::Document
+        has_one :child, class_name: "HomChild"
+        field :name
+        validates :name, presence: true
+      end
+
+      class HomChild; include Mongoid::Document; end
+
+      belongs_to
+      child.parent = parent
+      child.save
+    end
+
+    after do
+      Object.send(:remove_const, :HomParent)
+      Object.send(:remove_const, :HomChild)
+    end
+
+    let(:belongs_to) do
+      HomChild.belongs_to :parent, autosave: true, validate: false, optional: optional
+    end
+
+    let(:child) { HomChild.new }
+    let(:parent) { HomParent.new }
+
+
+    context "when belongs_to_required_by_default is true" do
+      config_override :belongs_to_required_by_default, true
+
+      context "when optional is true" do
+        let(:optional) { true }
+
+        it "persists the child with the parent_id" do
+          expect(HomChild.first.parent_id).to eq(parent._id)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is false" do
+        let(:optional) { false }
+
+        it "doesn't persist the parent or the child" do
+          expect(HomChild.count).to eq(0)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is not set" do
+        let(:belongs_to) do
+          HomChild.belongs_to :parent, autosave: true, validate: false
+        end
+
+        it "doesn't persist the parent or the child" do
+          expect(HomChild.count).to eq(0)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+    end
+
+    context "when belongs_to_required_by_default is false" do
+      config_override :belongs_to_required_by_default, false
+
+      context "when optional is true" do
+        let(:optional) { true }
+
+        it "persists the child with the parent_id" do
+          expect(HomChild.first.parent_id).to eq(parent._id)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is false" do
+        let(:optional) { false }
+
+        it "doesn't persist the parent or the child" do
+          expect(HomChild.count).to eq(0)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is not set" do
+        let(:belongs_to) do
+          HomChild.belongs_to :parent, autosave: true, validate: false
+        end
+
+        it "persists the child with the parent_id" do
+          expect(HomChild.first.parent_id).to eq(parent._id)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+    end
+  end
 end