mongoid 7.2.1 → 9.0.0

data/spec/mongoid/monkey_patches_spec.rb

@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+# @note This test ensures that we do not inadvertently introduce new monkey patches
+# to Mongoid. Existing monkey patch methods which are marked with +Mongoid.deprecated+
+# are excluded from this test.
+RSpec.describe('Do not add monkey patches') do # rubocop:disable RSpec/DescribeClass
+  classes = [
+    Object,
+    Array,
+    BigDecimal,
+    Date,
+    DateTime,
+    FalseClass,
+    Float,
+    Hash,
+    Integer,
+    Module,
+    NilClass,
+    Range,
+    Regexp,
+    Set,
+    String,
+    Symbol,
+    Time,
+    TrueClass,
+    ActiveSupport::TimeWithZone,
+    BSON::Binary,
+    BSON::Decimal128,
+    BSON::ObjectId,
+    BSON::Regexp,
+    BSON::Regexp::Raw
+  ]
+
+  expected_instance_methods = {
+    Object => %i[
+      __add__
+      __add_from_array__
+      __array__
+      __deep_copy__
+      __evolve_object_id__
+      __expand_complex__
+      __intersect__
+      __intersect_from_array__
+      __intersect_from_object__
+      __mongoize_object_id__
+      __union__
+      __union_from_object__
+      ivar
+      mongoize
+      numeric?
+      remove_ivar
+      resizable?
+      substitutable
+    ],
+    Array => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+      __sort_option__
+      __sort_pair__
+      delete_one
+    ],
+    Date => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    DateTime => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    FalseClass => %i[is_a?],
+    Float => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    Hash => %i[
+      __sort_option__
+    ],
+    Integer => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    Module => %i[
+      re_define_method
+    ],
+    NilClass => %i[
+      __evolve_date__
+      __evolve_time__
+      __expanded__
+      __override__
+      collectionize
+    ],
+    Range => %i[
+      __evolve_date__
+      __evolve_range__
+      __evolve_time__
+    ],
+    String => %i[
+      __evolve_date__
+      __evolve_time__
+      __expr_part__
+      __mongo_expression__
+      __mongoize_time__
+      __sort_option__
+      before_type_cast?
+      collectionize
+      reader
+      valid_method_name?
+      writer?
+    ],
+    Symbol => %i[
+      __expr_part__
+      add_to_set
+      all
+      asc
+      ascending
+      avg
+      desc
+      descending
+      elem_match
+      eq
+      exists
+      first
+      gt
+      gte
+      in
+      intersects_line
+      intersects_point
+      intersects_polygon
+      last
+      lt
+      lte
+      max
+      min
+      mod
+      ne
+      near
+      near_sphere
+      nin
+      not
+      push
+      sum
+      with_size
+      with_type
+      within_box
+      within_polygon
+    ],
+    TrueClass => %i[is_a?],
+    Time => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    ActiveSupport::TimeWithZone => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+      _bson_to_i
+    ],
+    BSON::Decimal128 => %i[
+      __evolve_decimal128__
+    ]
+  }.each_value(&:sort!)
+
+  expected_class_methods = {
+    Object => %i[
+      demongoize
+      evolve
+      re_define_method
+    ],
+    Float => %i[__numeric__],
+    Integer => %i[__numeric__],
+    String => %i[__expr_part__],
+    Symbol => %i[add_key]
+  }.each_value(&:sort!)
+
+  def mongoid_method?(method)
+    method.source_location&.first&.include?('/lib/mongoid/')
+  end
+
+  def added_instance_methods(klass)
+    methods = klass.instance_methods.select { |m| mongoid_method?(klass.instance_method(m)) }
+    methods -= added_instance_methods(Object) unless klass == Object
+    methods.sort
+  end
+
+  def added_class_methods(klass)
+    methods = klass.methods.select { |m| mongoid_method?(klass.method(m)) }
+    methods -= added_instance_methods(Object)
+    methods -= added_class_methods(Object) unless klass == Object
+    methods.sort
+  end
+
+  classes.each do |klass|
+    context klass.name do
+      it 'adds no unexpected instance methods' do
+        expect(added_instance_methods(klass)).to eq(expected_instance_methods[klass] || [])
+      end
+
+      it 'adds no unexpected class methods' do
+        expect(added_class_methods(klass)).to eq(expected_class_methods[klass] || [])
+      end
+    end
+  end
+end

data/spec/mongoid/persistable/creatable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -235,11 +235,11 @@ describe Mongoid::Persistable::Creatable do
       end
 
       let(:attributes) do
-        collection.find({ name: "Testy"}).first
+        collection.find({ name: "Testy" }).first
       end
 
       before do
-        Browser.create(name: 'Safari', version: '4.0.0')
+        Browser.create(name: 'Safari', version: 4.0)
       end
 
       it "persists the versions" do
@@ -352,8 +352,8 @@ describe Mongoid::Persistable::Creatable do
       context "when building related documents" do
 
         before do
-          container.vehicles.build({}, Car).save
-          container.vehicles.build({}, Truck).save
+          container.vehicles.build({}, Car).save!
+          container.vehicles.build({}, Truck).save!
         end
 
         it "allows STI from the build call" do

data/spec/mongoid/persistable/deletable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -8,23 +8,37 @@ describe Mongoid::Persistable::Deletable do
   describe "#delete" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when deleting a readonly document" do
-
       let(:from_db) do
-        Person.only(:_id).first
+        Person.first.tap(&:readonly!)
       end
 
       it "raises an error" do
+        expect(from_db.readonly?).to be true
         expect {
           from_db.delete
         }.to raise_error(Mongoid::Errors::ReadonlyDocument)
       end
     end
 
-    context "when removing a root document" do
+    context 'when deleting a document that was not saved' do
+      let(:unsaved_person) { Person.new(id: person.id) }
+
+      before do
+        unsaved_person.delete
+      end
+
+      it 'deletes the matching document from the database' do
+        lambda do
+          person.reload
+        end.should raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Person with id\(s\)/)
+      end
+    end
+
+    context "when deleting a root document" do
 
       let!(:deleted) do
         person.delete
@@ -33,7 +47,7 @@ describe Mongoid::Persistable::Deletable do
       it "deletes the document from the collection" do
         expect {
           Person.find(person.id)
-        }.to raise_error(Mongoid::Errors::DocumentNotFound)
+        }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Person with id\(s\)/)
       end
 
       it "returns true" do
@@ -43,9 +57,28 @@ describe Mongoid::Persistable::Deletable do
       it "resets the flagged for destroy flag" do
         expect(person).to_not be_flagged_for_destroy
       end
+
+      context 'when :persist option false' do
+
+        let!(:deleted) do
+          person.delete(persist: false)
+        end
+
+        it "does not delete the document from the collection" do
+          expect(Person.find(person.id)).to eq person
+        end
+
+        it "returns true" do
+          expect(deleted).to be true
+        end
+
+        it "does not set the flagged for destroy flag" do
+          expect(person).to_not be_flagged_for_destroy
+        end
+      end
     end
 
-    context "when removing an embedded document" do
+    context "when deleting an embedded document" do
 
       let(:address) do
         person.addresses.build(street: "Bond Street")
@@ -73,7 +106,7 @@ describe Mongoid::Persistable::Deletable do
       context "when the document has been saved" do
 
         before do
-          address.save
+          address.save!
           address.delete
         end
 
@@ -81,22 +114,69 @@ describe Mongoid::Persistable::Deletable do
           Person.find(person.id)
         end
 
-        it "removes the object from the parent and database" do
+        it "removes the object from the parent" do
+          expect(person.addresses).to be_empty
+        end
+
+        it "removes the object from the database" do
+          expect(from_db.addresses).to be_empty
+        end
+      end
+
+      context 'when :persist option false' do
+
+        before do
+          address.save!
+          address.delete(persist: false)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "does not remove the object from the database" do
+          expect(from_db.addresses).to eq [address]
+          expect(from_db.addresses.first).to_not be_flagged_for_destroy
+        end
+      end
+
+      context 'when :suppress option true' do
+
+        before do
+          address.save!
+          address.delete(suppress: true)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "removes the object from the database" do
           expect(from_db.addresses).to be_empty
         end
       end
     end
 
-    context "when removing deeply embedded documents" do
+    context "when deleting deeply embedded documents" do
 
       context "when the document has been saved" do
 
         let(:address) do
-          person.addresses.create(street: "Bond Street")
+          person.addresses.create!(street: "Bond Street")
         end
 
         let(:location) do
-          address.locations.create(name: "Home")
+          address.locations.create!(name: "Home")
         end
 
         let(:from_db) do
@@ -120,19 +200,19 @@ describe Mongoid::Persistable::Deletable do
     context "when deleting subclasses" do
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:firefox2) do
-        Firefox.create(name: "firefox 2")
+        Firefox.create!(name: "firefox 2")
       end
 
       let!(:browser) do
-        Browser.create(name: "browser")
+        Browser.create!(name: "browser")
       end
 
       let!(:canvas) do
-        Canvas.create(name: "canvas")
+        Canvas.create!(name: "canvas")
       end
 
       context "when deleting a single document" do
@@ -184,19 +264,19 @@ describe Mongoid::Persistable::Deletable do
       end
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:firefox2) do
-        Firefox.create(name: "firefox 2")
+        Firefox.create!(name: "firefox 2")
       end
 
       let!(:browser) do
-        Browser.create(name: "browser")
+        Browser.create!(name: "browser")
       end
 
       let!(:canvas) do
-        Canvas.create(name: "canvas")
+        Canvas.create!(name: "canvas")
       end
 
       before do
@@ -228,19 +308,19 @@ describe Mongoid::Persistable::Deletable do
       end
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:firefox2) do
-        Firefox.create(name: "firefox 2")
+        Firefox.create!(name: "firefox 2")
       end
 
       let!(:browser) do
-        Browser.create(name: "browser")
+        Browser.create!(name: "browser")
       end
 
       let!(:canvas) do
-        Canvas.create(name: "canvas")
+        Canvas.create!(name: "canvas")
       end
 
       before do
@@ -259,12 +339,92 @@ describe Mongoid::Persistable::Deletable do
         expect(Browser.count).to eq(1)
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(bolt: Bolt.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Bolt.count.should == 1
+            parent.delete
+            Bolt.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(threadlocker: Threadlocker.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Threadlocker.count.should == 1
+            parent.delete
+            Threadlocker.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(sealer: Sealer.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Sealer.count.should == 1
+            parent.delete
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Nut.count.should == 1
+            parent.delete
+            Nut.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Washer.count.should == 1
+            parent.delete
+            Washer.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Spacer.count.should == 1
+            parent.delete
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 
   describe "#delete_all" do
 
     let!(:person) do
-      Person.create(title: "sir")
+      Person.create!(title: "sir")
     end
 
     context "when no conditions are provided" do
@@ -285,7 +445,7 @@ describe Mongoid::Persistable::Deletable do
     context "when conditions are provided" do
 
       let!(:person_two) do
-        Person.create
+        Person.create!
       end
 
       context "when no conditions attribute provided" do
@@ -321,7 +481,7 @@ describe Mongoid::Persistable::Deletable do
       context 'when the write concern is unacknowledged' do
 
         before do
-          Person.create(title: 'miss')
+          Person.create!(title: 'miss')
         end
 
         let!(:deleted) do
@@ -337,5 +497,85 @@ describe Mongoid::Persistable::Deletable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(bolt: Bolt.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Bolt.count.should == 1
+            Hole.delete_all
+            Bolt.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(threadlocker: Threadlocker.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Threadlocker.count.should == 1
+            Hole.delete_all
+            Threadlocker.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(sealer: Sealer.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Sealer.count.should == 1
+            Hole.delete_all
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Nut.count.should == 1
+            Hole.delete_all
+            Nut.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Washer.count.should == 1
+            Hole.delete_all
+            Washer.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Spacer.count.should == 1
+            Hole.delete_all
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 end