mongoid 7.2.1 → 9.0.0

data/spec/mongoid/persistable/pullable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -37,7 +37,7 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -89,11 +89,11 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -118,7 +118,7 @@ describe Mongoid::Persistable::Pullable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 1, 2, 3 ])
       end
 
       it "marks a dirty change for the pulled fields" do
@@ -128,6 +128,42 @@ describe Mongoid::Persistable::Pullable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 1, 2, 3 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.pull(test_array: 1)
+          expect(person.test_array).to eq([ 2, 3 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.pull(test_array: 1)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 
   describe "#pull_all" do
@@ -162,7 +198,7 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -216,11 +252,11 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -245,7 +281,7 @@ describe Mongoid::Persistable::Pullable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 1, 2, 3, 4 ])
+        Person.create!(test_array: [ 1, 1, 2, 3, 4 ])
       end
 
       it "marks a dirty change for the pulled fields" do
@@ -255,5 +291,41 @@ describe Mongoid::Persistable::Pullable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 1, 2, 3, 4 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.pull_all(test_array: [ 1, 2 ])
+          expect(person.test_array).to eq([ 3, 4 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.pull_all(test_array: [ 1, 2 ])
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/pushable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -45,7 +45,7 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 2 ], array: [ 4, 5 ])
+        Person.create!(aliases: [ 1, 2 ], array: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -155,11 +155,11 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1 ], a: [ 4, 5 ])
+        person.addresses.create!(street: "t", services: [ 1 ], a: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -195,7 +195,7 @@ describe Mongoid::Persistable::Pushable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
       it "marks a dirty change for the modified fields" do
@@ -205,6 +205,42 @@ describe Mongoid::Persistable::Pushable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 2, 3 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.add_to_set(test_array: [ 1, 4 ])
+          expect(person.test_array).to eq([ 1, 2, 3, 4 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.add_to_set(test_array: [ 1, 4 ])
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 
   describe "#push" do
@@ -251,7 +287,7 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when provided string fields" do
@@ -311,11 +347,11 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1 ], a: [ 4, 5 ])
+        person.addresses.create!(street: "t", services: [ 1 ], a: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -340,7 +376,7 @@ describe Mongoid::Persistable::Pushable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
       it "marks a dirty change for the pushed fields" do
@@ -350,5 +386,41 @@ describe Mongoid::Persistable::Pushable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 2, 3 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.push(test_array: [ 1, 4 ])
+          expect(person.test_array).to eq([ 1, 2, 3, 1, 4 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.push(test_array: [ 1, 4 ])
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/renamable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -57,7 +57,7 @@ describe Mongoid::Persistable::Renamable do
       end
 
       let(:person) do
-        Person.create(title: "sir", dob: date)
+        Person.create!(title: "sir", dob: date)
       end
 
       context "when provided symbol names" do
@@ -109,7 +109,7 @@ describe Mongoid::Persistable::Renamable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:name) do
@@ -138,7 +138,7 @@ describe Mongoid::Persistable::Renamable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       it "marks a dirty change for the renamed fields" do
@@ -148,5 +148,41 @@ describe Mongoid::Persistable::Renamable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(title: "sir")
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.rename title: :salutation
+          expect(person.reload.salutation).to eq("sir")
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.rename(title: :salutation)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/savable_spec.rb

@@ -1,14 +1,17 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
+require "support/immutable_ids"
 
 describe Mongoid::Persistable::Savable do
+  extend Mongoid::ImmutableIds
+  immutable_id_examples_as "persisted _ids are immutable"
 
   describe "#save" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:contextable_item) do
@@ -16,7 +19,7 @@ describe Mongoid::Persistable::Savable do
     end
 
     let(:persisted_contextable_item) do
-      ContextableItem.create(title: 'sir')
+      ContextableItem.create!(title: 'sir')
     end
 
     context "when skipping validation" do
@@ -47,7 +50,7 @@ describe Mongoid::Persistable::Savable do
       context "when saving document that is a belongs to child" do
 
         let(:account) do
-          Account.create
+          Account.create!(name: 'Foobar')
         end
 
         let(:alert) do
@@ -149,7 +152,7 @@ describe Mongoid::Persistable::Savable do
     context "when validation fails" do
 
       let(:address) do
-        person.addresses.create(city: "London")
+        person.addresses.create!(city: "London")
       end
 
       before do
@@ -166,7 +169,7 @@ describe Mongoid::Persistable::Savable do
       context "when performing modification and insert ops" do
 
         let(:owner) do
-          Owner.create(name: "Blah")
+          Owner.create!(name: "Blah")
         end
 
         let!(:birthday) do
@@ -229,7 +232,7 @@ describe Mongoid::Persistable::Savable do
         end
 
         let!(:person) do
-          Person.create(
+          Person.create!(
             title: "Blah",
             addresses: [ address ]
           )
@@ -292,9 +295,6 @@ describe Mongoid::Persistable::Savable do
           expect(truck.crates[0].toys[0].name).to eq "Teddy bear"
           expect(truck.crates[1].volume).to eq 0.8
           expect(truck.crates[1].toys.size).to eq 0
-
-          #expect(truck.atomic_updates[:conflicts]).to eq nil
-
           expect { truck.save! }.not_to raise_error
 
           _truck = Truck.find(truck.id)
@@ -360,8 +360,6 @@ describe Mongoid::Persistable::Savable do
 
         context 'when also updating first embedded top level association' do
           it 'performs all writes' do
-            pending 'https://jira.mongodb.org/browse/MONGOID-4982'
-
             truck.crates.first.volume = 2
             truck.crates.first.toys.build(name: 'Bear')
             truck.crates.build
@@ -397,8 +395,6 @@ describe Mongoid::Persistable::Savable do
 
         context 'when embedded association embeds another association' do
           it 'persists the new documents' do
-            pending 'https://jira.mongodb.org/browse/MONGOID-4982'
-
             expect(truck.seats.size).to eq 1
             expect(truck.seats[0].rating).to eq 1
 
@@ -409,7 +405,7 @@ describe Mongoid::Persistable::Savable do
 
             _truck = Truck.find(truck.id)
             expect(_truck.seats.size).to eq 2
-            expect(_truck.seats[0].rating).to eq 1
+            expect(_truck.seats[0].rating).to eq 2
             expect(_truck.seats[0].armrests.length).to eq 1
             expect(_truck.seats[1].rating).to eq 100
           end
@@ -459,7 +455,7 @@ describe Mongoid::Persistable::Savable do
     context "when the changed attribute is not writable" do
 
       before do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       let(:person) do
@@ -470,13 +466,13 @@ describe Mongoid::Persistable::Savable do
         expect {
           person.username = 'unloaded-attribute'
           person.save
-        }.to raise_error(ActiveModel::MissingAttributeError)
+        }.to raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'username' on Person which was not loaded/)
       end
 
       context 'when the changed attribute is aliased' do
 
         before do
-          Person.create(at: Time.now)
+          Person.create!(at: Time.now)
         end
 
         let(:person) do
@@ -485,7 +481,7 @@ describe Mongoid::Persistable::Savable do
 
         it "saves the document" do
           person.aliased_timestamp = Time.now
-          expect(person.save(validate: false)).to be true
+          expect(person.save!(validate: false)).to be true
         end
       end
     end
@@ -497,27 +493,125 @@ describe Mongoid::Persistable::Savable do
     end
 
     context "when validation context exists" do
+
       context "on new document" do
+
         it "returns true" do
           contextable_item.title = "sir"
           expect(contextable_item.save(context: :in_context)).to be true
         end
+
         it "returns false" do
           expect(contextable_item.save(context: :in_context)).to be false
         end
       end
 
       context "on persisted document" do
+
         it "returns true" do
           persisted_contextable_item.title = "lady"
           expect(persisted_contextable_item.save(context: :in_context)).to be true
         end
+
         it "returns false" do
           persisted_contextable_item.title = nil
           expect(persisted_contextable_item.save(context: :in_context)).to be false
         end
       end
     end
+
+    context "when saving a readonly document" do
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        context "when its a new document" do
+
+          let(:document) do
+            Band.new
+          end
+
+          before do
+            document.__selected_fields = { 'test' => 1 }
+            expect(document).to be_readonly
+          end
+
+          it "persists the document" do
+            expect(Band.count).to eq(0)
+            document.save!
+            expect(Band.count).to eq(1)
+          end
+        end
+
+        context "when its an old document" do
+
+          let(:document) do
+            Band.only(:name).first
+          end
+
+          before do
+            Band.create!
+            expect(document).to be_readonly
+          end
+
+          it "updates the document" do
+            document.name = "The Rolling Stones"
+            document.save!
+            expect(Band.first.name).to eq("The Rolling Stones")
+          end
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        context "when its a new document" do
+
+          let(:document) do
+            Band.new
+          end
+
+          before do
+            document.readonly!
+            expect(document).to be_readonly
+          end
+
+          it "raises a readonly error" do
+            expect do
+              document.save!
+            end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+          end
+        end
+
+        context "when its an old document" do
+
+          let(:document) do
+            Band.first.tap(&:readonly!)
+          end
+
+          before do
+            Band.create!
+            expect(document).to be_readonly
+          end
+
+          it "raises a readonly error" do
+            document.name = "The Rolling Stones"
+            expect do
+              document.save!
+            end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+          end
+        end
+      end
+    end
+
+    context "when the _id has been modified" do
+      def invoke_operation!
+        object._id = new_id_value
+        object.save
+      end
+
+      it_behaves_like "persisted _ids are immutable"
+    end
   end
 
   describe "save!" do
@@ -629,7 +723,7 @@ describe Mongoid::Persistable::Savable do
     context "when the document has associations" do
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:writer) do