mongoid 7.2.1 → 9.0.0

data/spec/mongoid/association/eager_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -210,10 +210,10 @@ describe Mongoid::Association::EagerLoadable do
         end
 
         it 'successfully loads all relations' do
-          user = User.create
-          unit = Unit.create
-          booking = Booking.create(unit: unit)
-          Voucher.create(booking: booking, created_by: user)
+          user = User.create!
+          unit = Unit.create!
+          booking = Booking.create!(unit: unit)
+          Voucher.create!(booking: booking, created_by: user)
 
           vouchers = Voucher.includes(:created_by, booking: [:unit])
 
@@ -245,10 +245,60 @@ describe Mongoid::Association::EagerLoadable do
       end
 
       it "runs the has_one preload" do
-        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([book_association, cat_association], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([ book_association ], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([ cat_association ], docs).once.and_call_original
         context.eager_load(docs)
       end
     end
+
+    context "when including an embedded_in relation" do
+      let!(:account) { Account.create(name: "home", memberships: memberships) }
+      let(:memberships) { [ Membership.new(name: "his"), Membership.new(name: "hers") ] }
+      let(:criteria) { Account.includes(memberships: :account) }
+
+      it "loads the parent document" do
+        result = criteria.find_by(name: "home")
+        expect(result).to eq(account)
+        expect(result.memberships.first.account).to eq(account)
+      end
+    end
+
+    context "when including an embeds_many relation" do
+      let!(:account) { Account.create(name: "home", memberships: memberships) }
+      let(:memberships) { [ Membership.new(name: "his"), Membership.new(name: "hers") ] }
+      let(:criteria) { Account.includes(:memberships) }
+
+      it "loads the subdocuments" do
+        result = criteria.find_by(name: "home")
+        expect(result).to eq(account)
+        expect(result.memberships.count).to eq(2)
+      end
+    end
+
+    context "when including an embeds_one relation" do
+      let!(:person) { Person.create(username: "test", pet: pet) }
+      let(:pet) { Animal.new(name: "fido") }
+      let(:criteria) { Person.includes(:pet) }
+
+      it "loads the subdocument" do
+        result = criteria.find_by(username: "test")
+        expect(result).to eq(person)
+        expect(result.pet).to eq(pet)
+      end
+    end
+
+    context "when chaining a referenced association from an embedded relation" do
+      let!(:person) { Person.create(username: "test", messages: [ message ]) }
+      let!(:post) { Post.create(title: "notice", posteable: message) }
+      let(:message) { Message.new(body: "hello") }
+      let(:criteria) { Person.includes(messages: :post) }
+
+      it "loads the referenced association" do
+        result = criteria.find_by(username: "test")
+        expect(result).to eq(person)
+        expect(result.messages.first.post).to eq(post)
+      end
+    end
   end
 
   describe ".eager_loadable?" do

data/spec/mongoid/association/embedded/cyclic_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -28,7 +28,7 @@ describe Mongoid::Association::Embedded::Cyclic do
       context "when a query is executed" do
 
         before do
-          document.save
+          document.save!
         end
 
         it "queries the database, not memory" do
@@ -151,7 +151,7 @@ describe Mongoid::Association::Embedded::Cyclic do
     context "when a query is executed" do
 
       before do
-        document.save
+        document.save!
       end
 
       it "queries the database, not memory" do

data/spec/mongoid/association/embedded/dirty_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -21,7 +21,7 @@ end
 describe "when creating a model with an embedded model" do
 
   let(:person) do
-    Person.create(pet: Pet.new)
+    Person.create!(pet: Pet.new)
   end
 
   it "does not have changes in the embedded model" do
@@ -36,7 +36,7 @@ end
 describe "when embedding a model on an already saved model" do
 
   let(:person) do
-    Person.create
+    Person.create!
   end
 
   before do

data/spec/mongoid/association/embedded/embedded_in/binding_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -59,7 +59,8 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Binding do
         end
 
         it "does nothing" do
-          expect(name).to receive(:namable=).never
+          expect(name).to receive(:namable=).with(person).never
+          expect(name).to receive(:namable=).with(nil).once
           binding.bind_one
         end
       end

data/spec/mongoid/association/embedded/embedded_in/buildable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -34,4 +34,58 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Buildable do
       end
     end
   end
+
+  context 'when the object is already associated with another object' do
+
+    context "when inverse is embeds_many" do
+
+      let(:appointment1) do
+        Appointment.new
+      end
+
+      let(:appointment2) do
+        Appointment.new
+      end
+
+      let(:person) do
+        Person.create!
+      end
+
+      before do
+        appointment1.person = person
+        appointment2.person = person
+      end
+
+      it 'does not clear the object of its previous association' do
+        expect(appointment1.person).to eq(person)
+        expect(appointment2.person).to eq(person)
+        expect(person.appointments).to eq([appointment1, appointment2])
+      end
+    end
+
+    context "when inverse is embeds_one" do
+
+      let(:scribe1) do
+        Scribe.new
+      end
+
+      let(:scribe2) do
+        Scribe.new
+      end
+
+      let(:owner) do
+        Owner.create!
+      end
+
+      before do
+        scribe1.owner = owner
+        scribe2.owner = owner
+      end
+
+      it 'clears the object of its previous association' do
+        expect(scribe1.owner).to be_nil
+        expect(scribe2.owner).to eq(owner)
+      end
+    end
+  end
 end

data/spec/mongoid/association/embedded/embedded_in/proxy_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
+require_relative '../embeds_many_models'
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
 
@@ -79,7 +80,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:name) do
@@ -224,7 +225,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when the documents are not new records" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:name) do
@@ -294,7 +295,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when the documents are not new records" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address) do
@@ -322,7 +323,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when a child already exists on the parent" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address_one) do
@@ -392,19 +393,19 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
   context "when creating the tree through initialization" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
-      Address.create(addressable: person)
+      Address.create!(addressable: person)
     end
 
     let!(:first_location) do
-      Location.create(address: address)
+      Location.create!(address: address)
     end
 
     let!(:second_location) do
-      Location.create(address: address)
+      Location.create!(address: address)
     end
 
     it "saves the child" do
@@ -433,7 +434,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
   context "when instantiating a new child with a persisted parent" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
@@ -456,15 +457,15 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
   context "when replacing the relation with another" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:person_two) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
-      person.addresses.create(street: "Kotbusser Damm")
+      person.addresses.create!(street: "Kotbusser Damm")
     end
 
     let!(:name) do
@@ -473,7 +474,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
 
     before do
       name.namable = address.addressable
-      name.namable.save
+      name.namable.save!
     end
 
     it "sets the new parent" do
@@ -508,7 +509,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
     end
   end
 
-  context "when the same class is embedded multiple times" do
+  context "when the same class is embedded multiple times; embeds_one" do
 
     let(:customer) do
       Customer.new
@@ -517,7 +518,6 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
     context "assignment after saving" do
 
       it "correctly sets the association for the embedded class" do
-        pending 'MONGOID-5039'
 
         customer.home_address = CustomerAddress.new
         customer.work_address = CustomerAddress.new
@@ -538,23 +538,110 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
 
         expect(customer.home_address.instance_eval { _association.store_as }).to eq("home_address")
         expect(customer.work_address.instance_eval { _association.store_as }).to eq("work_address")
+
+        expect(customer.home_address.addressable).to eq(customer)
+        expect(customer.work_address.addressable).to eq(customer)
       end
     end
 
     context "inverse assignment" do
 
+      it "raises an error when trying to set the association" do
+        customer.work_address = CustomerAddress.new
+
+        expect do
+          customer.work_address.addressable = customer
+        end.to raise_error(Mongoid::Errors::InvalidSetPolymorphicRelation)
+      end
+    end
+
+    context "when there is an explicit inverse_of" do
+
+      let(:customer) { EmmCustomer.new }
+
       it "correctly sets the association for the embedded class" do
-        pending 'MONGOID-5039'
+        customer.work_address = EmmCustomerAddress.new
 
-        customer.work_address = CustomerAddress.new
-        customer.work_address.addressable = customer
+        expect do
+          customer.work_address.addressable = customer
+        end.to_not raise_error
 
-        expect(customer.home_address._association.store_as).to eq("home_address")
-        expect(customer.work_address._association.store_as).to eq("work_address")
+        expect(customer.work_address.addressable).to eq(customer)
+      end
+    end
+  end
 
-        expect(customer.home_address.instance_eval { _association.store_as }).to eq("home_address")
-        expect(customer.work_address.instance_eval { _association.store_as }).to eq("work_address")
+  context "when the same class is embedded multiple times; embeds_many" do
+
+    let(:customer) do
+      EmmCustomer.new
+    end
+
+    context "assignment after saving" do
+
+      it "correctly sets the association for the embedded class" do
+
+        customer.close_friends = [EmmFriend.new]
+        customer.acquaintances = [EmmFriend.new]
+
+        expect(customer.close_friends._association.store_as).to eq("close_friends")
+        expect(customer.acquaintances._association.store_as).to eq("acquaintances")
+
+        expect(customer.close_friends[0].instance_eval { _association.store_as }).to eq("close_friends")
+        expect(customer.acquaintances[0].instance_eval { _association.store_as }).to eq("acquaintances")
+
+        customer.save!
+
+        customer.close_friends = [EmmFriend.new]
+        customer.acquaintances = [EmmFriend.new]
+
+        expect(customer.close_friends._association.store_as).to eq("close_friends")
+        expect(customer.acquaintances._association.store_as).to eq("acquaintances")
+
+        expect(customer.close_friends[0].instance_eval { _association.store_as }).to eq("close_friends")
+        expect(customer.acquaintances[0].instance_eval { _association.store_as }).to eq("acquaintances")
+
+        expect(customer.close_friends[0].befriendable).to eq(customer)
+        expect(customer.acquaintances[0].befriendable).to eq(customer)
+      end
+    end
+
+    context "inverse assignment" do
+
+      it "raises an error when trying to set the association" do
+        customer.acquaintances = [EmmFriend.new]
+
+        expect do
+          customer.acquaintances[0].befriendable = customer
+        end.to raise_error(Mongoid::Errors::InvalidSetPolymorphicRelation)
       end
     end
   end
+
+  context "when assigning a hash" do
+    let(:building_address) { BuildingAddress.new }
+
+    before do
+      building_address.building = { name: "Chrysler" }
+    end
+
+    it "creates the objects correctly" do
+      expect(building_address.building).to be_a(Building)
+      expect(building_address.building.name).to eq("Chrysler")
+    end
+  end
+
+  context "when replacing an association with a hash" do
+    let(:building_address) { BuildingAddress.new }
+
+    before do
+      building_address.building = { name: "Chrysler" }
+      building_address.building = { name: "Empire State" }
+    end
+
+    it "creates the objects correctly" do
+      expect(building_address.building).to be_a(Building)
+      expect(building_address.building.name).to eq("Empire State")
+    end
+  end
 end

data/spec/mongoid/association/embedded/embedded_in_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 require_relative './embeds_one_models'
@@ -157,20 +157,27 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
   describe '#touchable?' do
 
     context 'when :touch is in the options' do
+      shared_examples_for ':touch is in the options' do
+        it 'returns the value in the options' do
+          expect(association.send(:touchable?)).to be(options[:touch])
+        end
+      end
 
-      let(:options) do
-        { touch: true}
+      context 'when the option is true' do
+        let(:options) { { touch: true } }
+        it_behaves_like ':touch is in the options'
       end
 
-      it 'returns true' do
-        expect(association.send(:touchable?)).to be(true)
+      context 'when the option is false' do
+        let(:options) { { touch: false } }
+        it_behaves_like ':touch is in the options'
       end
     end
 
     context 'when :touch is not in the options' do
 
-      it 'return false' do
-        expect(association.send(:touchable?)).to be(false)
+      it 'return the default value' do
+        expect(association.send(:touchable?)).to be(true)
       end
     end
   end
@@ -583,7 +590,11 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
     context 'when the :class_name option is specified' do
 
       let(:options) do
-        { class_name: 'OtherContainer' }
+        # `touch: true` is the default (see MONGOID-5016), which means by
+        # default, callbacks are added to the referenced class. In this case,
+        # the class does not exist, so we must explicitly set `touch: false`
+        # to prevent Mongoid from attempting to load the bogus class.
+        { touch: false, class_name: 'OtherContainer' }
       end
 
       it 'returns the class name option' do

data/spec/mongoid/association/embedded/embeds_many/binding_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/association/embedded/embeds_many/buildable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -104,4 +104,116 @@ describe Mongoid::Association::Embedded::EmbedsMany::Buildable do
       end
     end
   end
+
+  context 'when the object is already associated with another object' do
+
+    context "when using <<" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment) do
+        Appointment.new
+      end
+
+      before do
+        person1.appointments << appointment
+        person2.appointments << appointment
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([])
+        expect(person2.appointments).to eq([appointment])
+      end
+    end
+
+    context "when using concat" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment) do
+        Appointment.new
+      end
+
+      before do
+        person1.appointments.concat([appointment])
+        person2.appointments.concat([appointment])
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([])
+        expect(person2.appointments).to eq([appointment])
+      end
+    end
+
+    context "when using =" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment) do
+        Appointment.new
+      end
+
+      let(:apts) { [ appointment ] }
+
+      before do
+        person1.appointments = apts
+        person2.appointments = apts
+        expect(apts).to eq([ appointment ])
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([])
+        expect(person2.appointments).to eq([appointment])
+      end
+    end
+
+    context "when using = on the same document twice" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment1) do
+        Appointment.new
+      end
+
+      let(:appointment2) do
+        Appointment.new
+      end
+
+      let(:apts) { [ appointment1, appointment2 ] }
+
+      before do
+        person1.appointments = apts
+        person1.appointments = person1.appointments.reverse
+        expect(apts).to eq([ appointment1, appointment2  ])
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([ appointment2, appointment1 ])
+      end
+    end
+  end
 end