mongoid 7.2.1 → 9.0.0

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_spec.rb

@@ -1,17 +1,16 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
+require_relative "../has_and_belongs_to_many_models"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
+  config_override :raise_not_found_error, true
 
   around(:each) do |example|
-    original_raise_not_found_error = Mongoid.raise_not_found_error
     original_preferences_association = Person.relations["preferences"]
-    Mongoid.raise_not_found_error = true
     Person.has_and_belongs_to_many :preferences, autosave: true
     example.run
-    Mongoid.raise_not_found_error = original_raise_not_found_error
     Person.relations["preferences"] = original_preferences_association
   end
 
@@ -27,7 +26,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the inverse_of is nil" do
 
         let!(:article) do
-          Article.create
+          Article.create!
         end
 
         context "when the child document is new" do
@@ -48,7 +47,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when the child document is not new" do
 
           let(:preference) do
-            Preference.create
+            Preference.create!
           end
 
           it "does not persist the child document" do
@@ -80,7 +79,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:preference) do
@@ -124,11 +123,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when appending in a parent create block" do
 
           let!(:preference) do
-            Preference.create(name: "testing")
+            Preference.create!(name: "testing")
           end
 
           let!(:person) do
-            Person.create do |doc|
+            Person.create! do |doc|
               doc.preferences << preference
             end
           end
@@ -213,7 +212,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           context "when the child is already persisted" do
 
             let!(:persisted) do
-              Preference.create(name: "testy")
+              Preference.create!(name: "testy")
             end
 
             let(:preference) do
@@ -222,7 +221,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
             before do
               person.preferences.send(method, preference)
-              person.save
+              person.save!
             end
 
             it "adds the documents to the relation" do
@@ -253,7 +252,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           context "when setting via the associated ids" do
 
             let!(:persisted) do
-              Preference.create(name: "testy")
+              Preference.create!(name: "testy")
             end
 
             let(:preference) do
@@ -265,7 +264,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
             end
 
             before do
-              person.save
+              person.save!
             end
 
             it "adds the documents to the relation" do
@@ -293,7 +292,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when the parent is not a new record" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           let(:preference) do
@@ -375,11 +374,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when both sides have been persisted" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           let(:event) do
-            Event.create
+            Event.create!
           end
 
           before do
@@ -428,15 +427,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when the relation also includes a has_many relation" do
 
           let(:artwork) do
-            Artwork.create
+            Artwork.create!
           end
 
           let(:exhibition) do
-            Exhibition.create
+            Exhibition.create!
           end
 
           let(:exhibitor) do
-            Exhibitor.create(exhibition: exhibition)
+            Exhibitor.create!(exhibition: exhibition)
           end
 
           before do
@@ -451,11 +450,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when the relation is self referencing" do
 
           let(:tag_one) do
-            Tag.create(text: "one")
+            Tag.create!(text: "one")
           end
 
           let(:tag_two) do
-            Tag.create(text: "two")
+            Tag.create!(text: "two")
           end
 
           before do
@@ -564,7 +563,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
 
       let(:preference) do
-        Preference.create(name: "one")
+        Preference.create!(name: "one")
       end
 
       before do
@@ -585,7 +584,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the document is persisted" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "does not add the duplicates" do
@@ -656,7 +655,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         end
 
         let!(:preference) do
-          Preference.create
+          Preference.create!
         end
 
         before do
@@ -703,7 +702,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:preference) do
@@ -787,7 +786,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
               expect(person.preferences).to eq([ another_preference ])
             end
 
-            it "persists the relation between another_prefrence and person" do
+            it "persists the relation between another_preference and person" do
               expect(another_preference.people).to eq([ person ])
             end
 
@@ -799,7 +798,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           context "and person is saved" do
 
             before do
-              person.save
+              person.save!
               person.reload
               another_preference.reload
             end
@@ -808,7 +807,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
               expect(person.preferences).to eq([ another_preference ])
             end
 
-            it "persists the relation between another_prefrence and person" do
+            it "persists the relation between another_preference and person" do
               expect(another_preference.people).to eq([ person ])
             end
 
@@ -823,11 +822,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
   describe "when self-referencing" do
     let!(:parent) do
-      Vertex.create
+      Vertex.create!
     end
 
     let!(:child) do
-      Vertex.create(parents: [parent])
+      Vertex.create!(parents: [parent])
     end
 
     before do
@@ -964,7 +963,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           context "when the relation has been loaded" do
 
             let(:person) do
-              Person.create
+              Person.create!
             end
 
             let(:preference) do
@@ -1004,7 +1003,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
             end
 
             let(:person) do
-              Person.create.tap do |p|
+              Person.create!.tap do |p|
                 p.preferences = [ preference ]
               end
             end
@@ -1074,7 +1073,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when the parent is not a new record" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:preference) do
@@ -1112,7 +1111,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           context "when saving the target" do
 
             before do
-              preference.save
+              preference.save!
             end
 
             it "persists the parent keys" do
@@ -1131,13 +1130,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the parent has been persisted" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         context "when the children are persisted" do
 
           let!(:preference) do
-            person.preferences.create(name: "settings")
+            person.preferences.create!(name: "settings")
           end
 
           let!(:relation) do
@@ -1309,7 +1308,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the parent is not a new record" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:preference) do
@@ -1353,11 +1352,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when appending in a parent create block" do
 
         let!(:preference) do
-          Preference.create(name: "testing")
+          Preference.create!(name: "testing")
         end
 
         let!(:person) do
-          Person.create do |doc|
+          Person.create! do |doc|
             doc.preferences.concat([ preference ])
           end
         end
@@ -1442,7 +1441,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when the child is already persisted" do
 
           let!(:persisted) do
-            Preference.create(name: "testy")
+            Preference.create!(name: "testy")
           end
 
           let(:preference) do
@@ -1451,7 +1450,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
           before do
             person.preferences.concat([ preference ])
-            person.save
+            person.save!
           end
 
           it "adds the documents to the relation" do
@@ -1482,7 +1481,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when setting via the associated ids" do
 
           let!(:persisted) do
-            Preference.create(name: "testy")
+            Preference.create!(name: "testy")
           end
 
           let(:preference) do
@@ -1494,7 +1493,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           end
 
           before do
-            person.save
+            person.save!
           end
 
           it "adds the documents to the relation" do
@@ -1522,7 +1521,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:preference) do
@@ -1604,11 +1603,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when both sides have been persisted" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:event) do
-          Event.create
+          Event.create!
         end
 
         before do
@@ -1657,15 +1656,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the relation also includes a has_many relation" do
 
         let(:artwork) do
-          Artwork.create
+          Artwork.create!
         end
 
         let(:exhibition) do
-          Exhibition.create
+          Exhibition.create!
         end
 
         let(:exhibitor) do
-          Exhibitor.create(exhibition: exhibition)
+          Exhibitor.create!(exhibition: exhibition)
         end
 
         before do
@@ -1680,11 +1679,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the relation is self referencing" do
 
         let(:tag_one) do
-          Tag.create(text: "one")
+          Tag.create!(text: "one")
         end
 
         let(:tag_two) do
-          Tag.create(text: "two")
+          Tag.create!(text: "two")
         end
 
         before do
@@ -1735,7 +1734,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#count" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when nothing exists on the relation" do
@@ -1760,7 +1759,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     describe "#any?" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when nothing exists on the relation" do
@@ -1797,7 +1796,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when documents have been persisted" do
 
       let!(:preference) do
-        person.preferences.create(name: "setting")
+        person.preferences.create!(name: "setting")
       end
 
       it "returns the number of persisted documents" do
@@ -1808,12 +1807,12 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when appending to a loaded relation" do
 
       let!(:preference) do
-        person.preferences.create(name: "setting")
+        person.preferences.create!(name: "setting")
       end
 
       before do
         person.preferences.count
-        person.preferences << Preference.create(name: "two")
+        person.preferences << Preference.create!(name: "two")
       end
 
       it "returns the number of persisted documents" do
@@ -1837,7 +1836,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the documents are part of the relation" do
 
         before do
-          Preference.create(person_ids: [ person.id ])
+          Preference.create!(person_ids: [ person.id ])
         end
 
         it "returns the count from the db" do
@@ -1848,7 +1847,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when the documents are not part of the relation" do
 
         before do
-          Preference.create
+          Preference.create!
         end
 
         it "returns the count from the db" do
@@ -1862,7 +1861,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       context "when documents have been persisted" do
 
         let!(:house) do
-          person.houses.create(name: "Wayne Manor")
+          person.houses.create!(name: "Wayne Manor")
         end
 
         it "returns the number of persisted documents" do
@@ -1886,7 +1885,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#any?" do
 
     let(:sandwich) do
-      Sandwich.create
+      Sandwich.create!
     end
 
     context "when nothing exists on the relation" do
@@ -1954,7 +1953,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when documents have been persisted" do
 
       let!(:meat) do
-        sandwich.meats.create
+        sandwich.meats.create!
       end
 
       it "returns true" do
@@ -1975,7 +1974,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
     context "when new documents exist in the database" do
       before do
-        Meat.create(sandwiches: [sandwich])
+        Meat.create!(sandwiches: [sandwich])
       end
 
       it "returns true" do
@@ -1993,15 +1992,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when using string keys" do
 
           let(:agent) do
-            Agent.create(number: "007")
+            Agent.create!(number: "007")
           end
 
           before do
-            agent.accounts.create(name: "testing again")
+            agent.accounts.send(method, name: "test again")
           end
 
           it "does not convert the string key to an object id" do
-            expect(agent.account_ids).to eq([ "testing-again" ])
+            expect(agent.account_ids).to eq([ "test-again" ])
           end
         end
 
@@ -2073,7 +2072,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when validation fails" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the relation is not polymorphic" do
@@ -2087,290 +2086,236 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     end
   end
 
-  describe "#delete" do
-
-    let(:person) do
-      Person.create
-    end
-
-    let(:preference_one) do
-      Preference.create(name: "Testing")
-    end
-
-    let(:preference_two) do
-      Preference.create(name: "Test")
-    end
-
-    before do
-      person.preferences << [ preference_one, preference_two ]
-    end
-
-    context "when the document exists" do
-
-      let!(:deleted) do
-        person.preferences.delete(preference_one)
-      end
-
-      it "removes the document from the relation" do
-        expect(person.preferences).to eq([ preference_two ])
-      end
+  %i[ delete delete_one ].each do |method|
+    describe "\##{method}" do
+      let(:person) { Person.create! }
+      let(:preference_one) { Preference.create!(name: "Testing") }
+      let(:preference_two) { Preference.create!(name: "Test") }
 
-      it "returns the document" do
-        expect(deleted).to eq(preference_one)
-      end
-
-      it "removes the document key from the foreign key" do
-        expect(person.preference_ids).to eq([ preference_two.id ])
-      end
-
-      it "removes the inverse reference" do
-        expect(deleted.reload.people).to be_empty
-      end
-
-      it "removes the base id from the inverse keys" do
-        expect(deleted.reload.person_ids).to be_empty
+      before do
+        person.preferences << [ preference_one, preference_two ]
       end
 
-      context "and person and preferences are reloaded" do
-
-        before do
-          person.reload
-          preference_one.reload
-          preference_two.reload
+      context 'when the document exists' do
+        let!(:deleted) do
+          person.preferences.send(method, preference_one)
         end
 
-        it "nullifies the deleted preference" do
+        it 'removes the document from the relation' do
           expect(person.preferences).to eq([ preference_two ])
         end
 
-        it "retains the ids for one preference" do
-          expect(person.preference_ids).to eq([ preference_two.id ])
+        it 'returns the document' do
+          expect(deleted).to eq(preference_one)
         end
-      end
-    end
-
-    context "when the document does not exist" do
-
-      let!(:deleted) do
-        person.preferences.delete(Preference.new)
-      end
-
-      it "returns nil" do
-        expect(deleted).to be_nil
-      end
-
-      it "does not modify the relation" do
-        expect(person.preferences).to eq([ preference_one, preference_two ])
-      end
-
-      it "does not modify the keys" do
-        expect(person.preference_ids).to eq([ preference_one.id, preference_two.id ])
-      end
-    end
-
-    context "when :dependent => :nullify is set" do
-
-      context "when :inverse_of is set" do
 
-        let(:event) do
-          Event.create
+        it 'removes the document key from the foreign key' do
+          expect(person.preference_ids).to eq([ preference_two.id ])
         end
 
-        before do
-          person.administrated_events << [ event ]
+        it 'removes the inverse reference' do
+          expect(deleted.reload.people).to be_empty
         end
 
-        it "deletes the document" do
-          expect(event.delete).to be true
+        it 'removes the base id from the inverse keys' do
+          expect(deleted.reload.person_ids).to be_empty
         end
-      end
-    end
 
-    context "when the relationships are self referencing" do
-
-      let(:tag_one) do
-        Tag.create(text: "one")
-      end
+        context 'and person and preferences are reloaded' do
+          before do
+            person.reload
+            preference_one.reload
+            preference_two.reload
+          end
 
-      let(:tag_two) do
-        Tag.create(text: "two")
-      end
+          it 'nullifies the deleted preference' do
+            expect(person.preferences).to eq([ preference_two ])
+          end
 
-      before do
-        tag_one.related << tag_two
+          it 'retains the ids for one preference' do
+            expect(person.preference_ids).to eq([ preference_two.id ])
+          end
+        end
       end
 
-      context "when deleting without reloading" do
-
+      context 'when the document does not exist' do
         let!(:deleted) do
-          tag_one.related.delete(tag_two)
-        end
-
-        it "deletes the document from the relation" do
-          expect(tag_one.related).to be_empty
+          person.preferences.send(method, Preference.new)
         end
 
-        it "deletes the foreign key from the relation" do
-          expect(tag_one.related_ids).to be_empty
+        it 'returns nil' do
+          expect(deleted).to be_nil
         end
 
-        it "removes the reference from the inverse" do
-          expect(deleted.related).to be_empty
+        it 'does not modify the relation' do
+          expect(person.preferences).to eq([ preference_one, preference_two ])
         end
 
-        it "removes the foreign keys from the inverse" do
-          expect(deleted.related_ids).to be_empty
+        it 'does not modify the keys' do
+          expect(person.preference_ids).to eq([ preference_one.id, preference_two.id ])
         end
       end
 
-      context "when deleting with reloading" do
-
-        context "when deleting from the front side" do
-
-          let(:reloaded) do
-            tag_one.reload
-          end
-
-          let!(:deleted) do
-            reloaded.related.delete(tag_two)
-          end
+      context 'when :dependent => :nullify is set' do
+        context 'when :inverse_of is set' do
+          let(:event) { Event.create! }
 
-          it "deletes the document from the relation" do
-            expect(reloaded.related).to be_empty
+          before do
+            person.administrated_events << [ event ]
           end
 
-          it "deletes the foreign key from the relation" do
-            expect(reloaded.related_ids).to be_empty
+          it 'deletes the document' do
+            expect(event.delete).to be true
           end
+        end
+      end
 
-          it "removes the reference from the inverse" do
-            expect(deleted.related).to be_empty
-          end
+      context 'when the relationships are self referencing' do
+        let(:tag_one) { Tag.create!(text: "one") }
+        let(:tag_two) { Tag.create!(text: "two") }
 
-          it "removes the foreign keys from the inverse" do
-            expect(deleted.related_ids).to be_empty
-          end
+        before do
+          tag_one.related << tag_two
         end
 
-        context "when deleting from the inverse side" do
-
-          let(:reloaded) do
-            tag_two.reload
-          end
+        context 'when deleting without reloading' do
+          let!(:deleted) { tag_one.related.send(method, tag_two) }
 
-          let!(:deleted) do
-            reloaded.related.delete(tag_one)
+          it 'deletes the document from the relation' do
+            expect(tag_one.related).to be_empty
           end
 
-          it "deletes the document from the relation" do
-            expect(reloaded.related).to be_empty
+          it 'deletes the foreign key from the relation' do
+            expect(tag_one.related_ids).to be_empty
           end
 
-          it "deletes the foreign key from the relation" do
-            expect(reloaded.related_ids).to be_empty
+          it 'removes the reference from the inverse' do
+            expect(deleted.related).to be_empty
           end
 
-          it "removes the foreign keys from the inverse" do
+          it 'removes the foreign keys from the inverse' do
             expect(deleted.related_ids).to be_empty
           end
         end
-      end
-    end
 
-    context "when the association has callbacks" do
+        context 'when deleting with reloading' do
+          context "when deleting from the front side" do
+            let(:reloaded) { tag_one.reload }
+            let!(:deleted) { reloaded.related.send(method, tag_two) }
 
-      let(:post) do
-        Post.new
-      end
+            it 'deletes the document from the relation' do
+              expect(reloaded.related).to be_empty
+            end
 
-      let(:tag) do
-        Tag.new
-      end
+            it 'deletes the foreign key from the relation' do
+              expect(reloaded.related_ids).to be_empty
+            end
 
-      before do
-        post.tags << tag
-      end
+            it 'removes the reference from the inverse' do
+              expect(deleted.related).to be_empty
+            end
 
-      context "when the callback is a before_remove" do
+            it 'removes the foreign keys from the inverse' do
+              expect(deleted.related_ids).to be_empty
+            end
+          end
 
-        context "when there are no errors" do
+          context 'when deleting from the inverse side' do
+            let(:reloaded) { tag_two.reload }
+            let!(:deleted) { reloaded.related.send(method, tag_one) }
 
-          before do
-            post.tags.delete tag
-          end
+            it 'deletes the document from the relation' do
+              expect(reloaded.related).to be_empty
+            end
 
-          it "executes the callback" do
-            expect(post.before_remove_called).to be true
-          end
+            it 'deletes the foreign key from the relation' do
+              expect(reloaded.related_ids).to be_empty
+            end
 
-          it "removes the document from the relation" do
-            expect(post.tags).to be_empty
+            it 'removes the foreign keys from the inverse' do
+              expect(deleted.related_ids).to be_empty
+            end
           end
         end
+      end
 
-        context "when errors are raised" do
-
-          before do
-            expect(post).to receive(:before_remove_tag).and_raise
-            begin; post.tags.delete(tag); rescue; end
-          end
+      context 'when the association has callbacks' do
+        let(:post) { Post.new }
+        let(:tag) { Tag.new }
 
-          it "does not remove the document from the relation" do
-            expect(post.tags).to eq([ tag ])
-          end
+        before do
+          post.tags << tag
         end
-      end
 
-      context "when the callback is an after_remove" do
+        context 'when the callback is a before_remove' do
+          context 'when there are no errors' do
+            before do
+              post.tags.send(method, tag)
+            end
 
-        context "when no errors are raised" do
+            it 'executes the callback' do
+              expect(post.before_remove_called).to be true
+            end
 
-          before do
-            post.tags.delete(tag)
+            it 'removes the document from the relation' do
+              expect(post.tags).to be_empty
+            end
           end
 
-          it "executes the callback" do
-            expect(post.after_remove_called).to be true
-          end
+          context "when errors are raised" do
+            before do
+              expect(post).to receive(:before_remove_tag).and_raise
+              begin; post.tags.send(method, tag); rescue; end
+            end
 
-          it "removes the document from the relation" do
-            expect(post.tags).to be_empty
+            it 'does not remove the document from the relation' do
+              expect(post.tags).to eq([ tag ])
+            end
           end
         end
 
-        context "when errors are raised" do
+        context 'when the callback is an after_remove' do
+          context 'when no errors are raised' do
+            before do
+              post.tags.send(method, tag)
+            end
 
-          before do
-            expect(post).to receive(:after_remove_tag).and_raise
-            begin; post.tags.delete(tag); rescue; end
+            it 'executes the callback' do
+              expect(post.after_remove_called).to be true
+            end
+
+            it 'removes the document from the relation' do
+              expect(post.tags).to be_empty
+            end
           end
 
-          it "removes the document from the relation" do
-            expect(post.tags).to be_empty
+          context 'when errors are raised' do
+            before do
+              expect(post).to receive(:after_remove_tag).and_raise
+              begin; post.tags.send(method, tag); rescue; end
+            end
+
+            it 'removes the document from the relation' do
+              expect(post.tags).to be_empty
+            end
           end
         end
       end
     end
   end
 
-  [ :delete_all, :destroy_all ].each do |method|
-
-    describe "##{method}" do
-
-      context "when the relation is not polymorphic" do
-
-        context "when conditions are provided" do
-
-          let(:person) do
-            Person.create
-          end
+  %i[ delete_all destroy_all ].each do |method|
+    describe "\##{method}" do
+      context 'when the relation is not polymorphic' do
+        context 'when conditions are provided' do
+          let(:person) { Person.create! }
 
           let!(:preference_one) do
-            person.preferences.create(name: "Testing")
+            person.preferences.create!(name: "Testing")
           end
 
           let!(:preference_two) do
-            person.preferences.create(name: "Test")
+            person.preferences.create!(name: "Test")
           end
 
           let!(:deleted) do
@@ -2395,14 +2340,18 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "removes the ids from the foreign key" do
             expect(person.preference_ids).to eq([ preference_two.id ])
           end
+
+          it "sets the association locally" do
+            expect(person.preferences).to eq([preference_two])
+          end
         end
 
         context "when conditions are not provided" do
 
           let(:person) do
-            Person.create.tap do |person|
-              person.preferences.create(name: "Testing")
-              person.preferences.create(name: "Test")
+            Person.create!.tap do |person|
+              person.preferences.create!(name: "Testing")
+              person.preferences.create!(name: "Test")
             end
           end
 
@@ -2421,6 +2370,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "returns the number of documents deleted" do
             expect(deleted).to eq(2)
           end
+
+          it "sets the association locally" do
+            expect(person.preferences).to eq([])
+          end
         end
       end
     end
@@ -2436,13 +2389,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#exists?" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when documents exist in the database" do
 
       before do
-        person.preferences.create
+        person.preferences.create!
       end
 
       it "returns true" do
@@ -2467,23 +2420,23 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the relation is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:preference_one) do
-        person.preferences.create(name: "Test")
+        person.preferences.create!(name: "Test")
       end
 
       let!(:preference_two) do
-        person.preferences.create(name: "OMG I has relations")
+        person.preferences.create!(name: "OMG I has relations")
       end
 
       let!(:unrelated_pref) do
-        Preference.create(name: "orphan annie")
+        Preference.create!(name: "orphan annie")
       end
 
       let!(:unrelated_pref_two) do
-        Preference.create(name: "orphan two")
+        Preference.create!(name: "orphan two")
       end
 
       context "when providing an id" do
@@ -2508,39 +2461,29 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "raises an error" do
             expect {
               preference
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
           end
         end
 
         context "when the id does not match" do
 
           context "when config set to raise error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             it "raises an error" do
               expect {
                 person.preferences.find(BSON::ObjectId.new)
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
             end
           end
 
           context "when config set not to raise error" do
+            config_override :raise_not_found_error, false
 
             let(:preference) do
               person.preferences.find(BSON::ObjectId.new)
             end
 
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
-
             it "returns nil" do
               expect(preference).to be_nil
             end
@@ -2561,7 +2504,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           end
         end
 
-        context "when the ids matche unreferenced documents" do
+        context "when the ids match unreferenced documents" do
 
           let(:preferences) do
             person.preferences.find(
@@ -2572,39 +2515,29 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "raises an error" do
             expect {
               preferences
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
           end
         end
 
         context "when the ids do not match" do
 
           context "when config set to raise error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             it "raises an error" do
               expect {
                 person.preferences.find([ BSON::ObjectId.new ])
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
             end
           end
 
           context "when config set not to raise error" do
+            config_override :raise_not_found_error, false
 
             let(:preferences) do
               person.preferences.find([ BSON::ObjectId.new ])
             end
 
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
-
             it "returns an empty array" do
               expect(preferences).to be_empty
             end
@@ -2619,11 +2552,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the relation is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:preference) do
-        person.preferences.create(name: "Testing")
+        person.preferences.create!(name: "Testing")
       end
 
       context "when the document exists" do
@@ -2659,11 +2592,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the relation is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:preference) do
-        person.preferences.create(name: "Testing")
+        person.preferences.create!(name: "Testing")
       end
 
       context "when the document exists" do
@@ -2708,11 +2641,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the relation is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:preference) do
-        person.preferences.create(name: "Testing")
+        person.preferences.create!(name: "Testing")
       end
 
       context "when the document exists" do
@@ -2746,15 +2679,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#max" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:preference_one) do
-      Preference.create(ranking: 5)
+      Preference.create!(ranking: 5)
     end
 
     let(:preference_two) do
-      Preference.create(ranking: 10)
+      Preference.create!(ranking: 10)
     end
 
     before do
@@ -2775,15 +2708,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#max_by" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:preference_one) do
-      Preference.create(ranking: 5)
+      Preference.create!(ranking: 5)
     end
 
     let(:preference_two) do
-      Preference.create(ranking: 10)
+      Preference.create!(ranking: 10)
     end
 
     before do
@@ -2802,19 +2735,19 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#method_missing" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:preference_one) do
-      person.preferences.create(name: "First", value: "Posting")
+      person.preferences.create!(name: "First", value: "Posting")
     end
 
     let!(:preference_two) do
-      person.preferences.create(name: "Second", value: "Testing")
+      person.preferences.create!(name: "Second", value: "Testing")
     end
 
     let!(:unrelated) do
-      Preference.create(name: "Third")
+      Preference.create!(name: "Third")
     end
 
     context "when providing a single criteria" do
@@ -2828,7 +2761,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
 
       context 'when providing a collation' do
-        min_server_version '3.4'
 
         let(:preferences) do
           person.preferences.where(name: "FIRST").collation(locale: 'en_US', strength: 2).to_a
@@ -2889,7 +2821,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         context "when the inverse relation is not defined" do
 
           let!(:house) do
-            person.houses.create(name: "Wayne Manor")
+            person.houses.create!(name: "Wayne Manor")
           end
 
           it "returns the distinct values for the fields" do
@@ -2903,15 +2835,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#min" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:preference_one) do
-      Preference.create(ranking: 5)
+      Preference.create!(ranking: 5)
     end
 
     let(:preference_two) do
-      Preference.create(ranking: 10)
+      Preference.create!(ranking: 10)
     end
 
     before do
@@ -2932,15 +2864,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#min_by" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:preference_one) do
-      Preference.create(ranking: 5)
+      Preference.create!(ranking: 5)
     end
 
     let(:preference_two) do
-      Preference.create(ranking: 10)
+      Preference.create!(ranking: 10)
     end
 
     before do
@@ -2966,15 +2898,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   describe "#nullify_all" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:preference_one) do
-      person.preferences.create(name: "One")
+      person.preferences.create!(name: "One")
     end
 
     let!(:preference_two) do
-      person.preferences.create(name: "Two")
+      person.preferences.create!(name: "Two")
     end
 
     before do
@@ -3095,13 +3027,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     describe "##{method}" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when documents have been persisted" do
 
         let!(:preference) do
-          person.preferences.create(name: "Testing")
+          person.preferences.create!(name: "Testing")
         end
 
         it "returns the number of documents" do
@@ -3113,7 +3045,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
         before do
           person.preferences.build(name: "Test")
-          person.preferences.create(name: "Test 2")
+          person.preferences.create!(name: "Test 2")
         end
 
         it "returns the total number of documents" do
@@ -3128,15 +3060,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the relation has no default scope" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:preference_one) do
-        person.preferences.create(name: "first")
+        person.preferences.create!(name: "first")
       end
 
       let!(:preference_two) do
-        Preference.create(name: "second")
+        Preference.create!(name: "second")
       end
 
       let(:unscoped) do
@@ -3151,15 +3083,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the relation has a default scope" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:house_one) do
-        person.houses.create(name: "first")
+        person.houses.create!(name: "first")
       end
 
       let!(:house_two) do
-        House.create(name: "second")
+        House.create!(name: "second")
       end
 
       let(:unscoped) do
@@ -3195,10 +3127,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     end
 
     before do
-      person.update_attributes(
+      person.update_attributes!(
           houses: [ wife_house, exwife_house, girlfriend_house ]
       )
-      person.update_attributes(house_ids: [ girlfriend_house.id ])
+      person.update_attributes!(house_ids: [ girlfriend_house.id ])
     end
 
     context "when reloading" do
@@ -3245,7 +3177,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
 
       let!(:business) do
-        Business.create(name: "serious", owners: [ user ])
+        Business.create!(name: "serious", owners: [ user ])
       end
 
       before do
@@ -3288,11 +3220,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the documents are persisted" do
 
       let(:user) do
-        User.create(name: "tst")
+        User.create!(name: "tst")
       end
 
       let(:business) do
-        Business.create(name: "srs", owners: [ user ])
+        Business.create!(name: "srs", owners: [ user ])
       end
 
       before do
@@ -3336,11 +3268,11 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   context "when binding the relation multiple times" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:preference) do
-      person.preferences.create(name: "testing")
+      person.preferences.create!(name: "testing")
     end
 
     before do
@@ -3359,19 +3291,19 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   context "when the association has order criteria" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:preference_one) do
-      OrderedPreference.create(name: 'preference-1', value: 10)
+      OrderedPreference.create!(name: 'preference-1', value: 10)
     end
 
     let(:preference_two) do
-      OrderedPreference.create(name: 'preference-2', value: 20)
+      OrderedPreference.create!(name: 'preference-2', value: 20)
     end
 
     let(:preference_three) do
-      OrderedPreference.create(name: 'preference-3', value: 20)
+      OrderedPreference.create!(name: 'preference-3', value: 20)
     end
 
     before do
@@ -3395,7 +3327,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   context "when the parent is not a new record and freshly loaded" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:preference) do
@@ -3404,7 +3336,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
     before do
       person.preferences = [ preference ]
-      person.save
+      person.save!
       person.reload
       person.preferences = nil
     end
@@ -3427,15 +3359,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   context "when reloading the relation" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:preference_one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     let!(:preference_two) do
-      Preference.create(name: "two")
+      Preference.create!(name: "two")
     end
 
     before do
@@ -3479,7 +3411,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the document is new" do
 
       let!(:person) do
-        Person.create(preference_names: "one, two")
+        Person.create!(preference_names: "one, two")
       end
 
       let(:preference_one) do
@@ -3515,23 +3447,23 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     end
 
     let(:preference_one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     let(:preference_two) do
-      Preference.create(name: "two")
+      Preference.create!(name: "two")
     end
 
     before do
       person.preference_ids = [ preference_one.id, preference_two.id ]
-      person.save
+      person.save!
     end
 
     context "and the order is changed" do
 
       before do
         person.preference_ids = [ preference_two.id, preference_one.id ]
-        person.save
+        person.save!
       end
 
       let(:reloaded) do
@@ -3548,13 +3480,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "and the order is changed and an element is added" do
 
       let(:preference_three) do
-        Preference.create(name: "three")
+        Preference.create!(name: "three")
       end
 
       before do
         person.preference_ids =
             [ preference_two.id, preference_one.id, preference_three.id ]
-        person.save
+        person.save!
       end
 
       let(:reloaded) do
@@ -3571,16 +3503,16 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "and the order is changed and an element is removed" do
 
       let(:preference_three) do
-        Preference.create(name: "three")
+        Preference.create!(name: "three")
       end
 
       before do
         person.preference_ids =
             [ preference_one.id, preference_two.id, preference_three.id ]
-        person.save
+        person.save!
         person.preference_ids =
             [ preference_three.id, preference_two.id ]
-        person.save
+        person.save!
       end
 
       let(:reloaded) do
@@ -3630,15 +3562,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     context "when the relation exists" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:pref_one) do
-        person.preferences.create
+        person.preferences.create!
       end
 
       let!(:pref_two) do
-        Preference.create
+        Preference.create!
       end
 
       before do
@@ -3654,15 +3586,19 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
   context "when using a different primary key" do
 
     let(:dog) do
-      Dog.create(name: 'Doggie')
+      Dog.create!(name: 'Doggie')
     end
 
     let(:cat) do
-      Cat.create(name: 'Kitty')
+      Cat.create!(name: 'Kitty')
+    end
+
+    let(:another_cat) do
+      Cat.create!(name: 'Kitten')
     end
 
     let(:fire_hydrant) do
-      FireHydrant.create(location: '221B Baker Street')
+      FireHydrant.create!(location: '221B Baker Street')
     end
 
     context "when adding to a one-way many to many" do
@@ -3676,6 +3612,28 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
     end
 
+    context "when adding multiple documents to a one-way many to many" do
+
+      before do
+        fire_hydrant.cats.push([cat, another_cat])
+      end
+
+      it "adds the pk values to the fk set" do
+        expect(fire_hydrant.cat_ids).to eq([cat.name, another_cat.name])
+      end
+    end
+
+    context "when adding a new document to a one-way many to many" do
+
+      before do
+        fire_hydrant.cats.build name: 'Kitten'
+      end
+
+      it "adds the pk values to the fk set" do
+        expect(fire_hydrant.cat_ids).to eq(['Kitten'])
+      end
+    end
+
     context "when adding to a two-way many to many" do
 
       before do
@@ -3732,10 +3690,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     end
 
     it "should assign relation from both sides" do
-      p1 = Project.create name: 'Foo'
-      p2 = Project.create name: 'Bar'
-      d1 = Distributor.create name: 'Rock'
-      d2 = Distributor.create name: 'Soul'
+      p1 = Project.create! name: 'Foo'
+      p2 = Project.create! name: 'Bar'
+      d1 = Distributor.create! name: 'Rock'
+      d2 = Distributor.create! name: 'Soul'
 
       p1.distributors << d1
       expect(p1.d_ids).to match_array([d1.id])
@@ -3745,4 +3703,56 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       expect(p2.d_ids).to match_array([d2.id])
     end
   end
+
+  context "when accesing own _id from parent's foreign key in default" do
+    let!(:contract) { HabtmmContract.create! }
+    let!(:signature) { contract.signatures.create! }
+
+    it "is nil" do
+      expect(signature.favorite_signature).to be nil
+    end
+  end
+
+  context "when setting an association on a model that uses the class_name option" do
+    let!(:contract) { HabtmmContract.create! }
+    let!(:signature) { HabtmmSignature.create!(contracts: [contract]) }
+
+    it "populates the inverse foreign key" do
+      expect(signature.contracts.first.signature_ids).to eq([signature.id])
+    end
+  end
+
+  context "when there is a foreign key in the aliased associations" do
+    it "has the correct aliases" do
+      expect(Dog.aliased_associations["breed_ids"]).to eq("breeds")
+      expect(Breed.aliased_associations["dog_ids"]).to eq("dogs")
+    end
+  end
+
+  # This test is for MONGOID-5344 which tests that the initial call to
+  # signature_ids refers to the same array as subsequent calls to signature_ids.
+  # Prior to the change in that ticket, this test broke because the array
+  # returned from write_attribute (which is triggered the first time the
+  # foreign key array is referenced, to set the default), refers to a different
+  # array to the one stored in the attributes hash. This happened because,
+  # when retrieving a document from the database, the attributes hash is actually
+  # a BSON::Document, which applies a transformation to the array before
+  # storing it.
+  context "when executing concat on foreign key array from the db" do
+    before do
+      HabtmmContract.create!
+      HabtmmSignature.create!
+    end
+
+    let!(:contract) { HabtmmContract.first }
+    let!(:signature) { HabtmmSignature.first }
+
+    before do
+      contract.signature_ids.concat([signature.id])
+    end
+
+    it "works on the first attempt" do
+      expect(contract.signature_ids).to eq([signature.id])
+    end
+  end
 end