mongoid 7.2.1 → 9.0.0

data/spec/mongoid/persistable/destroyable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -8,44 +8,75 @@ describe Mongoid::Persistable::Destroyable do
   describe "#destroy" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when destroying a readonly document" do
-
       let(:from_db) do
-        Person.only(:_id).first
+        Person.first.tap(&:readonly!)
       end
 
       it "raises an error" do
+        expect(from_db.readonly?).to be true
         expect {
           from_db.destroy
         }.to raise_error(Mongoid::Errors::ReadonlyDocument)
       end
     end
 
-    context "when removing a root document" do
+    context 'when destroying a document that was not saved' do
+      let(:unsaved_person) { Person.new(id: person.id) }
+
+      before do
+        unsaved_person.destroy
+      end
+
+      it 'deletes the matching document from the database' do
+        expect { person.reload }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Person with id\(s\)/)
+      end
+    end
+
+    context "when destroying a root document" do
 
-      let!(:destroyd) do
+      let!(:destroyed) do
         person.destroy
       end
 
       it "destroys the document from the collection" do
         expect {
           Person.find(person.id)
-        }.to raise_error(Mongoid::Errors::DocumentNotFound)
+        }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Person with id\(s\)/)
       end
 
       it "returns true" do
-        expect(destroyd).to be true
+        expect(destroyed).to be true
       end
 
       it "resets the flagged for destroy flag" do
         expect(person).to_not be_flagged_for_destroy
       end
+
+      context 'when :persist option false' do
+
+        let!(:destroyed) do
+          person.destroy(persist: false)
+        end
+
+        it "does not destroy the document from the collection" do
+          expect(Person.find(person.id)).to eq person
+        end
+
+        it "returns true" do
+          expect(destroyed).to be true
+        end
+
+        it "does not set the flagged for destroy flag" do
+          expect(person).to_not be_flagged_for_destroy
+        end
+      end
     end
 
-    context "when removing an embedded document" do
+    context "when destroying an embedded document" do
 
       let(:address) do
         person.addresses.build(street: "Bond Street")
@@ -73,7 +104,7 @@ describe Mongoid::Persistable::Destroyable do
       context "when the document has been saved" do
 
         before do
-          address.save
+          address.save!
           address.destroy
         end
 
@@ -81,12 +112,59 @@ describe Mongoid::Persistable::Destroyable do
           Person.find(person.id)
         end
 
-        it "removes the object from the parent and database" do
+        it "removes the object from the parent" do
+          expect(person.addresses).to be_empty
+        end
+
+        it "removes the object from the database" do
+          expect(from_db.addresses).to be_empty
+        end
+      end
+
+      context 'when :persist option false' do
+
+        before do
+          address.save!
+          address.destroy(persist: false)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "does not remove the object from the database" do
+          expect(from_db.addresses).to eq [address]
+          expect(from_db.addresses.first).to_not be_flagged_for_destroy
+        end
+      end
+
+      context 'when :suppress option true' do
+
+        before do
+          address.save!
+          address.destroy(suppress: true)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "removes the object from the database" do
           expect(from_db.addresses).to be_empty
         end
       end
 
-      context 'when removing from a list of embedded documents' do
+      context 'when destroying from a list of embedded documents' do
 
         context 'when the embedded documents list is reversed in memory' do
 
@@ -116,16 +194,16 @@ describe Mongoid::Persistable::Destroyable do
       end
     end
 
-    context "when removing deeply embedded documents" do
+    context "when destroying deeply embedded documents" do
 
       context "when the document has been saved" do
 
         let(:address) do
-          person.addresses.create(street: "Bond Street")
+          person.addresses.create!(street: "Bond Street")
         end
 
         let(:location) do
-          address.locations.create(name: "Home")
+          address.locations.create!(name: "Home")
         end
 
         let(:from_db) do
@@ -145,15 +223,95 @@ describe Mongoid::Persistable::Destroyable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(bolt: Bolt.create!)
+          end
+
+          it 'destroys dependent documents' do
+            Bolt.count.should == 1
+            parent.destroy
+            Bolt.count.should == 0
+          end
+        end
+
+        context 'dependent: :destroy_all' do
+          let!(:parent) do
+            Hole.create!(threadlocker: Threadlocker.create!)
+          end
+
+          it 'deletes dependent documents' do
+            Threadlocker.count.should == 1
+            parent.destroy
+            Threadlocker.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(sealer: Sealer.create!)
+          end
+
+          it 'raises an exception' do
+            Sealer.count.should == 1
+            expect { parent.destroy }.to raise_error(Mongoid::Errors::DeleteRestriction)
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'destroys dependent documents' do
+            Nut.count.should == 1
+            parent.destroy
+            Nut.count.should == 0
+          end
+        end
+
+        context 'dependent: :destroy_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'deletes dependent documents' do
+            Washer.count.should == 1
+            parent.destroy
+            Washer.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'raises an exception' do
+            Spacer.count.should == 1
+            expect { parent.destroy }.to raise_error(Mongoid::Errors::DeleteRestriction)
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 
   describe "#destroy!" do
 
-    context "when no validation callback returns false" do
+    let(:person) do
+      Person.create!
+    end
 
-      let(:person) do
-        Person.create
-      end
+    context "when no validation callback returns false" do
 
       it "returns true" do
         expect(person.destroy!).to eq(true)
@@ -163,7 +321,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when a validation callback returns false" do
 
       let(:album) do
-        Album.create
+        Album.create!
       end
 
       before do
@@ -180,12 +338,153 @@ describe Mongoid::Persistable::Destroyable do
         }.to raise_error(Mongoid::Errors::DocumentNotDestroyed)
       end
     end
+
+    context 'when destroying a document that was not saved' do
+      let(:unsaved_person) { Person.new(id: person.id) }
+
+      before do
+        unsaved_person.destroy!
+      end
+
+      it 'deletes the matching document from the database' do
+        expect { person.reload }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Person with id\(s\)/)
+      end
+    end
+
+    context "when destroying a root document" do
+
+      let!(:destroyed) do
+        person.destroy!
+      end
+
+      it "destroys the document from the collection" do
+        expect {
+          Person.find(person.id)
+        }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Person with id\(s\)/)
+      end
+
+      it "returns true" do
+        expect(destroyed).to be true
+      end
+
+      it "resets the flagged for destroy flag" do
+        expect(person).to_not be_flagged_for_destroy
+      end
+
+      context 'when :persist option false' do
+
+        let!(:destroyed) do
+          person.destroy!(persist: false)
+        end
+
+        it "does not destroy the document from the collection" do
+          expect(Person.find(person.id)).to eq person
+        end
+
+        it "returns true" do
+          expect(destroyed).to be true
+        end
+
+        it "does not set the flagged for destroy flag" do
+          expect(person).to_not be_flagged_for_destroy
+        end
+      end
+    end
+
+    context "when destroying an embedded document" do
+
+      let(:address) do
+        person.addresses.build(street: "Bond Street")
+      end
+
+      context "when the document is not yet saved" do
+
+        before do
+          address.destroy!
+        end
+
+        it "removes the document from the parent" do
+          expect(person.addresses).to be_empty
+        end
+
+        it "removes the attributes from the parent" do
+          expect(person.raw_attributes["addresses"]).to be_nil
+        end
+
+        it "resets the flagged for destroy flag" do
+          expect(address).to_not be_flagged_for_destroy
+        end
+      end
+
+      context "when the document has been saved" do
+
+        before do
+          address.save!
+          address.destroy!
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "removes the object from the parent" do
+          expect(person.addresses).to be_empty
+        end
+
+        it "removes the object from the database" do
+          expect(from_db.addresses).to be_empty
+        end
+      end
+
+      context 'when :persist option false' do
+
+        before do
+          address.save!
+          address.destroy!(persist: false)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "does not remove the object from the database" do
+          expect(from_db.addresses).to eq [address]
+          expect(from_db.addresses.first).to_not be_flagged_for_destroy
+        end
+      end
+
+      context 'when :suppress option true' do
+
+        before do
+          address.save!
+          address.destroy!(suppress: true)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "removes the object from the database" do
+          expect(from_db.addresses).to be_empty
+        end
+      end
+    end
   end
 
   describe "#destroy_all" do
 
     let!(:person) do
-      Person.create(title: "sir")
+      Person.create!(title: "sir")
     end
 
     context "when no conditions are provided" do
@@ -206,7 +505,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when conditions are provided" do
 
       let!(:person_two) do
-        Person.create
+        Person.create!
       end
 
       context "when no conditions attribute provided" do
@@ -228,7 +527,7 @@ describe Mongoid::Persistable::Destroyable do
     context 'when the write concern is unacknowledged' do
 
       before do
-        Person.create(title: 'miss')
+        Person.create!(title: 'miss')
       end
 
       let!(:removed) do
@@ -244,7 +543,7 @@ describe Mongoid::Persistable::Destroyable do
       end
     end
 
-    context 'when removing a list of embedded documents' do
+    context 'when destroying a list of embedded documents' do
 
       context 'when the embedded documents list is reversed in memory' do
 
@@ -264,5 +563,91 @@ describe Mongoid::Persistable::Destroyable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Bolt.create!(hole: hole)
+            end
+          end
+
+          it 'destroys dependent documents' do
+            Bolt.count.should == 1
+            Hole.destroy_all
+            Bolt.count.should == 0
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Threadlocker.create!(hole: hole)
+            end
+          end
+
+          it 'deletes dependent documents' do
+            Threadlocker.count.should == 1
+            Hole.destroy_all
+            Threadlocker.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Sealer.create!(hole: hole)
+            end
+          end
+
+          it 'raises an exception' do
+            Sealer.count.should == 1
+            expect { Hole.destroy_all }.to raise_error(Mongoid::Errors::DeleteRestriction)
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'destroys dependent documents' do
+            Nut.count.should == 1
+            Hole.destroy_all
+            Nut.count.should == 0
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'deletes dependent documents' do
+            Washer.count.should == 1
+            Hole.destroy_all
+            Washer.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'raises an exception' do
+            Spacer.count.should == 1
+            expect { Hole.destroy_all }.to raise_error(Mongoid::Errors::DeleteRestriction)
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/incrementable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -45,7 +45,7 @@ describe Mongoid::Persistable::Incrementable do
       end
 
       let(:person) do
-        Person.create(age: 10, score: 100)
+        Person.create!(age: 10, score: 100)
       end
 
       context "when providing string fields" do
@@ -126,11 +126,11 @@ describe Mongoid::Persistable::Incrementable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "test", number: 10, no: 100)
+        person.addresses.create!(street: "test", number: 10, no: 100)
       end
 
       context "when providing string fields" do
@@ -190,19 +190,19 @@ describe Mongoid::Persistable::Incrementable do
       end
 
       let(:survey) do
-        Survey.create
+        Survey.create!
       end
 
       let(:question) do
-        survey.questions.create(content: 'foo')
+        survey.questions.create!(content: 'foo')
       end
 
       let!(:first_answer) do
-        question.answers.create(position: 99)
+        question.answers.create!(position: 99)
       end
 
       let!(:second_answer) do
-        question.answers.create(position: 1)
+        question.answers.create!(position: 1)
       end
 
       context "when providing string fields" do
@@ -228,7 +228,7 @@ describe Mongoid::Persistable::Incrementable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(age: 10, score: 100)
+        Person.create!(age: 10, score: 100)
       end
 
       it "marks a dirty change for the incremented fields" do
@@ -238,5 +238,42 @@ describe Mongoid::Persistable::Incrementable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(age: 10, score: 100)
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "age" => 1, "score" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.inc(age: 15, score: 2)
+          expect(person.age).to eq(25)
+          expect(person.score).to eq(102)
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.inc(age: 15, score: 2)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end