mongoid 7.2.1 → 9.0.0

data/spec/mongoid/touchable_spec_models.rb

@@ -0,0 +1,154 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+module TouchableSpec
+  module Embedded
+    class Building
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      field :title, type: String
+
+      embeds_many :entrances, class_name: "TouchableSpec::Embedded::Entrance"
+      embeds_many :floors, class_name: "TouchableSpec::Embedded::Floor"
+    end
+
+    class Entrance
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      field :last_used_at, type: Time
+      field :level, type: Integer
+
+      embedded_in :building, touch: false, class_name: "TouchableSpec::Embedded::Building"
+
+      embeds_many :keypads, class_name: "TouchableSpec::Embedded::Keypad"
+      embeds_many :cameras, class_name: "TouchableSpec::Embedded::Camera"
+    end
+
+    class Floor
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      field :level, type: Integer
+      field :last_used_at, type: Time
+
+      embedded_in :building, touch: true, class_name: "TouchableSpec::Embedded::Building"
+
+      embeds_many :chairs, class_name: "TouchableSpec::Embedded::Chair"
+      embeds_many :sofas, class_name: "TouchableSpec::Embedded::Sofa"
+    end
+
+    class Keypad
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: false, class_name: "TouchableSpec::Embedded::Entrance"
+    end
+
+    class Camera
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: true, class_name: "TouchableSpec::Embedded::Entrance"
+    end
+
+    class Chair
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: false, class_name: "TouchableSpec::Embedded::Floor"
+    end
+
+    class Sofa
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: true, class_name: "TouchableSpec::Embedded::Floor"
+    end
+  end
+
+  module Referenced
+    class Building
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      has_many :entrances, inverse_of: :building, class_name: "TouchableSpec::Referenced::Entrance"
+      has_many :floors, inverse_of: :building, class_name: "TouchableSpec::Referenced::Floor"
+    end
+
+    class Entrance
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      field :level, type: Integer
+
+      belongs_to :building, touch: false, class_name: "TouchableSpec::Referenced::Building"
+
+      embeds_many :keypads, class_name: "TouchableSpec::Referenced::Keypad"
+      embeds_many :cameras, class_name: "TouchableSpec::Referenced::Camera"
+
+      has_many :plants, class_name: "TouchableSpec::Referenced::Plant"
+      has_many :windows, class_name: "TouchableSpec::Referenced::Window"
+    end
+
+    class Floor
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      field :level, type: Integer
+
+      belongs_to :building, touch: true, class_name: "TouchableSpec::Referenced::Building"
+
+      embeds_many :chairs, class_name: "TouchableSpec::Referenced::Chair"
+      embeds_many :sofas, class_name: "TouchableSpec::Referenced::Sofa"
+
+      has_many :plants, class_name: "TouchableSpec::Referenced::Plant"
+      has_many :windows, class_name: "TouchableSpec::Referenced::Window"
+    end
+
+    class Plant
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      belongs_to :floor, touch: false, class_name: "TouchableSpec::Referenced::Floor"
+      belongs_to :entrance, touch: false, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Window
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      belongs_to :floor, touch: true, class_name: "TouchableSpec::Referenced::Floor"
+      belongs_to :entrance, touch: true, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Keypad
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: false, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Camera
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: true, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Chair
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: false, class_name: "TouchableSpec::Referenced::Floor"
+    end
+
+    class Sofa
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: true, class_name: "TouchableSpec::Referenced::Floor"
+    end
+  end
+end

data/spec/mongoid/traversable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -63,8 +63,72 @@ describe Mongoid::Traversable do
         expect(person._children).to include(address)
       end
 
+      it "does not include embedded documents multiple levels deep" do
+        expect(person._children).not_to include(location)
+      end
+    end
+  end
+
+  describe "#_descendants" do
+
+    let(:person) do
+      Person.new(title: "King")
+    end
+
+    context "with one level of embedding" do
+
+      let(:name) do
+        Name.new(first_name: "Titus")
+      end
+
+      let(:address) do
+        Address.new(street: "Queen St")
+      end
+
+      before do
+        person.name = name
+        person.addresses << address
+      end
+
+      it "includes embeds_one documents" do
+        expect(person._descendants).to include(name)
+      end
+
+      it "includes embeds_many documents" do
+        expect(person._descendants).to include(address)
+      end
+    end
+
+    context "with multiple levels of embedding" do
+
+      let(:name) do
+        Name.new(first_name: "Titus")
+      end
+
+      let(:address) do
+        Address.new(street: "Queen St")
+      end
+
+      let(:location) do
+        Location.new(name: "Work")
+      end
+
+      before do
+        person.name = name
+        address.locations << location
+        person.addresses << address
+      end
+
+      it "includes embeds_one documents" do
+        expect(person._descendants).to include(name)
+      end
+
+      it "includes embeds_many documents" do
+        expect(person._descendants).to include(address)
+      end
+
       it "includes embedded documents multiple levels deep" do
-        expect(person._children).to include(location)
+        expect(person._descendants).to include(location)
       end
     end
   end
@@ -273,13 +337,7 @@ describe Mongoid::Traversable do
     end
 
     context "when the discriminator key is changed at the global level" do
-      before do
-        Mongoid.discriminator_key = "hello"
-      end
-
-      after do
-        Mongoid.discriminator_key = "_type"
-      end
+      config_override :discriminator_key, 'hello'
 
       it "sets the correct value globally" do
         expect(Mongoid.discriminator_key).to eq("hello")
@@ -474,9 +532,9 @@ describe Mongoid::Traversable do
         end
 
         context "before class creation" do
-          before do
-            Mongoid.discriminator_key = "test"
+          config_override :discriminator_key, "test"
 
+          before do
             class PreGlobalDiscriminatorParent
               include Mongoid::Document
             end
@@ -485,10 +543,6 @@ describe Mongoid::Traversable do
             end
           end
 
-          after do
-            Mongoid.discriminator_key = "_type"
-          end
-
           it "creates a field with new discriminator key in the parent" do
             expect(PreGlobalDiscriminatorParent.fields.keys).to include("test")
           end
@@ -620,9 +674,9 @@ describe Mongoid::Traversable do
         end
 
         context "before class creation" do
-          before do
-            Mongoid.discriminator_key = :test
+          config_override :discriminator_key, :test
 
+          before do
             class PreGlobalSymDiscriminatorParent
               include Mongoid::Document
             end
@@ -631,10 +685,6 @@ describe Mongoid::Traversable do
             end
           end
 
-          after do
-            Mongoid.discriminator_key = "_type"
-          end
-
           it "creates a field with new discriminator key as a string in the parent" do
             expect(PreGlobalSymDiscriminatorParent.fields.keys).to include("test")
           end
@@ -772,8 +822,9 @@ describe Mongoid::Traversable do
     end
 
     context "when setting a field equal to discriminator key and duplicate_fields_exception is true" do
+      config_override :duplicate_fields_exception, true
+
       before do
-        Mongoid.duplicate_fields_exception = true
 
         class DuplicateDiscriminatorKeyParent
           include Mongoid::Document
@@ -784,10 +835,6 @@ describe Mongoid::Traversable do
         end
       end
 
-      after do
-        Mongoid.duplicate_fields_exception = false
-      end
-
       it "does not raise an error" do
         expect do
           DuplicateDiscriminatorKeyParent.discriminator_key = "dkey"
@@ -814,9 +861,10 @@ describe Mongoid::Traversable do
     end
 
     context "when setting a field equal to global discriminator key and duplicate_fields_exception is true" do
+      config_override :duplicate_fields_exception, true
+      config_override :discriminator_key, "dkey"
+
       before do
-        Mongoid.duplicate_fields_exception = true
-        Mongoid.discriminator_key = "dkey"
 
         class GlobalDuplicateDiscriminatorKeyParent
           include Mongoid::Document
@@ -826,11 +874,6 @@ describe Mongoid::Traversable do
         end
       end
 
-      after do
-        Mongoid.duplicate_fields_exception = false
-        Mongoid.discriminator_key = "_type"
-      end
-
       it "raises an error" do
         expect do
           GlobalDuplicateDiscriminatorKeyParent.class_eval do
@@ -841,10 +884,9 @@ describe Mongoid::Traversable do
     end
 
     context "when the global discriminator key conflicts with mongoid's internals" do
-
-      after do
-        Mongoid.discriminator_key = "_type"
-      end
+      # This is not an override, it is meant to restore the original value
+      # after the test only.
+      config_override :discriminator_key, '_type'
 
       [:_association, :invalid].each do |meth|
         context "when the field is named #{meth}" do

data/spec/mongoid/validatable/associated_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -76,7 +76,6 @@ describe Mongoid::Validatable::AssociatedValidator do
         end
 
         it "does not run validation on them" do
-          expect(description).to receive(:valid?).never
           expect(user).to be_valid
         end
 
@@ -85,14 +84,14 @@ describe Mongoid::Validatable::AssociatedValidator do
     end
   end
 
-  describe "#validate_each" do
+  describe "#validate" do
 
     let(:person) do
       Person.new
     end
 
     let(:validator) do
-      described_class.new(attributes: person.attributes)
+      described_class.new(attributes: person.relations.keys)
     end
 
     context "when the association is a one to one" do
@@ -100,7 +99,7 @@ describe Mongoid::Validatable::AssociatedValidator do
       context "when the association is nil" do
 
         before do
-          validator.validate_each(person, :name, nil)
+          validator.validate(person)
         end
 
         it "adds no errors" do
@@ -109,14 +108,9 @@ describe Mongoid::Validatable::AssociatedValidator do
       end
 
       context "when the association is valid" do
-
-        let(:associated) do
-          double(valid?: true, flagged_for_destroy?: false)
-        end
-
         before do
-          expect(associated).to receive(:validated?).and_return(false)
-          validator.validate_each(person, :name, associated)
+          person.name = Name.new(first_name: 'A', last_name: 'B')
+          validator.validate(person)
         end
 
         it "adds no errors" do
@@ -126,13 +120,9 @@ describe Mongoid::Validatable::AssociatedValidator do
 
       context "when the association is invalid" do
 
-        let(:associated) do
-          double(valid?: false, flagged_for_destroy?: false)
-        end
-
         before do
-          expect(associated).to receive(:validated?).and_return(false)
-          validator.validate_each(person, :name, associated)
+          person.name = Name.new(first_name: 'Jamis', last_name: 'Buck')
+          validator.validate(person)
         end
 
         it "adds errors to the parent document" do
@@ -150,7 +140,7 @@ describe Mongoid::Validatable::AssociatedValidator do
       context "when the association is empty" do
 
         before do
-          validator.validate_each(person, :addresses, [])
+          validator.validate(person)
         end
 
         it "adds no errors" do
@@ -160,13 +150,9 @@ describe Mongoid::Validatable::AssociatedValidator do
 
       context "when the association has invalid documents" do
 
-        let(:associated) do
-          double(valid?: false, flagged_for_destroy?: false)
-        end
-
         before do
-          expect(associated).to receive(:validated?).and_return(false)
-          validator.validate_each(person, :addresses, [ associated ])
+          person.addresses << Address.new(street: '123')
+          validator.validate(person)
         end
 
         it "adds errors to the parent document" do
@@ -176,13 +162,10 @@ describe Mongoid::Validatable::AssociatedValidator do
 
       context "when the association has all valid documents" do
 
-        let(:associated) do
-          double(valid?: true, flagged_for_destroy?: false)
-        end
-
         before do
-          expect(associated).to receive(:validated?).and_return(false)
-          validator.validate_each(person, :addresses, [ associated ])
+          person.addresses << Address.new(street: '123 First St')
+          person.addresses << Address.new(street: '456 Second St')
+          validator.validate(person)
         end
 
         it "adds no errors" do

data/spec/mongoid/validatable/format_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/validatable/length_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/validatable/numericality_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/validatable/presence_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
+require_relative '../association/referenced/has_one_models'
 
 describe Mongoid::Validatable::PresenceValidator do
 
@@ -239,7 +240,7 @@ describe Mongoid::Validatable::PresenceValidator do
           context "when saving the base" do
 
             before do
-              person.save
+              person.save!
             end
 
             it "saves the relation" do
@@ -250,41 +251,44 @@ describe Mongoid::Validatable::PresenceValidator do
       end
     end
 
-    context "when the relation is a has one and autosave is false" do
+    context "when the association is a has one and autosave is false" do
 
       before do
-        Person.relations["game"].options[:autosave] = false
-        Person.validates :game, presence: true
+        HomCollege.validates :accreditation, presence: true
       end
 
       after do
-        Person.reset_callbacks(:validate)
+        HomCollege.reset_callbacks(:validate)
       end
 
-      it "does not change autosave on the relation" do
-        expect(Person.relations["game"].autosave?).to be false
+      it "does not change autosave on the association" do
+        expect(HomCollege.relations["accreditation"].autosave?).to be false
       end
 
-      context "when the relation is new" do
+      context "when the association target is new" do
 
-        let(:person) do
-          Person.new
+        let(:parent) do
+          HomCollege.new
         end
 
-        context "when the base is valid" do
+        context "when the parent is valid" do
 
-          let!(:game) do
-            person.build_game
+          let!(:child) do
+            parent.build_accreditation
           end
 
-          context "when saving the base" do
+          context "when saving the parent" do
 
             before do
-              person.save
+              parent.associations[:accreditation].options[:autosave].should be_falsy
+
+              parent.save!
             end
 
-            it "does not save the relation" do
-              expect { game.reload }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            it "does not save the association target" do
+              child.persisted?.should be false
+
+              expect { child.reload }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class HomAccreditation with id\(s\)/)
             end
           end
         end
@@ -294,17 +298,17 @@ describe Mongoid::Validatable::PresenceValidator do
     context "when the relation is a belongs to" do
 
       let(:product) do
-        Product.create(name: "testing")
+        Product.create!(name: "testing")
       end
 
       context "when the relation is present" do
 
         let(:purchase) do
-          Purchase.create
+          Purchase.create!
         end
 
         let(:line_item) do
-          purchase.line_items.create(product: product)
+          purchase.line_items.create!(product: product)
         end
 
         context "when the foreign key is nil" do
@@ -334,11 +338,11 @@ describe Mongoid::Validatable::PresenceValidator do
       context "when the relation has documents" do
 
         let!(:house) do
-          House.create
+          House.create!
         end
 
         let!(:person) do
-          Person.create(houses: [ house ])
+          Person.create!(houses: [ house ])
         end
 
         context "when the relation is loaded from the db" do