decidim-core 0.28.6 → 0.29.0.rc1

data/lib/decidim/core/test/factories.rb

@@ -112,7 +112,11 @@ FactoryBot.define do
       create_static_pages { true }
     end
 
-    name { Faker::Company.unique.name }
+    # we do not want machine translation here
+    name do
+      Decidim.available_locales.index_with { |_locale| Faker::Company.unique.name }
+    end
+
     reference_prefix { Faker::Name.suffix }
     time_zone { "UTC" }
     twitter_handler { Faker::Hipster.word }
@@ -137,7 +141,7 @@ FactoryBot.define do
     admin_terms_of_service_body { generate_localized_description(:admin_terms_of_service_body, skip_injection:) }
     force_users_to_authenticate_before_access_organization { false }
     machine_translation_display_priority { "original" }
-    external_domain_whitelist { ["example.org", "twitter.com", "facebook.com", "youtube.com", "github.com", "mytesturl.me"] }
+    external_domain_allowlist { ["example.org", "twitter.com", "facebook.com", "youtube.com", "github.com", "mytesturl.me"] }
     smtp_settings do
       {
         "from" => "test@example.org",
@@ -149,7 +153,18 @@ FactoryBot.define do
     end
     file_upload_settings { Decidim::OrganizationSettings.default(:upload) }
     enable_participatory_space_filters { true }
-    content_security_policy { {} }
+    content_security_policy do
+      {
+        "default-src" => "localhost:* #{host}:*",
+        "script-src" => "localhost:* #{host}:*",
+        "style-src" => "localhost:* #{host}:*",
+        "img-src" => "localhost:* #{host}:*",
+        "font-src" => "localhost:* #{host}:*",
+        "connect-src" => "localhost:* #{host}:*",
+        "frame-src" => "localhost:* #{host}:* www.example.org",
+        "media-src" => "localhost:* #{host}:*"
+      }
+    end
     colors do
       {
         primary: "#e02d2d",
@@ -203,15 +218,8 @@ FactoryBot.define do
     end
 
     trait :deleted do
-      name { "" }
-      nickname { "" }
       email { "" }
-      delete_reason { "I want to delete my account" }
-      admin { false }
       deleted_at { Time.current }
-      avatar { nil }
-      personal_url { "" }
-      about { "" }
     end
 
     trait :admin_terms_accepted do
@@ -429,6 +437,7 @@ FactoryBot.define do
     end
     title { generate_localized_title(:static_page_topic_title, skip_injection:) }
     description { generate_localized_description(:static_page_topic_description, skip_injection:) }
+    show_in_footer { true }
     organization
   end
 
@@ -464,6 +473,11 @@ FactoryBot.define do
       content_type { "application/pdf" }
       file_size { 17_525 }
     end
+
+    trait :with_link do
+      file { nil }
+      link { Faker::Internet.url }
+    end
   end
 
   factory :component, class: "Decidim::Component" do
@@ -1008,25 +1022,4 @@ FactoryBot.define do
         end
     end
   end
-
-  factory :blob, class: "ActiveStorage::Blob" do
-    transient do
-      filepath { Decidim::Dev.asset("city.jpeg") }
-    end
-
-    filename { File.basename(filepath) }
-    content_type { MiniMime.lookup_by_filename(filepath)&.content_type || "text/plain" }
-
-    before(:create) do |object, evaluator|
-      object.upload(File.open(evaluator.filepath))
-    end
-
-    trait :image do
-      filepath { Decidim::Dev.asset("city.jpeg") }
-    end
-
-    trait :document do
-      filepath { Decidim::Dev.asset("Exampledocument.pdf") }
-    end
-  end
 end

data/lib/decidim/core/test/shared_examples/acts_as_author_examples.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-# users of this test should delare the `subject` variable.
+# users of this test should declare the `subject` variable.
 shared_examples "acts as author" do
   describe "presenter" do
     it "returns an instance of the presenter for this author" do

data/lib/decidim/core/test/shared_examples/amendable/withdraw_amendment_examples.rb

@@ -4,7 +4,7 @@ shared_examples "withdraw amendment" do
   context "when current user is the author of the amendment" do
     let(:current_user) { amendment.amender }
 
-    context "and the amendment has no supports" do
+    context "and the amendment has no votes" do
       it "withdraws the amendment" do
         expect { command.call }.to broadcast(:ok)
         expect(amendment.state).to eq("withdrawn")
@@ -12,7 +12,7 @@ shared_examples "withdraw amendment" do
       end
     end
 
-    context "and the amendment has some supports" do
+    context "and the amendment has some votes" do
       before do
         emendation.votes.create!(author: other_user)
       end

data/lib/decidim/core/test/shared_examples/announcements_examples.rb

@@ -12,7 +12,7 @@ shared_examples "manage announcements" do
       ca: "Un avís molt important"
     )
 
-    click_button "Update"
+    click_on "Update"
 
     visit main_component_path(current_component)
 
@@ -46,12 +46,12 @@ shared_examples "manage announcements" do
         ca: "Un avís per a aquesta fase"
       )
 
-      click_button "Update"
+      click_on "Update"
 
       visit main_component_path(current_component)
 
       within page.find("[data-announcement]", match: :first) do
-        expect(page).not_to have_content("An important announcement")
+        expect(page).to have_no_content("An important announcement")
         expect(page).to have_content("An announcement for this step")
       end
     end

data/lib/decidim/core/test/shared_examples/assembly_announcements_examples.rb

@@ -2,7 +2,7 @@
 
 shared_examples "manage assemblies announcements" do
   it "can customize a general announcement for the assembly" do
-    click_link "Configure"
+    click_on "Configure"
 
     fill_in_i18n_editor(
       :assembly_announcement,
@@ -20,14 +20,14 @@ shared_examples "manage assemblies announcements" do
     visit decidim_admin_assemblies.assemblies_path
 
     if defined?(parent_assembly) && !parent_assembly.nil?
-      within find("tr", text: translated(parent_assembly.title)) do
-        click_link "Assemblies"
+      within "tr", text: translated(parent_assembly.title) do
+        click_on "Assemblies"
       end
     end
 
     new_window = window_opened_by do
       within "tr", text: translated(assembly.title) do
-        click_link "Preview"
+        click_on "Preview"
       end
     end
 

data/lib/decidim/core/test/shared_examples/attachable_interface_examples.rb

@@ -10,7 +10,7 @@ shared_examples_for "attachable interface" do
 
     it "includes the attachment urls" do
       attachment_urls = response["attachments"].map { |attachment| attachment["url"] }
-      expect(attachment_urls).to include_blob_urls(*attachments.map(&:file).map(&:blob))
+      expect(attachment_urls).to include(*attachments.map(&:url))
     end
   end
 end

data/lib/decidim/core/test/shared_examples/authorable_interface_examples.rb

@@ -18,7 +18,7 @@ shared_examples_for "authorable interface" do
     end
 
     describe "with a regular user" do
-      let(:author) { create(:user, :confirmed, organization: model.participatory_space.organization) }
+      let(:author) { create(:user, organization: model.participatory_space.organization) }
       let(:query) { "{ author { name } }" }
 
       before do