lighthouse 8.5.1 → 8.6.0-dev.20211016

package/flow-report/test/summary/category-test.tsx

@@ -4,65 +4,114 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import fs from 'fs';
-import {dirname} from 'path';
-import {fileURLToPath} from 'url';
-
+import {FunctionComponent} from 'preact';
 import {render} from '@testing-library/preact';
 
 import {SummaryTooltip} from '../../src/summary/category';
-import {Util} from '../../../report/renderer/util';
+import {flowResult} from '../sample-flow';
+import {I18nProvider} from '../../src/i18n/i18n';
+import {FlowResultContext} from '../../src/util';
+
+let wrapper: FunctionComponent;
 
-const flowResult: LH.FlowResult = JSON.parse(
-  fs.readFileSync(
-    // eslint-disable-next-line max-len
-    `${dirname(fileURLToPath(import.meta.url))}/../../../lighthouse-core/test/fixtures/fraggle-rock/reports/sample-lhrs.json`,
-    'utf-8'
-  )
-);
+beforeEach(() => {
+  // Include sample flowResult for locale in I18nProvider.
+  wrapper = ({children}) => (
+    <FlowResultContext.Provider value={flowResult}>
+      <I18nProvider>
+        {children}
+      </I18nProvider>
+    </FlowResultContext.Provider>
+  );
+});
 
 describe('SummaryTooltip', () => {
   it('renders tooltip with rating', async () => {
-    // Snapshot SEO
-    const reportResult = Util.prepareReportResult(flowResult.steps[2].lhr);
-    const category = reportResult.categories['seo'];
+    const category: any = {
+      id: 'performance',
+      score: 1,
+      auditRefs: [
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+        {result: {score: 0, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+      ],
+    };
 
     const root = render(
-      <SummaryTooltip category={category} gatherMode={reportResult.gatherMode}/>
+      <SummaryTooltip category={category} gatherMode="snapshot"/>,
+      {wrapper}
     );
 
-    const rating = root.getByTestId('SummaryTooltip__rating');
-    expect(rating.classList).toContain('SummaryTooltip__rating--average');
-
-    expect(root.getByText('9 audits passed / 11 audits run')).toBeTruthy();
+    expect(root.getByText('Average')).toBeTruthy();
+    expect(() => root.getByText(/^[0-9]+$/)).toThrow();
+    expect(root.getByText('2 audits passed')).toBeTruthy();
+    expect(root.getByText('3 passable audits')).toBeTruthy();
   });
 
   it('renders tooltip without rating', async () => {
-    // Snapshot performance
-    const reportResult = Util.prepareReportResult(flowResult.steps[2].lhr);
-    const category = reportResult.categories['performance'];
+    const category: any = {
+      id: 'performance',
+      score: 1,
+      auditRefs: [
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 0, group: 'diagnostics'},
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 0, group: 'diagnostics'},
+        {result: {score: 0, scoreDisplayMode: 'binary'}, weight: 0, group: 'diagnostics'},
+      ],
+    };
 
     const root = render(
-      <SummaryTooltip category={category} gatherMode={reportResult.gatherMode}/>
+      <SummaryTooltip category={category} gatherMode="snapshot"/>,
+      {wrapper}
     );
 
-    expect(() => root.getByTestId('SummaryTooltip__rating')).toThrow();
-    expect(root.getByText('2 audits passed / 4 audits run')).toBeTruthy();
+    expect(() => root.getByText(/^(Average|Good|Poor)$/)).toThrow();
+    expect(() => root.getByText(/^[0-9]+$/)).toThrow();
+    expect(root.getByText('2 audits passed')).toBeTruthy();
+    expect(root.getByText('3 passable audits')).toBeTruthy();
   });
 
   it('renders scored category tooltip with score', async () => {
-    // Navigation performance
-    const reportResult = Util.prepareReportResult(flowResult.steps[0].lhr);
-    const category = reportResult.categories['performance'];
+    const category: any = {
+      id: 'performance',
+      score: 1,
+      auditRefs: [
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+        {result: {score: 0, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+      ],
+    };
 
     const root = render(
-      <SummaryTooltip category={category} gatherMode={reportResult.gatherMode}/>
+      <SummaryTooltip category={category} gatherMode="navigation"/>,
+      {wrapper}
     );
 
-    const rating = root.getByTestId('SummaryTooltip__rating');
-    expect(rating.classList).toContain('SummaryTooltip__rating--pass');
-    expect(rating.textContent).toEqual('Good · 94');
+    expect(root.getByText('Good')).toBeTruthy();
+    expect(root.getByText('100')).toBeTruthy();
+    expect(root.getByText('2 audits passed')).toBeTruthy();
+    expect(root.getByText('3 passable audits')).toBeTruthy();
+  });
+
+  it('renders informative audit count if any', async () => {
+    const category: any = {
+      id: 'performance',
+      score: 1,
+      auditRefs: [
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+        {result: {score: 1, scoreDisplayMode: 'binary'}, weight: 1, group: 'diagnostics'},
+        {result: {score: 0, scoreDisplayMode: 'informative'}, weight: 1, group: 'diagnostics'},
+      ],
+    };
+
+    const root = render(
+      <SummaryTooltip category={category} gatherMode="navigation"/>,
+      {wrapper}
+    );
 
-    expect(root.getByText('41 audits passed / 58 audits run')).toBeTruthy();
+    expect(root.getByText('Good')).toBeTruthy();
+    expect(root.getByText('100')).toBeTruthy();
+    expect(root.getByText('2 audits passed')).toBeTruthy();
+    expect(root.getByText('2 passable audits')).toBeTruthy();
+    expect(root.getByText('1 informative audit')).toBeTruthy();
   });
 });

package/flow-report/test/summary/summary-test.tsx

@@ -4,24 +4,14 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import fs from 'fs';
-import {dirname} from 'path';
-import {fileURLToPath} from 'url';
-
 import {render} from '@testing-library/preact';
 import {FunctionComponent} from 'preact';
 
+import {I18nProvider} from '../../src/i18n/i18n';
 import {SummaryHeader, SummaryFlowStep} from '../../src/summary/summary';
 import {FlowResultContext} from '../../src/util';
 import {ReportRendererProvider} from '../../src/wrappers/report-renderer';
-
-const flowResult: LH.FlowResult = JSON.parse(
-  fs.readFileSync(
-    // eslint-disable-next-line max-len
-    `${dirname(fileURLToPath(import.meta.url))}/../../../lighthouse-core/test/fixtures/fraggle-rock/reports/sample-lhrs.json`,
-    'utf-8'
-  )
-);
+import {flowResult} from '../sample-flow';
 
 let wrapper: FunctionComponent;
 
@@ -29,7 +19,9 @@ beforeEach(() => {
   wrapper = ({children}) => (
     <FlowResultContext.Provider value={flowResult}>
       <ReportRendererProvider>
-        {children}
+        <I18nProvider>
+          {children}
+        </I18nProvider>
       </ReportRendererProvider>
     </FlowResultContext.Provider>
   );
@@ -42,7 +34,7 @@ describe('SummaryHeader', () => {
     const lhrCounts = root.getByText(/·/);
     expect(root.getByText('Summary')).toBeTruthy();
     expect(lhrCounts.textContent).toEqual(
-      '2 navigation reports · 1 timespan reports · 1 snapshot reports'
+      '2 navigation reports · 1 timespan report · 1 snapshot report'
     );
   });
 });
@@ -59,7 +51,8 @@ describe('SummaryFlowStep', () => {
 
     expect(root.getByText('Navigation (1)')).toBeTruthy();
 
-    const screenshot = root.getByTestId('SummaryFlowStep__screenshot') as HTMLImageElement;
+    const screenshot =
+      root.getByAltText('Screenshot of a page tested by Lighthouse') as HTMLImageElement;
     expect(screenshot.src).toMatch(/data:image\/jpeg;base64/);
 
     const gauges = root.getAllByTestId('CategoryScore');
@@ -67,6 +60,7 @@ describe('SummaryFlowStep', () => {
 
     const links = root.getAllByRole('link') as HTMLAnchorElement[];
     expect(links.map(a => a.href)).toEqual([
+      'https://www.mikescerealshack.co/',
       'file:///Users/example/report.html/#index=0',
       'file:///Users/example/report.html/#index=0&anchor=performance',
       'file:///Users/example/report.html/#index=0&anchor=accessibility',
@@ -86,8 +80,7 @@ describe('SummaryFlowStep', () => {
 
     expect(root.getByText('Timespan (1)')).toBeTruthy();
 
-    const screenshot = root.getByTestId('SummaryFlowStep__screenshot') as HTMLImageElement;
-    expect(screenshot.src).toBeFalsy();
+    expect(() => root.getByAltText('Screenshot of a page tested by Lighthouse')).toThrow();
 
     // Accessibility and SEO are missing in timespan.
     const nullCategories = root.getAllByTestId('SummaryCategory__null');
@@ -115,7 +108,8 @@ describe('SummaryFlowStep', () => {
 
     expect(root.getByText('Snapshot (1)')).toBeTruthy();
 
-    const screenshot = root.getByTestId('SummaryFlowStep__screenshot') as HTMLImageElement;
+    const screenshot =
+      root.getByAltText('Screenshot of a page tested by Lighthouse') as HTMLImageElement;
     expect(screenshot.src).toMatch(/data:image\/jpeg;base64/);
 
     const gauges = root.getAllByTestId('CategoryScore');

package/flow-report/test/topbar-test.tsx

@@ -0,0 +1,68 @@
+/**
+ * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+import {jest} from '@jest/globals';
+import {FunctionComponent} from 'preact';
+import {act, render} from '@testing-library/preact';
+
+import {Topbar} from '../src/topbar';
+import {FlowResultContext} from '../src/util';
+import {ReportRendererContext} from '../src/wrappers/report-renderer';
+import {I18nProvider} from '../src/i18n/i18n';
+
+const flowResult = {
+  name: 'User flow',
+  steps: [{lhr: {
+    fetchTime: '2021-09-14T22:24:22.462Z',
+    configSettings: {locale: 'en-US'},
+  }}],
+} as any;
+
+let wrapper: FunctionComponent;
+let mockSaveFile = jest.fn();
+
+beforeEach(() => {
+  mockSaveFile = jest.fn();
+  const reportRendererValue: any = {
+    dom: {
+      saveFile: mockSaveFile,
+    },
+  };
+  wrapper = ({children}) => (
+    <FlowResultContext.Provider value={flowResult}>
+      <ReportRendererContext.Provider value={reportRendererValue}>
+        <I18nProvider>
+          {children}
+        </I18nProvider>
+      </ReportRendererContext.Provider>
+    </FlowResultContext.Provider>
+  );
+});
+
+it('save button opens save dialog for HTML file', async () => {
+  const root = render(<Topbar onMenuClick={() => {}}/>, {wrapper});
+
+  const saveButton = root.getByText('Save');
+  saveButton.click();
+
+  expect(mockSaveFile).toHaveBeenCalledWith(
+    expect.any(Blob),
+    'User-flow_2021-09-14_22-24-22'
+  );
+});
+
+it('toggles help dialog', async () => {
+  const root = render(<Topbar onMenuClick={() => {}}/>, {wrapper});
+
+  expect(root.queryByText(/Use Navigation reports to/)).toBeFalsy();
+  const helpButton = root.getByText('Understanding Flows');
+
+  await act(() => helpButton.click());
+  expect(root.getByText(/Use Navigation reports to/)).toBeTruthy();
+
+  await act(() => helpButton.click());
+  expect(root.queryByText(/Use Navigation reports to/)).toBeFalsy();
+});

package/flow-report/test/util-test.tsx

@@ -4,24 +4,13 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import fs from 'fs';
-import {dirname} from 'path';
-import {fileURLToPath} from 'url';
-
 import {jest} from '@jest/globals';
 import {renderHook} from '@testing-library/preact-hooks';
 import {FunctionComponent} from 'preact';
 import {act} from 'preact/test-utils';
 
 import {FlowResultContext, useCurrentLhr} from '../src/util';
-
-const flowResult: LH.FlowResult = JSON.parse(
-  fs.readFileSync(
-    // eslint-disable-next-line max-len
-    `${dirname(fileURLToPath(import.meta.url))}/../../lighthouse-core/test/fixtures/fraggle-rock/reports/sample-lhrs.json`,
-    'utf-8'
-  )
-);
+import {flowResult} from './sample-flow';
 
 let wrapper: FunctionComponent;
 

package/flow-report/tsconfig.json

@@ -14,8 +14,10 @@
   "references": [
     {"path": "../types/lhr/"},
     {"path": "../report"},
+    {"path": "../shared"},
   ],
   "include": [
+    "**/*.js",
     "**/*.ts",
     "**/*.tsx",
     "./types",

package/flow-report/types/flow-report.d.ts

@@ -19,8 +19,9 @@ declare global {
 
   // Expose global types in LH namespace.
   module LH {
-    export type FlowResult = FlowResult_;
     export type ConfigSettings = Settings.ConfigSettings;
+
+    export import FlowResult = FlowResult_;
   }
 }
 

package/jest.config.js

@@ -6,18 +6,6 @@
 'use strict';
 
 module.exports = {
-  collectCoverage: false,
-  coverageReporters: ['none'],
-  collectCoverageFrom: [
-    '**/lighthouse-core/**/*.js',
-    '**/lighthouse-cli/**/*.js',
-    '**/report/**/*.js',
-    '**/lighthouse-viewer/**/*.js',
-  ],
-  coveragePathIgnorePatterns: [
-    '/test/',
-    '/scripts/',
-  ],
   setupFilesAfterEnv: ['./lighthouse-core/test/test-utils.js'],
   testEnvironment: 'node',
   testMatch: [
@@ -26,12 +14,10 @@ module.exports = {
     '**/report/**/*-test.js',
     '**/lighthouse-core/test/fraggle-rock/**/*-test-pptr.js',
     '**/lighthouse-treemap/**/*-test.js',
-    '**/lighthouse-treemap/**/*-test-pptr.js',
     '**/lighthouse-viewer/**/*-test.js',
-    '**/lighthouse-viewer/**/*-test-pptr.js',
     '**/third-party/**/*-test.js',
     '**/clients/test/**/*-test.js',
-    '**/docs/**/*.test.js',
+    '**/shared/**/*-test.js',
   ],
   transform: {},
   prettierPath: null,

package/lighthouse-cli/bin.js

@@ -61,6 +61,11 @@ async function begin() {
     commands.listAudits();
   }
 
+  // Process terminating command
+  if (cliFlags.listLocales) {
+    commands.listLocales();
+  }
+
   // Process terminating command
   if (cliFlags.listTraceCategories) {
     commands.listTraceCategories();

package/lighthouse-cli/cli-flags.js

@@ -12,7 +12,8 @@ import fs from 'fs';
 import yargs from 'yargs';
 import * as yargsHelpers from 'yargs/helpers';
 
-import {isObjectOfUnknownValues} from '../lighthouse-core/lib/type-verifiers.js';
+import {LH_ROOT} from '../root.js';
+import {isObjectOfUnknownValues} from '../shared/type-verifiers.js';
 
 /**
  * @param {string=} manualArgv
@@ -26,6 +27,7 @@ function getFlags(manualArgv, options = {}) {
     yargs(yargsHelpers.hideBin(process.argv));
 
   let parser = y.help('help')
+      .version(JSON.parse(fs.readFileSync(`${LH_ROOT}/package.json`, 'utf-8')).version)
       .showHelpOnFail(false, 'Specify --help for available options')
 
       .usage('lighthouse <url> <options>')
@@ -103,6 +105,11 @@ function getFlags(manualArgv, options = {}) {
           default: false,
           describe: 'Prints a list of all available audits and exits',
         },
+        'list-locales': {
+          type: 'boolean',
+          default: false,
+          describe: 'Prints a list of all supported locales and exits',
+        },
         'list-trace-categories': {
           type: 'boolean',
           default: false,
@@ -208,7 +215,7 @@ function getFlags(manualArgv, options = {}) {
         },
       })
       .group([
-        'save-assets', 'list-all-audits', 'list-trace-categories', 'print-config', 'additional-trace-categories',
+        'save-assets', 'list-all-audits', 'list-locales', 'list-trace-categories', 'print-config', 'additional-trace-categories',
         'config-path', 'preset', 'chrome-flags', 'port', 'hostname', 'form-factor', 'screenEmulation', 'emulatedUserAgent',
         'max-wait-for-load', 'enable-error-reporting', 'gather-mode', 'audit-mode',
         'only-audits', 'only-categories', 'skip-audits', 'budget-path',
@@ -312,7 +319,7 @@ function getFlags(manualArgv, options = {}) {
         //   - We're just printing the config.
         //   - We're in auditMode (and we have artifacts already)
         // If one of these don't apply, if no URL, stop the program and ask for one.
-        const isPrintSomethingMode = argv.listAllAudits || argv.listTraceCategories || argv.printConfig;
+        const isPrintSomethingMode = argv.listAllAudits || argv.listLocales || argv.listTraceCategories || argv.printConfig;
         const isOnlyAuditMode = !!argv.auditMode && !argv.gatherMode;
         if (isPrintSomethingMode || isOnlyAuditMode) {
           return true;

package/lighthouse-cli/commands/commands.js

@@ -7,3 +7,4 @@
 
 export {listAudits} from './list-audits.js';
 export {listTraceCategories} from './list-trace-categories.js';
+export {listLocales} from './list-locales.js';

package/lighthouse-cli/commands/list-locales.js

@@ -0,0 +1,16 @@
+/**
+ * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+'use strict';
+
+import locales from '../../shared/localization/locales.js';
+
+function listLocales() {
+  const localesList = Object.keys(locales);
+  process.stdout.write(JSON.stringify({locales: localesList}, null, 2));
+  process.exit(0);
+}
+
+export {listLocales};

package/lighthouse-cli/run.js

@@ -17,7 +17,7 @@ import open from 'open';
 
 import * as Printer from './printer.js';
 import lighthouse from '../lighthouse-core/index.js';
-import {getFilenamePrefix} from '../report/generator/file-namer.js';
+import {getLhrFilenamePrefix} from '../report/generator/file-namer.js';
 import * as assetSaver from '../lighthouse-core/lib/asset-saver.js';
 import URL from '../lighthouse-core/lib/url-shim.js';
 
@@ -137,7 +137,7 @@ async function saveResults(runnerResult, flags) {
   // Use the output path as the prefix for all generated files.
   // If no output path is set, generate a file prefix using the URL and date.
   const configuredPath = !flags.outputPath || flags.outputPath === 'stdout' ?
-      getFilenamePrefix(lhr) :
+      getLhrFilenamePrefix(lhr) :
       flags.outputPath.replace(/\.\w{2,4}$/, '');
   const resolvedPath = path.resolve(cwd, configuredPath);
 

package/lighthouse-cli/test/smokehouse/report-assert.js

@@ -200,26 +200,42 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) {
           JSON.stringify(value, null, 2),
           `Actual Chromium version: ${getChromeVersion()}`,
         ].join(' '));
-        delete obj[key];
+        if (Array.isArray(obj)) {
+          obj.splice(Number(key), 1);
+        } else {
+          delete obj[key];
+        }
       } else if (value._legacyOnly && isFraggleRock) {
         localConsole.log([
           `[${key}] marked legacy only but run is Fraggle Rock, pruning expectation:`,
           JSON.stringify(value, null, 2),
         ].join(' '));
-        delete obj[key];
+        if (Array.isArray(obj)) {
+          obj.splice(Number(key), 1);
+        } else {
+          delete obj[key];
+        }
       } else if (value._fraggleRockOnly && !isFraggleRock) {
         localConsole.log([
           `[${key}] marked Fraggle Rock only but run is legacy, pruning expectation:`,
           JSON.stringify(value, null, 2),
           `Actual channel: ${lhr.configSettings.channel}`,
         ].join(' '));
-        delete obj[key];
+        if (Array.isArray(obj)) {
+          obj.splice(Number(key), 1);
+        } else {
+          delete obj[key];
+        }
       } else if (value._skipInBundled && !isBundled) {
         localConsole.log([
           `[${key}] marked as skip in bundled and runner is bundled, pruning expectation:`,
           JSON.stringify(value, null, 2),
         ].join(' '));
-        delete obj[key];
+        if (Array.isArray(obj)) {
+          obj.splice(Number(key), 1);
+        } else {
+          delete obj[key];
+        }
       } else {
         pruneRecursively(value);
       }

package/lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js

@@ -115,11 +115,12 @@ class UnusedBytes extends Audit {
       settings,
     };
     const networkRecords = await NetworkRecords.request(devtoolsLog, context);
+    const hasContentfulRecords = networkRecords.some(record => record.transferSize);
 
     // Requesting load simulator requires non-empty network records.
     // Timespans are not guaranteed to have any network activity.
     // There are no bytes to be saved if no bytes were downloaded, so mark N/A if empty.
-    if (!networkRecords.length && gatherContext.gatherMode === 'timespan') {
+    if (!hasContentfulRecords && gatherContext.gatherMode === 'timespan') {
       return {
         score: 1,
         notApplicable: true,

package/lighthouse-core/audits/byte-efficiency/unused-javascript.js

@@ -128,7 +128,7 @@ class UnusedJavaScript extends ByteEfficiencyAudit {
           })
           .filter(d => d.unused >= bundleSourceUnusedThreshold);
 
-        const commonSourcePrefix = commonPrefix([...bundle.map._sourceInfos.keys()]);
+        const commonSourcePrefix = commonPrefix([...bundle.map.sourceInfos.keys()]);
         item.subItems = {
           type: 'subitems',
           items: topUnusedSourceSizes.map(({source, unused, total}) => {

package/lighthouse-core/audits/seo/crawlable-anchors.js

@@ -31,7 +31,7 @@ class CrawlableAnchors extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['AnchorElements'],
+      requiredArtifacts: ['AnchorElements', 'URL'],
     };
   }
 
@@ -39,15 +39,12 @@ class CrawlableAnchors extends Audit {
    * @param {LH.Artifacts} artifacts
    * @return {LH.Audit.Product}
    */
-  static audit({AnchorElements: anchorElements}) {
+  static audit({AnchorElements: anchorElements, URL: url}) {
     const failingAnchors = anchorElements.filter(({
       rawHref,
-      listeners = [],
-      onclick = '',
       name = '',
       role = '',
     }) => {
-      onclick = onclick.replace( /\s/g, '');
       rawHref = rawHref.replace( /\s/g, '');
       name = name.trim();
       role = role.trim();
@@ -56,19 +53,20 @@ class CrawlableAnchors extends Audit {
       // Ignore mailto links even if they use one of the failing patterns. See https://github.com/GoogleChrome/lighthouse/issues/11443#issuecomment-694898412
       if (rawHref.startsWith('mailto:')) return;
 
-      const windowLocationRegExp = /window\.location=/;
-      const windowOpenRegExp = /window\.open\(/;
       const javaScriptVoidRegExp = /javascript:void(\(|)0(\)|)/;
 
       if (rawHref.startsWith('file:')) return true;
-      if (windowLocationRegExp.test(onclick)) return true;
-      if (windowOpenRegExp.test(onclick)) return true;
-
-      const hasClickHandler = listeners.some(({type}) => type === 'click');
-      if (hasClickHandler || name.length > 0) return;
+      if (name.length > 0) return;
 
       if (rawHref === '') return true;
       if (javaScriptVoidRegExp.test(rawHref)) return true;
+
+      // checking if rawHref is a valid
+      try {
+        new URL(rawHref, url.finalUrl);
+      } catch (e) {
+        return true;
+      }
     });
 
     /** @type {LH.Audit.Details.Table['headings']} */

package/lighthouse-core/computed/js-bundles.js

@@ -29,8 +29,7 @@ function computeGeneratedFileSizes(map, content) {
     const source = mapping.sourceURL;
     const lineNum = mapping.lineNumber;
     const colNum = mapping.columnNumber;
-    // @ts-expect-error: `lastColumnNumber` is not on types yet. This will eventually be added to CDT.
-    const lastColNum = /** @type {number=} */ (mapping.lastColumnNumber);
+    const lastColNum = mapping.lastColumnNumber;
 
     // Webpack sometimes emits null mappings.
     // https://github.com/mozilla/source-map/pull/303

package/lighthouse-core/computed/unused-javascript-summary.js

@@ -127,9 +127,9 @@ class UnusedJavascriptSummary {
       let offset = lineOffsets[mapping.lineNumber];
 
       offset += mapping.columnNumber;
-      const lastColumnOfMapping =
-        // @ts-expect-error: We will upstream lastColumnNumber to CDT eventually.
-        (mapping.lastColumnNumber - 1) || lineLengths[mapping.lineNumber];
+      const lastColumnOfMapping = mapping.lastColumnNumber !== undefined ?
+        mapping.lastColumnNumber - 1 :
+        lineLengths[mapping.lineNumber];
       for (let i = mapping.columnNumber; i <= lastColumnOfMapping; i++) {
         if (wasteData.every(data => data.unusedByIndex[offset] === 1)) {
           const key = mapping.sourceURL || '(unmapped)';

package/lighthouse-core/config/config-helpers.js

@@ -283,6 +283,7 @@ function resolveSettings(settingsJson = {}, overrides = undefined) {
   // If a locale is requested in flags or settings, use it. A typical CLI run will not have one,
   // however `lookupLocale` will always determine which of our supported locales to use (falling
   // back if necessary).
+  // TODO: could do more work to sniff out the user's locale
   const locale = i18n.lookupLocale((overrides && overrides.locale) || settingsJson.locale);
 
   // Fill in missing settings with defaults