lighthouse 8.5.1 → 8.6.0-dev.20211016

package/third-party/chromium-synchronization/inspector-issueAdded-types-test.js

@@ -7,7 +7,7 @@
 
 const fs = require('fs');
 const fetch = require('node-fetch');
-const {LH_ROOT} = require('../../../root.js');
+const {LH_ROOT} = require('../../root.js');
 
 const inspectorIssuesGathererPath = LH_ROOT +
   '/lighthouse-core/gather/gatherers/inspector-issues.js';
@@ -31,7 +31,8 @@ describe('issueAdded types', () => {
       .sort();
   });
 
-  it('should notify us if something changed', () => {
+  // TODO: https://github.com/GoogleChrome/lighthouse/issues/13147
+  it.skip('should notify us if something changed', () => {
     expect(inspectorIssueDetailsTypes).toMatchInlineSnapshot(`
       Array [
         "blockedByResponseIssueDetails",
@@ -44,7 +45,8 @@ describe('issueAdded types', () => {
     `);
   });
 
-  it('are each handled explicitly in the gatherer', () => {
+  // TODO: https://github.com/GoogleChrome/lighthouse/issues/13147
+  it.skip('are each handled explicitly in the gatherer', () => {
     // Regex relies on the typecasts
     const sourceTypeMatches = inspectorIssuesGathererSource.matchAll(
       /LH\.Crdp\.Audits\.(.*?Details)>/g

package/third-party/chromium-synchronization/installability-errors-test.js

@@ -74,7 +74,8 @@ Array [
 `);
   });
 
-  it('are each handled explicitly in the gatherer', () => {
+  // TODO: https://github.com/GoogleChrome/lighthouse/issues/13147
+  it.skip('are each handled explicitly in the gatherer', () => {
     const errorStrings = Object.keys(InstallableManifestAudit.UIStrings)
       .filter(key => chromiumErrorIds.includes(key))
       .sort();

package/tsconfig-all.json

@@ -9,6 +9,7 @@
     {"path": "./lighthouse-viewer/"},
     {"path": "./lighthouse-treemap/"},
     {"path": "./flow-report/"},
+    {"path": "./shared/"},
   ],
   "files": [],
   "include": [],

package/tsconfig-base.json

@@ -19,6 +19,6 @@
 
     // "listFiles": true,
     // "noErrorTruncation": true,
-    "extendedDiagnostics": true,
+    // "extendedDiagnostics": true,
   },
 }

package/tsconfig.json

@@ -10,6 +10,7 @@
     {"path": "./types/lhr/"},
     {"path": "./report/"},
     {"path": "./report/generator/"},
+    {"path": "./shared/"},
   ],
   "include": [
     "root.js",
@@ -22,13 +23,13 @@
 
     // TODO(esmodules): JSON files included via resolveJsonModule. Removable on the switch to ES Modules.
     "package.json",
-    "lighthouse-core/lib/i18n/locales/en-US.json",
     "lighthouse-core/test/results/sample_v2.json",
     "lighthouse-core/lib/sd-validation/assets/*.json",
     "lighthouse-core/test/fixtures/unresolved-perflog.json",
     "lighthouse-core/test/fixtures/traces/lcp-m78.devtools.log.json",
     "third-party/snyk/snapshot.json",
     "lighthouse-core/audits/byte-efficiency/polyfill-graph-data.json",
+    "shared/localization/locales/en-US.json",
   ],
   "exclude": [
     "lighthouse-core/test/audits/**/*.js",
@@ -79,8 +80,6 @@
     "lighthouse-core/test/lib/dependency-graph/simulator/simulator-test.js",
     "lighthouse-core/test/lib/emulation-test.js",
     "lighthouse-core/test/lib/i18n/i18n-test.js",
-    "lighthouse-core/test/lib/i18n/locales-test.js",
-    "lighthouse-core/test/lib/i18n/swap-locale-test.js",
     "lighthouse-core/test/lib/icons-test.js",
     "lighthouse-core/test/lib/lh-element-test.js",
     "lighthouse-core/test/lib/manifest-parser-test.js",

package/types/config.d.ts

@@ -134,6 +134,7 @@ declare module Config {
     auditRefs: AuditRefJson[];
     description?: string | IcuMessage;
     manualDescription?: string | IcuMessage;
+    supportedModes?:  Gatherer.GatherMode[];
   }
 
   interface GroupJson {

package/types/es-main.d.ts

@@ -0,0 +1,18 @@
+/**
+ * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+/**
+ * @fileoverview Types for the `es-main` npm module.
+ */
+
+/**
+ * Test if an ES module is run directly with Node.js.
+ * @param importMeta `import.meta` 
+ */
+declare function esMain(importMeta: ImportMeta): boolean;
+declare module 'es-main' {
+  export = esMain;
+}

package/types/externs.d.ts

@@ -155,6 +155,8 @@ export interface CliFlags extends Flags {
   enableErrorReporting?: boolean;
   /** Flag to print a list of all audits + categories. */
   listAllAudits: boolean;
+  /** Flag to print a list of all supported locales. */
+  listLocales: boolean;
   /** Flag to print a list of all required trace categories. */
   listTraceCategories: boolean;
   /** A preset audit of selected audit categories to run. */

package/types/lhr/flow.d.ts

@@ -11,6 +11,11 @@ declare module FlowResult {
     lhr: Result;
     name: string;
   }
+
+  interface LhrRef {
+    value: Result;
+    index: number;
+  }
 }
 
 /**
@@ -19,6 +24,8 @@ declare module FlowResult {
 interface FlowResult {
   /** Ordered list of flow steps, each corresponding to a navigation, timespan, or snapshot. */
   steps: FlowResult.Step[];
+  /** Name given to this user flow. */
+  name: string;
 }
 
 export default FlowResult;

package/types/lhr/i18n.d.ts

@@ -4,9 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-// TODO(bckenny): i18n types should not be necessary for the LHR, but too difficult
-// to unravel from audit-details right now.
-
 export type IcuMessage = {
   // NOTE: `i18nId` rather than just `id` to make tsc typing easier (vs type branding which won't survive JSON roundtrip).
   /** The id locating this message in the locale message json files. */